Hi,
On Thu, 14 Jul 2016 11:47:52 +0200 Philipp Zabel wrote:
> Hi Lothar,
>
> Am Dienstag, den 12.07.2016, 18:50 +0200 schrieb Philipp Zabel:
> > From: Lothar WaÃmann
> >
> > The 'de-active' and 'pixelclk-active' DT properties are evaluated
> > by of_parse_display_timing() called from of_get_d
Hi,
On Tue, 16 Aug 2016 13:41:20 +0200 Lucas Stach wrote:
> Hi Lothar,
>
> Am Dienstag, den 16.08.2016, 13:12 +0200 schrieb Lothar WaÃmann:
> > Describe the new parameter 'bus_flags' to of_get_drm_display_mode() in
> > the kerneldoc comments and add kerneldoc comments to the new function
> > drm
Describe the new parameter 'bus_flags' to of_get_drm_display_mode() in
the kerneldoc comments and add kerneldoc comments to the new function
drm_bus_flags_from_videomode().
Signed-off-by: Lothar WaÃmann
---
drivers/gpu/drm/drm_modes.c | 10 ++
1 file changed, 10 insertions(+)
diff --gi
Describe the new parameter 'bus_flags' to of_get_drm_display_mode() in
the kerneldoc comments and add kerneldoc comments to the new function
drm_bus_flags_from_videomode().
Signed-off-by: Lothar WaÃmann
---
Changes vs. v1:
- added missing characters
drivers/gpu/drm/drm_modes.c | 10 +
> + __drm_atomic_helper_crtc_destroy_state(crtc->state);
> +
> + kfree(to_lcdif_crtc_state(crtc->state));
>
If crtc-state can be NULL at this point, this will only work as long as
'base' is the first member of the lcdif_crtc_state struct (which
currently is the case, but there is no guarantee that this will always
be this way), otherwise the if clause above is not needed.
Lothar Waßmann
0 {
> vddcore-supply = <&ldo8_reg>;
> vddio-supply = <&ldo10_reg>;
> + samsung,burst-clock-frequency = <5>;
> + samsung,esc-clock-frequency = <2000>;
> samsung,pll-clock-frequency = <2400>;
> status = "okay";
>
Lothar Waßmann
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi,
the commit 503fe87bd0a8 ("gpu: ipu-v3: Fix imx-ipuv3-crtc module autoloading")
indeed fixes the autoloading issue, but completely breaks the driver in
non-modular mode (at least with the parallel-display driver I didn't
yet check with the imx-ldb driver.
Can anyone confirm that the imx-drm dri
Hi,
On Fri, 13 May 2016 13:04:12 +0200 Philipp Zabel wrote:
> Hi Lothar,
>
> Am Freitag, den 13.05.2016, 12:33 +0200 schrieb Lothar WaÃmann:
> > Hi,
> >
> > the commit 503fe87bd0a8 ("gpu: ipu-v3: Fix imx-ipuv3-crtc module
> > autoloading")
> > indeed fixes the autoloading issue, but completely
Hi,
On Wed, 18 May 2016 14:56:40 +0200 Philipp Zabel wrote:
> The component master driver imx-drm-core matches component devices using
> their of_node. Since commit 950b410dd1ab ("gpu: ipu-v3: Fix imx-ipuv3-crtc
> module autoloading"), the imx-ipuv3-crtc dev->of_node is not set during
> probing. B
This patch allows to select a specific video mode from a list of modes
defined in DT by setting the 'native-mode' property appropriately.
This change does not affect the behaviour of existing platforms, since
they either:
- have just one display-timings subnode
- have the native-mode propert
The 'mode_valid' flag is never set in this driver. Remove it and the
code that depends on it.
Signed-off-by: Lothar WaÃmann
---
drivers/gpu/drm/imx/parallel-display.c | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/gpu/drm/imx/parallel-display.c
b/drivers/gpu/drm/imx/p
Currently these flags are lost in the call
drm_display_mode_from_videomode()
Signed-off-by: Lothar WaÃmann
---
drivers/gpu/drm/imx/imx-drm-core.c | 12 +++
drivers/gpu/drm/imx/imx-drm.h | 7 ---
drivers/gpu/drm/imx/imx-ldb.c | 37 ++
The 'de-active' and 'pixelclk-active' DT properties are evaluated
by of_parse_display_timing() called from of_get_drm_display_mode(),
but later lost in the conversion from videomode.flags to
drm_display_mode.flags.
Use an open coded version of of_get_drm_display_mode() to get access
to these flags
The 'mode_valid' flag is never set in this driver. Remove it and the
code that depends on it.
Signed-off-by: Lothar WaÃmann
---
drivers/gpu/drm/imx/parallel-display.c | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/gpu/drm/imx/parallel-display.c
b/drivers/gpu/drm/imx/p
Currently these flags are lost in the call
drm_display_mode_from_videomode()
Signed-off-by: Lothar WaÃmann
---
drivers/gpu/drm/imx/imx-ldb.c | 37 ++
drivers/gpu/drm/imx/parallel-display.c | 31
2 files changed, 56 insertions
This patch allows to select a specific video mode from a list of modes
defined in DT by setting the 'native-mode' property appropriately.
This change does not affect the behaviour of existing platforms, since
they either:
- have just one display-timings subnode
- have the native-mode propert
The 'de-active' and 'pixelclk-active' DT properties are evaluated
by of_parse_display_timing() called from of_get_drm_display_mode(),
but later lost in the conversion from videomode.flags to
drm_display_mode.flags.
Use an open coded version of of_get_drm_display_mode() to get access
to these flags
Hi,
On Tue, 24 May 2016 16:16:40 +0200 Philipp Zabel wrote:
> Hi Lothar,
>
> thank you for rebasing. I have applied the other two patches.
> With this one, I'd like to avoid the duplicated code. See below:
>
> Am Dienstag, den 24.05.2016, 08:31 +0200 schrieb Lothar WaÃmann:
> > Currently these
The 'de-active' and 'pixelclk-active' DT properties are evaluated
by of_parse_display_timing() called from of_get_drm_display_mode(),
but later lost in the conversion from videomode.flags to
drm_display_mode.flags.
Use an open coded version of of_get_drm_display_mode() to get access
to these flags
Hi,
On Wed, 25 May 2016 15:18:16 +0200 Lothar WaÃmann wrote:
> The 'de-active' and 'pixelclk-active' DT properties are evaluated
> by of_parse_display_timing() called from of_get_drm_display_mode(),
> but later lost in the conversion from videomode.flags to
> drm_display_mode.flags.
> Use an ope
of_get_drm_display_mode() may fail. Check its return code and bail out
on error.
Signed-off-by: Lothar WaÃmann
---
drivers/gpu/drm/imx/parallel-display.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imx/parallel-display.c
b/drivers/gpu/drm/imx/para
The 'de-active' and 'pixelclk-active' DT properties are evaluated
by of_parse_display_timing() called from of_get_drm_display_mode(),
but later lost in the conversion from videomode.flags to
drm_display_mode.flags.
Enhance of_get_drm_display_mode() to also return the bus flags in a
separate variab
The 'de-active' and 'pixelclk-active' DT properties are evaluated
by of_parse_display_timing() called from of_get_drm_display_mode(),
but later lost in the conversion from videomode.flags to
drm_display_mode.flags.
Changes vs. v3:
- split the patch as suggested by Daniel Vetter
Changes vs. v2
add a helper function to extract information about pixel clock and DE
polarity from DT for use by of_get_drm_display_mode().
While at it, convert spaces to tabs in indentation in drm_modes.h.
Signed-off-by: Lothar WaÃmann
---
drivers/gpu/drm/drm_modes.c | 15 +++
include/drm/drm_mod
The first two patches of this patchset simplify the definition of
display modes in the driver and make it less error prone.
Patch 3 & 4 add support for overriding certain settings defined in the
panel definitions via DT entries to match up HW interfacing variants.
The remaining patches add suppor
open coded repeating the same
parameters multiple times into the macro expansion.
Signed-off-by: Lothar Waßmann
---
drivers/gpu/drm/panel/panel-simple.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c
b/drivers/gpu/drm/panel/panel-simple.c
Signed-off-by: Lothar Waßmann
---
.../bindings/display/panel/edt,et0350g0dh6.txt| 7 +++
drivers/gpu/drm/panel/panel-simple.c | 19 +++
2 files changed, 26 insertions(+)
create mode 100644
Documentation/devicetree/bindings/display/panel/edt
to handle certain quirks of the LCD interface to the
panel driver to be able to override the bus format specified in a
panel's display_mode.
Signed-off-by: Lothar Waßmann
---
.../bindings/display/panel/simple-panel.txt| 2 ++
drivers/gpu/drm/panel/panel-simple.c
Use the newly defined macro to generate the display_mode data entries
for all panels. This reduces the code size significantly and makes the
code more readable.
Signed-off-by: Lothar Waßmann
---
drivers/gpu/drm/panel/panel-simple.c | 799 ++-
1 file changed, 134
This adds support for the Emerging Display Technologies Corporation
10.1" WXGA LVDS panel ET1010G0DSA (without a touch panel) and
ETML1010G0DKA (with capacitive touch panel).
Signed-off-by: Lothar Waßmann
---
.../bindings/display/panel/edt,et1010g0dsa.txt | 7 +++
.../bindings/di
This panel is the same as ETM0700g0DH6 with an inverted pixel clock.
Signed-off-by: Lothar Waßmann
---
.../bindings/display/panel/edt,etm0700g0edh6.txt | 9 +
drivers/gpu/drm/panel/panel-simple.c | 15 +++
2 files changed, 24 insertions
The Ka-Ro electronics MB7 baseboard has an on-board LCD->LVDS
converter that requires a fixed pixelclk polarity, no matter what the
panel's display_mode specifies. Add an option to override the pixelclk
polarity defined in the panel's display_mode via DTB.
Signed-off-by: L
Signed-off-by: Lothar Waßmann
---
.../bindings/display/panel/edt,et0430g0dh6.txt| 7 +++
drivers/gpu/drm/panel/panel-simple.c | 19 +++
2 files changed, 26 insertions(+)
create mode 100644
Documentation/devicetree/bindings/display/panel/edt
Signed-off-by: Lothar Waßmann
---
.../bindings/display/panel/nlt,nl12880bc20.txt | 14 +++
drivers/gpu/drm/panel/panel-simple.c | 45 ++
2 files changed, 59 insertions(+)
create mode 100644
Documentation/devicetree/bindings/display/panel/nlt
vga_set_default_device(pdev);
> > + break;
> > + }
> > + }
> > + }
> > +
> > + if (!vga_default_device()) {
> > + vgadev = list_first_entry_or_null(&vga_list,
> > + struct vga_device, list);
> > + if (vgadev) {
> > + struct device *dev = &vgadev->pdev->dev;
> > + vgaarb_info(dev, "setting as boot device (VGA legacy
> > resources not available)\n");
> > + vga_set_default_device(pdev);
>
> Isn't 'pdev' NULL here? shouldn't it be vgadev->pdev instead?
>
That cannot not happen, though it isn't quite obvious.
'vgadev' will only be non-NULL, when the vga_list isn't empty and in
that case pdev has been set up in the list_for_each_entry() loop above.
Lothar Waßmann
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi,
On Mon, 16 Oct 2017 17:13:29 -0500 Rob Herring wrote:
> On Wed, Oct 11, 2017 at 6:23 AM, Lothar Waßmann
> wrote:
> > The Ka-Ro electronics MB7 baseboard has an on-board LCD->LVDS
> > converter that requires a fixed pixelclk polarity, no matter what the
> > pan
Hi,
On Tue, 17 Oct 2017 14:08:18 +0200 Thierry Reding wrote:
> On Wed, Oct 11, 2017 at 01:23:33PM +0200, Lothar Waßmann wrote:
> > Create a macro that eases the definition of display mode parameters by
> > accecpting the parameters:
> > freq, hactive, hfront-porch,
Hi,
On Tue, 17 Oct 2017 14:14:22 +0200 Thierry Reding wrote:
> On Wed, Oct 11, 2017 at 01:23:36PM +0200, Lothar Waßmann wrote:
> > The Ka-Ro electronics MB7 baseboard has an on-board LCD->LVDS
> > converter that requires a fixed pixelclk polarity, no matter what the
> &
Hi,
On Tue, 17 Oct 2017 14:12:40 +0200 Thierry Reding wrote:
> On Wed, Oct 11, 2017 at 01:23:35PM +0200, Lothar Waßmann wrote:
> > The baseboards for the Ka-Ro electronics series of i.MX modules
> > use a 24bit LCD interface, no matter what LCD bus width the SoC on the
> >
Hi,
On Tue, 17 Oct 2017 15:08:31 +0200 Thierry Reding wrote:
> On Tue, Oct 17, 2017 at 03:05:16PM +0200, Lothar Waßmann wrote:
> > Hi,
> >
> > On Tue, 17 Oct 2017 14:09:37 +0200 Thierry Reding wrote:
> > > On Wed, Oct 11, 2017 at 01:23:34PM +0200, Lothar Waßman
Hi,
On Tue, 17 Oct 2017 14:09:37 +0200 Thierry Reding wrote:
> On Wed, Oct 11, 2017 at 01:23:34PM +0200, Lothar Waßmann wrote:
> > Use the newly defined macro to generate the display_mode data entries
> > for all panels. This reduces the code size significantly and makes th
Hi,
On Tue, 17 Oct 2017 14:45:04 +0200 Thierry Reding wrote:
> On Tue, Oct 17, 2017 at 02:25:07PM +0200, Lothar Waßmann wrote:
> > Hi,
> >
> > On Tue, 17 Oct 2017 14:14:22 +0200 Thierry Reding wrote:
> > > On Wed, Oct 11, 2017 at 01:23:36PM +0200, Lothar Wa
1td01-panel.dtsi, but those files are referenced nowhere in
the kernel source.
Should the driver be removed or moved to staging, until it is properly
fixed?
Lothar Waßmann
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedeskto
Adjust the compatible string that was obviously copied from the
mitsubishi,aa121td01.txt file.
Signed-off-by: Lothar Waßmann
---
.../devicetree/bindings/display/panel/mitsubishi,aa104xd12.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/Documentation/devicetree
panel-common.txt references display-timing.txt with an invalid path
('/panel' missing).
Signed-off-by: Lothar Waßmann
---
Documentation/devicetree/bindings/display/panel/panel-common.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetre
Hi,
On Wed, 08 Nov 2017 10:18:03 -0800 Eric Anholt wrote:
> Lothar Waßmann writes:
>
> > Hi,
> >
> > drivers/gpu/drm/bridge/lvds-encoder.c driver is currently
> > dysfunctional due to:
> > |commit 13dfc0540a575b47b2d640b093ac16e9e09474f6
> > |Author: Er
lvds_encoder->bridge.funcs = &funcs;
> + drm_bridge_add(&lvds_encoder->bridge);
>
> - platform_set_drvdata(pdev, bridge);
> + platform_set_drvdata(pdev, lvds_encoder);
>
> return 0;
> }
>
> stati
e_id innolux_of_match[] = {
> - { .compatible = "innolux,p079zca", },
> - { }
> + { .compatible = "innolux,p079zca",
> + .data = &innolux_p079zca_panel_desc
> + },
> + { .compatible = "innolux,p097pfg",
> + .data = &innolux_p097
Hi,
Laurent Pinchart wrote:
> Hello,
>
> On Monday 17 March 2014 14:41:09 Andrzej Hajda wrote:
> > On 03/13/2014 06:17 PM, Denis Carikli wrote:
> > > We need a way to pass signal polarity informations
> > > between DRM panels, and the display drivers.
> > >
> > > To do that, a pol_flags field wa
Hi,
Denis Carikli wrote:
> The previous hardware behaviour was kept if the
> flags are not set.
>
> Signed-off-by: Denis Carikli
> ---
> ChangeLog v10->v11:
> - This patch was splitted-out and adapted from:
> "Prepare imx-drm for extra display-timings retrival."
> - The display-timings dt spec
Hi,
Laurent Pinchart wrote:
> Hi Lothar,
>
> On Monday 17 March 2014 16:14:36 Lothar Wa?mann wrote:
> > Laurent Pinchart wrote:
> > > On Monday 17 March 2014 14:41:09 Andrzej Hajda wrote:
> > > > On 03/13/2014 06:17 PM, Denis Carikli wrote:
> > > > > We need a way to pass signal polarity informat
Hi,
Laurent Pinchart wrote:
> Hi Lothar,
>
> On Tuesday 18 March 2014 08:50:30 Lothar Wa?mann wrote:
> > Laurent Pinchart wrote:
> > > On Monday 17 March 2014 16:14:36 Lothar Wa?mann wrote:
> > > > Laurent Pinchart wrote:
> > > > > On Monday 17 March 2014 14:41:09 Andrzej Hajda wrote:
> > > > > >
Hi,
Shawn Guo wrote:
> On Mon, Apr 07, 2014 at 02:44:45PM +0200, Denis Carikli wrote:
> > The imx-drm driver can't use the de-active and
> > pixelclk-active display-timings properties yet.
> >
> > Instead the data-enable and the pixel data clock
> > polarity are hardcoded in the imx-drm driver.
>
53 matches
Mail list logo
