The IPUv3 primary plane doesn't support partial off screen.
So, this patch separates plane check logics for primary plane and overlay
plane and adds more limitations on the primary plane.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/imx/ipuv3-plane.c
e be rejected.
So, let's don't call the callback for the CRTC.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/drm_atomic_helper.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/drm_atomic_helper.c
b/drivers/gpu/drm/drm_atomic_helper.c
index ddfa0d1..939df90 10064
To match with the atomic context, this patch updates kerneldoc to clarify
that all mode_fixup callbacks and encoder's ->atomic_check callback are
called only when enabling a display mode on the relevant CRTC.
Suggested-by: Daniel Vetter
Signed-off-by: Liu Ying
---
include/drm/dr
ck commit will not overwrite
the hardware setting when a nonblock page flip is about to finish,
so that the page flip may wait for vblank successfully.
* See changelogs in each patch for other trivial updates.
Liu Ying (10):
drm/imx: ipuv3 plane: Check different types of plane separately
gpu: ipu
The IPUv3 primary plane doesn't support partial off screen.
So, this patch separates plane check logics for primary plane and overlay
plane and adds more limitations on the primary plane.
Signed-off-by: Liu Ying
---
v1->v2:
* Remove an unnecessary copy to address Philipp's comment.
Wire up CRTCs', planes' and connectors' ->reset, ->duplicate and ->destroy state
hooks to use the default implementations from the atomic helper library.
The helpers track each DRM object state.
Signed-off-by: Liu Ying
---
v1->v2:
* Remove the 'atomic
pdate
are always successful. Also, some necessary logics are tweaked for a smooth
transition.
Signed-off-by: Liu Ying
---
v1->v2:
* Get the overlay ipu plane resource when initializing the relevant CRTC
and do not get ipu plane resource any more when updating plane to avoid
resource alloca
Use drm_atomic_set_fb_for_plane() in the legacy ->page_flip path to track
the pointer plane_state->fb correctly.
Signed-off-by: Liu Ying
---
v1->v2:
* None.
drivers/gpu/drm/imx/ipuv3-crtc.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/imx/ipuv3-crtc.c b/dr
moved
from ->load in order not to confuse the atomic driver.
Signed-off-by: Liu Ying
---
v1->v2:
* Handle the newly introduced bus_flags via imx_encoder after the rebasing.
* Remove the legacy function drm_helper_disable_unused_functions() from
->load in order not to confuse the atomic
This patch switches the update/disable_plane callbacks to their atomic version.
Also, use the default atomic helpers to implement the atomic_check/commit
callbacks for mode configuration.
Signed-off-by: Liu Ying
---
v1->v2:
* None.
drivers/gpu/drm/imx/imx-drm-core.c | 3 +++
drivers/gpu/
mx-tve driver, since the encoder's callback ->dpms is replaced by
->disable, we need to move the setting for the IPU_CLK_EN bit(in register
TVE_COM_CONF_REG) from ->enable/->disable to ->mode_set, otherwise, the
relevant CRTC cannot be disabled correctly with a warning on DC stop ti
To support generic atomic page flip, this patch customizes ->atomic_commit
for nonblock commits.
Signed-off-by: Liu Ying
---
v1->v2:
* s/async/nonblock/ on this patch to address Daniel Vetter's comment.
* Wait for pending commit on each CRTC for both block and nonblock
atomic mo
With all the beforehand phases and steps done, we can adverstise DRIVER_ATOMIC.
Signed-off-by: Liu Ying
---
v1->v2:
* None.
drivers/gpu/drm/imx/imx-drm-core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imx/imx-drm-core.c
b/drivers/gpu/drm/imx/imx-
to handle allocation failure cases then.
Signed-off-by: Liu Ying
---
v1->v2:
* Improve the commit message to better explain why the static allocation
mechanism can replace the dynamic one.
drivers/gpu/drm/imx/ipuv3-plane.c | 26 -
drivers/gpu/ipu-v3/ipu-dmf
The function __drm_framebuffer_unregister() has boilerplate code to drop idr
reference. Let's replace it with drm_mode_object_put() to simplify the code.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/drm_crtc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/driver
We've done sanity NULL pointer check on set->mode at the beginning of
drm_crtc_helper_set_config() and bailed out if necessary, thus any later on
check is redundant.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/drm_crtc_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
We've done sanity NULL pointer check on set->fb at the beginning of
drm_crtc_helper_set_config() and bailed out if necessary, thus any later on
check or case handling is redundant.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/drm_crtc_helper.c | 2 --
1 file changed, 2 deletions(-)
diff
trong
Cc: Laurent Pinchart
Cc: Jonas Karlman
Cc: Jernej Skrabec
Cc: David Airlie
Cc: Daniel Vetter
Cc: Boris Brezillon
Cc: Jerome Brunet
Cc: Cheng-Yi Chiang
Cc: Dariusz Marcinkiewicz
Cc: Archit Taneja
Cc: Jose Abreu
Cc: dri-devel@lists.freedesktop.org
Cc: NXP Linux Team
Signed-off-by: Liu
vid Airlie
Cc: Daniel Vetter
Cc: Boris Brezillon
Cc: Jerome Brunet
Cc: Cheng-Yi Chiang
Cc: Dariusz Marcinkiewicz
Cc: Archit Taneja
Cc: Jose Abreu
Cc: Sam Ravnborg
Cc: dri-devel@lists.freedesktop.org
Cc: NXP Linux Team
Signed-off-by: Liu Ying
---
v1->v2:
* Put drm_bridge_add() in __dw_hd
er
Cc: Pengutronix Kernel Team
Cc: NXP Linux Team
Cc:
Signed-off-by: Liu Ying
---
drivers/gpu/drm/imx/imx-ldb.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c
index 4da22a9..af4d0d8 100644
--- a/drivers/g
On Fri, 2020-07-10 at 19:32 +0200, Sam Ravnborg wrote:
> On Thu, Jul 09, 2020 at 10:02:36AM +0800, Liu Ying wrote:
> > It doesn't hurt to add the bridge in the global bridge list also
> > for
> > platform specific dw-hdmi drivers which are based on the component
&
ascha Hauer
Cc: Pengutronix Kernel Team
Cc: NXP Linux Team
Signed-off-by: Liu Ying
---
drivers/gpu/drm/imx/imx-ldb.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c
index 4da22a9..19a00eb 100644
--- a/drivers/gpu/drm/imx/imx-ldb.
er
Cc: Pengutronix Kernel Team
Cc: NXP Linux Team
Cc:
Signed-off-by: Liu Ying
---
drivers/gpu/drm/imx/imx-ldb.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c
index 4da22a9..af4d0d8 100644
--- a/drivers/g
trong
Cc: Laurent Pinchart
Cc: Jonas Karlman
Cc: Jernej Skrabec
Cc: David Airlie
Cc: Daniel Vetter
Cc: Boris Brezillon
Cc: Jerome Brunet
Cc: Cheng-Yi Chiang
Cc: Dariusz Marcinkiewicz
Cc: Archit Taneja
Cc: Jose Abreu
Cc: dri-devel@lists.freedesktop.org
Cc: NXP Linux Team
Signed-off-by: Liu
hiang
Cc: Dariusz Marcinkiewicz
Cc: Archit Taneja
Cc: Jose Abreu
Cc: dri-devel@lists.freedesktop.org
Cc: NXP Linux Team
Signed-off-by: Liu Ying
---
Laurent,
I may see the uninitialized mutex accessing issue with
i.MX dw-hdmi after applying your below patch set[1].
I think patch '[22/27] d
ith the VGA, HDMI
> > and
> > LVDS outputs.
> >
> > [1]
> > https://lore.kernel.org/dri-devel/20200409004610.12346-1-laurent.pinchart+rene...@ideasonboard.com/
> > [2]
> > https://lore.kernel.org/dri-devel/20200409003636.11792-1-laurent.pinchart+rene...@i
Hi Laurent,
On Sun, 2020-06-28 at 11:22 +0300, Laurent Pinchart wrote:
> Hi Liu,
>
> (CC'ing Sam)
>
> Thank you for the patch.
Thanks for your review.
>
> On Tue, Jun 16, 2020 at 05:04:52PM +0800, Liu Ying wrote:
> > It doesn't hurt to add the bridge i
trong
Cc: Laurent Pinchart
Cc: Jonas Karlman
Cc: Jernej Skrabec
Cc: David Airlie
Cc: Daniel Vetter
Cc: Boris Brezillon
Cc: Jerome Brunet
Cc: Cheng-Yi Chiang
Cc: Dariusz Marcinkiewicz
Cc: Archit Taneja
Cc: Jose Abreu
Cc: dri-devel@lists.freedesktop.org
Cc: NXP Linux Team
Signed-off-by: Liu
vid Airlie
Cc: Daniel Vetter
Cc: Boris Brezillon
Cc: Jerome Brunet
Cc: Cheng-Yi Chiang
Cc: Dariusz Marcinkiewicz
Cc: Archit Taneja
Cc: Jose Abreu
Cc: Sam Ravnborg
Cc: dri-devel@lists.freedesktop.org
Cc: NXP Linux Team
Signed-off-by: Liu Ying
---
v1->v2:
* Put drm_bridge_add() in __dw_hd
Gentle ping...
On Tue, 2020-05-12 at 15:31 +0800, Liu Ying wrote:
> Both of the two LVDS channels should be disabled for split mode
> in the encoder's ->disable() callback, because they are enabled
> in the encoder's ->enable() callback.
>
> Fixes: 6556f7f82b9c
Gentle ping...
On Tue, 2020-05-12 at 15:21 +0800, Liu Ying wrote:
> No one is using the LVDS_BIT_MAP_SPWG/JEIDA enums since a previous
> commit which changes the imx_ldb_bit_mappings[] array definition,
> so let's remove them.
>
> Fixes: 5e501ed7253b ("drm/imx: imx-ld
does the same thing as this patch does. I'm fine to drop
this patch then.
Regarding Philipp's proposal on the use-after-free issue, we've got the
basically the same implemetation in downstream ldb driver to address
the issue.
Regards,
Liu Ying
>
> [1]
> https://eur0
Hi Marco,
On Thu, 2020-05-28 at 11:31 +0200, Marco Felsch wrote:
> Hi Liu
>
> On 20-05-28 10:58, Liu Ying wrote:
> > Gentle ping...
>
> Please check my "spring cleanup series" [1] which do the split:
It looks that your series doesn't disable both lvds
Add compatible to panel-simple for Kaohsiung Opto-Electronics Inc.
10.1" WUXGA(1920x1200) TX26D202VM0BWA TFT LCD panel with LVDS interface.
Cc: Thierry Reding
Cc: Sam Ravnborg
Cc: Rob Herring
Signed-off-by: Liu Ying
---
Documentation/devicetree/bindings/display/panel/panel-simple.yam
t different.
It looks that the two types of panel are compatible with each other.
http://www.koe.j-display.com/upload/product/TX26D202VM0BAA.pdf
Patch 1/2 adds compatible for the panel in the panel-simple DT binding doc.
Patch 2/2 adds the panel support in the DRM panel-simple driver.
Liu Ying (2
'TX26D202VM0BAA' is a little bit different.
It looks that the two types of panel are compatible with each other.
http://www.koe.j-display.com/upload/product/TX26D202VM0BAA.pdf
Cc: Thierry Reding
Cc: Sam Ravnborg
Signed-off-by: Liu Ying
---
drivers/gpu
2015-05-12 21:36 GMT+08:00 Thierry Reding :
> On Fri, Feb 13, 2015 at 01:25:19PM +0800, Liu Ying wrote:
>> Signed-off-by: Liu Ying
>
> This could use a commit message. Describe for example why this is useful
> or when to use it.
Ok, I'll add it in the next version
ife easier to do the conversion
from a specific MIPI DSI pixel format to it's bits per pixel value.
Signed-off-by: Liu Ying
---
v9.5->v9.5.1:
* To address Thierry Reding's comments, add a commit message to describe why
the helper is useful and when to use it and fix typo in kernel-do
tch binds
the plane created by ipu_plane_init() with crtc->primary and removes the
safe one to address this issue.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/imx/imx-drm-core.c | 3 ++-
drivers/gpu/drm/imx/ipuv3-crtc.c | 6 ++
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/d
For primary plane initialization failure cases, ipu_plane_init() may return
a pointer encoded by ERR_PTR(). So, we should bailout instead of use that
pointer blindly.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/imx/ipuv3-crtc.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu
On Fri, Nov 06, 2015 at 11:05:48AM +0100, Philipp Zabel wrote:
> Am Mittwoch, den 04.11.2015, 18:15 +0800 schrieb Liu Ying:
> > Since we are using ipu_plane_init() to add one primary plane for each
> > IPU CRTC, it's unnecessary to create the safe one by using the helper
>
On Fri, Nov 06, 2015 at 11:05:54AM +0100, Philipp Zabel wrote:
> Hi Liu,
>
> Am Mittwoch, den 04.11.2015, 18:15 +0800 schrieb Liu Ying:
> > For primary plane initialization failure cases, ipu_plane_init() may return
> > a pointer encoded by ERR_PTR(). So, we should bailou
patch removes the safe
plane which is created by create_primary_plane(). Or, at least, it fixes the
NULL pointer dereference issue triggered by the drm modetest I mentioned in my
patch[1].
Otherwise, Acked-by: Liu Ying
[1] https://lkml.org/lkml/2015/11/4/107
Regards,
Liu Ying
>
> Si
For primary plane initialization failure cases, ipu_plane_init() may return
a pointer encoded by ERR_PTR(). So, we should bailout instead of using that
pointer blindly.
Signed-off-by: Liu Ying
---
v1->v2:
* Trivial commit message fix.
* Rebase onto Phillip's patch[1].
One of the two local variables old_crtc_state is redundantly defined in the
function disable_outputs(). It has only a scope partway through the block
for_each_connector_in_state. So, let's remove it and use the one which
has the scope within the function disable_outputs().
Signed-off-by
Hi Philipp,
2015-11-23 19:48 GMT+08:00 Philipp Zabel :
> Am Freitag, den 20.11.2015, 16:14 +0800 schrieb Liu Ying:
>> This patch changes the dev_info() call to dev_dbg() in ipu_plane_update()
>> to print out the information that a plane's CRTC is changed, because this
>&
nonblock
atomic mode settings. This way, a block commit will not overwrite
the hardware setting when a nonblock page flip is about to finish,
so that the page flip may wait for vblank successfully.
* See changelogs in each patch for other trivial updates.
Liu Ying (10):
drm/imx: ipuv3
Use drm_atomic_set_fb_for_plane() in the legacy ->page_flip path to track
the pointer plane_state->fb correctly.
Signed-off-by: Liu Ying
---
v2->v3:
* None.
v1->v2:
* None.
drivers/gpu/drm/imx/ipuv3-crtc.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/d
The IPUv3 primary plane doesn't support partial off screen.
So, this patch separates plane check logics for primary plane and overlay
plane and adds more limitations on the primary plane.
Signed-off-by: Liu Ying
---
v2->v3:
* None.
v1->v2:
* Remove an unnecessary copy to addres
pdate
are always successful. Also, some necessary logics are tweaked for a smooth
transition.
Signed-off-by: Liu Ying
---
v2->v3:
* A minor change to simplify the way we find crtc->enabled in
drm_plane_helper_funcs->atomic_check.
v1->v2:
* Get the overlay ipu plane resource
The main task of imx encoders' ->prepare callbacks is to set bus_format,
bus_flags, di_vsync_pin and di_hsync_pin. We may create a structure named
imx_encoder to cache them. The atomic encoder callback ->disable may
replace ->prepare later, so let's remove ->prepare.
S
There is no one using the legacy drm_connector_funcs structure since
the imx-drm has been converted to atomic, so we may remove it.
Signed-off-by: Liu Ying
---
v2->v3:
* Newly introduced to remove the legacy drm_connector_funcs structure
step-by-step.
drivers/gpu/drm/bridge/dw-hdmi.c |
Wire up CRTCs', planes' and connectors' ->reset, ->duplicate and ->destroy state
hooks to use the default implementations from the atomic helper library.
The helpers track each DRM object state.
Signed-off-by: Liu Ying
---
v2->v3:
* For dw-hdmi bridge driver, simply
With all the beforehand phases and steps done, we can adverstise DRIVER_ATOMIC.
Signed-off-by: Liu Ying
---
v2->v3:
* None.
v1->v2:
* None.
drivers/gpu/drm/imx/imx-drm-core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imx/imx-drm-core.c
b/d
mx-tve driver, since the encoder's callback ->dpms is replaced by
->disable, we need to move the setting for the IPU_CLK_EN bit(in register
TVE_COM_CONF_REG) from ->enable/->disable to ->mode_set, otherwise, the
relevant CRTC cannot be disabled correctly with a warning on DC stop ti
to handle allocation failure cases then.
Signed-off-by: Liu Ying
---
v2->v3:
* None.
v1->v2:
* Improve the commit message to better explain why the static allocation
mechanism can replace the dynamic one.
drivers/gpu/drm/imx/ipuv3-plane.c | 26 -
drivers/gpu/ipu-v3/ipu-
ve the private ipu_crtc->enabled state which was left
there for the transitional atomic helpers in phase 1. Page flip is also
switched to the atomic version. Last, the legacy function
drm_helper_disable_unused_functions() is removed from ->load in order
not to confuse the atomic driver.
Signed
of my changes in the appropriate places (the
> mode_set removal could be squashed into the "Legacy callback fixups"
> patch, for example). I could then retest and potentially rebase the
> remaining changes on your next version.
I'll respin to fix the LVDS bus format translatio
r both block and nonblock
atomic mode settings. This way, a block commit will not overwrite
the hardware setting when a nonblock page flip is about to finish,
so that the page flip may wait for vblank successfully.
* See changelogs in each patch for other trivial updates.
Liu Ying (10):
The IPUv3 primary plane doesn't support partial off screen.
So, this patch separates plane check logics for primary plane and overlay
plane and adds more limitations on the primary plane.
Signed-off-by: Liu Ying
---
v3->v4:
* None.
v2->v3:
* None.
v1->v2:
* Remove an unnec
to handle allocation failure cases then.
Signed-off-by: Liu Ying
---
v3->v4:
* None.
v2->v3:
* None.
v1->v2:
* Improve the commit message to better explain why the static allocation
mechanism can replace the dynamic one.
drivers/gpu/drm/imx/ipuv3-plane.c | 26 -
drivers/gp
Use drm_atomic_set_fb_for_plane() in the legacy ->page_flip path to track
the pointer plane_state->fb correctly.
Signed-off-by: Liu Ying
---
v3->v4:
* None.
v2->v3:
* None.
v1->v2:
* None.
drivers/gpu/drm/imx/ipuv3-crtc.c | 4
1 file changed, 4 insertions(+)
diff --gi
The main task of imx encoders' ->prepare callbacks is to set bus_format,
bus_flags, di_vsync_pin and di_hsync_pin. We may create a structure named
imx_encoder to cache them. The atomic encoder callback ->disable may
replace ->prepare later, so let's remove ->prepare.
S
pdate
are always successful. Also, some necessary logics are tweaked for a smooth
transition.
Signed-off-by: Liu Ying
---
v3->v4:
* Staticize ipu_plane_atomic_set_base().
v2->v3:
* A minor change to simplify the way we find crtc->enabled in
drm_plane_helper_funcs->atomic_chec
ve the private ipu_crtc->enabled state which was left
there for the transitional atomic helpers in phase 1. Page flip is also
switched to the atomic version. Last, the legacy function
drm_helper_disable_unused_functions() is removed from ->load in order
not to confuse the atomic driver.
Signed
With all the beforehand phases and steps done, we can adverstise DRIVER_ATOMIC.
Signed-off-by: Liu Ying
---
v3->v4:
* None.
v2->v3:
* None.
v1->v2:
* None.
drivers/gpu/drm/imx/imx-drm-core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/im
mx-tve driver, since the encoder's callback ->dpms is replaced by
->disable, we need to move the setting for the IPU_CLK_EN bit(in register
TVE_COM_CONF_REG) from ->enable/->disable to ->mode_set, otherwise, the
relevant CRTC cannot be disabled correctly with a warning on DC stop ti
There is no one using the legacy drm_connector_funcs structure since
the imx-drm has been converted to atomic, so we may remove it.
Signed-off-by: Liu Ying
---
v3->v4:
* None.
v2->v3:
* Newly introduced to remove the legacy drm_connector_funcs structure
step-by-step.
drivers/gpu/drm/
Wire up CRTCs', planes' and connectors' ->reset, ->duplicate and ->destroy state
hooks to use the default implementations from the atomic helper library.
The helpers track each DRM object state.
Signed-off-by: Liu Ying
---
v3->v4:
* None.
v2->v3:
* For dw-hdmi
There is no one calling imx_drm_crtc_vblank_get/_put() and
they are just two simple wrappers of drm_crtc_vblank_get/_put()
without doing any thing fancy - the drivers may call
drm_crtc_vblank_get/_put() directly. So, let's remove the two
wrappers.
Signed-off-by: Liu Ying
---
drivers/gp
There is no one calling imx_drm_crtc_id() and it is just a simple
wrapper of drm_crtc_index() without doing any thing fancy - the
drivers may call drm_crtc_index() directly. So, let's remove the
wrapper.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/imx/imx-drm-core.c | 6 --
drivers/gp
imx_drm_handle_vblank() is just a simple wrapper of drm_crtc_handle_vblank()
without doing any thing fancy - drm_crtc_handle_vblank() can be called
directly. So, let's remove the wrapper.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/imx/imx-drm-core.c | 6 --
drivers/gpu/drm/imx/imx-
The return type of drm_fb_helper_debug_enter() is int, so we should return '0'
instead of 'false'.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/drm_fb_helper.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu
The variable info->fix.type_aux is set to zero twice in the function
drm_fb_helper_fill_fix(). This patch removes one redundant.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/drm_fb_helper.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/
On 06/19/2014 03:01 PM, Daniel Vetter wrote:
> On Thu, Jun 19, 2014 at 10:50:31AM +0800, Liu Ying wrote:
>> The return type of drm_fb_helper_debug_enter() is int, so we should return
>> '0'
>> instead of 'false'.
>>
>> Signed-off-by: Liu Yin
necessary check in drm_fb_helper_debug_enter().
Signed-off-by: Liu Ying
---
drivers/gpu/drm/drm_fb_helper.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index d5d8cea..eb77a2f 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++
changes to fullfill the task.
Liu Ying (3):
ARM: imx6q: refactor some ldb related clocks
ARM: dts: imx6q/imx6dl: add necessary clocks for ldb node
staging: drm/imx: ldb: correct the ldb di clock trees
.../devicetree/bindings/clock/imx6q-clock.txt |6 ++--
arch/arm/boot/dts
ldb_di[0/1]_div_sel multiplexers
so that the fixed factor clocks of 1/3.5 and 1/7 can be set to be
the parents of ldb_di[0/1]_div_sel multiplexers. The ldb_di[0/1]_podf
dividers are no longer used then.
Signed-off-by: Liu Ying
---
.../devicetree/bindings/clock/imx6q-clock.txt |6
de
as well.
Signed-off-by: Liu Ying
---
drivers/staging/imx-drm/imx-ldb.c | 38 +
1 file changed, 30 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/imx-drm/imx-ldb.c
b/drivers/staging/imx-drm/imx-ldb.c
index 8af7f3b..7c553b8 100644
--- a/dr
This patch adds di[0/1]_div_3_5, di[0/1]_div_7 and di[0/1]_div_sel
clocks to the ldb nodes so that the ldb driver may use them to
setup the display clock trees.
Signed-off-by: Liu Ying
---
arch/arm/boot/dts/imx6dl.dtsi |8 ++--
arch/arm/boot/dts/imx6q.dtsi |8 ++--
2 files
On 08/20/2013 05:43 PM, Philipp Zabel wrote:
> Am Dienstag, den 20.08.2013, 16:38 +0800 schrieb Liu Ying:
>> The ldb_di[0/1]_ipu_div clock dividers in the CSCMR2 register
>> of i.MX53, i.MX6Q and i.MX6DL SoCs can be configured to a 1/3.5
>> drivider or a 1/7 divider. The c
On 08/21/2013 09:59 AM, Shawn Guo wrote:
> Hi Ying,
>
> On Tue, Aug 20, 2013 at 06:08:48PM +0800, Liu Ying wrote:
>>> While I admit to having introduced the combination of 1/3.5 fixed
>>> divider and configurable 1/1,1/2 divder clocks to describe this
>>> fr
On 08/20/2013 11:40 PM, Fabio Estevam wrote:
> On Tue, Aug 20, 2013 at 5:38 AM, Liu Ying wrote:
>
>> diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.txt
>> b/Documentation/devicetree/bindings/clock/imx6q-clock.txt
>> index 5a90a72..90e923e 10064
>atomic_disable callback, but not in each plane's ->atomic_update callback,
as suggested by Daniel Vetter.
* +Cc Lucas Stach, as he tested the patch v2.
v1->v2:
* Do not reject reconfiguring an active overlay plane.
Liu Ying (7):
drm/atomic-helper: Add atomic_disable CRTC helper c
state for disable operation.
Suggested-by: Daniel Vetter
Cc: Philipp Zabel
Cc: David Airlie
Cc: Russell King
Cc: Peter Senna Tschudin
Cc: Lucas Stach
Signed-off-by: Liu Ying
---
v3->v4:
* Improve kernel-doc of CRTC's atomic_disable callback to address Daniel
Vetter's comment.
Now that the drm atomic core supports the callback ->atomic_disable,
we may replace the legacy one ->disable with it.
Cc: Philipp Zabel
Cc: David Airlie
Cc: Russell King
Cc: Daniel Vetter
Cc: Peter Senna Tschudin
Cc: Lucas Stach
Signed-off-by: Liu Ying
---
v3->v4:
* None.
v3
irlie
Cc: Russell King
Cc: Peter Senna Tschudin
Cc: Lucas Stach
Signed-off-by: Liu Ying
---
v4:
* Newly introduced in v4, but some logic is picked from patch 3/3 in v3.
drivers/gpu/drm/imx/imx-drm-core.c | 3 ++-
drivers/gpu/drm/imx/ipuv3-crtc.c | 3 +++
drivers/gpu/drm/imx/ipuv3-plane.c
ter Senna Tschudin
Cc: Lucas Stach
Signed-off-by: Liu Ying
---
v4:
* Newly introduced in v4.
drivers/gpu/drm/arm/malidp_drv.c | 3 +-
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 +-
drivers/gpu/drm/drm_atomic_helper.c | 46
driv
;atomic_check callback so that the CRTC
will be disabled before the plane configuration.
Suggested-by: Daniel Vetter
Cc: Philipp Zabel
Cc: David Airlie
Cc: Russell King
Cc: Peter Senna Tschudin
Cc: Lucas Stach
Signed-off-by: Liu Ying
---
v4:
* Newly introduced in v4, but the logic is picked
lanes
of old_crtc_state in the helper.
Suggested-by: Daniel Vetter
Cc: Philipp Zabel
Cc: David Airlie
Cc: Russell King
Cc: Peter Senna Tschudin
Cc: Lucas Stach
Signed-off-by: Liu Ying
---
v4:
* Newly introduced in v4.
drivers/gpu/drm/drm_atomic_helper.c | 16 +---
inc
dd the new
DRM_PLANE_COMMIT_NO_DISABLE_AFTER_MODESET flag to the imx-drm driver
which changes the procedure to disable display channel slightly.
Cc: Philipp Zabel
Cc: David Airlie
Cc: Russell King
Cc: Peter Senna Tschudin
Cc: Lucas Stach
Cc: Daniel Vetter
Signed-off-by: Liu Ying
---
v4:
* Newly introd
ter Senna Tschudin
Cc: Lucas Stach
Signed-off-by: Liu Ying
---
I choose to pick this patch from the patch set[1] so that I may address
Daniel Vetter's comments conveniently by sending v2 for it alone.
[1] http://www.spinics.net/lists/dri-devel/msg116491.html
v1->v2:
* Add a new
me thing for other transitional helpers, but it seems this one
was missed.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/drm_crtc_helper.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_crtc_helper.c
b/drivers/gpu/drm/drm_crtc_helper.c
index 79555
changes to fullfill the task.
Liu Ying (3):
ARM: imx6q: refactor some ldb related clocks
ARM: dts: imx6q/imx6dl: add necessary clocks for ldb node
staging: drm/imx: ldb: correct the ldb di clock trees
.../devicetree/bindings/clock/imx6q-clock.txt |6 ++--
arch/arm/boot/dts
ldb_di[0/1]_div_sel multiplexers
so that the fixed factor clocks of 1/3.5 and 1/7 can be set to be
the parents of ldb_di[0/1]_div_sel multiplexers. The ldb_di[0/1]_podf
dividers are no longer used then.
Signed-off-by: Liu Ying
---
.../devicetree/bindings/clock/imx6q-clock.txt |6
This patch adds di[0/1]_div_3_5, di[0/1]_div_7 and di[0/1]_div_sel
clocks to the ldb nodes so that the ldb driver may use them to
setup the display clock trees.
Signed-off-by: Liu Ying
---
arch/arm/boot/dts/imx6dl.dtsi |8 ++--
arch/arm/boot/dts/imx6q.dtsi |8 ++--
2 files
de
as well.
Signed-off-by: Liu Ying
---
drivers/staging/imx-drm/imx-ldb.c | 38 +
1 file changed, 30 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/imx-drm/imx-ldb.c
b/drivers/staging/imx-drm/imx-ldb.c
index 8af7f3b..7c553b8 100644
--- a/dr
On 08/20/2013 05:43 PM, Philipp Zabel wrote:
> Am Dienstag, den 20.08.2013, 16:38 +0800 schrieb Liu Ying:
>> The ldb_di[0/1]_ipu_div clock dividers in the CSCMR2 register
>> of i.MX53, i.MX6Q and i.MX6DL SoCs can be configured to a 1/3.5
>> drivider or a 1/7 divider. The c
On 08/21/2013 09:59 AM, Shawn Guo wrote:
> Hi Ying,
>
> On Tue, Aug 20, 2013 at 06:08:48PM +0800, Liu Ying wrote:
>>> While I admit to having introduced the combination of 1/3.5 fixed
>>> divider and configurable 1/1,1/2 divder clocks to describe this
>>> fr
On 08/20/2013 11:40 PM, Fabio Estevam wrote:
> On Tue, Aug 20, 2013 at 5:38 AM, Liu Ying wrote:
>
>> diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.txt
>> b/Documentation/devicetree/bindings/clock/imx6q-clock.txt
>> index 5a90a72..90e923e 10064
601 - 700 of 1452 matches
Mail list logo
