+items:
> + - const: iahb
> + - const: isfr
> + - const: fdcc
> + - const: cec
> + - const: pix
> +
> + power-domains:
> +maxItems: 1
Missing 'ports' property?
> +
> +required:
> + - compatible
> + - reg
> + - clocks
&
+ plat_data->priv_data = hdmi;
Need to set plat_data->phy_force_vendor to be true? Or, you rely on
reading the HDMI_CONFIG2_ID register to determine the phy type?
> +
> + hdmi->dw_hdmi = dw_hdmi_probe(pdev, plat_data);
> + if (IS_ERR(hdmi->dw_hdmi))
> +
list it as an 'interrupts' property?
> +
> +required:
> + - compatible
> + - reg
> + - power-domains
> + - ports
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> +#include
This is not needed if the example node doe
(!remote)
> + return -EINVAL;
> +
> + pvi->next_bridge = of_drm_find_bridge(remote);
> + of_node_put(remote);
> +
> + if (!pvi->next_bridge)
> + return dev_err_probe(&pdev->dev, -EPROBE_DEFER,
> +
27;ll use new dt binding way to
support i.MX8qm/qxp clocks. This depends on a not-yet-landed patch set
to do basic conversions for the platforms.
* Fix dt binding yamllint warnings.
* Require bypass0 and bypass1 clocks for both i.MX8qxp and i.MX8qm in DPU's
dt binding documentation.
* Us
This patch adds bindings for i.MX8qxp/qm Display Processing Unit.
Reviewed-by: Rob Herring
Signed-off-by: Liu Ying
---
v7->v14:
* No change.
v6->v7:
* Add Rob's R-b tag back.
v5->v6:
* Use graph schema. So, drop Rob's R-b tag as review is needed.
v4->v5:
* No chan
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Channel.
Reviewed-by: Rob Herring
Signed-off-by: Liu Ying
---
v10->v14:
* No change.
v9->v10:
* Add Rob's R-b tag.
v8->v9:
* Reference 'interrupts-extended' schema instead of 'interrupts' to
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Gasket.
Reviewed-by: Rob Herring
Signed-off-by: Liu Ying
---
v4->v14:
* No change.
v3->v4:
* Improve compatible property by using enum instead of oneOf+const. (Rob)
* Add Rob's R-b tag.
v2->v3:
* No change.
v1-
Artificially use 'plane' and 'old_plane_state' to avoid 'not used' warning.
The precedent has already been set by other macros in the same file.
Acked-by: Daniel Vetter
Signed-off-by: Liu Ying
---
v6->v14:
* No change.
v5->v6:
* Fix commit message typo -
Add myself as the maintainer of the i.MX8qxp DPU DRM driver.
Acked-by: Laurentiu Palcu
Signed-off-by: Liu Ying
---
v11->v14:
* No change.
v10->v11:
* Rebase upon v6.0-rc1.
v9->v10:
* Add Laurentiu's A-b tag.
v1->v9:
* No change.
MAINTAINERS | 9 +
1 file chan
the bridge kernel doc")
Fixes: ("f32df58acc68 drm/bridge: Add the necessary bits to support bus format
negotiation")
Signed-off-by: Liu Ying
---
include/drm/drm_bridge.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/drm/drm_bridge.h b/include/dr
ind_property calls to the
> recently added of_property_present() helper when we just want to test
> for presence of a property and nothing more.
>
> Signed-off-by: Rob Herring
> ---
> drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c | 2 +-
Reviewed-by: Liu Ying # i
Appropriate maintainers should be suggested for changes to the
include/drm/drm_bridge.h header file, so add the header file to the
'DRM DRIVERS FOR BRIDGE CHIPS' section.
Signed-off-by: Liu Ying
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAI
x the bridge kernel doc")
Fixes: f32df58acc68 ("drm/bridge: Add the necessary bits to support bus format
negotiation")
Signed-off-by: Liu Ying
---
v1->v2:
* Correct Fixes tag format.
* Copy DRM bridge driver maintainers.
* Copy Boris.
include/drm/drm_bridge.h | 4 ++--
1 file cha
Hi Lee,
On Fri, 2023-03-17 at 08:17 +, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> scripts/Makefile.build:252: drivers/gpu/drm/bridge/imx/Makefile:
> imx-ldb-helper.o is added to multiple modules: imx8qm-ldb imx8qxp-ldb
>
> Cc: Liu Ying
&
dges' member from lcdif_drm_private structure.
* Drop a comment about bridge input bus format from lcdif_crtc_atomic_check().
Liu Ying (6):
dt-bindings: lcdif: Add i.MX93 LCDIF support
drm: lcdif: Drop unnecessary NULL pointer check on lcdif->bridge
drm: lcdif: Determine bus format and flags in ->atomi
). i.MX93
LCDIF IP is essentially the same to i.MX8MP LCDIF IP. Add device
tree binding for i.MX93 LCDIF.
Acked-by: Krzysztof Kozlowski
Reviewed-by: Marek Vasut
Reviewed-by: Alexander Stein
Signed-off-by: Liu Ying
---
v4->v5:
* No change.
v3->v4:
* Add Alexander's R-b tag.
v
A valid bridge is already found in lcdif_attach_bridge() and set
to lcdif->bridge, so lcdif->bridge cannot be a NULL pointer. Drop
the unnecessary NULL pointer check in KMS stage.
Tested-by: Alexander Stein
Reviewed-by: Alexander Stein
Signed-off-by: Liu Ying
---
v4->v5:
* Add Alexan
ucture is introduced to cache bus format
and bus flags states in ->atomic_check() so that they can be read
in ->atomic_enable().
Tested-by: Alexander Stein
Reviewed-by: Alexander Stein
Signed-off-by: Liu Ying
---
v4->v5:
* Add Alexander's R-b and T-b tags.
v3->v4:
* Use 'new_{c
ein
Signed-off-by: Liu Ying
---
v4->v5:
* Add Alexander's A-b and T-b tags.
v3->v4:
* No change.
v2->v3:
* No change.
v1->v2:
* Split from patch 2/2 in v1. (Marek, Alexander)
* Drop a comment about bridge input bus format from lcdif_crtc_atomic_check().
drivers/gpu/drm/mx
pport.
Tested-by: Alexander Stein
Acked-by: Alexander Stein
Signed-off-by: Liu Ying
---
v4->v5:
* Rebase upon v6.4-rc1 and resolve a trivial conflict.
* Add Alexander's A-b and T-b tags.
v3->v4:
* Improve warning message when ignoring invalid LCDIF OF endpoint ids.
(Alexander)
v2-
-by: Liu Ying
---
v4->v5:
* Add Alexander's T-b tag.
v3->v4:
* Add Alexander's R-b tag.
v2->v3:
* Fix a trivial typo in commit message.
v1->v2:
* Split from patch 2/2 in v1. (Marek, Alexander)
drivers/gpu/drm/mxsfb/lcdif_drv.c | 1 +
1 file changed, 1 insertion(+)
diff -
ki
Signed-off-by: Liu Ying
---
v1->v2:
* Add Krzysztof's A-b tag.
.../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
b/Documentation/devicetree/bindings/d
iming in patch 2/2 to tell minimum and maximum
pixel clock rates.
* Set bus_flags to DRM_BUS_FLAG_DE_HIGH in struct panel_desc in patch 2/2.
Liu Ying (2):
dt-bindings: display: simple: Add BOE EV121WXM-N10-1850 panel
drm/panel: panel-simple: Add BOE EV121WXM-N10-1850 panel support
.../
Add BOE EV121WXM-N10-1850 12.1" WXGA (1280x800) TFT LCD panel support.
The panel has a LVDS display interface.
The panel's product specification can be found at:
http://www.onetech.com.tw/files/EV121WXM-N10-1850ProductSpecification_20180801.pdf
Signed-off-by: Liu Ying
---
v1->v2:
tate structure to
note it should always be the first member. (Lothar)
* Drop unneeded 'bridges' member from lcdif_drm_private structure.
* Drop a comment about bridge input bus format from lcdif_crtc_atomic_check().
Liu Ying (6):
dt-bindings: lcdif: Add i.MX93 LCDIF support
). i.MX93
LCDIF IP is essentially the same to i.MX8MP LCDIF IP. Add device
tree binding for i.MX93 LCDIF.
Acked-by: Krzysztof Kozlowski
Reviewed-by: Marek Vasut
Reviewed-by: Alexander Stein
Signed-off-by: Liu Ying
---
v5->v6:
* No change.
v4->v5:
* No change.
v3->v4:
* Add Alexan
A valid bridge is already found in lcdif_attach_bridge() and set
to lcdif->bridge, so lcdif->bridge cannot be a NULL pointer. Drop
the unnecessary NULL pointer check in KMS stage.
Tested-by: Alexander Stein
Reviewed-by: Alexander Stein
Signed-off-by: Liu Ying
---
v5->v6:
* Kee
ucture is introduced to cache bus format
and bus flags states in ->atomic_check() so that they can be read
in ->atomic_enable().
Tested-by: Alexander Stein
Reviewed-by: Alexander Stein
Reviewed-by: Marek Vasut
Signed-off-by: Liu Ying
---
v5->v6:
* Add Marek's R-b tag.
* A slight
ein
Reviewed-by: Marek Vasut
Signed-off-by: Liu Ying
---
v5->v6:
* Add Marek's R-b.
* A slight change brought from the update in patch 2/6 to keep default
MEDIA_BUS_FMT_RGB888_1X24 bus format.
v4->v5:
* Add Alexander's A-b and T-b tags.
v3->v4:
* No change.
v2->v3:
* No
pport.
Tested-by: Alexander Stein
Acked-by: Alexander Stein
Signed-off-by: Liu Ying
---
v5->v6:
* Drop MAX_DISPLAYS macro. (Marek)
* Drop the encoder member in struct lcdif_drm_private.
* Drop endpoint id check.
* Allocate encoders by calling devm_kzalloc().
v4->v5:
* Rebase upon v
: Marek Vasut
Signed-off-by: Liu Ying
---
v5->v6:
* Add Marek's R-b tag.
v4->v5:
* Add Alexander's T-b tag.
v3->v4:
* Add Alexander's R-b tag.
v2->v3:
* Fix a trivial typo in commit message.
v1->v2:
* Split from patch 2/2 in v1. (Marek, Alexander)
drivers/gpu/
si_phy_init() in patch 9.
Liu Ying (9):
drm/bridge: synopsys: dw-mipi-dsi: Add dw_mipi_dsi_get_bridge() helper
drm/bridge: synopsys: dw-mipi-dsi: Add input bus format negotiation
support
drm/bridge: synopsys: dw-mipi-dsi: Force input bus flags
drm/bridge: synopsys: dw-mipi-dsi: Add mode fix
Add dw_mipi_dsi_get_bridge() helper so that it can be used by vendor
drivers which implement vendor specific extensions to Synopsys DW MIPI DSI.
Signed-off-by: Liu Ying
---
v1->v3:
* No change.
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 ++
include/drm/bridge/dw_mipi_ds
ormats through pdata->get_input_bus_fmts()
first. If it's unavailable, fall back to the only format - MEDIA_BUS_FMT_FIXED,
which matches the default behavior if ->atomic_get_input_bus_fmts() is not
implemented as ->atomic_get_input_bus_fmts()'s kerneldoc indicates.
Signed-off
.
Signed-off-by: Liu Ying
---
v1->v3:
* No change.
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
index 8580b8a97fb1..8cd89a63b5f2 100
video
mode.
Signed-off-by: Liu Ying
Reviewed-by: Neil Armstrong
---
v2->v3:
* Add Neil's R-b tag from v1.
v1->v2:
* No change.
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw
Vendor drivers may need to fixup mode due to pixel clock tree limitation,
so introduce the ->mode_fixup() callcack to struct dw_mipi_dsi_plat_data
and call it at atomic check stage if available.
Signed-off-by: Liu Ying
---
v1->v3:
* No change.
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.
or doesn't happen for
the 1920x1080p@60 video mode at least.
Signed-off-by: Liu Ying
Reviewed-by: Neil Armstrong
---
v2->v3:
* Add Neil's R-b tag from v1.
v1->v2:
* No change.
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
di
sum up
HSA, HBP, HFP and HDISPLAY.
This helps the case where Raydium RM67191 DSI panel is connected, since
it's video timing for hsync length is only 2 pixels and without this patch
the programmed value for DSI_VID_HSA_TIME is only 2 with 4 data lanes.
Signed-off-by: Liu Ying
Reviewed-
Freescale i.MX93 SoC embeds a Synopsys Designware MIPI DSI host
controller and a Synopsys Designware MIPI DPHY. Some configurations
and extensions to them are controlled by i.MX93 media blk-ctrl.
Signed-off-by: Liu Ying
Reviewed-by: Rob Herring
---
v2->v3:
* No change.
v1->v2:
* Add Rob
i.MX93 MIPI DSI specific extensions.
Signed-off-by: Liu Ying
---
v2->v3:
* Select GENERIC_PHY to fix Kconfig warning for GENERIC_PHY_MIPI_DPHY
dependency.
v1->v2:
* Use dev_err_probe() to replace DRM_DEV_ERROR(). (Sam and Alexander)
* Use dev_*() to replace DRM_*(). (Sam)
* Fix build f
the order is reversed, like the problematic case mentioned
in the below link.
Link:
https://lore.kernel.org/lkml/capdykfr0xjru_udkoukq_q8rwaukyql+8fv-7s1ctmqi7u3...@mail.gmail.com/T/
Suggested-by: Ulf Hansson
Signed-off-by: Liu Ying
---
v2->v3:
* Improve commit message s/swapped/reversed/.
ts to zero in case
imx93_pdfc_bridge_atomic_get_input_bus_fmts() returns NULL in patch 2/2.
* Replace .remove callback with .remove_new callback in
imx93_pdfc_bridge_driver in patch 2/2.
Liu Ying (2):
dt-bindings: display: bridge: Add NXP i.MX93 parallel display format
configuration
dr
NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which
configures parallel display format by using the "PARALLEL_DISP_FORMAT"
field. Add device tree bindings for the display format configuration.
Signed-off-by: Liu Ying
---
v1->v2:
* No change.
.../display/bri
NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which
configures parallel display format by using the "PARALLEL_DISP_FORMAT"
field. Add a DRM bridge driver to support the display format configuration.
Signed-off-by: Liu Ying
---
v1->v2:
* Set *num_input_fmts to
emove_new callback in
imx93_pdfc_bridge_driver in patch 2/2.
Liu Ying (2):
dt-bindings: soc: imx93-media-blk-ctrl: Add PDFC subnode to schema and
example
drm/bridge: imx: Add i.MX93 parallel display format configuration
support
.../soc/imx/fsl,imx93-media-blk-ctrl.yaml | 68 ++
drivers/gpu/d
i.MX93 SoC mediamix blk-ctrl contains one DISPLAY_MUX register which
configures parallel display format by using the "PARALLEL_DISP_FORMAT"
field. Document the Parallel Display Format Configuration(PDFC) subnode
and add the subnode to example.
Signed-off-by: Liu Ying
---
v2-&g
NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which
configures parallel display format by using the "PARALLEL_DISP_FORMAT"
field. Add a DRM bridge driver to support the display format configuration.
Signed-off-by: Liu Ying
---
v2->v3:
* No change.
v1->v2:
* Set
Fixes: cb285a5348e7 ("drm: mxsfb: Replace mxsfb_get_fb_paddr() with
drm_fb_cma_get_gem_addr()")
Signed-off-by: Liu Ying
---
drivers/gpu/drm/mxsfb/mxsfb_kms.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c
b/drivers/gpu/drm/mxsfb/mxsfb_kms.c
ind
Fixes: cb285a5348e7 ("drm: mxsfb: Replace mxsfb_get_fb_paddr() with
drm_fb_cma_get_gem_addr()")
Cc: sta...@vger.kernel.org # 5.19+
Signed-off-by: Liu Ying
---
v1->v2:
* Cc stable. (Marek)
drivers/gpu/drm/mxsfb/mxsfb_kms.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/dri
obot )
* Improve error messages for imx93_dsi_phy_init() in patch 9.
Liu Ying (9):
drm/bridge: synopsys: dw-mipi-dsi: Add dw_mipi_dsi_get_bridge() helper
drm/bridge: synopsys: dw-mipi-dsi: Add input bus format negotiation
support
drm/bridge: synopsys: dw-mipi-dsi: Force input bus fl
ormats through pdata->get_input_bus_fmts()
first. If it's unavailable, fall back to the only format - MEDIA_BUS_FMT_FIXED,
which matches the default behavior if ->atomic_get_input_bus_fmts() is not
implemented as ->atomic_get_input_bus_fmts()'s kerneldoc indicates.
Signed-off
Add dw_mipi_dsi_get_bridge() helper so that it can be used by vendor
drivers which implement vendor specific extensions to Synopsys DW MIPI DSI.
Signed-off-by: Liu Ying
---
v1->v3:
* No change.
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 ++
include/drm/bridge/dw_mipi_ds
.
Signed-off-by: Liu Ying
---
v1->v3:
* No change.
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
index 945d46a76995..ed9288a9c444 100
Vendor drivers may need to fixup mode due to pixel clock tree limitation,
so introduce the ->mode_fixup() callcack to struct dw_mipi_dsi_plat_data
and call it at atomic check stage if available.
Signed-off-by: Liu Ying
---
v1->v3:
* No change.
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.
video
mode.
Signed-off-by: Liu Ying
Reviewed-by: Neil Armstrong
---
v2->v3:
* Add Neil's R-b tag from v1.
v1->v2:
* No change.
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw
sum up
HSA, HBP, HFP and HDISPLAY.
This helps the case where Raydium RM67191 DSI panel is connected, since
it's video timing for hsync length is only 2 pixels and without this patch
the programmed value for DSI_VID_HSA_TIME is only 2 with 4 data lanes.
Signed-off-by: Liu Ying
Reviewed-
or doesn't happen for
the 1920x1080p@60 video mode at least.
Signed-off-by: Liu Ying
Reviewed-by: Neil Armstrong
---
v2->v3:
* Add Neil's R-b tag from v1.
v1->v2:
* No change.
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
di
Freescale i.MX93 SoC embeds a Synopsys Designware MIPI DSI host
controller and a Synopsys Designware MIPI DPHY. Some configurations
and extensions to them are controlled by i.MX93 media blk-ctrl.
Signed-off-by: Liu Ying
Reviewed-by: Rob Herring
---
v2->v3:
* No change.
v1->v2:
* Add Rob
i.MX93 MIPI DSI specific extensions.
Signed-off-by: Liu Ying
---
v2->v3:
* Select GENERIC_PHY to fix Kconfig warning for GENERIC_PHY_MIPI_DPHY
dependency.
v1->v2:
* Use dev_err_probe() to replace DRM_DEV_ERROR(). (Sam and Alexander)
* Use dev_*() to replace DRM_*(). (Sam)
* Fix build f
ys.
* Drop the device tree patches because we'll use new dt binding way to
support i.MX8qm/qxp clocks. This depends on a not-yet-landed patch set
to do basic conversions for the platforms.
* Fix dt binding yamllint warnings.
* Require bypass0 and bypass1 clocks for both i.MX8qxp and i.MX8q
This patch adds bindings for i.MX8qxp/qm Display Processing Unit.
Reviewed-by: Rob Herring
Signed-off-by: Liu Ying
---
v7->v14:
* No change.
v6->v7:
* Add Rob's R-b tag back.
v5->v6:
* Use graph schema. So, drop Rob's R-b tag as review is needed.
v4->v5:
* No chan
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Gasket.
Reviewed-by: Rob Herring
Signed-off-by: Liu Ying
---
v4->v14:
* No change.
v3->v4:
* Improve compatible property by using enum instead of oneOf+const. (Rob)
* Add Rob's R-b tag.
v2->v3:
* No change.
v1-
Artificially use 'plane' and 'old_plane_state' to avoid 'not used' warning.
The precedent has already been set by other macros in the same file.
Acked-by: Daniel Vetter
Signed-off-by: Liu Ying
---
v6->v14:
* No change.
v5->v6:
* Fix commit message typo -
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Channel.
Reviewed-by: Rob Herring
Signed-off-by: Liu Ying
---
v10->v14:
* No change.
v9->v10:
* Add Rob's R-b tag.
v8->v9:
* Reference 'interrupts-extended' schema instead of 'interrupts' to
Add myself as the maintainer of the i.MX8qxp DPU DRM driver.
Acked-by: Laurentiu Palcu
Signed-off-by: Liu Ying
---
v11->v14:
* No change.
v10->v11:
* Rebase upon v6.0-rc1.
v9->v10:
* Add Laurentiu's A-b tag.
v1->v9:
* No change.
MAINTAINERS | 9 +
1 file chan
driver.
Patch 8 adds DT-binding documentation for i.MX93 MIPI DSI.
Patch 9 adds i.MX93 MIPI DSI DRM bridge.
Liu Ying (9):
drm/bridge: synopsys: dw-mipi-dsi: Add dw_mipi_dsi_get_bridge() helper
drm/bridge: synopsys: dw-mipi-dsi: Add input bus format negotiation
support
drm/bridge: synopsys
Add dw_mipi_dsi_get_bridge() helper so that it can be used by vendor
drivers which implement vendor specific extensions to Synopsys DW MIPI DSI.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 ++
include/drm/bridge/dw_mipi_dsi.h | 2 ++
2 files
ormats through pdata->get_input_bus_fmts()
first. If it's unavailable, fall back to the only format - MEDIA_BUS_FMT_FIXED,
which matches the default behavior if ->atomic_get_input_bus_fmts() is not
implemented as ->atomic_get_input_bus_fmts()'s kerneldoc indicates.
Signed-off-b
Vendor drivers may need to fixup mode due to pixel clock tree limitation,
so introduce the ->mode_fixup() callcack to struct dw_mipi_dsi_plat_data
and call it at atomic check stage if available.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c |
.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
index 8580b8a97fb1..8cd89a63b5f2 100644
--- a/drivers/gpu/drm
video
mode.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
index c754d55f71d1..332388fd86da 100644
sum up
HSA, HBP, HFP and HDISPLAY.
This helps the case where Raydium RM67191 DSI panel is connected, since
it's video timing for hsync length is only 2 pixels and without this patch
the programmed value for DSI_VID_HSA_TIME is only 2 with 4 data lanes.
Signed-off-by: Liu Ying
---
drivers
or doesn't happen for
the 1920x1080p@60 video mode at least.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
b/drivers/gpu/drm/bridge/synopsys/dw-m
Freescale i.MX93 SoC embeds a Synopsys Designware MIPI DSI host
controller and a Synopsys Designware MIPI DPHY. Some configurations
and extensions to them are controlled by i.MX93 media blk-ctrl.
Signed-off-by: Liu Ying
---
.../display/bridge/fsl,imx93-mipi-dsi.yaml| 115
i.MX93 MIPI DSI specific extensions.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/bridge/imx/Kconfig | 10 +
drivers/gpu/drm/bridge/imx/Makefile | 1 +
drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c | 934
3 files changed, 945 insertions(+)
create mode 100644
the order is swapped, like the problematic case mentioned
in the below link.
Link:
https://lore.kernel.org/lkml/capdykfr0xjru_udkoukq_q8rwaukyql+8fv-7s1ctmqi7u3...@mail.gmail.com/T/
Suggested-by: Ulf Hansson
Signed-off-by: Liu Ying
---
drivers/gpu/drm/bridge/panel.c | 15 +++
1 file
the order is swapped, like the problematic case mentioned
in the below link.
Link:
https://lore.kernel.org/lkml/capdykfr0xjru_udkoukq_q8rwaukyql+8fv-7s1ctmqi7u3...@mail.gmail.com/T/
Suggested-by: Ulf Hansson
Signed-off-by: Liu Ying
---
v1->v2:
* Fix bailout for panel_bridge_attach() in c
we don't need
modeset, otherwise, we initialize the two EBA buffers with the buffer address.
Fixes: c6c1f9bc798b ("drm/imx: Add active plane reconfiguration support")
Cc: stable at vger.kernel.org # 4.8
Signed-off-by: Liu Ying
---
drivers/gpu/drm/imx/ipuv3-plane.c | 3 ++-
fb's pixel format is
probably not YU12 or YV12.
Link: https://bugs.freedesktop.org/show_bug.cgi?id=98150
Fixes: c6c1f9bc798b ("drm/imx: Add active plane reconfiguration support")
Cc: stable at vger.kernel.org # 4.8
Signed-off-by: Liu Ying
---
drivers/gpu/drm/imx/ipuv3-plane.c | 2 +
7;t
need modeset.
Fixes: c6c1f9bc798b ("drm/imx: Add active plane reconfiguration support")
Cc: stable at vger.kernel.org # 4.8
Signed-off-by: Liu Ying
---
drivers/gpu/drm/imx/ipuv3-plane.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/im
Hi Philipp,
2016-10-18 0:10 GMT+08:00 Philipp Zabel :
> Hi Liu,
>
> Am Montag, den 10.10.2016, 14:50 +0800 schrieb Liu Ying:
>> Before accessing the u/v offset(aka, u/vbo for IPUv3) of the old plane
>> state's
>> relevant fb, we should make sure the fb is in
fb's pixel format is
probably not YU12 or YV12.
Link: https://bugs.freedesktop.org/show_bug.cgi?id=98150
Fixes: c6c1f9bc798b ("drm/imx: Add active plane reconfiguration support")
Cc: stable at vger.kernel.org # 4.8
Signed-off-by: Liu Ying
---
v1->v2:
* Correct the condition under wh
Trivial fix.
Some dev_err messages in this driver are missing \n, so add them.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/bridge/sii902x.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
index 9126d03
No one is using the structure imx_drm_component, so let's remove the
definition to save several lines.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/imx/imx-drm-core.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/imx/imx-drm-core.c
b/drivers/gpu/drm/imx/imx-drm-c
mode setting as we don't need to handle
allocation failure cases then.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/imx/ipuv3-plane.c | 26 -
drivers/gpu/ipu-v3/ipu-dmfc.c | 213 ++
include/video/imx-ipu-v3.h| 3 -
3 files changed, 7
Now that we can use atomic configurations, all the legacy callbacks
of CRTCs, encoders and connectors can be switched to the atomic version.
For the imx-ldb driver, there is a clock parent setting mismatch bewteen
->enable and ->disable after the switch, so a fixup is added.
Signed-off-b
Signed-off-by: Liu Ying
---
drivers/gpu/drm/imx/ipuv3-plane.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c
b/drivers/gpu/drm/imx/ipuv3-plane.c
index 681ec6e..157032d 100644
--- a/drivers/gpu/drm/imx/ipuv3-plane.c
+++ b/drivers/gpu/drm/imx
gned-off-by: Liu Ying
---
drivers/gpu/drm/drm_crtc_helper.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/drm_crtc_helper.c
b/drivers/gpu/drm/drm_crtc_helper.c
index 79555d2..7fabcd7 100644
--- a/drivers/gpu/drm/drm_crtc_helper.c
+++ b/drivers/gpu/drm/drm_crtc_helper.c
Use drm_atomic_set_fb_for_plane() in the legacy ->page_flip path to track
the pointer plane_state->fb correctly.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/imx/ipuv3-crtc.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/imx/ipuv3-crtc.c b/drivers/gpu/drm/imx
This patch switches the update/disable_plane callbacks to their atomic version.
Also, use the default atomic helpers to implement the atomic_check/commit
callbacks for mode configuration.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/imx/imx-drm-core.c | 3 +++
drivers/gpu/drm/imx/ipuv3-plane.c
Hi,
This patch set converts imx drm into atomic mode setting.
It takes 3 phases to achieve the goal as recommended.
This patch set may apply to Philipp Zabel's open git branch imx-drm/fixes.
Liu Ying (14):
drm/imx: ipuv3-plane: Constify ipu_plane_funcs
drm/imx: plane: Don't set p
To support generic atomic page flip, this patch customizes ->atomic_commit
for async commits.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/imx/imx-drm-core.c | 137 +++-
drivers/gpu/drm/imx/ipuv3-crtc.c | 156 ++---
2 files chan
With all the beforehand phases and steps done, we can adverstise DRIVER_ATOMIC.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/imx/imx-drm-core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imx/imx-drm-core.c
b/drivers/gpu/drm/imx/imx-drm-core.c
index
ic_update
are always successful. Also, some necessary logics are tweaked for a smooth
transition.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/imx/ipuv3-crtc.c | 173 +++--
drivers/gpu/drm/imx/ipuv3-plane.c | 516 +++---
drivers/gpu/drm/imx/ipuv3-plan
ay implement
CRTC/plane atomic checks by using the new CRTC/plane states instead of the
legacy ones and we may remove the private ipu_crtc->enabled state which was
left there for the transitional atomic helpers in phase 1.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/imx/dw_hdmi-imx.c | 18 +++
Since the drm core sets plane->crtc correctly, we don't need to do that.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/imx/ipuv3-plane.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c
b/drivers/gpu/drm/imx/ipuv3-plane.c
index 157032d..e6ec8eb 1006
Wire up CRTCs', planes' and connectors' ->reset, ->duplicate and ->destroy state
hooks to use the default implementations from the atomic helper library.
The helpers track each DRM object state.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/bridge/dw-hdmi.c | 19 +++-
We should disable planes explicitly when suspending.
Especially, this is meaningful for those display controllers which
don't support active planes without relevant CRTCs being enabled.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/drm_atomic_helper.c | 18 +-
1 file change
501 - 600 of 1452 matches
Mail list logo
