ido Günther
Cc: Kishon Vijay Abraham I
Cc: Vinod Koul
Cc: Rob Herring
Cc: NXP Linux Team
Reviewed-by: Rob Herring
Reviewed-by: Guido Günther
Signed-off-by: Liu Ying
---
v6->v7:
* No change.
v5->v6:
* No change.
v4->v5:
* No change.
v3->v4:
* Add Rob's and Guido's R-
Add support for Mixel MIPI DPHY + LVDS PHY combo IP
as found on Freescale i.MX8qxp SoC.
Cc: Guido Günther
Cc: Kishon Vijay Abraham I
Cc: Vinod Koul
Cc: Rob Herring
Cc: NXP Linux Team
Reviewed-by: Rob Herring
Reviewed-by: Guido Günther
Signed-off-by: Liu Ying
---
v6->v7:
* No change.
-by: Guido Günther
Signed-off-by: Liu Ying
---
v6->v7:
* Use marco instead of magic number for CCM and CA values.
* Suppress 'checkpatch --strict' warnings.
v5->v6:
* No change.
v4->v5:
* No change.
v3->v4:
* Add Guido's R-b tag.
v2->v3:
* Improve readability of m
->v2:
* Convert mixel,mipi-dsi-phy plain text dt binding to json-schema. (Guido)
* Print invalid PHY mode in dmesg from the Mixel PHY driver. (Guido)
* Add Guido's R-b tag on the patch for the nwl-dsi drm bridge driver.
Liu Ying (5):
drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_mode_set()
: Robert Chiras
Cc: Martin Kepplinger
Cc: Andrzej Hajda
Cc: Neil Armstrong
Cc: Laurent Pinchart
Cc: Jonas Karlman
Cc: Jernej Skrabec
Cc: David Airlie
Cc: Daniel Vetter
Cc: NXP Linux Team
Signed-off-by: Liu Ying
---
v7->v8:
* No change.
v6->v7:
* No change.
v5->v6:
* Rebase the se
I
Cc: Vinod Koul
Cc: NXP Linux Team
Signed-off-by: Liu Ying
---
v7->v8:
* Trivial kernel doc style fix - add '*'.
v6->v7:
* Update the year of copyright.
* Better variable explanation for bits_per_lane_and_dclk_cycle.
v5->v6:
* Rebase upon v5.17-rc1.
v4->v5:
* Ali
ido Günther
Cc: Kishon Vijay Abraham I
Cc: Vinod Koul
Cc: Rob Herring
Cc: NXP Linux Team
Reviewed-by: Rob Herring
Reviewed-by: Guido Günther
Signed-off-by: Liu Ying
---
v7->v8:
* No change.
v6->v7:
* No change.
v5->v6:
* No change.
v4->v5:
* No change.
v3->v4:
* Add Rob'
Add support for Mixel MIPI DPHY + LVDS PHY combo IP
as found on Freescale i.MX8qxp SoC.
Cc: Guido Günther
Cc: Kishon Vijay Abraham I
Cc: Vinod Koul
Cc: Rob Herring
Cc: NXP Linux Team
Reviewed-by: Rob Herring
Reviewed-by: Guido Günther
Signed-off-by: Liu Ying
---
v7->v8:
* No change.
-by: Guido Günther
Signed-off-by: Liu Ying
---
v7->v8:
* No change.
v6->v7:
* Use marco instead of magic number for CCM and CA values.
* Suppress 'checkpatch --strict' warnings.
* Check !opts in mixel_dphy_configure().
v5->v6:
* No change.
v4->v5:
* No change.
v3->v4
'clock-names' property in the PHY dt binding.
v1->v2:
* Convert mixel,mipi-dsi-phy plain text dt binding to json-schema. (Guido)
* Print invalid PHY mode in dmesg from the Mixel PHY driver. (Guido)
* Add Guido's R-b tag on the patch for the nwl-dsi drm bridge driver.
Liu Ying (
: Robert Chiras
Cc: Martin Kepplinger
Cc: Andrzej Hajda
Cc: Neil Armstrong
Cc: Laurent Pinchart
Cc: Jonas Karlman
Cc: Jernej Skrabec
Cc: David Airlie
Cc: Daniel Vetter
Cc: NXP Linux Team
Signed-off-by: Liu Ying
---
v7->v8:
* Resend with Andrzej's and Jernej's mail addressed upd
I
Cc: Vinod Koul
Cc: NXP Linux Team
Signed-off-by: Liu Ying
---
v7->v8:
* Trivial kernel doc style fix - add '*'.
v6->v7:
* Update the year of copyright.
* Better variable explanation for bits_per_lane_and_dclk_cycle.
v5->v6:
* Rebase upon v5.17-rc1.
v4->v5:
* Ali
ido Günther
Cc: Kishon Vijay Abraham I
Cc: Vinod Koul
Cc: Rob Herring
Cc: NXP Linux Team
Reviewed-by: Rob Herring
Reviewed-by: Guido Günther
Signed-off-by: Liu Ying
---
v7->v8:
* No change.
v6->v7:
* No change.
v5->v6:
* No change.
v4->v5:
* No change.
v3->v4:
* Add Rob'
Add support for Mixel MIPI DPHY + LVDS PHY combo IP
as found on Freescale i.MX8qxp SoC.
Cc: Guido Günther
Cc: Kishon Vijay Abraham I
Cc: Vinod Koul
Cc: Rob Herring
Cc: NXP Linux Team
Reviewed-by: Rob Herring
Reviewed-by: Guido Günther
Signed-off-by: Liu Ying
---
v7->v8:
* No change.
-by: Guido Günther
Signed-off-by: Liu Ying
---
v7->v8:
* No change.
v6->v7:
* Use marco instead of magic number for CCM and CA values.
* Suppress 'checkpatch --strict' warnings.
* Check !opts in mixel_dphy_configure().
v5->v6:
* No change.
v4->v5:
* No change.
v3->v4
tion to change the description of
pm_runtime_resume() to reflect the new behavior of rpm_resume().
Cc: Rafael J. Wysocki
Cc: Len Brown
Cc: Pavel Machek
Cc: Greg Kroah-Hartman
Cc: Ulf Hansson
Cc: Douglas Anderson
Signed-off-by: Liu Ying
---
Documentation/power/runtime_pm.rst | 14 +++---
drivers/base
. Then, device
usage count will be 1 after pm_runtime_put() is called at dpm_complete
stage.
Also, update the documentation to change the description of
pm_runtime_resume() to reflect the new behavior of rpm_resume().
Cc: Rafael J. Wysocki
Cc: Len Brown
Cc: Pavel Machek
Cc: Greg Kroah-Hartma
On Fri, 2022-09-23 at 15:48 +0200, Ulf Hansson wrote:
> On Fri, 23 Sept 2022 at 14:47, Liu Ying wrote:
> >
> > After a device transitions to sleep state through it's system
> > suspend
> > callback pm_runtime_force_suspend(), the device's driver may still
On Mon, 2022-09-26 at 11:47 +0200, Ulf Hansson wrote:
> On Fri, 23 Sept 2022 at 17:23, Liu Ying wrote:
> > On Fri, 2022-09-23 at 15:48 +0200, Ulf Hansson wrote:
> > > On Fri, 23 Sept 2022 at 14:47, Liu Ying wrote:
> > > > After a device transitions to s
didn't check other coefficients closely though.
[...]
> @@ -456,6 +574,12 @@ static const u32 lcdif_primary_plane_formats[] = {
> DRM_FORMAT_XRGB1555,
> DRM_FORMAT_XRGB,
> DRM_FORMAT_XRGB,
> +
> + /* packed YCbCr */
Nitpick: Add a similar comment for above RGB pixel formats?
Regards,
Liu Ying
> + DRM_FORMAT_YUYV,
> + DRM_FORMAT_YVYU,
> + DRM_FORMAT_UYVY,
> + DRM_FORMAT_VYUY,
> };
nged, 2 insertions(+), 2 deletions(-)
Reviewed-by: Liu Ying
field values
> ---
> drivers/gpu/drm/mxsfb/lcdif_regs.h | 28 ++--
> 1 file changed, 14 insertions(+), 14 deletions(-)
One option is to use FIELD_RPEP() macro for register field values.
But I think this patch is ok without using it, so:
Reviewed-by: Liu Ying
quot;)
> Signed-off-by: Laurent Pinchart
> ---
> Changes since v1:
>
> - Use coefficients from imx-pxp.c
> ---
> drivers/gpu/drm/mxsfb/lcdif_kms.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
With the typo in commit message fixed:
Reviewed-by: Liu Ying
with YUV
fb. Looks like something with wrong stride. XR24 fb is ok, but RG16 fb
has similar issue. Anything I missed?
The command I'm using to test YUV fb:
modetest -M imx-lcdif -P 31@35:1920x1200@YUYV
Liu Ying
lity better and tell which coefficient is which.
Also for RGB to YCbCr conversion if you want to do that with this
series. Sorry for not pointing this out in v2 review cycle.
> + */
> +static const u32 lcdif_yuv2rgb_coeffs[3][2][6] = {
[...]
> + /* YUYV Formats */
'YUV Formats&#x
display image for YUV framebuffers due to
the pre-existing bug that Laurent claims, I choose to trust Laurent,
so:
Reviewed-by: Liu Ying
Thanks Laurent and Kieran for the work.
+*/
> > + ctrl = CTRLDESCL0_3_P_SIZE(2) | CTRLDESCL0_3_T_SIZE(2) |
> > + CTRLDESCL0_3_PITCH(lcdif->crtc.primary->state->fb-
> > >pitches[0]);
> > + writel(ctrl, lcdif->base + LCDC_V8_CTRLDESCL0_3);
Nit: I would write the register directly, i
Hi Kishon, Vinod,
Any follow-up comments/suggestions based on my previous reply?
Or, perhaps, just keep the patch as-is to support the generic lvds phy
configuration structure?
Thanks,
Liu Ying
On Thu, 2021-04-01 at 16:36 +0800, Liu Ying wrote:
> Hi Kishon,
>
> First of all, thanks
On Wed, 2023-01-25 at 14:56 +0100, Marek Vasut wrote:
> On 1/25/23 07:40, Liu Ying wrote:
> > A valid bridge is already found in lcdif_attach_bridge() and set
> > to lcdif->bridge, so lcdif->bridge cannot be a NULL pointer. Drop
> > the unnecessary NULL pointer che
parallel output connects with this piece of small logic to configure
parallel display format.
Patch 1/2 adds NXP i.MX93 parallel display format configuration dt-bindings.
Patch 2/2 adds NXP i.MX93 parallel display format configuration DRM bridge
driver support.
Liu Ying (2):
dt-bindings: displ
NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which
configures parallel display format by using the "PARALLEL_DISP_FORMAT"
field. Add device tree bindings for the display format configuration.
Signed-off-by: Liu Ying
---
.../display/bridge/nxp,imx93-pdfc.yaml
NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which
configures parallel display format by using the "PARALLEL_DISP_FORMAT"
field. Add a DRM bridge driver to support the display format configuration.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/bridge/imx/Kconfig
On Sun, 2023-01-29 at 12:46 +0100, Krzysztof Kozlowski wrote:
> On 28/01/2023 04:47, Liu Ying wrote:
> > NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register
> > which
> > configures parallel display format by using the
> > "PARALLEL_DISP_FORMAT"
&g
On Mon, 2023-01-30 at 15:39 -0600, Rob Herring wrote:
> On Mon, Jan 30, 2023 at 04:39:05PM +0800, Liu Ying wrote:
> > On Sun, 2023-01-29 at 12:46 +0100, Krzysztof Kozlowski wrote:
> > > On 28/01/2023 04:47, Liu Ying wrote:
> > > > NXP i.MX93 mediamix blk-ctrl con
Hi,
This patch series aims to add BOE EV121WXM-N10-1850 panel support
in the DRM simple panel driver.
Patch 1/2 adds dt-bindings support for the panel.
Patch 2/2 adds the panel support in the DRM simple panel driver.
Liu Ying (2):
dt-bindings: display: simple: Add BOE EV121WXM-N10-1850 panel
Add BOE EV121WXM-N10-1850 12.1" WXGA (1280x800) TFT LCD panel
compatible string. The panel has a LVDS display interface.
The panel's product specification can be found at:
http://www.onetech.com.tw/files/EV121WXM-N10-1850ProductSpecification_20180801.pdf
Signed-off-by
Add BOE EV121WXM-N10-1850 12.1" WXGA (1280x800) TFT LCD panel support.
The panel has a LVDS display interface.
The panel's product specification can be found at:
http://www.onetech.com.tw/files/EV121WXM-N10-1850ProductSpecification_20180801.pdf
Signed-off-by: Liu Ying
---
drivers/gpu
if_attach_bridge(). (Lothar)
* Add comment on the 'base' member of lcdif_crtc_state structure to
note it should always be the first member. (Lothar)
* Drop unneeded 'bridges' member from lcdif_drm_private structure.
* Drop a comment about bridge input bus format from lcdif_crtc_at
). i.MX93
LCDIF IP is essentially the same to i.MX8MP LCDIF IP. Add device
tree binding for i.MX93 LCDIF.
Acked-by: Krzysztof Kozlowski
Reviewed-by: Marek Vasut
Signed-off-by: Liu Ying
---
v2->v3:
* No change.
v1->v2:
* Add Krzysztof's A-b and Marek's R-b tags on patch 1/6.
A valid bridge is already found in lcdif_attach_bridge() and set
to lcdif->bridge, so lcdif->bridge cannot be a NULL pointer. Drop
the unnecessary NULL pointer check in KMS stage.
Signed-off-by: Liu Ying
---
v2->v3:
* No change.
v1->v2:
* Split from patch 2/2 in v1. (Marek, Alexande
ucture is introduced to cache bus format
and bus flags states in ->atomic_check() so that they can be read
in ->atomic_enable().
Signed-off-by: Liu Ying
---
v2->v3:
* No change.
v1->v2:
* Split from patch 2/2 in v1. (Marek, Alexander)
* Add comment on the 'base' member of lcdif
The single LCDIF embedded in i.MX93 SoC may drive multiple displays
simultaneously. Check bus format and flags across first bridges in
->atomic_check() to ensure they are consistent. This is a preparation
for adding i.MX93 LCDIF support.
Signed-off-by: Liu Ying
---
v2->v3:
* No change.
pport.
Signed-off-by: Liu Ying
---
v2->v3:
* No change.
v1->v2:
* Split from patch 2/2 in v1. (Marek, Alexander)
* Drop '!remote ||' from lcdif_attach_bridge(). (Lothar)
* Drop unneeded 'bridges' member from lcdif_drm_private structure.
drivers
With all previous preparations done to make it possible for the
single LCDIF embedded in i.MX93 SoC to drive multiple displays
simultaneously, add i.MX93 LCDIF compatible string as the last
step of adding i.MX93 LCDIF support.
Signed-off-by: Liu Ying
---
v2->v3:
* Fix a trivial typo in com
On Tue, 2023-02-14 at 15:12 +0100, Alexander Stein wrote:
> Hi Liu,
Hi Alexander,
>
> thanks for the update.
Thanks for your review.
>
> Am Montag, 13. Februar 2023, 09:56:09 CET schrieb Liu Ying:
> > Instead of determining LCDIF output bus format and bus flags in
>
On Wed, 2023-02-15 at 08:26 +0100, Alexander Stein wrote:
> Hi Liu,
Hi Alexander,
>
> thanks for the update.
Thanks for the review.
>
> Am Montag, 13. Februar 2023, 09:56:07 CET schrieb Liu Ying:
> > There is one LCDIF embedded in i.MX93 SoC to connect with
> >
On Wed, 2023-02-15 at 08:55 +0100, Alexander Stein wrote:
> Hi Liu,
Hi Alexander,
>
> thanks for the update.
Thanks for the review.
>
> Am Montag, 13. Februar 2023, 09:56:10 CET schrieb Liu Ying:
> > The single LCDIF embedded in i.MX93 SoC may drive multiple displa
On Wed, 2023-02-15 at 08:54 +0100, Alexander Stein wrote:
> Hi Liu,
Hi Alexander,
>
> thanks for the update.
Thanks for the review.
>
> Am Montag, 13. Februar 2023, 09:56:11 CET schrieb Liu Ying:
> > The single LCDIF embedded in i.MX93 SoC may drive multiple displa
it should always be the first member. (Lothar)
* Drop unneeded 'bridges' member from lcdif_drm_private structure.
* Drop a comment about bridge input bus format from lcdif_crtc_atomic_check().
Liu Ying (6):
dt-bindings: lcdif: Add i.MX93 LCDIF support
drm: lcdif: Drop unnecessary NUL
). i.MX93
LCDIF IP is essentially the same to i.MX8MP LCDIF IP. Add device
tree binding for i.MX93 LCDIF.
Acked-by: Krzysztof Kozlowski
Reviewed-by: Marek Vasut
Reviewed-by: Alexander Stein
Signed-off-by: Liu Ying
---
v3->v4:
* Add Alexander's R-b tag.
v2->v3:
* No change.
v1
A valid bridge is already found in lcdif_attach_bridge() and set
to lcdif->bridge, so lcdif->bridge cannot be a NULL pointer. Drop
the unnecessary NULL pointer check in KMS stage.
Reviewed-by: Alexander Stein
Signed-off-by: Liu Ying
---
v3->v4:
* Add Alexander's R-b tag.
v2-&g
ucture is introduced to cache bus format
and bus flags states in ->atomic_check() so that they can be read
in ->atomic_enable().
Signed-off-by: Liu Ying
---
v3->v4:
* Use 'new_{c,p}state' instead of 'new_{crtc,plane}_state'. (Alexander)
* Simplify lcdif_crtc_reset() by c
The single LCDIF embedded in i.MX93 SoC may drive multiple displays
simultaneously. Check bus format and flags across first bridges in
->atomic_check() to ensure they are consistent. This is a preparation
for adding i.MX93 LCDIF support.
Signed-off-by: Liu Ying
---
v3->v4:
* No change.
pport.
Signed-off-by: Liu Ying
---
v3->v4:
* Improve warning message when ignoring invalid LCDIF OF endpoint ids.
(Alexander)
v2->v3:
* No change.
v1->v2:
* Split from patch 2/2 in v1. (Marek, Alexander)
* Drop '!remote ||' from lcdif_attach_bridge(). (Lothar)
* Drop unneed
With all previous preparations done to make it possible for the
single LCDIF embedded in i.MX93 SoC to drive multiple displays
simultaneously, add i.MX93 LCDIF compatible string as the last
step of adding i.MX93 LCDIF support.
Reviewed-by: Alexander Stein
Signed-off-by: Liu Ying
---
v3->
On Fri, 2023-02-17 at 09:18 +0100, Alexander Stein wrote:
> Hi Liu,
Hi Alexander,
>
> Am Freitag, 17. Februar 2023, 07:54:01 CET schrieb Liu Ying:
> > Hi,
> >
> > This patch set aims to add i.MX93 LCDIF display controller support
> > in the existing LCDIF D
On Mon, 2023-02-20 at 11:16 +0100, Alexander Stein wrote:
> Hi Liu,
Hi Alexander,
>
> Am Montag, 20. Februar 2023, 09:55:19 CET schrieb Alexander Stein:
> > Hi Liu,
> >
> > Am Freitag, 17. Februar 2023, 09:59:14 CET schrieb Liu Ying:
> > > On Fri, 2023-0
Hi Marcel,
On Wed, 2023-01-04 at 10:01 +, Marcel Ziswiler wrote:
> Hi Liu
>
> Thank you very much!
>
> On Wed, 2022-10-19 at 10:02 +0800, Liu Ying wrote:
> > This patch introduces i.MX8qm/qxp Display Processing Unit(DPU) DRM
> > support.
> >
> > DPU i
.
Patch 1/2 adds device tree binding for i.MX93 LDB in the existing
fsl,ldb.yaml.
Patch 2/2 adds i.MX93 LDB support in the existing i.MX8mp LDB DRM bridge
driver.
Liu Ying (2):
dt-bindings: display: bridge: ldb: Add i.MX93 LDB device tree binding
drm/bridge: fsl-ldb: Add i.MX93 LDB support
while
i.MX8mp LDB supports at most two. Add i.MX93 LDB device tree binding
in the existing i.MX8mp LDB device tree binding documentation.
Signed-off-by: Liu Ying
---
.../bindings/display/bridge/fsl,ldb.yaml | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --
ridge driver by adding i.MX93 LDB compatible string and
device data(to reflect different register offsets and LVDS_CTRL register
bit1 definition).
Signed-off-by: Liu Ying
---
drivers/gpu/drm/bridge/fsl-ldb.c | 53 ++--
1 file changed, 44 insertions(+), 9 deletions(-)
diff
.
Patch 1/2 adds device tree binding for i.MX93 LDB in the existing
fsl,ldb.yaml.
Patch 2/2 adds i.MX93 LDB support in the existing i.MX8mp LDB DRM bridge
driver.
v1->v2:
* Drop redundant "device tree binding" from patch 1/2's subject. (Krzysztof)
* Add Krzysztof's A-b tag
while
i.MX8mp LDB supports at most two. Add i.MX93 LDB device tree binding
in the existing i.MX8mp LDB device tree binding documentation.
Acked-by: Krzysztof Kozlowski
Signed-off-by: Liu Ying
---
v1->v2:
* Drop redundant "device tree binding" from patch subject. (Krzysztof)
* Add
ridge driver by adding i.MX93 LDB compatible string and
device data(to reflect different register offsets and LVDS_CTRL register
bit1 definition).
Signed-off-by: Liu Ying
---
v1->v2:
* No change.
drivers/gpu/drm/bridge/fsl-ldb.c | 53 ++--
1 file changed, 44 insertio
on patch 2/2.
v1->v2:
* Drop redundant "device tree binding" from patch 1/2's subject. (Krzysztof)
* Add Krzysztof's A-b tag on patch 1/2.
Liu Ying (2):
dt-bindings: display: bridge: ldb: Add i.MX93 LDB
drm/bridge: fsl-ldb: Add i.MX93 LDB support
.../bindings/d
while
i.MX8mp LDB supports at most two. Add i.MX93 LDB device tree binding
in the existing i.MX8mp LDB device tree binding documentation.
Acked-by: Krzysztof Kozlowski
Signed-off-by: Liu Ying
---
v2->v3:
* No change.
v1->v2:
* Drop redundant "device tree binding" from patch
ridge driver by adding i.MX93 LDB compatible string and
device data(to reflect different register offsets and LVDS_CTRL register
bit1 definition).
Reviewed-by: Marek Vasut
Signed-off-by: Liu Ying
---
v2->v3:
* Provide comment on LVDS_CTRL_LVDS_EN bit when defining it's macro. (Marek)
* Add Ma
flags
states so that the next downstream bridges may use consistent bus
format and bus flags.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/mxsfb/lcdif_drv.c | 73 +--
drivers/gpu/drm/mxsfb/lcdif_drv.h | 6 +-
drivers/gpu/drm/mxsfb/lcdif_kms.c | 206 --
3
). i.MX93
LCDIF IP is essentially the same to i.MX8MP LCDIF IP. Add device
tree binding for i.MX93 LCDIF.
Signed-off-by: Liu Ying
---
Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree
display.
Patch 1/2 adds device tree binding support for i.MX93 LCDIF in the
existing fsl,lcdif.yaml.
Patch 2/2 adds i.MX93 LCDIF support in the existing LCDIF DRM driver.
Liu Ying (2):
dt-bindings: lcdif: Add i.MX93 LCDIF support
drm: lcdif: Add i.MX93 LCDIF support
.../bindings/display
On Mon, 2023-01-23 at 09:13 +0100, Lothar Waßmann wrote:
> Hi,
Hi,
>
> On Mon, 23 Jan 2023 15:23:58 +0800 Liu Ying wrote:
> > The LCDIF embedded in i.MX93 SoC is essentially the same to those
> > in i.MX8mp SoC. However, i.MX93 LCDIF may connect with MIPI DSI
> > con
On Mon, 2023-01-23 at 16:57 +0100, Marek Vasut wrote:
> On 1/23/23 08:23, Liu Ying wrote:
> > The LCDIF embedded in i.MX93 SoC is essentially the same to those
> > in i.MX8mp SoC. However, i.MX93 LCDIF may connect with MIPI DSI
> > controller through LCDIF cross line
On Tue, 2023-01-24 at 12:15 +0100, Alexander Stein wrote:
> Hi,
Hi,
>
> Am Dienstag, 24. Januar 2023, 08:59:39 CET schrieb Liu Ying:
> > On Mon, 2023-01-23 at 16:57 +0100, Marek Vasut wrote:
> > > On 1/23/23 08:23, Liu Ying wrote:
> > > > The LCDIF embedded i
ber of lcdif_crtc_state structure to
note it should always be the first member. (Lothar)
* Drop unneeded 'bridges' member from lcdif_drm_private structure.
* Drop a comment about bridge input bus format from lcdif_crtc_atomic_check().
Liu Ying (6):
dt-bindings: lcdif: Add i.MX93 LCD
). i.MX93
LCDIF IP is essentially the same to i.MX8MP LCDIF IP. Add device
tree binding for i.MX93 LCDIF.
Acked-by: Krzysztof Kozlowski
Reviewed-by: Marek Vasut
Signed-off-by: Liu Ying
---
v1->v2:
* Add Krzysztof's A-b and Marek's R-b tags on patch 1/6.
Documentation/device
A valid bridge is already found in lcdif_attach_bridge() and set
to lcdif->bridge, so lcdif->bridge cannot be a NULL pointer. Drop
the unnecessary NULL pointer check in KMS stage.
Signed-off-by: Liu Ying
---
v1->v2:
* Split from patch 2/2 in v1. (Marek, Alexander)
drivers/gpu/
ucture is introduced to cache bus format
and bus flags states in ->atomic_check() so that they can be read
in ->atomic_enable().
Signed-off-by: Liu Ying
---
v1->v2:
* Split from patch 2/2 in v1. (Marek, Alexander)
* Add comment on the 'base' member of lcdif_crtc_state structure to
The single LCDIF embedded in i.MX93 SoC may drive multiple displays
simultaneously. Check bus format and flags across first bridges in
->atomic_check() to ensure they are consistent. This is a preparation
for adding i.MX93 LCDIF support.
Signed-off-by: Liu Ying
---
v1->v2:
* Split from p
With all previous preparations done to make it possible for the
single LCDIF embedded in i.MX93 SoC to drive multipledisplays
simultaneously, add i.MX93 LCDIF compatible string as the last
step of adding i.MX93 LCDIF support.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/mxsfb/lcdif_drv.c | 1
pport.
Signed-off-by: Liu Ying
---
v1->v2:
* Split from patch 2/2 in v1. (Marek, Alexander)
* Drop '!remote ||' from lcdif_attach_bridge(). (Lothar)
* Drop unneeded 'bridges' member from lcdif_drm_private structure.
drivers/gpu/drm/mxsfb/lcdif_drv.c | 68
A duplicated line 'select DRM_KMS_HELPER' was introduced in Kconfig file
by commit 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option"),
so remove it.
Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
Signed-off-by: Liu Ying
---
driver
xp clocks. This depends on a not-yet-landed patch set
to do basic conversions for the platforms.
* Fix dt binding yamllint warnings.
* Require bypass0 and bypass1 clocks for both i.MX8qxp and i.MX8qm in DPU's
dt binding documentation.
* Use new dt binding way to add clocks in the dt bin
This patch adds bindings for i.MX8qxp/qm Display Processing Unit.
Reviewed-by: Rob Herring
Signed-off-by: Liu Ying
---
v7->v12:
* No change.
v6->v7:
* Add Rob's R-b tag back.
v5->v6:
* Use graph schema. So, drop Rob's R-b tag as review is needed.
v4->v5:
* No chan
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Gasket.
Reviewed-by: Rob Herring
Signed-off-by: Liu Ying
---
v4->v12:
* No change.
v3->v4:
* Improve compatible property by using enum instead of oneOf+const. (Rob)
* Add Rob's R-b tag.
v2->v3:
* No change.
v1-
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Channel.
Reviewed-by: Rob Herring
Signed-off-by: Liu Ying
---
v10->v12:
* No change.
v9->v10:
* Add Rob's R-b tag.
v8->v9:
* Reference 'interrupts-extended' schema instead of 'interrupts' to
Add myself as the maintainer of the i.MX8qxp DPU DRM driver.
Acked-by: Laurentiu Palcu
Signed-off-by: Liu Ying
---
v11->v12:
* No change.
v10->v11:
* Rebase upon v6.0-rc1.
v9->v10:
* Add Laurentiu's A-b tag.
v1->v9:
* No change.
MAINTAINERS | 9 +
1 file chan
Artificially use 'plane' and 'old_plane_state' to avoid 'not used' warning.
The precedent has already been set by other macros in the same file.
Acked-by: Daniel Vetter
Signed-off-by: Liu Ying
---
v6->v12:
* No change.
v5->v6:
* Fix commit message typo -
ds on a not-yet-landed patch set
to do basic conversions for the platforms.
* Fix dt binding yamllint warnings.
* Require bypass0 and bypass1 clocks for both i.MX8qxp and i.MX8qm in DPU's
dt binding documentation.
* Use new dt binding way to add clocks in the dt binding examples.
* Address sev
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Gasket.
Reviewed-by: Rob Herring
Signed-off-by: Liu Ying
---
v4->v13:
* No change.
v3->v4:
* Improve compatible property by using enum instead of oneOf+const. (Rob)
* Add Rob's R-b tag.
v2->v3:
* No change.
v1-
This patch adds bindings for i.MX8qxp/qm Display Processing Unit.
Reviewed-by: Rob Herring
Signed-off-by: Liu Ying
---
v7->v13:
* No change.
v6->v7:
* Add Rob's R-b tag back.
v5->v6:
* Use graph schema. So, drop Rob's R-b tag as review is needed.
v4->v5:
* No chan
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Channel.
Reviewed-by: Rob Herring
Signed-off-by: Liu Ying
---
v10->v13:
* No change.
v9->v10:
* Add Rob's R-b tag.
v8->v9:
* Reference 'interrupts-extended' schema instead of 'interrupts' to
Artificially use 'plane' and 'old_plane_state' to avoid 'not used' warning.
The precedent has already been set by other macros in the same file.
Acked-by: Daniel Vetter
Signed-off-by: Liu Ying
---
v6->v13:
* No change.
v5->v6:
* Fix commit message typo -
Add myself as the maintainer of the i.MX8qxp DPU DRM driver.
Acked-by: Laurentiu Palcu
Signed-off-by: Liu Ying
---
v11->v13:
* No change.
v10->v11:
* Rebase upon v6.0-rc1.
v9->v10:
* Add Laurentiu's A-b tag.
v1->v9:
* No change.
MAINTAINERS | 9 +
1 file chan
rm_device' has no member named 'irq_enabled'
>
> 67 | drm->irq_enabled = true;
> |^~
I've sent v13 to fix the potential build break by removing this line
since drm->irq_enabled should only be used by legacy drm drivers with
userspace modesetting but not imx-dpu drm driver.
Thanks for reporting the issue.
Liu Ying
[...]
Hi Philipp,
On Sun, 2022-10-09 at 10:35 +0800, Liu Ying wrote:
> A duplicated line 'select DRM_KMS_HELPER' was introduced in Kconfig
> file
> by commit 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER
> option"),
> so remove it.
>
> Fixes: 09717af7d13
ort for i.MX8MP LCDIF variant")
> Signed-off-by: Marek Vasut
> ---
> Cc: Kieran Bingham
> Cc: Laurent Pinchart
> Cc: Liu Ying
> Cc: Lucas Stach
> Cc: Marco Felsch
> Cc: Martyn Welch
> Cc: Peng Fan
> Cc: Sam Ravnborg
> ---
> drivers/gpu/drm/mxsfb/l
On Thu, 2022-10-27 at 12:03 +0200, Marek Vasut wrote:
> On 10/27/22 07:45, Liu Ying wrote:
>
> Hi,
>
> [...]
>
> > > diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c
> > > b/drivers/gpu/drm/mxsfb/lcdif_kms.c
> > > index a5302006c02cd..aee7babb5
On Fri, 2022-10-28 at 02:03 +0200, Marek Vasut wrote:
> On 10/27/22 19:47, Marco Felsch wrote:
> > On 22-10-27, Liu Ying wrote:
> > > On Thu, 2022-10-27 at 12:03 +0200, Marek Vasut wrote:
> > > > On 10/27/22 07:45, Liu Y
On Tue, 2022-11-01 at 15:04 +0100, Marco Felsch wrote:
> Hi Marek, Liu,
Hi,
>
> On 22-10-28, Liu Ying wrote:
> > On Fri, 2022-10-28 at 02:03 +0200, Marek Vasut wrote:
> > > On 10/27/22 19:47, Marco Felsch wrote:
> > > > On 22-10-27, Liu Ying wrote:
> &g
rm: lcdif: Add support for i.MX8MP LCDIF
> variant")
> Signed-off-by: Marek Vasut
> ---
> Cc: Kieran Bingham
> Cc: Laurent Pinchart
> Cc: Liu Ying
> Cc: Lucas Stach
> Cc: Marco Felsch
> Cc: Martyn Welch
> Cc: Peng Fan
> Cc: Sam Ravnborg
> ---
> V2: -
401 - 500 of 1452 matches
Mail list logo
