Re: [PATCH] drm/atomic: Check new_crtc_state->active to determine if CRTC needs disable in self refresh mode

2022-01-07 Thread Liu Ying
On Fri, 2022-01-07 at 14:53 -0500, Alex Deucher wrote: > On Wed, Dec 29, 2021 at 11:07 PM Liu Ying wrote: > > > > Actual hardware state of CRTC is controlled by the member 'active' > > in > > struct drm_crtc_state instead of the member 'enable', ac

[PATCH] drm/self_refresh: Don't trigger the entry timer for self refresh work if CRTC state is inactive

2022-01-10 Thread Liu Ying
self refresh work(the CRTC is disabled, while the relevant encoder and bridges could be disabled or not depending on the drivers). Cc: Rob Clark Cc: Sean Paul Cc: Zain Wang Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Signed-off-by: Liu

[PATCH] drm/imx: imx-ldb: detach existing panels when unbinding the driver

2016-08-12 Thread Liu Ying
We should detach existing panels when unbinding the driver since they are attached at the binding stage, otherwise, the attaching function would return the -EBUSY value when the ldb driver module is installed again. Signed-off-by: Liu Ying --- drivers/gpu/drm/imx/imx-ldb.c | 3 +++ 1 file

[PATCH] drm/imx: Add active primary plane reconfiguration support

2016-08-15 Thread Liu Ying
plane reconfiguration support by forcing CRTC mode change and disabling-enabling plane in plane's ->atomic_update callback. Suggested-by: Daniel Vetter Cc: Philipp Zabel Cc: David Airlie Cc: Russell King Cc: Daniel Vetter Cc: Peter Senna Tschudin Signed-off-by: Liu Ying --- drivers/gp

[PATCH] drm/imx: Add active primary plane reconfiguration support

2016-08-15 Thread Liu Ying
2016-08-15 15:18 GMT+08:00 Daniel Vetter : > On Mon, Aug 15, 2016 at 02:09:13PM +0800, Liu Ying wrote: >> We don't support configuring active primary plane on-the-fly for imx-drm. >> The relevant CRTC should be disabled before the plane configuration. >> Of course,

[PATCH v2] drm/imx: Add active plane reconfiguration support

2016-08-15 Thread Liu Ying
bling plane in plane's ->atomic_update callback. Suggested-by: Daniel Vetter Cc: Philipp Zabel Cc: David Airlie Cc: Russell King Cc: Daniel Vetter Cc: Peter Senna Tschudin Signed-off-by: Liu Ying --- v1->v2: * Do not reject reconfiguring an active overlay plane. drivers/gpu/drm/im

[PATCH v3 0/3] drm/imx: Add active plane reconfiguration support

2016-08-19 Thread Liu Ying
;atomic_disable callback, but not in each plane's ->atomic_update callback, as suggested by Daniel Vetter. * +Cc Lucas Stach, as he tested the patch v2. v1->v2: * Do not reject reconfiguring an active overlay plane. Liu Ying (3): drm/atomic-helper: Add atomic_disable CRTC helper call

[PATCH v3 1/3] drm/atomic-helper: Add atomic_disable CRTC helper callback

2016-08-19 Thread Liu Ying
the old CRTC state for disable operation. Suggested-by: Daniel Vetter Cc: Philipp Zabel Cc: David Airlie Cc: Russell King Cc: Daniel Vetter Cc: Peter Senna Tschudin Cc: Lucas Stach Signed-off-by: Liu Ying --- v3: * Newly introduced in v3. drivers/gpu/drm/drm_atomic_helper.c | 2

[PATCH v3 2/3] drm/imx: ipuv3-crtc: Use the callback ->atomic_disable instead of ->disable

2016-08-19 Thread Liu Ying
Now that the drm atomic core supports the callback ->atomic_disable, we may replace the legacy one ->disable with it. Cc: Philipp Zabel Cc: David Airlie Cc: Russell King Cc: Daniel Vetter Cc: Peter Senna Tschudin Cc: Lucas Stach Signed-off-by: Liu Ying --- v3: * Newly introduced

[PATCH v3 3/3] drm/imx: Add active plane reconfiguration support

2016-08-19 Thread Liu Ying
Cc: Russell King Cc: Daniel Vetter Cc: Peter Senna Tschudin Cc: Lucas Stach Signed-off-by: Liu Ying --- v2->v3: * Disable all appropriate affected planes(when necessary) in CRTC's ->atomic_disable callback, but not in each plane's ->atomic_update callback, as suggested by

[PATCH v8 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

2022-06-08 Thread Liu Ying
p LDB bridge driver. * Use of_graph_get_endpoint_by_regs() and of_graph_get_remote_endpoint() to get the input remote endpoint in imx8qxp_ldb_set_di_id() of i.MX8qxp LDB bridge driver. * Avoid using companion_port OF node after putting it in imx8qxp_ldb_parse_dt_companion() of i.MX8qxp LDB

[PATCH v8 01/14] media: uapi: Add some RGB bus formats for i.MX8qm/qxp pixel combiner

2022-06-08 Thread Liu Ying
bus(12-bit per component) to a pixel link. Reviewed-by: Robert Foss Reviewed-by: Laurent Pinchart Signed-off-by: Liu Ying --- v7->v8: * No change. v6->v7: * No change. v5->v6: * Add Laurent's R-b tag. v4->v5: * Add Robert's R-b tag. v3->v4: * No change. v2->v3

[PATCH v8 02/14] media: docs: Add some RGB bus formats for i.MX8qm/qxp pixel combiner

2022-06-08 Thread Liu Ying
or a 36-bit output bus(12-bit per component) to a pixel link. Reviewed-by: Robert Foss Reviewed-by: Laurent Pinchart Signed-off-by: Liu Ying --- Robert, I keep your R-b tag from v5. Let me know if you want me to drop it, as v6 contains a fix. v7->v8: * No change. v6->v7: * No change.

[PATCH v8 03/14] dt-bindings: display: bridge: Add i.MX8qm/qxp pixel combiner binding

2022-06-08 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp pixel combiner. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v7->v8: * No change. v6->v7: * No change. v5->v6: * No change. v4->v5: * No change. v3->v4: * No change. v2->v3: * Add Rob's R-b tag. v1->v2: * Use gra

[PATCH v8 04/14] drm/bridge: imx: Add i.MX8qm/qxp pixel combiner support

2022-06-08 Thread Liu Ying
-off-by: Liu Ying --- Robert, I keep your R-b tag from v5. Let me know if you want me to drop it, as v7 contains a fix for checkpatch complaints. Marcel, as the fix is trivial, I add your T-b tag. Let me know if you want me to drop it. v7->v8: * No change. v6->v7: * Fix 'Alignment s

[PATCH v8 05/14] dt-bindings: display: bridge: Add i.MX8qm/qxp display pixel link binding

2022-06-08 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp display pixel link. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v7->v8: * No change. v6->v7: * No change. v5->v6: * No change. v4->v5: * No change. v3->v4: * No change. v2->v3: * Add Rob's R-b tag. v1->v2: *

[PATCH v8 06/14] drm/bridge: imx: Add i.MX8qm/qxp display pixel link support

2022-06-08 Thread Liu Ying
control interface. Reviewed-by: Robert Foss Tested-by: Marcel Ziswiler # Colibri iMX8X, LT170410-2WHC, LP156WF1 Signed-off-by: Liu Ying --- Robert, I keep your R-b tag from v5. Let me know if you want me to drop it, as v7 contains a fix for checkpatch complaints. Marcel, as the fix is trivial

[PATCH v8 07/14] dt-bindings: display: bridge: Add i.MX8qxp pixel link to DPI binding

2022-06-08 Thread Liu Ying
This patch adds bindings for i.MX8qxp pixel link to DPI(PXL2DPI). Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v7->v8: * No change. v6->v7: * No change. v5->v6: * Add Rob's R-b tag. v4->v5: * No change. v3->v4: * Add 'fsl,sc-resource' property. (Ro

[PATCH v8 08/14] drm/bridge: imx: Add i.MX8qxp pixel link to DPI support

2022-06-08 Thread Liu Ying
codings between those modules. The PXL2DPI is purely combinatorial. Tested-by: Marcel Ziswiler # Colibri iMX8X, LT170410-2WHC, LP156WF1 Reviewed-by: Robert Foss Signed-off-by: Liu Ying --- Marcel, I add your T-b tag from v6, let me know if you want me to drop it, as the checkpatch fix and

[PATCH v8 09/14] drm/bridge: imx: Add LDB driver helper support

2022-06-08 Thread Liu Ying
-by: Liu Ying --- Marcel, I add your T-b tag from v6, let me know if you want me to drop it, as the checkpatch fix in v7 and the rebase in v8 are trivial. v7->v8: * Use devm_drm_of_get_bridge() due to the rebase upon v5.19-rc1. v6->v7: * Fix below complaints from 'checkpatch.pl --stric

[PATCH v8 10/14] dt-bindings: display: bridge: Add i.MX8qm/qxp LVDS display bridge binding

2022-06-08 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp LVDS display bridge(LDB). Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v7->v8: * No change. v6->v7: * No change. v5->v6: * No change. v4->v5: * No change. v3->v4: * Add Rob's R-b tag. v2->v3: * Drop 'fsl,syscon&#x

[PATCH v8 11/14] drm/bridge: imx: Add LDB support for i.MX8qxp

2022-06-08 Thread Liu Ying
supports the LDB single mode and split mode. Tested-by: Marcel Ziswiler # Colibri iMX8X, LT170410-2WHC, LP156WF1 Reviewed-by: Robert Foss Signed-off-by: Liu Ying --- Marcel, I add your T-b tag from v6, let me know if you want me to drop it, as the checkpatch fix in v7 is trivial. v7->v8: * No cha

[PATCH v8 12/14] drm/bridge: imx: Add LDB support for i.MX8qm

2022-06-08 Thread Liu Ying
Reviewed-by: Robert Foss Signed-off-by: Liu Ying --- Marcel, I add your T-b tag from v6, let me know if you want me to drop it, as the checkpatch fix in v7 is trivial. v7->v8: * No change. v6->v7: * Fix below complaints from 'checkpatch.pl --strict'. (Robert) - 'Prefe

[PATCH v8 13/14] dt-bindings: mfd: Add i.MX8qm/qxp Control and Status Registers module binding

2022-06-08 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp Control and Status Registers module. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v7->v8: * No change. v6->v7: * Add Rob's R-b tag. v5->v6: * Drop 'select' schema. (Rob) v4->v5: * Newly introduced in v5. (Rob) .

[PATCH v8 14/14] MAINTAINERS: add maintainer for DRM bridge drivers for i.MX SoCs

2022-06-08 Thread Liu Ying
Add myself as the maintainer of DRM bridge drivers for i.MX SoCs. Reviewed-by: Robert Foss Signed-off-by: Liu Ying --- v7->v8: * No change. v6->v7: * Add Robert's R-b tag. v5->v6: * No change. v4->v5: * No change. v3->v4: * No change. v2->v3: * No chang

Re: [PATCH v8 03/14] dt-bindings: display: bridge: Add i.MX8qm/qxp pixel combiner binding

2022-06-09 Thread Liu Ying
Hi Laurent, On Thu, 2022-06-09 at 11:24 +0300, Laurent Pinchart wrote: > Hi Liu, > > Thank you for the patch. Thank you for the review. > > On Thu, Jun 09, 2022 at 02:49:20PM +0800, Liu Ying wrote: > > This patch adds bindings for i.MX8qm/qxp pixel combiner. > > &

Re: [PATCH v8 06/14] drm/bridge: imx: Add i.MX8qm/qxp display pixel link support

2022-06-09 Thread Liu Ying
Hi Laurent, On Thu, 2022-06-09 at 12:30 +0300, Laurent Pinchart wrote: > Hi Liu, > > Thank you for the patch. Thank you for the review. > > On Thu, Jun 09, 2022 at 02:49:23PM +0800, Liu Ying wrote: > > This patch adds a drm bridge driver for i.MX8qm/qxp display pixel &g

Re: [PATCH v8 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

2022-06-09 Thread Liu Ying
Hi Laurent, On Thu, 2022-06-09 at 12:32 +0300, Laurent Pinchart wrote: > Hi Liu, > > On Thu, Jun 09, 2022 at 02:49:17PM +0800, Liu Ying wrote: > > Hi, > > > > This is the v8 series to add some DRM bridge drivers support > > for i.MX8qm/qxp SoCs. > > >

Re: (EXT) [PATCH v8 09/14] drm/bridge: imx: Add LDB driver helper support

2022-06-09 Thread Liu Ying
On Thu, 2022-06-09 at 09:47 +0200, Alexander Stein wrote: > Am Donnerstag, 9. Juni 2022, 08:49:26 CEST schrieb Liu Ying: > > This patch adds a helper to support LDB drm bridge drivers for > > i.MX SoCs. Helper functions supported by this helper should > > implement comm

[PATCH v9 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

2022-06-11 Thread Liu Ying
to get the input remote endpoint in imx8qxp_ldb_set_di_id() of i.MX8qxp LDB bridge driver. * Avoid using companion_port OF node after putting it in imx8qxp_ldb_parse_dt_companion() of i.MX8qxp LDB bridge driver. * Drop unnecessary check for maximum available LDB channels from i.MX8qm LDB bridge dr

[PATCH v9 01/14] media: uapi: Add some RGB bus formats for i.MX8qm/qxp pixel combiner

2022-06-11 Thread Liu Ying
bus(12-bit per component) to a pixel link. Reviewed-by: Robert Foss Reviewed-by: Laurent Pinchart Signed-off-by: Liu Ying --- v8->v9: * No change. v7->v8: * No change. v6->v7: * No change. v5->v6: * Add Laurent's R-b tag. v4->v5: * Add Robert's R-b tag. v3->v4

[PATCH v9 03/14] dt-bindings: display: bridge: Add i.MX8qm/qxp pixel combiner binding

2022-06-11 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp pixel combiner. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v8->v9: * No change. v7->v8: * No change. v6->v7: * No change. v5->v6: * No change. v4->v5: * No change. v3->v4: * No change. v2->v3: * Add Rob's R-b

[PATCH v9 02/14] media: docs: Add some RGB bus formats for i.MX8qm/qxp pixel combiner

2022-06-11 Thread Liu Ying
or a 36-bit output bus(12-bit per component) to a pixel link. Reviewed-by: Robert Foss Reviewed-by: Laurent Pinchart Signed-off-by: Liu Ying --- Robert, I keep your R-b tag from v5. Let me know if you want me to drop it, as v6 contains a fix. v8->v9: * No change. v7->v8: * No change.

[PATCH v9 04/14] drm/bridge: imx: Add i.MX8qm/qxp pixel combiner support

2022-06-11 Thread Liu Ying
-off-by: Liu Ying --- Robert, I keep your R-b tag from v5. Let me know if you want me to drop it, as v7 contains a fix for checkpatch complaints. Marcel, as the fix is trivial, I add your T-b tag. Let me know if you want me to drop it. v8->v9: * No change. v7->v8: * No change. v6->

[PATCH v9 05/14] dt-bindings: display: bridge: Add i.MX8qm/qxp display pixel link binding

2022-06-11 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp display pixel link. Signed-off-by: Liu Ying --- v8->v9: * Add 'fsl,dc-id' and 'fsl,dc-stream-id' properties. (Laurent) * Drop Rob's R-b tag. v7->v8: * No change. v6->v7: * No change. v5->v6: * No change. v4->v5

[PATCH v9 06/14] drm/bridge: imx: Add i.MX8qm/qxp display pixel link support

2022-06-11 Thread Liu Ying
control interface. Reviewed-by: Robert Foss Tested-by: Marcel Ziswiler # Colibri iMX8X, LT170410-2WHC, LP156WF1 Signed-off-by: Liu Ying --- Robert, I keep your R-b tag from v5. Let me know if you want me to drop it, as v7 contains a fix for checkpatch complaints and change in v9 is kinda

[PATCH v9 07/14] dt-bindings: display: bridge: Add i.MX8qxp pixel link to DPI binding

2022-06-11 Thread Liu Ying
This patch adds bindings for i.MX8qxp pixel link to DPI(PXL2DPI). Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v8->v9: * No change. v7->v8: * No change. v6->v7: * No change. v5->v6: * Add Rob's R-b tag. v4->v5: * No change. v3->v4: * Add 'fsl,sc-resou

[PATCH v9 08/14] drm/bridge: imx: Add i.MX8qxp pixel link to DPI support

2022-06-11 Thread Liu Ying
codings between those modules. The PXL2DPI is purely combinatorial. Tested-by: Marcel Ziswiler # Colibri iMX8X, LT170410-2WHC, LP156WF1 Reviewed-by: Robert Foss Signed-off-by: Liu Ying --- Marcel, I add your T-b tag from v6, let me know if you want me to drop it, as the checkpatch fix and

[PATCH v9 09/14] drm/bridge: imx: Add LDB driver helper support

2022-06-11 Thread Liu Ying
-by: Liu Ying --- Marcel, I add your T-b tag from v6, let me know if you want me to drop it, as the checkpatch fix in v7 and the rebase in v8 are trivial. v8->v9: * No change. v7->v8: * Use devm_drm_of_get_bridge() due to the rebase upon v5.19-rc1. v6->v7: * Fix below compla

[PATCH v9 10/14] dt-bindings: display: bridge: Add i.MX8qm/qxp LVDS display bridge binding

2022-06-11 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp LVDS display bridge(LDB). Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v8->v9: * No change. v7->v8: * No change. v6->v7: * No change. v5->v6: * No change. v4->v5: * No change. v3->v4: * Add Rob's R-b tag. v2-

[PATCH v9 11/14] drm/bridge: imx: Add LDB support for i.MX8qxp

2022-06-11 Thread Liu Ying
supports the LDB single mode and split mode. Tested-by: Marcel Ziswiler # Colibri iMX8X, LT170410-2WHC, LP156WF1 Reviewed-by: Robert Foss Signed-off-by: Liu Ying --- Marcel, I add your T-b tag from v6, let me know if you want me to drop it, as the checkpatch fix in v7 is trivial. v8->v9: * No cha

[PATCH v9 12/14] drm/bridge: imx: Add LDB support for i.MX8qm

2022-06-11 Thread Liu Ying
Reviewed-by: Robert Foss Signed-off-by: Liu Ying --- Marcel, I add your T-b tag from v6, let me know if you want me to drop it, as the checkpatch fix in v7 is trivial. v8->v9: * No change. v7->v8: * No change. v6->v7: * Fix below complaints from 'checkpatch.pl --strict'. (R

[PATCH v9 13/14] dt-bindings: mfd: Add i.MX8qm/qxp Control and Status Registers module binding

2022-06-11 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp Control and Status Registers module. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v8->v9: * No change. v7->v8: * No change. v6->v7: * Add Rob's R-b tag. v5->v6: * Drop 'select' schema. (Rob) v4->v5:

[PATCH v9 14/14] MAINTAINERS: add maintainer for DRM bridge drivers for i.MX SoCs

2022-06-11 Thread Liu Ying
Add myself as the maintainer of DRM bridge drivers for i.MX SoCs. Reviewed-by: Robert Foss Signed-off-by: Liu Ying --- v8->v9: * No change. v7->v8: * No change. v6->v7: * Add Robert's R-b tag. v5->v6: * No change. v4->v5: * No change. v3->v4: * No change. v2-&g

Re: [PATCH v9 05/14] dt-bindings: display: bridge: Add i.MX8qm/qxp display pixel link binding

2022-06-14 Thread Liu Ying
On Tue, 2022-06-14 at 14:11 -0600, Rob Herring wrote: > On Sat, Jun 11, 2022 at 10:14:12PM +0800, Liu Ying wrote: > > This patch adds bindings for i.MX8qm/qxp display pixel link. > > > > Signed-off-by: Liu Ying > > --- > > v8->v9: > > * Add 'fsl,dc-

Re: [PATCH] drm/bridge: imx: i.MX8 bridge drivers should depend on ARCH_MXC

2022-06-21 Thread Liu Ying
support. s/i.MX8MP/i.MX8/ For now, only i.MX8qm and i.MX8qxp display bridge drivers are in bridge/imx directory, no i.MX8MP display bridge driver. With this fixed: Reviewed-by: Liu Ying > > Fixes: e60c4354840b2fe8 ("drm/bridge: imx: Add LDB support for > i.MX8qm") > Fixes:

Re: [PATCH] [RFC] drm: mxsfb: Implement LCDIF scanout CRC32 support

2022-02-06 Thread Liu Ying
struct device_attribute *attr, > + char *buf) > +{ > + struct drm_device *drm = dev_get_drvdata(dev); > + struct mxsfb_drm_private *mxsfb = drm->dev_private; > + u32 hwcrc = readl(mxsfb->base, LCDC_V4_CRC_STAT); Access registe

[PATCH RESEND] drm/self_refresh: Don't trigger the entry timer for self refresh work if CRTC state is inactive

2022-02-06 Thread Liu Ying
self refresh work(the CRTC is disabled, while the relevant encoder and bridges could be disabled or not depending on the drivers). Cc: Rob Clark Cc: Sean Paul Cc: Zain Wang Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Signed-off-by: Liu

Re: [PATCH] [RFC] drm: mxsfb: Implement LCDIF scanout CRC32 support

2022-02-07 Thread Liu Ying
On Mon, 2022-02-07 at 09:14 +0100, Marek Vasut wrote: > On 2/7/22 06:13, Liu Ying wrote: > > Hi Marek, > > Hi, > > > On Sun, 2022-02-06 at 19:56 +0100, Marek Vasut wrote: > > > The LCDIF controller as present in i.MX6SX/i.MX8M Mini/Nano has a > > > CRC

Re: [PATCH] [RFC] drm: mxsfb: Implement LCDIF scanout CRC32 support

2022-02-07 Thread Liu Ying
On Mon, 2022-02-07 at 11:43 +0100, Marek Vasut wrote: > On 2/7/22 10:18, Liu Ying wrote: > > Hi, > > > > > On Sun, 2022-02-06 at 19:56 +0100, Marek Vasut wrote: > > > > > The LCDIF controller as present in i.MX6SX/i.MX8M Mini/Nano > > > > &

Re: [PATCH] [RFC] drm: mxsfb: Implement LCDIF scanout CRC32 support

2022-02-09 Thread Liu Ying
Hello Laurent, On Tue, 2022-02-08 at 05:03 +0200, Laurent Pinchart wrote: > Hello Liu Ying, > > On Tue, Feb 08, 2022 at 10:41:59AM +0800, Liu Ying wrote: > > On Mon, 2022-02-07 at 11:43 +0100, Marek Vasut wrote: > > > On 2/7/22 10:18, Liu Ying wrote: > > > > &

Re: [PATCH] [RFC] drm: mxsfb: Implement LCDIF scanout CRC32 support

2022-02-09 Thread Liu Ying
On Tue, 2022-02-08 at 11:02 +0100, Marek Vasut wrote: > On 2/8/22 03:41, Liu Ying wrote: > > Hello everyone, > > > > > > There are many blank areas which are undocumented, this LCDIF > > > > > CRC32 > > > > > feature, i.MX8M M

[PATCH] drm/bridge: nwl-dsi: Remove superfluous write to NWL_DSI_IRQ_MASK register

2022-02-16 Thread Liu Ying
To initialize register NWL_DSI_IRQ_MASK, it's enough to write it only once in function nwl_dsi_init_interrupts(). Signed-off-by: Liu Ying --- drivers/gpu/drm/bridge/nwl-dsi.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/bridge/nwl-ds

Re: [PATCH resend v8 0/5] phy: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2022-04-20 Thread Liu Ying
On Wed, 2022-04-20 at 13:00 +0530, Vinod Koul wrote: > On 19-04-22, 09:08, Liu Ying wrote: > > Hi, > > > > This is the v8 series to add i.MX8qxp LVDS PHY mode support for the > > Mixel > > PHY in the Freescale i.MX8qxp SoC. > > > > The Mixel PHY is M

Re: [PATCH resend v8 1/5] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_mode_set()

2022-04-29 Thread Liu Ying
Hi, On Fri, 2022-04-22 at 19:24 +0200, Guido Günther wrote: > Hi, > On Tue, Apr 19, 2022 at 09:08:48AM +0800, Liu Ying wrote: > > The Northwest Logic MIPI DSI host controller embedded in i.MX8qxp > > works with a Mixel MIPI DPHY + LVDS PHY combo to support either > > a MI

[PATCH v11 0/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2022-08-22 Thread Liu Ying
ire bypass0 and bypass1 clocks for both i.MX8qxp and i.MX8qm in DPU's dt binding documentation. * Use new dt binding way to add clocks in the dt binding examples. * Address several comments from Laurentiu on the DPU DRM patch. Liu Ying (6): dt-bindings: display: imx: Add i.MX

[PATCH v11 1/6] dt-bindings: display: imx: Add i.MX8qxp/qm DPU binding

2022-08-22 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Processing Unit. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v10->v11: * No change. v9->v10: * No change. v8->v9: * No change. v7->v8: * No change. v6->v7: * Add Rob's R-b tag back. v5->v6: * Use graph schema.

[PATCH v11 2/6] dt-bindings: display: imx: Add i.MX8qxp/qm PRG binding

2022-08-22 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Gasket. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v10->v11: * No change. v9->v10: * No change. v8->v9: * No change. v7->v8: * No change. v6->v7: * No change. v5->v6: * No change. v4->v5:

[PATCH v11 3/6] dt-bindings: display: imx: Add i.MX8qxp/qm DPR channel binding

2022-08-22 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Channel. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v10->v11: * No change. v9->v10: * Add Rob's R-b tag. v8->v9: * Reference 'interrupts-extended' schema instead of 'interrupts' to

[PATCH v11 4/6] drm/atomic: Avoid unused-but-set-variable warning on for_each_old_plane_in_state

2022-08-22 Thread Liu Ying
Artificially use 'plane' and 'old_plane_state' to avoid 'not used' warning. The precedent has already been set by other macros in the same file. Acked-by: Daniel Vetter Signed-off-by: Liu Ying --- v10->v11: * No change. v9->v10: * No change. v8->v9: * N

[PATCH v11 6/6] MAINTAINERS: add maintainer for i.MX8qxp DPU DRM driver

2022-08-22 Thread Liu Ying
Add myself as the maintainer of the i.MX8qxp DPU DRM driver. Acked-by: Laurentiu Palcu Signed-off-by: Liu Ying --- v10->v11: * Rebase upon v6.0-rc1. v9->v10: * Add Laurentiu's A-b tag. v8->v9: * No change. v7->v8: * No change. v6->v7: * No change. v5->v6: * No chang

Re: [PATCH v2] drm/bridge: imx: i.MX8 bridge drivers should depend on ARCH_MXC

2022-06-27 Thread Liu Ying
pport for > > i.MX8qxp") > > Fixes: 96988a526c97cfbe ("drm/bridge: imx: Add i.MX8qxp pixel link > > to DPI support") > > Fixes: 1ec17c26bc06289d ("drm/bridge: imx: Add i.MX8qm/qxp display > > pixel link support") > > Fixes: 93e163a9e0392aca

Re: [PATCH v6 2/2] drm: lcdif: Add support for i.MX8MP LCDIF variant

2022-06-30 Thread Liu Ying
(31, 16) > +#define HSYN_PARA_FP_H(n)

Re: [PATCH v6 2/2] drm: lcdif: Add support for i.MX8MP LCDIF variant

2022-06-30 Thread Liu Ying
On Thu, 2022-06-30 at 22:47 +0200, Marek Vasut wrote: > On 6/30/22 10:30, Liu Ying wrote: > > Hi Marek, > > Hi, > > > > drivers/gpu/drm/Makefile | 2 +- > > > drivers/gpu/drm/mxsfb/Kconfig | 16 + > > > drivers/gpu/drm/mxsfb

Re: [PATCH 1/4] drm/lcdif: Clean up headers

2022-06-30 Thread Liu Ying
t; Cc: Laurent Pinchart > Cc: Liu Ying > Cc: Lucas Stach > Cc: Marek Vasut > Cc: Martyn Welch > Cc: Peng Fan > Cc: Robby Cai > Cc: Sam Ravnborg > Cc: Stefan Agner If you want to add my 'Reported-by: Liu Ying ' tag, you may add it. Reviewed-by: Liu Ying

Re: [PATCH 2/4] drm/lcdif: Consistently use plane timings

2022-06-30 Thread Liu Ying
On Thu, 2022-06-30 at 22:57 +0200, Marek Vasut wrote: > Drop the crtc_ prefix from mode, consistently use the plane one. s/plane/plain/ Otherwise: Reviewed-by: Liu Ying If you want to add my 'Reported-by: Liu Ying ' tag, you may add it. > > Fixes: 9db35bb349a0e ("drm

Re: [PATCH 3/4] drm/lcdif: Clean up debug prints and comments

2022-06-30 Thread Liu Ying
Vasut > Cc: Alexander Stein > Cc: Laurent Pinchart > Cc: Liu Ying > Cc: Lucas Stach > Cc: Marek Vasut > Cc: Martyn Welch > Cc: Peng Fan > Cc: Robby Cai > Cc: Sam Ravnborg > Cc: Stefan Agner If you want to add my 'Reported-by: Liu Ying ' tag, you may add it. Reviewed-by: Liu Ying

Re: [PATCH 4/4] drm/lcdif: switch to devm_drm_of_get_bridge

2022-06-30 Thread Liu Ying
if: Add support for i.MX8MP LCDIF > variant") > Signed-off-by: Marek Vasut > Cc: Alexander Stein > Cc: Laurent Pinchart > Cc: Liu Ying > Cc: Lucas Stach > Cc: Marek Vasut > Cc: Martyn Welch > Cc: Peng Fan > Cc: Robby Cai > Cc: Sam Ravnborg > C

[PATCH 0/3] drm/bridge: fsl-ldb: A few fixes

2022-06-30 Thread Liu Ying
Hi, This series contains three fixes for the fsl-ldb bridge driver. Patch 1/3 fixes mode clock rate validation. Patch 2/3 fixes LVDS dual link mode. Patch 3/3 fixes input data enable signal polarity. Liu Ying (3): drm/bridge: fsl-ldb: Fix mode clock rate validation drm/bridge: fsl-ldb

[PATCH 1/3] drm/bridge: fsl-ldb: Fix mode clock rate validation

2022-06-30 Thread Liu Ying
scale i.MX8MP LDB bridge") Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: David Airlie Cc: Daniel Vetter Cc: Sam Ravnborg Cc: Marek Vasut Cc: NXP Linux Team Signed-off-by: Liu Ying --- drivers/gpu/drm/bridge/fsl-ldb.c

[PATCH 2/3] drm/bridge: fsl-ldb: Enable split mode for LVDS dual link

2022-06-30 Thread Liu Ying
Cc: David Airlie Cc: Daniel Vetter Cc: Sam Ravnborg Cc: Marek Vasut Cc: NXP Linux Team Signed-off-by: Liu Ying --- drivers/gpu/drm/bridge/fsl-ldb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm/bridge/fsl-ldb.c index 3c

[PATCH 3/3] drm/bridge: fsl-ldb: Drop DE signal polarity inversion

2022-06-30 Thread Liu Ying
niel Vetter Cc: Sam Ravnborg Cc: Marek Vasut Cc: NXP Linux Team Signed-off-by: Liu Ying --- drivers/gpu/drm/bridge/fsl-ldb.c | 17 - 1 file changed, 17 deletions(-) diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm/bridge/fsl-ldb.c index d4f005eef6f6..4b503c54

Re: [PATCH v2] drm/bridge: imx: i.MX8 bridge drivers should depend on ARCH_MXC

2022-07-01 Thread Liu Ying
Hi Neil, Robert, On Tue, 2022-06-28 at 09:10 +0200, Neil Armstrong wrote: > On 28/06/2022 04:31, Liu Ying wrote: > > On Mon, 2022-06-27 at 14:22 +0200, Neil Armstrong wrote: > > > Hi, > > > > Hi, > > > > > > > > On 24/06/2022 14:10, Geert U

Re: [PATCH v2 2/4] drm/lcdif: Consistently use plane timings

2022-07-09 Thread Liu Ying
On Sat, 2022-07-09 at 03:17 +0200, Marek Vasut wrote: > Drop the crtc_ prefix from mode, consistently use the plain one. > > Reviewed-by: Liu Ying > Reported-by: Liu Ying > Fixes: 9db35bb349a0e ("drm: lcdif: Add support for i.MX8MP LCDIF > variant") > Signed-off-b

[PATCH] drm/bridge: nwl-dsi: Drop the drm_of_panel_bridge_remove() function call

2022-03-31 Thread Liu Ying
nction call. As nwl_dsi_bridge_detach() only calls drm_of_panel_bridge_remove(), it can also be dropped. Cc: Robert Foss Cc: Guido Günther Cc: Jagan Teki Cc: NXP Linux Team Signed-off-by: Liu Ying --- drivers/gpu/drm/bridge/nwl-dsi.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/br

[PATCH v6 0/5] phy: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2022-04-01 Thread Liu Ying
Y dt binding. v1->v2: * Convert mixel,mipi-dsi-phy plain text dt binding to json-schema. (Guido) * Print invalid PHY mode in dmesg from the Mixel PHY driver. (Guido) * Add Guido's R-b tag on the patch for the nwl-dsi drm bridge driver. Liu Ying (5): drm/bridge: nwl-dsi: Set PHY mode in nw

[PATCH v6 1/5] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_mode_set()

2022-04-01 Thread Liu Ying
: Robert Chiras Cc: Martin Kepplinger Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: David Airlie Cc: Daniel Vetter Cc: NXP Linux Team Signed-off-by: Liu Ying --- v5->v6: * Rebase the series upon v5.17-rc1. * Set PHY mode in ->mo

[PATCH v6 2/5] phy: Add LVDS configuration options

2022-04-01 Thread Liu Ying
I Cc: Vinod Koul Cc: NXP Linux Team Signed-off-by: Liu Ying --- v5->v6: * Rebase upon v5.17-rc1. v4->v5: * Align kernel-doc style to include/linux/phy/phy.h. (Vinod) * Trivial tweaks. * Drop Robert's R-b tag. v3->v4: * Add Robert's R-b tag. v2->v3: * No change

[PATCH v6 3/5] dt-bindings: phy: Convert mixel, mipi-dsi-phy to json-schema

2022-04-01 Thread Liu Ying
ido Günther Cc: Kishon Vijay Abraham I Cc: Vinod Koul Cc: Rob Herring Cc: NXP Linux Team Reviewed-by: Rob Herring Reviewed-by: Guido Günther Signed-off-by: Liu Ying --- v5->v6: * No change. v4->v5: * No change. v3->v4: * Add Rob's and Guido's R-b tags. v2->v3: * I

[PATCH v6 4/5] dt-bindings: phy: mixel: mipi-dsi-phy: Add Mixel combo PHY support for i.MX8qxp

2022-04-01 Thread Liu Ying
Add support for Mixel MIPI DPHY + LVDS PHY combo IP as found on Freescale i.MX8qxp SoC. Cc: Guido Günther Cc: Kishon Vijay Abraham I Cc: Vinod Koul Cc: Rob Herring Cc: NXP Linux Team Reviewed-by: Rob Herring Reviewed-by: Guido Günther Signed-off-by: Liu Ying --- v5->v6: * No change.

[PATCH v6 5/5] phy: freescale: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2022-04-01 Thread Liu Ying
-by: Guido Günther Signed-off-by: Liu Ying --- v5->v6: * No change. v4->v5: * No change. v3->v4: * Add Guido's R-b tag. v2->v3: * Improve readability of mixel_dphy_set_mode(). (Guido) v1->v2: * Print invalid PHY mode in dmesg. (Guido) .../phy/freescale/phy-fsl-im

[PATCH v6 0/5] phy: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2022-04-01 Thread Liu Ying
) in the Mixel PHY driver. (Guido) * Improve the 'clock-names' property in the PHY dt binding. v1->v2: * Convert mixel,mipi-dsi-phy plain text dt binding to json-schema. (Guido) * Print invalid PHY mode in dmesg from the Mixel PHY driver. (Guido) * Add Guido's R-b tag on the pa

[PATCH v6 resend 1/5] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_mode_set()

2022-04-01 Thread Liu Ying
: Robert Chiras Cc: Martin Kepplinger Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: David Airlie Cc: Daniel Vetter Cc: NXP Linux Team Signed-off-by: Liu Ying --- v5->v6: * Rebase the series upon v5.17-rc1. * Set PHY mode in ->mo

[PATCH v6 resend 2/5] phy: Add LVDS configuration options

2022-04-01 Thread Liu Ying
I Cc: Vinod Koul Cc: NXP Linux Team Signed-off-by: Liu Ying --- v5->v6: * Rebase upon v5.17-rc1. v4->v5: * Align kernel-doc style to include/linux/phy/phy.h. (Vinod) * Trivial tweaks. * Drop Robert's R-b tag. v3->v4: * Add Robert's R-b tag. v2->v3: * No change

[PATCH v6 resend 3/5] dt-bindings: phy: Convert mixel, mipi-dsi-phy to json-schema

2022-04-01 Thread Liu Ying
ido Günther Cc: Kishon Vijay Abraham I Cc: Vinod Koul Cc: Rob Herring Cc: NXP Linux Team Reviewed-by: Rob Herring Reviewed-by: Guido Günther Signed-off-by: Liu Ying --- v5->v6: * No change. v4->v5: * No change. v3->v4: * Add Rob's and Guido's R-b tags. v2->v3: * I

[PATCH v6 resend 4/5] dt-bindings: phy: mixel: mipi-dsi-phy: Add Mixel combo PHY support for i.MX8qxp

2022-04-01 Thread Liu Ying
Add support for Mixel MIPI DPHY + LVDS PHY combo IP as found on Freescale i.MX8qxp SoC. Cc: Guido Günther Cc: Kishon Vijay Abraham I Cc: Vinod Koul Cc: Rob Herring Cc: NXP Linux Team Reviewed-by: Rob Herring Reviewed-by: Guido Günther Signed-off-by: Liu Ying --- v5->v6: * No change.

[PATCH v6 resend 5/5] phy: freescale: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2022-04-01 Thread Liu Ying
-by: Guido Günther Signed-off-by: Liu Ying --- v5->v6: * No change. v4->v5: * No change. v3->v4: * Add Guido's R-b tag. v2->v3: * Improve readability of mixel_dphy_set_mode(). (Guido) v1->v2: * Print invalid PHY mode in dmesg. (Guido) .../phy/freescale/phy-fsl-im

[PATCH v10 0/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2022-04-07 Thread Liu Ying
s. * Require bypass0 and bypass1 clocks for both i.MX8qxp and i.MX8qm in DPU's dt binding documentation. * Use new dt binding way to add clocks in the dt binding examples. * Address several comments from Laurentiu on the DPU DRM patch. Liu Ying (6): dt-bindings: display: imx: Add i.MX8qxp/qm

[PATCH v10 1/6] dt-bindings: display: imx: Add i.MX8qxp/qm DPU binding

2022-04-07 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Processing Unit. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v9->v10: * No change. v8->v9: * No change. v7->v8: * No change. v6->v7: * Add Rob's R-b tag back. v5->v6: * Use graph schema. So, drop Rob's R-

[PATCH v10 2/6] dt-bindings: display: imx: Add i.MX8qxp/qm PRG binding

2022-04-07 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Gasket. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v9->v10: * No change. v8->v9: * No change. v7->v8: * No change. v6->v7: * No change. v5->v6: * No change. v4->v5: * No change. v3->v4:

[PATCH v10 3/6] dt-bindings: display: imx: Add i.MX8qxp/qm DPR channel binding

2022-04-07 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Channel. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v9->v10: * Add Rob's R-b tag. v8->v9: * Reference 'interrupts-extended' schema instead of 'interrupts' to require an additional inter

[PATCH v10 4/6] drm/atomic: Avoid unused-but-set-variable warning on for_each_old_plane_in_state

2022-04-07 Thread Liu Ying
Artificially use 'plane' and 'old_plane_state' to avoid 'not used' warning. The precedent has already been set by other macros in the same file. Acked-by: Daniel Vetter Signed-off-by: Liu Ying --- v9->v10: * No change. v8->v9: * No change. v7->v8: * N

[PATCH v10 6/6] MAINTAINERS: add maintainer for i.MX8qxp DPU DRM driver

2022-04-07 Thread Liu Ying
Add myself as the maintainer of the i.MX8qxp DPU DRM driver. Acked-by: Laurentiu Palcu Signed-off-by: Liu Ying --- v9->v10: * Add Laurentiu's A-b tag. v8->v9: * No change. v7->v8: * No change. v6->v7: * No change. v5->v6: * No change. v4->v5: * No change. v3-&g

Re: [PATCH v6 resend 2/5] phy: Add LVDS configuration options

2022-04-13 Thread Liu Ying
Hi Vinod, On Wed, 2022-04-13 at 11:41 +0530, Vinod Koul wrote: > On 02-04-22, 13:24, Liu Ying wrote: > > This patch allows LVDS PHYs to be configured through > > the generic functions and through a custom structure > > added to the generic union. > > > > The p

Re: [PATCH v6 resend 5/5] phy: freescale: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2022-04-13 Thread Liu Ying
Hi Vinod, On Wed, 2022-04-13 at 11:51 +0530, Vinod Koul wrote: > On 02-04-22, 13:24, Liu Ying wrote: > > i.MX8qxp SoC embeds a Mixel MIPI DPHY + LVDS PHY combo which > > supports > > either a MIPI DSI display or a LVDS display. The PHY mode is > > controlled > &g

Re: [PATCH v6 resend 2/5] phy: Add LVDS configuration options

2022-04-13 Thread Liu Ying
On Wed, 2022-04-13 at 16:19 +0530, Vinod Koul wrote: > On 13-04-22, 18:04, Liu Ying wrote: > > Hi Vinod, > > > > On Wed, 2022-04-13 at 11:41 +0530, Vinod Koul wrote: > > > On 02-04-22, 13:24, Liu Ying wrote: > > > > This patch allows LVDS PHYs to

Re: [PATCH v6 resend 2/5] phy: Add LVDS configuration options

2022-04-13 Thread Liu Ying
On Thu, 2022-04-14 at 11:07 +0530, Vinod Koul wrote: > On 13-04-22, 20:39, Liu Ying wrote: > > On Wed, 2022-04-13 at 16:19 +0530, Vinod Koul wrote: > > > On 13-04-22, 18:04, Liu Ying wrote: > > > > Hi Vinod, > > > > > > > > On Wed, 2022-04-1

[PATCH v7 0/5] phy: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2022-04-13 Thread Liu Ying
uido) * Print invalid PHY mode in dmesg from the Mixel PHY driver. (Guido) * Add Guido's R-b tag on the patch for the nwl-dsi drm bridge driver. Liu Ying (5): drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_mode_set() phy: Add LVDS configuration options dt-bindings: phy: Convert mixel,mipi

[PATCH v7 1/5] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_mode_set()

2022-04-13 Thread Liu Ying
: Robert Chiras Cc: Martin Kepplinger Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: David Airlie Cc: Daniel Vetter Cc: NXP Linux Team Signed-off-by: Liu Ying --- v6->v7: * No change. v5->v6: * Rebase the series upon v5.17-rc1. * Set PH

[PATCH v7 2/5] phy: Add LVDS configuration options

2022-04-13 Thread Liu Ying
I Cc: Vinod Koul Cc: NXP Linux Team Signed-off-by: Liu Ying --- v6->v7: * Update the year of copyright. * Better variable explaination for bits_per_lane_and_dclk_cycle. v5->v6: * Rebase upon v5.17-rc1. v4->v5: * Align kernel-doc style to include/linux/phy/phy.h. (Vinod) * Trivi

<    1   2   3   4   5   6   7   8   9   10   >