RE: [PATCH v3] drm/scheduler: Improve documentation

2024-09-22 Thread Lin, Shuicheng
Hi all, I am not familiar with the process yet. To get it merged, should I add more mail-list or how to notify the maintainers? Thanks in advance for your guide. Best Regards Shuicheng > -Original Message- > From: Lin, Shuicheng > Sent: Tuesday, September 17, 2024 7:48 AM

RE: [PATCH v20 2/5] drm/xe/xe_gt_pagefault: Move pagefault struct to header

2025-04-22 Thread Lin, Shuicheng
On Mon, April 21, 2025 1:34 PM Cavitt, Jonathan wrote: > Move the pagefault struct from xe_gt_pagefault.c to the > xe_gt_pagefault_types.h header file, and move the associated enum values > into the regs folder under xe_pagefault_desc.h > > Since xe_pagefault_desc.h is being initialized here, also

RE: [PATCH v21 3/5] drm/xe/uapi: Define drm_xe_vm_get_property

2025-04-23 Thread Lin, Shuicheng
On Wed, April 23, 2025 1:19 PM Cavitt, Jonathan wrote: > Add initial declarations for the drm_xe_vm_get_property ioctl. > > v2: > - Expand kernel docs for drm_xe_vm_get_property (Jianxun) > > v3: > - Remove address type external definitions (Jianxun) > - Add fault type to xe_drm_fault struct (Jia

RE: [PATCH v21 4/5] drm/xe/xe_vm: Add per VM fault info

2025-04-23 Thread Lin, Shuicheng
On Wed, April 23, 2025 1:19 PM Cavitt, Jonathan wrote: > Add additional information to each VM so they can report up to the first > 50 seen faults. Only pagefaults are saved this way currently, though in the > future, all faults should be tracked by the VM for future reporting. > > Additionally,

RE: [PATCH v21 5/5] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-04-23 Thread Lin, Shuicheng
On Wed, April 23, 2025 1:19 PM Cavitt, Jonathan wrote: > Add support for userspace to request a list of observed faults from a > specified > VM. > > v2: > - Only allow querying of failed pagefaults (Matt Brost) > > v3: > - Remove unnecessary size parameter from helper function, as it > is a pr

RE: [PATCH v21 3/5] drm/xe/uapi: Define drm_xe_vm_get_property

2025-04-23 Thread Lin, Shuicheng
On Wed, April 23, 2025 7:15 PM Brost, Matthew wrote: > On Wed, Apr 23, 2025 at 07:57:10PM -0600, Lin, Shuicheng wrote: > > On Wed, April 23, 2025 1:19 PM Cavitt, Jonathan wrote: > > > Add initial declarations for the drm_xe_vm_get_property ioctl. > > > > > >

RE: [PATCH v22 4/5] drm/xe/xe_vm: Add per VM fault info

2025-04-24 Thread Lin, Shuicheng
On Thu, April 24, 2025 7:38 AM Cavitt, Jonathan wrote: > Add additional information to each VM so they can report up to the first > 50 seen faults. Only pagefaults are saved this way currently, though in the > future, all faults should be tracked by the VM for future reporting. > > Additionally,

RE: [PATCH v20 1/5] drm/xe/xe_gt_pagefault: Disallow writes to read-only VMAs

2025-04-22 Thread Lin, Shuicheng
On Mon, April 21, 2025 1:34 PM Cavitt, Jonathan wrote: > The page fault handler should reject write/atomic access to read only VMAs. > Add code to handle this in handle_pagefault after the VMA lookup. > > Fixes: 3d420e9fa848 ("drm/xe: Rework GPU page fault handling") > Signed-off-by: Jonathan Cavi

RE: [PATCH v4 6/6] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-03 Thread Lin, Shuicheng
On Mon, Mar 03 2025 at 14:00, Jonathan Cavitt wrote: > Add support for userspace to request a list of observed failed pagefaults from > a specified VM. > > v2: > - Only allow querying of failed pagefaults (Matt Brost) > > v3: > - Remove unnecessary size parameter from helper function, as it > i

RE: [PATCH v6 3/6] drm/xe/xe_vm: Add per VM pagefault info

2025-03-07 Thread Lin, Shuicheng
On Fri, Mar 7, 2025 2:41 PM Cavitt, Jonathan wrote > Add additional information to each VM so they can report up to the first > 50 seen pagefaults. Only failed pagefaults are saved this way, as successful > pagefaults should recover and not need to be reported to userspace. > > v2: > - Free vm af

RE: [PATCH v6 0/6] drm/xe/xe_vm: Implement xe_vm_get_faults_ioctl

2025-03-07 Thread Lin, Shuicheng
One generic question, do we have test case to verify whether the function is working correctly? Thanks. I think we could have IGT test case to trigger the fault, then have another IGT test case to query it with this new uapi. And make sure we could get the expected data with the new uapi. Shuich

RE: [PATCH v5 3/6] drm/xe/xe_vm: Add per VM pagefault info

2025-03-04 Thread Lin, Shuicheng
On Tue, Mar 04, 2025 9:09 AM Cavitt, Jonathan wrote > Add additional information to each VM so they can report up to the last > 50 seen pagefaults. Only failed pagefaults are saved this way, as successful > pagefaults should recover and not need to be reported to userspace. > > Signed-off-by: Jon

RE: [PATCH v5 6/6] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-04 Thread Lin, Shuicheng
On Tue, Mar 4, 2025 9:09 AM Cavitt, Jonathan wrote > Add support for userspace to request a list of observed failed pagefaults from > a specified VM. > > v2: > - Only allow querying of failed pagefaults (Matt Brost) > > v3: > - Remove unnecessary size parameter from helper function, as it > is