Re: [PATCH v9 6/6] MAINTAINERS: add maintainer for i.MX8qxp DPU DRM driver

2021-04-21 Thread Laurentiu Palcu
Hi, On Mon, Mar 29, 2021 at 01:57:26PM +0800, Liu Ying wrote: > Add myself as the maintainer of the i.MX8qxp DPU DRM driver. > > Signed-off-by: Liu Ying Acked-by: Laurentiu Palcu Thanks, laurentiu > --- > v8->v9: > * No change. > > v7->v8: > * No change. &g

Re: [PATCH] drm/imx/dcss: Use device_get_match_data()

2021-03-22 Thread Laurentiu Palcu
Hi Fabio, On Mon, Mar 15, 2021 at 09:38:11AM -0300, Fabio Estevam wrote: > The retrieval of driver data can be a bit simplified by using > device_get_match_data(), so switch to it. > > Signed-off-by: Fabio Estevam Reviewed-by: Laurentiu Palcu > --- > drivers/gpu/drm/imx/d

Re: [PATCH v5 5/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2021-01-15 Thread Laurentiu Palcu
Hi Liu Ying, I promised I would have a second, more in-depth, look at this and I finally managed to do it. I have to admit it was a challenge. Partially because I'm not very familiar with DPU but mostly because of the abundance of macros used. It's true, macros make the code more compact. However

Re: [PATCH v5 5/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2021-01-20 Thread Laurentiu Palcu
Hi Liu Ying, On Wed, Jan 20, 2021 at 04:42:50PM +0800, Liu Ying wrote: > Hi Laurentiu, > > On Fri, 2021-01-15 at 19:27 +0200, Laurentiu Palcu wrote: > > Hi Liu Ying, > > > > I promised I would have a second, more in-depth, look at this and I finally > > managed

Re: [PATCH v6 5/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2021-01-25 Thread Laurentiu Palcu
Hi Liu Ying, Just some minor comments below. On Thu, Jan 21, 2021 at 03:14:22PM +0800, Liu Ying wrote: > This patch introduces i.MX8qm/qxp Display Processing Unit(DPU) DRM support. > > DPU is comprised of two main components that include a blit engine for > 2D graphics accelerations(with composi

Re: [PATCH v8 5/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2021-03-02 Thread Laurentiu Palcu
Hi Liu Ying, One comment below. On Tue, Mar 02, 2021 at 02:33:15PM +0800, Liu Ying wrote: > This patch introduces i.MX8qm/qxp Display Processing Unit(DPU) DRM support. > > DPU is comprised of two main components that include a blit engine for > 2D graphics accelerations(with composition support)

Re: [PATCH 5/8] drm/imx: Introduce i.MX8qxp DPU DRM

2020-11-23 Thread Laurentiu Palcu
Hi Liu Ying, On Mon, Nov 23, 2020 at 10:45:38AM +0800, Liu Ying wrote: > Hi Laurentiu, > > On Fri, 2020-11-20 at 16:38 +0200, Laurentiu Palcu wrote: > > Hi Liu Ying, > > > > I gave this a first look but, since this is a huge piece of code and I'm not > >

Re: [RFC] dcss: fix attaching to sn56dsi86 bridge

2020-11-24 Thread Laurentiu Palcu
Hi Lukas, On Tue, Nov 24, 2020 at 06:19:57PM +0100, Lukas F. Hartmann wrote: > The sn56dsi86 DSI to eDP bridge driver does not support attaching > without a drm connector. I think the SN65DSI86 driver is exactly what you should focus on, so that it works when connector is optional. The ADV7511/AD

[PATCH 1/2] drm/imx/dcss: fix rotations for Vivante tiled formats

2020-11-05 Thread Laurentiu Palcu
ource width and height need to be swapped since DPR is sending the buffer to scaler already rotated. Also, make sure to allow full rotations for DRM_FORMAT_MOD_VIVANTE_SUPER_TILED. Fixes: 9021c317b770 ("drm/imx: Add initial support for DCSS on iMX8MQ") Signed-off-by: Laurentiu Palcu -

[PATCH 0/2] drm/imx/dcss: a couple of fixes

2020-11-05 Thread Laurentiu Palcu
Hi, This patchset fixes 90/270 rotations for Vivante tiled and super-tiled formats and a Coccinelle warning. Thanks, laurentiu Laurentiu Palcu (2): drm/imx/dcss: fix rotations for Vivante tiled formats drm/imx/dcss: fix coccinelle warning drivers/gpu/drm/imx/dcss/dcss-plane.c | 14

[PATCH 2/2] drm/imx/dcss: fix coccinelle warning

2020-11-05 Thread Laurentiu Palcu
X8MQ") Signed-off-by: Laurentiu Palcu --- drivers/gpu/drm/imx/dcss/dcss-plane.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/imx/dcss/dcss-plane.c b/drivers/gpu/drm/imx/dcss/dcss-plane.c index 46a188dd02ad..5db093aada2f 100644 --- a/drivers/gpu/drm/imx

[PATCH] drm/imx/dcss: allow using nearest neighbor interpolation scaling

2020-11-05 Thread Laurentiu Palcu
This patch adds support for using NN interpolation scaling by setting the SCALING_FILTER plane property to 1. Otherwise, the default method is used. Signed-off-by: Laurentiu Palcu --- I had no retro pixel art games to test this with, so I used modetest to see the results: To test, I used a

Re: [PATCH 0/8] drm/imx: Introduce i.MX8qxp DPU DRM

2020-11-19 Thread Laurentiu Palcu
Hi Liu Ying, On Thu, Nov 19, 2020 at 05:22:17PM +0800, Liu Ying wrote: > Hi, > > > This patch set introduces i.MX8qxp Display Processing Unit(DPU) DRM support. Glad to see this series out. However, something went wrong with it as patch 5/8 didn't make it to dri-devel mailing list... :/ https:/

Re: [PATCH 5/8] drm/imx: Introduce i.MX8qxp DPU DRM

2020-11-20 Thread Laurentiu Palcu
Hi Liu Ying, I gave this a first look but, since this is a huge piece of code and I'm not very familiar with DPU, I'll probably give it another pass next week. Anyway, some comments/questions inline. On Thu, Nov 19, 2020 at 11:22:22AM +0200, Liu Ying wrote: > This patch introduces i.MX8qxp Displ

Re: [PATCH] drm/imx/dcss: i.MX8MQ DCSS select DRM_GEM_CMA_HELPER

2022-02-18 Thread Laurentiu Palcu
Hi Rudi, On Wed, Feb 16, 2022 at 09:22:28PM +, Rudi Heitbaum wrote: > Without DRM_GEM_CMA_HELPER i.MX8MQ DCSS won't build. This needs to be > there. > > Signed-off-by: Rudi Heitbaum Reviewed-by: Laurentiu Palcu ...and pushed to drm-misc-fixes. Thanks, laurentiu > --

Re: [PATCH 1/2] drm/imx/dcss: add missing drm_bridge.h include

2021-12-13 Thread Laurentiu Palcu
Hi Lucas, On Sat, Dec 11, 2021 at 11:18:47PM +0100, Lucas Stach wrote: > This has been pulled in via some other include before, which is no > longer true. > > Signed-off-by: Lucas Stach > --- Reviewed-by: Laurentiu Palcu > drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 + &g

Re: [PATCH 2/2] drm/imx/dcss: select DRM_KMS_HELPER

2021-12-13 Thread Laurentiu Palcu
Hi Lucas, On Sat, Dec 11, 2021 at 11:18:48PM +0100, Lucas Stach wrote: > DCSS can not be built without the DRM_KMS_HELPERs being available. > Select this symbol to disallow this invalid configuration. > > Signed-off-by: Lucas Stach Reviewed-by: Laurentiu Palcu Can you also

Re: [EXT] Re: [PATCH 0/2] drm: imx: Add NWL MIPI DSI host controller support

2019-05-28 Thread Laurentiu Palcu
Hi Shawn, Lucas, On Tue, May 28, 2019 at 09:38:02AM +0800, Shawn Guo wrote: > Caution: EXT Email > > Hi Lucas, > > On Mon, May 27, 2019 at 03:36:53PM +0200, Lucas Stach wrote: > > We have been looking at how to support DCSS in mainline for a while, > > but most of the actual work got pushed behi

Re: [EXT] Re: [PATCH 0/2] drm: imx: Add NWL MIPI DSI host controller support

2019-05-28 Thread Laurentiu Palcu
Lucas and Daniel, On Tue, May 28, 2019 at 10:36:43AM +0200, Daniel Vetter wrote: > Caution: EXT Email > > On Tue, May 28, 2019 at 10:20 AM Lucas Stach wrote: > > > > Hi Shawn, > > > > Am Dienstag, den 28.05.2019, 09:38 +0800 schrieb Shawn Guo: > > > Hi Lucas, > > > > > > On Mon, May 27, 2019 at

Re: [EXT] Re: [PATCH 0/2] drm: imx: Add NWL MIPI DSI host controller support

2019-05-28 Thread Laurentiu Palcu
Hi Guido, On Tue, May 28, 2019 at 11:33:00AM +0200, Guido Günther wrote: > Caution: EXT Email > > Hi Laurentiu, > On Tue, May 28, 2019 at 07:03:54AM +0000, Laurentiu Palcu wrote: > > Hi Shawn, Lucas, > > > > On Tue, May 28, 2019 at 09:38:02AM +0800, Shawn Guo w

Re: [PATCH] drm/imx/dcss: get rid of HPD warning message

2022-08-04 Thread Laurentiu Palcu
On Thu, Jul 21, 2022 at 03:25:02PM +0300, Laurent Pinchart wrote: > Hi Laurentiu, > > Thank you for the patch. > > On Thu, Jul 21, 2022 at 03:09:12PM +0300, Laurentiu Palcu wrote: > > When DCSS + MIPI_DSI is used, and the last bridge in the chain supports > >

Re: [PATCH] drm/imx/dcss: Add missing of_node_put() in fail path

2022-07-14 Thread Laurentiu Palcu
Hi Liang, Thanks for the patch. The patch is ok but, since you're at it, maybe add of_node_put() in the dcss_dev_destroy() too? Thanks, laurentiu On Thu, Jul 07, 2022 at 10:32:14AM +0800, Liang He wrote: > In dcss_dev_create(), we should call of_node_put() in fail path for > of_graph_get_port_b

Re: [PATCH v2] drm/imx/dcss: Add missing of_node_put() in fail path

2022-07-20 Thread Laurentiu Palcu
/imx: Add initial support for DCSS on iMX8MQ") > Signed-off-by: Liang He Reviewed-by: Laurentiu Palcu Applied to drm-misc-fixes. Thanks, Laurentiu > --- > changelog: > > v2: add of_node_put() in dcss_dev_destroy() advised by Laurentiu > v1: only fix bug in dcss_dev_

[PATCH] drm/imx/dcss: get rid of HPD warning message

2022-07-21 Thread Laurentiu Palcu
ion, which made the drm_bridge_connector_enable_hpd() call, in DCSS init path, redundant. So, let's remove that call. Fixes: 09077bc311658 ("drm/bridge_connector: enable HPD by default if supported") Signed-off-by: Laurentiu Palcu --- drivers/gpu/drm/imx/dcss/dcss-kms.c | 2 -

Re: Re: [PATCH v2 4/5] dt-bindings: display: imx: add bindings for DCSS

2019-10-14 Thread Laurentiu Palcu
Hi Rob, On Fri, Oct 11, 2019 at 09:50:42AM -0500, Rob Herring wrote: > :u?wc??m5?^?㞾?}4-??z{b???r?+?׀u???ا#????ek > ?W?J^?(???h}??-??z{b???r?Z+?jW.?\?oۊwb? > ?v+)l?b?&??,?&??ξW???!jxw΢?ǫ?*'??+y?^??^?M:???r鞞֭???u??q?ky?ۊwb? > ?v+)l?b?&??,?&?????

Re: Re: Re: [PATCH v2 4/5] dt-bindings: display: imx: add bindings for DCSS

2019-10-14 Thread Laurentiu Palcu
Hi Rob, On Mon, Oct 14, 2019 at 08:23:51AM -0500, Rob Herring wrote: > On Mon, Oct 14, 2019 at 3:03 AM Laurentiu Palcu > wrote: > > > > Hi Rob, > > > > On Fri, Oct 11, 2019 at 09:50:42AM -0500, Rob Herring wrote: > > > :u?wc??m5?^?㞾?}4-??z{b???r?+?׀u???ا?

Re: [PATCH v3 2/4] drm/imx: Add initial support for DCSS on iMX8MQ

2020-02-25 Thread Laurentiu Palcu
Hi Lucas, Thanks for taking some time to look over this series. On Mon, Feb 24, 2020 at 06:27:25PM +0100, Lucas Stach wrote: > Hi Laurentiu, > > just a first drive-by comment, more in-depth review tomorrow. > > On Fr, 2019-12-06 at 11:52 +0200, Laurentiu Palcu wrote: > &

Re: [PATCH v3 3/4] dt-bindings: display: imx: add bindings for DCSS

2020-02-25 Thread Laurentiu Palcu
Hi Lucas, On Mon, Feb 24, 2020 at 06:21:57PM +0100, Lucas Stach wrote: > On Fr, 2019-12-06 at 11:52 +0200, Laurentiu Palcu wrote: > > Add bindings for iMX8MQ Display Controller Subsystem. > > > > Signed-off-by: Laurentiu Palcu > > Reviewed-by: Rob Herring > >

Re: [PATCH v3 2/4] drm/imx: Add initial support for DCSS on iMX8MQ

2020-03-06 Thread Laurentiu Palcu
idth > was pretty exhausted by the time I made my was to the scaler code. :) > > On Fr, 2019-12-06 at 11:52 +0200, Laurentiu Palcu wrote: > > This adds initial support for iMX8MQ's Display Controller Subsystem (DCSS). > > Some of its capabilities include: > > * 4K@60f

Re: [PATCH v3 2/4] drm/imx: Add initial support for DCSS on iMX8MQ

2020-03-06 Thread Laurentiu Palcu
Hi Philipp, On Fri, Mar 06, 2020 at 11:20:51AM +0100, Philipp Zabel wrote: > Hi Laurentiu, > > On Fri, 2020-03-06 at 11:58 +0200, Laurentiu Palcu wrote: > > On Wed, Feb 26, 2020 at 02:19:11PM +0100, Lucas Stach wrote: > [...] > > > > +/* This function will be

[PATCH v4 0/4] Add support for iMX8MQ Display Controller Subsystem

2020-03-06 Thread Laurentiu Palcu
From: Laurentiu Palcu Hi, This patchset adds initial DCSS support for iMX8MQ chip. Initial support includes only graphics plane support (no video planes), no HDR10 capabilities, no graphics decompression (only linear, tiled and super-tiled buffers allowed). Support for the rest of the features

[PATCH v4 1/4] drm/imx: compile imx directory by default

2020-03-06 Thread Laurentiu Palcu
From: Laurentiu Palcu Currently the drm/imx/ directory is compiled only if DRM_IMX is set. Adding a new IMX related IP in the same directory would need DRM_IMX to be set, which would bring in also IPUv3 core driver... The current patch would allow adding new IPs in the imx/ directory without

[PATCH v4 4/4] arm64: dts: imx8mq: add DCSS node

2020-03-06 Thread Laurentiu Palcu
From: Laurentiu Palcu This patch adds the node for iMX8MQ Display Controller Subsystem. Signed-off-by: Laurentiu Palcu --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 23 +++ 1 file changed, 23 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch

[PATCH v4 2/4] drm/imx: Add initial support for DCSS on iMX8MQ

2020-03-06 Thread Laurentiu Palcu
From: Laurentiu Palcu This adds initial support for iMX8MQ's Display Controller Subsystem (DCSS). Some of its capabilities include: * 4K@60fps; * HDR10; * one graphics and 2 video pipelines; * on-the-fly decompression of compressed video and graphics; The reference manual can be found

[PATCH v4 3/4] dt-bindings: display: imx: add bindings for DCSS

2020-03-06 Thread Laurentiu Palcu
From: Laurentiu Palcu Add bindings for iMX8MQ Display Controller Subsystem. Signed-off-by: Laurentiu Palcu --- .../bindings/display/imx/nxp,imx8mq-dcss.yaml | 85 +++ 1 file changed, 85 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/imx/nxp,imx8mq

[PATCH 2/5] drm/imx: compile imx directory by default

2019-09-23 Thread Laurentiu Palcu
. Signed-off-by: Laurentiu Palcu --- drivers/gpu/drm/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index 82ff826..a6191f8 100644 --- a/drivers/gpu/drm/Makefile +++ b/drivers/gpu/drm/Makefile @@ -98,7 +98,7 @@ obj

[PATCH 0/5] Add support for iMX8MQ Display Controller Subsystem

2019-09-23 Thread Laurentiu Palcu
incrementally, in subsequent patches. The patchset was tested with both HDP driver (not yet upstreamed) and MIPI-DSI (drivers already on the dri-devel ML). Thanks, Laurentiu Laurentiu Palcu (5): clk: imx8mq: Add VIDEO2_PLL clock drm/imx: compile imx directory by default drm/imx: Add initial support

[PATCH 4/5] dt-bindings: display: imx: add bindings for DCSS

2019-09-23 Thread Laurentiu Palcu
Add bindings for iMX8MQ Display Controller Subsystem. Signed-off-by: Laurentiu Palcu --- .../bindings/display/imx/nxp,imx8mq-dcss.yaml | 86 ++ 1 file changed, 86 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/imx/nxp,imx8mq-dcss.yaml diff

Re: Re: [PATCH 4/5] dt-bindings: display: imx: add bindings for DCSS

2019-09-24 Thread Laurentiu Palcu
Hi, On Tue, Sep 24, 2019 at 01:53:28PM -0500, Rob Herring wrote: > On Mon, Sep 23, 2019 at 9:14 AM Laurentiu Palcu > wrote: > > > > Add bindings for iMX8MQ Display Controller Subsystem. > > > > Signed-off-by: Laurentiu Palcu > > --- > > .../bindings/

[PATCH v2 0/5] Add support for iMX8MQ Display Controller Subsystem

2019-10-02 Thread Laurentiu Palcu
owercase, to be consistent; * Removed some left-over references to P010; * Added a Kconfig dependency of DRM && ARCH_MXC. This will also silence compilation issues reported by kbuild for other architectures; Laurentiu Palcu (5): clk: imx8mq: Add VIDEO2_PLL clock drm/imx: compile imx dir

[PATCH v2 2/5] drm/imx: compile imx directory by default

2019-10-02 Thread Laurentiu Palcu
. Signed-off-by: Laurentiu Palcu --- drivers/gpu/drm/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index 82ff826..a6191f8 100644 --- a/drivers/gpu/drm/Makefile +++ b/drivers/gpu/drm/Makefile @@ -98,7 +98,7 @@ obj

[PATCH v2 4/5] dt-bindings: display: imx: add bindings for DCSS

2019-10-02 Thread Laurentiu Palcu
Add bindings for iMX8MQ Display Controller Subsystem. Signed-off-by: Laurentiu Palcu --- .../bindings/display/imx/nxp,imx8mq-dcss.yaml | 86 ++ 1 file changed, 86 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/imx/nxp,imx8mq-dcss.yaml diff

[PATCH v2 3/5] drm/imx: Add initial support for DCSS on iMX8MQ

2019-10-02 Thread Laurentiu Palcu
e per-plane de-gamma/CSC/gamma support is in. Signed-off-by: Laurentiu Palcu --- drivers/gpu/drm/imx/Kconfig| 2 + drivers/gpu/drm/imx/Makefile | 1 + drivers/gpu/drm/imx/dcss/Kconfig | 8 + drivers/gpu/drm/imx/dcss/Makefile | 6 + drivers/gpu/drm/imx/dcss

[PATCH] drm: fix HDR static metadata type field numbering

2019-11-27 Thread Laurentiu Palcu
->hdr_sink_metadata.hdmi_type1.metadata_type is always 0, because hdr_metadata_type() in drm_edid.c checks the wrong bit. This patch corrects the HDMI_STATIC_METADATA_TYPE1 bit position. Signed-off-by: Laurentiu Palcu --- include/linux/hdmi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

Re: [EXT] Re: [PATCH] drm: fix HDR static metadata type field numbering

2019-11-28 Thread Laurentiu Palcu
On Wed, Nov 27, 2019 at 05:17:03PM +0200, Ville Syrjälä wrote: > Caution: EXT Email > > On Wed, Nov 27, 2019 at 02:42:35PM +, Laurentiu Palcu wrote: > > According to CTA-861 specification, HDR static metadata data block allows a > > sink to indicate which HDR metadata

[PATCH v3 3/4] dt-bindings: display: imx: add bindings for DCSS

2019-12-06 Thread Laurentiu Palcu
Add bindings for iMX8MQ Display Controller Subsystem. Signed-off-by: Laurentiu Palcu Reviewed-by: Rob Herring --- .../bindings/display/imx/nxp,imx8mq-dcss.yaml | 86 ++ 1 file changed, 86 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/imx

[PATCH v3 1/4] drm/imx: compile imx directory by default

2019-12-06 Thread Laurentiu Palcu
. Signed-off-by: Laurentiu Palcu --- drivers/gpu/drm/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index 9f1c7c4..69155f9 100644 --- a/drivers/gpu/drm/Makefile +++ b/drivers/gpu/drm/Makefile @@ -100,7 +100,7 @@ obj

[PATCH v3 0/4] Add support for iMX8MQ Display Controller Subsystem

2019-12-06 Thread Laurentiu Palcu
uild for other architectures; Laurentiu Palcu (4): drm/imx: compile imx directory by default drm/imx: Add initial support for DCSS on iMX8MQ dt-bindings: display: imx: add bindings for DCSS arm64: dts: imx8mq: add DCSS node .../bindings/display/imx/nxp,imx8mq-dcss.yaml | 86 +++ a

Re: [PATCH v2 09/22] drm/imx: Don't set struct drm_device.irq_enabled

2021-06-22 Thread Laurentiu Palcu
ms.c | 3 --- Not sure if it's worth the effort but, since DCSS is a completely self-contained driver, maybe it would be good to split this patch in 2 as well. Anyway, for DCSS bit: Acked-by: Laurentiu Palcu Thanks, laurentiu > drivers/gpu/drm/imx/imx-drm-core.c | 11 --- &

Re: [PATCH] drm/probe_helper: sort out poll_running vs poll_enabled

2023-01-12 Thread Laurentiu Palcu
xf0 > driver_probe_device+0xe0/0x164 > __device_attach_driver+0xc0/0x13c > bus_for_each_drv+0x84/0xe0 > __device_attach+0xa4/0x1a0 > device_initial_probe+0x1c/0x30 > bus_probe_device+0xa4/0xb0 > deferred_probe_work_func+0x90/0xd0 > process_one_work+0x200/0x474 >

Re: [PATCH v2] drm/probe_helper: sort out poll_running vs poll_enabled

2023-01-18 Thread Laurentiu Palcu
vice+0xe0/0x164 > __device_attach_driver+0xc0/0x13c > bus_for_each_drv+0x84/0xe0 > __device_attach+0xa4/0x1a0 > device_initial_probe+0x1c/0x30 > bus_probe_device+0xa4/0xb0 > deferred_probe_work_func+0x90/0xd0 > process_one_work+0x200/0x474 > worker_thread+0x74/0x43c

Re: [PATCH 10/26] drm: imx/dcss: Remove #ifdef guards for PM related functions

2022-11-11 Thread Laurentiu Palcu
t having to use #ifdef > guards. > > This has the advantage of always compiling these functions in, > independently of any Kconfig option. Thanks to that, bugs and other > regressions are subsequently easier to catch. > > Signed-off-by: Paul Cercueil Reviewed-by: Laurentiu Palcu

Re: [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-01-09 Thread Laurentiu Palcu
Hi Dmitry, It looks like there are some issues with this patchset... :/ I just fetched the drm-tip and, with these patches included, the "Hot plug detection already enabled" warning is back for i.MX DCSS. After a short investigation, it seems that we end up calling drm_bridge_hpd_enable() from bo

Re: [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-01-09 Thread Laurentiu Palcu
Hi, On Mon, Jan 09, 2023 at 10:26:28PM +0200, Dmitry Baryshkov wrote: > Hi, > > On 09/01/2023 18:21, Laurentiu Palcu wrote: > > Hi Dmitry, > > > > It looks like there are some issues with this patchset... :/ I just > > fetched the drm-tip and, with thes

Re: [PATCH 1/2] drm/imx/dcss: Drop if blocks with always false condition

2023-01-10 Thread Laurentiu Palcu
L. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurentiu Palcu Pushed to drm-misc-next. Thanks, laurentiu > --- > drivers/gpu/drm/imx/dcss/dcss-drv.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/imx/dcss/dcss-drv.c > b/drive

Re: [PATCH 2/2] drm/imx/dcss: Don't call dev_set_drvdata(..., NULL);

2023-01-10 Thread Laurentiu Palcu
Hi, On Fri, Dec 30, 2022 at 02:00:25PM +0100, Uwe Kleine-König wrote: > The driver core takes care about removing driver data, so this can be > dropped from the driver. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurentiu Palcu Pushed to drm-misc-next. Thank

Re: [PATCH 1/1] drm/imx/dcss: Use dev_err_probe

2023-07-28 Thread Laurentiu Palcu
Hi, On Mon, Jul 17, 2023 at 11:29:50AM +0200, Alexander Stein wrote: > This helps identifying problems with downstream pipeline devices, like > HDMI/DP output. > > Signed-off-by: Alexander Stein Reviewed-by: Laurentiu Palcu Pushed to drm-misc-next. Thanks, Laurentiu > --- >

[PATCH] drm/imx: fix typo in ipu_plane_formats[]

2017-06-28 Thread Laurentiu Palcu
The BGRA appears twice in the ipu_plane_formats[] list. The duplicate should be BGRX. The original commit is: commit 59d6b7189a96 ("drm/imx: ipuv3-plane: enable support for RGBX and RGBA pixel formats") Signed-off-by: Laurentiu Palcu --- drivers/gpu/drm/imx/ipuv3-p

[PATCH v5 4/5] dt-bindings: display: imx: add bindings for DCSS

2020-07-09 Thread Laurentiu Palcu
From: Laurentiu Palcu Add bindings for iMX8MQ Display Controller Subsystem. Signed-off-by: Laurentiu Palcu --- .../bindings/display/imx/nxp,imx8mq-dcss.yaml | 84 +++ 1 file changed, 84 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/imx/nxp,imx8mq

[PATCH v5 1/5] drm/imx: compile imx directory by default

2020-07-09 Thread Laurentiu Palcu
From: Laurentiu Palcu Currently the drm/imx/ directory is compiled only if DRM_IMX is set. Adding a new IMX related IP in the same directory would need DRM_IMX to be set, which would bring in also IPUv3 core driver... The current patch would allow adding new IPs in the imx/ directory without

[PATCH v5 5/5] arm64: dts: imx8mq: add DCSS node

2020-07-09 Thread Laurentiu Palcu
From: Laurentiu Palcu This patch adds the node for iMX8MQ Display Controller Subsystem. Signed-off-by: Laurentiu Palcu --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 23 +++ 1 file changed, 23 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch

[PATCH v5 0/4] Add support for iMX8MQ Display Controller Subsystem

2020-07-09 Thread Laurentiu Palcu
From: Laurentiu Palcu Hi, This patchset adds initial DCSS support for iMX8MQ chip. Initial support includes only graphics plane support (no video planes), no HDR10 capabilities, no graphics decompression (only linear, tiled and super-tiled buffers allowed). Support for the rest of the features

[PATCH v5 3/5] drm/imx/dcss: add component framework functionality

2020-07-09 Thread Laurentiu Palcu
From: Laurentiu Palcu Component framework is needed by HDP driver. Signed-off-by: Laurentiu Palcu --- drivers/gpu/drm/imx/dcss/dcss-drv.c | 89 ++--- drivers/gpu/drm/imx/dcss/dcss-kms.c | 14 - drivers/gpu/drm/imx/dcss/dcss-kms.h | 4 +- 3 files changed, 80

[PATCH v5 2/5] drm/imx: Add initial support for DCSS on iMX8MQ

2020-07-09 Thread Laurentiu Palcu
From: Laurentiu Palcu This adds initial support for iMX8MQ's Display Controller Subsystem (DCSS). Some of its capabilities include: * 4K@60fps; * HDR10; * one graphics and 2 video pipelines; * on-the-fly decompression of compressed video and graphics; The reference manual can be found

Re: [PATCH v5 0/4] Add support for iMX8MQ Display Controller Subsystem

2020-07-17 Thread Laurentiu Palcu
> > wrote: > > > > Hi Laurentiu, > > > > > > > > Am Donnerstag, den 09.07.2020, 19:47 +0300 schrieb Laurentiu Palcu: > > > > > From: Laurentiu Palcu > > > > > > > > > > Hi, > > > > > > > > &g

[PATCH v6 1/4] drm/imx: compile imx directory by default

2020-07-17 Thread Laurentiu Palcu
From: Laurentiu Palcu Currently the drm/imx/ directory is compiled only if DRM_IMX is set. Adding a new IMX related IP in the same directory would need DRM_IMX to be set, which would bring in also IPUv3 core driver... The current patch would allow adding new IPs in the imx/ directory without

[PATCH v6 4/4] dt-bindings: display: imx: add bindings for DCSS

2020-07-17 Thread Laurentiu Palcu
From: Laurentiu Palcu Add bindings for iMX8MQ Display Controller Subsystem. Signed-off-by: Laurentiu Palcu --- .../bindings/display/imx/nxp,imx8mq-dcss.yaml | 104 ++ 1 file changed, 104 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/imx/nxp

[PATCH v6 3/4] MAINTAINERS: Add entry for i.MX 8MQ DCSS driver

2020-07-17 Thread Laurentiu Palcu
From: Laurentiu Palcu The driver is part of DRM subsystem and is located in drivers/gpu/drm/imx/dcss. Signed-off-by: Laurentiu Palcu --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index dad5a62d21a7..200c5985b41f 100644 --- a/MAINTAINERS

[PATCH v6 0/4] Add support for iMX8MQ Display Controller Subsystem

2020-07-17 Thread Laurentiu Palcu
From: Laurentiu Palcu Hi, This patchset adds initial DCSS support for iMX8MQ chip. Initial support includes only graphics plane support (no video planes), no HDR10 capabilities, no graphics decompression (only linear, tiled and super-tiled buffers allowed). Support for the rest of the features

[PATCH v6 2/4] drm/imx: Add initial support for DCSS on iMX8MQ

2020-07-17 Thread Laurentiu Palcu
From: Laurentiu Palcu This adds initial support for iMX8MQ's Display Controller Subsystem (DCSS). Some of its capabilities include: * 4K@60fps; * HDR10; * one graphics and 2 video pipelines; * on-the-fly decompression of compressed video and graphics; The reference manual can be found

Re: [PATCH v6 2/4] drm/imx: Add initial support for DCSS on iMX8MQ

2020-07-20 Thread Laurentiu Palcu
Hi Sam, On Fri, Jul 17, 2020 at 09:48:49PM +0200, Sam Ravnborg wrote: > Hi Laurentiu. > > On Fri, Jul 17, 2020 at 05:41:27PM +0300, Laurentiu Palcu wrote: > > From: Laurentiu Palcu > > > > This adds initial support for iMX8MQ's Display Controller Subsystem (DCS

[PATCH] drm/bridge/adv7511: set the bridge type properly

2020-07-20 Thread Laurentiu Palcu
From: Laurentiu Palcu After the drm_bridge_connector_init() helper function has been added, the ADV driver has been changed accordingly. However, the 'type' field of the bridge structure was left unset, which makes the helper function always return -EINVAL. Signed-off-by: Laure

Re: [PATCH v6 4/4] dt-bindings: display: imx: add bindings for DCSS

2020-07-20 Thread Laurentiu Palcu
Hi Rob, On Mon, Jul 20, 2020 at 10:49:27AM -0600, Rob Herring wrote: > On Fri, 17 Jul 2020 17:41:29 +0300, Laurentiu Palcu wrote: > > From: Laurentiu Palcu > > > > Add bindings for iMX8MQ Display Controller Subsystem. > > > > Signed-off-by: Laurentiu Palcu

[PATCH v7 0/5] Add support for iMX8MQ Display Controller Subsystem

2020-07-21 Thread Laurentiu Palcu
From: Laurentiu Palcu Hi, This patchset adds initial DCSS support for iMX8MQ chip. Initial support includes only graphics plane support (no video planes), no HDR10 capabilities, no graphics decompression (only linear, tiled and super-tiled buffers allowed). Support for the rest of the features

[PATCH v7 3/5] drm/imx/dcss: use drm_bridge_connector API

2020-07-21 Thread Laurentiu Palcu
From: Laurentiu Palcu Make use of drm_bridge_connector API to have the connector initialized by the display controller. Signed-off-by: Laurentiu Palcu CC: Sam Ravnborg CC: Laurent Pinchart --- drivers/gpu/drm/imx/dcss/dcss-dev.c | 17 +--- drivers/gpu/drm/imx/dcss/dcss-kms.c

[PATCH v7 2/5] drm/imx: Add initial support for DCSS on iMX8MQ

2020-07-21 Thread Laurentiu Palcu
From: Laurentiu Palcu This adds initial support for iMX8MQ's Display Controller Subsystem (DCSS). Some of its capabilities include: * 4K@60fps; * HDR10; * one graphics and 2 video pipelines; * on-the-fly decompression of compressed video and graphics; The reference manual can be found

[PATCH v7 1/5] drm/imx: compile imx directory by default

2020-07-21 Thread Laurentiu Palcu
From: Laurentiu Palcu Currently the drm/imx/ directory is compiled only if DRM_IMX is set. Adding a new IMX related IP in the same directory would need DRM_IMX to be set, which would bring in also IPUv3 core driver... The current patch would allow adding new IPs in the imx/ directory without

[PATCH v7 4/5] MAINTAINERS: Add entry for i.MX 8MQ DCSS driver

2020-07-21 Thread Laurentiu Palcu
From: Laurentiu Palcu The driver is part of DRM subsystem and is located in drivers/gpu/drm/imx/dcss. Signed-off-by: Laurentiu Palcu --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index dad5a62d21a7..200c5985b41f 100644 --- a/MAINTAINERS

[PATCH v7 5/5] dt-bindings: display: imx: add bindings for DCSS

2020-07-21 Thread Laurentiu Palcu
From: Laurentiu Palcu Add bindings for iMX8MQ Display Controller Subsystem. Signed-off-by: Laurentiu Palcu Reviewed-by: Rob Herring --- .../bindings/display/imx/nxp,imx8mq-dcss.yaml | 104 ++ 1 file changed, 104 insertions(+) create mode 100644 Documentation/devicetree

Re: [PATCH v7 2/5] drm/imx: Add initial support for DCSS on iMX8MQ

2020-07-21 Thread Laurentiu Palcu
Hi Philipp, On Tue, Jul 21, 2020 at 02:43:28PM +0200, Philipp Zabel wrote: > Hi Laurentiu, > > On Tue, 2020-07-21 at 13:20 +0300, Laurentiu Palcu wrote: > > From: Laurentiu Palcu > > > > This adds initial support for iMX8MQ's Display Controller Subsystem (DCS

[PATCH v8 2/5] drm/imx: Add initial support for DCSS on iMX8MQ

2020-07-24 Thread Laurentiu Palcu
From: Laurentiu Palcu This adds initial support for iMX8MQ's Display Controller Subsystem (DCSS). Some of its capabilities include: * 4K@60fps; * HDR10; * one graphics and 2 video pipelines; * on-the-fly decompression of compressed video and graphics; The reference manual can be found

[PATCH v8 0/5] Add support for iMX8MQ Display Controller Subsystem

2020-07-24 Thread Laurentiu Palcu
From: Laurentiu Palcu Hi, This patchset adds initial DCSS support for iMX8MQ chip. Initial support includes only graphics plane support (no video planes), no HDR10 capabilities, no graphics decompression (only linear, tiled and super-tiled buffers allowed). Support for the rest of the features

[PATCH v8 1/5] drm/imx: compile imx directory by default

2020-07-24 Thread Laurentiu Palcu
From: Laurentiu Palcu Currently the drm/imx/ directory is compiled only if DRM_IMX is set. Adding a new IMX related IP in the same directory would need DRM_IMX to be set, which would bring in also IPUv3 core driver... The current patch would allow adding new IPs in the imx/ directory without

[PATCH v8 4/5] MAINTAINERS: Add entry for i.MX 8MQ DCSS driver

2020-07-24 Thread Laurentiu Palcu
From: Laurentiu Palcu The driver is part of DRM subsystem and is located in drivers/gpu/drm/imx/dcss. Signed-off-by: Laurentiu Palcu --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index dad5a62d21a7..200c5985b41f 100644 --- a/MAINTAINERS

[PATCH v8 3/5] drm/imx/dcss: use drm_bridge_connector API

2020-07-24 Thread Laurentiu Palcu
From: Laurentiu Palcu Make use of drm_bridge_connector API to have the connector initialized by the display controller. Signed-off-by: Laurentiu Palcu CC: Sam Ravnborg CC: Laurent Pinchart --- drivers/gpu/drm/imx/dcss/dcss-dev.c | 17 +--- drivers/gpu/drm/imx/dcss/dcss-kms.c

[PATCH v8 5/5] dt-bindings: display: imx: add bindings for DCSS

2020-07-24 Thread Laurentiu Palcu
From: Laurentiu Palcu Add bindings for iMX8MQ Display Controller Subsystem. Signed-off-by: Laurentiu Palcu Reviewed-by: Rob Herring --- .../bindings/display/imx/nxp,imx8mq-dcss.yaml | 104 ++ 1 file changed, 104 insertions(+) create mode 100644 Documentation/devicetree

Re: [PATCH v8 2/5] drm/imx: Add initial support for DCSS on iMX8MQ

2020-07-29 Thread Laurentiu Palcu
Hi Guido, On Wed, Jul 29, 2020 at 03:11:21PM +0200, Guido Günther wrote: > Hi Laurentiu, > On Fri, Jul 24, 2020 at 12:07:31PM +0300, Laurentiu Palcu wrote: > > From: Laurentiu Palcu > > > > This adds initial support for iMX8MQ's Display Controller Subsystem (DCSS).

Re: [PATCH v8 0/5] Add support for iMX8MQ Display Controller Subsystem

2020-07-29 Thread Laurentiu Palcu
Hi Guido, On Wed, Jul 29, 2020 at 03:59:48PM +0200, Guido Günther wrote: > Hi, > On Fri, Jul 24, 2020 at 12:07:29PM +0300, Laurentiu Palcu wrote: > > From: Laurentiu Palcu > > > > Hi, > > > > This patchset adds initial DCSS support for iMX8MQ chip. Initia

Re: [PATCH v8 5/5] dt-bindings: display: imx: add bindings for DCSS

2020-07-29 Thread Laurentiu Palcu
On Wed, Jul 29, 2020 at 03:27:30PM +0200, Guido Günther wrote: > Hi, > On Fri, Jul 24, 2020 at 12:07:34PM +0300, Laurentiu Palcu wrote: > > From: Laurentiu Palcu > > > > Add bindings for iMX8MQ Display Controller Subsystem. > > > > Signed-off-by: Laurentiu

Re: [PATCH v8 0/5] Add support for iMX8MQ Display Controller Subsystem

2020-07-30 Thread Laurentiu Palcu
Hi Guido, On Wed, Jul 29, 2020 at 05:09:52PM +0200, Guido Günther wrote: > Hi, > On Wed, Jul 29, 2020 at 05:16:47PM +0300, Laurentiu Palcu wrote: > > Hi Guido, > > > > On Wed, Jul 29, 2020 at 03:59:48PM +0200, Guido Günther wrote: > > > Hi, > > >

[PATCH v9 1/5] drm/imx: compile imx directory by default

2020-07-31 Thread Laurentiu Palcu
From: Laurentiu Palcu Currently the drm/imx/ directory is compiled only if DRM_IMX is set. Adding a new IMX related IP in the same directory would need DRM_IMX to be set, which would bring in also IPUv3 core driver... The current patch would allow adding new IPs in the imx/ directory without

[PATCH v9 5/5] dt-bindings: display: imx: add bindings for DCSS

2020-07-31 Thread Laurentiu Palcu
From: Laurentiu Palcu Add bindings for iMX8MQ Display Controller Subsystem. Signed-off-by: Laurentiu Palcu --- Changes in v9: * Include imx8mq-clock.h in the example so we can use clock names instead of their values; .../bindings/display/imx/nxp,imx8mq-dcss.yaml | 108

[PATCH v9 4/5] MAINTAINERS: Add entry for i.MX 8MQ DCSS driver

2020-07-31 Thread Laurentiu Palcu
From: Laurentiu Palcu The driver is part of DRM subsystem and is located in drivers/gpu/drm/imx/dcss. Signed-off-by: Laurentiu Palcu --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2c669c07fa35..1a22038f2869 100644 --- a/MAINTAINERS

[PATCH v9 0/5] Add support for iMX8MQ Display Controller Subsystem

2020-07-31 Thread Laurentiu Palcu
From: Laurentiu Palcu Hi, This patchset adds initial DCSS support for iMX8MQ chip. Initial support includes only graphics plane support (no video planes), no HDR10 capabilities, no graphics decompression (only linear, tiled and super-tiled buffers allowed). Support for the rest of the features

[PATCH v9 2/5] drm/imx: Add initial support for DCSS on iMX8MQ

2020-07-31 Thread Laurentiu Palcu
From: Laurentiu Palcu This adds initial support for iMX8MQ's Display Controller Subsystem (DCSS). Some of its capabilities include: * 4K@60fps; * HDR10; * one graphics and 2 video pipelines; * on-the-fly decompression of compressed video and graphics; The reference manual can be found

[PATCH v9 3/5] drm/imx/dcss: use drm_bridge_connector API

2020-07-31 Thread Laurentiu Palcu
From: Laurentiu Palcu Make use of drm_bridge_connector API to have the connector initialized by the display controller. Signed-off-by: Laurentiu Palcu --- drivers/gpu/drm/imx/dcss/dcss-dev.c | 17 +--- drivers/gpu/drm/imx/dcss/dcss-kms.c | 31 - drivers

Re: [PATCH v3 07/22] drm/imx/dcss: Initialize DRM driver instance with CMA helper macro

2020-09-23 Thread Laurentiu Palcu
of > this change. > > Two callbacks, .gem_prime_export and .gem_prime_import, were initialized > to their default implementations, so they are just kept empty now. > > Signed-off-by: Thomas Zimmermann > Reported-by: kernel test robot > --- Reviewed-by: Laurentiu Palcu Than

Re: [PATCH v9 0/5] Add support for iMX8MQ Display Controller Subsystem

2020-08-28 Thread Laurentiu Palcu
ing I haven't been very active in this area... :/ On that note, I will probably need help with the merging, provided it's still happenning. Will you be able to help me out with this? Thanks, laurentiu On Fri, Jul 31, 2020 at 11:18:28AM +0300, Laurentiu Palcu wrote: > From: Lauren

Re: [PATCH v9 0/5] Add support for iMX8MQ Display Controller Subsystem

2020-08-31 Thread Laurentiu Palcu
Hi Lucas, Sam, On Mon, Aug 31, 2020 at 12:37:23PM +0200, Lucas Stach wrote: > Hi Laurentiu, > > On Fr, 2020-08-28 at 11:36 +0300, Laurentiu Palcu wrote: > > Hi Lucas, > > > > I was wondering about the plans to merge this series. Since not many > > people can tes

per-plane LUTs and CSCs?

2020-09-09 Thread Laurentiu Palcu
Hi all, I was wondering whether you could give me an advise on how to proceed further with the following issue as I'm preparing to upstream the next set of patches for the iMX8MQ display controller(DCSS). The display controller has 3 planes, each with 2 CSCs and one degamma LUT. The CSCs are in fr

  1   2   >