Hi Geert,
On Thu, Jan 17, 2019 at 11:21:32AM +0100, Geert Uytterhoeven wrote:
> On Thu, Jan 17, 2019 at 3:07 AM Laurent Pinchart
> wrote:
> > The LVDS1 encoder must supply a pixel clock to the DU for the DPAD
> > output when the LVDS0 encoder is used. Enable it despite its ou
Hi Peter,
Thank you for the patch.
On Sat, Dec 29, 2018 at 07:07:25AM +, Peter Rosin wrote:
> Drop #address-cells and #size-cells from the root node in the
> example, they are unused.
>
> Reviewed-by: Rob Herring
> Signed-off-by: Peter Rosin
Reviewed-by: L
s90c185.txt
> > @@ -0,0 +1,55 @@
> > +Texas Instruments FPD-Link (LVDS) Serializer
> > +
> > +
> > +The DS90C185 and DS90C187 are low-power serializers for portable
> > +battery-powered applications that reduc
rting the binding
> (lvds-encoder.c) never implemented the property, and no dts file
> names it. At least not upstream.
>
> Signed-off-by: Peter Rosin
Reviewed-by: Laurent Pinchart
> ---
> Documentation/devicetree/bindings/display/bridge/thine,thc63lvdm83d.txt | 2
> +-
>
Hi Peter,
Thank you for the patch.
On Sat, Dec 29, 2018 at 07:07:37AM +, Peter Rosin wrote:
> Make the code easier to read and modify.
>
> Signed-off-by: Peter Rosin
Reviewed-by: Laurent Pinchart
> ---
> drivers/gpu/drm/bridge/lvds-encoder.c | 19 +--
&g
struct lvds_encoder,
> + bridge);
> +
> + if (lvds_encoder->powerdown_gpio)
> + gpiod_set_value_cansleep(lvds_encoder->powerdown_gpio, 1);
Same here.
> +}
> +
> static struct drm_bridge_funcs funcs = {
Whil
Hajda
> Signed-off-by: Peter Rosin
Reviewed-by: Laurent Pinchart
> ---
> drivers/gpu/drm/bridge/lvds-encoder.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/lvds-encoder.c
> b/drivers/gpu/drm/bridge/lvds-encoder.
depends on OF
> + depends on INPUT
> select DRM_KMS_HELPER
> imply EXTCON
> - select INPUT
> select RC_CORE
RC_CORE is always a user-visible symbol (which by the way depends on
INPUT). I think reverting commit d6abe6df706c would be a better
solution.
>
The LVDS1 encoder must supply a pixel clock to the DU for the DPAD
output when the LVDS0 encoder is used. Enable it despite its output not
being connected.
Signed-off-by: Laurent Pinchart
---
Changes since v1:
- Add a comment in the DT to explain why the LVDS1 encoder needs to be
enabled
, the LVDS PLL needs to be controlled manually. Add an
API to do so, to be called by the DU driver.
The drivers/gpu/drm/rcar-du/ directory has to be treated as obj-y
unconditionally, as the LVDS driver could be built-in while the DU
driver is compiled as a module.
Signed-off-by: Laurent Pinchart
case on D3 and E3.
Signed-off-by: Laurent Pinchart
---
Changes since v1:
- Typo fix in the commit message
---
drivers/gpu/drm/rcar-du/rcar_lvds.c | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c
b/drivers/gpu/drm/rc
, removing most of the DT parsing.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 3 +-
drivers/gpu/drm/rcar-du/rcar_du_encoder.h | 3 +-
drivers/gpu/drm/rcar-du/rcar_du_kms.c | 52 ++-
3 files changed, 6 insertions(+), 52 deletions(-)
diff
in the DT files.
The patches have been tested on Draak only as I don't have access to an
Ebisu board, but they should work equally well on both boards.
For your convenience the patches are available from
git://linuxtv.org/pinchartl/media.git drm/du/d3e3
Laurent Pinchart (6):
drm:
On the D3 and E3 SoCs the LVDS PLL clock output provides the dot clock
to the DU channels, even when the LVDS outputs are not in use. Enable
and disable the LVDS clock output when enabling or disabling a CRTC
connected to the DPAD0 output.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm
The LVDS1 encoder must supply a pixel clock to the DU for the DPAD
output when the LVDS0 encoder is used. Enable it despite its output not
being connected.
Signed-off-by: Laurent Pinchart
---
Changes since v1:
- Add a comment in the DT to explain why the LVDS1 encoder needs to be
enabled
Hi Simon,
On Wed, Jan 23, 2019 at 09:56:57AM +0100, Simon Horman wrote:
> On Wed, Jan 23, 2019 at 12:54:04AM +0200, Laurent Pinchart wrote:
> > The LVDS1 encoder must supply a pixel clock to the DU for the DPAD
> > output when the LVDS0 encoder is used. Enable it despite its outpu
ct RC_CORE
>
> Keeping "select RC_CORE" is wrong though, as the driver appears to be
> working find without RC. Maybe it should be stubbed out?
It should definitely not be select'ed as it's a user-visible symbol. My
preference would be to simply revert d6abe6df706c. If
Hello Dmity,
On Wed, Jan 23, 2019 at 02:21:05PM -0800, Dmitry Torokhov wrote:
> On Thu, Jan 24, 2019 at 12:17:35AM +0200, Laurent Pinchart wrote:
> > On Wed, Jan 23, 2019 at 02:03:42PM -0800, Dmitry Torokhov wrote:
> >> On Wed, Jan 23, 2019 at 09:45:56AM +0100, Lukas Wunner w
Hi Daniel,
On Tue, Jan 29, 2019 at 02:21:53PM +0100, Daniel Vetter wrote:
> I'm kinda fed up explaining why the have a confusing name :-)
Fully agreed, it's confusing and should definitely be fixed.
Acked-by: Laurent Pinchart
> Cc: Noralf Trønnes
> Cc: Laurent Pincha
++---
> > drivers/gpu/drm/bridge/synopsys/dw-hdmi.h | 1 +
> > drivers/gpu/drm/meson/meson_dw_hdmi.c | 128 ---
> > drivers/gpu/drm/meson/meson_vclk.c| 93 ---
> > drivers/gpu/drm/meson/meson_vclk.h| 7 +-
> > drivers/gpu/drm/meson/meson_venc.c| 8 +-
> > drivers/gpu/drm/meson/meson_venc.h| 11 ++
> > drivers/gpu/drm/meson/meson_venc_cvbs.c | 3 +-
> > include/drm/bridge/dw_hdmi.h | 7 +
> > 9 files changed, 374 insertions(+), 66 deletions(-)
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Rob,
On Wed, Jan 30, 2019 at 10:39:10AM -0600, Rob Herring wrote:
> On Tue, Jan 22, 2019 at 05:44:28PM +0200, Laurent Pinchart wrote:
> > On Tue, Jan 22, 2019 at 03:25:46PM +, Biju Das wrote:
> >> Document the RZ/G1N (R8A7744) LVDS bindings.
> >>
&
drm: rcar-du: add missing of_node_put
Laurent Pinchart (4):
drm: rcar-du: Simplify encoder registration
drm: rcar-du: lvds: Don't fail probe if output is not connected on D3/E3
drm: rcar-du: lvds: Add API to enable/disable clock output
drm: rcar-du: Turn LVDS cloc
This ensures the backlight is also disabled when the display is
> turned off like when doing xset dpms force off.
>
> Signed-off-by: Andreas Kemnade
Reviewed-by: Laurent Pinchart
> ---
> Changes in v2:
> - do not reorder initialisation
> - fix commit message
>
>
Hi Andreas,
Thank you for the patch.
On Tue, Feb 05, 2019 at 07:38:13AM +0100, Andreas Kemnade wrote:
> This adds an additional backlight property as described
> in panel-common.txt
>
> Signed-off-by: Andreas Kemnade
Reviewed-by: Laurent Pinchart
> ---
> Documentation/d
The OSD Displays OSD070T1718-19TS is a 7" WVGA (800x480) 24bit RGB panel
and is compatible with the simple-panel bindings.
Signed-off-by: Laurent Pinchart
Reviewed-by: Tomi Valkeinen
---
Changes since v2:
- Specify which of the simple-panel properties are valid
---
.../display/
Hi Tomi,
On Fri, Jan 18, 2019 at 12:33:03PM +0200, Tomi Valkeinen wrote:
> On 11/01/19 05:51, Laurent Pinchart wrote:
> > Hook up drm_bridge support in the omapdrm driver. Despite the recent
> > extensive preparation work, this is a rather intrusive change, as the
> > manage
Hi Sebastian,
On Sat, Feb 09, 2019 at 01:05:14PM +0100, Sebastian Reichel wrote:
> On Fri, Jan 11, 2019 at 03:34:19AM +0200, Laurent Pinchart wrote:
> > On Thursday, 20 December 2018 14:17:27 EET Sebastian Reichel wrote:
> >> On Mon, Dec 10, 2018 at 03:06:17AM +0200, Laur
evice
infrastructure is not affected), this will be fixed in subsequent
changes.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
---
Changes since v2:
- Remove struct omap_drm_pipeline display field
Changes since v1:
- Fix typo in function name (u
and review tags
collected. Please see individual patches for changelogs. The whole series
is available from
git://linuxtv.org/pinchartl/media.git omapdrm/bridge/next
Laurent Pinchart (46):
drm/atomic: Constify mode argument to mode_valid_path()
drm/omap: Remove declaration of
The mode_valid_path() function validates the mode it receives without
ever modifying it. Constify the mode pointer argument to make that
explicit.
Signed-off-by: Laurent Pinchart
Reviewed-by: Ville Syrjälä
Reviewed-by: Tomi Valkeinen
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
by adding back video mode flags handling in the
DSI encoder driver as a hack in the meantime.
Fixes: b4935e3a3cfa ("drm/omap: Store bus flags in the omap_dss_device
structure")
Signed-off-by: Tomi Valkeinen
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-b
The kobj field from struct omap_dss_device is not used. Remove it.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
Reviewed-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/dss/omapdss.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers
ned-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
Signed-off-by: Laurent Pinchart
Tested-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/dss/dsi.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c
b/drivers/gpu/drm/omapdrm
e API.
Replace the videomode parameter to the .check_timings() and
.set_timings() operations with a drm_display_mode. This pushed the
conversion to videomode down to the DSS devices in some cases. If needed
they will be converted to operate on drm_display_mode natively.
Signed-off-by: Laurent Pin
;s still a good practice to
disable the device explicitly. There is currently a safety check in
.remove() in some drivers but not all of them.
Remove the safety checks from the .enable() and .disable() handlers, and
add missing ones in the .remove() handler.
Signed-off-by: Laurent Pinchart
Reviewe
the alias ID is done when initializing display dss devices.
That code will be removed when moving to drm_bridge and drm_panel. Move
retrieval of the alias ID to display pipeline connection time and store
it in the pipeline structure instead to keep the feature.
Signed-off-by: Laurent Pinchart
The mode setting handler of the VENC stores the video mode internally,
to then convert it to a configuration when programming the hardware. The
stored mode is otherwise unused. Cache the configuration directly
instead.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by
create a helper
function for panels to add a single DRM mode from the panel video
timings.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/displays/panel-dpi.c | 8 ++---
.../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 10
ults
in OF child devices being potentially removed multiple times. Fix it by
placing the of_platform_depopulate() call where it belongs.
Fixes: edb715dffdee ("drm/omap: dss: dsi: Move initialization code from bind to
probe")
Signed-off-by: Tomi Valkeinen
Signed-off-by: Laurent P
Instead of manually iterating over the dss devices in the pipeline to
find the first one that implements the .get_modes() operation, add a new
operation flag for .get_modes() and use the omap_connector_find_device()
helper function to locate the right dss device.
Signed-off-by: Laurent Pinchart
The TV encoder supports both PAL and NTSC modes, but when queried for
the list of modes it supports, only the currently selected mode is
reported. Fix it and report the two modes unconditionally.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
All the internal encoders share common init and cleanup code. Factor it
out to separate functions.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/dss/dpi.c | 17 +++--
drivers/gpu/drm/omapdrm/dss/dsi.c
The omap_connector_attached_encoder() doesn't exist anymore, remove its
declaration from omap_connector.h.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
Reviewed-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/omap_connector.h | 2 --
1
The DISPC timings checks relate to the CRTC, but they're performed in
the encoder and connector .atomic_check() and .mode_valid() operations.
Move them to the CRTC .mode_valid() operation.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
---
dr
ll
be addressed separately.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
---
.../omapdrm/displays/connector-analog-tv.c| 23 +-
.../gpu/drm/omapdrm/displays/connector-dvi.c | 17 +--
.../gpu/drm/omapdrm/displays/connector-h
Now that the direction of OF graph walk has been reversed, there's no
need to lookup devices by port as we have no sink device connected
through multiple sink ports. Simplify OF lookup of the DSS devices to
look them up by node only.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Re
utput devices only.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
---
Changes since v1:
- Shutdown pipelines starting at the output device
---
.../omapdrm/displays/connector-analog-tv.c| 21 --
.../gpu/drm/omapdrm/displays/connector-dvi.c
Instead of rolling out custom suspend/resume implementations based on
state information stored in the driver's data structures, use the atomic
suspend/resume helpers that rely on a DRM atomic state object.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Seba
The venc_device structure wss_data field is set to 0 and never otherwise
modified, remove it.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
Reviewed-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/dss/venc.c | 11 +--
1 file changed, 1
Now that the .get_modes() operations takes a drm_connector and fills it
with modes, it becomes easy to fill display information in the same
operation without requiring a separate .get_size() opearation.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
-sample to
specify the pixel clock sampling edge (as set through the EDGE pin).
Signed-off-by: Laurent Pinchart
Reviewed-by: Tomi Valkeinen
Reviewed-by: Rob Herring
Tested-by: Sebastian Reichel
---
.../bindings/display/bridge/ti,tfp410.txt | 24 ++-
1 file changed, 18
The DPI and SDI encoders store the full videomode upon mode set, to only
use the value of the pixel clock when enabling the encoder. This wastes
memory. Store the pixel clock value only.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
---
drivers
The source pointer will be removed to the omap_dss_device structure.
Store it internally in the DSI panel driver data.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
---
.../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 55 ++-
1 file
The field is only used in a safety check during device
connection/disconnection, where the src field can be easily used
instead. Remove it and use src.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/dss/base.c| 6
odule is taken when constructing the dss devices chain, so the
module can only be unloaded when the dss device is disconnected.
Remove the safety checks.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
---
.../gpu/drm/omapdrm/displays/encoder-opa
paths that access the dss
devices chain from the display device, which is set to NULL when the
device isn't connected, making it impossible to access the device in
that case.
The safety check is thus not needed, remove it.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Test
evice
infrastructure is not affected), this will be fixed in subsequent
changes.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
---
Changes since v2:
- Remove struct omap_drm_pipeline display field
Changes since v1:
- Fix typo in function name (u
Replace internal usage of struct videomode with struct drm_display_mode
in order to avoid converting needlessly between the data structures.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
---
Changes since v1:
- Set mode.crtc_* fields and mode name
ocate the last matching device.
The display device is still passed to the connector init function in
order to find its type, which requires access to the end of the
pipeline.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
---
drivers/gpu/drm/om
imply use the default configuration in that case. When the chip is
configured through dedicated pins, we parse the configuration from DT.
Signed-off-by: Laurent Pinchart
Reviewed-by: Tomi Valkeinen
Reviewed-by: Jyri Sarha
Tested-by: Sebastian Reichel
---
drivers/gpu/drm/bridge/ti-tfp410.c
The encoder .atomic_check() and connector .mode_valid() operations both
walk through the dss devices in the pipeline to validate the mode.
Factor out the common code in a new omap_drm_connector_mode_fixup()
function.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by
The display isn't used by the encoder implementation, don't pass it to
the initialization function and store it internally needlessly.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/omap_drv.c | 2 +-
drive
(DRM_BUS_FLAG_DE_LOW).
Signed-off-by: Stefan Agner
Signed-off-by: Laurent Pinchart
Reviewed-by: Tomi Valkeinen
Tested-by: Sebastian Reichel
---
Changes since v1:
- Renamed bus_flags to input_bus_flags
---
drivers/gpu/drm/bridge/dumb-vga-dac.c | 6 +++---
include/drm/drm_bridge.h | 12
From: Laurent Pinchart
The DRM_BUS_FLAG_PIXDATA_(POS|NEG)EDGE and
DRM_BUS_FLAG_SYNC_(POS|NEG)EDGE flags are deprecated in favour of the
new DRM_BUS_FLAG_PIXDATA_(DRIVE|SAMPLE)_(POS|NEG)EDGE and
new DRM_BUS_FLAG_SYNC_(DRIVE|SAMPLE)_(POS|NEG)EDGE flags. Replace them
through the code.
This
For HDMI pipelines, when the output gets disconnected the device
handling CEC needs to be notified. Instead of guessing which device that
would be (and sometimes getting it wrong), notify all devices in the
pipeline.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by
Add support for the OSD070T1718-19TS 7" 800x480 panel from One Stop
Displays to the panel-simple driver.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Reviewed-by: Tomi Valkeinen
Tested-by: Sebastian Reichel
---
drivers/gpu/drm/panel/panel-simple.c
The TFP410 has a powerdown pin that can be connected to a GPIO to
control power saving. The DT bindings define a corresponding property,
but the driver doesn't implement support for it. Fix that.
Signed-off-by: Laurent Pinchart
Reviewed-by: Tomi Valkeinen
Reviewed-by: Jyri Sarha
Test
display field to the omap_dss_device
structure to identify displays, and merge the type and output_type
fields.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
---
.../gpu/drm/omapdrm/displays/connector-analog-tv.c | 1 +
drivers/gpu/drm/omapdrm/displays
The OSD Displays OSD070T1718-19TS is a 7" WVGA (800x480) 24bit RGB panel
and is compatible with the simple-panel bindings.
Signed-off-by: Laurent Pinchart
Reviewed-by: Tomi Valkeinen
Tested-by: Sebastian Reichel
---
Changes since v2:
- Specify which of the simple-panel properties are
OSD Displays is a panel manufacturer. It has been acquired by New Vision
Displays in 2015 but continues to operate under its own brand name.
Signed-off-by: Laurent Pinchart
Reviewed-by: Tomi Valkeinen
Reviewed-by: Rob Herring
Tested-by: Sebastian Reichel
---
Documentation/devicetree/bindings
Those components are supported by the drm_bridge infrastructure, remove
the omapdrm-specific driver.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/displays/Kconfig | 11 -
drivers/gpu/drm/omapdrm/displays/Makefile
bus flags (set by the panel) into account, and
enable/disable the panel in the encoder enable/disable operations
handlers.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/dss/base.c | 12 ---
drivers/gpu/drm/omapdrm
.
Signed-off-by: Laurent Pinchart
Reviewed-by: Tomi Valkeinen
Reviewed-by: Jyri Sarha
Tested-by: Sebastian Reichel
---
drivers/gpu/drm/bridge/ti-tfp410.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c
b/drivers/gpu/drm/bridge/ti-tfp410.c
The field is only used to check whether the device is connected, and we
can do so by checking the dss field instead. Remove the src field.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/dss/base.c| 14
This allows nicer kerneldoc with an easy way to reference the enum and
the values.
Signed-off-by: Laurent Pinchart
---
include/drm/drm_connector.h | 108 +---
1 file changed, 64 insertions(+), 44 deletions(-)
diff --git a/include/drm/drm_connector.h b/include
will need to attach to
the bridges before getting the aliases. As attaching to bridges requires
an encoder object, we have to reorganize the initialization sequence to
create encoders before getting aliases and sorting the pipelines.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
ck code is updated accordingly to ignore
devices managed by external bridge drivers.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/dss/base.c| 20 +++---
.../gpu/drm/omapdrm/dss/omapdss-boot-ini
From: Laurent Pinchart
The DRM_BUS_FLAG_PIXDATA_POSEDGE and DRM_BUS_FLAG_PIXDATA_NEGEDGE macros
and their DRM_BUS_FLAG_SYNC_* counterparts define on which pixel clock
edge data and sync signals are driven. They are however used in some
drivers to define on which pixel clock edge data and sync
Panels are now supported through the drm_panel infrastructure, remove
the omapdrm-specific driver.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/displays/Kconfig | 6 -
drivers/gpu/drm/omapdrm/displays/Makefile
changes
would be quite intrusive. Long term major changes will be needed there
anyway as it makes no sense to have to frameworks with similar purposes
in DRM/KMS and V4L2.
> + */
> +
> +/**
> * drm_dev_init - Initialise new DRM device
> * @dev: DRM device
> * @driver: DRM driver
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
e
> >> to review bridge related work. Andrzej has been doing it by himself
> >> for a while now.
> >>
> >> Cc: Andrzej Hajda
> >> Cc: Laurent Pinchart
> >> Cc: Gustavo Padovan
> >> Cc: Maarten Lankhorst
> >> Cc: Sean Paul
>
Hi Daniel,
On Tuesday, 18 December 2018 11:37:14 EET Daniel Vetter wrote:
> On Tue, Dec 18, 2018 at 7:47 AM Laurent Pinchart wrote:
> > On Tuesday, 18 December 2018 08:00:24 EET Kuninori Morimoto wrote:
> >> From: Kuninori Morimoto
> >>
> >> This patch
Hi Morimoto-san,
On Wednesday, 19 December 2018 02:16:55 EET Kuninori Morimoto wrote:
> Hi
>
> >>>> This patch updates license to use SPDX-License-Identifier
> >>>> instead of verbose license text.
> >>>>
> >>>> Signed-off
BUS_FMT_RGB888_1X24;
> >
> > hdmi->hdmi_data.pix_repet_factor = 0;
> > hdmi->hdmi_data.hdcp_enable = 0;
> >
> > diff --git a/include/drm/bridge/dw_hdmi.h b/include/drm/bridge/dw_hdmi.h
> > index 7a02744ce0bc..2e797f782c51 100644
> > --- a/include/drm/bridge/dw_hdmi.h
> > +++ b/include/drm/bridge/dw_hdmi.h
> > @@ -142,6 +142,11 @@ struct dw_hdmi_plat_data {
> >
> > int (*configure_phy)(struct dw_hdmi *hdmi,
> >
> > const struct dw_hdmi_plat_data *pdata,
> > unsigned long mpixelclock);
> >
> > +
> > + unsigned long (*get_input_bus_format)(void *data);
> > + unsigned long (*get_output_bus_format)(void *data);
> > + unsigned long (*get_enc_in_encoding)(void *data);
> > + unsigned long (*get_enc_out_encoding)(void *data);
> >
> > };
> >
> > struct dw_hdmi *dw_hdmi_probe(struct platform_device *pdev,
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
ode sequencing
of GPIOs and power supplies in DT. That path has been tried in the past, with
no good results.
I would instead create device-specific bindings, like done for
thine,thc63lvdm83d. It's fine to then add support for the pwdn-gpios property
in the lvds-encoder driver, as long as the meaning of the property comes from
specific DT bindings, not from the generic ones.
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
nted in the probe() path.
> err = anx78xx_enable_interrupts(anx78xx);
> if (err)
> @@ -1379,7 +1387,9 @@ static int anx78xx_i2c_probe(struct i2c_client
> *client, }
>
> /* Look for supported chip ID */
> - anx78xx_poweron(anx78xx);
> +
include
While at it, how about sorting headers alphabetically to make sure this won't
happen again ?
With that change,
Reviewed-by: Laurent Pinchart
> struct panel_bridge {
> struct drm_bridge bridge;
--
Regards,
Laurent Pinchart
___
Hi Sam,
Thank you for the patch.
On Wednesday, 26 December 2018 23:03:50 EET Sam Ravnborg wrote:
> Add missing includes in dw_hdmi.h and
> fix fallout in drivers.
>
> Signed-off-by: Sam Ravnborg
> Cc: Archit Taneja
> Cc: Andrzej Hajda
> Cc: Laurent Pinchart
> Cc: Da
: Archit Taneja
> Cc: Andrzej Hajda
> Cc: Laurent Pinchart
> Cc: Maarten Lankhorst
> Cc: Maxime Ripard
> Cc: Sean Paul
> Cc: Kieran Bingham
> ---
> drivers/gpu/drm/arc/arcpgu_sim.c | 1 +
> drivers/gpu/drm/bridge/cdns-dsi.c| 2 ++
> drivers/gpu/drm/drm
forward declarations of structures.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/rcar-du/rcar_du_crtc.c| 1 -
drivers/gpu/drm/rcar-du/rcar_du_crtc.h| 1 -
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 -
drivers/gpu/drm/rcar-du/rcar_du_drv.h | 1 +
drivers/gpu/drm/rcar-du
avoid including drm_device.h by un-inlining (Daniel)
It would be nice to explain why you de-inline the function (I assume because
it's a bit too large).
Reviewed-by: Laurent Pinchart
> Cc: Sam Ravnborg
> Cc: Daniel Vetter
> Cc: Laurent Pinchart
> Signed-off-by: Jani Nikula
> ---
to make drm_file.h self-contained."
Reviewed-by: Laurent Pinchart
> Cc: Sam Ravnborg
> Cc: Daniel Vetter
> Cc: Laurent Pinchart
> Signed-off-by: Jani Nikula
> ---
> include/drm/drm_file.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/drm/drm
luding
linux/kernel.h. This prepares for dropping drmP.h from files including
drm_hdcp.h."
Reviewed-by: Laurent Pinchart
> Cc: Sam Ravnborg
> Cc: Daniel Vetter
> Cc: Laurent Pinchart
> Signed-off-by: Jani Nikula
> ---
> include/drm/drm_hdcp.h | 2 ++
> 1 file changed, 2
Hi Jani,
Thank you for the patch.
On Friday, 28 December 2018 10:28:15 EET Jani Nikula wrote:
> Make it easier to drop drmP.h includes. Switch from "" to <> includes
> while at it.
>
> v2: forward declare instead of including drm_file.h (Daniel)
Reviewed-by: Lau
It's also included in drm-tip now.
>
> So I did this *before* I got the review feedback from Laurent, based on
> Daniel's review only. Would you all like me to redo the branch with
> Laurent's comments addressed and r-b added?
If you think my comments are valuable, th
Hi Sebastian,
On Thursday, 20 December 2018 14:17:27 EET Sebastian Reichel wrote:
> Hi,
>
> On Mon, Dec 10, 2018 at 03:06:17AM +0200, Laurent Pinchart wrote:
> > This patch series hooks up support for drm_bridge and drm_panel in the
> > omapdrm driver.
> >
&
utput devices only.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
---
Changes since v1:
- Shutdown pipelines starting at the output device
---
.../omapdrm/displays/connector-analog-tv.c| 21 --
.../gpu/drm/omapdrm/displays/connector-dvi.c
The field is only used in a safety check during device
connection/disconnection, where the src field can be easily used
instead. Remove it and use src.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/dss/base.c| 6
All the internal encoders share common init and cleanup code. Factor it
out to separate functions.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/dss/dpi.c | 17 +++--
drivers/gpu/drm/omapdrm/dss/dsi.c
The omap_connector_attached_encoder() doesn't exist anymore, remove its
declaration from omap_connector.h.
Signed-off-by: Laurent Pinchart
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/omap_connector.h | 2 --
1 file changed, 2 deletions(-)
901 - 1000 of 9324 matches
Mail list logo
