Re: [PATCH 01/11] ASoC: dai_dma: remove slave_id field

2021-11-15 Thread Lars-Peter Clausen
On 11/15/21 9:53 AM, Arnd Bergmann wrote: From: Arnd Bergmann This field is never set, and serves no purpose, so remove it. I agree that we should remove it. Its been legacy support code for a while, but the description that there is no user is not right. The tegra20_spdif driver obviously

Re: [PATCH 01/11] ASoC: dai_dma: remove slave_id field

2021-11-15 Thread Lars-Peter Clausen
On 11/15/21 11:42 AM, Arnd Bergmann wrote: On Mon, Nov 15, 2021 at 11:14 AM Lars-Peter Clausen wrote: On 11/15/21 9:53 AM, Arnd Bergmann wrote: From: Arnd Bergmann This field is never set, and serves no purpose, so remove it. I agree that we should remove it. Its been legacy support code

Re: [PATCH 01/15] iio: buffer-dma: Get rid of incoming/outgoing queues

2021-11-21 Thread Lars-Peter Clausen
On 11/15/21 3:19 PM, Paul Cercueil wrote: The buffer-dma code was using two queues, incoming and outgoing, to manage the state of the blocks in use. While this totally works, it adds some complexity to the code, especially since the code only manages 2 blocks. It is much easier to just check eac

Re: [PATCH 01/15] iio: buffer-dma: Get rid of incoming/outgoing queues

2021-11-21 Thread Lars-Peter Clausen
On 11/21/21 6:52 PM, Paul Cercueil wrote: Hi Lars, Le dim., nov. 21 2021 at 17:23:35 +0100, Lars-Peter Clausen a écrit : On 11/15/21 3:19 PM, Paul Cercueil wrote: The buffer-dma code was using two queues, incoming and outgoing, to manage the state of the blocks in use. While this totally

Re: [PATCH 01/15] iio: buffer-dma: Get rid of incoming/outgoing queues

2021-11-22 Thread Lars-Peter Clausen
On 11/21/21 9:08 PM, Paul Cercueil wrote: Le dim., nov. 21 2021 at 19:49:03 +0100, Lars-Peter Clausen a écrit : On 11/21/21 6:52 PM, Paul Cercueil wrote: Hi Lars, Le dim., nov. 21 2021 at 17:23:35 +0100, Lars-Peter Clausen  a écrit : On 11/15/21 3:19 PM, Paul Cercueil wrote: The

Re: [PATCH 01/15] iio: buffer-dma: Get rid of incoming/outgoing queues

2021-11-22 Thread Lars-Peter Clausen
On 11/22/21 4:16 PM, Paul Cercueil wrote: Hi Lars, Le lun., nov. 22 2021 at 16:08:51 +0100, Lars-Peter Clausen a écrit : On 11/21/21 9:08 PM, Paul Cercueil wrote: Le dim., nov. 21 2021 at 19:49:03 +0100, Lars-Peter Clausen  a écrit : On 11/21/21 6:52 PM, Paul Cercueil wrote: Hi Lars

Re: [PATCH 11/15] iio: buffer-dma: Boost performance using write-combine cache setting

2021-11-28 Thread Lars-Peter Clausen
On 11/27/21 5:05 PM, Jonathan Cameron wrote: Non-coherent mapping with no cache sync: - fileio: read: 156 MiB/s write: 123 MiB/s - dmabuf: read: 234 MiB/s (capped by sample rate) write: 182 MiB/s Non-coherent reads with no cache sync + write-combine writes:

Re: [PATCH v3 07/11] iio: core: Add new DMABUF interface infrastructure

2023-04-04 Thread Lars-Peter Clausen
On 4/4/23 00:55, Paul Cercueil wrote: [...] +   priv = attach->importer_priv; +   list_del_init(&priv->entry); + +   iio_buffer_dmabuf_put(attach); +   iio_buffer_dmabuf_put(attach); + Is this intended? Looks suspicious... It is intended, yes. You want to release the dma_buf_at

[PATCH 1/2 v3] drm/bridge: adv7511: Add Audio support.

2016-09-16 Thread Lars-Peter Clausen
On 09/07/2016 01:22 AM, John Stultz wrote: > This patch adds support to Audio for both adv7511 and adv7533 > bridge chips. > > This patch was originally from [1] by Lars-Peter Clausen > and was adapted by Archit Taneja and > Srinivas Kandagatla . > > Then I heavily rew

[PATCH RESEND 3/3] drm: adv7511: it's HPD, not HDP

2016-01-04 Thread Lars-Peter Clausen
On 01/04/2016 03:33 AM, Wolfram Sang wrote: > From: Wolfram Sang > > Fix this typo, consequently used over both files :) > > Signed-off-by: Wolfram Sang Acked-by: Lars-Peter Clausen Thanks.

[PATCH] drm: adv7511: Fix crash in IRQ handler when no encoder is associated

2015-05-14 Thread Lars-Peter Clausen
> > Fix this by ignoring hot plug detection IRQs when no encoder is > associated yet. > > Signed-off-by: Laurent Pinchart Acked-by: Lars-Peter Clausen > --- > drivers/gpu/drm/i2c/adv7511.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/d

[PATCH v2 00/11] ARM: dts: zynq: Prepare Parallella

2014-07-28 Thread Lars-Peter Clausen
On 07/28/2014 06:17 PM, Andreas F?rber wrote: > Hi Lars-Peter, > > Am 25.07.2014 01:00, schrieb Andreas F?rber: >> most notably I'm missing >> ADI ADV7513 and AXI-HDMI support > [...] >> Cc: Lars-Peter Clausen (HDMI) > > Could you please enlighten us

Re: [RFC 01/10] drm: ADV7511 i2c HDMI encoder driver

2013-09-04 Thread Lars-Peter Clausen
[...] >> + >> +/** >> + * enum adv7511_input_color_depth - Selects the input format color depth >> + * @ADV7511_INPUT_COLOR_DEPTH_8BIT: Input format color depth is 8 bits per > channel >> + * @ADV7511_INPUT_COLOR_DEPTH_10BIT: Input format color dpeth is 10 bits > per channel >> + * @ADV7511_INPUT

[PATCH 0/8] i2c: Remove redundant driver field from the i2c_client struct

2013-09-29 Thread Lars-Peter Clausen
nd of course also the runtime memory footprint of the i2c_client struct is reduced. - Lars Lars-Peter Clausen (8): [media] s5c73m3: Don't use i2c_client->driver [media] exynos4-is: Don't use i2c_client->driver [media] core: Don't use i2c_client->driver drm: encoder_slav

[PATCH 1/8] [media] s5c73m3: Don't use i2c_client->driver

2013-09-29 Thread Lars-Peter Clausen
The 'driver' field of the i2c_client struct is redundant and is going to be removed. The results of the expressions 'client->driver.driver->field' and 'client->dev.driver->field' are identical, so replace all occurrences of the former with the lat

[PATCH 2/8] [media] exynos4-is: Don't use i2c_client->driver

2013-09-29 Thread Lars-Peter Clausen
The 'driver' field of the i2c_client struct is redundant and is going to be removed. The results of the expressions 'client->driver.driver->field' and 'client->dev.driver->field' are identical, so replace all occurrences of the former with the lat

[PATCH 4/8] drm: encoder_slave: Don't use i2c_client->driver

2013-09-29 Thread Lars-Peter Clausen
get direct access to the i2c_driver struct use 'to_i2c_driver(client->dev.driver)'. Signed-off-by: Lars-Peter Clausen --- drivers/gpu/drm/drm_encoder_slave.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_encoder_slave.c b/drivers/gp

[PATCH 5/8] drm: nouveau: Don't use i2c_client->driver

2013-09-29 Thread Lars-Peter Clausen
The 'driver' field of the i2c_client struct is redundant and is going to be removed. Use 'to_i2c_driver(client->dev.driver)' instead to get direct access to the i2c_driver struct. Signed-off-by: Lars-Peter Clausen Cc: Martin Peres --- drivers/gpu/drm/nouveau/core/subde

[PATCH 6/8] ALSA: ppc: keywest: Don't use i2c_client->driver

2013-09-29 Thread Lars-Peter Clausen
The 'driver' field of the i2c_client struct is redundant and is going to be removed. Use 'to_i2c_driver(client->dev.driver)' instead to get direct access to the i2c_driver struct. Signed-off-by: Lars-Peter Clausen --- sound/ppc/keywest.c | 4 ++-- 1 file changed, 2 ins

[PATCH 3/8] [media] core: Don't use i2c_client->driver

2013-09-29 Thread Lars-Peter Clausen
The 'driver' field of the i2c_client struct is redundant and is going to be removed. The results of the expressions 'client->driver.driver->field' and 'client->dev.driver->field' are identical, so replace all occurrences of the former with the

[PATCH 7/8] ASoC: imx-wm8962: Don't use i2c_client->driver

2013-09-29 Thread Lars-Peter Clausen
The 'driver' field of the i2c_client struct is redundant and is going to be removed. Check i2c_client->dev.driver instead to see if a driver is bound to the device. Signed-off-by: Lars-Peter Clausen --- sound/soc/fsl/imx-wm8962.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[PATCH 8/8] i2c: Remove redundant 'driver' field from the i2c_client struct

2013-09-29 Thread Lars-Peter Clausen
removes the 'driver' field from the i2c_client struct. Signed-off-by: Lars-Peter Clausen --- drivers/i2c/i2c-core.c | 21 - drivers/i2c/i2c-smbus.c | 10 ++ include/linux/i2c.h | 2 -- 3 files changed, 18 insertions(+), 15 deletions(-) diff --git a/drivers/

[PATCH] adv7511: Added mode_fixup function.

2016-02-04 Thread Lars-Peter Clausen
On 02/04/2016 04:22 PM, Carlos Palminha wrote: > Hi guys, > > any feedback? patch will be accepted for adv7511 driver? Hi, Thanks for the patch, but please try to find and fix the call site that is trying to invoke the callback even though it does not exist. This is most likely drm_i2c_encoder_

[alsa-devel] [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver

2016-04-08 Thread Lars-Peter Clausen
On 04/08/2016 12:06 PM, Jose Abreu wrote: > Hi Mark, > > > On 07-04-2016 18:53, Mark Brown wrote: >> On Thu, Apr 07, 2016 at 05:53:59PM +0100, Jose Abreu wrote: >> >>> + Optional properties: >>> + - snps,use-dmaengine: If set the driver will use ALSA DMA engine. If set >>> + it is required to u

[alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

2016-04-08 Thread Lars-Peter Clausen
On 04/07/2016 06:53 PM, Jose Abreu wrote: > This patch adds audio support for the ADV7511 HDMI transmitter > using ALSA SoC. > > The code was ported from Analog Devices linux tree from > commit 1770c4a1e32b ("Merge remote-tracking branch > 'xilinx/master' into xcomm_zynq"), which is available at:

[alsa-devel] [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver

2016-04-09 Thread Lars-Peter Clausen
On 04/08/2016 06:08 PM, Jose Abreu wrote: > Hi Lars, > > > On 08-04-2016 16:52, Lars-Peter Clausen wrote: >> On 04/08/2016 12:06 PM, Jose Abreu wrote: >>> Hi Mark, >>> >>> >>> On 07-04-2016 18:53, Mark Brown wrote: >>&

[alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

2016-04-09 Thread Lars-Peter Clausen
On 04/08/2016 06:12 PM, Jose Abreu wrote: [...] >> >> [...] >>> +- adi,enable-audio: If set the ADV7511 driver will register a codec >>> interface >>> + into ALSA SoC. >> This is not a description of the hardware. > > Is this okay: "adi,enable-audio: Set this boolean parameter if ADV7511 > trans

[alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

2016-04-11 Thread Lars-Peter Clausen
On 04/11/2016 11:27 AM, Jose Abreu wrote: > Hi Lars, > > > On 09-04-2016 16:02, Lars-Peter Clausen wrote: >> On 04/08/2016 06:12 PM, Jose Abreu wrote: >> [...] >>>> [...] >>>>> +- adi,enable-audio: If set the ADV7511 driver will register a codec

[alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

2016-04-11 Thread Lars-Peter Clausen
On 04/11/2016 01:32 PM, Jose Abreu wrote: > Hi Lars, > > > On 11-04-2016 10:33, Lars-Peter Clausen wrote: >> On 04/11/2016 11:27 AM, Jose Abreu wrote: >>> Hi Lars, >>> >>> >>> On 09-04-2016 16:02, Lars-Peter Clause

[alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

2016-04-11 Thread Lars-Peter Clausen
On 04/11/2016 04:08 PM, Jose Abreu wrote: [...] >> Currently there is also zero support of of-graph in ASoC, so a bit of work >> is required to get this integrated properly. >> > > I also believe this would be the better option but in the meantime can't I > integrate the audio like it is being don

[PATCH 3/4] drm/bridge: adv7511: Enable connector polling when no interrupt is specified

2017-09-05 Thread Lars-Peter Clausen
Fall back to polling the connector for connect and disconnect events when no interrupt is specified. Otherwise these events will not be noticed and monitor hotplug does not work. Signed-off-by: Lars-Peter Clausen --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 6 +- 1 file changed, 5

[PATCH 4/4] drm/bridge: adv7511: Constify HDMI CODEC platform data

2017-09-05 Thread Lars-Peter Clausen
The HDMI codec platform data is global driver state shared by all instances. As such it should not be modified (and is not), to make this explicit declare it as const. Signed-off-by: Lars-Peter Clausen --- drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 2/4] drm/bridge: adv7511: Remove private copy of the EDID

2017-09-05 Thread Lars-Peter Clausen
-Peter Clausen --- drivers/gpu/drm/bridge/adv7511/adv7511.h | 2 -- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 16 ++-- 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511.h b/drivers/gpu/drm/bridge/adv7511/adv7511.h index

[PATCH 1/4] drm/bridge: adv7511: Properly update EDID when no EDID was found

2017-09-05 Thread Lars-Peter Clausen
after the EDID check handle the case where the EDID is NULL just fine and exhibit the expected behavior, so just drop the check. Signed-off-by: Lars-Peter Clausen --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/adv7511

Re: [PATCH v2 3/5] [RFT] ARM: dts: wheat: Fix ADV7513 address usage

2018-02-12 Thread Lars-Peter Clausen
On 02/12/2018 07:11 PM, Kieran Bingham wrote: [...] > + /* > + * The adv75xx resets its addresses to defaults during low power power > + * mode. Because we have two ADV7513 devices on the same bus, we must > + * change both of them away from the defaults so that they do not > +

Re: [PATCH 2/2] drm: adv7511: Add support for i2c_new_secondary_device

2018-01-22 Thread Lars-Peter Clausen
On 01/22/2018 01:50 PM, Kieran Bingham wrote: > The ADV7511 has four 256-byte maps that can be accessed via the main I²C > ports. Each map has it own I²C address and acts as a standard slave > device on the I²C bus. > > Allow a device tree node to override the default addresses so that > address c

Re: [RFC v2 3/5] drm: Add HDMI infoframe helpers

2012-12-05 Thread Lars-Peter Clausen
On 12/05/2012 05:45 PM, Thierry Reding wrote: > Add a generic helper to fill in an HDMI AVI infoframe with data > extracted from a DRM display mode. That's a very nice patch series, comes in pretty handy. Thanks :) I've just one comment. > [...] > +static inline enum hdmi_picture_aspect > +drm_d

Re: [RFC v2 3/5] drm: Add HDMI infoframe helpers

2012-12-06 Thread Lars-Peter Clausen
On 12/06/2012 08:28 AM, Thierry Reding wrote: > On Wed, Dec 05, 2012 at 06:51:20PM +0100, Lars-Peter Clausen wrote: >> On 12/05/2012 05:45 PM, Thierry Reding wrote: >>> Add a generic helper to fill in an HDMI AVI infoframe with data >>> extracted from a DRM display mod

Re: CDF discussions at FOSDEM

2013-01-31 Thread Lars-Peter Clausen
On 01/31/2013 11:53 AM, Laurent Pinchart wrote: > On Friday 11 January 2013 21:27:03 Laurent Pinchart wrote: >> Hi everybody, >> >> Would anyone be interested in meeting at the FOSDEM to discuss the Common >> Display Framework ? There will be a CDF meeting at the ELC at the end of >> February, the

Re: [PULL] SH Mobile DRM driver for v3.7

2012-09-15 Thread Lars-Peter Clausen
On 09/15/2012 01:28 AM, Dave Airlie wrote: > On Fri, Sep 14, 2012 at 10:38 PM, Laurent Pinchart > wrote: >> Hi Dave, >> >> The SH Mobile DRM driver is now (in my opinion) ready for mainline. It >> requires GEM and KMS/FB helpers that have been reviewed on the list and >> tested. Sascha is waiting

[PATCH 1/2] drm: Fix EDID color format parsing

2012-02-10 Thread Lars-Peter Clausen
The code should obviously check the EDID feature field for EDID feature flags and not the color_formats field of the drm_display_info struct. Also it should update the color_formats field with new modes instead of overwriting the current mode. Signed-off-by: Lars-Peter Clausen --- drivers/gpu

[PATCH 2/2] drm: Parse color format information in CEA blocks

2012-02-10 Thread Lars-Peter Clausen
-Peter Clausen --- drivers/gpu/drm/drm_edid.c | 31 +-- 1 files changed, 21 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index a6bb2f5..390aeca 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm

[PATCH resend 2/2] drm: Parse color format information in CEA blocks

2012-02-28 Thread Lars-Peter Clausen
The CEA extension block has a field which describes which YCbCr modes are supported by the device, use it to fill the drm_display_info color_formats fields. Also the existence of a CEA extension block is used as indication that the device supports RGB. Signed-off-by: Lars-Peter Clausen

[PATCH resend 1/2] drm: Fix EDID color fromat parsing

2012-02-28 Thread Lars-Peter Clausen
The code should obviously check the EDID feature field for EDID feature flags and not the color_formats field of the drm_display_info struct. Also update the color_formats field with new modes instead of overwriting the current mode. Signed-off-by: Lars-Peter Clausen --- drivers/gpu/drm

Re: [PATCH resend 1/2] drm: Fix EDID color fromat parsing

2012-03-01 Thread Lars-Peter Clausen
On 02/28/2012 07:04 PM, Jesse Barnes wrote: > On Tue, 28 Feb 2012 10:21:44 +0100 > Lars-Peter Clausen wrote: > >> The code should obviously check the EDID feature field for EDID feature flags >> and not the color_formats field of the drm_display_info struct. Also update &g

Re: [PATCH resend 1/2] drm: Fix EDID color fromat parsing

2012-03-15 Thread Lars-Peter Clausen
On 02/28/2012 07:04 PM, Jesse Barnes wrote: > On Tue, 28 Feb 2012 10:21:44 +0100 > Lars-Peter Clausen wrote: > >> The code should obviously check the EDID feature field for EDID feature flags >> and not the color_formats field of the drm_display_info struct. Also update &g

[PATCH resend 1/2] drm: Fix EDID color format parsing

2012-04-16 Thread Lars-Peter Clausen
The code should obviously check the EDID feature field for EDID feature flags and not the color_formats field of the drm_display_info struct. Also update the color_formats field with new modes instead of overwriting the current mode. Signed-off-by: Lars-Peter Clausen Reviewed-by: Jesse Barnes

[PATCH resend 2/2] drm: Parse color format information in CEA blocks

2012-04-16 Thread Lars-Peter Clausen
The CEA extension block has a field which describes which YCbCr modes are supported by the device, use it to fill the drm_display_info color_formats fields. Also the existence of a CEA extension block is used as indication that the device supports RGB. Signed-off-by: Lars-Peter Clausen Reviewed

Re: Enhancing EDID quirk functionality

2012-04-24 Thread Lars-Peter Clausen
On 04/19/2012 09:16 PM, Ian Pilcher wrote: > Greetings all! > > I recently discovered that my nice 1900x1200 display is horribly > confused by the InfoFrame functionality that was added to the nouveau > driver in Linux 3.3. Additional testing has shown that it has the same > problem with the i915

Re:

2012-05-22 Thread Lars-Peter Clausen
On 05/18/2012 02:27 PM, Sascha Hauer wrote: > Hi All, > > The following adds a drm/kms driver for the Freescale i.MX LCDC > controller. Most notable change to the last SDRM based version is that > the SDRM layer has been removed and the driver now is purely i.MX > specific. I hope that this is mor

Re: [PATCH 1/2] DRM: add Freescale i.MX LCDC driver

2012-05-23 Thread Lars-Peter Clausen
[...] >>> + >>> +static int imx_drm_gem_mmap_buffer(struct file *filp, >>> + struct vm_area_struct *vma) >>> +{ >>> + struct drm_gem_object *obj = filp->private_data; >>> + struct imx_drm_gem_obj *imx_drm_gem_obj = to_imx_drm_gem_obj(obj); >>> + struct imx_drm_buf_en

Re: [PATCH] DRM: add drm gem CMA helper

2012-05-29 Thread Lars-Peter Clausen
On 05/29/2012 04:10 PM, Sascha Hauer wrote: > Many embedded drm devices do not have a IOMMU and no dedicated > memory for graphics. These devices use CMA (Contiguous Memory > Allocator) backed graphics memory. This patch provides helper > functions to be able to share the code. > > Signed-off-by:

Re: [PATCH] DRM: add drm gem CMA helper

2012-05-29 Thread Lars-Peter Clausen
On 05/29/2012 04:46 PM, Lars-Peter Clausen wrote: > On 05/29/2012 04:10 PM, Sascha Hauer wrote: >> Many embedded drm devices do not have a IOMMU and no dedicated >> memory for graphics. These devices use CMA (Contiguous Memory >> Allocator) backed graphics memory. This

[PATCH 1/2] DRM: Add DRM kms/fb cma helper

2012-05-29 Thread Lars-Peter Clausen
This patchset introduces a set of helper function for implementing the KMS framebuffer layer for drivers which use the drm gem CMA helper function. Signed-off-by: Lars-Peter Clausen --- drivers/gpu/drm/Kconfig | 11 ++ drivers/gpu/drm/Makefile|1 + drivers/gpu/drm

[PATCH 2/2] DRM: imx: Use new fb cma helper functions

2012-05-29 Thread Lars-Peter Clausen
--- Sascha, this is against your inital patch and I suppose it does not apply cleanly anymore to your current tree, but it shouldn't be to hard to make the changes manually. Can you test whether the generic cma fb helper functions works for you? --- drivers/gpu/drm/imx/Kconfig |1 + dr

Re: [PATCH 4/4] drm: Renesas SH Mobile DRM driver

2012-05-30 Thread Lars-Peter Clausen
On 05/30/2012 03:43 PM, Sascha Hauer wrote: > Hi Laurent, > > On Wed, May 30, 2012 at 02:32:59PM +0200, Laurent Pinchart wrote: >> The SH Mobile LCD controller (LCDC) DRM driver supports the main >> graphics plane in RGB and YUV formats, as well as the overlay planes (in >> alpha-blending mode onl

Re: [PATCH 4/4] drm: Renesas SH Mobile DRM driver

2012-05-30 Thread Lars-Peter Clausen
On 05/30/2012 02:32 PM, Laurent Pinchart wrote: > [...] > + for (i = 0; i < (format->yuv ? 2 : 1); ++i) { > + obj = drm_gem_object_lookup(dev, file_priv, > + mode_cmd->handles[i]); > + if (obj == NULL) { > + dev

Re: [PATCH 4/4] drm: Renesas SH Mobile DRM driver

2012-05-30 Thread Lars-Peter Clausen
On 05/30/2012 04:45 PM, Lars-Peter Clausen wrote: > On 05/30/2012 02:32 PM, Laurent Pinchart wrote: >> [...] >> +for (i = 0; i < (format->yuv ? 2 : 1); ++i) { >> +obj = drm_gem_object_lookup(dev, file_priv, >> +

[PATCH v2] DRM: Add DRM kms/fb cma helper

2012-05-30 Thread Lars-Peter Clausen
This patch introduces a set of helper function for implementing the KMS framebuffer layer for drivers which use the drm gem CMA helper function. Signed-off-by: Lars-Peter Clausen --- Changes since v1: * Some spelling fixes * Add missing kfree in drm_fb_cma_alloc error path

Re: [PATCH v2] DRM: Add DRM kms/fb cma helper

2012-05-31 Thread Lars-Peter Clausen
On 05/31/2012 10:13 AM, Sascha Hauer wrote: > On Wed, May 30, 2012 at 05:30:15PM +0200, Lars-Peter Clausen wrote: >> This patch introduces a set of helper function for implementing the KMS >> framebuffer layer for drivers which use the drm gem CMA helper function. >> >>

Re: [PATCH v2] DRM: Add DRM kms/fb cma helper

2012-06-04 Thread Lars-Peter Clausen
On 05/31/2012 08:11 PM, Sascha Hauer wrote: > On Thu, May 31, 2012 at 11:34:37AM +0200, Lars-Peter Clausen wrote: >>>> + drm_helper_mode_fill_fb_struct(&fb_cma->fb, mode_cmd); >>>> + >>>> + for (i = 0; i < num_planes; i++) >>>>

Re: [PATCH v2] DRM: add drm gem cma helper

2012-06-04 Thread Lars-Peter Clausen
On 05/31/2012 10:08 AM, Sascha Hauer wrote: > [...] > diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c > new file mode 100644 > index 000..d8c0dc7 > --- /dev/null > +++ b/drivers/gpu/drm/drm_gem_cma_helper.c > @@ -0,0 +1,243 @@ > +/* > + * drm gem cma (co

Re: [PATCH 4/4] drm: Renesas SH Mobile DRM driver

2012-06-27 Thread Lars-Peter Clausen
On 06/27/2012 02:40 PM, Laurent Pinchart wrote: > Hi Lars-Peter, > > [...] > > Do you plan to post a v3 of your "DRM: Add DRM kms/fb cma helper" patch in > the > near future ? Hi Laurent, I don't think there have been any changes since v2 except for adjusting to the renamed functions in Sasch

Re: [PATCH 4/4] drm: Renesas SH Mobile DRM driver

2012-06-27 Thread Lars-Peter Clausen
On 06/27/2012 10:27 PM, Laurent Pinchart wrote: > Hi Lars-Peter, > > On Wednesday 27 June 2012 22:06:54 Lars-Peter Clausen wrote: >> On 06/27/2012 02:40 PM, Laurent Pinchart wrote: >>> Hi Lars-Peter, >>> >>> [...] >>> >>> Do you plan to

[PATCH v3] DRM: Add DRM kms/fb cma helper

2012-07-02 Thread Lars-Peter Clausen
This patchset introduces a set of helper function for implementing the KMS framebuffer layer for drivers which use the drm gem CMA helper function. Signed-off-by: Lars-Peter Clausen --- Note: This patch depends on Sascha's "DRM: add drm gem CMA helper" patch Changes since v2:

Re: [PATCH v4] DRM: add drm gem CMA helper

2012-07-18 Thread Lars-Peter Clausen
de. The code technically does > not depend on CMA as the backend allocator, the name has been chosen > because cma makes for a nice, short but still descriptive function > prefix. > > Signed-off-by: Sascha Hauer Tested-by: Lars-Peter Clausen ... for quite some time now. There are n

Re: [PATCH v3] DRM: Add DRM kms/fb cma helper

2012-07-19 Thread Lars-Peter Clausen
On 07/19/2012 02:46 PM, Laurent Pinchart wrote: > Hi Lars, > > Thank you for the patch. > > On Monday 02 July 2012 16:37:47 Lars-Peter Clausen wrote: >> This patchset introduces a set of helper function for implementing the KMS >> framebuffer layer for drivers which

Re: exynos drm hdmi audio: how to recieve audio parameters (sf, bps, channel count)

2012-07-19 Thread Lars-Peter Clausen
On 07/19/2012 02:22 PM, Rob Clark wrote: > On Tue, Jul 17, 2012 at 1:12 AM, RAHUL SHARMA > wrote: >> hi, >> >> I am adding support for hdmi audio, inside exynos drm hdmi driver. Hdmi >> audio is initialized with default parameters. I want to implement the >> mechanism to update hdmi registers,

Re: [PATCH v3] DRM: Add DRM kms/fb cma helper

2012-07-19 Thread Lars-Peter Clausen
On 07/19/2012 03:33 PM, Laurent Pinchart wrote: > Hi Lars, > > On Thursday 19 July 2012 15:34:26 Lars-Peter Clausen wrote: >> On 07/19/2012 02:46 PM, Laurent Pinchart wrote: >>> On Monday 02 July 2012 16:37:47 Lars-Peter Clausen wrote: >>>> This patchset int

Re: [PATCH v3] DRM: Add DRM kms/fb cma helper

2012-07-19 Thread Lars-Peter Clausen
On 07/19/2012 04:41 PM, Laurent Pinchart wrote: > On Thursday 19 July 2012 16:02:41 Laurent Pinchart wrote: >> On Thursday 19 July 2012 15:55:56 Lars-Peter Clausen wrote: >>> On 07/19/2012 03:33 PM, Laurent Pinchart wrote: >>>> On Thursday 19 July 2012 15:34:26 Lars

Re: [PATCH v3] DRM: Add DRM kms/fb cma helper

2012-07-19 Thread Lars-Peter Clausen
On 07/19/2012 04:57 PM, Lars-Peter Clausen wrote: > And well something similar for horizontal subsampling. s/horizontal/vertical/ ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v3] DRM: Add DRM kms/fb cma helper

2012-07-19 Thread Lars-Peter Clausen
On 07/19/2012 04:57 PM, Lars-Peter Clausen wrote: > On 07/19/2012 04:41 PM, Laurent Pinchart wrote: >> On Thursday 19 July 2012 16:02:41 Laurent Pinchart wrote: >>> On Thursday 19 July 2012 15:55:56 Lars-Peter Clausen wrote: >>>> On 07/19/2012 03:33 PM, Laurent Pincha

Re: [PATCH v3] DRM: Add DRM kms/fb cma helper

2012-07-19 Thread Lars-Peter Clausen
On 07/19/2012 05:01 PM, Laurent Pinchart wrote: > Hi Lars, > > On Thursday 19 July 2012 16:57:15 Lars-Peter Clausen wrote: >> On 07/19/2012 04:41 PM, Laurent Pinchart wrote: >>> On Thursday 19 July 2012 16:02:41 Laurent Pinchart wrote: >>>> On Thursday 19 J

Re: [PATCH v3] DRM: Add DRM kms/fb cma helper

2012-07-19 Thread Lars-Peter Clausen
On 07/19/2012 05:46 PM, Laurent Pinchart wrote: > Hi Lars, > > On Thursday 19 July 2012 17:12:28 Lars-Peter Clausen wrote: >> On 07/19/2012 04:57 PM, Lars-Peter Clausen wrote: >>> On 07/19/2012 04:41 PM, Laurent Pinchart wrote: >>>> On Thursday 19 July

Re: exynos drm hdmi audio: how to recieve audio parameters (sf, bps, channel count)

2012-07-20 Thread Lars-Peter Clausen
On 07/20/2012 01:44 PM, RAHUL SHARMA wrote: > > On Fri, Jul 20, 2012 at 11:40 AM, RAHUL SHARMA > wrote: >> >> >> --- Original Message ------- >> Sender : Lars-Peter Clausen >> Date : Jul 19, 2012 19:12 (GMT+05:30) >> Title : Re: exynos drm hd

Re: [PATCH v4] DRM: add drm gem CMA helper

2012-08-08 Thread Lars-Peter Clausen
args->width * args->bpp, 8) to calculate the pitch >> - make drm_gem_cma_vm_ops const >> - add missing #include >> changes since v1: >> - map whole buffer at mmap time, not page by page at fault time >> - several cleanups as suggested by Lars-Peter Clau

[PATCH] drm/exynos: exynos_hdmi: Pass correct pointer to free_irq()

2013-05-20 Thread Lars-Peter Clausen
) @@ position p != r2.p; @@ *free_irq@p(...) Signed-off-by: Lars-Peter Clausen --- drivers/gpu/drm/exynos/exynos_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index bbfc384..7e99853 100644 --- a

[PATCH resend 1/2] drm: Fix EDID color format parsing

2012-04-16 Thread Lars-Peter Clausen
The code should obviously check the EDID feature field for EDID feature flags and not the color_formats field of the drm_display_info struct. Also update the color_formats field with new modes instead of overwriting the current mode. Signed-off-by: Lars-Peter Clausen Reviewed-by: Jesse Barnes

[PATCH resend 2/2] drm: Parse color format information in CEA blocks

2012-04-16 Thread Lars-Peter Clausen
The CEA extension block has a field which describes which YCbCr modes are supported by the device, use it to fill the drm_display_info color_formats fields. Also the existence of a CEA extension block is used as indication that the device supports RGB. Signed-off-by: Lars-Peter Clausen Reviewed

Enhancing EDID quirk functionality

2012-04-24 Thread Lars-Peter Clausen
On 04/19/2012 09:16 PM, Ian Pilcher wrote: > Greetings all! > > I recently discovered that my nice 1900x1200 display is horribly > confused by the InfoFrame functionality that was added to the nouveau > driver in Linux 3.3. Additional testing has shown that it has the same > problem with the i915

[PATCH v4] DRM: add drm gem CMA helper

2012-08-08 Thread Lars-Peter Clausen
args->width * args->bpp, 8) to calculate the pitch >> - make drm_gem_cma_vm_ops const >> - add missing #include >> changes since v1: >> - map whole buffer at mmap time, not page by page at fault time >> - several cleanups as suggested by Lars-Peter Clau

[RFC v2 3/5] drm: Add HDMI infoframe helpers

2012-12-05 Thread Lars-Peter Clausen
On 12/05/2012 05:45 PM, Thierry Reding wrote: > Add a generic helper to fill in an HDMI AVI infoframe with data > extracted from a DRM display mode. That's a very nice patch series, comes in pretty handy. Thanks :) I've just one comment. > [...] > +static inline enum hdmi_picture_aspect > +drm_d

[RFC v2 3/5] drm: Add HDMI infoframe helpers

2012-12-06 Thread Lars-Peter Clausen
On 12/06/2012 08:28 AM, Thierry Reding wrote: > On Wed, Dec 05, 2012 at 06:51:20PM +0100, Lars-Peter Clausen wrote: >> On 12/05/2012 05:45 PM, Thierry Reding wrote: >>> Add a generic helper to fill in an HDMI AVI infoframe with data >>> extracted from a DRM display mod

[PATCH 1/2] drm: Fix EDID color format parsing

2012-02-10 Thread Lars-Peter Clausen
The code should obviously check the EDID feature field for EDID feature flags and not the color_formats field of the drm_display_info struct. Also it should update the color_formats field with new modes instead of overwriting the current mode. Signed-off-by: Lars-Peter Clausen --- drivers/gpu

[PATCH 2/2] drm: Parse color format information in CEA blocks

2012-02-10 Thread Lars-Peter Clausen
-Peter Clausen --- drivers/gpu/drm/drm_edid.c | 31 +-- 1 files changed, 21 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index a6bb2f5..390aeca 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm

[PATCH resend 2/2] drm: Parse color format information in CEA blocks

2012-02-28 Thread Lars-Peter Clausen
The CEA extension block has a field which describes which YCbCr modes are supported by the device, use it to fill the drm_display_info color_formats fields. Also the existence of a CEA extension block is used as indication that the device supports RGB. Signed-off-by: Lars-Peter Clausen

[PATCH resend 1/2] drm: Fix EDID color fromat parsing

2012-02-28 Thread Lars-Peter Clausen
The code should obviously check the EDID feature field for EDID feature flags and not the color_formats field of the drm_display_info struct. Also update the color_formats field with new modes instead of overwriting the current mode. Signed-off-by: Lars-Peter Clausen --- drivers/gpu/drm

[PATCH v3] DRM: Add DRM kms/fb cma helper

2012-07-02 Thread Lars-Peter Clausen
This patchset introduces a set of helper function for implementing the KMS framebuffer layer for drivers which use the drm gem CMA helper function. Signed-off-by: Lars-Peter Clausen --- Note: This patch depends on Sascha's "DRM: add drm gem CMA helper" patch Changes since v2:

[PULL] SH Mobile DRM driver for v3.7

2012-09-15 Thread Lars-Peter Clausen
On 09/15/2012 01:28 AM, Dave Airlie wrote: > On Fri, Sep 14, 2012 at 10:38 PM, Laurent Pinchart > wrote: >> Hi Dave, >> >> The SH Mobile DRM driver is now (in my opinion) ready for mainline. It >> requires GEM and KMS/FB helpers that have been reviewed on the list and >> tested. Sascha is waiting

[PATCH v4] DRM: add drm gem CMA helper

2012-07-18 Thread Lars-Peter Clausen
de. The code technically does > not depend on CMA as the backend allocator, the name has been chosen > because cma makes for a nice, short but still descriptive function > prefix. > > Signed-off-by: Sascha Hauer Tested-by: Lars-Peter Clausen ... for quite some time now. There are n

[PATCH v3] DRM: Add DRM kms/fb cma helper

2012-07-19 Thread Lars-Peter Clausen
On 07/19/2012 02:46 PM, Laurent Pinchart wrote: > Hi Lars, > > Thank you for the patch. > > On Monday 02 July 2012 16:37:47 Lars-Peter Clausen wrote: >> This patchset introduces a set of helper function for implementing the KMS >> framebuffer layer for drivers which

exynos drm hdmi audio: how to recieve audio parameters (sf, bps, channel count)

2012-07-19 Thread Lars-Peter Clausen
On 07/19/2012 02:22 PM, Rob Clark wrote: > On Tue, Jul 17, 2012 at 1:12 AM, RAHUL SHARMA > wrote: >> hi, >> >> I am adding support for hdmi audio, inside exynos drm hdmi driver. Hdmi >> audio is initialized with default parameters. I want to implement the >> mechanism to update hdmi registers,

[PATCH v3] DRM: Add DRM kms/fb cma helper

2012-07-19 Thread Lars-Peter Clausen
On 07/19/2012 03:33 PM, Laurent Pinchart wrote: > Hi Lars, > > On Thursday 19 July 2012 15:34:26 Lars-Peter Clausen wrote: >> On 07/19/2012 02:46 PM, Laurent Pinchart wrote: >>> On Monday 02 July 2012 16:37:47 Lars-Peter Clausen wrote: >>>> This patchset int

[PATCH v3] DRM: Add DRM kms/fb cma helper

2012-07-19 Thread Lars-Peter Clausen
On 07/19/2012 04:41 PM, Laurent Pinchart wrote: > On Thursday 19 July 2012 16:02:41 Laurent Pinchart wrote: >> On Thursday 19 July 2012 15:55:56 Lars-Peter Clausen wrote: >>> On 07/19/2012 03:33 PM, Laurent Pinchart wrote: >>>> On Thursday 19 July 2012 15:34:26 Lars

[PATCH v3] DRM: Add DRM kms/fb cma helper

2012-07-19 Thread Lars-Peter Clausen
On 07/19/2012 04:57 PM, Lars-Peter Clausen wrote: > And well something similar for horizontal subsampling. s/horizontal/vertical/

[PATCH v3] DRM: Add DRM kms/fb cma helper

2012-07-19 Thread Lars-Peter Clausen
On 07/19/2012 04:57 PM, Lars-Peter Clausen wrote: > On 07/19/2012 04:41 PM, Laurent Pinchart wrote: >> On Thursday 19 July 2012 16:02:41 Laurent Pinchart wrote: >>> On Thursday 19 July 2012 15:55:56 Lars-Peter Clausen wrote: >>>> On 07/19/2012 03:33 PM, Laurent Pincha

[PATCH v3] DRM: Add DRM kms/fb cma helper

2012-07-19 Thread Lars-Peter Clausen
On 07/19/2012 05:01 PM, Laurent Pinchart wrote: > Hi Lars, > > On Thursday 19 July 2012 16:57:15 Lars-Peter Clausen wrote: >> On 07/19/2012 04:41 PM, Laurent Pinchart wrote: >>> On Thursday 19 July 2012 16:02:41 Laurent Pinchart wrote: >>>> On Thursday 19 J

[PATCH v3] DRM: Add DRM kms/fb cma helper

2012-07-19 Thread Lars-Peter Clausen
On 07/19/2012 05:46 PM, Laurent Pinchart wrote: > Hi Lars, > > On Thursday 19 July 2012 17:12:28 Lars-Peter Clausen wrote: >> On 07/19/2012 04:57 PM, Lars-Peter Clausen wrote: >>> On 07/19/2012 04:41 PM, Laurent Pinchart wrote: >>>> On Thursday 19 July

exynos drm hdmi audio: how to recieve audio parameters (sf, bps, channel count)

2012-07-20 Thread Lars-Peter Clausen
On 07/20/2012 01:44 PM, RAHUL SHARMA wrote: > > On Fri, Jul 20, 2012 at 11:40 AM, RAHUL SHARMA > wrote: >> >> >> --- Original Message ------- >> Sender : Lars-Peter Clausen >> Date : Jul 19, 2012 19:12 (GMT+05:30) >> Title : Re: exynos drm hd

[PATCH v2] DRM: Add DRM kms/fb cma helper

2012-06-04 Thread Lars-Peter Clausen
On 05/31/2012 08:11 PM, Sascha Hauer wrote: > On Thu, May 31, 2012 at 11:34:37AM +0200, Lars-Peter Clausen wrote: >>>> + drm_helper_mode_fill_fb_struct(&fb_cma->fb, mode_cmd); >>>> + >>>> + for (i = 0; i < num_planes; i++) >>>>

  1   2   >