anymore.
>
> Patches are rebased on current next and are independent.
> Please pick up as you wish.
>
> Best regards,
> Krzysztof
Agreed,
Acked-by: Kukjin Kim
k-gene
>
> Krzysztof Kozlowski (4):
> ARM: EXYNOS: Remove Exynos4415 driver (SoC not supported anymore)
&g
On 05/20/15 09:12, Krzysztof Kozlowski wrote:
> 2015-02-07 19:49 GMT+09:00 Inki Dae :
>> This patch sets display clock correctly.
>>
>> If Display clock isn't set correctly then you would find below messages
>> and Display controller doesn't work correctly since a patch[1]
>>
>>exynos-drm: No c
On 08/13/13 14:12, Chanho Park wrote:
The exynos4 platform is only dt-based since 3.10, we should convert driver data
and ids to dt-based parsing methods. The rotator driver has a limit table to get
size limit of input picture. Each SoCs has slightly different limit value
compared with any others
On 08/13/13 14:12, Chanho Park wrote:
> The exynos4 platform is only dt-based since 3.10, we should convert driver
> data
> and ids to dt-based parsing methods. The rotator driver has a limit table to
> get
> size limit of input picture. Each SoCs has slightly different limit value
> compared wit
Sylwester Nawrocki wrote:
>
> Hi Inki,
>
Hi Sylwester and Inki,
> On 01/31/2013 02:30 AM, Inki Dae wrote:
> >> -Original Message-
> >> From: Sylwester Nawrocki [mailto:sylvester.nawro...@gmail.com]
> >> Sent: Thursday, January 31, 2013 5:51 AM
> >> To: Inki Dae
> >> Cc: Sachin Kamat; lin
Florian Tobias Schandinat wrote:
>
> On 08/01/2012 02:28 AM, Kukjin Kim wrote:
> > Leela Krishna Amudala wrote:
> >>
> >> This patchset moves the contents of regs-fb-v4.h and regs-fb.h from
> arch
> >> side
> >> to include/video/samsung_fi
md_exynos5? It's time to use independent from SoC name
because we don't have any guarantee of same address on all of EXYNOS5 SoCs.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
__
T (26)
+#define VIDCON0_VIDOUT_MASK(0x3 <<
VIDCON0_VIDOUT_SHIFT)
Or just without XXX_SHIFT if the XXX_SHIFT is not used somewhere else,
+#define VIDCON0_VIDOUT_MASK(0x3 << 26)
[...]
Thanks.
Best regards,
Kgene.
--
ne FIMD_V8_VIDCON1 (0x20004)
>
>
> How about using soc_is_exynos5250()?
>
> +#define VIDTCON0 (soc_is_exynos5250() ? \
> + (0x20010) : (0x10))
>
> In this case, the FIMD driver doe
ung/include/plat/regs-fb-v4.h
rename arch/arm/plat-samsung/include/plat/regs-fb.h =>
include/video/samsung_fimd.h (74%)
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
___
les changed, 526 insertions(+), 0 deletions(-)
> create mode 100644 include/video/samsung_fimd.h
>
Firstly, please check my comment on your previous patches.
And I don't see following definitions are needed and used now. If some
definitions are not needed, they can be removed.
Thank
DTCON3 (0x2001C)
> +#define EXYNOS5_VIDCON1 (0x20004)
> --
> 1.7.0.4
All of EXYNOS5 SoCs including upcoming SoCs _really_ have same address like
above?
I don't think so. You need to consider its flexibility or some compatibility
when definitions are added.
Thanks.
os/mach-nuri.c
index ea785fc..90d8daa 100644
--- a/arch/arm/mach-exynos/mach-nuri.c
+++ b/arch/arm/mach-exynos/mach-nuri.c
@@ -29,6 +29,7 @@
#include
#include
+#include
#include
#include
#include
@@ -39,7 +40,6 @@
#include
#include
-#include
#include
#inclu
|2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
[...]
> --- a/drivers/video/s3c-fb.c
> +++ b/drivers/video/s3c-fb.c
> @@ -26,7 +26,7 @@
> #include
>
> #include
> -#include
> +#include
> #include
>
See my previous com
sung tree and just adds include/video/samsung_fimd.h. But I'm
not sure the added inclusion will be used in other file of drivers/video. If
so, I can provide some topic branch can be merged into Florian's tree.
Florian, how about?
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior
Leela Krishna Amudala wrote:
>
> Hello Kgene,
>
> On Wed, Aug 1, 2012 at 7:34 AM, Kukjin Kim wrote:
> > Leela Krishna Amudala wrote:
> >>
> >> The FIMD register headers are moved to include/video/
> >> hence, deleting these files from platform side
&
Florian Tobias Schandinat wrote:
>
> On 08/01/2012 02:28 AM, Kukjin Kim wrote:
> > Leela Krishna Amudala wrote:
> >>
> >> This patchset moves the contents of regs-fb-v4.h and regs-fb.h from
> arch
> >> side
> >> to include/video/samsung_fi
Sylwester Nawrocki wrote:
>
> Hi,
>
> On 08/01/2012 11:39 AM, Kukjin Kim wrote:
> > Leela Krishna Amudala wrote:
> >> On Wed, Aug 1, 2012 at 7:34 AM, Kukjin Kim
> wrote:
> >>> Leela Krishna Amudala wrote:
> >>>>
> >>>> The
+--
> 26 files changed, 165 insertions(+), 194 deletions(-)
> delete mode 100644 arch/arm/plat-samsung/include/plat/regs-fb-v4.h
> rename arch/arm/plat-samsung/include/plat/regs-fb.h =>
> include/video/samsung_fimd.h (73%)
Looks OK to me. Will apply into topic branch, 'v3.7
Sylwester Nawrocki wrote:
>
> On 02/01/2013 09:33 AM, Sachin Kamat wrote:
> > On 1 February 2013 06:57, Inki Dae wrote:
> >>
> >> For example,
> >> If compatible = "samsung,g2d-3.0" is added to exynos4210.dtsi, it'd be
> >> reasonable. But what if that compatible string is added to exynos4.dtsi?.
Kukjin Kim wrote:
>
Oops, I'm re-sending due to my e-mail client problem :-(
> Sylwester Nawrocki wrote:
> >
> > On 02/01/2013 09:33 AM, Sachin Kamat wrote:
> > > On 1 February 2013 06:57, Inki Dae wrote:
> > >>
> > >> For example,
> &g
On 06/18/13 14:09, Rahul Sharma wrote:
Hi Mr. Kukjin,
Kindly consider the following patches for review and integration.
(+ Mike)
Rahul, basically, looks good to me but I'm waiting for Mike's ack on
this series...
regards,
Rahul Sharma.
On Fri, Jun 14, 2013 at 3:39 PM, Arun Kumar K wrote
On 06/19/13 21:51, Rahul Sharma wrote:
This patch renames the combatible strings for hdmi, mixer, ddc
and hdmiphy. It follows the convention of using compatible string
which represent the SoC in which the IP was added for the first
time.
Signed-off-by: Rahul Sharma
Acked-by: Kukjin Kim
On 06/19/13 22:50, Kukjin Kim wrote:
On 06/19/13 21:51, Rahul Sharma wrote:
This patch renames the combatible strings for hdmi, mixer, ddc
and hdmiphy. It follows the convention of using compatible string
which represent the SoC in which the IP was added for the first
time.
Signed-off-by
On 06/19/13 13:04, Rahul Sharma wrote:
+ mike
Mike, I'm waiting for your reply on this. If you're OK, let me take this
series on top of exynos5420 stuff in samsung tree.
Of course, if any concerns, please let me know.
Thanks,
- Kukjin
On Tue, Jun 18, 2013 at 8:03 PM, Rahul Sharma wrote:
On 06/24/13 13:28, Rahul Sharma wrote:
[...]
I never got these patches. I'm not subscribed to devicetree-devel or
linux-samsung so I only got two replies to patch #0, but none of the
code. Can you or Rajul resend?
Sure mike.
Acked-by: Mike Turquette
Applied with Mike's ack.
Thanks,
- K
Leela Krishna Amudala wrote:
>
> Hello Kgene,
>
> On Wed, Aug 1, 2012 at 7:34 AM, Kukjin Kim wrote:
> > Leela Krishna Amudala wrote:
> >>
> >> The FIMD register headers are moved to include/video/
> >> hence, deleting these files from platform side
&
Florian Tobias Schandinat wrote:
>
> On 08/01/2012 02:28 AM, Kukjin Kim wrote:
> > Leela Krishna Amudala wrote:
> >>
> >> This patchset moves the contents of regs-fb-v4.h and regs-fb.h from
> arch
> >> side
> >> to include/video/samsung_fi
Sylwester Nawrocki wrote:
>
> Hi,
>
> On 08/01/2012 11:39 AM, Kukjin Kim wrote:
> > Leela Krishna Amudala wrote:
> >> On Wed, Aug 1, 2012 at 7:34 AM, Kukjin Kim
> wrote:
> >>> Leela Krishna Amudala wrote:
> >>>>
> >>>> The
+--
> 26 files changed, 165 insertions(+), 194 deletions(-)
> delete mode 100644 arch/arm/plat-samsung/include/plat/regs-fb-v4.h
> rename arch/arm/plat-samsung/include/plat/regs-fb.h =>
> include/video/samsung_fimd.h (73%)
Looks OK to me. Will apply into topic branch, 'v3.7
Florian Tobias Schandinat wrote:
>
> On 08/01/2012 02:28 AM, Kukjin Kim wrote:
> > Leela Krishna Amudala wrote:
> >>
> >> This patchset moves the contents of regs-fb-v4.h and regs-fb.h from
> arch
> >> side
> >> to include/video/samsung_fi
Inki Dae wrote:
>
> Applied.
>
> Thanks,
> Inki Dae
>
> 2014-03-17 12:28 GMT+09:00 Daniel Kurtz :
> > The following commit [0] fixed a use-after-free, but left the subdrv
> open
> > in the error path.
> >
> > [0] commit 6ca605f7c70895a35737435f17ae9cc5e36f1466
> > drm/exynos: Fix freeing issues
ung/include/plat/regs-fb-v4.h
rename arch/arm/plat-samsung/include/plat/regs-fb.h =>
include/video/samsung_fimd.h (74%)
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
DTCON3 (0x2001C)
> +#define EXYNOS5_VIDCON1 (0x20004)
> --
> 1.7.0.4
All of EXYNOS5 SoCs including upcoming SoCs _really_ have same address like
above?
I don't think so. You need to consider its flexibility or some compatibility
when definitions are added.
Thanks.
md_exynos5? It's time to use independent from SoC name
because we don't have any guarantee of same address on all of EXYNOS5 SoCs.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
T (26)
+#define VIDCON0_VIDOUT_MASK(0x3 <<
VIDCON0_VIDOUT_SHIFT)
Or just without XXX_SHIFT if the XXX_SHIFT is not used somewhere else,
+#define VIDCON0_VIDOUT_MASK(0x3 << 26)
[...]
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
ne FIMD_V8_VIDCON1 (0x20004)
>
>
> How about using soc_is_exynos5250()?
>
> +#define VIDTCON0 (soc_is_exynos5250() ? \
> + (0x20010) : (0x10))
>
> In this case, the FIMD driver does not need to change.
> Also, one binary is available.
>
I don't agree. Do you _really_ think the address will be fixed on other SoCs
including upcoming SoCs? I'd prefer to use the version or something for it.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
les changed, 526 insertions(+), 0 deletions(-)
> create mode 100644 include/video/samsung_fimd.h
>
Firstly, please check my comment on your previous patches.
And I don't see following definitions are needed and used now. If some
definitions are not needed, they can be removed.
Thank
os/mach-nuri.c
index ea785fc..90d8daa 100644
--- a/arch/arm/mach-exynos/mach-nuri.c
+++ b/arch/arm/mach-exynos/mach-nuri.c
@@ -29,6 +29,7 @@
#include
#include
+#include
#include
#include
#include
@@ -39,7 +40,6 @@
#include
#include
-#include
#include
#include
#include
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
|2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
[...]
> --- a/drivers/video/s3c-fb.c
> +++ b/drivers/video/s3c-fb.c
> @@ -26,7 +26,7 @@
> #include
>
> #include
> -#include
> +#include
> #include
>
See my previous com
sung tree and just adds include/video/samsung_fimd.h. But I'm
not sure the added inclusion will be used in other file of drivers/video. If
so, I can provide some topic branch can be merged into Florian's tree.
Florian, how about?
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior
On 10/28/13 06:42, Inki Dae wrote:
> Hi Tomasz,
>
> I have merged the re-factoring patch set from Sean Paul. Can you
> re-base your patch set at top of exynos-drm-next?
>
Basically, RFC is not patch for merge. So Tomasz needs to re-submit
after addressing comments from RFC.
Thanks,
Kukjin
Sylwester Nawrocki wrote:
>
> On 02/01/2013 09:33 AM, Sachin Kamat wrote:
> > On 1 February 2013 06:57, Inki Dae wrote:
> >>
> >> For example,
> >> If compatible = "samsung,g2d-3.0" is added to exynos4210.dtsi, it'd be
> >> reasonable. But what if that compatible string is added to exynos4.dtsi?.
Kukjin Kim wrote:
>
Oops, I'm re-sending due to my e-mail client problem :-(
> Sylwester Nawrocki wrote:
> >
> > On 02/01/2013 09:33 AM, Sachin Kamat wrote:
> > > On 1 February 2013 06:57, Inki Dae wrote:
> > >>
> > >> For example,
> &g
On 03/12/15 22:37, Andrzej Hajda wrote:
> Hi Kukjin,
>
Hi,
> This is resend of my patchset with added (Reviewed|Tested)-by tags and
> removed RFC
> prefix.
>
> Exynos chipsets since 542x have asynchronous bridges connecting different IPs.
> These bridges should be operational during power domai
On 01/03/15 15:50, Inki Dae wrote:
> On 2014ë
11ì 28ì¼ 20:39, Inki Dae wrote:
>> This patch adds fimd device node which is a display controller
>> for Exynos3250 Rinato board.
>
> Hi Kukjin,
>
> Please, ping~
>
> Thanks,
> Inki Dae
>
>>
>> Signed-off-by: Inki Dae
>> Acked-by: Kyungmin Par
Ajay Kumar wrote:
>
> Define videoports and use endpoints to describe the connection between
> the encoder, bridge and the panel, instead of using phandles.
>
> Signed-off-by: Ajay Kumar
> Acked-by: Inki Dae
> Tested-by: Rahul Sharma
> Tested-by: Javier Martinez Canillas
> Tested-by: Gustavo
Marek Szyprowski wrote:
>
> Hi all,
>
> This is yet another update on patchset, which enables HDMI support for
> Exynos based platforms.
>
> Beside DTS changes, this patchset adds parent domain support for Exynos
> PM domains and add support for 'hdmi' clock directly to Exynos DRM mixer
> driver
On 02/04/15 09:09, Joonyoung Shim wrote:
> Hi,
>
Hi,
> On 02/03/2015 12:58 PM, Kukjin Kim wrote:
>> Marek Szyprowski wrote:
>>>
>>> Hi all,
>>>
>>> This is yet another update on patchset, which enables HDMI support for
>>> Exynos bas
On 01/27/15 13:27, Ajay kumar wrote:
> Hi Kukjin,
>
Hi,
[...]
>>
>> I'm fine on the DT changes in this series, shall I take 13/14 and 14/14 in
>> Samsung tree?
> Yes, please take these patches.
>
Done, thanks.
- Kukjin
Sylwester Nawrocki wrote:
>
> Hi Inki,
>
Hi Sylwester and Inki,
> On 01/31/2013 02:30 AM, Inki Dae wrote:
> >> -Original Message-
> >> From: Sylwester Nawrocki [mailto:sylvester.nawrocki at gmail.com]
> >> Sent: Thursday, January 31, 2013 5:51 AM
> >> To: Inki Dae
> >> Cc: Sachin Kamat;
On 06/18/13 14:09, Rahul Sharma wrote:
> Hi Mr. Kukjin,
>
> Kindly consider the following patches for review and integration.
>
(+ Mike)
Rahul, basically, looks good to me but I'm waiting for Mike's ack on
this series...
> regards,
> Rahul Sharma.
>
> On Fri, Jun 14, 2013 at 3:39 PM, Arun Kumar
On 06/19/13 21:51, Rahul Sharma wrote:
> This patch renames the combatible strings for hdmi, mixer, ddc
> and hdmiphy. It follows the convention of using compatible string
> which represent the SoC in which the IP was added for the first
> time.
>
> Signed-off-by: Rahul Sharma
On 06/19/13 22:50, Kukjin Kim wrote:
> On 06/19/13 21:51, Rahul Sharma wrote:
>> This patch renames the combatible strings for hdmi, mixer, ddc
>> and hdmiphy. It follows the convention of using compatible string
>> which represent the SoC in which the IP was added
On 06/19/13 13:04, Rahul Sharma wrote:
> + mike
>
Mike, I'm waiting for your reply on this. If you're OK, let me take this
series on top of exynos5420 stuff in samsung tree.
Of course, if any concerns, please let me know.
Thanks,
- Kukjin
> On Tue, Jun 18, 2013 at 8:03 PM, Rahul Sharma
> wrot
On 06/24/13 13:28, Rahul Sharma wrote:
[...]
> I never got these patches. I'm not subscribed to devicetree-devel or
> linux-samsung so I only got two replies to patch #0, but none of the
> code. Can you or Rajul resend?
>
Sure mike.
>>>
>>> Acked-by: Mike Turquette
>>>
56 matches
Mail list logo
