Re: [RFC PATCH 1/3] drm/virtio: .release ops for virtgpu fence release

2023-08-16 Thread Kim, Dongwon
Hi, On 8/14/2023 9:18 PM, Dmitry Osipenko wrote: On 7/13/23 01:44, Dongwon Kim wrote: virtio_gpu_fence_release is added to free virtio-gpu-fence upon release of dma_fence. Cc: Gerd Hoffmann Cc: Vivek Kasireddy Signed-off-by: Dongwon Kim --- drivers/gpu/drm/virtio/virtgpu_fence.c | 8 +

Re: [RFC PATCH 1/3] drm/virtio: .release ops for virtgpu fence release

2023-08-16 Thread Kim, Dongwon
Hi, On 8/16/2023 10:05 PM, Dmitry Osipenko wrote: On 8/16/23 21:10, Kim, Dongwon wrote: Hi, On 8/14/2023 9:18 PM, Dmitry Osipenko wrote: On 7/13/23 01:44, Dongwon Kim wrote: virtio_gpu_fence_release is added to free virtio-gpu-fence upon release of dma_fence. Cc: Gerd Hoffmann Cc: Vivek

Re: [RFC PATCH 1/3] drm/virtio: .release ops for virtgpu fence release

2023-08-17 Thread Kim, Dongwon
On 8/16/2023 10:05 PM, Dmitry Osipenko wrote: On 8/16/23 21:10, Kim, Dongwon wrote: Hi, On 8/14/2023 9:18 PM, Dmitry Osipenko wrote: On 7/13/23 01:44, Dongwon Kim wrote: virtio_gpu_fence_release is added to free virtio-gpu-fence upon release of dma_fence. Cc: Gerd Hoffmann Cc: Vivek

Re: [RFC PATCH 3/3] drm/virtio: drm_gem_plane_helper_prepare_fb for obj synchronization

2023-08-20 Thread Kim, Dongwon
On 8/17/2023 7:33 PM, Dmitry Osipenko wrote: On 7/13/23 01:44, Dongwon Kim wrote: This helper is needed for framebuffer synchronization. Old framebuffer data is often displayed on the guest display without this helper. Cc: Gerd Hoffmann Cc: Vivek Kasireddy Signed-off-by: Dongwon Kim --- dr

Re: [RFC PATCH 2/3] drm/virtio: new fence for every plane update

2023-08-20 Thread Kim, Dongwon
On 8/17/2023 7:21 PM, Dmitry Osipenko wrote: ... +static struct +drm_plane_state *virtio_gpu_plane_duplicate_state(struct drm_plane *plane) +{ + struct virtio_gpu_plane_state *new; + + if (WARN_ON(!plane->state)) + return NULL; When plane->state can be NULL? Honestly

Re: [RFC PATCH 3/3] drm/virtio: drm_gem_plane_helper_prepare_fb for obj synchronization

2023-08-24 Thread Kim, Dongwon
On 8/23/2023 8:52 PM, Dmitry Osipenko wrote: On 8/20/23 23:58, Kim, Dongwon wrote: On 8/17/2023 7:33 PM, Dmitry Osipenko wrote: On 7/13/23 01:44, Dongwon Kim wrote: This helper is needed for framebuffer synchronization. Old framebuffer data is often displayed on the guest display without

Re: [RFC PATCH 3/3] drm/virtio: drm_gem_plane_helper_prepare_fb for obj synchronization

2023-09-05 Thread Kim, Dongwon
Hi Dmitry, On 8/31/2023 3:51 PM, Dmitry Osipenko wrote: On 8/24/23 20:58, Kim, Dongwon wrote: ... You can do fence-wait in the guest userspace/Mesa after blitting/drawing to the udmabuf. There is already synchronization between QEMU and virtio-gpu driver on the guest. Upon resource flush

RE: [RFC PATCH v2 1/1] drm/virtio: new fence for every plane update

2023-10-23 Thread Kim, Dongwon
> -Original Message- > From: Dmitry Osipenko > Sent: Monday, October 23, 2023 5:24 AM > To: Kim, Dongwon ; dri-devel@lists.freedesktop.org > Cc: kra...@redhat.com; Kasireddy, Vivek > Subject: Re: [RFC PATCH v2 1/1] drm/virtio: new fence for every plane update >

RE: [RFC PATCH 3/3] drm/virtio: drm_gem_plane_helper_prepare_fb for obj synchronization

2023-10-04 Thread Kim, Dongwon
nko Sent: Wednesday, October 4, 2023 4:32 PM To: Kim, Dongwon ; dri-devel@lists.freedesktop.org Cc: Kasireddy, Vivek ; kra...@redhat.com Subject: Re: [RFC PATCH 3/3] drm/virtio: drm_gem_plane_helper_prepare_fb for obj synchronization On 9/6/23 00:08, Kim, Dongwon wrote: > > I don't b

RE: [RFC PATCH v2 1/1] drm/virtio: new fence for every plane update

2023-11-13 Thread Kim, Dongwon
Hi Dmitry, > -Original Message- > From: Dmitry Osipenko > Sent: Monday, November 13, 2023 8:16 AM > To: Kim, Dongwon ; dri- > de...@lists.freedesktop.org > Cc: kra...@redhat.com; Kasireddy, Vivek > Subject: Re: [RFC PATCH v2 1/1] drm/virtio: new fence for every pl

RE: [RFC PATCH 0/2] Virtio-GPU suspend and resume

2025-05-05 Thread Kim, Dongwon
t; > suspend and resume scenarios without resource loss. > > Resetting GPU by QEMU on suspend sounds like a wrong behaviour. Are you > talking about upstream QEMU? > > Could you please point at the QEMU code where it handles virtio-gpu > suspend/resume? Don't see where i

RE: [RFC PATCH 0/2] Virtio-GPU suspend and resume

2025-05-06 Thread Kim, Dongwon
Hi Dmitry, > Subject: Re: [RFC PATCH 0/2] Virtio-GPU suspend and resume > > On 5/5/25 22:38, Kim, Dongwon wrote: > >> I tried to apply your kernel patches and then suspend/resume guest > >> kernel, it doesn't work: > >> > >> virtio_gpu_transfer_t

RE: [RFC PATCH 0/2] Virtio-GPU suspend and resume

2025-05-13 Thread Kim, Dongwon
Hi Dmitry, Can you share some details about your test setup? How do I replicate the problem you saw? And is "suspend and resume" working by default in your case? Thanks, DW > -Original Message----- > From: Kim, Dongwon > Sent: Tuesday, May 6, 2025 9:47 AM > To: Dmitr

RE: [RFC PATCH 0/2] Virtio-GPU suspend and resume

2025-05-14 Thread Kim, Dongwon
and resume > > On 5/13/25 22:23, Kim, Dongwon wrote: > > Hi Dmitry, > > > > Can you share some details about your test setup? > > How do I replicate the problem you saw? And is "suspend and resume" > working by default in your case? > > My testing se

RE: [RFC PATCH v2 0/2] Virtio-GPU suspend and resume

2025-06-17 Thread Kim, Dongwon
ertions(+), 7 deletions(-) > > Tested the patches, applied to v6.15.2. Suspend-resume works with v2, > display works on resume. > > Have you figured out why 10ms workaround is needed? [Kim, Dongwon] Unfortunately, I don't know why it fails without the delay. I wanted to narr

RE: [PATCH v3 2/2] drm/virtio: Implement save and restore for virtio_gpu_objects

2025-07-09 Thread Kim, Dongwon
anyway. So some sort of recreation seemed to be required from my point of view. > -Original Message- > From: Dmitry Osipenko > Sent: Wednesday, July 9, 2025 6:26 AM > To: Kim, Dongwon ; dri- > de...@lists.freedesktop.org > Cc: Kasireddy, Vivek > Subject: Re: [PAT

RE: [RFC PATCH v2 0/2] Virtio-GPU suspend and resume

2025-06-30 Thread Kim, Dongwon
Hi Dmitry, This is great. I will test this and include the fix in the patch. > -Original Message- > From: Dmitry Osipenko > Sent: Monday, June 30, 2025 7:00 PM > To: Kim, Dongwon ; dri- > de...@lists.freedesktop.org > Cc: Kasireddy, Vivek > Subject: Re: [RFC PAT