Hi Jackie,
On 28/07/2021 09:42, Jackie Liu wrote:
> From: Jackie Liu
>
> After the patch 78b6bb1d24db ("drm: rcar-du: crtc: Control CMM operations"),
> the cmm module must be included in the crtc. We cannot remove this
> configuration option separately. Therefore, simply linking them together
>
On 28/07/2021 10:34, Jackie Liu wrote:
> Hi Kieran.
>
> Thanks for replying to the email so quickly.
>
> 在 2021/7/28 下午4:58, Kieran Bingham 写道:
>> Hi Jackie,
>>
>> On 28/07/2021 09:42, Jackie Liu wrote:
>>> From: Jackie Liu
>>>
>>> Af
d/should change the
drivers/gpu/drm/rcar-du/rcar_cmm.h from:
#if IS_ENABLED(CONFIG_DRM_RCAR_CMM)
to
#if IS_REACHABLE(CONFIG_DRM_RCAR_CMM)
...
Seems odd that we might allow the module to be compiled at all if it
won't be reachable and that we can't enforce that at the KConfig level -
but a
Hi Jackie / Laurent,
On 28/07/2021 12:30, Laurent Pinchart wrote:
> On Wed, Jul 28, 2021 at 12:09:34PM +0100, Kieran Bingham wrote:
>> Hi Jackie,
>>
>> On 28/07/2021 10:57, Jackie Liu wrote:
>>> Hi Kieran.
>>>
>>> How about this.
>>>
>&
Hi Jackie
On 28/07/2021 13:21, Jackie Liu wrote:
> Hi Kieran.
>
> 在 2021/7/28 下午8:13, Kieran Bingham 写道:
>> Hi Jackie / Laurent,
>>
>> On 28/07/2021 12:30, Laurent Pinchart wrote:
>>> On Wed, Jul 28, 2021 at 12:09:34PM +0100, Kieran Bingham wrote:
>>&
series has been tested on Salvator-XS with the DU test suite
(http://git.ideasonboard.com/renesas/kms-tests.git). No failure or
change in behaviour has been noticed.
Kieran Bingham (8):
media: vsp1: drm: Split vsp1_du_setup_lif()
drm: rcar-du: Convert to the new VSP atomic API
media: vsp1: drm
Break vsp1_du_setup_lif() into components more suited to the DRM Atomic
API. The existing vsp1_du_setup_lif() API call is maintained as it is
still used from the DU.
Reviewed-by: Ulrich Hecht
Signed-off-by: Kieran Bingham
Signed-off-by: Laurent Pinchart
---
Changes since v3:
- Minor formatting
to skip it
when the pipeline is disabled. The hardware will be configured the next
time the pipeline gets enabled.
Reviewed-by: Ulrich Hecht
Signed-off-by: Laurent Pinchart
Signed-off-by: Kieran Bingham
---
drivers/media/platform/vsp1/vsp1_drm.c | 13 -
drivers/media/platform/vsp1
.
Reviewed-by: Ulrich Hecht
Signed-off-by: Kieran Bingham
Signed-off-by: Laurent Pinchart
---
Changes since v2:
- Add more documentation
- Keep rcar_du_crtc_get() and rcar_du_crtc_put()
- Renamed rcar_du_crtc_enable() to rcar_du_crtc_exit_standby() and
rcar_du_crtc_disable() to
users of the deprecated vsp1_du_setup_lif() which
can now be removed.
Reviewed-by: Ulrich Hecht
Signed-off-by: Kieran Bingham
Signed-off-by: Laurent Pinchart
---
Changes since v2:
- Minor formatting changes
Changes since v3:
- Minor formatting for checkpatch.pl --strict
- Fix inlinc typo in
The vsp1_du_setup_lif() function is deprecated, and the users have been
removed. Remove the implementation and the associated configuration
structure.
Reviewed-by: Ulrich Hecht
Signed-off-by: Kieran Bingham
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_drm.c | 46
Create a new private state object for the DU groups, and move the
initialisation of a group object to a new function rcar_du_group_init().
Reviewed-by: Ulrich Hecht
Signed-off-by: Kieran Bingham
Signed-off-by: Laurent Pinchart
---
Changes since v3:
- Rebase to v5.11
- Fix pointer passing for
ot;.
Reviewed-by: Ulrich Hecht
Signed-off-by: Kieran Bingham
Signed-off-by: Laurent Pinchart
---
Changes since v2:
- Deconstruct rcar_du_crtc_setup() completely
---
drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 89 +++---
drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 4 +-
drivers/gpu/
handler, and
based on global DU state.
Signed-off-by: Laurent Pinchart
Signed-off-by: Kieran Bingham
---
Changes since v3:
- s/DPAD1/DPAD0/
- s/VSP1D/VSPD1/
---
drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 3 +-
drivers/gpu/drm/rcar-du/rcar_du_drv.h | 1 -
drivers/gpu/drm/rcar-du/rcar_du_group.c
of its CRTCs has been powered through
rcar_du_crtc_atomic_exit_standby().
Reviewed-by: Ulrich Hecht
Signed-off-by: Kieran Bingham
Signed-off-by: Laurent Pinchart
---
Changes since v3:
- Shorted macro length, and added relevant documentation to its usage
and function.
Changes since v2
Refactoring of the group control code will soon require more iteration
over the available groups. Simplify this process by introducing a group
iteration helper.
Reviewed-by: Ulrich Hecht
Signed-off-by: Kieran Bingham
Signed-off-by: Laurent Pinchart
---
Changes since v2:
- Don't assign __
Hi Thomas,
On 23/11/2020 11:56, Thomas Zimmermann wrote:
> The new GEM object function drm_gem_cma_mmap() sets the VMA flags
> and offset as in the old implementation and immediately maps in the
> buffer's memory pages.
>
> Changing CMA helpers to use the GEM object function allows for the
> remo
Hi Thomas,
On 14/01/2021 13:26, Thomas Zimmermann wrote:
> Hi Kieran
>
> Am 14.01.21 um 13:51 schrieb Kieran Bingham:
>> Hi Thomas,
>>
>> On 23/11/2020 11:56, Thomas Zimmermann wrote:
>>> The new GEM object function drm_gem_cma_mmap() sets the VM
Break vsp1_du_setup_lif() into components more suited to the DRM Atomic
API. The existing vsp1_du_setup_lif() API call is maintained as it is
still used from the DU.
Reviewed-by: Ulrich Hecht
Signed-off-by: Kieran Bingham
Signed-off-by: Laurent Pinchart
---
Changes since v3:
- Minor formatting
n tested on Salvator-XS with the DU test suite
(http://git.ideasonboard.com/renesas/kms-tests.git). No failure or
change in behaviour has been noticed.
Kieran Bingham (8):
media: vsp1: drm: Split vsp1_du_setup_lif()
drm: rcar-du: Convert to the new VSP atomic API
media: vsp1: drm: Remo
users of the deprecated vsp1_du_setup_lif() which
can now be removed.
Reviewed-by: Ulrich Hecht
Signed-off-by: Kieran Bingham
Signed-off-by: Laurent Pinchart
---
Changes since v2:
- Minor formatting changes
Changes since v3:
- Minor formatting for checkpatch.pl --strict
drivers/gpu/drm/rcar-du
The vsp1_du_setup_lif() function is deprecated, and the users have been
removed. Remove the implementation and the associated configuration
structure.
Reviewed-by: Ulrich Hecht
Signed-off-by: Kieran Bingham
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_drm.c | 46
.
Reviewed-by: Ulrich Hecht
Signed-off-by: Kieran Bingham
Signed-off-by: Laurent Pinchart
---
Changes since v2:
- Add more documentation
- Keep rcar_du_crtc_get() and rcar_du_crtc_put()
- Renamed rcar_du_crtc_enable() to rcar_du_crtc_exit_standby() and
rcar_du_crtc_disable() to
Refactoring of the group control code will soon require more iteration
over the available groups. Simplify this process by introducing a group
iteration helper.
Reviewed-by: Ulrich Hecht
Signed-off-by: Kieran Bingham
Signed-off-by: Laurent Pinchart
---
Changes since v2:
- Don't assign __
of its CRTCs has been powered through
rcar_du_crtc_atomic_exit_standby().
Reviewed-by: Ulrich Hecht
Signed-off-by: Kieran Bingham
Signed-off-by: Laurent Pinchart
---
Changes since v3:
- Shorted macro length, and added relevant documentation to its usage
and function.
Changes since v2
handler, and
based on global DU state.
Reviewed-by: Kieran Bingham
Signed-off-by: Laurent Pinchart
Signed-off-by: Kieran Bingham
---
Changes since v3:
- s/DPAD1/DPAD0/
- s/VSP1D/VSPD1/
drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 3 +-
drivers/gpu/drm/rcar-du/rcar_du_drv.h | 1 -
drivers/gpu
to skip it
when the pipeline is disabled. The hardware will be configured the next
time the pipeline gets enabled.
Reviewed-by: Ulrich Hecht
Reviewed-by: Kieran Bingham
Signed-off-by: Laurent Pinchart
Signed-off-by: Kieran Bingham
---
drivers/media/platform/vsp1/vsp1_drm.c | 13
Create a new private state object for the DU groups, and move the
initialisation of a group object to a new function rcar_du_group_init().
Reviewed-by: Ulrich Hecht
Signed-off-by: Kieran Bingham
Signed-off-by: Laurent Pinchart
---
Changes since v3:
- Rebase to v5.11
- Fix pointer passing for
ot;.
Reviewed-by: Ulrich Hecht
Signed-off-by: Kieran Bingham
Signed-off-by: Laurent Pinchart
---
Changes since v2:
- Deconstruct rcar_du_crtc_setup() completely
drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 89 +++---
drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 4 +-
drivers/gpu/
handle mmap specially in the RCar-DU driver, so I
>>>> wonder if this issue has hit anyone else as well?
>>>>
>>>> Any ideas of a repair without a revert ? Or do we just need to submit a
>>>> revert?
>>>
>>> I think we might not be setting the
n the DRM core code
> to the GEM object's value. Drivers with different needs can override
> this in their mmap callback.
>
> Signed-off-by: Thomas Zimmermann
> Fixes: f5ca8eb6f9bd ("drm/cma-helper: Implement mmap as GEM CMA object
> functions")
> Repor
On 15/01/2021 09:28, Thomas Zimmermann wrote:
> Hi
>
> Am 15.01.21 um 10:17 schrieb Kieran Bingham:
>> Hi Thomas,
>>
>> On 15/01/2021 08:39, Thomas Zimmermann wrote:
>>> The GEM mmap code relies on the GEM object's mmap callback to set the
>>> VMA
("drm/cma-helper: Implement mmap as GEM CMA object
> functions")
> Reported-by: Kieran Bingham
> Tested-by: Kieran Bingham
Re-tested just fine this side ;-)
- https://paste.ubuntu.com/p/Jgz6xMKNJX/
Thanks
Kieran
> Cc: Maxime Ripard
> Cc: Maarten Lankhorst
Hi Laurent,
On 13/01/2021 22:45, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Wed, Jan 13, 2021 at 05:02:53PM +, Kieran Bingham wrote:
>> The encoder allocation was converted to a DRM managed resource at the
>> same time as t
Laurent,
On 01/03/2021 10:30, Geert Uytterhoeven wrote:
> On Thu, Jan 14, 2021 at 11:00 AM Geert Uytterhoeven
> wrote:
>> On Wed, Jan 13, 2021 at 6:02 PM Kieran Bingham
>> wrote:
>>> The encoder allocation was converted to a DRM managed resource at the
>>>
On 01/03/2021 18:52, Greg Kroah-Hartman wrote:
> On Mon, Mar 01, 2021 at 11:11:26PM +0530, Naresh Kamboju wrote:
>> On stable rc 5.11 the x86_64 build failed due to below errors/warnings.
>>
>> drivers/gpu/drm/rcar-du/rcar_du_kms.c: In function 'rcar_du_modeset_cleanup':
>> drivers/gpu/drm/rcar-du/
gt; Reported-by: Hulk Robot
Fixes: 8de707aeb452 ("drm: rcar-du: kms: Initialize CMM instances")
Reviewed-by: Kieran Bingham
> ---
> drivers/gpu/drm/rcar-du/rcar_du_kms.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/rc
Hi Doug,
Quoting Doug Anderson (2022-03-07 23:21:28)
> Hi,
>
> On Mon, Mar 7, 2022 at 10:00 AM Kieran Bingham
> wrote:
> >
> > From: Laurent Pinchart
> >
> > Now that the driver supports the connector-related bridge operations,
> > make the connecto
Quoting Doug Anderson (2022-03-07 23:22:17)
> Hi,
>
> On Mon, Mar 7, 2022 at 10:00 AM Kieran Bingham
> wrote:
> >
> > @@ -1264,6 +1321,14 @@ static int ti_sn_bridge_probe(struct
> > auxiliary_device *adev,
> >
Hi Sam,
Quoting Sam Ravnborg (2022-02-06 15:44:02)
> From: Rob Clark
>
> Slightly awkward to fish out the display_info when we aren't creating
> own connector. But I don't see an obvious better way.
>
> v3:
> - Rebased and dropped the ti_sn_bridge_get_bpp() patch
>as this was solved in a
Quoting Doug Anderson (2022-03-07 23:22:00)
> Hi,
>
> On Mon, Mar 7, 2022 at 10:00 AM Kieran Bingham
> wrote:
> >
> > From: Laurent Pinchart
> >
> > Despite the SN65DSI86 being an eDP bridge, on some systems its output is
> > routed to a DisplayPort c
Hi Doug,
Quoting Doug Anderson (2022-03-07 19:52:08)
> Hi,
>
> On Mon, Mar 7, 2022 at 10:00 AM Kieran Bingham
> wrote:
> >
> > From: Laurent Pinchart
> >
> > Implement the bridge connector-related .get_edid() operation, and report
> > the related br
Quoting Kieran Bingham (2022-03-07 17:59:54)
> From: Laurent Pinchart
>
> Despite the SN65DSI86 being an eDP bridge, on some systems its output is
> routed to a DisplayPort connector. Enable DisplayPort mode when the next
> component in the display pipeline is detected a
Quoting Kieran Bingham (2022-03-10 14:04:09)
> Quoting Kieran Bingham (2022-03-07 17:59:54)
> > From: Laurent Pinchart
> >
> > Despite the SN65DSI86 being an eDP bridge, on some systems its output is
> > routed to a DisplayPort connector. Enable DisplayPort mode whe
g/all/20220206154405.124-1-...@ravnborg.org/
[1] git://git.kernel.org/pub/scm/linux/kernel/git/kbingham/rcar.git
branch: kbingham/drm-misc/next/sn65dsi86/hpd
Kieran Bingham (1):
drm/bridge: ti-sn65dsi86: Support hotplug detection
Laurent Pinchart (2):
drm/bridge: ti-sn65dsi86: Support DisplayPort
: Laurent Pinchart
Reworked to set bridge type based on the next bridge/connector.
Signed-off-by: Kieran Bingham
--
Changes since v1/RFC:
- Rebased on top of "drm/bridge: ti-sn65dsi86: switch to
devm_drm_of_get_bridge"
- eDP/DP mode determined from the next bridge connector type
legacy and new users should use
DRM_BRIDGE_ATTACH_NO_CONNECTOR.
Signed-off-by: Laurent Pinchart
Signed-off-by: Kieran Bingham
---
Changes since v1:
- Document the no_hpd field
- Rely on the SN_HPD_DISABLE_REG default value in the HPD case
- Add a TODO comment regarding IRQ support
[Kieran]
- Fix
From: Laurent Pinchart
Implement the bridge connector-related .get_edid() operation, and report
the related bridge capabilities and type.
Signed-off-by: Laurent Pinchart
Signed-off-by: Kieran Bingham
---
Changes since v1:
- The connector .get_modes() operation doesn't rely on EDID an
Quoting Kieran Bingham (2022-03-10 15:22:27)
> When the SN65DSI86 is used in DisplayPort mode, its output is likely
> routed to a DisplayPort connector, which can benefit from hotplug
> detection. Support it in such cases, with polling mode only for now.
>
> The implementation is
Hi Laurent
Quoting Laurent Pinchart (2022-03-10 16:42:48)
> Hi Kieran,
>
> Thank you for the patch.
>
> On Thu, Mar 10, 2022 at 03:22:27PM +, Kieran Bingham wrote:
> > When the SN65DSI86 is used in DisplayPort mode, its output is likely
> > routed to a Displ
Hi Doug, Sam,
Quoting Doug Anderson (2022-03-10 23:21:38)
> Hi,
>
> On Thu, Mar 10, 2022 at 7:22 AM Kieran Bingham
> wrote:
> >
> > Implement support for non eDP connectors on the TI-SN65DSI86 bridge, and
> > provide IRQ based hotplug detect to identify whe
Hi Doug,
Quoting Doug Anderson (2022-03-10 23:10:12)
> Hi,
>
> On Thu, Mar 10, 2022 at 7:22 AM Kieran Bingham
> wrote:
> >
> > @@ -1135,6 +1161,36 @@ static void ti_sn_bridge_atomic_post_disable(struct
> > drm_bridge *bridge,
> > pm_runtime_put_sync
Hi Doug,
Quoting Doug Anderson (2022-03-10 23:10:20)
> Hi,
>
> On Thu, Mar 10, 2022 at 7:22 AM Kieran Bingham
> wrote:
> >
> > From: Laurent Pinchart
> >
> > Implement the bridge connector-related .get_edid() operation, and report
> > the related br
ngham/rcar.git
branch: kbingham/drm-misc/next/sn65dsi86/hpd
Kieran Bingham (1):
drm/bridge: ti-sn65dsi86: Support hotplug detection
Laurent Pinchart (2):
drm/bridge: ti-sn65dsi86: Support DisplayPort (non-eDP) mode
drm/bridge: ti-sn65dsi86: Implement bridge connector operations
drivers/gp
: Laurent Pinchart
Reworked to set bridge type based on the next bridge/connector.
Signed-off-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Reviewed-by: Douglas Anderson
--
Changes since v1/RFC:
- Rebased on top of "drm/bridge: ti-sn65dsi86: switch to
devm_drm_of_get_bridge"
From: Laurent Pinchart
Implement the bridge connector-related .get_edid() operation, and report
the related bridge capabilities and type.
Signed-off-by: Laurent Pinchart
Signed-off-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
---
Changes since v1:
- The connector .get_modes() operation
operations are legacy and new users should use
DRM_BRIDGE_ATTACH_NO_CONNECTOR.
Signed-off-by: Laurent Pinchart
Signed-off-by: Kieran Bingham
---
Changes since v1:
- Document the no_hpd field
- Rely on the SN_HPD_DISABLE_REG default value in the HPD case
- Add a TODO comment regarding IRQ support
Quoting Doug Anderson (2022-03-23 21:47:17)
> Hi,
>
> On Thu, Mar 17, 2022 at 6:13 AM Kieran Bingham
> wrote:
> >
> > @@ -1241,9 +1350,32 @@ static int ti_sn_bridge_probe(struct
> > auxiliary_device *adev,
> > pdata->
sync_porch += 25;
> +
> + if (mode->htotal - mode->hsync_start < min_sync_porch)
> return MODE_HBLANK_NARROW;
Is the '19' in the hdse offset, this min_sync_port - 1 for position
correction? It looks something like that. And the rest seems ok.
With or without the additional optional comment suggestion above:
Reviewed-by: Kieran Bingham
>
> vbp = (mode->vtotal - mode->vsync_end) / (interlaced ? 2 : 1);
>
> base-commit: c18c889bb5e014e144716044991112f16833
> prerequisite-patch-id: dc9121a1b85ea05bf3eae2b0ac2168d47101ee87
> --
> Regards,
>
> Laurent Pinchart
>
to the display controller - as it's a factor
of the bridge?
On Falcon-V3U with HPD additions to SN65DSI86:
Tested-by: Kieran Bingham
> > In result, once encoders are switched to bridge_connector,
> > bridge-detected HPD stops working.
> >
> > This patch adds a ca
Quoting Laurent Pinchart (2022-02-23 16:25:28)
> Hello,
>
> On Wed, Feb 23, 2022 at 04:17:22PM +0000, Kieran Bingham wrote:
> > Quoting Laurent Pinchart (2021-12-29 23:44:29)
> > > On Sat, Dec 25, 2021 at 09:31:51AM +0300, Nikita Yushchenko wrote:
> > > > Hotpl
Hi All,
I'm working to respin the remainder of these patches, now that I have
IRQ based HPD working on the SN65DSI86, and the (non-eDP) mode is used
for Renesas R-Car boards.
Quoting Doug Anderson (2021-06-24 00:51:12)
> Hi,
>
> On Wed, Jun 23, 2021 at 4:26 PM Laurent Pinchart
> wrote:
> >
> >
Hi Doug, Laurent,
Quoting Laurent Pinchart (2021-06-23 14:59:00)
> Hi Doug,
>
> On Wed, Mar 24, 2021 at 03:47:07PM -0700, Doug Anderson wrote:
> > On Sun, Mar 21, 2021 at 8:02 PM Laurent Pinchart wrote:
> > >
> > > Despite the SN65DSI86 being an eDP bridge, on some systems its output is
> > > rou
Hi José
Quoting José Expósito (2022-02-28 18:39:54)
> The function "drm_of_find_panel_or_bridge" has been deprecated in
> favor of "devm_drm_of_get_bridge".
>
> Switch to the new function and reduce boilerplate.
>
> Signed-off-by: José Expósito
> ---
> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 8
Quoting Laurent Pinchart (2022-02-21 17:13:39)
> The VSP1 sink selection through register DEFR8 is only available on Gen2
> hardware. Skip it on Gen3.
aha, interesting, and I see how this leads into the second patch.
Looks fine on it's own too though:
Reviewed-by: Kieran Bingham
so I think this is cleaner all round.
Reviewed-by: Kieran Bingham
>
> Signed-off-by: Laurent Pinchart
> ---
> drivers/gpu/drm/rcar-du/rcar_du_plane.c | 6 ++
> drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 9 -
> 2 files changed, 6 insertions(+), 9 deletions(-)
>
>
Quoting José Expósito (2022-03-03 18:37:20)
> On Mon, Feb 28, 2022 at 11:24:36PM +0000, Kieran Bingham wrote:
> > Hi José
> >
> > Quoting José Expósito (2022-02-28 18:39:54)
> > > The function "drm_of_find_panel_or_bridge" has been deprecated i
Hi José
Quoting Kieran Bingham (2022-03-03 21:59:26)
> Quoting José Expósito (2022-03-03 18:37:20)
> > On Mon, Feb 28, 2022 at 11:24:36PM +0000, Kieran Bingham wrote:
> > > Hi José
> > >
> > > Quoting José Expósito (2022-02-28 18:39:54)
> > > > The
Hi Doug,
Quoting Doug Anderson (2022-02-23 18:25:13)
> Hi,
>
> On Wed, Feb 23, 2022 at 9:43 AM Kieran Bingham
> wrote:
> >
> > Hi All,
> >
> > I'm working to respin the remainder of these patches, now that I have
> > IRQ based HPD working on the SN
1225063151.2110878-1-nikita.yo...@cogentembedded.com/
Kieran Bingham (1):
drm/bridge: ti-sn65dsi86: Support hotplug detection
Laurent Pinchart (3):
drm/bridge: ti-sn65dsi86: Implement bridge connector operations
drm/bridge: ti-sn65dsi86: Make connector creation optional
drm/bridge: ti-sn65dsi86
: Laurent Pinchart
Reworked to set bridge type based on the next bridge/connector.
Signed-off-by: Kieran Bingham
--
Changes since v1/RFC:
- Rebased on top of "drm/bridge: ti-sn65dsi86: switch to
devm_drm_of_get_bridge"
- eDP/DP mode determined from the next bridge connector type.
From: Laurent Pinchart
Now that the driver supports the connector-related bridge operations,
make the connector creation optional. This enables usage of the
sn65dsi86 with the DRM bridge connector helper.
Signed-off-by: Laurent Pinchart
Signed-off-by: Kieran Bingham
---
Changes since v1
From: Laurent Pinchart
Implement the bridge connector-related .get_edid() operation, and report
the related bridge capabilities and type.
Signed-off-by: Laurent Pinchart
Reviewed-by: Stephen Boyd
Reviewed-by: Douglas Anderson
Signed-off-by: Kieran Bingham
---
Changes since v1:
- The
legacy and new users should use
DRM_BRIDGE_ATTACH_NO_CONNECTOR.
Signed-off-by: Laurent Pinchart
Signed-off-by: Kieran Bingham
---
Changes since v1:
- Document the no_hpd field
- Rely on the SN_HPD_DISABLE_REG default value in the HPD case
- Add a TODO comment regarding IRQ support
[Kieran]
- Fix
On 31/08/2021 14:57, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing
Reviewed-by: Kieran Bingham
> ---
> drivers/gpu/drm/shmobil
On 31/08/2021 08:54, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing
Reviewed-by: Kieran Bingham
> ---
> drivers/gpu/drm/rcar
20210622232024.3215248-2-kieran.bing...@ideasonboard.com/
But I can always rebase that later otherwise.
Reviewed-by: Kieran Bingham
> Signed-off-by: Laurent Pinchart
> ---
> drivers/gpu/drm/rcar-du/rcar_du_crtc.h| 11 ---
> drivers/gpu/drm/rcar-du/rcar_du_drv.c |
Hi Geert,
On 23/06/2021 13:53, Geert Uytterhoeven wrote:
> Hi Kieran,
>
> On Wed, Jun 23, 2021 at 1:11 AM Kieran Bingham
> wrote:
>> From: Kieran Bingham
>>
>> Extend the Renesas DU display bindings to support the r8a779a0 V3U.
>>
>> Signed-off-by:
Hi Laurent,
On 01/09/2021 23:13, Laurent Pinchart wrote:
> Hi Kieran,
>
> On Wed, Sep 01, 2021 at 11:01:11PM +0100, Kieran Bingham wrote:
>> On 23/06/2021 13:53, Geert Uytterhoeven wrote:
>>> On Wed, Jun 23, 2021 at 1:11 AM Kieran Bingham wrote:
>>>> From:
From: Kieran Bingham
Extend the Renesas DU display bindings to support the r8a779a0 V3U.
Reviewed-by: Laurent Pinchart
Signed-off-by: Kieran Bingham
---
v2:
- Collected Laurent's tag
- Remove clock-names requirement
- Specify only a single clock
.../bindings/display/renesas,du
From: Kieran Bingham
Sort the DU outputs alphabetically, with the exception of the final
entry which is there as a sentinal.
Reviewed-by: Laurent Pinchart
Signed-off-by: Kieran Bingham
---
v2:
- Collect tag
drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 4 ++--
1 file changed, 2 insertions
Pinchart
Signed-off-by: Kieran Bingham
---
v2:
- Remove parenthesis
drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
index ea7e39d03545..a0f837e8243a
From: Kieran Bingham
Extend the rcar_du_device_info structure and rcar_du_output enum to
support DSI outputs and utilise these additions to provide support for
the R8A779A0 V3U platform.
While the DIDSR register field is now named "DSI/CSI-2-TX-IF0 Dot Clock
Select" the existing defin
-by: Kieran Bingham
---
v2:
- New patch
drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 4 +--
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 48 +-
drivers/gpu/drm/rcar-du/rcar_du_drv.h | 9 ++---
3 files changed, 39 insertions(+), 22 deletions(-)
diff --git a/drivers/gpu/drm/rcar
The DIDSR fields named LDCS were incorrectly defined as LCDS.
Both the Gen2 and Gen3 documentation refer to the fields as the "LVDS
Dot Clock Select".
Correct the definitions.
Signed-off-by: Kieran Bingham
---
v2:
- New patch
drivers/gpu/drm/rcar-du/rcar_du_group.c | 4 ++--
drive
goto error;
> + }
> +
> + cma_obj->paddr = 0;
> + cma_obj->sgt = sgt;
> +
> + return gem_obj;
> +
> +error:
> + kfree(cma_obj);
> + return ERR_PTR(ret);
Almost seems overkill to handle this here, rather than inline in the
failure of d
From: Kieran Bingham
Extend the Renesas DU display bindings to support the r8a779a0 V3U.
Reviewed-by: Laurent Pinchart
Signed-off-by: Kieran Bingham
---
v2:
- Collected Laurent's tag
- Remove clock-names requirement
- Specify only a single clock
v3:
- Use clocknames: 'du.0&#
From: Kieran Bingham
Sort the DU outputs alphabetically, with the exception of the final
entry which is there as a sentinal.
Reviewed-by: Laurent Pinchart
Signed-off-by: Kieran Bingham
---
v2:
- Collect tag
drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 4 ++--
1 file changed, 2 insertions
: Laurent Pinchart
Signed-off-by: Kieran Bingham
---
v2:
- New patch
v3:
- Collect tag
drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 4 +--
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 48 +-
drivers/gpu/drm/rcar-du/rcar_du_drv.h | 9 ++---
3 files changed, 39 insertions
From: Kieran Bingham
Extend the rcar_du_device_info structure and rcar_du_output enum to
support DSI outputs and utilise these additions to provide support for
the R8A779A0 V3U platform.
While the DIDSR register field is now named "DSI/CSI-2-TX-IF0 Dot Clock
Select" the existing defin
The DIDSR fields named LDCS were incorrectly defined as LCDS.
Both the Gen2 and Gen3 documentation refer to the fields as the "LVDS
Dot Clock Select".
Correct the definitions.
Reviewed-by: Laurent Pinchart
Signed-off-by: Kieran Bingham
---
v2:
- New patch
v3:
- Collect tag
d
Pinchart
Signed-off-by: Kieran Bingham
---
v2:
- Remove parenthesis
drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
index ea7e39d03545..a0f837e8243a
On 23/09/2021 00:59, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Thu, Sep 23, 2021 at 12:47:26AM +0100, Kieran Bingham wrote:
>> From: Kieran Bingham
>>
>> Extend the rcar_du_device_info structure and rcar_du_output enum to
&
From: Kieran Bingham
Extend the Renesas DU display bindings to support the r8a779a0 V3U.
Reviewed-by: Laurent Pinchart
Reviewed-by: Geert Uytterhoeven
Signed-off-by: Kieran Bingham
---
v2:
- Collected Laurent's tag
- Remove clock-names requirement
- Specify only a single cloc
ch I was going to
tackle this same issue ...
But you've beaten me to it ;-)
Reviewed-by: Kieran Bingham
>
> arch/arm64/boot/dts/renesas/r8a779a0-falcon.dt.yaml: sn65dsi86@2c:
> reg:0:0: 45 was expected
> ---
> .../devicetree/bindings/display/bridge/ti,sn65dsi86.yaml
gt; case, and also skip creation of the DRM encoder as there's no point in
> an encoder without a connector.
>
> Fixes: e9e056949c92 ("drm: rcar-du: lvds: Convert to DRM panel bridge helper")
> Reported-by: Geert Uytterhoeven
> Signed-off-by: Laurent Pinchart
P
gt;>>>
> >>>>> ==><=======
> >>>>> diff --git a/drivers/gpu/drm/drm_bridge.c
> >>>>> b/drivers/gpu/drm/drm_bridge.c index c96847fc0ebc..7019acd37716
> >>>>> 100644
> >>>>&
Quoting Neil Armstrong (2022-01-17 13:53:47)
> On 17/01/2022 11:58, Kieran Bingham wrote:
> > Hi Neil,
> > This fixes the issue for me here on an H3 Salvator-XS.
> >
> > Could you add...
> >
> > Bisected-by: Kieran Bingham
> > Tested-by: Kieran B
ot;clk: renesas:
> Remove R-Car Gen2 legacy DT clock support"), in v5.5, which removes
> support for legacy bindings for clocks. The LBDS compatibility code is
s/LBDS/LVDS/
> thus not needed anymore. Drop it.
Oh, I'm almost sad to see such exotic code go...
But code gone is less
terface, which we won't have
... so it seems reasonable to accept that this whole driver can be
disabled in that instance.
Reading your mail that brought this thread up in my inbox, I think
you've already hit merge on this, so don't worry about adding a tag in
that instance, b
1 - 100 of 654 matches
Mail list logo
