Re: [PATCH v2] drm/amdgpu: add ring timeout information in devcoredump

2024-03-05 Thread Khatri, Sunil
On 3/5/2024 6:40 PM, Christian König wrote: Am 05.03.24 um 12:58 schrieb Sunil Khatri: Add ring timeout related information in the amdgpu devcoredump file for debugging purposes. During the gpu recovery process the registered call is triggered and add the debug information in data file create

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
On 3/6/2024 3:37 PM, Christian König wrote: Am 06.03.24 um 10:04 schrieb Sunil Khatri: When an  page fault interrupt is raised there is a lot more information that is useful for developers to analyse the pagefault. Well actually those information are not that interesting  because they are h

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
On 3/6/2024 6:12 PM, Christian König wrote: Am 06.03.24 um 11:40 schrieb Khatri, Sunil: On 3/6/2024 3:37 PM, Christian König wrote: Am 06.03.24 um 10:04 schrieb Sunil Khatri: When an  page fault interrupt is raised there is a lot more information that is useful for developers to analyse

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
On 3/6/2024 8:34 PM, Christian König wrote: Am 06.03.24 um 15:29 schrieb Alex Deucher: On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote: On 3/6/2024 6:12 PM, Christian König wrote: Am 06.03.24 um 11:40 schrieb Khatri, Sunil: On 3/6/2024 3:37 PM, Christian König wrote: Am 06.03.24 um

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
On 3/6/2024 9:19 PM, Alex Deucher wrote: On Wed, Mar 6, 2024 at 10:32 AM Alex Deucher wrote: On Wed, Mar 6, 2024 at 10:13 AM Khatri, Sunil wrote: On 3/6/2024 8:34 PM, Christian König wrote: Am 06.03.24 um 15:29 schrieb Alex Deucher: On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
On 3/6/2024 9:07 PM, Christian König wrote: Am 06.03.24 um 16:13 schrieb Khatri, Sunil: On 3/6/2024 8:34 PM, Christian König wrote: Am 06.03.24 um 15:29 schrieb Alex Deucher: On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote: On 3/6/2024 6:12 PM, Christian König wrote: Am 06.03.24 um

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
On 3/6/2024 9:45 PM, Alex Deucher wrote: On Wed, Mar 6, 2024 at 11:06 AM Khatri, Sunil wrote: On 3/6/2024 9:07 PM, Christian König wrote: Am 06.03.24 um 16:13 schrieb Khatri, Sunil: On 3/6/2024 8:34 PM, Christian König wrote: Am 06.03.24 um 15:29 schrieb Alex Deucher: On Wed, Mar 6

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
On 3/6/2024 9:49 PM, Christian König wrote: Am 06.03.24 um 17:06 schrieb Khatri, Sunil: On 3/6/2024 9:07 PM, Christian König wrote: Am 06.03.24 um 16:13 schrieb Khatri, Sunil: On 3/6/2024 8:34 PM, Christian König wrote: Am 06.03.24 um 15:29 schrieb Alex Deucher: On Wed, Mar 6, 2024 at 8

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
On 3/6/2024 9:59 PM, Alex Deucher wrote: On Wed, Mar 6, 2024 at 11:21 AM Khatri, Sunil wrote: On 3/6/2024 9:45 PM, Alex Deucher wrote: On Wed, Mar 6, 2024 at 11:06 AM Khatri, Sunil wrote: On 3/6/2024 9:07 PM, Christian König wrote: Am 06.03.24 um 16:13 schrieb Khatri, Sunil: On 3/6

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
, we just need to provide faulting address, Fault status register with gpu family to decode the fault along with process information. Regards Sunil Khatri On 3/6/2024 9:56 PM, Khatri, Sunil wrote: On 3/6/2024 9:49 PM, Christian König wrote: Am 06.03.24 um 17:06 schrieb Khatri, Sunil: On 3/6

RE: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
...@vger.kernel.org; Joshi, Mukul ; Paneer Selvam, Arunpravin ; Khatri, Sunil Subject: [PATCH] drm/amdgpu: cache in more vm fault information When an page fault interrupt is raised there is a lot more information that is useful for developers to analyse the pagefault. Add all such information

Re: [PATCH] drm/amdgpu: add vm fault information to devcoredump

2024-03-06 Thread Khatri, Sunil
...@vger.kernel.org; Joshi, Mukul ; Paneer Selvam, Arunpravin ; Khatri, Sunil Subject: [PATCH] drm/amdgpu: add vm fault information to devcoredump Add page fault information to the devcoredump. Output of devcoredump: AMDGPU Device Coredump version: 1 kernel: 6.7.0-amd-staging-drm-next module

Re: [PATCH] drm/amdgpu: add vm fault information to devcoredump

2024-03-07 Thread Khatri, Sunil
On 3/7/2024 1:47 PM, Christian König wrote: Am 06.03.24 um 19:19 schrieb Sunil Khatri: Add page fault information to the devcoredump. Output of devcoredump: AMDGPU Device Coredump version: 1 kernel: 6.7.0-amd-staging-drm-next module: amdgpu time: 29.725011811 process_name: soft_reco

Re: [PATCH] drm/amdgpu: add vm fault information to devcoredump

2024-03-07 Thread Khatri, Sunil
On 3/7/2024 6:10 PM, Christian König wrote: Am 07.03.24 um 09:37 schrieb Khatri, Sunil: On 3/7/2024 1:47 PM, Christian König wrote: Am 06.03.24 um 19:19 schrieb Sunil Khatri: Add page fault information to the devcoredump. Output of devcoredump: AMDGPU Device Coredump version: 1

Re: [PATCH 2/2] drm/amdgpu: add vm fault information to devcoredump

2024-03-07 Thread Khatri, Sunil
On 3/8/2024 12:44 AM, Alex Deucher wrote: On Thu, Mar 7, 2024 at 12:00 PM Sunil Khatri wrote: Add page fault information to the devcoredump. Output of devcoredump: AMDGPU Device Coredump version: 1 kernel: 6.7.0-amd-staging-drm-next module: amdgpu time: 29.725011811 process_name: s

Re: [PATCH v2 2/2] drm/amdgpu: add vm fault information to devcoredump

2024-03-08 Thread Khatri, Sunil
On 3/8/2024 2:39 PM, Christian König wrote: Am 07.03.24 um 21:50 schrieb Sunil Khatri: Add page fault information to the devcoredump. Output of devcoredump: AMDGPU Device Coredump version: 1 kernel: 6.7.0-amd-staging-drm-next module: amdgpu time: 29.725011811 process_name: soft_reco

RE: [PATCH] drm/amdgpu: add all ringbuffer information in devcoredump

2024-03-11 Thread Khatri, Sunil
-ker...@vger.kernel.org; Khatri, Sunil Subject: [PATCH] drm/amdgpu: add all ringbuffer information in devcoredump Add ringbuffer information such as: rptr, wptr, ring name, ring size and also the ring contents for each ring on a gpu reset. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd

Re: [PATCH] drm/amdgpu: add ring buffer information in devcoredump

2024-03-11 Thread Khatri, Sunil
On 3/11/2024 7:29 PM, Christian König wrote: Am 11.03.24 um 13:22 schrieb Sunil Khatri: Add relevant ringbuffer information such as rptr, wptr, ring name, ring size and also the ring contents for each ring on a gpu reset. Signed-off-by: Sunil Khatri ---   drivers/gpu/drm/amd/amdgpu/amdgpu_

Re: [PATCH 1/2] drm/amdgpu: add the IP information of the soc

2024-03-13 Thread Khatri, Sunil
c: amd-...@lists.freedesktop.org ; dri-devel@lists.freedesktop.org ; linux-ker...@vger.kernel.org ; Khatri, Sunil Subject: [PATCH 1/2] drm/amdgpu: add the IP information of the soc Add all the IP's information on a SOC to the devcoredump. Signed-off-by: Sunil Khatri --- drivers/gpu/drm

Re: [PATCH 1/2] drm/amdgpu: add the IP information of the soc

2024-03-13 Thread Khatri, Sunil
c: amd-...@lists.freedesktop.org ; dri-devel@lists.freedesktop.org ; linux-ker...@vger.kernel.org ; Khatri, Sunil Subject: [PATCH 1/2] drm/amdgpu: add the IP information of the soc Add all the IP's information on a SOC to the devcoredump. Signed-off-by: Sunil Khatri --- drivers/gpu/drm

Re: [PATCH 2/2] drm:amdgpu: add firmware information of all IP's

2024-03-13 Thread Khatri, Sunil
c: amd-...@lists.freedesktop.org ; dri-devel@lists.freedesktop.org ; linux-ker...@vger.kernel.org ; Khatri, Sunil Subject: [PATCH 2/2] drm:amdgpu: add firmware information of all IP's Add firmware version information of each IP and each instance where applicable. Signed-off-by: Sunil Khatri --- drivers/

Re: [PATCH 1/2] drm/amdgpu: add the IP information of the soc

2024-03-13 Thread Khatri, Sunil
On 3/14/2024 1:58 AM, Alex Deucher wrote: On Tue, Mar 12, 2024 at 8:41 AM Sunil Khatri wrote: Add all the IP's information on a SOC to the devcoredump. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 19 +++ 1 file changed, 19 insertions(+) di

Re: [PATCH 2/2] drm:amdgpu: add firmware information of all IP's

2024-03-13 Thread Khatri, Sunil
On 3/14/2024 2:06 AM, Alex Deucher wrote: On Tue, Mar 12, 2024 at 8:42 AM Sunil Khatri wrote: Add firmware version information of each IP and each instance where applicable. Is there a way we can share some common code with devcoredump, debugfs, and the info IOCTL? All three places need to

Re: [PATCH 2/2] drm:amdgpu: add firmware information of all IP's

2024-03-14 Thread Khatri, Sunil
On 3/14/2024 11:40 AM, Sharma, Shashank wrote: On 14/03/2024 06:58, Khatri, Sunil wrote: On 3/14/2024 2:06 AM, Alex Deucher wrote: On Tue, Mar 12, 2024 at 8:42 AM Sunil Khatri wrote: Add firmware version information of each IP and each instance where applicable. Is there a way we can

Re: [PATCH 1/2] drm/amdgpu: add the IP information of the soc

2024-03-14 Thread Khatri, Sunil
On 3/14/2024 8:12 PM, Alex Deucher wrote: On Thu, Mar 14, 2024 at 1:44 AM Khatri, Sunil wrote: On 3/14/2024 1:58 AM, Alex Deucher wrote: On Tue, Mar 12, 2024 at 8:41 AM Sunil Khatri wrote: Add all the IP's information on a SOC to the devcoredump. Signed-off-by: Sunil K

RE: [PATCH] drm/amdgpu: add the hw_ip version of all IP's

2024-03-15 Thread Khatri, Sunil
; linux-ker...@vger.kernel.org; Khatri, Sunil Subject: [PATCH] drm/amdgpu: add the hw_ip version of all IP's Add all the IP's version information on a SOC to the devcoredump. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 62 +++ 1 fi

Re: [PATCH] drm/amdgpu: add the hw_ip version of all IP's

2024-03-15 Thread Khatri, Sunil
On 3/15/2024 6:45 PM, Alex Deucher wrote: On Fri, Mar 15, 2024 at 8:13 AM Sunil Khatri wrote: Add all the IP's version information on a SOC to the devcoredump. Signed-off-by: Sunil Khatri This looks great. Reviewed-by: Alex Deucher Thanks Alex --- drivers/gpu/drm/amd/amdgpu/amdgp

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Khatri, Sunil
Validated the code by using the function in same way as ioctl would use in devcoredump and getting the valid values. Also this would be the container of the information that we need to share between ioctl, debugfs and devcoredump and keep updating this based on information needed. On 3/19/2

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Khatri, Sunil
On 3/19/2024 7:19 PM, Lazar, Lijo wrote: On 3/19/2024 6:02 PM, Sunil Khatri wrote: Refactor the code so debugfs and devcoredump can reuse the common information and avoid unnecessary copy of it. created a new file which would be the right place to hold functions which will be used between sy

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Khatri, Sunil
On 3/19/2024 7:43 PM, Lazar, Lijo wrote: On 3/19/2024 7:27 PM, Khatri, Sunil wrote: On 3/19/2024 7:19 PM, Lazar, Lijo wrote: On 3/19/2024 6:02 PM, Sunil Khatri wrote: Refactor the code so debugfs and devcoredump can reuse the common information and avoid unnecessary copy of it. created a

Re: [PATCH v2] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Khatri, Sunil
On 3/19/2024 8:07 PM, Christian König wrote: Am 19.03.24 um 15:25 schrieb Sunil Khatri: Refactor the code so debugfs and devcoredump can reuse the common information and avoid unnecessary copy of it. created a new file which would be the right place to hold functions which will be used betwee

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Khatri, Sunil
Sent a new patch based on discussion with Alex. On 3/19/2024 8:34 PM, Christian König wrote: Am 19.03.24 um 15:59 schrieb Alex Deucher: On Tue, Mar 19, 2024 at 10:56 AM Christian König wrote: Am 19.03.24 um 15:26 schrieb Alex Deucher: On Tue, Mar 19, 2024 at 8:32 AM Sunil Khatri wrote: Ref

RE: [PATCH v2] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Khatri, Sunil
...@vger.kernel.org; Zhang, Hawking ; Kuehling, Felix ; Lazar, Lijo ; Khatri, Sunil Subject: [PATCH v2] drm/amdgpu: refactor code to reuse system information Refactor the code so debugfs and devcoredump can reuse the common information and avoid unnecessary copy of it. created a new file which

Re: [PATCH] drm/amdgpu: add support of bios dump in devcoredump

2024-03-26 Thread Khatri, Sunil
On 3/26/2024 10:23 PM, Alex Deucher wrote: On Tue, Mar 26, 2024 at 10:38 AM Sunil Khatri wrote: dump the bios binary in the devcoredump. Signed-off-by: Sunil Khatri --- .../gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 20 +++ 1 file changed, 20 insertions(+) diff --git a/

Re: [PATCH] drm/amdgpu: add IP's FW information to devcoredump

2024-03-27 Thread Khatri, Sunil
On 3/28/2024 8:38 AM, Alex Deucher wrote: On Tue, Mar 26, 2024 at 1:31 PM Sunil Khatri wrote: Add FW information of all the IP's in the devcoredump. Signed-off-by: Sunil Khatri Might want to include the vbios version info as well, e.g., atom_context->name atom_context->vbios_pn atom_contex

RE: [PATCH] drm: function to get process name and pid

2025-04-11 Thread Khatri, Sunil
[AMD Official Use Only - AMD Internal Distribution Only] Sure, I will send the patch for the user too. Regards Sunil Khatri -Original Message- From: Koenig, Christian Sent: Friday, April 11, 2025 5:40 PM To: Khatri, Sunil ; dri-devel@lists.freedesktop.org; amd

Re: [PATCH v1 3/3] drm/amdgpu: update the error logging for more information

2025-04-11 Thread Khatri, Sunil
On 4/11/2025 7:54 PM, Alex Deucher wrote: On Fri, Apr 11, 2025 at 9:05 AM Sunil Khatri wrote: add process and pid information in the userqueue error logging to make it more useful in resolving the error by logs. Sample log: [ 42.444297] [drm:amdgpu_userqueue_wait_for_signal [amdgpu]] *ERRO

Re: [PATCH V6 3/5] drm/amdgpu: use drm_file_err in fence timeouts

2025-04-17 Thread Khatri, Sunil
On 4/17/2025 7:11 PM, Tvrtko Ursulin wrote: On 17/04/2025 13:31, Sunil Khatri wrote: use drm_file_err instead of DRM_ERROR which adds process and pid information in the userqueue error logging. Sample log: [   42.444297] [drm:amdgpu_userqueue_wait_for_signal [amdgpu]] *ERROR* Timed out wait

Re: [PATCH v3 3/4] drm/amdgpu: use drm_file_err in logging to also dump process information

2025-04-16 Thread Khatri, Sunil
On 4/16/2025 5:37 PM, Pierre-Eric Pelloux-Prayer wrote: Hi, Le 16/04/2025 à 12:01, Khatri, Sunil a écrit : On 4/16/2025 12:56 PM, Tvrtko Ursulin wrote: On 15/04/2025 19:43, Sunil Khatri wrote: add process and pid information in the userqueue error logging to make it more useful in

Re: [PATCH 1/2] drm/ttm: fix the warning for hit_low and evict_low

2025-04-18 Thread Khatri, Sunil
On 4/17/2025 5:01 PM, Tvrtko Ursulin wrote: On 17/04/2025 10:34, Sunil Khatri wrote: fix the below warning messages: ttm/ttm_bo.c:1098: warning: Function parameter or struct member 'hit_low' not described in 'ttm_bo_swapout_walk' ttm/ttm_bo.c:1098: warning: Function parameter or struct membe

Re: [PATCH V6 1/5] drm: add drm_file_err function to add process info

2025-04-18 Thread Khatri, Sunil
For rest of the patches which are part of the amdgpu tree will push incorporating changes as shared by @Tvrtko Ursulin once drm change is merged. Thanks a lot all for the reviews. Regards Sunil Khatri On 4/17/2025 6:01 PM, Sunil Khatri wrote: Add a drm helper function which append the proc

Re: [PATCH v2 1/4] drm: function to get process name and pid

2025-04-15 Thread Khatri, Sunil
On 4/15/2025 5:10 PM, Tvrtko Ursulin wrote: On 15/04/2025 12:25, Sunil Khatri wrote: Add helper function which get the process information for the drm_file and updates the user provided character buffer with the information of process name and pid as a string. Signed-off-by: Sunil Khatri --

Re: [PATCH V8 2/5] drm/amdgpu: add drm_file reference in userq_mgr

2025-04-22 Thread Khatri, Sunil
On 4/22/2025 2:07 PM, Christian König wrote: Am 17.04.25 um 18:10 schrieb Sunil Khatri: drm_file will be used in usermode queues code to enable better process information in logging and hence add drm_file part of the userq_mgr struct. update the drm_file pointer in userq_mgr for each amdgpu_d

Re: [PATCH V6 1/5] drm: add drm_file_err function to add process info

2025-04-17 Thread Khatri, Sunil
On 4/17/2025 7:04 PM, Tvrtko Ursulin wrote: On 17/04/2025 13:31, Sunil Khatri wrote: Add a drm helper function which append the process information for appends Noted the drm_file over drm_err formated output. formatted 'Noted v5: change to macro from function (Christian Koenig)   

Re: [PATCH v1] drm/sched: fix the warning in drm_sched_job_done

2025-04-18 Thread Khatri, Sunil
On 4/17/2025 3:51 PM, Tvrtko Ursulin wrote: On 17/04/2025 11:01, Sunil Khatri wrote: Fix the below warning. scheduler/sched_main.c:397: warning: Function parameter or struct member 'result' not described in 'drm_sched_job_done' Reviewed-by: Tvrtko Ursulin Signed-off-by: Sunil Khatri ---

RE: [PATCH] drm/ttm: fix the warning for hit_low and evict_low

2025-04-22 Thread Khatri, Sunil
[AMD Official Use Only - AMD Internal Distribution Only] Thanks a lot. Regards Sunil Khatri -Original Message- From: Maarten Lankhorst Sent: Tuesday, April 22, 2025 10:24 PM To: Khatri, Sunil ; Khatri, Sunil ; dri-devel@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian

Re: [PATCH V8 1/5] drm: add drm_file_err function to add process info

2025-04-28 Thread Khatri, Sunil
On 4/22/2025 2:33 PM, Christian König wrote: Am 17.04.25 um 18:10 schrieb Sunil Khatri: Add a drm helper function which appends the process information for the drm_file over drm_err formatted output. v5: change to macro from function (Christian Koenig) add helper functions for lock/unloc

RE: [PATCH V8 1/5] drm: add drm_file_err function to add process info

2025-04-30 Thread Khatri, Sunil
ed to drm-misc-next. Christian " -Original Message- From: Jani Nikula Sent: Monday, April 28, 2025 5:20 PM To: Khatri, Sunil ; Koenig, Christian ; Khatri, Sunil ; dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; David Airlie ; Simona Vetter ; Maxime Ripard ; Maarten

Re: [PATCH v1 1/3] drm: function to get process name and pid

2025-04-13 Thread Khatri, Sunil
Ping? On 4/11/2025 6:34 PM, Sunil Khatri wrote: Add helper function which get the process information for the drm_file and updates the user provided character buffer with the information of process name and pid as a string. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/drm_file.c | 30

Re: [PATCH v3 4/4] drm/amdgpu: change DRM_ERROR to drm_file_err in amdgpu_userqueue.c

2025-04-16 Thread Khatri, Sunil
On 4/16/2025 12:48 PM, Tvrtko Ursulin wrote: On 15/04/2025 19:43, Sunil Khatri wrote: change the DRM_ERROR to drm_file_err which gives the drm device information too which is useful in case of multiple GPU's and also add process information. Signed-off-by: Sunil Khatri ---   drivers/gpu/drm

Re: [PATCH v4 1/5] drm: add macro drm_file_err to print process info

2025-04-16 Thread Khatri, Sunil
On 4/16/2025 7:55 PM, Jani Nikula wrote: On Wed, 16 Apr 2025, Sunil Khatri wrote: Add a drm helper macro which append the process information for the drm_file over drm_err. Signed-off-by: Sunil Khatri --- include/drm/drm_file.h | 41 + 1 file changed,

Re: [PATCH v3 1/4] drm: add function drm_file_err to print proc information too

2025-04-16 Thread Khatri, Sunil
On 4/16/2025 12:37 PM, Tvrtko Ursulin wrote: On 15/04/2025 19:43, Sunil Khatri wrote: Add a drm helper function which get the process information for the drm_file and append the process information using the existing drm_err. Signed-off-by: Sunil Khatri ---   include/drm/drm_file.h | 40 +++

Re: [PATCH v3 2/4] drm/amdgpu: add drm_file reference in userq_mgr

2025-04-16 Thread Khatri, Sunil
On 4/16/2025 12:59 PM, Tvrtko Ursulin wrote: On 15/04/2025 19:43, Sunil Khatri wrote: drm_file will be used in usermode queues code to enable better process information in logging and hence add drm_file part of the userq_mgr struct. update the drm_file pointer in userq_mgr for each amdgpu_dr

Re: [PATCH v4 1/5] drm: add macro drm_file_err to print process info

2025-04-17 Thread Khatri, Sunil
On 4/16/2025 7:55 PM, Jani Nikula wrote: On Wed, 16 Apr 2025, Sunil Khatri wrote: Add a drm helper macro which append the process information for the drm_file over drm_err. Signed-off-by: Sunil Khatri --- include/drm/drm_file.h | 41 + 1 file changed,

Re: [PATCH] drm/schedular: fix the warning in drm_sched_job_done

2025-04-17 Thread Khatri, Sunil
On 4/17/2025 3:01 PM, Tvrtko Ursulin wrote: [Added Philipp and Danilo to cc.] On 17/04/2025 10:25, Sunil Khatri wrote: Fix the below warning. scheduler/sched_main.c:397: warning: Function parameter or struct member 'result' not described in 'drm_sched_job_done' Signed-off-by: Sunil Khatri

Re: [PATCH v3 3/4] drm/amdgpu: use drm_file_err in logging to also dump process information

2025-04-16 Thread Khatri, Sunil
On 4/16/2025 12:56 PM, Tvrtko Ursulin wrote: On 15/04/2025 19:43, Sunil Khatri wrote: add process and pid information in the userqueue error logging to make it more useful in resolving the error by logs. Sample log: [   42.444297] [drm:amdgpu_userqueue_wait_for_signal [amdgpu]] *ERROR* Time

RE: [PATCH v6 1/5] drm: add macro drm_file_err to print process info

2025-04-17 Thread Khatri, Sunil
[AMD Official Use Only - AMD Internal Distribution Only] -Original Message- From: Jani Nikula Sent: Thursday, April 17, 2025 5:00 PM To: Koenig, Christian ; Khatri, Sunil ; dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org Cc: Deucher, Alexander ; Tvrtko Ursulin ; Pelloux

Re: [PATCH v1 1/3] drm: function to get process name and pid

2025-04-15 Thread Khatri, Sunil
On 4/15/2025 2:14 PM, Tvrtko Ursulin wrote: On 14/04/2025 18:58, Christian König wrote: Adding Pierre-eric and Tvrtko as well. Thanks! Am 11.04.25 um 15:04 schrieb Sunil Khatri: Add helper function which get the process information for the drm_file and updates the user provided character

RE: [PATCH v2] drm/sched: fix the warning in drm_sched_job_done

2025-04-28 Thread Khatri, Sunil
, Pierre-Eric ; Khatri, Sunil Subject: [PATCH v2] drm/sched: fix the warning in drm_sched_job_done Fix the below warning. scheduler/sched_main.c:397: warning: Function parameter or struct member 'result' not described in 'drm_sched_job_done' Reviewed-by: Tvrtko Ursulin

Re: [PATCH] drm/ttm: fix the warning for hit_low and evict_low

2025-04-21 Thread Khatri, Sunil
@Lankhorst Does the comment sounds correct or could you please share what should be the right comment to add Regards Sunil Khatri On 4/21/2025 4:49 PM, Sunil Khatri wrote: fix the below warning messages: ttm/ttm_bo.c:1098: warning: Function parameter or struct member 'hit_low' not described

RE: [PATCH v2] drm/sched: fix the warning in drm_sched_job_done

2025-05-06 Thread Khatri, Sunil
[AMD Official Use Only - AMD Internal Distribution Only] Ping ? Not picked yet while patches raised before this are merged. Regards Sunil Khatri -Original Message- From: Koenig, Christian Sent: Tuesday, April 29, 2025 12:49 PM To: Khatri, Sunil ; dri-devel@lists.freedesktop.org

RE: [PATCH] drm/debugfs: add client-id to the debugfs entry

2025-05-28 Thread Khatri, Sunil
- From: Pierre-Eric Pelloux-Prayer Sent: Wednesday, May 28, 2025 6:03 PM To: Koenig, Christian ; Khatri, Sunil ; dri-devel@lists.freedesktop.org; Tvrtko Ursulin ; dmitry.osipe...@collabora.com; Pelloux-Prayer, Pierre-Eric Subject: Re: [PATCH] drm/debugfs: add client-id to the debugfs entry Hi

Re: [PATCH v2 2/2] drm: add debugfs support on per client-id basis

2025-06-16 Thread Khatri, Sunil
On 6/16/2025 5:41 PM, Christian König wrote: On 6/16/25 12:05, Sunil Khatri wrote: add support to add a directory for each client-id with root at the dri level. Since the clients are unique and not just related to one single drm device, so it makes more sense to add all the client based nodes

Re: [PATCH v4 1/4] drm: move debugfs functionality from drm_drv.c to drm_debugfs.c

2025-06-19 Thread Khatri, Sunil
On 6/19/2025 10:37 AM, Khatri, Sunil wrote: On 6/18/2025 7:38 PM, Christian König wrote: On 6/18/25 15:47, Sunil Khatri wrote: move the functions from drm_drv.c which uses the static drm_debugfs_root as parent node in the debugfs by drm. move this root node to the debugfs for easily

Re: [PATCH v4 1/4] drm: move debugfs functionality from drm_drv.c to drm_debugfs.c

2025-06-18 Thread Khatri, Sunil
On 6/18/2025 7:38 PM, Christian König wrote: On 6/18/25 15:47, Sunil Khatri wrote: move the functions from drm_drv.c which uses the static drm_debugfs_root as parent node in the debugfs by drm. move this root node to the debugfs for easily handling of future requirements to add more informati

Re: [PATCH v1 0/2] debugfs support for pt base for each vm

2025-06-22 Thread Khatri, Sunil
On 6/20/2025 6:10 PM, Tvrtko Ursulin wrote: On 13/06/2025 08:15, Sunil Khatri wrote: root@amd-X570-AORUS-ELITE:~# cat /sys/kernel/debug/dri/0/clients   command  tgid dev master a   uid magic name client-id    systemd-logind  1056   0   y    y 0 0 5 Xwayla

Re: [PATCH v4 2/4] drm: add debugfs support on per client-id basis

2025-06-23 Thread Khatri, Sunil
On 6/23/2025 2:58 PM, Tvrtko Ursulin wrote: On 18/06/2025 14:47, Sunil Khatri wrote: add support to add a directory for each client-id with root at the dri level. Since the clients are unique and not just related to one single drm device, so it makes more sense to add all the client based no

Re: [PATCH v2 2/2] drm: add debugfs support on per client-id basis

2025-06-16 Thread Khatri, Sunil
On 6/16/2025 6:26 PM, Christian König wrote: On 6/16/25 14:25, Khatri, Sunil wrote: On 6/16/2025 5:41 PM, Christian König wrote: On 6/16/25 12:05, Sunil Khatri wrote: add support to add a directory for each client-id with root at the dri level. Since the clients are unique and not just

Re: [PATCH v1 0/2] debugfs support for pt base for each vm

2025-06-13 Thread Khatri, Sunil
On 6/13/2025 2:30 PM, Christian König wrote: On 6/13/25 09:15, Sunil Khatri wrote: root@amd-X570-AORUS-ELITE:~# cat /sys/kernel/debug/dri/0/clients command tgid dev master a uid magic name client-id syst

Re: [PATCH v5 4/5] drm/amdgpu: add debugfs support for VM pagetable per client

2025-06-26 Thread Khatri, Sunil
On 6/26/2025 5:48 PM, Christian König wrote: On 24.06.25 13:34, Sunil Khatri wrote: Each drm node is associated with a unique client-id. Create a directory for each drm-file in the dri root directory. This directory is unique to hold information related to a client id which is unique in the sy

Re: [PATCH] drm/debugfs: add client-id to the debugfs entry

2025-05-28 Thread Khatri, Sunil
Sure Pierre Go ahead and get them merged. I am also planning to use that information in debugfs implementation of some parameters of our driver so I do need those. I will drop my debugfs patch. Regards Sunil Khatri On 5/28/2025 6:32 PM, Christian König wrote: On 5/28/25 14:33, Pierre-Eric P

RE: [PATCH 3/3] drm/file: add client id to drm_file_error

2025-05-28 Thread Khatri, Sunil
[AMD Official Use Only - AMD Internal Distribution Only] -Original Message- From: Koenig, Christian Sent: Wednesday, May 28, 2025 4:44 PM To: Khatri, Sunil ; dri-devel@lists.freedesktop.org; Tvrtko Ursulin ; dmitry.osipe...@collabora.com; Pelloux-Prayer, Pierre-Eric Subject: Re

Re: [PATCH v9 3/4] drm/amdgpu: add debugfs support for VM pagetable per client

2025-07-03 Thread Khatri, Sunil
On 7/3/2025 1:30 PM, Christian König wrote: On 01.07.25 18:49, Sunil Khatri wrote: Add a debugfs file under the client directory which shares the root page table base address of the VM. This address could be used to dump the pagetable for debug memory issues. Signed-off-by: Sunil Khatri ---

Re: [PATCH v8 1/4] drm: move drm based debugfs funcs to drm_debugfs.c

2025-07-01 Thread Khatri, Sunil
On 7/1/2025 8:50 PM, Jeff Hugo wrote: On 7/1/2025 7:02 AM, Khatri, Sunil wrote: [AMD Official Use Only - AMD Internal Distribution Only] I cannot review this message with this restriction.  In my opinion, your email client is not properly configured for interfacing with the community

Re: [PATCH v6 2/5] drm: move debugfs functionality from drm_drv.c to drm_debugfs.c

2025-06-30 Thread Khatri, Sunil
On 6/30/2025 5:11 PM, Christian König wrote: On 27.06.25 11:49, Sunil Khatri wrote: move the debugfs functions from drm_drv.c to drm_debugfs.c move this root node to the debugfs for easily handling of future requirements to add more information in the root directory and one of which is plann

Re: [PATCH v5 1/5] drm: move the debugfs accel driver code to drm layer

2025-06-26 Thread Khatri, Sunil
On 6/26/2025 5:26 PM, Christian König wrote: On 24.06.25 13:34, Sunil Khatri wrote: move the debugfs accel driver code to the drm layer. This is first inline change to move the debugfs related changes for drm to drm_debugfs.c Maybe write something like this: Noted Regards Sunil "And int

Re: [PATCH v5 3/5] drm: add debugfs support on per client-id basis

2025-06-26 Thread Khatri, Sunil
On 6/26/2025 7:07 PM, Tvrtko Ursulin wrote: On 24/06/2025 12:34, Sunil Khatri wrote: add support to add a directory for each client-id with root at the dri level. Since the clients are unique and not just related to one single drm device, so it makes more sense to add all the client based nod

Re: [PATCH v5 2/5] drm: move debugfs functionality from drm_drv.c to drm_debugfs.c

2025-06-26 Thread Khatri, Sunil
On 6/26/2025 5:28 PM, Christian König wrote: On 24.06.25 13:34, Sunil Khatri wrote: move the debugfs functions from drm_drv.c to drm_debugfs.c move this root node to the debugfs for easily handling of future requirements to add more information in the root directory and one of which is plann

Re: [PATCH v5 3/5] drm: add debugfs support on per client-id basis

2025-06-26 Thread Khatri, Sunil
On 6/26/2025 5:34 PM, Christian König wrote: On 24.06.25 13:34, Sunil Khatri wrote: add support to add a directory for each client-id with root at the dri level. Since the clients are unique and not just related to one single drm device, so it makes more sense to add all the client based nodes

Re: [PATCH v7 1/5] drm: move the debugfs accel driver code to drm layer

2025-06-30 Thread Khatri, Sunil
On 6/30/2025 8:49 PM, Jeff Hugo wrote: On 6/30/2025 8:36 AM, Sunil Khatri wrote: I don't see a cover letter on list. Surely there should be one? Yes there is one with the first version of patches. Looks like you didn't send this to the Accel maintainer. Did you forget to run the get_mainta

Re: [PATCH v7 1/5] drm: move the debugfs accel driver code to drm layer

2025-06-30 Thread Khatri, Sunil
On 7/1/2025 12:04 AM, Christian König wrote: On 30.06.25 16:36, Sunil Khatri wrote: Move the debugfs accel driver code to the drm layer and it is an intermediate step to move all debugfs related handling into drm_debugfs.c Signed-off-by: Sunil Khatri Reviewed-by: Christian König --- driv

RE: [PATCH v8 1/4] drm: move drm based debugfs funcs to drm_debugfs.c

2025-07-01 Thread Khatri, Sunil
...@kernel.org; d...@kernel.org; linux-ker...@vger.kernel.org; Oded Gabbay ; Khatri, Sunil Subject: [PATCH v8 1/4] drm: move drm based debugfs funcs to drm_debugfs.c Requirement is to create per client-id based directories to hold key debugging information and for that access to root debugfs