Re: [Nouveau] Aspirant for GSOC 2018 for Nouveau Vulkan driver

2018-03-07 Thread Karol Herbst
I would be willing to be a mentor for this project. On Wed, Mar 7, 2018 at 1:45 PM, Martin Peres wrote: > Hi Anusha, > > Sorry, I was under the expectation that userspace developers would > answer you after your first message, and I missed your second one! My > sincere apologies. > > Generally, t

Re: [Nouveau] [RFC PATCH] drm/nouveau/therm: initial implementation of new gp1xx temperature sensor

2017-08-31 Thread Karol Herbst
On Thu, Aug 31, 2017 at 4:55 AM, Rhys Kidd wrote: > Signed-off-by: Rhys Kidd > --- > .../gpu/drm/nouveau/include/nvkm/subdev/therm.h| 1 + > drivers/gpu/drm/nouveau/nvkm/engine/device/base.c | 6 +++ > drivers/gpu/drm/nouveau/nvkm/subdev/therm/Kbuild | 1 + > drivers/gpu/drm/nouveau/nv

Re: [Nouveau] [PATCH] [RESEND] drm/nouveau/clk: fix gcc-7 -Wint-in-bool-context warning

2017-09-06 Thread Karol Herbst
On Wed, Sep 6, 2017 at 3:56 PM, Arnd Bergmann wrote: > gcc thinks that interpreting a multiplication result as a bool > is confusing: > > drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt215.c: In function 'read_pll': > drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt215.c:133:8: error: '*' in boolean > conte

Re: [Nouveau] [PATCH] [RESEND] drm/nouveau/clk: fix gcc-7 -Wint-in-bool-context warning

2017-09-06 Thread Karol Herbst
On Wed, Sep 6, 2017 at 10:11 PM, Arnd Bergmann wrote: > On Wed, Sep 6, 2017 at 4:20 PM, Karol Herbst wrote: >>> In this instance, I think using multiplication is more intuitive >>> than '&&', so I'm adding a comparison to zero instead to shut up >&g

Re: [Nouveau] [PATCH] drm/nouveau/mmu: Fix trailing semicolon

2018-01-23 Thread Karol Herbst
Reviewed-by: Karol Herbst On Wed, Jan 17, 2018 at 7:53 PM, Luis de Bethencourt wrote: > The trailing semicolon is an empty statement that does no operation. > Removing it since it doesn't do anything. > > Signed-off-by: Luis de Bethencourt > --- > > Hi, > >

Re: [Nouveau] [RFC v2 1/4] drm/nouveau: Add support for basic clockgating on Kepler1

2018-01-26 Thread Karol Herbst
On Fri, Jan 26, 2018 at 4:35 AM, Lyude Paul wrote: > This adds support for enabling automatic clockgating on nvidia GPUs for > Kepler1. While this is not technically a clockgating level, it does > enable clockgating using the clockgating values initially set by the > vbios (which should be safe to

Re: [Nouveau] [PATCH] drm/nouveau/therm/gp100: Do not report temperature when subdev is shadowed

2018-01-26 Thread Karol Herbst
no, we can't do that. We actually have to prevent this from hwom. The issue here is, that the reg read returns 0x and parsing that is the first step in the first place. On Thu, Jan 25, 2018 at 7:16 PM, Tobias Klausmann wrote: > This fixes wrong temperature outputs e.g. 511°C if the card i

Re: [Nouveau] [PATCH] drm/nouveau/therm/gp100: Do not report temperature when subdev is shadowed

2018-01-26 Thread Karol Herbst
> device is shadowed, getting a sane temp value out of is seems unlikely to > me! > > Greetings, > > Tobias > > > On 1/26/18 12:40 PM, Karol Herbst wrote: >> >> no, we can't do that. We actually have to prevent this from hwom. The >> issue here is,

Re: [Nouveau] [regression drm/noveau] suspend to ram -> BOOM: exception RIP: drm_calc_vbltimestamp_from_scanoutpos+335

2017-07-15 Thread Karol Herbst
Yeah, we shouldn't let the machine die. Are there more WARN_ON_ONCE usage we could convert to WARN_ONCE? Reviewed-By: Karol Herbst On Fri, Jul 14, 2017 at 5:05 PM, Tobias Klausmann wrote: > On 7/14/17 3:41 PM, Mike Galbraith wrote: >> >> On Fri, 2017-07-14 at 15:36 +0200,

Re: [Nouveau] [PATCH] drm/nouveau/mmu: fix odd_ptr_err.cocci warnings (fwd)

2017-11-28 Thread Karol Herbst
Hi julia, I think it would be better to extract the assignment out of the if clause. Then you'll get something like this: memory = ...; if (IS_ERR(memory)) { } so, to answer your question: no, it isn't necessary. On Tue, Nov 28, 2017 at 1:56 PM, Julia Lawall wrote: > This is a false posit

Re: [Nouveau] [PATCH] drm/nouveau/mmu: fix odd_ptr_err.cocci warnings

2017-12-06 Thread Karol Herbst
Reviewed-by: Karol Herbst On Thu, Nov 30, 2017 at 8:53 PM, Christoph Böhmwalder wrote: > The kbuild test bot complained about a new coccinelle warning nearby, > which sparked a discussion about the assignment to 'memory' inside of > the conditional expression. See Link bel

Re: [PATCH] drm/nouveau/i2c: rename aux.c and aux.h to nvkm_i2c_aux.c and nvkm_i2c_aux.h

2024-06-01 Thread Karol Herbst
On Sat, Jun 1, 2024 at 11:33 PM wrote: > > s=20181004; d=freemail.hu; > > h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; > l=6462; bh=CnHSqkRX34kqCWN2/oPtvm9wm8HJCe8QhPwQypdpi3w=; > b=JDlDB9yOQDBY7EDnRMrt8qYnWfH8J/LKYKb904

Re: [PATCH] drm/nouveau/i2c: rename aux.c and aux.h to nvkm_i2c_aux.c and nvkm_i2c_aux.h

2024-06-03 Thread Karol Herbst
roE132r01M9mxZU5bk4M4uMO38l > HwZjS8YTSOmTA49PcLYbh+hr+e+GVFHP+X1wgmd/93wqlySRgqM7N1fh84jucg03IMS > D/tvbePTzg== > Content-Transfer-Encoding: quoted-printable > > 2024. 06. 02. 0:12 keltez=C3=A9ssel, Karol Herbst =C3=ADrta: > > On Sat, Jun 1, 2024 at 11:33=E2=80

Re: [PATCH v3 2/2] drm/nouveau: Add drm_panic support for nv50+

2024-10-21 Thread Karol Herbst
On Fri, Oct 18, 2024 at 11:50 PM Lyude Paul wrote: > > On Fri, 2024-09-13 at 09:03 +0200, Jocelyn Falempe wrote: > > Add drm_panic support, for nv50+ cards. > > It's enough to get the panic screen while running Gnome/Wayland on a > > GTX 1650. > > It doesn't support multi-plane or compressed forma

Re: [PATCH 1/2] gpu: nova-core: add initial driver stub

2025-02-01 Thread Karol Herbst
On Fri, Jan 31, 2025 at 11:04 PM Danilo Krummrich wrote: > > Add the initial nova-core driver stub. > > nova-core is intended to serve as a common base for nova-drm (the > corresponding DRM driver) and the vGPU manager VFIO driver, serving as a > hard- and firmware abstraction layer for GSP-based

Re: [PATCH 1/2] gpu: nova-core: add initial driver stub

2025-02-01 Thread Karol Herbst
On Sat, Feb 1, 2025 at 9:14 AM Karol Herbst wrote: > > On Fri, Jan 31, 2025 at 11:04 PM Danilo Krummrich wrote: > > > > Add the initial nova-core driver stub. > > > > nova-core is intended to serve as a common base for nova-drm (the > > corresponding DRM driv

[PATCH 1/1] MAINTAINERS: Remove myself

2025-02-14 Thread Karol Herbst
here I simply couldn't continue the work I was so motivated doing as I've did in the early days. Please respect my wishes and put this statement as is into the tree. Leaving anything out destroys its entire meaning. Respectfully Karol Signed-off-by: Karol Herbst --- MAINT

[PATCH 0/1] Me stepping down as a nouveau kernel maintainer

2025-02-14 Thread Karol Herbst
y the best of luck and all the strength needed. Karol Herbst (1): MAINTAINERS: Remove myself MAINTAINERS | 2 -- 1 file changed, 2 deletions(-) -- 2.48.1

<    1   2   3   4   5