good catch
Reviewed-by: Karol Herbst
2017-04-29 6:11 GMT+02:00 Mario Kleiner :
> A missing u64 cast causes a 32-Bit wraparound from
> 4096 MiB to 0 MiB and therefore total 0 MiB VRAM detected
> if card has 4096 Mib per FBP.
>
> Signed-off-by: Mario Kleiner
> ---
> drivers
2017-05-02 7:07 GMT+02:00 Martin Peres :
> On 26/04/17 19:46, Oscar Salvador wrote:
>> This patch replaces the symbolic permissions with the numeric ones,
>> and adds me to the authors too.
>>
>> Signed-off-by: Oscar Salvador
>
>
>> ---
>> drivers/gpu/drm/nouveau/nouveau_hwmon.c | 14 +++-
2017-05-02 6:25 GMT+02:00 Martin Peres :
> On 26/04/17 19:46, Oscar Salvador wrote:
>> This patch introduces the nouveau_hwmon_ops structure, sets up
>> .is_visible and .read_string operations and adds all the functions
>> for these operations.
>> This is also a preparation for the next patches, wh
2016-11-08 16:46 GMT+01:00 Ilia Mirkin :
> On Tue, Nov 8, 2016 at 8:56 AM, Arnd Bergmann wrote:
>> The newly introduced LED handling for nouveau fails to link when the
>> driver is built-in but the LED subsystem is a loadable module:
>>
>> drivers/gpu/drm/nouveau/nouveau.o: In function `nouveau_do
2016-11-08 17:12 GMT+01:00 Arnd Bergmann :
> On Tuesday, November 8, 2016 5:07:01 PM CET Lukas Wunner wrote:
>> On Tue, Nov 08, 2016 at 04:52:49PM +0100, Arnd Bergmann wrote:
>> > The underlying problem is that we already have a number of other
>> > symbols that either have "depends on LEDS_CLASS"
It looks similiar to this one:
https://bugs.freedesktop.org/show_bug.cgi?id=101322
please provide a dmesg booted with "nouveau.debug=debug" as well
2017-06-02 12:01 GMT+02:00 Chris Chiu :
> We are working with new desktop that have the NVIDIA NV118
> chipset.
>
> During boot, the display becomes
I think it would be better to squash those commits:
1. for the includes
2. for static declerations
2016-10-22 11:41 GMT+02:00 Baoyou Xie :
> We get 2 warnings when building kernel with W=1:
> drivers/gpu/drm/nouveau/nvkm/core/firmware.c:34:1: warning: no previous
> prototype for 'nvkm_firmware_ge
2016-10-24 9:13 GMT+02:00 Baoyou Xie :
>
>
> On 23 October 2016 at 01:32, Karol Herbst wrote:
>>
>> I think it would be better to squash those commits:
>> 1. for the includes
>> 2. for static declerations
>>
> OK, I have resent new patch that squash tho
uhh, that function looks so odd, ... yeah. Change looks fine.
Reviewed-By: Karol Herbst
2016-10-24 17:30 GMT+02:00 Arnd Bergmann :
> gcc-4.9 notices that the validate_init() function returns unintialized
> data when called with a zero 'nr_buffers' argument, when called wi
Thanks for the pointer.
But I don't like this patch. If you find a bug, make a bug report or
just fix it if you know the fix already. Or write something in IRC. Or
write on the Mailing list as a general question or something else
But I really don't agree on doing it this way. You would have neede
Hi Dan,
yeah I also catched that. I assume something went wrong in the review process,
because I am sure I didn't added that "pci ||" check myself ;) but who knows,
maybe I was tired working with ben on that, cause it was like 4am while doing
the last polishing steps.
nvm, I already send a patch
> Karol Herbst hat am 13. Januar 2016 um 13:30
> geschrieben:
>
> Hi Dan,
>
> yeah I also catched that. I assume something went wrong in the review process,
> because I am sure I didn't added that "pci ||" check myself ;) but who knows,
> maybe I was tired
> Arnd Bergmann hat am 13. Januar 2016 um 14:48 geschrieben:
>
> The new debugfs initialization code fails to build when CONFIG_DEBUG_FS
> is disabled:
>
> In file included from /git/arm-soc/drivers/gpu/drm/nouveau/nouveau_drm.c:57:0:
> drivers/gpu/drm/nouveau/nouveau_debugfs.h: In function 'nou
> Emil Velikov hat am 15. Januar 2016 um 12:06
> geschrieben:
>
> On 13 January 2016 at 16:00, Arnd Bergmann wrote:
> > On Wednesday 13 January 2016 14:55:47 Karol Herbst wrote:
> >> > Arnd Bergmann hat am 13. Januar 2016 um 14:48
> >> >
On Tue, Jul 7, 2020 at 9:30 PM Karol Herbst wrote:
>
> Hi everybody,
>
> with the mentioned commit Nouveau isn't able to load firmware onto the
> GPU on one of my systems here. Even though the issue doesn't always
> happen I am quite confident this is the commit
On Fri, Jul 17, 2020 at 1:54 AM Bjorn Helgaas wrote:
>
> [+cc Sasha -- stable kernel regression]
> [+cc Patrick, Kai-Heng, LKML]
>
> On Fri, Jul 17, 2020 at 12:10:39AM +0200, Karol Herbst wrote:
> > On Tue, Jul 7, 2020 at 9:30 PM Karol Herbst wrote:
> > >
> >
Filed at https://bugzilla.kernel.org/show_bug.cgi?id=208597
oddly enough I wasn't able to reproduce it on my XPS 9560, will ping
once something breaks.
On Fri, Jul 17, 2020 at 2:43 AM Karol Herbst wrote:
>
> On Fri, Jul 17, 2020 at 1:54 AM Bjorn Helgaas wrote:
> >
> &g
do a proper bug report and we can
look into it and come up with a proper fix (and keep this patch out until
we resolve all of those).
Signed-off-by: Karol Herbst
CC: Alex Hung
CC: "Rafael J. Wysocki"
CC: Len Brown
CC: Lyude Paul
CC: linux-ker...@vger.kernel.org
CC:
On Fri, Jul 17, 2020 at 9:52 PM Alex Hung wrote:
>
> On 2020-07-17 1:05 p.m., Karol Herbst wrote:
> > It's hard to figure out what systems are actually affected and right now I
> > don't see a good way of removing those...
> >
> > But I'd like to see t
On Mon, Jul 20, 2020 at 3:19 AM Alex Hung wrote:
>
> On 2020-07-19 1:50 p.m., Karol Herbst wrote:
> > On Fri, Jul 17, 2020 at 9:52 PM Alex Hung wrote:
> >>
> >> On 2020-07-17 1:05 p.m., Karol Herbst wrote:
> >>> It's hard to figure out wha
On Wed, Jul 22, 2020 at 11:25 AM Mika Westerberg
wrote:
>
> On Tue, Jul 21, 2020 at 01:37:12PM -0500, Patrick Volkerding wrote:
> > On 7/21/20 10:27 AM, Mika Westerberg wrote:
> > > On Tue, Jul 21, 2020 at 11:01:55AM -0400, Lyude Paul wrote:
> > >> Sure thing. Also, feel free to let me know if you
On Fri, Oct 9, 2020 at 11:35 PM Ondrej Zary wrote:
>
> Hello,
> I'm testing 5.9.0-rc8 and found that Riva TNT2 stopped working:
> [0.00] Linux version 5.9.0-rc8+ (zary@gsql) (gcc (Debian 8.3.0-6)
> 8.3.0, GNU ld (GNU Binutils for Debian) 2.31.1) #326 SMP Fri Oct 9 22:31:40
> CEST 2020
>
On Sat, Oct 10, 2020 at 12:23 AM Ilia Mirkin wrote:
>
> On Fri, Oct 9, 2020 at 5:54 PM Karol Herbst wrote:
> >
> > On Fri, Oct 9, 2020 at 11:35 PM Ondrej Zary wrote:
> > >
> > > Hello,
> > > I'm testing 5.9.0-rc8 and found that Riva TNT2 stopped
Ben, I think this is like the 5th patch tackling this issue, I think
we should merge one of those.
On Thu, Oct 15, 2020 at 6:23 AM Keita Suzuki
wrote:
>
> struct pw_rail_t is allocated as an array in function nvios_iccsense_parse,
> and stored to a struct member of local variable. However, the ar
On Thu, Oct 15, 2020 at 6:32 PM Karol Herbst wrote:
>
> Ben, I think this is like the 5th patch tackling this issue, I think
> we should merge one of those.
>
maybe I just confused that with reports, but it seems to turn up quite
a bit and maybe I should have pushed more of it as wel
I sent a patch to the mailing list and wanted to have some review on
that from at least Ben, but no idea if Ben already picked it and if
it's good enough for sending it to stable yet.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lis
On Tue, Jun 23, 2020 at 3:03 PM Mikko Perttunen wrote:
>
> # Host1x/TegraDRM UAPI proposal
>
> This is a proposal for a stable UAPI for Host1x and TegraDRM, to replace
> the current TegraDRM UAPI that is behind `STAGING` and quite obsolete in
> many ways.
>
> I haven't written any implementation y
On Fri, Jun 26, 2020 at 1:13 PM Mikko Perttunen wrote:
>
> On 6/26/20 2:06 PM, Karol Herbst wrote:
> > On Tue, Jun 23, 2020 at 3:03 PM Mikko Perttunen wrote:
> >>
> >> # Host1x/TegraDRM UAPI proposal
> >>
> >> This is a proposal for a stable U
On Wed, Jul 1, 2020 at 6:45 AM James Jones wrote:
>
> This implies something is trying to use one of the old
> DRM_FORMAT_MOD_NVIDIA_16BX2_BLOCK format modifiers with DRM-KMS without
> first checking whether it is supported by the kernel. I had tried to
> force an Xorg+Mesa stack without my users
On Wed, Jul 1, 2020 at 6:01 PM Daniel Vetter wrote:
>
> On Wed, Jul 1, 2020 at 5:51 PM James Jones wrote:
> >
> > On 7/1/20 4:24 AM, Karol Herbst wrote:
> > > On Wed, Jul 1, 2020 at 6:45 AM James Jones wrote:
> > >>
> > >> Thi
On Wed, Jul 1, 2020 at 7:37 PM James Jones wrote:
>
> On 7/1/20 10:04 AM, Karol Herbst wrote:
> > On Wed, Jul 1, 2020 at 6:01 PM Daniel Vetter wrote:
> >>
> >> On Wed, Jul 1, 2020 at 5:51 PM James Jones wrote:
> >>>
> >>> On 7/1/20 4:24 AM,
Reviewed-by: Alex Deucher
> Acked-by: Noralf Trønnes
> Cc: Andrey Grodzovsky
> Cc: Dave Airlie
> Cc: Sean Paul
> Cc: Simon Ser
> Cc: Ben Skeggs
> Cc: Karol Herbst
>
> ---
>
> This is only about laying out plans for the future, not about what
> drivers do toda
On Sat, Mar 21, 2020 at 2:02 AM Karol Herbst wrote:
>
> On Fri, Mar 20, 2020 at 11:19 PM Bjorn Helgaas wrote:
> >
> > On Tue, Mar 10, 2020 at 08:26:27PM +0100, Karol Herbst wrote:
> > > Fixes the infamous 'runtime PM' bug many users are facing on Laptops with
annoying issue for user having to choose between a
crashing kernel or higher power consumption of their Laptops.
Signed-off-by: Karol Herbst
Cc: Bjorn Helgaas
Cc: Lyude Paul
Cc: Rafael J. Wysocki
Cc: Mika Westerberg
Cc: linux-...@vger.kernel.org
Cc: linux...@vger.kernel.org
Cc:
just noticed that the patch title should be changed..
drm/nouveau: prevent putting nvidia GPUs into lower device states on
certain intel bridges
or
drm/nouveau: workaround runpm fail by disabling PCI power management
on certain intel bridges
On Tue, Mar 24, 2020 at 9:29 PM Karol Herbst wrote
es.
Applies to 5.5 and 5..4 as well.
And both commits should probably get applied to older trees as well.
but I didn't get to it yet to see if they apply and work as expected.
On Wed, Apr 15, 2020 at 1:36 PM Sasha Levin wrote:
>
> From: Karol Her
On Wed, Sep 16, 2020 at 9:47 PM Jeremy Cline wrote:
>
> The temp_get() function currently returns negative error numbers or a
> temperature. However, the thermal sensors can (in theory) measure
> negative temperatures. Some implementations of temp_get() correctly
> clamp negative temperature readi
On Wed, Sep 16, 2020 at 10:01 PM Karol Herbst wrote:
>
> On Wed, Sep 16, 2020 at 9:47 PM Jeremy Cline wrote:
> >
> > The temp_get() function currently returns negative error numbers or a
> > temperature. However, the thermal sensors can (in theory) measure
> &g
On Thu, Sep 17, 2020 at 4:11 PM Jeremy Cline wrote:
>
> On Wed, Sep 16, 2020 at 10:03:22PM +0200, Karol Herbst wrote:
> > On Wed, Sep 16, 2020 at 10:01 PM Karol Herbst wrote:
> > >
> > > On Wed, Sep 16, 2020 at 9:47 PM Jeremy Cline wrote:
> > > >
Hi everybody,
I think it's time to finally move our wiki from the old infrastructure
over to gitlab pages.
This comes with several benefits:
* full control through git over the ikiwiki pipeline (setup files,
plugins, system packages, ...)
* random users are able to create MRs against the wiki as
On Fri, Sep 25, 2020 at 11:27 PM Karol Herbst wrote:
>
> Hi everybody,
>
> I think it's time to finally move our wiki from the old infrastructure
> over to gitlab pages.
>
> This comes with several benefits:
> * full control through git over the ikiwiki pipeline (s
On Thu, Oct 1, 2020 at 7:53 PM Sam Ravnborg wrote:
>
> Hi Karol.
>
> On Thu, Oct 01, 2020 at 01:36:52PM +0200, Karol Herbst wrote:
> > On Fri, Sep 25, 2020 at 11:27 PM Karol Herbst wrote:
> > >
> > > Hi everybody,
> > >
> > > I think it'
other drivers seems to do something similar
Signed-off-by: Karol Herbst
Cc: dri-devel
Cc: Dave Airlie
Cc: sta...@vger.kernel.org
---
drivers/gpu/drm/nouveau/nouveau_mem.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/nouveau/nouveau_mem.c
b/drivers/gpu/drm/nouveau
Previously the code relied on device->pri to be NULL and to fail probing
later. We really should just return an error inside nvkm_device_ctor for
unsupported GPUs.
Fixes: 24d5ff40a732 ("drm/nouveau/device: rework mmio mapping code to get rid
of second map")
Signed-off-by: Karol Her
On Tue, Sep 1, 2020 at 9:13 AM Daniel Vetter wrote:
>
> On Tue, Aug 18, 2020 at 04:37:51PM +0200, Thierry Reding wrote:
> > On Fri, Aug 14, 2020 at 07:25:17PM +0200, Daniel Vetter wrote:
> > > On Fri, Aug 14, 2020 at 7:17 PM Daniel Stone wrote:
> > > >
> > > > Hi,
> > > >
> > > > On Fri, 14 Aug 2
On Wed, Sep 9, 2020 at 6:06 AM Ben Skeggs wrote:
>
> On Thu, 13 Aug 2020 at 06:50, Jeremy Cline wrote:
> >
> > Commit d32656373857 ("drm/nouveau/therm/gp100: initial implementation of
> > new gp1xx temperature sensor") added support for reading finer-grain
> > temperatures, but continued to repor
Reviewed-by: Karol Herbst
On Mon, Aug 3, 2020 at 5:46 AM Jing Xiangfeng wrote:
>
> This patch performs the following changes:
> 1. remove a redundant parentheses around the nvkm_acr_lsfw_add() calls
> 2. do assignment before this if condition, it is more readable
>
> S
Hi James,
I don't know if you knew, but on the Jetson nano we had the issue for
quite some time, that GLX/EGL through mesa on X was broken due to some
fix in mesa related to modifiers.
And I was wondering if the overall state just caused the issue we saw
here and wanted to know what branches/patc
D_INVALID... anyway, it seems like with your patches applied it's
now way easier to debug and figure out what's going wrong, so maybe I
can figure it out now :)
> Thanks,
> -James
>
> On 8/4/20 1:58 AM, Karol Herbst wrote:
> > Hi James,
> >
> > I don't
On Wed, Aug 12, 2020 at 12:27 PM Karol Herbst wrote:
>
> On Wed, Aug 12, 2020 at 2:19 AM James Jones wrote:
> >
> > Sorry for the slow reply here as well. I've been in the process of
> > rebasing and reworking the userspace patches. I'm not clear my change
On Wed, Aug 12, 2020 at 12:43 PM Karol Herbst wrote:
>
> On Wed, Aug 12, 2020 at 12:27 PM Karol Herbst wrote:
> >
> > On Wed, Aug 12, 2020 at 2:19 AM James Jones wrote:
> > >
> > > Sorry for the slow reply here as well. I've been in the process of
&
On Wed, Aug 12, 2020 at 5:05 PM Thierry Reding wrote:
>
> On Wed, Aug 12, 2020 at 12:43:17PM +0200, Karol Herbst wrote:
> > On Wed, Aug 12, 2020 at 12:27 PM Karol Herbst wrote:
> > >
> > > On Wed, Aug 12, 2020 at 2:19 AM James Jones wrote:
> > > >
>
On Wed, Aug 12, 2020 at 5:20 PM Karol Herbst wrote:
>
> On Wed, Aug 12, 2020 at 5:05 PM Thierry Reding
> wrote:
> >
> > On Wed, Aug 12, 2020 at 12:43:17PM +0200, Karol Herbst wrote:
> > > On Wed, Aug 12, 2020 at 12:27 PM Karol Herbst wrote:
> > > >
>
On Wed, Aug 12, 2020 at 7:03 PM James Jones wrote:
>
> On 8/12/20 5:37 AM, Ilia Mirkin wrote:
> > On Wed, Aug 12, 2020 at 8:24 AM Karol Herbst wrote:
> >>
> >> On Wed, Aug 12, 2020 at 12:43 PM Karol Herbst wrote:
> >>>
> >>> On Wed, Aug 12,
in case you all were wondering, it works on xorg-server git because of
this commit:
https://gitlab.freedesktop.org/xorg/xserver/-/commit/9b8999411033c9473cd68e92e4690a91aecf5b95
On Wed, Aug 12, 2020 at 8:25 PM James Jones wrote:
>
> On 8/12/20 10:40 AM, Alyssa Rosenzweig wrote:
> >> ...and in me
Reviewed-by: Karol Herbst
On Wed, Aug 12, 2020 at 10:50 PM Jeremy Cline wrote:
>
> Commit d32656373857 ("drm/nouveau/therm/gp100: initial implementation of
> new gp1xx temperature sensor") added support for reading finer-grain
> temperatures, but continued to report te
you think?
On Wed, Aug 12, 2020 at 8:51 PM Karol Herbst wrote:
>
> in case you all were wondering, it works on xorg-server git because of
> this commit:
> https://gitlab.freedesktop.org/xorg/xserver/-/commit/9b8999411033c9473cd68e92e4690a91aecf5b95
>
> On Wed, Aug 12, 2
btw, I just noticed that wayland with gnome-shell is totally busted.
With this MR it at least displays something, but without it doesn't
work at all.
On Thu, Aug 13, 2020 at 3:00 PM Karol Herbst wrote:
>
> At least for now I've created an MR to revert the change:
> https://git
gnome :)
On Thu, Aug 13, 2020 at 5:39 PM Karol Herbst wrote:
>
> btw, I just noticed that wayland with gnome-shell is totally busted.
> With this MR it at least displays something, but without it doesn't
> work at all.
>
> On Thu, Aug 13, 2020 at 3:00 PM Karol Herbst wrote
modifier support by
default at this point.
> Thanks,
> -James
>
> On 8/13/20 10:19 AM, Karol Herbst wrote:
> > another thing: with gsettings set org.gnome.mutter
> > experimental-features '["kms-modifiers"]' it all just works out of the
> > box with
On Fri, Aug 14, 2020 at 3:40 PM Thierry Reding wrote:
>
> On Wed, Aug 12, 2020 at 10:03:46AM -0700, James Jones wrote:
> > On 8/12/20 5:37 AM, Ilia Mirkin wrote:
> > > On Wed, Aug 12, 2020 at 8:24 AM Karol Herbst wrote:
> > > >
> > > >
On Fri, Aug 14, 2020 at 3:57 PM Thierry Reding wrote:
>
> On Thu, Aug 13, 2020 at 07:48:39PM +0200, Karol Herbst wrote:
> > On Thu, Aug 13, 2020 at 7:45 PM James Jones wrote:
> > >
> > > I'll defer to Thierry, but I think that may be by design. Tegra forma
On Fri, Aug 14, 2020 at 4:05 PM Thierry Reding wrote:
>
> On Thu, Aug 13, 2020 at 10:45:34AM -0700, James Jones wrote:
> > I'll defer to Thierry, but I think that may be by design. Tegra format
> > modifiers were added to get things like this working in the first place,
> > right? It's not a reg
On Fri, Aug 14, 2020 at 4:08 PM Thierry Reding wrote:
>
> On Thu, Aug 13, 2020 at 05:39:39PM +0200, Karol Herbst wrote:
> > btw, I just noticed that wayland with gnome-shell is totally busted.
> > With this MR it at least displays something, but without it doesn't
> >
On Fri, Aug 14, 2020 at 5:35 PM Thierry Reding wrote:
>
> On Fri, Aug 14, 2020 at 04:44:43PM +0200, Karol Herbst wrote:
> > On Fri, Aug 14, 2020 at 4:05 PM Thierry Reding
> > wrote:
> > >
> > > On Thu, Aug 13, 2020 at 10:45:34AM -0700, James Jones wrote:
On Fri, Aug 14, 2020 at 5:24 PM Thierry Reding wrote:
>
> On Fri, Aug 14, 2020 at 04:45:39PM +0200, Karol Herbst wrote:
> > On Fri, Aug 14, 2020 at 4:08 PM Thierry Reding
> > wrote:
> > >
> > > On Thu, Aug 13, 2020 at 05:39:39PM +0200, Karol Herbst wro
On Fri, Aug 14, 2020 at 6:06 PM Thierry Reding wrote:
>
> On Fri, Aug 14, 2020 at 05:40:34PM +0200, Karol Herbst wrote:
> > On Fri, Aug 14, 2020 at 5:35 PM Thierry Reding
> > wrote:
> > >
> > > On Fri, Aug 14, 2020 at 04:44:43PM +0200, Karol Herbst wrote:
>
Hi Colin,
thanks for pointing this out, but I am quite sure this continue
statement won't ever be hit, ever.
check the nvkm_iccsense_create_sensor function. A sensor object will
only be created for one of those three types and others don't exist.
I've just added that default statement to shut GCC
we already have that included in 4.10
2016-12-12 12:26 GMT+01:00 Chris Chiu :
> Nouveau driver shows unknown chipset (136000a1) for GTX 1060, so it
> only gives VGA resolution on screen. Use the same chipset as nv134
> then it shows FullHD. This commit copies fields from nv134_chipset
> to nv136_c
> >
> > Generated by: scripts/coccinelle/misc/semicolon.cocci
> >
> > CC: Martin Peres
> > Signed-off-by: Fengguang Wu
> Signed-off-by: Martin Peres
Signed-off-by: Karol Herbst
fe this check is probably not required"
> > and kfreeaddr.cocci by Julia Lawall.
> >
> > Generated by: scripts/coccinelle/free/ifnullfree.cocci
> >
> > CC: Karol Herbst
> > Signed-off-by: Fengguang Wu
> Signed-off-by: Martin Peres
Signed-off-by: Karol Herbst
why the nouveau_is_rpm_worker stuff?
On Sat, Nov 17, 2018 at 2:50 AM Lyude Paul wrote:
>
> Now that we have ->pre_transfer() and ->post_transfer() for DP AUX
> channel devices, we can implement these hooks in order to ensure that
> the GPU is actually woken up before AUX transactions happen. This
Patches 1 and 5 are Acked-by: Karol Herbst
Patches 2-4 are Reviewed-by: Karol Herbst
On Sat, Nov 17, 2018 at 1:21 AM Lyude Paul wrote:
>
> So we don't ever have to worry about drivers touching drm_dp_mst_port
> structs without verifying them and crashing again.
>
> Lyu
Reviewed-by: Karol Herbst
On Tue, Aug 7, 2018 at 10:39 PM, Lyude Paul wrote:
> It's not necessary to call these before we call nouveau_do_suspend().
> Ideally; we shouldn't have to call this at all here, but getting that to
> work will take a bit more effort. So for the ti
Reviewed-by: Karol Herbst
On Tue, Aug 7, 2018 at 10:39 PM, Lyude Paul wrote:
> Currently, it appears that nouveau_do_suspend() forgets to roll back
> suspending fbcon and suspending the device LEDs. We also currently skip
> the entire rollback process if nouveau_display_suspend() fails
Reviewed-by: Karol Herbst
On Tue, Aug 7, 2018 at 10:39 PM, Lyude Paul wrote:
> Otherwise, how will we roll everything back?
>
> Signed-off-by: Lyude Paul
> Cc: sta...@vger.kernel.org
> Cc: Lukas Wunner
> Cc: Karol Herbst
> ---
> drivers/gpu/drm/nouveau/nouveau
Reviewed-by: Karol Herbst
On Tue, Aug 7, 2018 at 10:39 PM, Lyude Paul wrote:
> It's true we can't resume the device from poll workers in
> nouveau_connector_detect(). We can however, prevent the autosuspend
> timer from elapsing immediately if it hasn't already witho
> hotplug handlers using pm_runtime_get_noresume() and mark the device as
> busy once we're finished.
>
> Signed-off-by: Lyude Paul
> Cc: sta...@vger.kernel.org
> Cc: Lukas Wunner
> Cc: Karol Herbst
> ---
> drivers/gpu/drm/nouveau/nouveau_connector.c | 8
>
Patches 1-5 are Acked-by: Karol Herbst
On Tue, Aug 7, 2018 at 10:39 PM, Lyude Paul wrote:
> Again, this doesn't do anything. drm_kms_helper_poll_enable() will have
> already been called in nouveau_display_init()
>
> Signed-off-by: Lyude Paul
> Cc: Lukas Wunner
> Cc: Ka
Patches 1-5 are Reviewed-by: Karol Herbst
I think it might be worth to test those patches on a system without
any backlight devices just to verify we don't break things, but the
code looked good already, so maybe we don't really need to test.
On Thu, Aug 23, 2018 at 3:21 AM, Lyude P
On Thu, May 24, 2018 at 7:24 PM, Kees Cook wrote:
> In the quest to remove all stack VLA usage from the kernel[1], this
> allocates the working buffers before starting the writing so it won't
> abort in the middle. This needs an initial walk of the lists to figure
> out how large the buffer should
On Fri, Jun 22, 2018 at 11:34 PM, Kees Cook wrote:
> On Fri, Jun 22, 2018 at 10:50 AM, Karol Herbst wrote:
>> On Thu, May 24, 2018 at 7:24 PM, Kees Cook wrote:
>>> In the quest to remove all stack VLA usage from the kernel[1], this
>>> allocates the working buffers
this was already debugged and there is no point in searching inside
the Firmware. It's not a firmware bug or anything.
The proper fix is to do something inside Nouveau so that we don't
upset the device and being able to runtime resume it again.
The initial thing we do inside Nouveau to cause thos
On Thu, Nov 29, 2018 at 2:29 AM Michael S. Tsirkin wrote:
>
> On Thu, Nov 29, 2018 at 12:21:31AM +0100, Karol Herbst wrote:
> > this was already debugged and there is no point in searching inside
> > the Firmware. It's not a firmware bug or anything.
> >
> >
a machine running windows directly.
On Thu, Nov 29, 2018 at 6:12 PM Michael S. Tsirkin wrote:
>
> On Thu, Nov 29, 2018 at 11:53:53AM +0100, Karol Herbst wrote:
> > On Thu, Nov 29, 2018 at 2:29 AM Michael S. Tsirkin wrote:
> > >
> > > On Thu, Nov 29, 2018 at 12:21:31AM +01
Both patches are Reviewed-by: Karol Herbst
On Wed, Sep 19, 2018 at 7:13 PM, Lyude Paul wrote:
> This is a small patch series that adds a strap_peek file into our
> debugfs, and sets the size of the vbios.rom debugfs file so that nvbios
> can easily be used to parse the vbios even o
Reviewed-by: Karol Herbst
On Fri, Sep 14, 2018 at 10:44 PM, Lyude Paul wrote:
> While we currently grab a runtime PM ref in nouveau's normal connector
> detection code, we apparently don't do this for MST. This means if we're
> in a scenario where the GPU is suspended a
Reviewed-by: Karol Herbst
On Tue, Jul 17, 2018 at 1:59 AM, Lyude Paul wrote:
> While the GPU is guaranteed to be on when a hotplug has been received,
> the same assertion does not hold true if a connector probe has been
> started by userspace without having had received a sysfs
Reviewed-by: Karol Herbst
On Tue, Jul 17, 2018 at 9:21 AM, Lukas Wunner wrote:
> On Mon, Jul 16, 2018 at 07:59:26PM -0400, Lyude Paul wrote:
>> --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
>> +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
>> @@ -2012,10 +2012,18 @@ nv50_di
wrote:
> The i2c bus can be both accessed by DRM itself, along with any of it's
> devnodes (/sys/class/i2c). So, we need to make sure that all codepaths
> using the i2c bus keep the GPU resumed.
>
> Signed-off-by: Lyude Paul
> Cc: Karol Herbst
> Cc: sta...@vger.kern
isn't there like 1 space missing for each change? Or maybe my client
is messed up, but please align it with the first letter of the
parameters not the "(".
With that fixed: Reviewed-by: Karol Herbst
On Tue, Jul 17, 2018 at 2:07 AM, Lyude Paul wrote:
> Signed-
Reviewed-by: Karol Herbst
2018-07-12 19:13 GMT+02:00 Lyude Paul :
> This makes debugging with DP tracing a lot harder to interpret, so name
> each i2c based off the name of the encoder that it's for
>
> Signed-off-by: Lyude Paul
> ---
> drivers/gpu/drm/nouveau/d
On Tue, Jul 17, 2018 at 1:54 PM, Ben Skeggs wrote:
> On Tue, 17 Jul 2018 at 20:18, Karol Herbst wrote:
>>
>> mhh, we shouldn't call to Linux APIs from within of nvkm. Rather gaurd
>> the Linux glue code to the i2c stuff instead, but this is all done
>> from inside
Fixes: b88baab82871 ("drm/nouveau: implement new VM_BIND uAPI")
Cc: Danilo Krummrich
Cc: # v6.6+
Signed-off-by: Karol Herbst
Reviewed-by: Lyude Paul
Reviewed-by: Danilo Krummrich
Link:
https://patchwork.freedesktop.org/patch/msgid/20240304183157.1587152-1-kher...@redhat.com
---
drivers/
Those are already de-facto UAPI, so let's just move it into the uapi
header.
Signed-off-by: Karol Herbst
Reviewed-by: Lyude Paul
Reviewed-by: Danilo Krummrich
Link:
https://patchwork.freedesktop.org/patch/msgid/20240304183157.1587152-2-kher...@redhat.com
---
drivers/gpu/drm/no
/255
Fixes: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX
interrupts")
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/nouveau/nvkm/engine/disp/uconn.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/n
On Thu, Nov 2, 2023 at 8:06 PM Alex Deucher wrote:
>
> On Thu, Nov 2, 2023 at 3:00 PM Hamza Mahfooz wrote:
> >
> > On 11/1/23 17:36, Alex Deucher wrote:
> > > On Wed, Nov 1, 2023 at 5:01 PM Hamza Mahfooz
> > > wrote:
> > >>
> > >> Without this fix the 5120x1440@240 timing of these monitors
> >
Fixes: b88baab82871 ("drm/nouveau: implement new VM_BIND uAPI")
Cc: Danilo Krummrich
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/nouveau/nouveau_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c
b/drivers/gpu/drm/nouveau/nouv
Those are already de-facto UAPI, so let's just move it into the uapi
header.
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/nouveau/nouveau_abi16.c | 20 +++-
drivers/gpu/drm/nouveau/nouveau_abi16.h | 12
include/uapi/drm/nouveau_drm.h
On Wed, Oct 11, 2017 at 4:18 PM, Ilia Mirkin wrote:
> On Wed, Oct 11, 2017 at 9:46 AM, Bjorn Helgaas wrote:
>> On Wed, Oct 11, 2017 at 08:54:05AM -0400, Ilia Mirkin wrote:
>>> On Wed, Oct 11, 2017 at 7:47 AM, Bjorn Helgaas wrote:
>>> > /* do magic */
>>> > nvif_mask(&device->object, 0x088488
301 - 400 of 418 matches
Mail list logo
