y visible, but the declaration says about the parameters
> in the middle:
> enum nv50_disp_interlock_type,
> u32 interlock_data,
> u32 heads,
>
> While the definition states differently:
> u32 heads,
> enum nv50_disp_interlock_type interlock_type,
> u32 interlock_data,
>
Reviewed-by: Karol Herbst
will push in a moment
On Thu, Jan 12, 2023 at 11:49 PM Kees Cook wrote:
>
> On Mon, Jan 09, 2023 at 07:39:30PM -0600, Gustavo A. R. Silva wrote:
> > Zero-length arrays are deprecated[1] and we are moving towards
> > adopting C99 flexible-array m
;
> > [1] https://github.com/KSPP/linux/issues/78
> >
> > Cc: Ben Skeggs
> > Cc: Karol Herbst
> > Cc: Lyude Paul
> > Cc: David Airlie
> > Cc: Daniel Vetter
> > Cc: Gourav Samaiya
> > Cc: "Gustavo A. R. Silva"
> > Cc: dri-dev
On Mon, Jan 16, 2023 at 5:24 PM Karol Herbst wrote:
>
> On Wed, Jan 4, 2023 at 1:52 AM Gustavo A. R. Silva
> wrote:
> >
> > On Tue, Jan 03, 2023 at 03:48:36PM -0800, Kees Cook wrote:
> > > Zero-length arrays are deprecated[1] and are being replaced with
> > &g
On Tue, Jan 17, 2023 at 5:02 AM Stephen Rothwell wrote:
>
> Hi all,
>
> The following commit is also in the drm-misc tree as a different commit
> (but the same patch):
>
> 06b19f46455c ("drm/nouveau/fb/ga102: Replace zero-length array of trailing
> structs with flex-array")
>
which branch? Bec
hanged, 244 insertions(+), 137 deletions(-)
>
> And the get_maintainers.pl rationale was:
>
> Ben Skeggs (supporter:DRM DRIVER FOR NVIDIA
> GEFORCE/QUADRO
> GPUS,commit_signer:1/1=100%,commit_signer:6/16=38%,authored:4/16=25%,added_lines:23/124=19%,removed_lines:36/152=24%)
> K
On Fri, Nov 11, 2022 at 9:16 PM Kees Cook wrote:
>
> On Fri, Nov 11, 2022 at 09:06:54PM +0100, Karol Herbst wrote:
> > On Fri, Nov 11, 2022 at 8:21 PM Kees Cook wrote:
> > >
> > > On Fri, Nov 11, 2022 at 11:13:17AM +0200, Jani Nikula wrote:
> > > >
On Tue, Nov 1, 2022 at 3:12 AM Bagas Sanjaya wrote:
>
> On 10/31/22 23:32, antoniospg wrote:
> > Summary:
> >
> > * Add support to turn on/off backlight when changing values in bl_power
> > file. This is achieved by using function backlight_get_brightness()
> > in nva3_set_intensity to get cur
cklight_get_brightness(bd);
> + if (val)
> + val = (val * div) / 100;
> +
> if (div) {
> nvif_wr32(device, NV50_PDISP_SOR_PWM_CTL(or),
> val |
> --
> 2.25.1
>
Reviewed-by: Karol Herbst
btw, i'll fix up the name with the one from the Email From field, so
you won't have to send it out again.
ready using
> > dma_resv_wait_timeout() correctly.
> >
> > Fixes: 41d351f29528 ("drm/nouveau: stop using ttm_bo_wait")
> > Reported-by: Tanmay Bhushan <0070472...@gmail.com>
> > Link:
> > https://lore.kernel.org/lkml/20230119225351.71657-1-0070472...@gmail.co
On Sun, Apr 16, 2023 at 11:30 AM Markus Elfring wrote:
>
> Date: Sun, 16 Apr 2023 11:22:23 +0200
>
> Several update suggestions were taken into account
> from static source code analysis.
>
Reviewed-by: Karol Herbst
> Markus Elfring (9):
> debugfs: Move an express
> dpcd[DP_RECEIVER_CAP_SIZE],
> >|
> > ~~~^~
> >
> > Fixes: 813443721331 ("drm/nouveau/disp: move DP link config into acquire")
> > Cc: Ben Skeggs
> > Cc: Lyude Paul
> >
On Sun, Apr 23, 2023 at 10:24 PM Kees Cook wrote:
>
> On April 23, 2023 10:36:24 AM PDT, Linus Torvalds
> wrote:
> >Kees,
> > I made the mistake of upgrading my M2 Macbook Air to Fedora-38, and
> >in the process I got gcc-13 which is not WERROR-clean because we only
> >limited the 'array-bounds
On Fri, Apr 28, 2023 at 12:46 AM Lyude Paul wrote:
>
> Hey Linus, Kees. Responses below
>
> On Sun, 2023-04-23 at 13:23 -0700, Kees Cook wrote:
> > On April 23, 2023 10:36:24 AM PDT, Linus Torvalds
> > wrote:
> > > Kees,
> > > I made the mistake of upgrading my M2 Macbook Air to Fedora-38, and
On Fri, Apr 28, 2023 at 1:27 AM Lyude Paul wrote:
>
> On Fri, 2023-04-28 at 00:50 +0200, Karol Herbst wrote:
> > On Fri, Apr 28, 2023 at 12:46 AM Lyude Paul wrote:
> > >
> > > Hey Linus, Kees. Responses below
> > >
> > > On Sun, 2023-04-23 at 1
This allows us to advertise more modes especially on HDR displays.
Fixes using 4K@60 modes on my TV and main display both using a HDMI to DP
adapter. Also fixes similiar issues for users running into this.
Cc: sta...@vger.kernel.org # 5.10+
Signed-off-by: Karol Herbst
---
drivers/gpu/drm
On Fri, Mar 31, 2023 at 12:39 AM Karol Herbst wrote:
>
> This allows us to advertise more modes especially on HDR displays.
>
> Fixes using 4K@60 modes on my TV and main display both using a HDMI to DP
> adapter. Also fixes similiar issues for users running into th
Closes: https://gitlab.freedesktop.org/drm/nouveau/-/issues/203
Fixes: 5728d064190e1 ("drm/nouveau/fb: handle sysmem flush page from common
code")
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf108.c | 1 +
drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk104.c | 1
Reviewed-by: Karol Herbst
On Thu, Dec 29, 2022 at 4:52 PM Ben Dooks wrote:
>
> Make ga100_mc_device static as it isn't exported, to
> fix the following sparse warning:
>
> drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c:51:1: warning: symbol
> 'ga100_mc_device
Reviewed-by: Karol Herbst
On Sat, Sep 24, 2022 at 10:00 AM ruanjinjie wrote:
>
> The symbol is not used outside of the file, so mark it static.
>
> Fixes the following warning:
>
> ./drivers/gpu/drm/nouveau/nvkm/engine/disp/gv100.c:591:1: warning:
> symbol 'gv100_di
On Thu, Mar 9, 2023 at 9:24 PM Faith Ekstrand
wrote:
>
> On Thu, 2023-03-09 at 15:04 +0900, Asahi Lina wrote:
> > On 08/03/2023 02.34, Björn Roy Baron wrote:
> > > > +// SAFETY: This is just the ioctl
> > > > argument, which hopefully has the right type
> > > > +
on't know when it's the next time it
will be pushed upwards, but it should get there eventually. And
because it also contains a Fixes tag it will be backported to older
branches as well.
> Chris
>
> On 20/02/2023 22:16, Ben Skeggs wrote:
> > On Mon, 20 Feb 2023 at 21:27, Kar
nouveau changes up to here are:
Reviewed-by: Karol Herbst
On Fri, Mar 17, 2023 at 9:23 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/dispnv04/crtc.c:453: warning: This comment starts
> with '/**', but isn'
mistake not using this function.
Ben, is it safe to remove it? The code seems to be slightly different
things, but also looks like it needs to be rewritten a little anyway.
> Cc: Ben Skeggs
> Cc: Karol Herbst
> Cc: Lyude Paul
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc:
agree with the code being always broken as
`dma_fence_is_signaled_locked` specifies: "This function requires
&dma_fence.lock to be held."
> +
> + if (ret == true)
> + dma_fence_put(fence);
> + return ret;
> }
>
> static void
> --
> 2.40.1
>
regardless of the patch fixing the issue users have seen:
Reviewed-by: Karol Herbst
On Thu, Jun 15, 2023 at 1:19 PM Christian König
wrote:
>
> Am 13.06.23 um 16:18 schrieb Karol Herbst:
> > On Tue, Jun 13, 2023 at 3:59 PM Christian König
> > wrote:
> >> Am 13.06.23 um 15:05 schrieb Karol Herbst:
> >>> On Mon, Dec 5, 2022 at 2:40 PM C
Cc: Ben Skeggs
Cc: Lyude Paul
Fixes: f530bc60a30b ("drm/nouveau/disp: move HDMI config into acquire +
infoframe methods")
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/nouveau/nvkm/engine/disp/gt215.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drive
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 +-
drivers/gpu/drm/nouveau/nouveau_connector.c | 2 +-
drivers/gpu/drm/nouveau/nouveau_dp.c| 3 +--
drivers/gpu/drm/nouveau/nouveau_encoder.h | 3 +--
4 files changed, 4 insertions(+), 6 deletions(-)
diff
one of my Tesla GPUs with a connected 4K display.
Link: https://gitlab.freedesktop.org/drm/nouveau/-/issues/199
Cc: Ben Skeggs
Cc: Lyude Paul
Cc: sta...@vger.kernel.org # v6.1+
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/nouveau/nouveau_connector.c | 19 +++
1 file changed
Cc: Ben Skeggs
Cc: Lyude Paul
Fixes: f530bc60a30b ("drm/nouveau/disp: move HDMI config into acquire +
infoframe methods")
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/nouveau/nvkm/e
On Wed, May 10, 2023 at 9:59 AM Jonas Ådahl wrote:
>
> On Tue, May 09, 2023 at 08:22:30PM +, Simon Ser wrote:
> > On Tuesday, May 9th, 2023 at 21:53, Dave Airlie wrote:
> >
> > > There are also other vendor side effects to having this in userspace.
> > >
> > > Will the library have a loader?
/201
Fixes: 4a16dd9d18a0 ("drm/nouveau/kms: switch to drm fbdev helpers")
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/nouveau/nouveau_chan.c | 1 +
drivers/gpu/drm/nouveau/nouveau_chan.h | 1 +
drivers/gpu/drm/nouveau/nouveau_drm.c | 19 ---
3 files changed, 18
Reviewed-by: Karol Herbst
will merge soon
On Mon, Apr 17, 2023 at 11:03 PM Arnd Bergmann wrote:
>
> From: Arnd Bergmann
>
> nv50_display_create() is declared in another header, along with
> a couple of declarations that are now outdated:
>
> drivers/gpu/drm/nouveau/d
Reviewed-by: Karol Herbst
On Wed, May 17, 2023 at 3:31 PM Tom Rix wrote:
>
> smatch reports
> drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c:49:1: warning: symbol
> 'ga102_gsps' was not declared. Should it be static?
>
> This variable is only used in its defining
This fixes a NULL pointer access inside nvkm_acr_oneinit in case necessary
firmware files couldn't be loaded.
Closes: https://gitlab.freedesktop.org/drm/nouveau/-/issues/212
Fixes: 4b569ded09fd ("drm/nouveau/acr/ga102: initial support")
Signed-off-by: Karol Herbst
---
drivers/
On Mon, May 22, 2023 at 10:18 PM Karol Herbst wrote:
>
> This fixes a NULL pointer access inside nvkm_acr_oneinit in case necessary
> firmware files couldn't be loaded.
>
> Closes: https://gitlab.freedesktop.org/drm/nouveau/-/issues/212
> Fixes: 4b569ded09fd ("dr
I wouldn't be surprised if 4a16dd9d18a0 is the culprit and that it was
always broken like this with drm fbdev. Anyway, the logs don't indicate we
are actually doing anything wrong, It's just that the tty handling is a
little bonkers as always.
On Thu, May 25, 2023 at 1:37 PM Bagas Sanjaya wrote:
On Thu, Jul 27, 2023 at 11:57 PM Lyude Paul wrote:
>
> On Sun, 2023-07-09 at 01:42 +0200, Karol Herbst wrote:
> > On Fri, Jul 7, 2023 at 11:58 PM Lyude Paul wrote:
> > >
> > > Currently we use the drm_dp_dpcd_read_caps() helper in the DRM side of
> > > no
On Fri, Jul 28, 2023 at 1:11 AM Karol Herbst wrote:
>
> On Thu, Jul 27, 2023 at 11:57 PM Lyude Paul wrote:
> >
> > On Sun, 2023-07-09 at 01:42 +0200, Karol Herbst wrote:
> > > On Fri, Jul 7, 2023 at 11:58 PM Lyude Paul wrote:
> > > >
> > > >
)
> +#define DRM_IOCTL_NOUVEAU_CHANNEL_ALLOC DRM_IOWR(DRM_COMMAND_BASE +
> DRM_NOUVEAU_CHANNEL_ALLOC, struct drm_nouveau_channel_alloc)
> +#define DRM_IOCTL_NOUVEAU_CHANNEL_FREE DRM_IOW (DRM_COMMAND_BASE +
> DRM_NOUVEAU_CHANNEL_FREE, struct drm_nouveau_channel_free)
> +
> #define DRM_IOCTL_NOUVEAU_SVM_INIT DRM_IOWR(DRM_COMMAND_BASE +
> DRM_NOUVEAU_SVM_INIT, struct drm_nouveau_svm_init)
> #define DRM_IOCTL_NOUVEAU_SVM_BIND DRM_IOWR(DRM_COMMAND_BASE +
> DRM_NOUVEAU_SVM_BIND, struct drm_nouveau_svm_bind)
>
> --
> 2.41.0
>
Reviewed-by: Karol Herbst
On Tue, Aug 1, 2023 at 5:15 PM Faith Ekstrand wrote:
> On Tue, Aug 1, 2023 at 4:37 AM Karol Herbst wrote:
>
>> On Mon, Jul 31, 2023 at 9:16 PM Dave Airlie wrote:
>> >
>> > From: Dave Airlie
>> >
>> > nouveau > 10 years ago had a plan for new
t; - return gk20a_gr_load_net(gr, "gr/", "sw_veid_bundle_init", ver,
> tu102_gr_av_to_init_veid,
> -&gr->bundle_veid);
> -}
> -
> static const struct gf100_gr_fwif
> tu102_gr_fwif[] = {
> { 0, gm200_gr_load, &tu102_gr, &gp108_gr_fecs_acr,
> &gp108_gr_gpccs_acr },
> --
> 2.39.2
>
Reviewed-by: Karol Herbst
Will push to drm-misc in a sec
On Fri, Aug 4, 2023 at 2:02 PM Thorsten Leemhuis
wrote:
>
> Hi!
>
> On 02.08.23 23:28, Olaf Skibbe wrote:
> > Dear Maintainers,
> >
> > Hereby I would like to report an apparent bug in the nouveau driver in
> > linux/6.1.38-2.
>
> Thx for your report. Maybe your problem is caused by a incomplete
>
On Fri, Aug 4, 2023 at 2:48 PM Olaf Skibbe wrote:
>
> On Fri, 4 Aug 2023 at 14:15, Karol Herbst wrote:
>
> > mind retrying with only fb725beca62d and 62aecf23f3d1 reverted?
>
> I will do this later this day (takes some time, it is a slow machine).
>
> > Would be weir
On Fri, Aug 4, 2023 at 8:10 PM Olaf Skibbe wrote:
>
> Dear all,
>
> On Fri, 4 Aug 2023 at 14:15, Karol Herbst wrote:
>
> >>> 62aecf23f3d1 drm/nouveau: add nv_encoder pointer check for NULL
> >>> fb725beca62d drm/nouveau/dp: check for NULL nv_connector->
Paul
Closes: https://gitlab.freedesktop.org/drm/nouveau/-/issues/238
Closes: https://gitlab.freedesktop.org/drm/nouveau/-/issues/245
Fixes: 20a2ce87fbaf8 ("drm/nouveau/dp: check for NULL
nv_connector->native_mode")
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/nouveau/nouveau_co
nouveau_fence_emit(fence, drm->dmem->migrate.chan);
> migrate_vma_pages(args);
> nouveau_dmem_fence_done(&fence);
> nouveau_pfns_map(svmm, args->vma->vm_mm, args->start, pfns, i);
>
> base-commit: 82d750e9d2f5d0594c8f7057ce59127e701af781
> --
> 2.41.0
>
Reviewed-by: Karol Herbst
://gitlab.freedesktop.org/drm/nouveau/-/issues/201
Fixes: 4a16dd9d18a0 ("drm/nouveau/kms: switch to drm fbdev helpers")
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/nouveau/nouveau_chan.c | 1 +
drivers/gpu/drm/nouveau/nouveau_chan.h | 1 +
drivers/gpu/drm/nouveau/nouveau_drm.c | 20 +
c void nouveau_dsm_pci_probe(struct pci_dev *pdev,
> acpi_handle *dhandle_out
> int optimus_funcs;
> struct pci_dev *parent_pdev;
>
> + if (pdev->vendor != PCI_VENDOR_ID_NVIDIA)
> + return;
> +
> *has_pr3 = false;
> parent_pdev = pci_upstr
On Fri, May 26, 2023 at 5:21 PM Ilia Mirkin wrote:
>
> On Fri, May 26, 2023 at 5:11 AM Karol Herbst wrote:
> >
> > 1ba6113a90a0 removed a lot of the kernel GPU channel, but method 0x128
> > was important as otherwise the GPU spams us with `CACHE_ERROR` messages.
rm/nouveau/nvkm/subdev/bios/init.c:611: warning: expecting
> prototype for INIT_DONE(). Prototype was for init_done() instead
> [Snipped ~140 lines for brevity]
>
> Cc: Ben Skeggs
> Cc: Karol Herbst
> Cc: Lyude Paul
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: dr
: variable
> ‘loc’ set but not used [-Wunused-but-set-variable]
>
> Cc: Ben Skeggs
> Cc: Karol Herbst
> Cc: Lyude Paul
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: Gourav Samaiya
> Cc: dri-devel@lists.freedesktop.org
> Cc: nouv...@lists.freedesktop.org
> Signed-
c-guide/kernel-doc.rst
> drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:62: warning: This comment
> starts with '/**', but isn't a kernel-doc comment. Refer
> Documentation/doc-guide/kernel-doc.rst
>
> Cc: Ben Skeggs
> Cc: Karol Herbst
> Cc:
On Fri, Jun 9, 2023 at 10:18 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c:210:1: warning: no previous
> prototype for ‘tu102_gr_load’ [-Wmissing-prototypes]
>
> Cc: Ben Skeggs
> Cc: Karol
-guide/kernel-doc.rst
>
> Cc: Ben Skeggs
> Cc: Karol Herbst
> Cc: Lyude Paul
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: dri-devel@lists.freedesktop.org
> Cc: nouv...@lists.freedesktop.org
> Signed-off-by: Lee Jones
Reviewed-by: Karol Herbst
> ---
> drivers/
kernel-doc.rst
> drivers/gpu/drm/nouveau/dispnv04/crtc.c:629: warning: This comment starts
> with '/**', but isn't a kernel-doc comment. Refer
> Documentation/doc-guide/kernel-doc.rst
>
> Cc: Ben Skeggs
> Cc: Karol Herbst
> Cc: Lyude Paul
> Cc: David Airli
On Mon, Dec 5, 2022 at 2:40 PM Christian König wrote:
>
> Am 29.11.22 um 22:14 schrieb Felix Kuehling:
> > On 2022-11-25 05:21, Christian König wrote:
> >> Instead of a single worker going over the list of delete BOs in regular
> >> intervals use a per BO worker which blocks for the resv object an
On Tue, Jun 13, 2023 at 3:59 PM Christian König
wrote:
>
> Am 13.06.23 um 15:05 schrieb Karol Herbst:
> > On Mon, Dec 5, 2022 at 2:40 PM Christian König
> > wrote:
> >> Am 29.11.22 um 22:14 schrieb Felix Kuehling:
> >>> On 2022-11-25 05:21, Christian
et's do that.
>
> Signed-off-by: Lyude Paul
Reviewed-by: Karol Herbst
> ---
> drivers/gpu/drm/nouveau/dispnv50/disp.c | 8 ++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c
> b/drivers/gpu/drm/nouveau
On Sun, Aug 6, 2023 at 11:40 PM Borislav Petkov wrote:
>
> Hi folks,
>
> the patch in $Subject breaks booting here on one of my test boxes, see
> below.
>
> Reverting it ontop of -rc4 fixes the issue.
>
> Thx.
>
> [3.580535] ACPI: \_PR_.CP04: Found 4 idle states
> [3.585694] ACPI: \_PR_.CP
On Mon, Aug 7, 2023 at 5:05 PM Borislav Petkov wrote:
>
> On Mon, Aug 07, 2023 at 01:49:42PM +0200, Karol Herbst wrote:
> > in what way does it stop? Just not progressing? That would be kinda
> > concerning. Mind tracing with what arguments `nvkm_uevent_add` is
> > call
On Wed, Aug 9, 2023 at 11:22 AM Takashi Iwai wrote:
>
> On Tue, 08 Aug 2023 12:39:32 +0200,
> Karol Herbst wrote:
> >
> > On Mon, Aug 7, 2023 at 5:05 PM Borislav Petkov wrote:
> > >
> > > On Mon, Aug 07, 2023 at 01:49:42PM +0200, Karol Herbst wrote:
>
On Wed, Aug 9, 2023 at 1:46 PM Takashi Iwai wrote:
>
> On Wed, 09 Aug 2023 13:42:09 +0200,
> Karol Herbst wrote:
> >
> > On Wed, Aug 9, 2023 at 11:22 AM Takashi Iwai wrote:
> > >
> > > On Tue, 08 Aug 2023 12:39:32 +0200,
> > > Karol Herbst wrote
On Wed, Aug 9, 2023 at 4:04 PM Thorsten Leemhuis
wrote:
>
> On 09.08.23 15:13, Takashi Iwai wrote:
> >
> > If this can't be fixed quickly, I suppose it's safer to revert it from
> > 6.4.y for now. 6.5 is still being cooked, but 6.4.x is already in
> > wide deployment, hence the regression has to
On Wed, Aug 9, 2023 at 8:28 PM Karol Herbst wrote:
>
> On Wed, Aug 9, 2023 at 4:04 PM Thorsten Leemhuis
> wrote:
> >
> > On 09.08.23 15:13, Takashi Iwai wrote:
> > >
> > > If this can't be fixed quickly, I suppose it's safer to revert it from
>
On Wed, Aug 9, 2023 at 6:16 PM Takashi Iwai wrote:
>
> On Wed, 09 Aug 2023 16:46:38 +0200,
> Takashi Iwai wrote:
> >
> > On Wed, 09 Aug 2023 15:13:23 +0200,
> > Takashi Iwai wrote:
> > >
> > > On Wed, 09 Aug 2023 14:19:23 +0200,
> > > Karol
On Mon, Aug 14, 2023 at 2:48 PM Takashi Iwai wrote:
>
> On Mon, 14 Aug 2023 14:38:18 +0200,
> Karol Herbst wrote:
> >
> > On Wed, Aug 9, 2023 at 6:16 PM Takashi Iwai wrote:
> > >
> > > On Wed, 09 Aug 2023 16:46:38 +0200,
> > > Takashi Iwai wro
On Mon, Aug 14, 2023 at 2:56 PM Karol Herbst wrote:
>
> On Mon, Aug 14, 2023 at 2:48 PM Takashi Iwai wrote:
> >
> > On Mon, 14 Aug 2023 14:38:18 +0200,
> > Karol Herbst wrote:
> > >
> > > On Wed, Aug 9, 2023 at 6:16 PM Takashi Iwai wrote:
> >
On Tue, Aug 8, 2023 at 3:47 PM Borislav Petkov wrote:
>
> On Tue, Aug 08, 2023 at 12:39:32PM +0200, Karol Herbst wrote:
> > ahh, that would have been good to know :)
>
> Yeah, I didn't see it before - it would only freeze. Only after I added
> the printk you requeste
On Mon, Aug 14, 2023 at 3:35 PM Takashi Iwai wrote:
>
> On Mon, 14 Aug 2023 15:19:11 +0200,
> Karol Herbst wrote:
> >
> > On Mon, Aug 14, 2023 at 2:56 PM Karol Herbst wrote:
> > >
> > > On Mon, Aug 14, 2023 at 2:48 PM Takashi Iwai wrote:
> > &
uption in error handling related to that commit.
Link:
https://lore.kernel.org/lkml/20230806213107.GFZNARG6moWpFuSJ9W@fat_crate.local/
Fixes: 95983aea8003 ("drm/nouveau/disp: add connector class")
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/nouveau/nouveau_connector.c | 11 +
On Mon, Aug 14, 2023 at 4:19 PM Karol Herbst wrote:
>
> On Mon, Aug 14, 2023 at 3:35 PM Takashi Iwai wrote:
> >
> > On Mon, 14 Aug 2023 15:19:11 +0200,
> > Karol Herbst wrote:
> > >
> > > On Mon, Aug 14, 2023 at 2:56 PM Karol Herbst wrote:
> > >
On Wed, Aug 16, 2023 at 11:30 AM Borislav Petkov wrote:
>
> On Mon, Aug 14, 2023 at 04:49:32PM +0200, Karol Herbst wrote:
> > We can't simply free the connector after calling drm_connector_init on it.
> > We need to clean up the drm side first.
> >
> > It
On Wed, Aug 16, 2023 at 4:54 PM Borislav Petkov wrote:
>
> On Wed, Aug 16, 2023 at 11:51:50AM +0200, Karol Herbst wrote:
> > Mind sharing your kernel logs with that patch applied? I suspect your
> > system boots up but you might just not have the connector available or
> >
On Wed, Aug 16, 2023 at 5:13 PM Borislav Petkov wrote:
>
> On Wed, Aug 16, 2023 at 04:57:28PM +0200, Karol Herbst wrote:
> > Do you have any connectors listed in "/sys/class/drm"?
>
> tree /sys/class/drm/
> /sys/class/drm/
> ├── card0 -> ../../devices/pci
On Thu, Aug 17, 2023 at 12:14 AM Borislav Petkov wrote:
>
> On Wed, Aug 16, 2023 at 11:27:05PM +0200, Karol Herbst wrote:
> > that GPU has only a `DMS-59` connector, is that right?
>
> No clue. How do I figure that out?
>
do you have one of these? https://en.wiki
On Thu, Aug 17, 2023 at 10:10 AM Borislav Petkov wrote:
>
> On Thu, Aug 17, 2023 at 01:18:12AM +0200, Karol Herbst wrote:
> > do you have one of these? https://en.wikipedia.org/wiki/DMS-59
>
> Ah, DMS == Dual Monitor Solution :-)
>
> Yap, that's exactly what the GPU
On Thu, Aug 17, 2023 at 11:58 AM Karol Herbst wrote:
>
> On Thu, Aug 17, 2023 at 10:10 AM Borislav Petkov wrote:
> >
> > On Thu, Aug 17, 2023 at 01:18:12AM +0200, Karol Herbst wrote:
> > > do you have one of these? https://en.wikipedia.org/wiki/DMS-59
> >
>
On Thu, Aug 17, 2023 at 12:11 PM Borislav Petkov wrote:
>
> On Thu, Aug 17, 2023 at 12:00:47PM +0200, Karol Herbst wrote:
> > btw, what would help is to know where `nvkm_uconn_uevent` actually
> > fails, or rather, are you running into this "/* TODO: support DP IRQ
> &g
rm/nouveau/nvkm/subdev/bios/init.c:611: warning: expecting
> prototype for INIT_DONE(). Prototype was for init_done() instead
> [Snipped ~140 lines for brevity]
>
> Signed-off-by: Lee Jones
> ---
> Cc: Ben Skeggs
> Cc: Karol Herbst
> Cc: Lyude Paul
> Cc: David Airlie
c-guide/kernel-doc.rst
> drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:62: warning: This comment
> starts with '/**', but isn't a kernel-doc comment. Refer
> Documentation/doc-guide/kernel-doc.rst
>
> Signed-off-by: Lee Jones
> ---
> Cc: Ben Skeggs
> Cc:
c-guide/kernel-doc.rst
>
> Signed-off-by: Lee Jones
> ---
> Cc: Ben Skeggs
> Cc: Karol Herbst
> Cc: Lyude Paul
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: dri-devel@lists.freedesktop.org
> Cc: nouv...@lists.freedesktop.org
> ---
> drivers/gpu/drm/nouve
kernel-doc.rst
> drivers/gpu/drm/nouveau/dispnv04/crtc.c:629: warning: This comment starts
> with '/**', but isn't a kernel-doc comment. Refer
> Documentation/doc-guide/kernel-doc.rst
>
> Signed-off-by: Lee Jones
> ---
> Cc: Ben Skeggs
> Cc: Karol Herbst
&g
ured this one out a bit later.
> On Fri, 2023-06-30 at 18:06 +0200, Karol Herbst wrote:
> > Cc: Ben Skeggs
> > Cc: Lyude Paul
> > Fixes: f530bc60a30b ("drm/nouveau/disp: move HDMI config into acquire +
> > infoframe methods")
> > Signed-off-by: Karol H
On Fri, Jul 7, 2023 at 11:58 PM Lyude Paul wrote:
>
> Currently we use the drm_dp_dpcd_read_caps() helper in the DRM side of
> nouveau in order to read the DPCD of a DP connector, which makes sure we do
> the right thing and also check for extended DPCD caps. However, it turns
> out we're not curr
Reviewed-by: Karol Herbst
On Mon, Jul 10, 2023 at 9:23 AM wrote:
>
> Assignments in if condition are less readable and error-prone. Fixes
> also checkpatch warning:
>
> ERROR: do not use assignment in if condition
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/
t; }
>
> static int
> -gk104_pcie_init(struct nvkm_pci * pci)
> +gk104_pcie_init(struct nvkm_pci *pci)
> {
> enum nvkm_pcie_speed lnkctl_speed, max_speed, cap_speed;
> struct nvkm_subdev *subdev = &pci->subdev;
>
Reviewed-by: Karol Herbst
if (!(pad = nvkm_i2c_pad_find(i2c, id)))
> +pad = nvkm_i2c_pad_find(i2c, id);
> +if (!pad)
> ret = func->pad_s_new(i2c, id, &pad);
> else
> ret = 0;
>
Reviewed-by: Karol Herbst
L)))
> +*paux = kzalloc(sizeof(**paux), GFP_KERNEL);
> +if (!*paux)
> return -ENOMEM;
> return nvkm_i2c_aux_ctor(func, pad, id, *paux);
> }
>
Reviewed-by: Karol Herbst
On Mon, Jul 10, 2023 at 11:10 AM Bagas Sanjaya wrote:
>
> On Mon, Jul 10, 2023 at 03:06:47PM +0800, sunran...@208suo.com wrote:
> > Fixed error: 'do not use assignment in if condition'
> >
> > This patch fixes error: 'do not use assignment in if condition'
> > in drm/nouveau/iccsense
>
> I guess t
On Thu, Jul 13, 2023 at 11:13 AM Karol Herbst wrote:
>
> On Mon, Jul 10, 2023 at 11:10 AM Bagas Sanjaya wrote:
> >
> > On Mon, Jul 10, 2023 at 03:06:47PM +0800, sunran...@208suo.com wrote:
> > > Fixed error: 'do not use assignment in if condition'
> >
On Sat, Jul 15, 2023 at 1:07 AM Lyude Paul wrote:
>
> NAK - checkpatch.pl is a (strongish) guideline, but not a rule. In the cases
> corrected in the patch series here, we format the switch cases on single lines
> as it dramatically improves the readability of what is otherwise just a /long/
> lis
Hi Ard,
the official nouveau tree is here: https://github.com/skeggsb/nouveau
But ben usually takes care of everything if you post the patches on the ML.
No idea what you discussed internally though, but alex also posts his suff
here.
On 16 Oct 2016 22:12, "Ard Biesheuvel" wrote:
On 7 October
thanks for the work, but could you please split that patch?
It looks like you are doing several things at once and it isn't really
easy to review like this. And it isn't bisectable.
If there are clean ups here, please do it in a seperate patch. I
highly doubt that it all has to be done within one
Hi Oscar,
this is a cover letter, there should be no patch attached to it, but a
stat of the following patches and an explenation what the series is
doing.
2017-04-13 11:07 GMT+02:00 Oscar Salvador :
> Hi again,
>
> I've split the patches as Karol Herbst suggested.
> I h
2017-04-13 11:08 GMT+02:00 Oscar Salvador :
> This patch introduces the structure "struct hwmon_ops" and sets up the
> ".visible" operation.
> Is also a preparation for the next patch where all work is being done.
>
> --- linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c.orig 2017-04-12
> 19:22:29
Also your series got a little messed up, there are two 1/4 patches,
and both are different.
2017-04-13 11:07 GMT+02:00 Oscar Salvador :
> Hi again,
>
> I've split the patches as Karol Herbst suggested.
> I hope now it's fine.
>
> This series
2017-04-17 9:47 GMT+02:00 Oscar Salvador :
> This patch introduces the nouveau_hwmon_ops structure, sets up
> .is_visible and .read_string operations and adds all the functions
> for these operations.
> This is also a preparation for the next patches, where most of the
> work is being done.
> This
2017-04-22 11:24 GMT+02:00 Oscar Salvador :
> This patch introduces the nouveau_hwmon_ops structure, sets up
> .is_visible and .read_string operations and adds all the functions
> for these operations.
> This is also a preparation for the next patches, where most of the
> work is being done.
> This
Hi Lyude,
thanks for the great work. Just a view comments inline.
2017-04-25 20:38 GMT+02:00 Lyude :
> This adds support for enabling automatic clockgating on nvidia GPUs for
> Fermi and later generations. This saves a little bit of power, bringing
> my fermi GPU's power consumption from ~28.3W o
201 - 300 of 418 matches
Mail list logo
