[PATCH] drm/mediatek: Initialize pointer before use to avoid undefiend behaviour

2024-11-11 Thread Karan Sanghavi
raphs support for display paths") Signed-off-by: Karan Sanghavi --- Coverity Message: CID 1601557: (#1 of 1): Uninitialized pointer read (UNINIT) 3. uninit_use: Using uninitialized value next. Coverity Link: https://scan7.scan.coverity.com/#/project-view/10043/11354?selectedIssue=1601557 --- d

[PATCH v2] drm:sprd: Correct left shift operator evaluating constant expression

2024-11-08 Thread Karan Sanghavi
quot;) Reviewed-by: Chunyan Zhang Signed-off-by: Karan Sanghavi --- Coverity Scan Message: CID 1511468: (#1 of 1): Wrong operator used (CONSTANT_EXPRESSION_RESULT) operator_confusion: (pll->kint << 4) & 15 is always 0 regardless of the values of its operands. This occurs

[PATCH] drm:sprd: Correct left shift operator evaluating constant expression

2024-11-06 Thread Karan Sanghavi
The left shift operation followed by a mask with 0xf will always result in 0. To correctly evaluate the expression for the bitwise OR operation, use a right shift instead. Reported by Coverity Scan CID: 1511468 Signed-off-by: Karan Sanghavi --- Coverity Scan Message: CID 1511468: (#1 of 1

Re: [PATCH v2] drm:sprd: Correct left shift operator evaluating constant expression

2024-11-09 Thread Karan Sanghavi
On Sat, Nov 09, 2024 at 09:27:36AM +0200, Dmitry Baryshkov wrote: > On Fri, Nov 08, 2024 at 05:11:25PM +0000, Karan Sanghavi wrote: > > The left shift operation followed by a mask with 0xf will > > always result in 0. To correctly evaluate the expression for > > the bitwis

Re: [PATCH v2] drm:sprd: Correct left shift operator evaluating constant expression

2024-12-27 Thread Karan Sanghavi
On Sat, Nov 09, 2024 at 09:27:36AM +0200, Dmitry Baryshkov wrote: > On Fri, Nov 08, 2024 at 05:11:25PM +0000, Karan Sanghavi wrote: > > The left shift operation followed by a mask with 0xf will > > always result in 0. To correctly evaluate the expression for > > the bitwis

Re: [PATCH] drm/mediatek: Initialize pointer before use to avoid undefiend behaviour

2024-12-27 Thread Karan Sanghavi
On Tue, Dec 24, 2024 at 05:09:54PM +0100, Markus Elfring wrote: > > Initialize the pointer with NULL as mtk_drm_of_get_ddp_ep_cid > > function might return before assigning value to next pointer > > but yet further dereference to next can lead to some undefined > > behavior as it may point to some

[PATCH v2] drm/mediatek: Initialize pointer to avoid undefined behavior

2025-01-12 Thread Karan Sanghavi
: 4c932840db1d ("drm/mediatek: Implement OF graphs support for display paths") Signed-off-by: Karan Sanghavi --- Coverity Message: CID 1601557: (#1 of 1): Uninitialized pointer read (UNINIT) 3. uninit_use: Using uninitialized value next. Coverity Link: https://scan7.scan.coverity.com/#/project-