On Mon, 12 Apr 2021, Daniel Vetter wrote:
> On Mon, Apr 12, 2021 at 2:21 PM Fabio M. De Francesco
> wrote:
> >
> > Replaced "unsigned with "unsigned int" since the latter is preferred.
> >
> > Signed-off-by: Fabio M. De Francesco
>
> Nit for the subjects: In drm we generally don't have the gp
On Thu, 15 Apr 2021, Fabio M. De Francesco wrote:
> Removed two set but unused variables.
Would it be useful to use the values?
julia
>
> Signed-off-by: Fabio M. De Francesco
> ---
> drivers/gpu/drm/nouveau/dispnv50/disp.c | 8 +++-
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
>
On Thu, 15 Apr 2021, Fabio M. De Francesco wrote:
> On Thursday, April 15, 2021 9:57:07 PM CEST Julia Lawall wrote:
> > On Thu, 15 Apr 2021, Fabio M. De Francesco wrote:
> > > Removed two set but unused variables.
> >
> > Would it be useful to use the values?
&
On Sat, 17 Apr 2021, Fabio M. De Francesco wrote:
> Added a 'break' in the default case of a switch selection statement.
Why?
julia
>
> Signed-off-by: Fabio M. De Francesco
> ---
> drivers/gpu/drm/drm_bufs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/g
On Sat, 17 Apr 2021, Fabio M. De Francesco wrote:
> On Saturday, April 17, 2021 5:45:46 PM CEST Julia Lawall wrote:
> > On Sat, 17 Apr 2021, Fabio M. De Francesco wrote:
> > > Added a 'break' in the default case of a switch selection statement.
> >
> >
On Mon, 19 Apr 2021, Fabio M. De Francesco wrote:
> Replace the deprecated API with new helpers, according to the TODO list
> of the DRM subsystem.
The commit message will perhaps not be very meaningful one year from now.
You could say for example DRM_MODESET_LOCK_ALL_BEGIN was introduced in
c
On Mon, 19 Apr 2021, Fabio M. De Francesco wrote:
> On Monday, April 19, 2021 3:08:51 PM CEST Julia Lawall wrote:
> > On Mon, 19 Apr 2021, Fabio M. De Francesco wrote:
> > > Replace the deprecated API with new helpers, according to the TODO list
> > > of the DRM su
From: kernel test robot
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
Fixes: 37439a51ff17 ("drm/amdgpu: Add mode2 reset support for aldebaran")
CC: Lijo Lazar
Reported-by: kernel test robot
Signed-off-by: kernel test robot
Signed-off-by: Ju
Use getter and setter functions, for platform_device structures and a
spi_device structure.
Signed-off-by: Julia Lawall
---
drivers/video/backlight/qcom-wled.c |2 +-
drivers/video/fbdev/amifb.c |4
++--
drivers
Use getter and setter functions, for platform_device structures and a
mipi_dsi_device structure.
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/aspeed/aspeed_gfx_drv.c |2 +-
drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c |2 +-
drivers/gpu/drm/panel/panel-lvds.c
On Wed, 10 Feb 2021, Daniel Vetter wrote:
> On Wed, Feb 10, 2021 at 08:23:41AM +, Lee Jones wrote:
> > On Tue, 09 Feb 2021, Julia Lawall wrote:
> >
> > > Use getter and setter functions, for platform_device structures and a
> > > spi_device structure.
> &
* of_node_put(x);
...
}
//
Fixes: 6529007522de ("drm: of: Add drm_of_lvds_get_dual_link_pixel_order")
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/drm_of.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_
Various spelling mistakes in comments.
Detected with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
index
Various spelling mistakes in comments.
Detected with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/sti/sti_gdp.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sti/sti_gdp.c b/drivers/gpu/drm/sti/sti_gdp.c
index 3db3768a3241
Various spelling mistakes in comments.
Detected with the help of Coccinelle.
---
drivers/base/devres.c |4 ++--
drivers/clk/qcom/gcc-sm6125.c |2 +-
drivers/clk/ti/clkctrl.c|2 +-
drivers/gpu/drm/amd/amdg
Various spelling mistakes in comments.
Detected with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
b/drivers/gpu/drm/amd/amdgpu
Various spelling mistakes in comments.
Detected with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
b
Various spelling mistakes in comments.
Detected with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/amd/display/dc/bios/command_table.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/bios/command_table.c
b
On Mon, 21 Mar 2022, Ville Syrjälä wrote:
> On Wed, Mar 16, 2022 at 10:00:06AM +0200, Jani Nikula wrote:
> > On Fri, 18 Feb 2022, Ville Syrjala wrote:
> > > From: Ville Syrjälä
> > >
> > > Initialize on-stack modes with drm_mode_init() to guarantee
> > > no stack garbage in the list head, or t
iomem, because vma has
already been tested.
julia
-- Forwarded message --
Date: Sat, 11 Sep 2021 09:14:18 +0800
From: kernel test robot
To: kbu...@lists.01.org
Cc: l...@intel.com, Julia Lawall
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Add ww context to intel_dpt_pin
CC: k
On Sat, 13 Aug 2016, Amitoj Kaur Chawla wrote:
> devm_pinctrl_register returns an ERR_PTR in case of error and should
> have an IS_ERR check instead of a null check.
>
> The Coccinelle semantic patch used to make this change is as follows:
> @@
> expression e;
> @@
>
> e = devm_pinxtrl_registe
These patches fix cases where a subsequent statement is aligned
with the right hand side of an assignment rather than the left
hand side. This was done using the following semantic match
(http://coccinelle.lip6.fr/). It has a lot of false positives,
because Coccinelle doesn't record the differenc
Delete tab aligning a statement with the right hand side of a
preceding assignment rather than the left hand side.
Found with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/msm/dsi/phy/dsi_phy.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
The device node iterators perform an of_node_get on each iteration, so a
jump out of the loop requires an of_node_put.
The patches for drivers/gpu/drm/imx/imx-ldb.c and
drivers/gpu/drm/sun4i/sun4i_backend.c contain some added of_node_puts for
which the need was identified manually. Details are in
node_put(child)
when != e = child
(
return child;
|
* return ...;
)
...
}
//
Signed-off-by: Julia Lawall
---
This changes the semantics, with respect to the availability of the child
field, and has not been tested.
drivers/gpu/drm/imx/imx-ldb.c | 25 +
,n) {
...
(
of_node_put(n);
|
e = n
|
+ of_node_put(n);
? goto l;
)
...
}
...
l: ... when != n
//
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek
;
@@
for_each_available_child_of_node(root, child) {
... when != of_node_put(child)
when != e = child
+ of_node_put(child);
? break;
...
}
... when != child
//
Signed-off-by: Julia Lawall
---
Not tested.
drivers/gpu/drm/sun4i/sun4i_backend.c |5 +++--
1 file changed, 3 insertions(+), 2
;
@@
for_each_child_of_node(root, child) {
... when != of_node_put(child)
when != e = child
+ of_node_put(child);
? break;
...
}
... when != child
//
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/rockchip/rockchip_rgb.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion
The result of of_graph_get_remote_port_parent needs an of_node_put,
even if it is not available.
---
drivers/gpu/drm/meson/meson_drv.c |9 +++--
drivers/gpu/drm/rcar-du/rcar_du_kms.c |1 +
drivers/of/property.c |1 +
3 files changed, 9 insertions(+), 2 deletio
!= true e == NULL
when != of_node_put(e)
when != of_fwnode_handle(e)
(
return e;
|
*return ...;
)
//
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/rcar-du/rcar_du_kms.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
b/drivers/gpu/drm
(http://coccinelle.lip6.fr):
//
@r exists@
local idexpression e;
expression x;
@@
e = of_graph_get_remote_port_parent(...);
... when != x = e
when != true e == NULL
when != of_node_put(e)
when != of_fwnode_handle(e)
(
return e;
|
*return ...;
)
//
Signed-off-by: Julia Lawall
On Mon, 14 Jan 2019, Kieran Bingham wrote:
> Hi Julia,
>
> Thank you for the patch,
>
> On 13/01/2019 09:44, Julia Lawall wrote:
> > Add an of_node_put when the result of of_graph_get_remote_port_parent is
> > not available.
> >
> > The semantic matc
;
expression x;
@@
e = of_graph_get_remote_port_parent(...);
... when != x = e
when != true e == NULL
when != of_node_put(e)
when != of_fwnode_handle(e)
(
return e;
|
*return ...;
)
//
Signed-off-by: Julia Lawall
---
v2: Add the second of_node_put(entity);, as suggested by Kieran Bingham
Failure of of_device_is_available implies that the device node
should be put, if it is not used otherwise.
---
arch/arm/mach-omap2/display.c|4 +++-
arch/powerpc/platforms/83xx/usb.c|4 +++-
drivers/bus/arm-cci.c
any
if (<+...of_device_is_available(e)...+>) {
... when != of_node_put(e)
(
return e;
|
+ of_node_put(e);
return ...;
)
}
//
Fixes: f76ee892a99e6 ("omapfb: copy omapdss & displays for omapfb")
Signed-off-by: Julia Lawall
---
drivers/video/fbdev/omap2/omapfb/dss/omapds
any
if (<+...of_device_is_available(e)...+>) {
... when != of_node_put(e)
(
return e;
|
+ of_node_put(e);
return ...;
)
}
//
Fixes: f2dd36ac9974c ("OMAPDSS: move 'compatible' converter to omapdss driver")
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/omapdrm/dss/
any
if (<+...of_device_is_available(e)...+>) {
... when != of_node_put(e)
(
return e;
|
+ of_node_put(e);
return ...;
)
}
//
Fixes: d8f4a9eda0067 ("drm: Add NVIDIA Tegra20 support")
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/tegra/rgb.c |4 +++-
1 file changed, 3
Hello,
It looks like line 1204 needs a break rather than a return, like in the
aborts from the other cases.
julia
-- Forwarded message --
Date: Sat, 2 Mar 2019 14:36:31 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: [radeon-alex:drm-next-5.2-wip 214
test robot
Signed-off-by: Julia Lawall
---
tree: git://people.freedesktop.org/~agd5f/linux.git drm-next-5.2-wip
head: 25752e1fc83e9f983b11d680fc7bfc129b4eaae6
commit: 76760fe3c00d04f25cc1a6115294310d4effeb77 [161/226] drm/amd/powerplay:
add function to store overdrive information for smu11
:::
From: kbuild test robot
PTR_ERR should access the value just tested by IS_ERR
Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
Fixes: 10f21de123ac ("drm/panfrost: add support for reset lines")
CC: Neil Armstrong
Signed-off-by: kbuild test robot
Signed-off-by: Julia Lawall
The of_node_put does not seem to be needed. Note that there is none at
the preceeding continues.
julia
-- Forwarded message --
Date: Sat, 11 Jun 2022 06:02:45 +0800
From: kernel test robot
To: kbu...@lists.01.org
Cc: l...@intel.com, Julia Lawall
Subject: [PATCH] drm: fix
Spelling mistake (triple letters) in comment.
Detected with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/etnaviv/etnaviv_gpu.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
b/drivers/gpu/drm/etnaviv
Spelling mistake (triple letters) in comment.
Detected with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/i915/gvt/gtt.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c
index
Spelling mistake (triple letters) in comment.
Detected with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c
b/drivers/gpu
Spelling mistakes (triple letters) in comments.
Detected with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/i915/display/intel_color.c |2 +-
drivers/gpu/drm/i915/display/intel_pps.c |2 +-
drivers/gpu/drm/i915/gt
Spelling mistakes (triple letters) in comments.
Detected with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c |2 +-
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c |4 ++--
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c |2 +-
3 files changed, 4
Spelling mistake (triple letters) in comment.
Detected with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
b
> On 30 May 2022, at 15:27, Arnd Bergmann wrote:
>
> On Mon, May 30, 2022 at 4:08 PM Jani Nikula wrote:
>>> On Mon, 30 May 2022, Arnd Bergmann wrote:
>>> struct my_driver_priv {
>>> struct device dev;
>>> u8 causes_misalignment;
>>> spinlock_t lock;
>>> atomic_t coun
From: kernel test robot
Use max to simplify the code.
Generated by: scripts/coccinelle/misc/minmax.cocci
CC: Denis Efremov
Reported-by: kernel test robot
Signed-off-by: kernel test robot
Signed-off-by: Julia Lawall
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds
Make const static structures that are just copied into other structures.
The semantic patch that detects the opportunity for this change is as
follows: (http://coccinelle.lip6.fr/)
@r disable optional_qualifier@
identifier i,j;
position p;
@@
static struct i j@p = { ... };
@upd@
position p1;
id
The dw_hdmi_hw structure is only copied into another structure,
so make it const.
The opportunity for this change was found using Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
The monspecs structure is only copied into another structure,
so make it const.
The opportunity for this change was found using Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/video/fbdev/sa1100fb.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev
Use resource_size rather than a verbose computation on
the end and start fields.
The semantic patch that makes these changes is as follows:
(http://coccinelle.lip6.fr/)
@@ struct resource ptr; @@
- (ptr.end - ptr.start + 1)
+ resource_size(&ptr)
Signed-off-by: Julia Lawall
---
dri
Use resource_size rather than a verbose computation on
the end and start fields.
The semantic patch that makes these changes is as follows:
(http://coccinelle.lip6.fr/)
@@
struct resource ptr;
@@
- ((ptr.end) - (ptr.start) + 1)
+ resource_size(&ptr)
@@
struct resource *ptr;
@@
- ((ptr->end) -
Use resource_size rather than a verbose computation on
the end and start fields.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
@@ struct resource ptr; @@
- (ptr.end - ptr.start + 1)
+ resource_size(&ptr)
Signed-off-by: Julia Lawall
---
drivers/v
t;)
Signed-off-by: kbuild test robot
Signed-off-by: Julia Lawall
---
tree: git://anongit.freedesktop.org/drm/drm-misc for-linux-next
head: 80805774fc354f9ae7755a8e649a01dedfd0dcf8
commit: dd90e9ae55a1e7efd3ac036afe9f7ae7bb64d39d [2/16] video: fbdev: mmp: add
COMPILE_TEST support
:: b
On Sat, 12 Oct 2019, Navid Emamdoost wrote:
> On Sat, Oct 12, 2019 at 4:07 AM Markus Elfring wrote:
> >
> > From: Markus Elfring
> > Date: Sat, 12 Oct 2019 10:30:21 +0200
> >
> > The return value from a call of the function “kmemdup” was not checked
> > in this function implementation. Thus ad
On Sat, 19 Oct 2019, Wambui Karuga wrote:
> From: Wambui Karuga
>
> Remove unnecessary variable `ret` in drm_dp_atomic_find_vcpi_slots()
> only used to hold the function return value and have the function
> return the value directly.
This patch applies for me, but with a huge offset. What tr
> |
> - ((n + (d - 1)) / d)
> + DIV_ROUND_UP(n,d)
> )
>
> Signed-off-by: Wambui Karuga
Acked-by: Julia Lawall
> ---
> drivers/gpu/drm/drm_agpsupport.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_agpsupport.c
> b/driv
From: kbuild test robot
Remove unneeded semicolons.
Generated by: scripts/coccinelle/misc/semicolon.cocci
Fixes: 841b04751dc0 ("UNCLEAN: add HDMI TX driver")
CC: Lucas Stach
Signed-off-by: kbuild test robot
Signed-off-by: Julia Lawall
---
tree: git://git.infradead.org/users
From: kbuild test robot
Remove unneeded semicolons.
Generated by: scripts/coccinelle/misc/semicolon.cocci
Fixes: 841b04751dc0 ("UNCLEAN: add HDMI TX driver")
CC: Lucas Stach
Signed-off-by: kbuild test robot
Signed-off-by: Julia Lawall
---
tree: git://git.infradead.org/users
Hello,
Color_format is unsigned, so it won't be less than 0 on line 272.
julia
-- Forwarded message --
Date: Mon, 23 Sep 2019 02:29:34 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [PATCH v6 2/2] drm/bridge: Add NWL MIPI DSI host contr
On Tue, 19 Nov 2019, Jani Nikula wrote:
> On Tue, 19 Nov 2019, Jani Nikula wrote:
> > On Mon, 18 Nov 2019, Thierry Reding wrote:
> >> On Mon, Nov 18, 2019 at 07:46:10PM +0800, zhengbin wrote:
> >>> zhengbin (2):
> >>> drm/tegra: Use PTR_ERR_OR_ZERO() to simplify code in
> >>> tegra_bo_du
> De: "Lukas Bulwahn"
> À: "Thomas Hellstrom" , dri-devel@lists.freedesktop.org
> Cc: "David Airlie" , "Daniel Vetter" ,
> "Sinclair Yeh" ,
> linux-graphics-maintai...@vmware.com, kernel-janit...@vger.kernel.org,
> linux-ker...@vger.kernel.org, "Lukas Bulwahn"
>
> Envoyé: Dimanche 8 Décembre 20
> >> @minus_one@
> >> expression FULL;
> >> @@
> >>
> >> - (get_random_int() & ((FULL) - 1)
> >> + prandom_u32_max(FULL)
> >
> >Ahh, well, okay, this is the example I mentioned above. Only works if
> >FULL is saturated. Any clever way to get coccinelle to prove that? Can
> >it look at the value of
On Sat, 29 Oct 2022, Deepak R Varma wrote:
> On Sat, Oct 29, 2022 at 09:32:50AM +0200, Greg Kroah-Hartman wrote:
> > On Fri, Oct 28, 2022 at 07:00:05PM +0530, Deepak R Varma wrote:
> > > The ARRAY_SIZE(foo) macro should be preferred over sizeof operator
> > > based computation such as sizeof(fo
On Mon, 31 Oct 2022, Deepak R Varma wrote:
> On Mon, Oct 31, 2022 at 12:41:40PM +0530, Deepak Varma wrote:
> > On Sat, Oct 29, 2022 at 07:34:26PM +0200, Julia Lawall wrote:
> > >
> > >
> > > On Sat, 29 Oct 2022, Deepak R Varma wrote:
> > >
> >
On Tue, 3 Jan 2023, Deepak R Varma wrote:
> On Wed, Dec 28, 2022 at 06:18:12AM -0500, Rodrigo Vivi wrote:
> > On Tue, Dec 27, 2022 at 11:36:13PM +0530, Deepak R Varma wrote:
> > > On Tue, Dec 27, 2022 at 12:13:56PM -0500, Rodrigo Vivi wrote:
> > > > On Tue, Dec 27, 2022 at 01:30:53PM +0530, Dee
> Hi Julia, thanks for helping here.
>
> So, my question is why this
>
> make coccicheck M=drivers/gpu/drm/i915/ MODE=context
> COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
>
> didn't catch this chunck:
>
> - debugfs_create_file("i915_fbc_false_color", 0644, parent,
)
+ array_size(E1, E2)
,...)
)
//
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/gud/gud_pipe.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/gud/gud_pipe.c b/drivers/gpu/drm/gud/gud_pipe.c
index dc16a92625d4..34df847bd829 100644
--- a
)
+ array_size(E1, E2)
,...)
)
//
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/i915/gvt/gtt.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c
index 4ec85308379a..df52385ad436 100644
)
+ array_size(e1, e2)
,...)
|
alloc(
- (e1) * (COUNT)
+ array_size(COUNT, e1)
,...)
)
//
Signed-off-by: Julia Lawall
---
drivers/dma-buf/heaps/system_heap.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma-buf/heaps/system_heap.c
)
+ array_size(e1, e2)
,...)
|
alloc(
- (e1) * (COUNT)
+ array_size(COUNT, e1)
,...)
)
//
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/vmwgfx/vmwgfx_devcaps.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vmwgfx
)
+ array_size(E1, E2)
,...)
)
//
Signed-off-by: Julia Lawall
---
drivers/accel/habanalabs/common/device.c |3 ++-
drivers/accel/habanalabs/common/state_dump.c |6 +++---
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/accel/habanalabs/common
Use array_size to protect against multiplication overflows.
This follows up on the following patches by Kees Cook from 2018.
42bc47b35320 ("treewide: Use array_size() in vmalloc()")
fad953ce0b22 ("treewide: Use array_size() in vzalloc()")
The changes were done using the following Coccinelle sema
The functions vmalloc_array and vcalloc were introduced in
commit a8749a35c399 ("mm: vmalloc: introduce array allocation functions")
but are not used much yet. This series introduces uses of
these functions, to protect against multiplication overflows.
The changes were done using the following
t:ocaml(alloc) { rename alloc };
@@
(
alloc(x1*x2*x3)
|
alloc(C1 * C2)
|
alloc((sizeof(t)) * (COUNT), ...)
|
- alloc((e1) * (e2))
+ realloc(e1, e2)
|
- alloc((e1) * (COUNT))
+ realloc(COUNT, e1)
|
- alloc((E1) * (E2))
+ realloc(E1, E2)
)
//
Signed-o
t:ocaml(alloc) { rename alloc };
@@
(
alloc(x1*x2*x3)
|
alloc(C1 * C2)
|
alloc((sizeof(t)) * (COUNT), ...)
|
- alloc((e1) * (e2))
+ realloc(e1, e2)
|
- alloc((e1) * (COUNT))
+ realloc(COUNT, e1)
|
- alloc((E1) * (E2))
+ realloc(E1, E2)
)
//
Signed-o
t:ocaml(alloc) { rename alloc };
@@
(
alloc(x1*x2*x3)
|
alloc(C1 * C2)
|
alloc((sizeof(t)) * (COUNT), ...)
|
- alloc((e1) * (e2))
+ realloc(e1, e2)
|
- alloc((e1) * (COUNT))
+ realloc(COUNT, e1)
|
- alloc((E1) * (E2))
+ realloc(E1, E2)
)
//
Signed-o
t:ocaml(alloc) { rename alloc };
@@
(
alloc(x1*x2*x3)
|
alloc(C1 * C2)
|
alloc((sizeof(t)) * (COUNT), ...)
|
- alloc((e1) * (e2))
+ realloc(e1, e2)
|
- alloc((e1) * (COUNT))
+ realloc(COUNT, e1)
|
- alloc((E1) * (E2))
+ realloc(E1, E2)
)
//
Signed-o
On Fri, 23 Jun 2023, Julia Lawall wrote:
> Use array_size to protect against multiplication overflows.
>
> The changes were done using the following Coccinelle semantic patch:
>
> //
> @@
> size_t e1,e2;
> expression COUNT;
> identifier alloc = {vmallo
On Wed, 12 Jul 2023, Uwe Kleine-König wrote:
> On Wed, Jul 12, 2023 at 12:46:33PM +0200, Christian König wrote:
> > Am 12.07.23 um 11:46 schrieb Uwe Kleine-König:
> > > Hello,
> > >
> > > while I debugged an issue in the imx-lcdc driver I was constantly
> > > irritated about struct drm_device po
Use the names of the corresponding functions.
Issue detected using Coccinelle (http://coccinelle.lip6.fr/)
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/omapdrm/omap_drv.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c
b
These patches fix cases where the documentation above a function definition
is not consistent with the function header. Issues are detected using the
semantic patch below (http://coccinelle.lip6.fr/). Basically, the semantic
patch parses a file to find comments, then matches each function header,
Adjust the documentation to use the names that appear in the function
parameter list.
Issue detected using Coccinelle (http://coccinelle.lip6.fr/)
Signed-off-by: Julia Lawall
---
drivers/dma-buf/sw_sync.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/dma
Delete a reference to a variable that has never been used by the function
in the first case, and rename a variable to that of the corresponding
parameter name in the second case.
Issue detected using Coccinelle (http://coccinelle.lip6.fr/)
Signed-off-by: Julia Lawall
---
drivers/gpu/drm
On Sat, 1 Oct 2016, Joe Perches wrote:
> On Sat, 2016-10-01 at 21:46 +0200, Julia Lawall wrote:
> > These patches fix cases where the documentation above a function definition
> > is not consistent with the function header. Issues are detected using the
> > seman
parameters etc. But the set of patches is not
exhaustive with respect to the remaining interesting ones either.
julia
>
> Jani, can you pls digg out these patches? Can't find them right now ...
> -Daniel
>
>
> On Sat, Oct 1, 2016 at 9:46 PM, Julia Lawall wrote:
> >
On Wed, 5 Oct 2016, Jani Nikula wrote:
> On Wed, 05 Oct 2016, Daniel Vetter wrote:
> > Jani Nikula has a patch with a scrip to make the one kernel-doc parser
> > into a lint/checker pass over the entire kernel. I think that'd would
> > be more robust instead of trying to approximate the real ke
The kfree on line 926 would only be a problem for the references to e on
lines 933 and 937 if the return value of drm_event_reserve_init can be
-EDEADLK.
julia
-- Forwarded message --
Date: Thu, 30 Mar 2017 00:48:54 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia
Hello,
It looks pretty clear that an unlock was intended.
julia
-- Forwarded message --
Date: Fri, 31 Mar 2017 19:29:47 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: [radeon-alex:drm-next-4.12 212/315]
drivers/gpu/drm/amd/amdgpu/../powerplay
It looks like &udev->cmdr_lock should be released at line 512 if it has
not been released otherwise. The lock was taken at line 438.
julia
-- Forwarded message --
Date: Fri, 14 Apr 2017 22:21:44 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subj
Remove unneeded semicolons.
Generated by: scripts/coccinelle/misc/semicolon.cocci
CC: Harry Wentland
Signed-off-by: Julia Lawall
Signed-off-by: Fengguang Wu
---
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-4.9
head: 79d2de1bcb650296adff1cb08bfbf1501a6e6e14
commit
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
CC: Harry Wentland
Signed-off-by: Julia Lawall
Signed-off-by: Fengguang Wu
---
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-4.9
head: 79d2de1bcb650296adff1cb08bfbf1501a6e6e14
commit
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
CC: Harry Wentland
Signed-off-by: Julia Lawall
Signed-off-by: Fengguang Wu
---
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-4.9
head: 79d2de1bcb650296adff1cb08bfbf1501a6e6e14
commit
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
CC: Harry Wentland
Signed-off-by: Julia Lawall
Signed-off-by: Fengguang Wu
---
v2: make subject line unique
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-4.9
head
Remove unneeded semicolons.
Generated by: scripts/coccinelle/misc/semicolon.cocci
CC: Harry Wentland
Signed-off-by: Julia Lawall
Signed-off-by: Fengguang Wu
---
v2: make subject line unique
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-4.9
head
The constants on lines 1613 and 1615 are the same.
julia
On Wed, 9 Nov 2016, kbuild test robot wrote:
>
> tree: git://people.freedesktop.org/~agd5f/linux.git drm-next-4.10-wip
> head: a5178d59d93d8b04fed1de3602cd448de9f1f995
> commit: 94f2d9bf6f3c0c192bc864ba1530d0f40afe9984 [26/45] drm/amd/
: Julia Lawall
---
drivers/gpu/drm/rockchip/rockchip_drm_fb.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c
b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c
index 0f6eda0..01e11bf 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c
filename
5274228 855101586 sun4i_backend.o
6401228 8663719ed sun4i_tcon.o
3708360 84076 fec sun4i_tv.o
1676100 01776 6f0 sun6i_drc.o
Signed-off-by: Julia Lawall
---
drivers/gpu/d
1 - 100 of 335 matches
Mail list logo
