[PATCH v2] drm/bridge: nwl-dsi: switch to devm_drm_of_get_bridge

The function "drm_of_find_panel_or_bridge" has been deprecated in favor of "devm_drm_of_get_bridge". Switch to the new function and reduce boilerplate. Signed-off-by: José Expósito --- v2: (Thanks to Liu Ying) - Rebase on top of drm-misc-next - Remove drm_of

Re: [PATCH v2] drm/bridge: nwl-dsi: switch to devm_drm_of_get_bridge

On Mon, Mar 28, 2022 at 03:24:05PM +0200, Robert Foss wrote: > On Fri, 18 Mar 2022 at 10:25, Liu Ying wrote: > > > > On Thu, 2022-03-17 at 18:58 +0100, José Expósito wrote: > > > The function "drm_of_find_panel_or_bridge" has been deprecated in >

[PATCH] drm/omap: switch to drm_of_find_panel_or_bridge

Use the "drm_of_find_panel_or_bridge" function instead of a custom version of it to reduce the boilerplate. Signed-off-by: José Expósito --- drivers/gpu/drm/omapdrm/dss/output.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/d

[PATCH] drm/bridge: anx7625: switch to devm_drm_of_get_bridge

The function "drm_of_find_panel_or_bridge" has been deprecated in favor of "devm_drm_of_get_bridge". Switch to the new function and reduce boilerplate. Signed-off-by: José Expósito --- drivers/gpu/drm/bridge/analogix/anx7625.c | 16 +--- 1 file changed,

[PATCH] drm/msm/dp: switch to devm_drm_of_get_bridge

The function "drm_of_find_panel_or_bridge" has been deprecated in favor of "devm_drm_of_get_bridge". Switch to the new function and reduce boilerplate. Signed-off-by: José Expósito --- drivers/gpu/drm/msm/dp/dp_parser.c | 10 +- 1 file changed, 1 insertion(+),

[PATCH] drm: rcar-du: switch to devm_drm_of_get_bridge

The function "drm_of_find_panel_or_bridge" has been deprecated in favor of "devm_drm_of_get_bridge". Switch to the new function and reduce boilerplate. Signed-off-by: José Expósito --- drivers/gpu/drm/rcar-du/rcar_lvds.c | 16 +--- 1 file changed, 5 inserti

[PATCH] drm/bridge: chipone-icn6211: switch to devm_drm_of_get_bridge

The function "drm_of_find_panel_or_bridge" has been deprecated in favor of "devm_drm_of_get_bridge". Switch to the new function and reduce boilerplate. Signed-off-by: José Expósito --- drivers/gpu/drm/bridge/chipone-icn6211.c | 7 +-- 1 file changed, 1 insertion(+),

Re: [PATCH] drm/msm/dp: switch to devm_drm_of_get_bridge

On Tue, Feb 22, 2022 at 09:07:49PM +, Stephen Boyd wrote: > Quoting José Expósito (2022-02-20 23:33:39) > > The function "drm_of_find_panel_or_bridge" has been deprecated in > > favor of "devm_drm_of_get_bridge". > > > > Switch to the new functio

Re: [PATCH] drm: rcar-du: switch to devm_drm_of_get_bridge

On Mon, Feb 21, 2022 at 02:15:01PM +0200, Laurent Pinchart wrote: > On Mon, Feb 21, 2022 at 09:56:19AM +0100, Maxime Ripard wrote: > > I guess lvds->panel can be removed from the rcar_lvds struct as well? > > It's used in rcar_lvds_get_lvds_mode() though, so this patch introduces > a regression.

[PATCH] drm/bridge: nwl-dsi: switch to devm_drm_of_get_bridge

The function "drm_of_find_panel_or_bridge" has been deprecated in favor of "devm_drm_of_get_bridge". Switch to the new function and reduce boilerplate. Signed-off-by: José Expósito --- drivers/gpu/drm/bridge/nwl-dsi.c | 15 --- 1 file changed, 4 insertions(+), 1

[PATCH] drm/bridge: nxp-ptn3460: switch to devm_drm_of_get_bridge

The function "drm_of_find_panel_or_bridge" has been deprecated in favor of "devm_drm_of_get_bridge". Switch to the new function and reduce boilerplate. Signed-off-by: José Expósito --- drivers/gpu/drm/bridge/nxp-ptn3460.c | 7 +-- 1 file changed, 1 insertion(+), 6 dele

[PATCH] drm/bridge: parade-ps8622: switch to devm_drm_of_get_bridge

The function "drm_of_find_panel_or_bridge" has been deprecated in favor of "devm_drm_of_get_bridge". Switch to the new function and reduce boilerplate. Signed-off-by: José Expósito --- drivers/gpu/drm/bridge/parade-ps8622.c | 7 +-- 1 file changed, 1 insertion(+),

[PATCH] drm/bridge: parade-ps8640: switch to devm_drm_of_get_bridge

The function "drm_of_find_panel_or_bridge" has been deprecated in favor of "devm_drm_of_get_bridge". Switch to the new function and reduce boilerplate. Signed-off-by: José Expósito --- drivers/gpu/drm/bridge/parade-ps8640.c | 9 + 1 file changed, 1 insertion(+),

[PATCH] drm/bridge: tc358762: switch to devm_drm_of_get_bridge

The function "drm_of_find_panel_or_bridge" has been deprecated in favor of "devm_drm_of_get_bridge". Switch to the new function and reduce boilerplate. Signed-off-by: José Expósito --- drivers/gpu/drm/bridge/tc358762.c | 9 + 1 file changed, 1 insertion(+), 8 deleti

[PATCH] drm/bridge: tc358775: switch to devm_drm_of_get_bridge

The function "drm_of_find_panel_or_bridge" has been deprecated in favor of "devm_drm_of_get_bridge". Switch to the new function and reduce boilerplate. Signed-off-by: José Expósito --- drivers/gpu/drm/bridge/tc358775.c | 11 ++- 1 file changed, 2 insertions(+),

[PATCH] drm/bridge: ti-sn65dsi83: switch to devm_drm_of_get_bridge

The function "drm_of_find_panel_or_bridge" has been deprecated in favor of "devm_drm_of_get_bridge". Switch to the new function and reduce boilerplate. Signed-off-by: José Expósito --- drivers/gpu/drm/bridge/ti-sn65dsi83.c | 13 +++-- 1 file changed, 3 inserti

[PATCH] drm/bridge: ti-sn65dsi86: switch to devm_drm_of_get_bridge

The function "drm_of_find_panel_or_bridge" has been deprecated in favor of "devm_drm_of_get_bridge". Switch to the new function and reduce boilerplate. Signed-off-by: José Expósito --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 8 +--- 1 file changed, 1 insertion(+),

[PATCH drm-misc-next 0/2] Use default drm_plane_funcs.format_mod_supported

Hi everyone, This series is a follow up to [1]. Some of the patches were merged in "drm-misc-next", however a couple of them, included in this series, are pending. I rebased the pending patches on top of "drm-misc-next" and added the reviewed by tags. Thanks, José

[PATCH drm-misc-next 1/2] drm/simple-kms: Drop format_mod_supported function

The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: José Expósito Reviewed-by: Simon Ser --- drivers/gpu/drm/drm_simple_kms_helper.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/drm_simple_km

[PATCH drm-misc-next 2/2] drm: mxsfb: Drop format_mod_supported function

The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: José Expósito Reviewed-by: Simon Ser --- drivers/gpu/drm/mxsfb/mxsfb_kms.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c

Re: [PATCH] drm/omap: switch to drm_of_find_panel_or_bridge

On Sun, Feb 20, 2022 at 10:36:35PM +0100, Sam Ravnborg wrote: > Hi José, > > On Sun, Feb 20, 2022 at 08:52:12PM +0100, José Expósito wrote: > > Use the "drm_of_find_panel_or_bridge" function instead of a custom > > version of it to reduce the boilerplate. > Tha

Re: [PATCH] drm/bridge: ti-sn65dsi86: switch to devm_drm_of_get_bridge

On Mon, Feb 28, 2022 at 11:24:36PM +, Kieran Bingham wrote: > Hi José > > Quoting José Expósito (2022-02-28 18:39:54) > > The function "drm_of_find_panel_or_bridge" has been deprecated in > > favor of "devm_drm_of_get_bridge". > > > &

[PATCH] drm/msm/dsi: invalid parameter check in msm_dsi_phy_enable

s") Addresses-Coverity-ID: 1493860 ("Null pointer dereference") Signed-off-by: José Expósito --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c

[PATCH] drm/doc: Fix TTM acronym

The TTM acronym is defined for the first time in the documentation as "Translation Table Maps". Afterwards, "Translation Table Manager" is used as definition. Fix the first definition to avoid confusion. Signed-off-by: José Expósito --- Documentation/gpu/drm-mm.rst | 2 +

[PATCH] net: mana: Fix memory leak in mana_hwc_create_wq

If allocating the DMA buffer fails, mana_hwc_destroy_wq was called without previously storing the pointer to the queue. In order to avoid leaking the pointer to the queue, store it as soon as it is allocated. Addresses-Coverity-ID: 1484720 ("Resource leak") Signed-off-by: Jos

[PATCH] drm/selftests/test-drm_dp_mst_helper: Fix memory leak in sideband_msg_req_encode_decode

Fixes: 09234b88ef55 ("drm/selftests/test-drm_dp_mst_helper: Move 'sideband_msg_req_encode_decode' onto the heap") Addresses-Coverity-ID: 1475685 ("Resource leak") Signed-off-by: José Expósito --- drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c | 4 +++- 1 fi

[PATCH] drm/imx: Fix memory leak in imx_pd_connector_get_modes

Fixes: 76ecd9c9fb24 ("drm/imx: parallel-display: check return code from of_get_drm_display_mode()") Addresses-Coverity-ID: 1443943 ("Resource leak") Signed-off-by: José Expósito --- drivers/gpu/drm/imx/parallel-display.c | 4 +++- 1 file changed, 3 insertions(+), 1 delet

[PATCH 0/3] drm/vkms: add support for multiple overlay planes

Hi all, First of all, let me quickly introduce myself. I'm José Expósito and I'm a hobbyist open source developer. My contributions are usually in the kernel input/HID subsystems and in its userspace library (libinput) as well as other projects. I'm trying to learn more about the

[PATCH 2/3] drm/vkms: add support for multiple overlay planes

Add a new module parameter to allow to set the number of overlay planes to create. Set it to 1 by default in order to keep the "enable_overlay" backwards compatible. Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/vkms_drv.c| 5 + drivers/gpu/drm/vkms/vkms_drv.h| 1

[PATCH 1/3] drm/vkms: refactor overlay plane creation

Move the logic to create an overlay plane to its own function. Refactor, no functional changes. Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/vkms_output.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_output.c

[PATCH 3/3] drm/vkms: drop "Multiple overlay planes" TODO

Signed-off-by: José Expósito --- Documentation/gpu/vkms.rst | 2 -- 1 file changed, 2 deletions(-) diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst index 941f0e7e5eef..9c873c3912cc 100644 --- a/Documentation/gpu/vkms.rst +++ b/Documentation/gpu/vkms.rst @@ -124,8 +124,6

[PATCH] drm/vkms: set plane modifiers

/wayland/weston/-/merge_requests/599/diffs?commit_id=5aea1bc522f0874e6cc07f5120fbcf1736706536 Suggested-by: Chris Healy Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/vkms_plane.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b

[PATCH v2 1/2] drm/vkms: add function to get plane formats

Move the logic to get the plane formats depending on the plane type to its own function. Refactor, no functional changes. Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/vkms_plane.c | 37 --- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a

[PATCH v2 2/2] drm/vkms: set plane modifiers

/wayland/weston/-/merge_requests/599/diffs?commit_id=5aea1bc522f0874e6cc07f5120fbcf1736706536 Suggested-by: Chris Healy Signed-off-by: José Expósito --- v2: Implement format_mod_supported (Simon Ser) --- drivers/gpu/drm/vkms/vkms_plane.c | 34 ++- 1 file changed, 33

Re: [PATCH] drm/vkms: set plane modifiers

On Wed, Dec 15, 2021 at 05:23:10PM +, Simon Ser wrote: > You'll need to set the format_mod_supported hook as well, otherwise the kernel > will expose a bogus IN_FORMATS prop with one modifier and zero formats. Hi Simon, Thank you very much for reviewing this patch, I just started learning abo

[PATCH] drm/amd/display: fix dereference before NULL check

dd cyan_skillfish display support") Signed-off-by: José Expósito --- drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c b/drivers/gpu/drm/amd/display/dc/dcn201/dcn

[PATCH 0/3] Add missing format_mod_supported functions

d I didn't find more instances of the issue. Jose José Expósito (3): drm/plane: Mention format_mod_supported in IN_FORMATS docs drm/msm/mdp4: Add format_mod_supported function drm/sun4i: Add format_mod_supported function drivers/gpu/drm/drm_plane.c| 7 +-- drivers/g

[PATCH 1/3] drm/plane: Mention format_mod_supported in IN_FORMATS docs

program [2]. Make clear in the IN_FORMATS documentation that implementing "format_mod_supported" is mandatory. [1] https://gitlab.freedesktop.org/wayland/weston/-/blob/9.0/libweston/backend-drm/kms.c#L431 [2] https://github.com/JoseExposito/drm-sandbox/blob/main/in_formats.c Signed-o

[PATCH 3/3] drm/sun4i: Add format_mod_supported function

Implement the missing "drm_plane_funcs.format_mod_supported" function to avoid exposing an invalid IN_FORMATS blob with modifiers but no formats. Signed-off-by: José Expósito --- drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 7 +++ drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 7 ++

[PATCH 2/3] drm/msm/mdp4: Add format_mod_supported function

Implement the missing "drm_plane_funcs.format_mod_supported" function to avoid exposing an invalid IN_FORMATS blob with modifiers but no formats. Signed-off-by: José Expósito --- drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c | 8 1 file changed, 8 insertions(+) diff --git a/d

[PATCH v2 0/6] Add missing format_mod_supported functions

e.kernel.org/dri-devel/20211216170532.GA16349@elementary/T/ José Expósito (6): drm/plane: Make format_mod_supported truly optional drm/plane: Fix typo in format_mod_supported documentation drm/simple-kms: Drop format_mod_supported function drm/i915/display: Drop format_mod_supported fun

[PATCH v2 1/6] drm/plane: Make format_mod_supported truly optional

ttps://github.com/JoseExposito/drm-sandbox/blob/main/in_formats.c Signed-off-by: José Expósito --- drivers/gpu/drm/drm_plane.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c index 82afb854141b..c1186b7215e

[PATCH v2 5/6] drm: mxsfb: Drop format_mod_supported function

The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: José Expósito --- drivers/gpu/drm/mxsfb/mxsfb_kms.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c b/drivers/gpu/drm/mxsfb/m

[PATCH v2 4/6] drm/i915/display: Drop format_mod_supported function

The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: José Expósito --- drivers/gpu/drm/i915/display/intel_cursor.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_cursor.c b/d

[PATCH v2 3/6] drm/simple-kms: Drop format_mod_supported function

The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: José Expósito --- drivers/gpu/drm/drm_simple_kms_helper.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/drm_simple_kms_helper.c b/drive

[PATCH v2 2/6] drm/plane: Fix typo in format_mod_supported documentation

Fix minor typo: "valdiate" -> "validate". Signed-off-by: José Expósito --- include/drm/drm_plane.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h index 0c1102dc4d88..06759badf99f 100644 --- a/includ

[PATCH v2 6/6] drm/stm: ltdc: Drop format_mod_supported function

The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: José Expósito --- drivers/gpu/drm/stm/ltdc.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/lt

[PATCH v3 0/1] drm/vkms: set plane modifiers

Hi, Now that "drm_plane_funcs.format_mod_supported" has been made truly optional [1], this third version of the patch is basically identical to the first version as no format/modifier filtering is required. José Expósito [1] https://lore.kernel.org/dri-devel/20211222090552.25972-1-jo

[PATCH v3 1/1] drm/vkms: set plane modifiers

/wayland/weston/-/merge_requests/599/diffs?commit_id=5aea1bc522f0874e6cc07f5120fbcf1736706536 Suggested-by: Chris Healy Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/vkms_plane.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b

[PATCH 1/1] drm/vkms: add zpos plane property

their order but always keep them between the primary and cursor planes. As documented, "vkms_crtc_state.active_planes" must be sorted by zpos. This is achieved by inserting them in the array at their normalized_zpos index. Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/vkms_cr

[PATCH 0/1] drm/vkms: zpos

and minimum overlay plane zpos. Thanks in advance, José Expósito [1] https://lore.kernel.org/dri-devel/20211213181131.17223-1-jose.exposit...@gmail.com/T/ José Expósito (1): drm/vkms: add zpos plane property drivers/gpu/drm/vkms/vkms_crtc.c | 3 +-- drivers/gpu/drm/vkms/vkms_drv.c | 1 +

Re: [PATCH v2 1/6] drm/plane: Make format_mod_supported truly optional

anually. I'll try to do some actual testing during Christmas and see how it goes. José Expósito [1] https://www.kernel.org/doc/html/latest/gpu/todo.html#drm-framebuffer-funcs-and-drm-mode-config-funcs-fb-create-cleanup

Re: [PATCH 0/3] drm/vkms: add support for multiple overlay planes

;t have a strong opinion on an exact/practical number. I took a > quick look at other drivers and exposing 8 planes seems reasonable to > me. 8 planes sound reasonable to me, I'll change it and send a revision of [1] as well using the new constant. Thanks again for taking the time to rev

[PATCH v2 1/3] drm/vkms: refactor overlay plane creation

Move the logic to create an overlay plane to its own function. Refactor, no functional changes. Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/vkms_output.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_output.c

[PATCH v2 3/3] drm/vkms: drop "Multiple overlay planes" TODO

Remove the task from the TODO list. Signed-off-by: José Expósito --- Documentation/gpu/vkms.rst | 2 -- 1 file changed, 2 deletions(-) diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst index 941f0e7e5eef..9c873c3912cc 100644 --- a/Documentation/gpu/vkms.rst +++ b

[PATCH v2 2/3] drm/vkms: add support for multiple overlay planes

04 | 00 | 00 | 04 | 00 | 00 | Signed-off-by: José Expósito --- v2: - Set the number of overlay planes as a constant instead of as a module parameter (Melissa Wen) - Add a test results in the commit message (Melissa Wen) --- drivers/gpu/drm/vkms/vkms_drv.h| 2 ++ drivers/gp

[PATCH v2 0/1] drm/vkms: zpos

d blend the first active plane. I'll look into it, feedback from someone that already investigated the issue is welcome :) Thanks in advance, José Expósito [1] https://lore.kernel.org/dri-devel/20211226104059.11265-1-jose.exposit...@gmail.com/T/ [2] https://www.kernel.org/doc/html/late

[PATCH v2 1/1] drm/vkms: add zpos plane property

CRC. This happens when the primary plane is disabled and the composer is not able to find the "primary_composer" variable. While the timeout bug needs to be fixed in a different series, the zpos property works as expected. Signed-off-by: José Expósito --- v2: - Use number of planes co

[PATCH v2] drm/amd/display: fix dereference before NULL check

dd cyan_skillfish display support") Signed-off-by: José Expósito Reviewed-by: Harry Wentland --- v2: - Fix coverity report ID - Add Reviewed-by tag (thanks to Harry Wentland) --- drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) di

[PATCH v3 0/6] Add missing format_mod_supported functions

uld be changed. The second version implemented the required changes and drops the "format_mod_supported" in the drivers that can use the default implementation. [3] This third version fixes a compiler warning and adds the reviewed by tags. Thanks, José Expósito [1]

[PATCH v3 1/6] drm/plane: Make format_mod_supported truly optional

ttps://github.com/JoseExposito/drm-sandbox/blob/main/in_formats.c Signed-off-by: José Expósito Reviewed-by: Simon Ser --- v2: - Remove unused "done:" label to fix compile warning Reported-by: kernel test robot - Add Reviewed-by (thanks to Simon Ser) --- drivers/gpu/drm/drm_

[PATCH v3 3/6] drm/simple-kms: Drop format_mod_supported function

The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: José Expósito --- drivers/gpu/drm/drm_simple_kms_helper.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/drm_simple_kms_helper.c b/drive

[PATCH v3 2/6] drm/plane: Fix typo in format_mod_supported documentation

Fix minor typo: "valdiate" -> "validate". Signed-off-by: José Expósito Reviewed-by: Simon Ser --- include/drm/drm_plane.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h index 0c1102dc4d88..06759badf9

[PATCH v3 6/6] drm/stm: ltdc: Drop format_mod_supported function

The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: José Expósito --- drivers/gpu/drm/stm/ltdc.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/lt

[PATCH v3 4/6] drm/i915/display: Drop format_mod_supported function

The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: José Expósito --- drivers/gpu/drm/i915/display/intel_cursor.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_cursor.c b/d

[PATCH v3 5/6] drm: mxsfb: Drop format_mod_supported function

The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: José Expósito --- drivers/gpu/drm/mxsfb/mxsfb_kms.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c b/drivers/gpu/drm/mxsfb/m

Re: [PATCH v3 2/6] drm/plane: Fix typo in format_mod_supported documentation

waiting on maintainers input? Thanks, José Expósito

[PATCH RESEND] drm/doc: Fix TTM acronym

The TTM acronym is defined for the first time in the documentation as "Translation Table Maps". Afterwards, "Translation Table Manager" is used as definition. Fix the first definition to avoid confusion. Signed-off-by: José Expósito --- Documentation/gpu/drm-mm.rst | 2 +

[PATCH RESEND v2 1/3] drm/vkms: refactor overlay plane creation

Move the logic to create an overlay plane to its own function. Refactor, no functional changes. Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/vkms_output.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_output.c

[PATCH RESEND v2 2/3] drm/vkms: add support for multiple overlay planes

04 | 00 | 00 | 04 | 00 | 00 | Signed-off-by: José Expósito --- v2: - Set the number of overlay planes as a constant instead of as a module parameter (Melissa Wen) - Add a test results in the commit message (Melissa Wen) --- drivers/gpu/drm/vkms/vkms_drv.h| 2 ++ drivers/gp

[PATCH RESEND v2 3/3] drm/vkms: drop "Multiple overlay planes" TODO

Remove the task from the TODO list. Signed-off-by: José Expósito --- Documentation/gpu/vkms.rst | 2 -- 1 file changed, 2 deletions(-) diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst index 941f0e7e5eef..9c873c3912cc 100644 --- a/Documentation/gpu/vkms.rst +++ b

[PATCH v2] drm/imx: Fix memory leak in imx_pd_connector_get_modes

Avoid leaking the display mode variable if of_get_drm_display_mode fails. Fixes: 76ecd9c9fb24 ("drm/imx: parallel-display: check return code from of_get_drm_display_mode()") Addresses-Coverity-ID: 1443943 ("Resource leak") Signed-off-by: José Expósito --- v2: Im

[PATCH v2] drm/selftests/test-drm_dp_mst_helper: Fix memory leak in sideband_msg_req_encode_decode

Avoid leaking the "out" variable if it is not possible to allocate the "txmsg" variable. Fixes: 09234b88ef55 ("drm/selftests/test-drm_dp_mst_helper: Move 'sideband_msg_req_encode_decode' onto the heap") Addresses-Coverity-ID: 1475685 ("Resource

Re: [PATCH RESEND v2 2/3] drm/vkms: add support for multiple overlay planes

s, I'll have a look into the test as well. Thanks again, José Expósito [1] https://lore.kernel.org/all/20211226111219.27616-2-jose.exposit...@gmail.com/

[PATCH] drm/amd/display: invalid parameter check in dmub_hpd_callback

upt handling") Addresses-Coverity-ID: 1493909 ("Null pointer dereference") Signed-off-by: José Expósito --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

[PATCH] drm/msm/dpu: invalid parameter check in dpu_setup_dspp_pcc

n dpu driver") Addresses-Coverity-ID: 1493866 ("Null pointer dereference") Signed-off-by: José Expósito --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c b/dri

Re: [RFC PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

uggested, I applied all of them over the weekend. I'll send v1 of the patch to the mailing list including them so we have an up to date code to comment on. Thanks a lot for all of your comments and help, José Expósito

[PATCH 0/1] KUnit tests for drm_format_helper

Hello everyone, Recently Javier added a new task in the ToDo list [1] to create KUnit tests for the functions present in "drm_format_helper". This patch includes the changes suggested in the RFC version [2]. Best wishes, José Expósito [1] https://cgit.freedesktop.org/drm/drm-misc/

[PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

: Randomly picked - Destination pitch How to run the tests? $ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm \ --kconfig_add CONFIG_VIRTIO_UML=y \ --kconfig_add CONFIG_UML_PCI_OVER_VIRTIO=y Suggested-by: Javier Martinez Canillas Signed-off-by: José Expósito

Re: [PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

Hi! Javier Martinez Canillas wrote: > Hello José, > > On 6/6/22 11:55, José Expósito wrote: > > Test the conversion from XRGB to RGB332. > > > > What is tested? > > > > - Different values for the X in XRGB to make sure it is ignored > > -

[PATCH] drm/doc: Add KUnit documentation

/ [2] https://lore.kernel.org/dri-devel/CAGS_qxqpiCim_sy1LDK7PLwVgWf-LKW+uNFTGM=t7ydk-dy...@mail.gmail.com/ Signed-off-by: José Expósito --- Documentation/gpu/drm-internals.rst | 31 + 1 file changed, 31 insertions(+) diff --git a/Documentation/gpu/drm-internals.rst

Re: [PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

Hi Thomas, Thanks a lot for your review. On Tue, Jun 07, 2022 at 09:22:38AM +0200, Thomas Zimmermann wrote: > Hi, > > ading Kunit tests for the conversion helpers is pretty cool. Thanks for > doing that. > > Am 06.06.22 um 11:55 schrieb José Expósito: > > Test the con

[PATCH v2 0/3] KUnit tests for drm_format_helper

Hello everyone, Here is the v2 of the series, including the documentation, previously sent as a standalone patch [1], and changes suggested during review. Thanks a lot, José Expósito RFC -> v1: https://lore.kernel.org/dri-devel/20220530102017.471865-1-jose.exposit...@gmail.com/T/ -

[PATCH v2 1/3] drm/rect: Add DRM_RECT_INIT() macro

Add a helper macro to initialize a rectangle from x, y, width and height information. Signed-off-by: José Expósito --- include/drm/drm_rect.h | 12 1 file changed, 12 insertions(+) diff --git a/include/drm/drm_rect.h b/include/drm/drm_rect.h index 6f6e19bd4dac..945696323c69 100644

[PATCH v2 3/3] drm/doc: Add KUnit documentation

/ [2] https://lore.kernel.org/dri-devel/CAGS_qxqpiCim_sy1LDK7PLwVgWf-LKW+uNFTGM=t7ydk-dy...@mail.gmail.com/ Reviewed-by: Maxime Ripard Signed-off-by: José Expósito --- Documentation/gpu/drm-internals.rst | 32 + 1 file changed, 32 insertions(+) diff --git a

[PATCH v2 2/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

Martinez Canillas Signed-off-by: José Expósito --- drivers/gpu/drm/Kconfig | 16 ++ drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/kunit/.kunitconfig| 3 + drivers/gpu/drm/kunit/Makefile| 3 + .../gpu/drm/kunit

[PATCH v3 0/3] KUnit tests for drm_format_helper

Hello everyone, Here is the v3 of the series, including the documentation, previously sent as a standalone patch [1], and changes suggested during review. Thanks a lot, José Expósito RFC -> v1: https://lore.kernel.org/dri-devel/20220530102017.471865-1-jose.exposit...@gmail.com/T/ -

[PATCH v3 3/3] drm/doc: Add KUnit documentation

/ [2] https://lore.kernel.org/dri-devel/CAGS_qxqpiCim_sy1LDK7PLwVgWf-LKW+uNFTGM=t7ydk-dy...@mail.gmail.com/ Reviewed-by: Maxime Ripard Signed-off-by: José Expósito --- Documentation/gpu/drm-internals.rst | 32 + 1 file changed, 32 insertions(+) diff --git a

[PATCH v3 1/3] drm/rect: Add DRM_RECT_INIT() macro

Add a helper macro to initialize a rectangle from x, y, width and height information. Signed-off-by: José Expósito --- include/drm/drm_rect.h | 16 1 file changed, 16 insertions(+) diff --git a/include/drm/drm_rect.h b/include/drm/drm_rect.h index 6f6e19bd4dac..e8d94fca2703

[PATCH v3 2/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

Martinez Canillas Signed-off-by: José Expósito --- drivers/gpu/drm/Kconfig | 16 ++ drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/kunit/.kunitconfig| 3 + drivers/gpu/drm/kunit/Makefile| 3 + .../gpu/drm/kunit

Re: [PATCH v2 1/3] drm/rect: Add DRM_RECT_INIT() macro

On Mon, Jun 13, 2022 at 10:53:57AM +0300, Jani Nikula wrote: > On Sun, 12 Jun 2022, José Expósito wrote: > > Add a helper macro to initialize a rectangle from x, y, width and > > height information. > > > > Signed-off-by: José Expósito > > --- > > include/

Re: [PATCH] drm/bridge: anx7625: Zero error variable when panel bridge not present

On Mon, Jun 13, 2022 at 12:37:05PM -0400, Nícolas F. R. A. Prado wrote: > While parsing the DT, the anx7625 driver checks for the presence of a > panel bridge on endpoint 1. If it is missing, pdata->panel_bridge stores > the error pointer and the function returns successfully without first > cleani

Re: [PATCH v3 3/3] drm/doc: Add KUnit documentation

Hi Javier, On Tue, Jun 14, 2022 at 02:58:29PM +0200, Javier Martinez Canillas wrote: > Hello José, > > On 6/13/22 19:17, José Expósito wrote: > > [snip] > > > +KUnit (Kernel unit testing framework) provides a common framework for unit > > tests > > +within

Re: [PATCH v3 0/3] KUnit tests for drm_format_helper

Hi! Javier Martinez Canillas wrote: > Before merging this, could you please reach the folks working on [0] ? > I think that would be good to have some consistency with regard to KUnit > tests from the start to avoid future refactorings. For instance, you are > adding the tests under a `kunit` sub-

[PATCH v4 0/3] KUnit tests for drm_format_helper

not clear yet whether we want to have one or multiple Kconfig symbols and select which test should be built. However, refactoring from one approach to the other is quite simple, so I think we should be fine choosing the simpler option now and refactoring if required. Thanks a lot, José Expósito

[PATCH v4 1/3] drm/rect: Add DRM_RECT_INIT() macro

Add a helper macro to initialize a rectangle from x, y, width and height information. Reviewed-by: Jani Nikula Acked-by: Thomas Zimmermann Signed-off-by: José Expósito --- include/drm/drm_rect.h | 16 1 file changed, 16 insertions(+) diff --git a/include/drm/drm_rect.h b

[PATCH v4 2/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

Martinez Canillas Acked-by: Thomas Zimmermann Signed-off-by: José Expósito --- drivers/gpu/drm/Kconfig | 16 ++ drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/tests/.kunitconfig| 3 + drivers/gpu/drm/tests/Makefile| 3

[PATCH v4 3/3] drm/doc: Add KUnit documentation

/ [2] https://lore.kernel.org/dri-devel/CAGS_qxqpiCim_sy1LDK7PLwVgWf-LKW+uNFTGM=t7ydk-dy...@mail.gmail.com/ Reviewed-by: Maxime Ripard Reviewed-by: Javier Martinez Canillas Acked-by: Thomas Zimmermann Signed-off-by: José Expósito --- Documentation/gpu/drm-internals.rst | 32

Re: [PATCH v4 2/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

Hi David, On Tue, Jun 21, 2022 at 05:38:33PM +0800, David Gow wrote: > On Tue, Jun 21, 2022 at 12:06 AM José Expósito > wrote: > > > > Test the conversion from XRGB to RGB332. > > > > What is tested? > > > > - Different values for th

Re: [PATCH v4 3/3] drm/doc: Add KUnit documentation

Hi David, On Tue, Jun 21, 2022 at 05:38:38PM +0800, David Gow wrote: > On Tue, Jun 21, 2022 at 12:06 AM José Expósito > wrote: > > > > Explain how to run the KUnit tests present in the DRM subsystem and > > clarify why the UML-only options were not added to the configura

  1   2   3   4   5   >