[PATCH] drm/exynos: g2d: fix overflow of cmdlist size

2017-01-16 Thread Joonyoung Shim
The size of cmdlist is integer type, so it can be overflowed by cmd and cmd_buf that has too big size. This patch will fix overflow issue as checking maximum size of cmd and cmd_buf. Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 9 - 1 file changed, 8

Re: [PATCH] drm/exynos: g2d: fix overflow of cmdlist size

2017-01-17 Thread Joonyoung Shim
Hi Tobias, On 01/17/2017 11:24 PM, Tobias Jakobi wrote: > Joonyoung Shim wrote: >> The size of cmdlist is integer type, so it can be overflowed by cmd and >> cmd_buf that has too big size. This patch will fix overflow issue as >> checking maximum size of cmd and cmd_buf. >

Re: [PATCH] drm/exynos: g2d: fix overflow of cmdlist size

2017-01-19 Thread Joonyoung Shim
Hi Tobias, On 01/19/2017 10:16 PM, Tobias Jakobi wrote: > Hello Joonyoung, > > Joonyoung Shim wrote: >> Hi Tobias, >> >> On 01/17/2017 11:24 PM, Tobias Jakobi wrote: >>> Joonyoung Shim wrote: >>>> The size of cmdlist is integer type, so it can be

Re: [PATCH] drm/exynos: g2d: fix overflow of cmdlist size

2017-01-23 Thread Joonyoung Shim
Hi Tobias, On 01/21/2017 01:05 AM, Tobias Jakobi wrote: > Hello Joonyoung, > > > Joonyoung Shim wrote: >> Hi Tobias, >> >> On 01/19/2017 10:16 PM, Tobias Jakobi wrote: >>> Hello Joonyoung, >>> >>> Joonyoung Shim wrote: >>>

[PATCH v6 01/12] drm/exynos: atomic phase 1: use drm_plane_helper_update()

2015-05-22 Thread Joonyoung Shim
On 05/22/2015 05:02 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > Rip out the check from exynos_update_plane() and create > exynos_check_plane() for the check phase enabling use to use > the atomic helpers to call our check and update phases when updating > planes. > > Update all users

[PATCH v6 02/12] drm/exynos: atomic phase 1: use drm_plane_helper_disable()

2015-05-22 Thread Joonyoung Shim
On 05/22/2015 05:02 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > The atomic helper to disable planes also uses the optional > .atomic_disable() helper. The unique operation it does is calling > .win_disable() > > exynos_drm_fb_get_buf_cnt() needs a fb check too to avoid a null pointer.

[PATCH v6 03/12] drm/exynos: atomic phase 1: add .mode_set_nofb() callback

2015-05-22 Thread Joonyoung Shim
On 05/22/2015 05:02 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > The new atomic infrastructure needs the .mode_set_nofb() callback to > update CRTC timings before setting any plane. > > Signed-off-by: Gustavo Padovan > --- > drivers/gpu/drm/exynos/exynos_drm_crtc.c | 60 > +-

[PATCH v6 04/12] drm/exynos: atomic phase 2: wire up state reset(), duplicate() and destroy()

2015-05-22 Thread Joonyoung Shim
On 05/22/2015 05:02 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > Set CRTC, planes and connectors to use the default implementations from > the atomic helper library. The helpers will work to keep track of state > for each DRM object. > > Signed-off-by: Gustavo Padovan > --- > drivers

[PATCH v6 09/12] drm/exynos: remove exported functions from exynos_drm_plane

2015-05-22 Thread Joonyoung Shim
On 05/22/2015 05:02 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > Now that no one is using the functions exported by exynos_drm_plane due > to the atomic conversion we can make remove some of the them or make them > static. > > v2: remove unused exynos_drm_crtc > > Signed-off-by: Gusta

[PATCH v6 00/12] drm/exynos: atomic modesetting support

2015-05-22 Thread Joonyoung Shim
rivers/gpu/drm/exynos/exynos_drm_plane.h | 11 -- > drivers/gpu/drm/exynos/exynos_drm_vidi.c| 6 +- > drivers/gpu/drm/exynos/exynos_hdmi.c| 10 +- > 15 files changed, 184 insertions(+), 264 deletions(-) > I commented about some patches, looks good to me except them. Reviewed-by: Joonyoung Shim Thanks.

[PATCH 0/5] drm/exynos: rework layer blending setup

2015-05-22 Thread Joonyoung Shim
Hi Tobias, On 05/22/2015 05:44 AM, Tobias Jakobi wrote: > Gentle reminder that I still haven't heard anything about the series by > the Samsung guys ;) > Sorry for late, i'm busy and i think whether it's possible any way for this blending from exynos drm framework after atomic feature of exynos

[PATCH 1/5] drm/exynos: mixer: refactor layer setup

2015-05-22 Thread Joonyoung Shim
On 05/06/2015 10:36 PM, Tobias Jakobi wrote: > First step in allowing a more generic way to setup complex > blending for the different layers. > > Signed-off-by: Tobias Jakobi > --- > drivers/gpu/drm/exynos/exynos_mixer.c | 90 > ++- > 1 file changed, 79 insertio

[PATCH 2/5] drm/exynos: mixer: introduce mixer_layer_blending()

2015-05-22 Thread Joonyoung Shim
On 05/06/2015 10:36 PM, Tobias Jakobi wrote: > This analyses the current layer configuration (which layers > are enabled, which have alpha-pixelformat, etc.) and setups > blending accordingly. > > We currently disable all kinds of blending for the bottom-most > layer, since configuration of the mi

[PATCH 4/5] drm/exynos: mixer: do blending setup in mixer_cfg_layer()

2015-05-22 Thread Joonyoung Shim
On 05/06/2015 10:36 PM, Tobias Jakobi wrote: > This updates the blending setup when the layer configuration > changes (triggered by mixer_win_{commit,disable}). > > Extra care has to be taken for the layer that is currently > being enabled/disabled. > > Signed-off-by: Tobias Jakobi > --- > driv

[PATCH 0/5] drm/exynos: rework layer blending setup

2015-05-22 Thread Joonyoung Shim
Hi Tobias, On 05/22/2015 05:07 PM, Tobias Jakobi wrote: > Hello Joonyoung, > > On 2015-05-22 06:04, Joonyoung Shim wrote: >> Hi Tobias, >> >> On 05/22/2015 05:44 AM, Tobias Jakobi wrote: >>> Gentle reminder that I still haven't heard anything

[PATCH v7 12/13] drm/exynos: atomic dpms support

2015-05-27 Thread Joonyoung Shim
elper of ptn3460 bridge > > Signed-off-by: Gustavo Padovan > Reviewed-by: Joonyoung Shim > Tested-by: Tobias Jakobi > --- > drivers/gpu/drm/bridge/ps8622.c | 2 +- > drivers/gpu/drm/bridge/ptn3460.c| 2 +- > drivers/gpu/drm/exynos/exynos_dp_core

[PATCH v7 02/13] drm/exynos: atomic phase 1: use drm_plane_helper_update()

2015-05-27 Thread Joonyoung Shim
; > Update all users of exynos_update_plane() accordingly to call > exynos_check_plane() before. > > Signed-off-by: Gustavo Padovan > Reviewed-by: Joonyoung Shim > Tested-by: Tobias Jakobi y > --- > drivers/gpu/drm/exynos/exynos_drm_crtc.c | 23 ++ >

[PATCH v6 03/12] drm/exynos: atomic phase 1: add .mode_set_nofb() callback

2015-05-27 Thread Joonyoung Shim
On 05/23/2015 12:33 AM, Gustavo Padovan wrote: > Hi Joonyoung, > > 2015-05-22 Joonyoung Shim : > >> On 05/22/2015 05:02 AM, Gustavo Padovan wrote: >>> From: Gustavo Padovan >>> >>> The new atomic infrastructure needs the .mode_set_nofb() callback

[PATCH] xf86drm: fix build error by udev dependency

2015-05-28 Thread Joonyoung Shim
lude "libudev.h" ^ compilation terminated. make[2]: *** [libdrm_la-xf86drm.lo] Error 1 Signed-off-by: Joonyoung Shim --- xf86drm.c | 4 1 file changed, 4 insertions(+) diff --git a/xf86drm.c b/xf86drm.c index b5a174b..4a31019 100644 --- a/xf86drm.c +++ b/xf86drm.c @@ -63,7 +63,9

[PATCH] xf86drm: remove to open the DRM device unnecessarily

2015-05-28 Thread Joonyoung Shim
This is to remove to open the DRM device unnecessarily as call drmAvailable() when name is NULL or drm_server_info is NULL in drmOpenWithType function. Signed-off-by: Joonyoung Shim --- xf86drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xf86drm.c b/xf86drm.c index

[PATCH v7 12/13] drm/exynos: atomic dpms support

2015-05-28 Thread Joonyoung Shim
gt;>>> v2: Address comments by Joonyoung: >>>>- make hdmi code call ->disable() instead of ->dpms() >>>>- do not use WARN_ON on crtc enable/disable >>>> >>>> v3: - Fix build failure after the hdmi change in v2 >

[PATCH v8 02/14] drm/exynos: atomic phase 1: use drm_plane_helper_update()

2015-05-28 Thread Joonyoung Shim
; > Update all users of exynos_update_plane() accordingly to call > exynos_check_plane() before. > > Signed-off-by: Gustavo Padovan > Reviewed-by: Joonyoung Shim > Tested-by: Tobias Jakobi y > --- > drivers/gpu/drm/exynos/exynos_drm_crtc.c | 31

[PATCH v8 04/14] drm/exynos: atomic phase 1: add .mode_set_nofb() callback

2015-05-28 Thread Joonyoung Shim
On 05/28/2015 05:56 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > The new atomic infrastructure needs the .mode_set_nofb() callback to > update CRTC timings before setting any plane. > > Signed-off-by: Gustavo Padovan > Reviewed-by: Joonyoung Shim >

[PATCH v8 08/14] drm/exynos: atomic phase 3: use atomic .set_config helper

2015-05-28 Thread Joonyoung Shim
On 05/28/2015 05:56 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > Now that phase 1 and 2 are complete switch .set_config helper to > use the atomic one. > > v2: also remove .prepare() callback > > Signed-off-by: Gustavo Padovan > Reviewed-by: Joonyoun

[PATCH v7 12/13] drm/exynos: atomic dpms support

2015-05-28 Thread Joonyoung Shim
On 05/28/2015 05:24 PM, Joonyoung Shim wrote: > On 05/28/2015 02:39 PM, Inki Dae wrote: >> Hi Gustavo, >> >> On 2015년 05월 28일 05:27, Gustavo Padovan wrote: >>> Hi Inki, >>> >>> 2015-05-27 Inki Dae : >>> >>>> Hi G

[PATCH v7 12/13] drm/exynos: atomic dpms support

2015-05-29 Thread Joonyoung Shim
On 05/29/2015 06:36 AM, Gustavo Padovan wrote: > 2015-05-28 Joonyoung Shim : > >> On 05/28/2015 05:24 PM, Joonyoung Shim wrote: >>> On 05/28/2015 02:39 PM, Inki Dae wrote: >>>> Hi Gustavo, >>>> >>>> On 2015년 05월 28일 05:27, Gustavo

[PATCH v8 04/14] drm/exynos: atomic phase 1: add .mode_set_nofb() callback

2015-05-29 Thread Joonyoung Shim
On 05/28/2015 05:24 PM, Joonyoung Shim wrote: > On 05/28/2015 05:56 AM, Gustavo Padovan wrote: >> From: Gustavo Padovan >> >> The new atomic infrastructure needs the .mode_set_nofb() callback to >> update CRTC timings before setting any plane. >> >> Signed-

[PATCH v9 13/18] drm/exynos: add exynos specific .atomic_commit()

2015-05-29 Thread Joonyoung Shim
On 05/29/2015 06:42 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > exynos needs to update planes with the crtc enabled (mainly for the FIMD > case) so this specific atomic commit changes the order of > drm_atomic_helper_commit_modeset_enables() and > drm_atomic_helper_commit_planes() to c

[PATCH v9 16/18] drm/exynos: split exynos_crtc->dpms in enable() and disable()

2015-05-29 Thread Joonyoung Shim
On 05/29/2015 06:42 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > To follow more closely the new atomic API we split the dpms() > helper into the enable() and disable() helper to get exactly the > same semantics. > > Signed-off-by: Gustavo Padovan > --- > drivers/gpu/drm/exynos/exynos

[PATCH] drm/exynos: use adjusted_mode of crtc_state instead of mode

2015-05-29 Thread Joonyoung Shim
Handle changes by removing copy from adjusted_mode to mode as using adjusted_mode of crtc_state. Signed-off-by: Joonyoung Shim --- This is based on a patch "[PATCH v9 04/18] drm/exynos: atomic phase 1: add .mode_set_nofb() callback" of Gustavo. drivers/gpu/drm/exynos/exynos7_drm_de

[PATCH] xf86drm: fix build error by udev dependency

2015-05-29 Thread Joonyoung Shim
On 05/28/2015 10:02 PM, Emil Velikov wrote: > On 28 May 2015 at 00:56, Joonyoung Shim wrote: >> The build error is introduced by commit fde496917682 ("Add device >> enumeration interface (v4)") if don't enable udev. Can solve as check >> UDEV dependency. &

[PATCH] xf86drm: remove to open the DRM device unnecessarily

2015-05-29 Thread Joonyoung Shim
On 28 May 2015 at 15:15, Daniel Kurtz wrote: >> It's not necessary if we are about to skip the rest of the if clause anyway >> because name is NULL. >> >> On May 28, 2015 9:14 PM, "Emil Velikov" wrote: >>> >>> On 28 May 2015 at 00:57, Joonyo

[PATCH] drm/exynos: use adjusted_mode of crtc_state instead of mode

2015-06-01 Thread Joonyoung Shim
On 05/30/2015 12:57 AM, Gustavo Padovan wrote: > Hi Joonyoung, > > 2015-05-29 Joonyoung Shim : > >> Handle changes by removing copy from adjusted_mode to mode as using >> adjusted_mode of crtc_state. >> >> Signed-off-by: Joonyoung Shim >> --- >>

[PATCH v7 12/13] drm/exynos: atomic dpms support

2015-06-01 Thread Joonyoung Shim
On 05/30/2015 06:33 AM, Gustavo Padovan wrote: > 2015-05-29 Joonyoung Shim : > >> On 05/29/2015 06:36 AM, Gustavo Padovan wrote: >>> 2015-05-28 Joonyoung Shim : >>> >>>> On 05/28/2015 05:24 PM, Joonyoung Shim wrote: >>>>> On 05/28/2015 02:3

[PATCH] xf86drm: fix build error by udev dependency

2015-06-01 Thread Joonyoung Shim
On 05/30/2015 10:02 PM, Emil Velikov wrote: > On 29 May 2015 at 07:34, Joonyoung Shim wrote: >> On 05/28/2015 10:02 PM, Emil Velikov wrote: >>> On 28 May 2015 at 00:56, Joonyoung Shim wrote: >>>> The build error is introduced by commit fde496917682 ("Add de

[PATCH] xf86drm: remove to open the DRM device unnecessarily

2015-06-01 Thread Joonyoung Shim
On 05/30/2015 10:20 PM, Emil Velikov wrote: > On 29 May 2015 at 07:50, Joonyoung Shim wrote: >> On 05/29/2015 12:51 AM, Emil Velikov wrote: >>> Seems like I'm either too subtle and/or too stingy earlier. >>> >>> If drmAvailable() returns false, we have tw

drm/exynos: when to call dma_map_sg() on a GEM object?

2015-11-02 Thread Joonyoung Shim
On 10/31/2015 05:44 AM, Tobias Jakobi wrote: > Hey there, > > this question arose during some discussion with someone concerning the > Exynos mixer and G2D. > > The question is the following. Consider the Exynos mixer when run under > the IOMMU (that's sysmmu_tv IIRC). What exactly does setup the

[PATCH] drm/exynos: control blending of mixer graphic layer 0

2014-07-25 Thread Joonyoung Shim
The mixer graphic layer 0 isn't blended as default by commit 0377f4ed9f1aed30292c4e3c87f24e028ae26f36(drm/exynos: Don't blend mixer layer 0). But it needs to be blended with graphic layer 0 if video layer is enabled by vp because video layer is bottom. Signed-off-by: Joonyoung Shim --

[PATCH] drm: add checking DRM_FORMAT_NV12MT

2014-07-28 Thread Joonyoung Shim
If user NV12MT uses as pixel format, the Addfb2 ioctl is failed because of missing to check DRM_FORMAT_NV12MT. The NV12MT pixel format is supported by exynos4 and some qualcomm chipset and it is used by exynos drm driver. Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/drm_crtc.c | 5 + 1

Re: [PATCH 1/3] drm: use common drm_gem_dmabuf_release in i915/exynos drivers

2013-08-07 Thread Joonyoung Shim
On 08/07/2013 06:55 PM, Daniel Vetter wrote: On Wed, Aug 7, 2013 at 11:40 AM, Inki Dae wrote: -Original Message- From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] Sent: Wednesday, August 07, 2013 6:15 PM To: DRI Development Cc: Intel Graphics Development; Daniel Vetter; Inki Dae Subje

Re: [PATCH 1/3] drm: use common drm_gem_dmabuf_release in i915/exynos drivers

2013-08-07 Thread Joonyoung Shim
On 08/07/2013 07:21 PM, Daniel Vetter wrote: On Wed, Aug 07, 2013 at 07:18:45PM +0900, Joonyoung Shim wrote: On 08/07/2013 06:55 PM, Daniel Vetter wrote: On Wed, Aug 7, 2013 at 11:40 AM, Inki Dae wrote: -Original Message- From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] Sent

[PATCH] drm/exynos: add has_vtsel flag

2014-11-05 Thread Joonyoung Shim
The exynos fimd provides video type selection bits from system register but exynos3 series don't has it, so needs has_vtsel flag and we can distinguish whether set video type selection bits. Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 6 +- 1 file chang

[PATCH] drm/exynos: add has_vtsel flag

2014-11-05 Thread Joonyoung Shim
The exynos fimd provides video type selection bits from system register but exynos3 series don't has it, so needs has_vtsel flag and we can distinguish whether set video type selection bits. Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 6 +- 1 file chang

[PATCH] drm/exynos: add has_vtsel flag

2014-11-05 Thread Joonyoung Shim
The exynos fimd provides video type selection bits from system register but exynos3 series don't has it, so needs has_vtsel flag and we can distinguish whether set video type selection bits. Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 6 +- 1 file chang

[PATCH v2] drm/exynos: add has_vtsel flag

2014-11-14 Thread Joonyoung Shim
The exynos fimd provides video type selection bits from system register but exynos3 series don't has it, so needs has_vtsel flag and we can distinguish whether set video type selection bits. Signed-off-by: Joonyoung Shim --- Changelog from v1: - rebase on latest exynos-drm-next branch

[PATCH 1/2] drm/exynos: move triggering checking

2014-11-14 Thread Joonyoung Shim
It's better to be checking whether triggerring in fimd_trigger function. Also it will return if in triggerring on fimd_te_handler, then it can't execute remain codes. Signed-off-by: Joonyoung Shim --- Based on lastest exynos-drm-next branch. drivers/gpu/drm/exynos/exynos_drm_f

[PATCH 2/2] drm/exynos: use irq_flags instead of triggering

2014-11-14 Thread Joonyoung Shim
The drm_handle_vblank should be called whenever be vsync, te interrupt means vsync on i80 interface. Signed-off-by: Joonyoung Shim --- Based on lastest exynos-drm-next branch and patch of Youngjun Cho ("drm/exynos: fimd: move handle vblank position in TE handler"). drivers/gpu/

[PATCH 2/2] drm/exynos: use irq_flags instead of triggering

2014-11-14 Thread Joonyoung Shim
Hi, On 11/14/2014 02:01 PM, YoungJun Cho wrote: > Hi JoonYoung, > > On 11/14/2014 11:36 AM, Joonyoung Shim wrote: >> The drm_handle_vblank should be called whenever be vsync, te interrupt >> means vsync on i80 interface. > > That's right. > >> >>

[PATCH 08/14] drm/exynos: create a fake mmap offset with gem creation

2015-08-17 Thread Joonyoung Shim
On 08/16/2015 01:50 PM, Inki Dae wrote: > On 2015년 07월 28일 17:53, Joonyoung Shim wrote: >> Don't create a fake mmap offset in exynos_drm_gem_dumb_map_offset. If >> not, it will call drm_gem_create_mmap_offset whenever user requests >> DRM_IOCTL_MODE_MAP_DUMB io

[PATCH 09/14] drm/exynos: remove call to drm_gem_free_mmap_offset()

2015-08-17 Thread Joonyoung Shim
On 08/16/2015 02:07 PM, Inki Dae wrote: > On 2015년 07월 28일 17:53, Joonyoung Shim wrote: >> The drm_gem_object_release() function already performs this cleanup, >> so there is no reason to do it explicitly. >> >> Signed-off-by: Joonyoung Shim >&g

[PATCH 09/14] drm/exynos: remove call to drm_gem_free_mmap_offset()

2015-08-17 Thread Joonyoung Shim
On 08/17/2015 04:52 PM, Inki Dae wrote: > On 2015년 08월 17일 14:29, Joonyoung Shim wrote: >> On 08/16/2015 02:07 PM, Inki Dae wrote: >>> On 2015년 07월 28일 17:53, Joonyoung Shim wrote: >>>> The drm_gem_object_release() function already performs this cleanup,

[PATCH] drm/exynos: fix exynos_drm_gem_prime_import_sg_table() error handling

2015-08-27 Thread Joonyoung Shim
If exynos_drm_gem_init() is failed, the result is ERR_PTR, so we should just return the result. If not, wrong porinter will be referenced from err label. Reported-by: Dan Carpenter Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/exynos/exynos_drm_gem.c | 6 ++ 1 file changed, 2

[PATCH] drm/exynos: fix exynos_drm_gem_prime_import_sg_table() error handling

2015-09-01 Thread Joonyoung Shim
On 08/31/2015 01:10 AM, Inki Dae wrote: > 2015-08-27 17:31 GMT+09:00 Joonyoung Shim : >> If exynos_drm_gem_init() is failed, the result is ERR_PTR, so we should >> just return the result. If not, wrong porinter will be referenced from >> err label. >> >> Reported

[PATCH v3 16/17] drm/exynos/ipp: remove file argument from node related functions

2014-09-03 Thread Joonyoung Shim
xynos/exynos_drm_ipp.c | 12 +--- > 1 file changed, 5 insertions(+), 7 deletions(-) > About both patch 16 and 17 Reviewed-by: Joonyoung Shim Thanks. > diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c > b/drivers/gpu/drm/exynos/exynos_drm_ipp.c > index 05f0f4e..9e9714a 100644 >

[PATCH] drm/exynos: use a new anon file for exynos gem mmaper

2014-09-11 Thread Joonyoung Shim
Hi, On 09/11/2014 03:22 PM, Daniel Vetter wrote: > On Thu, Sep 11, 2014 at 11:16:53AM +0900, Inki Dae wrote: >> On 2014? 09? 10? 18:01, Daniel Vetter wrote: >>> Ok I've stumbled over the exynos mmap stuff again while cleaning up >>> drm legacy cruft and I just don't get what you're doing and why >

[PATCH] drm/exynos: fix plane-framebuffer linkage

2014-09-17 Thread Joonyoung Shim
Hi, On 09/17/2014 03:49 PM, Inki Dae wrote: > On 2014? 09? 17? 15:35, Andrzej Hajda wrote: >> Hi, >> >> On 09/16/2014 08:35 AM, Daniel Vetter wrote: >>> On Mon, Sep 15, 2014 at 12:52:17PM -0600, Daniel Drake wrote: Pageflipping currently causes some inconsistencies that lead to crashes.

-next mostly closed, what have I missed?

2014-09-17 Thread Joonyoung Shim
Hi Dave, On 09/17/2014 09:59 AM, Dave Airlie wrote: > Okay so I'm pretty sure I'm close to not taking anything major for next, > > I'm not sure I've gotten an exynos tree yet, so hopefully that appears > before -rc6, > > Please continue to send fixes for -next pulls, and I'm kinda open to > new

[PATCH] drm/exynos: fix plane-framebuffer linkage

2014-09-18 Thread Joonyoung Shim
Hi, On 09/18/2014 01:41 AM, Daniel Drake wrote: > On Wed, Sep 17, 2014 at 7:45 AM, Daniel Vetter wrote: >> I think fb refcounting in exynos is just plain busted. If you look at >> other drivers the only place the refcount framebuffers or backing >> storage objects is for pageflips to make sure th

[PATCH 2/2] drm/exynos: use drm generic mmap interface

2014-09-18 Thread Joonyoung Shim
Hi, On 09/17/2014 10:48 PM, Inki Dae wrote: > This patch removes DRM_EXYNOS_GEM_MMAP ictrl feature specific > to Exynos drm and instead uses drm generic mmap. > > We had used the interface specific to Exynos drm to do mmap directly, > not to use demand paging which maps each page with physical me

[PATCH] drm/exynos: factor out initial setting of each driver

2014-09-18 Thread Joonyoung Shim
>From fimd driver and vidi driver, dev->irq_enabled and dev->vblank_disable_allowed are set and also mixer needs them even if missed. It's duplicated so set them when loads drm driver. Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 17

[PATCH] drm/exynos: switch to universal plane API

2014-09-19 Thread Joonyoung Shim
Hi Andrzej, On 09/18/2014 10:17 PM, Andrzej Hajda wrote: > The patch replaces legacy functions > drm_plane_init() / drm_crtc_init() with > drm_universal_plane_init() and drm_crtc_init_with_planes(). > It allows to replace fake primary plane with the real one. > > Signed-off-by: Andrzej Hajda > -

[PATCH] drm/exynos: switch to universal plane API

2014-09-19 Thread Joonyoung Shim
Hi, On 09/19/2014 07:54 PM, Andrzej Hajda wrote: > On 09/19/2014 03:02 AM, Joonyoung Shim wrote: >> Hi Andrzej, >> >> On 09/18/2014 10:17 PM, Andrzej Hajda wrote: >>> The patch replaces legacy functions >>> drm_plane_init() / drm_crtc_init()

[PATCH] drm/exynos: switch to universal plane API

2014-09-19 Thread Joonyoung Shim
Hi, On 09/19/2014 08:11 PM, Joonyoung Shim wrote: > Hi, > > On 09/19/2014 07:54 PM, Andrzej Hajda wrote: >> On 09/19/2014 03:02 AM, Joonyoung Shim wrote: >>> Hi Andrzej, >>> >>> On 09/18/2014 10:17 PM, Andrzej Hajda wrote: >>>> T

[PATCH 09/10] drm/exynos: remove exported functions from exynos_drm_plane

2015-04-02 Thread Joonyoung Shim
Hi, On 03/28/2015 12:58 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > Now that no one is using the functions exported by exynos_drm_plane due > to the atomic conversion we can make remove some of the them or make them > static. > > Signed-off-by: Gustavo Padovan > --- > drivers/gpu/d

[PATCH 10/10] drm/exynos: atomic dpms support

2015-04-02 Thread Joonyoung Shim
Hi, On 03/31/2015 04:11 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > Run dpms operations through the atomic intefaces. This basically removes > the .dpms() callback from econders and crtcs and use .disable() and > .enable() to turn the crtc on and off. > > Signed-off-by: Gustavo Padov

[PATCH 09/14] drm/exynos: remove call to drm_gem_free_mmap_offset()

2015-09-24 Thread Joonyoung Shim
Hi Inki, On 08/17/2015 06:03 PM, Inki Dae wrote: > On 2015년 08월 17일 17:17, Joonyoung Shim wrote: >> On 08/17/2015 04:52 PM, Inki Dae wrote: >>> On 2015년 08월 17일 14:29, Joonyoung Shim wrote: >>>> On 08/16/2015 02:07 PM, Inki Dae wrote: >>>>>

[PATCH 09/14] drm/exynos: remove call to drm_gem_free_mmap_offset()

2015-09-30 Thread Joonyoung Shim
On 09/25/2015 06:15 PM, Inki Dae wrote: > On 2015년 09월 24일 10:01, Joonyoung Shim wrote: >> Hi Inki, >> >> On 08/17/2015 06:03 PM, Inki Dae wrote: >>> On 2015년 08월 17일 17:17, Joonyoung Shim wrote: >>>> On 08/17/2015 04:52 PM, Inki Dae wrote: >

[PATCH 2/2] drm/exynos: fix imported dma-buf to be mapped

2016-04-22 Thread Joonyoung Shim
The imported dma-buf should be mapped by sub-system exporting it. Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/exynos/exynos_drm_gem.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos/exynos_drm_gem.c index

[PATCH 1/2] drm/exynos: support gem_prime_mmap

2016-04-22 Thread Joonyoung Shim
This allows exported dma-bufs to be mapped using gem_prime_mmap. Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 1 + drivers/gpu/drm/exynos/exynos_drm_gem.c | 45 +++-- drivers/gpu/drm/exynos/exynos_drm_gem.h | 2 ++ 3 files changed, 35

[PATCH] drm/exynos: use directly DMA mapping APIs on g2d

2016-04-22 Thread Joonyoung Shim
There is no reason to be wapper functions to use DMA mapping APIs. Use directly DMA mapping APIs and remove the wapper functions. Signed-off-by: Joonyoung Shim --- This is based on linux-next for 20160422. drivers/gpu/drm/exynos/exynos_drm_g2d.c | 10 +- drivers/gpu/drm/exynos

[PATCH 11/14] drm: exynos: hdmi: add support for exynos5 mixer

2012-10-02 Thread Joonyoung Shim
On 09/28/2012 11:25 PM, Rahul Sharma wrote: > This patch adds support for exynos5 mixer with device tree enabled. > > Signed-off-by: Rahul Sharma > Signed-off-by: Fahad Kunnathadi > --- > drivers/gpu/drm/exynos/exynos_mixer.c | 41 > ++-- > drivers/gpu/drm/exynos

[PATCH 09/14] drm: exynos: hdmi: add support for platform variants for mixer

2012-10-02 Thread Joonyoung Shim
On 09/28/2012 11:25 PM, Rahul Sharma wrote: > This patch adds the support for multiple mixer versions avaialble in > various platform variants. Version is passed as a driver data field > instead of paltform data. > > Signed-off-by: Rahul Sharma > --- > drivers/gpu/drm/exynos/exynos_mixer.c | 2

[PATCH 00/14] drm: exynos: hdmi: add dt based support for exynos5 hdmi

2012-10-02 Thread Joonyoung Shim
Hi, On 09/28/2012 11:25 PM, Rahul Sharma wrote: > This patch set adds the DT based support for Samsung's Exynos5250 in DRM-HDMI. > It includes disabling of hdmi internal interrupt, suppport for platform > variants for hdmi and mixer, support to disable video processor based on > platform type and

[PATCH] drm/edid: fix interlace mode name

2012-09-10 Thread Joonyoung Shim
The some modes to support interlace have "i" character at the end of name from drm_mode_set_name(). For consistency, this patch adds "i" character at the end of name of interlaced modes defined in drm_edid_modes.h file. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Pa

[PATCH] drm/edid: fix interlace mode name

2012-09-11 Thread Joonyoung Shim
On 09/10/2012 09:48 PM, Alex Deucher wrote: > On Mon, Sep 10, 2012 at 7:35 AM, Paul Menzel > wrote: >> Am Montag, den 10.09.2012, 19:23 +0900 schrieb Joonyoung Shim: >>> The some modes to support interlace have "i" character at the end of >> In `drm_m

[PATCH 1/4] drm/exynos: fix fb offset calculation for plane

2012-12-13 Thread Joonyoung Shim
There is no any reason to change fb offset when CRTC is out of screen. Also, this fixes a typing error. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_plane.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers

[PATCH 0/4] drm/exynos: update plane and fimd

2012-12-13 Thread Joonyoung Shim
This patchset is to update plane and fimd of exynos-drm. it includes modification about coordinates calculation of plane and fimd and device tree support of fimd. The patchset is based exynos-drm-next branch on of git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git Joonyoung

[PATCH 2/4] drm/exynos: fix x, y coordinates for right bottom pixel

2012-12-13 Thread Joonyoung Shim
The x, y coordinates of right bottom pixel cannot be negative numbers. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/exynos

[PATCH 3/4] drm/exynos: support extended screen coordinate of fimd

2012-12-13 Thread Joonyoung Shim
The fimd of exynos5 SoC supports extended screen coordinate. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c

[PATCH 4/4] drm/exynos: support device tree for fimd

2012-12-13 Thread Joonyoung Shim
This adds the of_match_table to exynos-drm fimd driver to be probed from the device tree. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/gpu/drm/exynos

Re: [PATCH V3 1/2] drm/exynos: add platform_device_id table and driver data for exynos5 drm fimd

2012-08-16 Thread Joonyoung Shim
> .probe = fimd_probe, > .remove = __devexit_p(fimd_remove), > + .id_table = exynos_drm_fimd_driver_ids, > .driver = { > - .name = "exynos4-fb", > + .name = "exynos-drm-fimd", > .owner = THIS_MODULE, > .pm = &fimd_pm_ops, > }, > -- > 1.7.0.4 > > ___ > devicetree-discuss mailing list > devicetree-disc...@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/devicetree-discuss Thanks. -- - Joonyoung Shim ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH V3 2/2] video: drm: exynos: Add device tree support

2012-08-16 Thread Joonyoung Shim
eturn PTR_ERR(pdata); > + } > if (!pdata) { > dev_err(dev, "no platform data specified\n"); > return -EINVAL; > @@ -1027,6 +1108,15 @@ static struct platform_device_id > exynos_drm_fimd_dri

Re: [PATCH 02/13] drm/exynos: separated subdrv->probe call and encoder/connector creation.

2012-08-19 Thread Joonyoung Shim
On 08/17/2012 06:50 PM, Inki Dae wrote: this patch separates sub driver's probe call and encoder/connector creation so that exynos drm core module can take exception when some operation was failed properly. Which exceptions? I don't know this patch gives any benefit to us. Signed-off-by: Ink

Re: [PATCH 04/13] drm/exynos: use empty function instead of drm_helper_connector_dpms

2012-08-19 Thread Joonyoung Shim
On 08/17/2012 06:50 PM, Inki Dae wrote: crtc and encoder's dpms callback will be called before connector's dpms is called so drm_helper_connector_dpms doesn't need to be called. I can't understand this description. I know crtc and encoder dpms are called by drm_helper_connector_dpms. Signed-o

Re: [PATCH 05/13] drm/exynos: removed exynos_drm_encoder_dpms call

2012-08-19 Thread Joonyoung Shim
On 08/17/2012 06:50 PM, Inki Dae wrote: encoder's mode_set callback isn't specific to hardware so it doesn't need to call exynos_drm_encoder_dpms(). Then, where is exynos_drm_encoder_dpms() called? Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm

Re: [PATCH 09/13] drm/exynos: check NV12M format specific to Exynos properly

2012-08-19 Thread Joonyoung Shim
On 08/17/2012 06:50 PM, Inki Dae wrote: this patch adds buf_cnt variable in exynos_drm_fb structure and that means a buffer count to drm framebuffer and also adds two functions to get/set the buffer count from/to exynos_drm_fb structure. if pixel format is not DRM_FORMAT_NV12MT then it gets a buf

Re: [PATCH 10/13] drm/exynos: update crtc to plane safely

2012-08-19 Thread Joonyoung Shim
On 08/17/2012 06:50 PM, Inki Dae wrote: if old_crtc isn't same as encoder->crtc then it means that user changed crtc id to another one so a plane to old_crtc should be disabled so that current plane can be updated safely and plane->crtc should be set to new crtc(encoder->crtc) Signed-off-by: Ink

Re: [PATCH 11/13] drm/exynos: changed context name of hdmi and mixer

2012-08-19 Thread Joonyoung Shim
On 08/17/2012 06:50 PM, Inki Dae wrote: this patch changes ctx variable name in exynos_drm_hdmi_context structure to client because the use of ctx variable makes it confused. I don't prefer "client" name. This is not client and server relationship. Signed-off-by: Inki Dae Signed-off-by: Kyu

Re: [PATCH V3 2/2] video: drm: exynos: Add device tree support

2012-08-19 Thread Joonyoung Shim
On 08/17/2012 06:37 PM, Leela Krishna Amudala wrote: Hello, On Fri, Aug 17, 2012 at 6:55 AM, Joonyoung Shim wrote: Hi, 2012/8/16 Leela Krishna Amudala : Add device tree based discovery support for DRM-FIMD driver. Signed-off-by: Leela Krishna Amudala --- Documentation/devicetree

Re: [PATCH 02/13] drm/exynos: separated subdrv->probe call and encoder/connector creation.

2012-08-19 Thread Joonyoung Shim
On 08/20/2012 10:52 AM, InKi Dae wrote: 2012/8/20 Joonyoung Shim : On 08/17/2012 06:50 PM, Inki Dae wrote: this patch separates sub driver's probe call and encoder/connector creation so that exynos drm core module can take exception when some operation was failed properly. Which excep

Re: [PATCH 08/13] drm/exynos: make sure that hardware overlay for fimd is disabled

2012-08-19 Thread Joonyoung Shim
On 08/17/2012 06:50 PM, Inki Dae wrote: the values set to registers will be updated into real registers at vsync so dma operation could be malfunctioned when accessed to memory after gem buffer was released. this patch makes sure that hw overlay is disabled before the gem buffer is released. Sig

Re: [PATCH 02/13] drm/exynos: separated subdrv->probe call and encoder/connector creation.

2012-08-19 Thread Joonyoung Shim
On 08/20/2012 01:31 PM, InKi Dae wrote: 2012/8/20 Joonyoung Shim : On 08/20/2012 10:52 AM, InKi Dae wrote: 2012/8/20 Joonyoung Shim : On 08/17/2012 06:50 PM, Inki Dae wrote: this patch separates sub driver's probe call and encoder/connector creation so that exynos drm core module can

Re: [PATCH 09/13] drm/exynos: check NV12M format specific to Exynos properly

2012-08-19 Thread Joonyoung Shim
On 08/20/2012 11:23 AM, InKi Dae wrote: 2012/8/20 Joonyoung Shim : On 08/17/2012 06:50 PM, Inki Dae wrote: this patch adds buf_cnt variable in exynos_drm_fb structure and that means a buffer count to drm framebuffer and also adds two functions to get/set the buffer count from/to exynos_drm_fb

Re: [PATCH 11/13] drm/exynos: changed context name of hdmi and mixer

2012-08-19 Thread Joonyoung Shim
On 08/20/2012 11:29 AM, InKi Dae wrote: 2012/8/20 Joonyoung Shim : On 08/17/2012 06:50 PM, Inki Dae wrote: this patch changes ctx variable name in exynos_drm_hdmi_context structure to client because the use of ctx variable makes it confused. I don't prefer "client" name. Thi

Re: [PATCH 09/13] drm/exynos: check NV12M format specific to Exynos properly

2012-08-19 Thread Joonyoung Shim
On 08/20/2012 02:15 PM, InKi Dae wrote: sorry, again. 2012/8/20 InKi Dae : 2012/8/20 Joonyoung Shim : On 08/20/2012 11:23 AM, InKi Dae wrote: 2012/8/20 Joonyoung Shim : On 08/17/2012 06:50 PM, Inki Dae wrote: this patch adds buf_cnt variable in exynos_drm_fb structure and that means a

Re: [PATCH 11/13] drm/exynos: changed context name of hdmi and mixer

2012-08-19 Thread Joonyoung Shim
On 08/20/2012 03:17 PM, InKi Dae wrote: 2012/8/20 Joonyoung Shim : On 08/20/2012 11:29 AM, InKi Dae wrote: 2012/8/20 Joonyoung Shim : On 08/17/2012 06:50 PM, Inki Dae wrote: this patch changes ctx variable name in exynos_drm_hdmi_context structure to client because the use of ctx variable

Re: [PATCH] drm/exynos: Make g2d_pm_ops static

2012-08-29 Thread Joonyoung Shim
On 08/28/2012 05:41 PM, Sachin Kamat wrote: Fixes the following warning: drivers/gpu/drm/exynos/exynos_drm_g2d.c:897:1: warning: symbol 'g2d_pm_ops' was not declared. Should it be static? Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_g2d.c |2 +- 1 files changed, 1 in

[PATCH] drm/edid: fix interlace mode name

2012-09-10 Thread Joonyoung Shim
The some modes to support interlace have "i" character at the end of name from drm_mode_set_name(). For consistency, this patch adds "i" character at the end of name of interlaced modes defined in drm_edid_modes.h file. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Pa

Re: [PATCH] drm/edid: fix interlace mode name

2012-09-10 Thread Joonyoung Shim
On 09/10/2012 09:48 PM, Alex Deucher wrote: On Mon, Sep 10, 2012 at 7:35 AM, Paul Menzel wrote: Am Montag, den 10.09.2012, 19:23 +0900 schrieb Joonyoung Shim: The some modes to support interlace have "i" character at the end of In `drm_mode_set_name()` from `drivers/gpu/drm/d

Re: [PATCH 2/3] drm: exynos: hdmi: add exynos5 support to hdmi driver

2012-09-12 Thread Joonyoung Shim
Hi, Rahul. Overall, i think this patch causes messy codes. On 09/12/2012 09:08 PM, Rahul Sharma wrote: Added support for exynos5 to hdmi driver. Resource init is splitted for exynos5 and exynos4. Exynos5 hdmi driver is dt based while exynos4 hdmi driver is not. Signed-off-by: Rahul Sharma Sig

  1   2   3   4   5   6   >