Re: [PATCH] drm/i915/guc: Don't send policy update for child contexts.

2022-07-27 Thread John Harrison
On 7/27/2022 18:50, Ceraolo Spurio, Daniele wrote: On 7/27/2022 6:44 PM, John Harrison wrote: On 7/27/2022 17:33, Daniele Ceraolo Spurio wrote: The GuC FW applies the parent context policy to all the children, so individual updates to the children are not supported and we should not send them

Re: [PATCH 2/6] drm/i915/guc: Fix issues with live_preempt_cancel

2022-07-27 Thread John Harrison
the error from the dependent request is propagated. Fix live_preempt_cancel to take this behavior into account. Also update live_preempt_cancel to use new function intel_context_ban rather than intel_context_set_banned. Signed-off-by: Matthew Brost Signed-off-by: John Harrison Reviewed-by

Re: [PATCH 5/6] drm/i915/guc: Support larger contexts on newer hardware

2022-07-27 Thread John Harrison
Signed-off-by: John Harrison Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c index ba7541f3ca610

Re: [PATCH 3/6] drm/i915/guc: Add selftest for a hung GuC

2022-07-28 Thread John Harrison
On 7/27/2022 19:42, john.c.harri...@intel.com wrote: From: Rahul Kumar Singh Add a test to check that the hangcheck will recover from a submission hang in the GuC. Signed-off-by: Rahul Kumar Singh Signed-off-by: John Harrison --- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 1

Re: [PATCH 3/6] drm/i915/guc: Add selftest for a hung GuC

2022-07-28 Thread John Harrison
On 7/28/2022 11:26, john.c.harri...@intel.com wrote: From: Rahul Kumar Singh Add a test to check that the hangcheck will recover from a submission hang in the GuC. Signed-off-by: Rahul Kumar Singh Signed-off-by: John Harrison Reviewed-by: John Harrison --- .../gpu/drm/i915/gt/uc

Re: [Intel-gfx] [PATCH 6/6] drm/i915/guc: Don't abort on CTB_UNUSED status

2022-07-28 Thread John Harrison
On 7/28/2022 12:06, Michal Wajdeczko wrote: On 28.07.2022 04:42, john.c.harri...@intel.com wrote: From: John Harrison When the KMD sends a CLIENT_RESET request to GuC (as part of the suspend sequence), GuC will mark the CTB buffer as 'UNUSED'. If the hmm, GuC shouldn&#x

Re: [Intel-gfx] [PATCH 6/6] drm/i915/guc: Don't abort on CTB_UNUSED status

2022-07-28 Thread John Harrison
On 7/28/2022 17:00, Ceraolo Spurio, Daniele wrote: On 7/27/2022 7:42 PM, john.c.harri...@intel.com wrote: From: John Harrison When the KMD sends a CLIENT_RESET request to GuC (as part of the suspend sequence), GuC will mark the CTB buffer as 'UNUSED'. If the KMD then checked the CTB

Re: [Intel-gfx] [RFC PATCH 60/97] drm/i915: Track 'serial' counts for virtual engines

2021-05-26 Thread John Harrison
On 5/26/2021 01:40, Tvrtko Ursulin wrote: On 25/05/2021 18:52, Matthew Brost wrote: On Tue, May 25, 2021 at 11:16:12AM +0100, Tvrtko Ursulin wrote: On 06/05/2021 20:14, Matthew Brost wrote: From: John Harrison The serial number tracking of engines happens at the backend of request

Re: [Intel-gfx] [RFC PATCH 60/97] drm/i915: Track 'serial' counts for virtual engines

2021-05-27 Thread John Harrison
On 5/27/2021 01:53, Tvrtko Ursulin wrote: On 26/05/2021 19:45, John Harrison wrote: On 5/26/2021 01:40, Tvrtko Ursulin wrote: On 25/05/2021 18:52, Matthew Brost wrote: On Tue, May 25, 2021 at 11:16:12AM +0100, Tvrtko Ursulin wrote: On 06/05/2021 20:14, Matthew Brost wrote: From: John

Re: [Intel-gfx] [PATCH 06/18] drm/i915/guc: Drop guc->interrupts.enabled

2021-05-27 Thread John Harrison
ases in a less catastrophic manner? Or are there valid reasons for calling enable when already enabled? Either way, it seems like a plausible change and CI is happy with it, so: Reviewed-by: John Harrison John. Signed-off-by: Matthew Brost --- drivers/gpu/drm/i915/gt/uc/in

Re: [Intel-gfx] [PATCH 15/18] drm/i915/guc: Ensure H2G buffer updates visible before tail update

2021-05-27 Thread John Harrison
be necessary once the CTBs are up and running. If mixing does occur in the future, it sounds like something that should be addressed at the GuC architecture level! With the comment added: Reviewed-by: John Harrison + } else { + wmb(); + } +} + /** * DOC:

Re: [Intel-gfx] [RFC PATCH 60/97] drm/i915: Track 'serial' counts for virtual engines

2021-06-01 Thread John Harrison
On 6/1/2021 02:31, Tvrtko Ursulin wrote: On 27/05/2021 18:01, John Harrison wrote: On 5/27/2021 01:53, Tvrtko Ursulin wrote: On 26/05/2021 19:45, John Harrison wrote: On 5/26/2021 01:40, Tvrtko Ursulin wrote: On 25/05/2021 18:52, Matthew Brost wrote: On Tue, May 25, 2021 at 11:16:12AM +0100

Re: [PATCH 07/13] drm/i915/guc: New definition of the CTB registration action

2021-06-09 Thread John Harrison
On 6/7/2021 18:23, Daniele Ceraolo Spurio wrote: On 6/7/2021 11:03 AM, Matthew Brost wrote: From: Michal Wajdeczko Definition of the CTB registration action has changed. Add some ABI documentation and implement required changes. Signed-off-by: Michal Wajdeczko Signed-off-by: Matthew Brost C

Re: [Intel-gfx] [PATCH 43/47] drm/i915/guc: Hook GuC scheduling policies up

2021-06-25 Thread John Harrison
On 6/24/2021 17:59, Matthew Brost wrote: On Thu, Jun 24, 2021 at 12:05:12AM -0700, Matthew Brost wrote: From: John Harrison Use the official driver default scheduling policies for configuring the GuC scheduler rather than a bunch of hardcoded values. Signed-off-by: John Harrison Signed-off

Re: [PATCH 09/47] drm/i915/guc: Remove GuC stage descriptor, add lrc descriptor

2021-06-25 Thread John Harrison
On 6/24/2021 00:04, Matthew Brost wrote: Remove old GuC stage descriptor, add lrc descriptor which will be used by the new GuC interface implemented in this patch series. Cc: John Harrison Signed-off-by: Matthew Brost Reviewed-by: John Harrison

Re: [Intel-gfx] [PATCH v4 2/7] drm/i915: Fix up locking around dumping requests lists

2023-01-25 Thread John Harrison
On 1/24/2023 06:40, Tvrtko Ursulin wrote: On 20/01/2023 23:28, john.c.harri...@intel.com wrote: From: John Harrison The debugfs dump of requests was confused about what state requires the execlist lock versus the GuC lock. There was also a bunch of duplicated messy code between it and the

Re: [Intel-gfx] [PATCH v4 2/7] drm/i915: Fix up locking around dumping requests lists

2023-01-25 Thread John Harrison
On 1/25/2023 10:12, Tvrtko Ursulin wrote: On 25/01/2023 18:00, John Harrison wrote: On 1/24/2023 06:40, Tvrtko Ursulin wrote: On 20/01/2023 23:28, john.c.harri...@intel.com wrote: From: John Harrison The debugfs dump of requests was confused about what state requires the execlist lock

Re: [PATCH v4 1/7] drm/i915: Fix request locking during error capture & debugfs dump

2023-01-25 Thread John Harrison
On 1/23/2023 09:51, Tvrtko Ursulin wrote: On 20/01/2023 23:28, john.c.harri...@intel.com wrote: From: John Harrison   -struct i915_request *intel_context_find_active_request(struct intel_context *ce) +struct i915_request *intel_context_find_active_request_get(struct intel_context *ce

Re: [Intel-gfx] [PATCH v2 2/8] drm/i915/guc: Update GuC messages in intel_guc.c

2023-01-27 Thread John Harrison
On 1/24/2023 09:05, Michal Wajdeczko wrote: Use new macros to have common prefix that also include GT#. v2: drop now redundant "GuC" word from the message Signed-off-by: Michal Wajdeczko Cc: John Harrison Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_

Re: [Intel-gfx] [PATCH v2 4/8] drm/i915/guc: Update GuC messages in intel_guc_ct.c

2023-01-27 Thread John Harrison
On 1/24/2023 09:05, Michal Wajdeczko wrote: Use new macros to have common prefix that also include GT#. v2: drop unused helpers Signed-off-by: Michal Wajdeczko Cc: John Harrison Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 23 --- 1

Re: [Intel-gfx] [PATCH v2 6/8] drm/i915/guc: Update GuC messages in intel_guc_log.c

2023-01-27 Thread John Harrison
On 1/24/2023 09:05, Michal Wajdeczko wrote: Use new macros to have common prefix that also include GT#. v2: drop redundant GuC strings, minor improvements Signed-off-by: Michal Wajdeczko Cc: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 37 -- 1 file

Re: [Intel-gfx] [PATCH v2 7/8] drm/i915/guc: Update GuC messages in intel_guc_submission.c

2023-01-27 Thread John Harrison
On 1/24/2023 09:05, Michal Wajdeczko wrote: Use new macros to have common prefix that also include GT#. v2: improve few existing messages Signed-off-by: Michal Wajdeczko Cc: John Harrison Reviewed-by: John Harrison --- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 61

Re: [Intel-gfx] [PATCH v2 8/8] drm/i915/guc: Update GT/GuC messages in intel_uc.c

2023-01-27 Thread John Harrison
On 1/24/2023 09:05, Michal Wajdeczko wrote: Use new macros to have common prefix that also include GT#. v2: pass gt to print_fw_ver Signed-off-by: Michal Wajdeczko Cc: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_uc.c | 80 +-- 1 file changed, 39 insertions

Re: [Intel-gfx] [PATCH v2 1/8] drm/i915/guc: Add GuC oriented print macros

2023-01-27 Thread John Harrison
Wajdeczko Cc: Tvrtko Ursulin Cc: John Harrison Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_print.h | 48 1 file changed, 48 insertions(+) create mode 100644 drivers/gpu/drm/i915/gt/uc/intel_guc_print.h diff --git a/drivers/gpu/drm/i915/gt/uc

Re: [PATCH] drm/i915/guc: Fix missing ecodes

2023-01-27 Thread John Harrison
: Alan Previn On Tue, 2023-01-24 at 16:49 -0800, Harrison, John C wrote: From: John Harrison Error captures are tagged with an 'ecode'. This is a pseduo-unique magic number that is meant to distinguish similar seeming bugs with different underlying signatures. It is a combination of two

Re: [PATCH v3 6/8] drm/i915/guc: Update GuC messages in intel_guc_log.c

2023-01-30 Thread John Harrison
On 1/28/2023 11:59, Michal Wajdeczko wrote: Use new macros to have common prefix that also include GT#. v2: drop redundant GuC strings, minor improvements v3: more message improvements Signed-off-by: Michal Wajdeczko Cc: John Harrison Reviewed-by: John Harrison --- drivers/gpu/drm/i915

Re: [PATCH v3 8/8] drm/i915/guc: Update GT/GuC messages in intel_uc.c

2023-01-30 Thread John Harrison
On 1/28/2023 11:59, Michal Wajdeczko wrote: Use new macros to have common prefix that also include GT#. v2: pass gt to print_fw_ver v3: prefer guc_dbg in suspend/resume logs Signed-off-by: Michal Wajdeczko Cc: John Harrison Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/uc

Re: linux-next: manual merge of the usb tree with the drm-intel-fixes tree

2023-01-31 Thread John Harrison
On 1/31/2023 04:44, Andy Shevchenko wrote: On Tue, Jan 31, 2023 at 01:03:05PM +1100, Stephen Rothwell wrote: Hi all, Today's linux-next merge of the usb tree got a conflict in: drivers/gpu/drm/i915/gt/intel_engine_cs.c between commit: 5bc4b43d5c6c ("drm/i915: Fix up locking around dump

Re: linux-next: manual merge of the usb tree with the drm-intel-fixes tree

2023-02-01 Thread John Harrison
On 2/1/2023 07:31, Rodrigo Vivi wrote: On Wed, Feb 01, 2023 at 03:11:31PM +1100, Stephen Rothwell wrote: Hi all, On Tue, 31 Jan 2023 10:27:29 -0800 John Harrison wrote: On 1/31/2023 04:44, Andy Shevchenko wrote: On Tue, Jan 31, 2023 at 01:03:05PM +1100, Stephen Rothwell wrote: Today&#

Re: [PATCH] drm/i915/guc: Improve debug message on context reset notification

2023-02-01 Thread John Harrison
. Signed-off-by: Michal Wajdeczko Cc: John Harrison Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc

Re: [Intel-gfx] [PATCH 4/6] drm/i915/guc: More debug print updates - GuC selftests

2023-02-03 Thread John Harrison
On 2/3/2023 01:54, Michal Wajdeczko wrote: On 03.02.2023 01:11, john.c.harri...@intel.com wrote: From: John Harrison Update a bunch more debug prints to use the new GT based scheme. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/selftest_guc.c | 35

Re: [Intel-gfx] [PATCH 3/6] drm/i915/guc: More debug print updates - GuC reg capture

2023-02-06 Thread John Harrison
ce->lrc.lrca);" Did that get discussed in the original code review? I vaguely recall some reason for it not being a warning. But maybe I'm thinking of something else? Otherwise LGTM, Reviewed-by: Alan Previn On Thu, 2023-02-02 at 16:11 -0800, john.c.harri...@intel.com wrote: From

Re: [Intel-gfx] [PATCH 2/3] drm/i915/guc: Clean up of register capture search

2023-02-06 Thread John Harrison
id zero. John. Reviewed-by: Alan Previn On Thu, 2023-02-02 at 17:10 -0800, john.c.harri...@intel.com wrote: From: John Harrison The comparison in the search for a matching register capture node was not the most readable. So remove two redundant terms and re-format to keep each term on a s

Re: [PATCH v3 0/2] Don't use stolen memory or BAR mappings for ring buffers

2023-02-17 Thread John Harrison
On 2/17/2023 00:39, Hogander, Jouni wrote: On Wed, 2023-02-15 at 17:10 -0800, john.c.harri...@intel.com wrote: From: John Harrison Instruction from hardware arch is that stolen memory and BAR mappings are unsafe for use as ring buffers. There can be issues with cache aliasing due to the CPU

Re: [Intel-gfx] [PATCH 1/2] drm/i915/guc: Improve clean up of busyness stats worker

2023-02-17 Thread John Harrison
On 1/24/2023 16:55, Ceraolo Spurio, Daniele wrote: On 1/11/2023 5:54 PM, john.c.harri...@intel.com wrote: From: John Harrison The stats worker thread management was mis-matched between enable/disable call sites. Fix those up. Also, abstract the cancel code into a helper function rather than

Re: [PATCH 2/2] drm/i915/guc: Fix missing return code checks in submission init

2023-02-17 Thread John Harrison
On 1/24/2023 17:01, Ceraolo Spurio, Daniele wrote: On 1/11/2023 5:54 PM, john.c.harri...@intel.com wrote: From: John Harrison The CI results for the 'fast request' patch set (enables error return codes for fire-and-forget H2G messages) hit an issue with the KMD sending context

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-11 Thread John Harrison
On 1/11/2023 10:07, Matthew Brost wrote: On Wed, Jan 11, 2023 at 09:17:01AM +, Tvrtko Ursulin wrote: On 10/01/2023 19:01, Matthew Brost wrote: On Tue, Jan 10, 2023 at 04:50:55PM +, Tvrtko Ursulin wrote: On 10/01/2023 15:55, Matthew Brost wrote: On Tue, Jan 10, 2023 at 12:19:35PM +

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Allow error capture without a request

2023-01-12 Thread John Harrison
On 1/12/2023 02:01, Tvrtko Ursulin wrote: On 12/01/2023 02:53, john.c.harri...@intel.com wrote: From: John Harrison There was a report of error captures occurring without any hung context being indicated despite the capture being initiated by a 'hung context notification' fro

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Allow error capture of a pending request

2023-01-12 Thread John Harrison
On 1/12/2023 02:06, Tvrtko Ursulin wrote: On 12/01/2023 02:53, john.c.harri...@intel.com wrote: From: John Harrison A hang situation has been observed where the only requests on the context were either completed or not yet started according to the breaadcrumbs. However, the register state

Re: [Intel-gfx] [PATCH 3/4] drm/i915/guc: Look for a guilty context when an engine reset fails

2023-01-12 Thread John Harrison
On 1/12/2023 02:15, Tvrtko Ursulin wrote: On 12/01/2023 02:53, john.c.harri...@intel.com wrote: From: John Harrison Engine resets are supposed to never fail. But in the case when one does (due to unknown reasons that normally come down to a missing w/a), it is useful to get as much

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-12 Thread John Harrison
On 1/11/2023 14:56, Jason Ekstrand wrote: On Wed, Jan 11, 2023 at 4:32 PM Matthew Brost wrote: On Wed, Jan 11, 2023 at 04:18:01PM -0600, Jason Ekstrand wrote: > On Wed, Jan 11, 2023 at 2:50 AM Tvrtko Ursulin < > tvrtko.ursu...@linux.intel.com> wrote: > > > [snip] >

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Allow error capture without a request

2023-01-13 Thread John Harrison
On 1/13/2023 09:46, Hellstrom, Thomas wrote: On Fri, 2023-01-13 at 09:51 +, Tvrtko Ursulin wrote: On 12/01/2023 20:40, John Harrison wrote: On 1/12/2023 02:01, Tvrtko Ursulin wrote: On 12/01/2023 02:53, john.c.harri...@intel.com wrote: From: John Harrison There was a report of error

Re: [Intel-gfx] [PATCH 3/4] drm/i915/guc: Look for a guilty context when an engine reset fails

2023-01-13 Thread John Harrison
On 1/13/2023 01:22, Tvrtko Ursulin wrote: On 12/01/2023 20:59, John Harrison wrote: On 1/12/2023 02:15, Tvrtko Ursulin wrote: On 12/01/2023 02:53, john.c.harri...@intel.com wrote: From: John Harrison Engine resets are supposed to never fail. But in the case when one does (due to unknown

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Allow error capture without a request

2023-01-17 Thread John Harrison
On 1/16/2023 04:38, Tvrtko Ursulin wrote: On 13/01/2023 21:29, John Harrison wrote: On 1/13/2023 09:46, Hellstrom, Thomas wrote: On Fri, 2023-01-13 at 09:51 +, Tvrtko Ursulin wrote: On 12/01/2023 20:40, John Harrison wrote: On 1/12/2023 02:01, Tvrtko Ursulin wrote: On 12/01/2023 02:53

Re: [Intel-gfx] [PATCH 3/4] drm/i915/guc: Look for a guilty context when an engine reset fails

2023-01-17 Thread John Harrison
On 1/16/2023 04:43, Tvrtko Ursulin wrote: On 14/01/2023 01:27, John Harrison wrote: On 1/13/2023 01:22, Tvrtko Ursulin wrote: On 12/01/2023 20:59, John Harrison wrote: On 1/12/2023 02:15, Tvrtko Ursulin wrote: On 12/01/2023 02:53, john.c.harri...@intel.com wrote: From: John Harrison

Re: [PATCH v2 1/5] drm/i915: Fix request locking during error capture & debugfs dump

2023-01-18 Thread John Harrison
On 1/18/2023 00:29, Andy Shevchenko wrote: On Tue, Jan 17, 2023 at 01:36:26PM -0800, john.c.harri...@intel.com wrote: From: John Harrison When GuC support was added to error capture, the locking around the request object was broken. Fix it up. The context based search manages the spinlocking

Re: [PATCH v2 1/5] drm/i915: Fix request locking during error capture & debugfs dump

2023-01-18 Thread John Harrison
On 1/18/2023 08:22, Tvrtko Ursulin wrote: On 17/01/2023 21:36, john.c.harri...@intel.com wrote: From: John Harrison When GuC support was added to error capture, the locking around the request object was broken. Fix it up. The context based search manages the spinlocking around the search

Re: [PATCH v2 1/5] drm/i915: Fix request locking during error capture & debugfs dump

2023-01-18 Thread John Harrison
On 1/18/2023 09:54, Andy Shevchenko wrote: On Wed, Jan 18, 2023 at 09:34:47AM -0800, John Harrison wrote: On 1/18/2023 00:29, Andy Shevchenko wrote: On Tue, Jan 17, 2023 at 01:36:26PM -0800, john.c.harri...@intel.com wrote: From: John Harrison When GuC support was added to error capture

Re: [Intel-gfx] [PATCH v3 3/6] drm/i915: Allow error capture without a request

2023-01-20 Thread John Harrison
On 1/19/2023 17:54, Ceraolo Spurio, Daniele wrote: On 1/18/2023 10:49 PM, john.c.harri...@intel.com wrote: From: John Harrison There was a report of error captures occurring without any hung context being indicated despite the capture being initiated by a 'hung context notification'

Re: [Intel-gfx] [PATCH v3 3/6] drm/i915: Allow error capture without a request

2023-01-20 Thread John Harrison
On 1/20/2023 09:36, John Harrison wrote: On 1/19/2023 17:54, Ceraolo Spurio, Daniele wrote: On 1/18/2023 10:49 PM, john.c.harri...@intel.com wrote: From: John Harrison There was a report of error captures occurring without any hung context being indicated despite the capture being initiated

Re: [PATCH v3 1/6] drm/i915: Fix request locking during error capture & debugfs dump

2023-01-20 Thread John Harrison
On 1/19/2023 07:16, Andy Shevchenko wrote: On Wed, Jan 18, 2023 at 10:49:55PM -0800, john.c.harri...@intel.com wrote: From: John Harrison When GuC support was added to error capture, the locking around the request object was broken. Fix it up. The context based search manages the spinlocking

Re: [PATCH v4 2/7] drm/i915: Fix up locking around dumping requests lists

2023-01-20 Thread John Harrison
On 1/20/2023 15:28, john.c.harri...@intel.com wrote: From: John Harrison The debugfs dump of requests was confused about what state requires the execlist lock versus the GuC lock. There was also a bunch of duplicated messy code between it and the error capture code. So refactor the hung

Re: [PATCH v4 1/7] drm/i915: Fix request locking during error capture & debugfs dump

2023-01-23 Thread John Harrison
On 1/23/2023 09:51, Tvrtko Ursulin wrote: On 20/01/2023 23:28, john.c.harri...@intel.com wrote: From: John Harrison When GuC support was added to error capture, the locking around the request object was broken. Fix it up. The context based search manages the spinlocking around the search

Re: [PATCH 2/8] drm/i915/guc: Update GuC messages in intel_guc.c

2023-01-23 Thread John Harrison
On 1/20/2023 08:40, Michal Wajdeczko wrote: Use new macros to have common prefix that also include GT#. Signed-off-by: Michal Wajdeczko Cc: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc.c | 31 +- 1 file changed, 15 insertions(+), 16 deletions(-) diff

Re: [PATCH 3/8] drm/i915/guc: Update GuC messages in intel_guc_ads.c

2023-01-23 Thread John Harrison
On 1/20/2023 08:40, Michal Wajdeczko wrote: Use new macros to have common prefix that also include GT#. Signed-off-by: Michal Wajdeczko Cc: John Harrison Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 8 1 file changed, 4 insertions(+), 4 deletions

Re: [PATCH 4/8] drm/i915/guc: Update GuC messages in intel_guc_ct.c

2023-01-23 Thread John Harrison
On 1/20/2023 08:40, Michal Wajdeczko wrote: Use new macros to have common prefix that also include GT#. Signed-off-by: Michal Wajdeczko Cc: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers

Re: [PATCH 5/8] drm/i915/guc: Update GuC messages in intel_guc_fw.c

2023-01-23 Thread John Harrison
On 1/20/2023 08:40, Michal Wajdeczko wrote: Use new macros to have common prefix that also include GT#. Signed-off-by: Michal Wajdeczko Cc: John Harrison Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 17 + 1 file changed, 9 insertions(+), 8

Re: [PATCH 6/8] drm/i915/guc: Update GuC messages in intel_guc_log.c

2023-01-23 Thread John Harrison
On 1/20/2023 08:40, Michal Wajdeczko wrote: Use new macros to have common prefix that also include GT#. Signed-off-by: Michal Wajdeczko Cc: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 35 +++--- 1 file changed, 18 insertions(+), 17 deletions(-) diff

Re: [PATCH 7/8] drm/i915/guc: Update GuC messages in intel_guc_submission.c

2023-01-23 Thread John Harrison
On 1/20/2023 08:40, Michal Wajdeczko wrote: Use new macros to have common prefix that also include GT#. Signed-off-by: Michal Wajdeczko Cc: John Harrison --- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 60 --- 1 file changed, 26 insertions(+), 34 deletions(-) diff

Re: [PATCH 8/8] drm/i915/guc: Update GT/GuC messages in intel_uc.c

2023-01-23 Thread John Harrison
On 1/20/2023 08:40, Michal Wajdeczko wrote: Use new macros to have common prefix that also include GT#. Signed-off-by: Michal Wajdeczko Cc: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_uc.c | 74 +-- 1 file changed, 36 insertions(+), 38 deletions(-) diff

Re: [PATCH 1/8] drm/i915/guc: Add GuC oriented print macros

2023-01-23 Thread John Harrison
Wajdeczko Cc: Tvrtko Ursulin Cc: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_print.h | 48 1 file changed, 48 insertions(+) create mode 100644 drivers/gpu/drm/i915/gt/uc/intel_guc_print.h diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_print.h b/drivers

Re: [PATCH v4] drm/i915/uncore: Use GT message helpers in uncore

2023-01-24 Thread John Harrison
This is actually v1 not v4. Not sure how that crept in! John. On 1/24/2023 12:54, john.c.harri...@intel.com wrote: From: John Harrison Uncore is really part of the GT. So use the GT specific debug/error message helpers so as to get the GT index in the prints. Signed-off-by: John Harrison

Re: [Intel-gfx] [PATCH v4 3/7] drm/i915: Allow error capture without a request

2023-01-24 Thread John Harrison
On 1/24/2023 16:39, Ceraolo Spurio, Daniele wrote: On 1/20/2023 3:28 PM, john.c.harri...@intel.com wrote: From: John Harrison There was a report of error captures occurring without any hung context being indicated despite the capture being initiated by a 'hung context notification'

Re: [Intel-gfx] [PATCH v4 3/4] drm/i915: Make the heartbeat play nice with long pre-emption timeouts

2022-10-05 Thread John Harrison
On 10/3/2022 05:00, Tvrtko Ursulin wrote: On 03/10/2022 08:53, Tvrtko Ursulin wrote: On 30/09/2022 18:44, John Harrison wrote: On 9/30/2022 02:22, Tvrtko Ursulin wrote: On 29/09/2022 17:21, John Harrison wrote: On 9/29/2022 00:42, Tvrtko Ursulin wrote: On 29/09/2022 03:18, john.c.harri

Re: [Intel-gfx] [PATCH] drm/i915/huc: bump timeout for delayed load and reduce print verbosity

2022-10-06 Thread John Harrison
On 10/6/2022 10:20, Daniele Ceraolo Spurio wrote: We're observing sporadic HuC delayed load timeouts in CI, due to mei_pxp binding completing later than we expected. HuC is still still loaded still still when the bind occurs, but in the meantime i915 has started allowing submission to the VCS

Re: [Intel-gfx] [PATCH] drm/i915/huc: bump timeout for delayed load and reduce print verbosity

2022-10-06 Thread John Harrison
On 10/6/2022 13:16, Ceraolo Spurio, Daniele wrote: On 10/6/2022 1:09 PM, John Harrison wrote: On 10/6/2022 10:20, Daniele Ceraolo Spurio wrote: We're observing sporadic HuC delayed load timeouts in CI, due to mei_pxp binding completing later than we expected. HuC is still still loaded

Re: [PATCH 3/7] drm/i915/uc: use different ggtt pin offsets for uc loads

2022-10-10 Thread John Harrison
On 9/30/2022 16:42, Ceraolo Spurio, Daniele wrote: On 9/30/2022 4:24 PM, John Harrison wrote: On 9/22/2022 15:11, Daniele Ceraolo Spurio wrote: Our current FW loading process is the same for all FWs: - Pin FW to GGTT at the start of the ggtt->uc_fw node - Load the FW - Unpin This wor

Re: [PATCH v2] drm/i915/huc: bump timeout for delayed load and reduce print verbosity

2022-10-10 Thread John Harrison
#x27;m also reducing the print verbosity from error to notice. v2: use separate prints for MEI GSC and MEI PXP init timeouts (John) References: https://gitlab.freedesktop.org/drm/intel/-/issues/7033 Fixes: 27536e03271d ("drm/i915/huc: track delayed HuC load with a fence") Signed-off-by: Danie

Re: [PATCH v2] drm/i915/huc: bump timeout for delayed load and reduce print verbosity

2022-10-11 Thread John Harrison
On 10/10/2022 15:57, Ceraolo Spurio, Daniele wrote: On 10/10/2022 3:50 PM, John Harrison wrote: On 10/10/2022 11:48, Daniele Ceraolo Spurio wrote: We're observing sporadic HuC delayed load timeouts in CI, due to mei_pxp binding completing later than we expected. HuC is still loaded whe

Re: [PATCH v3] drm/i915/huc: bump timeout for delayed load and reduce print verbosity

2022-10-14 Thread John Harrison
HuC load with a fence") Signed-off-by: Daniele Ceraolo Spurio Reviewed-by: John Harrison Cc: Tony Ye Cc: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_huc.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/i

Re: [PATCH v2 3/7] drm/i915/uc: use different ggtt pin offsets for uc loads

2022-10-17 Thread John Harrison
improve comments (John) Signed-off-by: Daniele Ceraolo Spurio Cc: John Harrison Cc: Alan Previn --- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 30 +--- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.h | 13 ++ 2 files changed, 40 insertions(+), 3 deletions(-) diff --git a

Re: [PATCH v2 5/7] drm/i915/mtl: Handle wopcm per-GT and limit calculations.

2022-10-18 Thread John Harrison
are pre-locked by the bios. Therefore, we can skip all the math for the partitioning and just limit ourselves to sanity checking the values. v2: fix makefile file ordering (Jani) Signed-off-by: Aravind Iddamsetty Signed-off-by: Daniele Ceraolo Spurio Cc: Matt Roper Cc: John Harrison Cc: A

Re: [PATCH v3 3/7] drm/i915/uc: use different ggtt pin offsets for uc loads

2022-10-24 Thread John Harrison
improve comments (John) v3: more comment improvements (John) Signed-off-by: Daniele Ceraolo Spurio Cc: John Harrison Cc: Alan Previn Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 32 +--- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.h | 14 +

Re: [PATCH v3 5/7] drm/i915/mtl: Handle wopcm per-GT and limit calculations.

2022-10-24 Thread John Harrison
ing the values. v2: fix makefile file ordering (Jani) v3: drop XELPM_SAMEDIA_WOPCM_SIZE, check huc instead of VDBOX (John) Signed-off-by: Aravind Iddamsetty Signed-off-by: Daniele Ceraolo Spurio Cc: Matt Roper Cc: John Harrison Cc: Alan Previn Cc: Jani Nikula --- Documentation/gpu/i915.rst

Re: [PATCH v3 5/7] drm/i915/mtl: Handle wopcm per-GT and limit calculations.

2022-10-24 Thread John Harrison
On 10/24/2022 14:39, Ceraolo Spurio, Daniele wrote: On 10/24/2022 2:33 PM, John Harrison wrote: On 10/21/2022 17:10, Daniele Ceraolo Spurio wrote: From: Aravind Iddamsetty With MTL standalone media architecture the wopcm layout has changed with separate partitioning in WOPCM for GCD/GT GuC

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

2022-11-14 Thread John Harrison
On 11/10/2022 02:33, Jani Nikula wrote: On Wed, 09 Nov 2022, Michal Wajdeczko wrote: Instead of merging this patch now, oriented on GT only, I would rather wait until we discuss and plan solution for the all sub-components. Once that's done (with agreement on naming and output) we can start co

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

2022-11-14 Thread John Harrison
On 11/10/2022 01:43, Tvrtko Ursulin wrote: On 09/11/2022 17:46, John Harrison wrote: On 11/9/2022 03:05, Tvrtko Ursulin wrote: On 08/11/2022 20:15, John Harrison wrote: On 11/8/2022 01:01, Tvrtko Ursulin wrote: On 07/11/2022 19:14, John Harrison wrote: On 11/7/2022 08:17, Tvrtko Ursulin

Re: [Intel-gfx] [PATCH v2 0/5] Add module oriented dmesg output

2022-11-21 Thread John Harrison
On 11/18/2022 02:52, Jani Nikula wrote: On Thu, 17 Nov 2022, john.c.harri...@intel.com wrote: From: John Harrison When trying to analyse bug reports from CI, customers, etc. it can be difficult to work out exactly what is happening on which GT in a multi-GT system. So add GT oriented debug

Re: [PATCH] drm/i915/huc: fix leak of debug object in huc load fence on driver unload

2022-11-22 Thread John Harrison
Spurio Cc: Tvrtko Ursulin Cc: Brian Norris Cc: Alan Previn Cc: John Harrison Reviewed-by: John Harrison --- Note: I didn't manage to repro the reported warning, but I did confirm that we weren't correctly calling i915_sw_fence_fini and that this patch fixes that. driver

Re: [PATCH v2 3/5] drm/i915/guc: Add GuC specific debug print wrappers

2022-11-22 Thread John Harrison
On 11/22/2022 09:42, Michal Wajdeczko wrote: On 18.11.2022 02:58, john.c.harri...@intel.com wrote: From: John Harrison Create a set of GuC printers and start using them. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc.c| 32 -- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/guc: Add GuC CT specific debug print wrappers

2022-11-22 Thread John Harrison
On 11/22/2022 09:54, Michal Wajdeczko wrote: On 18.11.2022 02:58, john.c.harri...@intel.com wrote: From: John Harrison Re-work the existing GuC CT printers and extend as required to match the new wrapping scheme. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c

Re: [Intel-gfx] [PATCH] drm/i915/gt: Manage uncore->lock while waiting on MCR register

2022-11-23 Thread John Harrison
On 11/17/2022 09:33, Matt Roper wrote: ... diff --git a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c index 830edffe88cc..d9a8ff9e5e57 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c +++ b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c @@ -730,17 +730,19 @@ void in

Re: [PATCH] drm/i915/huc: always init the delayed load fence

2022-11-28 Thread John Harrison
leak of debug object in huc load fence on driver unload") Signed-off-by: Daniele Ceraolo Spurio Cc: John Harrison Cc: Alan Previn --- drivers/gpu/drm/i915/gt/uc/intel_huc.c | 47 +++--- 1 file changed, 34 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/i915

Re: [PATCH] drm/i915/mtl: Handle wopcm per-GT and limit calculations.

2022-10-25 Thread John Harrison
XELPM_SAMEDIA_WOPCM_SIZE, check huc instead of VDBOX (John) v4: further clarify commit message, remove blank line (John) Signed-off-by: Aravind Iddamsetty Signed-off-by: Daniele Ceraolo Spurio Cc: Matt Roper Cc: John Harrison Cc: Alan Previn Cc: Jani Nikula Reviewed-by: John Harrison --- Documentation/gpu

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Don't deadlock busyness stats vs reset

2022-10-31 Thread John Harrison
On 10/31/2022 05:51, Tvrtko Ursulin wrote: On 31/10/2022 10:09, Tvrtko Ursulin wrote: On 28/10/2022 20:46, john.c.harri...@intel.com wrote: From: John Harrison The engine busyness stats has a worker function to do things like 64bit extend the 32bit hardware counters. The GuC's reset pr

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Don't deadlock busyness stats vs reset

2022-11-01 Thread John Harrison
On 11/1/2022 02:58, Tvrtko Ursulin wrote: On 31/10/2022 18:30, John Harrison wrote: On 10/31/2022 05:51, Tvrtko Ursulin wrote: On 31/10/2022 10:09, Tvrtko Ursulin wrote: On 28/10/2022 20:46, john.c.harri...@intel.com wrote: From: John Harrison The engine busyness stats has a worker

Re: [PATCH] drm/i915/guc: don't hardcode BCS0 in guc_hang selftest

2022-11-02 Thread John Harrison
raolo Spurio Cc: John Harrison Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/selftest_guc_hangcheck.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/selftest_guc_hangcheck.c b/drivers/gpu/drm/i915/gt/uc/selftest_guc_hangch

Re: [Intel-gfx] [PATCH] drm/i915: Don't wait forever in drop_caches

2022-11-02 Thread John Harrison
On 11/2/2022 07:20, Tvrtko Ursulin wrote: On 02/11/2022 12:12, Jani Nikula wrote: On Tue, 01 Nov 2022, john.c.harri...@intel.com wrote: From: John Harrison At the end of each test, IGT does a drop caches call via sysfs with sysfs? Sorry, that was meant to say debugfs. I've also

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/guc: Don't deadlock busyness stats vs reset

2022-11-03 Thread John Harrison
On 11/3/2022 04:31, Tvrtko Ursulin wrote: On 02/11/2022 19:21, john.c.harri...@intel.com wrote: From: John Harrison The engine busyness stats has a worker function to do things like 64bit extend the 32bit hardware counters. The GuC's reset prepare function flushes out this worker functi

Re: [Intel-gfx] [PATCH] drm/i915: Don't wait forever in drop_caches

2022-11-03 Thread John Harrison
On 11/3/2022 02:38, Tvrtko Ursulin wrote: On 03/11/2022 09:18, Tvrtko Ursulin wrote: On 03/11/2022 01:33, John Harrison wrote: On 11/2/2022 07:20, Tvrtko Ursulin wrote: On 02/11/2022 12:12, Jani Nikula wrote: On Tue, 01 Nov 2022, john.c.harri...@intel.com wrote: From: John Harrison At the

Re: [Intel-gfx] [PATCH] drm/i915: Don't wait forever in drop_caches

2022-11-03 Thread John Harrison
On 11/3/2022 02:18, Tvrtko Ursulin wrote: On 03/11/2022 01:33, John Harrison wrote: On 11/2/2022 07:20, Tvrtko Ursulin wrote: On 02/11/2022 12:12, Jani Nikula wrote: On Tue, 01 Nov 2022, john.c.harri...@intel.com wrote: From: John Harrison At the end of each test, IGT does a drop caches

Re: [Intel-gfx] [PATCH] drm/i915: Don't wait forever in drop_caches

2022-11-03 Thread John Harrison
On 11/3/2022 03:45, Jani Nikula wrote: On Wed, 02 Nov 2022, John Harrison wrote: On 11/2/2022 07:20, Tvrtko Ursulin wrote: On 02/11/2022 12:12, Jani Nikula wrote: On Tue, 01 Nov 2022, john.c.harri...@intel.com wrote: From: John Harrison At the end of each test, IGT does a drop caches

Re: [Intel-gfx] [PATCH] drm/i915: Don't wait forever in drop_caches

2022-11-04 Thread John Harrison
On 11/4/2022 03:01, Tvrtko Ursulin wrote: On 03/11/2022 19:16, John Harrison wrote: On 11/3/2022 02:38, Tvrtko Ursulin wrote: On 03/11/2022 09:18, Tvrtko Ursulin wrote: On 03/11/2022 01:33, John Harrison wrote: On 11/2/2022 07:20, Tvrtko Ursulin wrote: On 02/11/2022 12:12, Jani Nikula wrote

Re: [PATCH v2 1/2] drm/i915/guc: Properly initialise kernel contexts

2022-11-04 Thread John Harrison
On 11/4/2022 11:53, Ceraolo Spurio, Daniele wrote: On 11/2/2022 12:21 PM, john.c.harri...@intel.com wrote: From: John Harrison If a context has already been registered prior to first submission then context init code was not being called. The noticeable effect of that was the scheduling

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

2022-11-07 Thread John Harrison
On 11/7/2022 08:17, Tvrtko Ursulin wrote: On 07/11/2022 09:33, Tvrtko Ursulin wrote: On 05/11/2022 01:03, Ceraolo Spurio, Daniele wrote: On 11/4/2022 10:25 AM, john.c.harri...@intel.com wrote: From: John Harrison When trying to analyse bug reports from CI, customers, etc. it can be

Re: [Intel-gfx] [PATCH] drm/i915: Don't wait forever in drop_caches

2022-11-07 Thread John Harrison
On 11/7/2022 06:09, Tvrtko Ursulin wrote: On 04/11/2022 17:45, John Harrison wrote: On 11/4/2022 03:01, Tvrtko Ursulin wrote: On 03/11/2022 19:16, John Harrison wrote: On 11/3/2022 02:38, Tvrtko Ursulin wrote: On 03/11/2022 09:18, Tvrtko Ursulin wrote: On 03/11/2022 01:33, John Harrison

Re: linux-next: build warning after merge of the drm tree

2022-11-07 Thread John Harrison
On 11/6/2022 19:29, Stephen Rothwell wrote: Hi all, After merging the drm tree, today's linux-next build (KCONFIG_NAME) produced this warning: drivers/gpu/drm/i915/i915_perf_types.h:319: warning: Function parameter or member 'lock' not described in 'i915_perf_stream' Introduced by commit

Re: [Intel-gfx] [PATCH] drm/i915: Don't wait forever in drop_caches

2022-11-08 Thread John Harrison
On 11/8/2022 01:08, Tvrtko Ursulin wrote: On 07/11/2022 19:45, John Harrison wrote: On 11/7/2022 06:09, Tvrtko Ursulin wrote: On 04/11/2022 17:45, John Harrison wrote: On 11/4/2022 03:01, Tvrtko Ursulin wrote: On 03/11/2022 19:16, John Harrison wrote: On 11/3/2022 02:38, Tvrtko Ursulin

Re: [PATCH v2] drm/i915: Partial abandonment of legacy DRM logging macros

2022-11-08 Thread John Harrison
ikula Cc: John Harrison Cc: Ville Syrjälä --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 2 +- .../gpu/drm/i915/gem/i915_gem_execbuffer.c| 26 +++ .../drm/i915/gt/intel_execlists_submission.c | 13 +++--- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 4 +- drivers/gpu/drm

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

2022-11-08 Thread John Harrison
On 11/8/2022 01:01, Tvrtko Ursulin wrote: On 07/11/2022 19:14, John Harrison wrote: On 11/7/2022 08:17, Tvrtko Ursulin wrote: On 07/11/2022 09:33, Tvrtko Ursulin wrote: On 05/11/2022 01:03, Ceraolo Spurio, Daniele wrote: On 11/4/2022 10:25 AM, john.c.harri...@intel.com wrote: From: John

<    1   2   3   4   5   6   >