Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-15 Thread John Ogness
example, you may have functions without a return value taking spinlocks. But now those functions could fail. John Ogness ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-15 Thread John Ogness
On 2019-03-14, John Ogness wrote: > On 2019-03-14, Daniel Vetter wrote: >> That's why we came up with the trylock + immediate bail out design if >> that fails. Plus really only render the oops int whatever is the >> current display buffer, so that we don't have to

Re: [RFC][PATCH 4/5 v2] dma-buf: heaps: Add CMA heap to dmabuf heapss

2019-03-15 Thread John Stultz
On Fri, Mar 15, 2019 at 2:06 AM Christoph Hellwig wrote: > > On Tue, Mar 05, 2019 at 12:54:32PM -0800, John Stultz wrote: > > This adds a CMA heap, which allows userspace to allocate > > a dma-buf of contiguous memory out of a CMA region. > > With my previous suggestion of

Re: [RFC][PATCH 5/5 v2] kselftests: Add dma-heap test

2019-03-15 Thread John Stultz
On Fri, Mar 15, 2019 at 1:07 PM Laura Abbott wrote: > > On 3/6/19 9:01 AM, John Stultz wrote: > > On Wed, Mar 6, 2019 at 8:14 AM Benjamin Gaignard > > wrote: > >> Le mar. 5 mars 2019 à 21:54, John Stultz a écrit : > >>> + > >>> +

Re: [RFC][PATCH 1/5 v2] dma-buf: Add dma-buf heaps framework

2019-03-15 Thread John Stultz
On Fri, Mar 15, 2019 at 1:18 PM Laura Abbott wrote: > > On 3/5/19 12:54 PM, John Stultz wrote: > > +DMA-BUF HEAPS FRAMEWORK > > +M: Laura Abbott > > +R: Liam Mark > > +R: Brian Starkey > > +R: "Andrew F. Davis" > > +R:

Re: [RFC][PATCH 0/5 v2] DMA-BUF Heaps (destaging ION)

2019-03-15 Thread John Stultz
On Fri, Mar 15, 2019 at 4:15 PM Jerome Glisse wrote: > On Tue, Mar 05, 2019 at 12:54:28PM -0800, John Stultz wrote: > > Here is a initial RFC of the dma-buf heaps patchset Andrew and I > > have been working on which tries to destage a fair chunk of ION > > functionality.

Re: [RFC][PATCH 0/5 v2] DMA-BUF Heaps (destaging ION)

2019-03-19 Thread John Stultz
On Tue, Mar 19, 2019 at 2:58 PM Rob Clark wrote: > > On Tue, Mar 19, 2019 at 1:00 PM Andrew F. Davis wrote: > > > > On 3/19/19 11:54 AM, Benjamin Gaignard wrote: > > > Le mer. 13 mars 2019 à 23:31, John Stultz a > > > écrit : > > >> > &g

Re: [RFC][PATCH 0/5 v2] DMA-BUF Heaps (destaging ION)

2019-03-20 Thread John Stultz
On Wed, Mar 20, 2019 at 2:16 AM Benjamin Gaignard wrote: > Le mar. 19 mars 2019 à 23:36, John Stultz a écrit : > > On Tue, Mar 19, 2019 at 2:58 PM Rob Clark wrote: > > > For at least some hw the importing driver needs to configure things > > > differently for secure b

Re: [RFC][PATCH 2/5 v2] dma-buf: heaps: Add heap helpers

2019-03-21 Thread John Stultz
gt;free = free; > > +} > > There is absolutely no reason to inlines this as far as I can tell. Yea, I think I was mimicing some of the helpers like INIT_LIST_HEAD() But sounds good. I can uninline it. > Also it would seem much simpler to simply let the caller assign the > free callback. Yea, its a bit ugly but I worry the caller might forget? Thanks again for the feedback! -john ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [RFC][PATCH 2/5 v2] dma-buf: heaps: Add heap helpers

2019-03-21 Thread John Stultz
On Tue, Mar 19, 2019 at 7:26 AM Brian Starkey wrote: > > Hi John, > > On Tue, Mar 05, 2019 at 12:54:30PM -0800, John Stultz wrote: > > ... > > > + > > +void dma_heap_buffer_destroy(struct dma_heap_buffer *heap_buffer) > > +{ > > + struct

Re: [RFC][PATCH 4/5 v2] dma-buf: heaps: Add CMA heap to dmabuf heapss

2019-03-21 Thread John Stultz
On Wed, Mar 6, 2019 at 8:05 AM Benjamin Gaignard wrote: > Le mar. 5 mars 2019 à 21:54, John Stultz a écrit : > > +#define to_cma_heap(x) container_of(x, struct cma_heap, heap) > > Even if I had write this macro years ago, now I would prefer to have a > static inline functi

Re: [RFC][PATCH 1/5 v2] dma-buf: Add dma-buf heaps framework

2019-03-21 Thread John Stultz
On Tue, Mar 19, 2019 at 5:08 AM Brian Starkey wrote: > > Hi John, > > On Tue, Mar 05, 2019 at 12:54:29PM -0800, John Stultz wrote: > > From: "Andrew F. Davis" > > [snip] > > > + > > +#define NUM_HEAP_MINORS 128 > > +static DEFINE

Re: [RFC][PATCH 1/5 v2] dma-buf: Add dma-buf heaps framework

2019-03-27 Thread John Stultz
On Wed, Mar 27, 2019 at 11:25 AM Greg KH wrote: > > On Tue, Mar 05, 2019 at 12:54:29PM -0800, John Stultz wrote: > > From: "Andrew F. Davis" > > > > This framework allows a unified userspace interface for dma-buf > > exporters, allowing userland to alloc

[RFC][PATCH 0/6 v3] DMA-BUF Heaps (destaging ION)

2019-03-28 Thread John Stultz
t some help from actual carveout/chunk users)! That said, the main user-interface is shaping up and I wanted to get some input on the device model (particularly from GreKH) and any other API/ABI specific input. thanks -john Cc: Laura Abbott Cc: Benjamin Gaignard Cc: Sumit Semwal Cc: Liam M

[RFC][PATCH 1/6 v3] dma-buf: Add dma-buf heaps framework

2019-03-28 Thread John Stultz
ri-devel@lists.freedesktop.org Signed-off-by: Andrew F. Davis Signed-off-by: John Stultz --- v2: * Folded down fixes I had previously shared in implementing heaps * Make flags a u64 (Suggested by Laura) * Add PAGE_ALIGN() fix to the core alloc funciton * IOCTL fixups suggested by Brian * Add

[RFC][PATCH 2/6 v3] dma-buf: heaps: Add heap helpers

2019-03-28 Thread John Stultz
Cc: Chenbo Feng Cc: Alistair Strachan Cc: dri-devel@lists.freedesktop.org Signed-off-by: John Stultz --- v2: * Removed cache management performance hack that I had accidentally folded in. * Removed stats code that was in helpers * Lots of checkpatch cleanups v3: * Uninline INIT_HEAP_HELPER_

[RFC][PATCH 3/6 v3] dma-buf: heaps: Add system heap to dmabuf heaps

2019-03-28 Thread John Stultz
; Cc: Yudongbin Cc: Christoph Hellwig Cc: Chenbo Feng Cc: Alistair Strachan Cc: dri-devel@lists.freedesktop.org Reviewed-by: Benjamin Gaignard Signed-off-by: John Stultz --- v2: * Switch allocate to return dmabuf fd * Simplify init code * Checkpatch fixups * Droped dead system-contig code v3: * Wh

[RFC][PATCH 4/6 v3] dma-buf: heaps: Add CMA heap to dmabuf heapss

2019-03-28 Thread John Stultz
ir Strachan Cc: dri-devel@lists.freedesktop.org Signed-off-by: John Stultz --- v2: * Switch allocate to return dmabuf fd * Simplify init code * Checkpatch fixups v3: * Switch to inline function for to_cma_heap() * Minor cleanups suggested by Brian * Fold in new registration style from Andrew * Fo

[RFC][PATCH 5/6 v3] dma-buf: Add Dummy Importer Test Device

2019-03-28 Thread John Stultz
reedesktop.org Signed-off-by: Andrew F. Davis [Renamed and refactored dma_buf_phys driver, rewote commitlog] Signed-off-by: John Stultz --- drivers/dma-buf/Kconfig | 6 + drivers/dma-buf/Makefile | 1 + drivers/dma-buf/dma-buf-testdev.c| 239 ++

[RFC][PATCH 6/6 v3] kselftests: Add dma-heap test

2019-03-28 Thread John Stultz
butao Cc: "Xiaqing (A)" Cc: Yudongbin Cc: Christoph Hellwig Cc: Chenbo Feng Cc: Alistair Strachan Cc: dri-devel@lists.freedesktop.org Signed-off-by: John Stultz --- v2: Switched to use reworked dma-heap apis v3: * Add simple mmap * Utilize dma-buf testdev to test importin

[PATCH 3/3] gup: new put_user_page_dirty*() helpers

2019-07-21 Thread john . hubbard
From: John Hubbard While converting call sites to use put_user_page*() [1], quite a few places ended up needing a single-page routine to put and dirty a page. Provide put_user_page_dirty() and put_user_page_dirty_lock(), and use them in a few places: net/xdp, drm/via/, drivers/infiniband. Cc

[PATCH 1/3] drivers/gpu/drm/via: convert put_page() to put_user_page*()

2019-07-21 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeh

[PATCH 2/3] net/xdp: convert put_page() to put_user_page*()

2019-07-21 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeh

[PATCH 0/4] put_user_page: new put_user_page_dirty*() helpers

2019-07-21 Thread john . hubbard
From: John Hubbard Hi, Here is the first small batch of call site conversions for put_page() to put_user_page(). This batch includes some, but not all of the places that benefit from the two new put_user_page_dirty*() helper functions. (The ordering of call site conversion patch submission

Re: [PATCH 1/3] drivers/gpu/drm/via: convert put_page() to put_user_page*()

2019-07-22 Thread John Hubbard
s, as I can't see how a reserved > page can end up here. So IMHO the above snippled should really look > something like this: > > put_user_pages(vsg->pages[i], vsg->num_pages, > vsg->direction == DMA_FROM_DEVICE); > > in the end. > Agreed. thanks, -- John Hubbard NVIDIA

Re: [PATCH 3/3] gup: new put_user_page_dirty*() helpers

2019-07-22 Thread John Hubbard
On 7/21/19 9:30 PM, john.hubb...@gmail.com wrote: > From: John Hubbard > > While converting call sites to use put_user_page*() [1], quite a few > places ended up needing a single-page routine to put and dirty a > page. > > Provide put_user_page_dirty() and put_user_page_di

Re: [PATCH 1/3] drivers/gpu/drm/via: convert put_page() to put_user_page*()

2019-07-22 Thread John Hubbard
On 7/22/19 12:07 PM, Matthew Wilcox wrote: > On Mon, Jul 22, 2019 at 11:53:54AM -0700, John Hubbard wrote: >> On 7/22/19 2:33 AM, Christoph Hellwig wrote: >>> On Sun, Jul 21, 2019 at 09:30:10PM -0700, john.hubb...@gmail.com wrote: >>>>for (

[PATCH 1/3] mm/gup: introduce __put_user_pages()

2019-07-22 Thread john . hubbard
From: John Hubbard Add a more capable variation of put_user_pages() to the API set, and call it from the simple ones. The new __put_user_pages() takes an enum that handles the various combinations of needing to call set_page_dirty() or set_page_dirty_lock(), before calling put_user_page(). Cc

[PATCH 0/3] introduce __put_user_pages(), convert a few call sites

2019-07-22 Thread john . hubbard
From: John Hubbard As discussed in [1] just now, this adds a more capable variation of put_user_pages() to the API set, and uses it to simplify both the main implementation, and (especially) the call sites. Thanks to Christoph for the simplifying ideas, and Matthew for (again) recommending an

[PATCH 3/3] net/xdp: convert put_page() to put_user_page*()

2019-07-22 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeh

[PATCH 2/3] drivers/gpu/drm/via: convert put_page() to put_user_page*()

2019-07-22 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeh

Re: [PATCH v6 2/5] dma-buf: heaps: Add heap helpers

2019-07-22 Thread John Stultz
s should be done at the dmabuf core level, and would actually be helpful for optimizing some of the cache maintenance rules w/ dmabuf. Does this sound like something closer to what your suggesting, or am I misunderstanding your point? Again, I really appreciate the review and feedback! Thanks so much! -john ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 3/3] net/xdp: convert put_page() to put_user_page*()

2019-07-22 Thread John Hubbard
On 7/22/19 5:25 PM, Ira Weiny wrote: On Mon, Jul 22, 2019 at 03:34:15PM -0700, john.hubb...@gmail.com wrote: From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is

Re: [PATCH v6 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps

2019-07-22 Thread John Stultz
to what your suggesting. Maybe could you expand a bit? Apologies for being a bit dense. Thanks again for the input! -john ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/3] mm/gup: introduce __put_user_pages()

2019-07-22 Thread John Hubbard
quot; really means, "call set_page_dirty()": */ void __put_user_pages_unlocked(struct page **pages, unsigned long npages, bool dirty); ? thanks, -- John Hubbard NVIDIA

Re: kernel panic: stack is corrupted in pointer

2019-07-23 Thread John Fastabend
erimental) > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=111fc8afa0 > > From the repro it looks like the same bpf stack overflow bug. +John > We need to dup them onto some canonical report for this bug, or this > becomes unmanageable. Fixes in bpf tre

Re: Re: kernel panic: stack is corrupted in pointer

2019-07-23 Thread John Fastabend
g?x=3430a151e1452331 > >> > dashboard link: > >> https://syzkaller.appspot.com/bug?extid=79f5f028005a77ecb6bb > >> > compiler: gcc (GCC) 9.0.0 20181231 (experimental) > >> > syz repro: > >> https://syzkaller.appspot.com/x/repro.syz?x=111f

Re: [PATCH 3/3] net/xdp: convert put_page() to put_user_page*()

2019-07-23 Thread John Hubbard
On 7/23/19 11:06 AM, Ira Weiny wrote: > On Mon, Jul 22, 2019 at 09:41:34PM -0700, John Hubbard wrote: >> On 7/22/19 5:25 PM, Ira Weiny wrote: >>> On Mon, Jul 22, 2019 at 03:34:15PM -0700, john.hubb...@gmail.com wrote: ... >> Obviously, this stuff is all subject to a certai

[PATCH v7 3/5] dma-buf: heaps: Add system heap to dmabuf heaps

2019-07-23 Thread John Stultz
-devel@lists.freedesktop.org Reviewed-by: Benjamin Gaignard Signed-off-by: John Stultz --- v2: * Switch allocate to return dmabuf fd * Simplify init code * Checkpatch fixups * Droped dead system-contig code v3: * Whitespace fixups from Benjamin * Make sure we're zeroing the allocated pages

[PATCH v7 2/5] dma-buf: heaps: Add heap helpers

2019-07-23 Thread John Stultz
Reviewed-by: Benjamin Gaignard Signed-off-by: John Stultz --- v2: * Removed cache management performance hack that I had accidentally folded in. * Removed stats code that was in helpers * Lots of checkpatch cleanups v3: * Uninline INIT_HEAP_HELPER_BUFFER (suggested by Christoph) * Switch to WARN on

[PATCH v7 0/5] DMA-BUF Heaps (destaging ION)

2019-07-23 Thread John Stultz
S avoidance suggested by Laura from ION code Thoughts and feedback would be greatly appreciated! thanks -john Cc: Laura Abbott Cc: Benjamin Gaignard Cc: Sumit Semwal Cc: Liam Mark Cc: Pratik Patel Cc: Brian Starkey Cc: Vincent Donnefort Cc: Sudipto Paul Cc: Andrew F. Davis Cc: Christop

[PATCH v7 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps

2019-07-23 Thread John Stultz
Signed-off-by: John Stultz --- v2: * Switch allocate to return dmabuf fd * Simplify init code * Checkpatch fixups v3: * Switch to inline function for to_cma_heap() * Minor cleanups suggested by Brian * Fold in new registration style from Andrew * Folded in changes from Andrew to use simplified page

[PATCH v7 5/5] kselftests: Add dma-heap test

2019-07-23 Thread John Stultz
Patel Cc: Brian Starkey Cc: Vincent Donnefort Cc: Sudipto Paul Cc: Andrew F. Davis Cc: Christoph Hellwig Cc: Chenbo Feng Cc: Alistair Strachan Cc: Hridya Valsaraju Cc: dri-devel@lists.freedesktop.org Reviewed-by: Benjamin Gaignard Signed-off-by: John Stultz --- v2: * Switched to use reworked

[PATCH v7 1/5] dma-buf: Add dma-buf heaps framework

2019-07-23 Thread John Stultz
: Andrew F. Davis Signed-off-by: John Stultz --- v2: * Folded down fixes I had previously shared in implementing heaps * Make flags a u64 (Suggested by Laura) * Add PAGE_ALIGN() fix to the core alloc funciton * IOCTL fixups suggested by Brian * Added fixes suggested by Benjamin * Removed core stat

[PATCH v2 3/3] net/xdp: convert put_page() to put_user_page*()

2019-07-23 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeh

[PATCH v2 2/3] drivers/gpu/drm/via: convert put_page() to put_user_page*()

2019-07-23 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeh

[PATCH v2 0/3] mm/gup: add make_dirty arg to put_user_pages_dirty_lock()

2019-07-23 Thread john . hubbard
From: John Hubbard Changes since v1: * Instead of providing __put_user_pages(), add an argument to put_user_pages_dirty_lock(), and delete put_user_pages_dirty(). This is based on the following points: 1. Lots of call sites become simpler if a bool is passed into put_user_page

[PATCH v2 1/3] mm/gup: add make_dirty arg to put_user_pages_dirty_lock()

2019-07-23 Thread john . hubbard
From: John Hubbard Provide more capable variation of put_user_pages_dirty_lock(), and delete put_user_pages_dirty(). This is based on the following: 1. Lots of call sites become simpler if a bool is passed into put_user_page*(), instead of making the call site choose which put_user_page

Re: [PATCH v2 1/3] mm/gup: add make_dirty arg to put_user_pages_dirty_lock()

2019-07-23 Thread John Hubbard
On 7/23/19 6:26 PM, john.hubb...@gmail.com wrote: > From: John Hubbard ... > + * 2) This code sees the page as clean, so it calls > + * set_page_dirty(). The page stays dirty, despite being > + * written back, so it gets written back

[PATCH v3 0/3] mm/gup: add make_dirty arg to put_user_pages_dirty_lock()

2019-07-23 Thread john . hubbard
From: John Hubbard Hi, I apologize for the extra emails (v2 was sent pretty recently), but I didn't want to leave a known-broken version sitting out there, creating problems. Changes since v2: * Critical bug fix: remove a stray "break;" from the new routine. Changes since v1

[PATCH v3 3/3] net/xdp: convert put_page() to put_user_page*()

2019-07-23 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeh

[PATCH v3 1/3] mm/gup: add make_dirty arg to put_user_pages_dirty_lock()

2019-07-23 Thread john . hubbard
From: John Hubbard Provide more capable variation of put_user_pages_dirty_lock(), and delete put_user_pages_dirty(). This is based on the following: 1. Lots of call sites become simpler if a bool is passed into put_user_page*(), instead of making the call site choose which put_user_page

[PATCH v3 2/3] drivers/gpu/drm/via: convert put_page() to put_user_page*()

2019-07-23 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeh

Re: [PATCH v6 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps

2019-07-24 Thread John Stultz
On Wed, Jul 24, 2019 at 12:00 AM Christoph Hellwig wrote: > On Mon, Jul 22, 2019 at 10:04:06PM -0700, John Stultz wrote: > > Apologies, I'm not sure I'm understanding your suggestion here. > > dma_alloc_contiguous() does have some interesting optimizations > > (

Re: Limits for ION Memory Allocator

2019-07-24 Thread John Stultz
perror("[-] open /dev/ion"); > > return 1; > > } > > > > while (1) { > > printf("iter %lu\n", i); > > ioctl(fd, ION_IOC_ALLOC, &data); > > i++; >

Re: Limits for ION Memory Allocator

2019-07-24 Thread John Stultz
On Wed, Jul 24, 2019 at 1:18 PM John Stultz wrote: > > On Wed, Jul 24, 2019 at 12:36 PM Laura Abbott wrote: > > > > On 7/17/19 12:31 PM, Alexander Popov wrote: > > > Hello! > > > > > > The syzkaller [1] has a trouble with fuzzing the Linux

Re: kernel panic: stack is corrupted in pointer

2019-07-25 Thread John Fastabend
Dmitry Vyukov wrote: > On Tue, Jul 23, 2019 at 7:26 PM John Fastabend > wrote: > > > > Dmitry Vyukov wrote: > > > On Wed, Jul 17, 2019 at 10:58 AM syzbot > > > wrote: > > > > > > > > Hello, > > > > > > > > syz

Re: [PATCH v7 3/5] dma-buf: heaps: Add system heap to dmabuf heaps

2019-07-25 Thread John Stultz
dma-heaps core would call it, it would only be a tool for the helper infrastructure to trace back to the heap specific free call. This is why its passed to the heap_helper initializer. I agree it feels a little odd, so I'd welcome alternate approaches. Very much appreciate the review and feedback! I'll try to address as much of this as I can in the next revision. thanks -john

[PATCH v4 2/3] drivers/gpu/drm/via: convert put_page() to put_user_page*()

2019-07-31 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeh

[PATCH v3 03/26] drm: kirin: Remove HISI_KIRIN_DW_DSI config option

2019-07-31 Thread John Stultz
The CONFIG_HISI_KIRIN_DW_DSI option is only used w/ kirin driver, so cut out the middleman and condense the config logic down. Cc: Rongrong Zou Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel Cc: Sam Ravnborg Reviewed-by: Sam Ravnborg Signed-off-by: John Stultz --- drivers/gpu/drm

[PATCH v3 02/26] drm: kirin: Get rid of drmP.h includes

2019-07-31 Thread John Stultz
Remove use of drmP.h in kirin driver Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel Cc: Sam Ravnborg Suggested-by: Sam Ravnborg Signed-off-by: John Stultz --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 6 +- drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 4 +++- 2 files

[PATCH v3 01/26] drm: kirin: Fix for hikey620 display offset problem

2019-07-31 Thread John Stultz
ommit message, checkpatch cleanups] Signed-off-by: John Stultz --- v2: Minor cleanups v3: Rename workqueue entry for clarity (suggested by Sam) --- .../gpu/drm/hisilicon/kirin/kirin_ade_reg.h | 1 + .../gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 22 +++ 2 files changed, 23 inser

[PATCH v3 04/26] drm: kirin: Remove unreachable return

2019-07-31 Thread John Stultz
The 'return 0' in kirin_drm_platform_probe() is unreachable code, so remove it. Cc: Rongrong Zou Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel Cc: Sam Ravnborg Reviewed-by: Sam Ravnborg Suggested by: Xu YiPing Signed-off-by: John Stultz --- drivers/gpu/drm/hisil

[PATCH v3 07/26] drm: kirin: Rename ade_plane to kirin_plane

2019-07-31 Thread John Stultz
future patch Cc: Rongrong Zou Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel Cc: Sam Ravnborg Reviewed-by: Sam Ravnborg Signed-off-by: Xu YiPing [jstultz: reworded commit message] Signed-off-by: John Stultz --- .../gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 57 ++- 1

[PATCH v3 12/26] drm: kirin: Move kirin_crtc, kirin_plane, kirin_format to kirin_drm_drv.h

2019-07-31 Thread John Stultz
Airlie Cc: Daniel Vetter Cc: dri-devel Cc: Sam Ravnborg Reviewed-by: Sam Ravnborg Signed-off-by: Xu YiPing [jstultz: reworded commit message] Signed-off-by: John Stultz --- .../gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 27 ++- .../gpu/drm/hisilicon/kirin/kirin_drm_drv.h | 24

[PATCH v3 10/26] drm: kirin: Move request irq handle in ade hw ctx alloc

2019-07-31 Thread John Stultz
-off-by: John Stultz --- .../gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 29 +++ 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c index ddcfe0c42d7c..0e0fe1cb945f 100644

[PATCH v3 06/26] drm: kirin: Remove out_format from ade_crtc

2019-07-31 Thread John Stultz
: Rongrong Zou Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel Cc: Sam Ravnborg Reviewed-by: Sam Ravnborg Signed-off-by: Xu YiPing [jstultz: reworded commit message] Signed-off-by: John Stultz --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 9 +++-- 1 file changed, 3 insertions

[PATCH v3 14/26] drm: kirin: Move ade crtc/plane help functions to driver_data

2019-07-31 Thread John Stultz
Zou Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel Cc: Sam Ravnborg Reviewed-by: Sam Ravnborg Signed-off-by: Xu YiPing [jstultz: reworded commit message] Signed-off-by: John Stultz --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 15 ++- drivers/gpu/drm/hisilicon/kirin

[PATCH v3 08/26] drm: kirin: Rename ade_crtc to kirin_crtc

2019-07-31 Thread John Stultz
future patch Cc: Rongrong Zou Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel Cc: Sam Ravnborg Reviewed-by: Sam Ravnborg Signed-off-by: Xu YiPing [jstultz: reworded commit message] Signed-off-by: John Stultz --- .../gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 74 +-- 1 file

[PATCH v3 05/26] drm: kirin: Remove uncessary parameter indirection

2019-07-31 Thread John Stultz
Ravnborg Reviewed-by: Sam Ravnborg Signed-off-by: Xu YiPing [jstultz: reworded commit message] Signed-off-by: John Stultz --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/kirin

[PATCH v3 18/26] drm: kirin: Move config max_width and max_height to driver data

2019-07-31 Thread John Stultz
kirin_drm_data structure. Cc: Rongrong Zou Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel Cc: Sam Ravnborg Reviewed-by: Sam Ravnborg Signed-off-by: Xu YiPing [jstultz: reworded commit message] Signed-off-by: John Stultz --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 2 ++ drivers

[PATCH v3 00/26] drm: Kirin driver cleanups to prep for Kirin960 support

2019-07-31 Thread John Stultz
inline-WIP Feedback would be greatly appreciated! thanks -john Cc: Rongrong Zou Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel Cc: Sam Ravnborg Da Lv (1): drm: kirin: Fix for hikey620 display offset problem John Stultz (4): drm: kirin: Get rid of drmP.h includes drm: kir

[PATCH v3 15/26] drm: kirin: Move channel formats to driver data

2019-07-31 Thread John Stultz
: David Airlie Cc: Daniel Vetter Cc: dri-devel Cc: Sam Ravnborg Reviewed-by: Sam Ravnborg Signed-off-by: Xu YiPing [jstultz: reworded commit message] Signed-off-by: John Stultz --- .../gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 30 +-- .../gpu/drm/hisilicon/kirin

[PATCH v3 16/26] drm: kirin: Move mode config function to driver_data

2019-07-31 Thread John Stultz
: Rongrong Zou Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel Cc: Sam Ravnborg Reviewed-by: Sam Ravnborg Signed-off-by: Xu YiPing Signed-off-by: John Stultz --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 10 ++ drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 8

[PATCH v3 13/26] drm: kirin: Reanme dc_ops to kirin_drm_data

2019-07-31 Thread John Stultz
Ravnborg Reviewed-by: Sam Ravnborg Signed-off-by: Xu YiPing [jstultz: reworded commit message] Signed-off-by: John Stultz --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 2 +- drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 16 drivers/gpu/drm/hisilicon/kirin

[PATCH v3 17/26] drm: kirin: Move plane number and primay plane in driver data

2019-07-31 Thread John Stultz
. Cc: Rongrong Zou Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel Cc: Sam Ravnborg Reviewed-by: Sam Ravnborg Signed-off-by: Xu YiPing Signed-off-by: John Stultz --- .../gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 21 --- .../gpu/drm/hisilicon/kirin/kirin_drm_drv.h | 2

[PATCH v3 09/26] drm: kirin: Dynamically allocate the hw_ctx

2019-07-31 Thread John Stultz
point to hardware revision specific ctx structures. Cc: Rongrong Zou Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel Cc: Sam Ravnborg Reviewed-by: Sam Ravnborg Signed-off-by: Xu YiPing [jstultz: reworded commit message] Signed-off-by: John Stultz --- .../gpu/drm/hisilicon/kirin

[PATCH v3 11/26] drm: kirin: Move workqueue to ade_hw_ctx structure

2019-07-31 Thread John Stultz
Cc: Sam Ravnborg Reviewed-by: Sam Ravnborg Signed-off-by: John Stultz --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin

[PATCH v3 22/26] drm: kirin: Fix dev->driver_data setting

2019-07-31 Thread John Stultz
ter Cc: dri-devel Cc: Sam Ravnborg Reviewed-by: Sam Ravnborg Signed-off-by: Xu YiPing [jstultz: Reworded commit message] Signed-off-by: John Stultz --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 1 - drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 3 +-- 2 files changed, 1 insertion(+)

[PATCH v3 20/26] drm: kirin: Add register connect helper functions in drm init

2019-07-31 Thread John Stultz
Cc: Sam Ravnborg Reviewed-by: Sam Ravnborg Signed-off-by: Xu YiPing [jstultz: reworded commit message] Signed-off-by: John Stultz --- .../gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 1 + .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 43 +++ .../gpu/drm/hisilicon/kirin

[PATCH v3 24/26] drm: kirin: Add alloc_hw_ctx/clean_hw_ctx ops in driver data

2019-07-31 Thread John Stultz
kirin_drm_drv.c Cc: Rongrong Zou Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel Cc: Sam Ravnborg Reviewed-by: Sam Ravnborg Signed-off-by: Xu YiPing [jstultz: Reworded commit message] Signed-off-by: John Stultz --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 9 - drivers/gpu/drm

[PATCH v3 26/26] drm: kirin: Move ade drm init to kirin drm drv

2019-07-31 Thread John Stultz
added later) kirin960 specific support code. Cc: Rongrong Zou Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel Cc: Sam Ravnborg Reviewed-by: Sam Ravnborg Signed-off-by: Xu YiPing [jstultz: Reworded commit message] Signed-off-by: John Stultz --- .../gpu/drm/hisilicon/kirin/kirin_drm_ade.c

[PATCH v3 25/26] drm: kirin: Pass driver data to crtc init and plane init

2019-07-31 Thread John Stultz
kirin_drm_drv.c using alternative driver_data structures that support other hardware. Cc: Rongrong Zou Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel Cc: Sam Ravnborg Reviewed-by: Sam Ravnborg Signed-off-by: Xu YiPing [jstultz: Reworded commit message] Signed-off-by: John Stultz --- v2

[PATCH v3 21/26] drm: kirin: Rename plane_init and crtc_init

2019-07-31 Thread John Stultz
Cc: Daniel Vetter Cc: dri-devel Cc: Sam Ravnborg Reviewed-by: Sam Ravnborg Signed-off-by: Xu YiPing [jstultz: reworded commit message] Signed-off-by: John Stultz --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a

[PATCH v3 19/26] drm: kirin: Move drm driver to driver data

2019-07-31 Thread John Stultz
Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel Cc: Sam Ravnborg Reviewed-by: Sam Ravnborg Signed-off-by: Xu YiPing [jstultz: Reworded commit message] Signed-off-by: John Stultz --- .../gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 27 + .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c

[PATCH v3 23/26] drm: kirin: Make driver_data variable non-global

2019-07-31 Thread John Stultz
Airlie Cc: Daniel Vetter Cc: dri-devel Cc: Sam Ravnborg Reviewed-by: Sam Ravnborg Signed-off-by: Xu YiPing [jstultz: Reworded commit message] Signed-off-by: John Stultz --- .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 43 +++ 1 file changed, 24 insertions(+), 19 deletions

[PATCH v5 1/3] mm/gup: add make_dirty arg to put_user_pages_dirty_lock()

2019-08-01 Thread john . hubbard
From: John Hubbard Provide more capable variation of put_user_pages_dirty_lock(), and delete put_user_pages_dirty(). This is based on the following: 1. Lots of call sites become simpler if a bool is passed into put_user_page*(), instead of making the call site choose which put_user_page

[PATCH v5 0/3] mm/gup: add make_dirty arg to put_user_pages_dirty_lock()

2019-08-01 Thread john . hubbard
From: John Hubbard Changes since v4: * Christophe Hellwig's review applied: deleted siw_free_plist() and __qib_release_user_pages(), now that put_user_pages_dirty_lock() does what those routines were doing. * Applied Bjorn's ACK for net/xdp, and Christophe's Reviewed-by

[PATCH v5 2/3] drivers/gpu/drm/via: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeh

[PATCH v5 3/3] net/xdp: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeh

Re: [PATCH v9 04/18] kunit: test: add kunit_stream a std::stream like logger

2019-08-02 Thread John Ogness
attempts to make it more reliable. But it was >>>> always either too complicated or error prone or both. >>>> >>>> You need to use your own buffering if you rely want perfect output. >>>> The question is if it is really worth the complexity. Also note

[PATCH 29/34] mm/process_vm_access.c: convert put_page() to put_user_page*()

2019-08-02 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeh

[PATCH 06/34] drm/i915: convert put_page() to put_user_page*()

2019-08-02 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeh

[PATCH 30/34] crypt: convert put_page() to put_user_page*()

2019-08-02 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeh

[PATCH 25/34] mm/frame_vector.c: convert put_page() to put_user_page*()

2019-08-02 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeh

[PATCH 32/34] goldfish_pipe: convert put_page() to put_user_page*()

2019-08-02 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeh

[PATCH 23/34] uprobes: convert put_page() to put_user_page*()

2019-08-02 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeh

[PATCH 28/34] mm/madvise.c: convert put_page() to put_user_page*()

2019-08-02 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeh

[PATCH 01/34] mm/gup: add make_dirty arg to put_user_pages_dirty_lock()

2019-08-02 Thread john . hubbard
From: John Hubbard Provide more capable variation of put_user_pages_dirty_lock(), and delete put_user_pages_dirty(). This is based on the following: 1. Lots of call sites become simpler if a bool is passed into put_user_page*(), instead of making the call site choose which put_user_page

[PATCH 17/34] vfio: convert put_page() to put_user_page*()

2019-08-02 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeh

<    2   3   4   5   6   7   8   9   10   11   >