[PATCH 3/3] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable qcom wled backlight and link to panel

2022-03-30 Thread Joel Selvaraj
Xiaomi Poco F1 uses the QCOM WLED driver for backlight control. Enable and link it to the panel to use it. Signed-off-by: Joel Selvaraj --- .../arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845

[PATCH 1/3] drm/panel: nt36672a: add backlight support

2022-03-30 Thread Joel Selvaraj
Add support for backlight. This panel supports backlight control through the QCOM WLED driver in Xiaomi Poco F1 device. Signed-off-by: Joel Selvaraj --- drivers/gpu/drm/panel/panel-novatek-nt36672a.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-novatek

[PATCH 2/3] dt-bindings: display: novatek, nt36672a: add backlight property

2022-03-30 Thread Joel Selvaraj
Add backlight property and update example to include it. Signed-off-by: Joel Selvaraj --- .../devicetree/bindings/display/panel/novatek,nt36672a.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml b/Documentation

[PATCH 0/3] drm/panel: nt36672a: add backlight support

2022-03-30 Thread Joel Selvaraj
Joel Selvaraj (3): drm/panel: nt36672a: add backlight support dt-bindings: display: novatek,nt36672a: add backlight property arm64: dts: qcom: sdm845-xiaomi-beryllium: enable qcom wled backlight and link to panel .../bindings/display/panel/novatek,nt36672a.yaml| 2 ++ .../arm64

Re: [PATCH 3/3] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable qcom wled backlight and link to panel

2022-03-30 Thread Joel Selvaraj
Hi Marijn, On 30/03/22 12:47, Marijn Suijten wrote: > On 2022-03-30 12:26:39, Joel Selvaraj wrote: >> Xiaomi Poco F1 uses the QCOM WLED driver for backlight control. >> Enable and link it to the panel to use it. >> >> Signed-off-by: Joel Selvaraj >> --- &g

Re: [PATCH v2 1/3] drm/panel: nt36672a: add backlight support

2022-06-07 Thread Joel Selvaraj
indly let me know if changes are required from my end. With Regards, Joel Selvaraj

Re: [PATCH v2 1/3] drm/panel: nt36672a: add backlight support

2022-06-08 Thread Joel Selvaraj
Sumit. Best Regards, Joel Selvaraj

Re: [PATCH v2 1/3] drm/panel: nt36672a: add backlight support

2022-06-08 Thread Joel Selvaraj
Hi Sumit, On 08/06/22 23:22, Sumit Semwal wrote: Not for 5.19-rcs for sure, but I think it should make it for 5.20-rcs? Ok. No problem. Thanks. Best, Sumit. Best Regards, Joel Selvaraj

[PATCH 0/3] Introduce EBBG FT8719 DRM panel driver

2022-05-06 Thread Joel Selvaraj
upport for handling regulators and linking external backlight is added. [1] https://github.com/msm8916-mainline/linux-mdss-dsi-panel-driver-generator Joel Selvaraj (3): dt-bindings: vendor-prefixes: Add prefix for EBBG dt-bindings: display: Add bindings for EBBG FT8719 drm/panel: introduce e

[PATCH 1/3] dt-bindings: vendor-prefixes: Add prefix for EBBG

2022-05-06 Thread Joel Selvaraj
Add a prefix for EBBG. They manufacture displays which are used in some Xiaomi phones, but I could not find much details about the company. Signed-off-by: Joel Selvaraj --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation

[PATCH 2/3] dt-bindings: display: Add bindings for EBBG FT8719

2022-05-06 Thread Joel Selvaraj
Add bindings for the EBBG FT8719 6.18" 2246x1080 DSI video mode panel, which can be found on some Xiaomi Poco F1 phones. The backlight is managed through the QCOM WLED driver. Signed-off-by: Joel Selvaraj --- .../bindings/display/panel/ebbg,ft8719.yaml | 78 +++ 1 file ch

[PATCH 3/3] drm/panel: introduce ebbg,ft8719 panel

2022-05-06 Thread Joel Selvaraj
Add DRM panel driver for EBBG FT8719 6.18" 2246x1080 DSI video mode panel, which can be found on some Xiaomi Poco F1 phones. The panel's backlight is managed through QCOM WLED driver. Signed-off-by: Joel Selvaraj --- MAINTAINERS | 7 + drivers/gpu

Re: [PATCH 2/3] dt-bindings: display: Add bindings for EBBG FT8719

2022-05-08 Thread Joel Selvaraj
Hi Krzysztof Kozlowski, Thank you for your review. Will fix them in v2. Regards Joel Selvaraj

Re: [PATCH 2/3] dt-bindings: display: Add bindings for EBBG FT8719

2022-05-08 Thread Joel Selvaraj
rue" and 46 panels mention "backlight: true". Almost all panels refer the panel-common.yaml too. So I think specifying them as true is just for extra clarity that these properties are usually used by this panel? But I am not very sure. Should I leave them be? or it's still r

[PATCH v2 0/3] Introduce EBBG FT8719 DRM panel driver

2022-05-10 Thread Joel Selvaraj
roperties - dt-bindings: in example change "|+" to "|' and "dsi0" to "dsi" Joel Selvaraj (3): dt-bindings: vendor-prefixes: Add prefix for EBBG dt-bindings: display: Add bindings for EBBG FT8719 drm/panel: introduce ebbg,ft8719 panel .../bindings/disp

[PATCH v2 1/3] dt-bindings: vendor-prefixes: Add prefix for EBBG

2022-05-10 Thread Joel Selvaraj
Add a prefix for EBBG. They manufacture displays which are used in some Xiaomi phones, but I could not find much details about the company. Signed-off-by: Joel Selvaraj --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation

[PATCH v2 2/3] dt-bindings: display: Add bindings for EBBG FT8719

2022-05-10 Thread Joel Selvaraj
Add bindings for the EBBG FT8719 6.18" 2246x1080 DSI video mode panel, which can be found on some Xiaomi Poco F1 phones. The backlight is managed through the QCOM WLED driver. Signed-off-by: Joel Selvaraj --- Changes in v2: (Krzysztof Kozlowski's Suggestions) - Specify maxIte

[PATCH v2 3/3] drm/panel: introduce ebbg,ft8719 panel

2022-05-10 Thread Joel Selvaraj
Add DRM panel driver for EBBG FT8719 6.18" 2246x1080 DSI video mode panel, which can be found on some Xiaomi Poco F1 phones. The panel's backlight is managed through QCOM WLED driver. Signed-off-by: Joel Selvaraj --- MAINTAINERS | 7 + drivers/gpu

Re: [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add prefix for EBBG

2022-05-11 Thread Joel Selvaraj
ly. > > https://elixir.bootlin.com/linux/v5.13/source/Documentation/process/submitting-patches.rst#L543 > > If a tag was not added on purpose, please state why and what changed. My bad. Completely forgot to pick the Acked-by. I will make sure to pick them up in future patches. Best Regards, Joel Selvaraj

Re: [PATCH 3/3] drm/panel: introduce ebbg,ft8719 panel

2022-05-16 Thread Joel Selvaraj
Hi Linus Walleij, On 13/05/22 03:21, Linus Walleij wrote: On Fri, May 6, 2022 at 2:18 PM Joel Selvaraj wrote: +#define dsi_dcs_write_seq(dsi, seq...) do {\ + static const u8 d[] = { seq }; \ + int ret

Re: [PATCH 3/3] drm/panel: introduce ebbg,ft8719 panel

2022-05-25 Thread Joel Selvaraj
combined into single write? Don't know much about this. Anyways since the panel works without all these magic commands, these will be removed in the next version. Yours, Linus Walleij Thanks and Regards Joel Selvaraj

[PATCH v3 0/3] Introduce EBBG FT8719 DRM panel driver

2022-05-30 Thread Joel Selvaraj
ge "|+" to "|' and "dsi0" to "dsi" Joel Selvaraj (3): dt-bindings: vendor-prefixes: Add prefix for EBBG dt-bindings: display: Add bindings for EBBG FT8719 drm/panel: introduce ebbg,ft8719 panel .../bindings/display/panel/ebbg,ft8719.yaml | 74 +

[PATCH v3 1/3] dt-bindings: vendor-prefixes: Add prefix for EBBG

2022-05-30 Thread Joel Selvaraj
Add a prefix for EBBG. They manufacture displays which are used in some Xiaomi phones, but I could not find much details about the company. Signed-off-by: Joel Selvaraj Acked-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions

[PATCH v3 2/3] dt-bindings: display: Add bindings for EBBG FT8719

2022-05-30 Thread Joel Selvaraj
Add bindings for the EBBG FT8719 6.18" 2246x1080 DSI video mode panel, which can be found on some Xiaomi Poco F1 phones. The backlight is managed through the QCOM WLED driver. Signed-off-by: Joel Selvaraj Reviewed-by: Krzysztof Kozlowski Reviewed-by: Linus Walleij --- Changes in v2: (Krzy

[PATCH v3 3/3] drm/panel: introduce ebbg,ft8719 panel

2022-05-30 Thread Joel Selvaraj
Add DRM panel driver for EBBG FT8719 6.18" 2246x1080 DSI video mode panel, which can be found on some Xiaomi Poco F1 phones. The panel's backlight is managed through QCOM WLED driver. Signed-off-by: Joel Selvaraj Reviewed-by: Sam Ravnborg --- Changes in v3: (Mostly Linus Walleij

[PATCH v4 0/4] Introduce EBBG FT8719 DRM panel driver

2022-06-01 Thread Joel Selvaraj
magic power on sequences as panel works fine without them Changes in v2: (Krzysztof Kozlowski's Suggestions) - dt-bindings: specify maxItems for reg - dt-bindings: cleanup and simplify the panel properties - dt-bindings: in example change "|+" to "|' and "dsi0" t

[PATCH v4 1/4] dt-bindings: vendor-prefixes: Add prefix for EBBG

2022-06-01 Thread Joel Selvaraj
Add a prefix for EBBG. They manufacture displays which are used in some Xiaomi phones, but I could not find much details about the company. Signed-off-by: Joel Selvaraj Acked-by: Krzysztof Kozlowski Acked-by: Linus Walleij --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1

[PATCH v4 2/4] dt-bindings: display: Add bindings for EBBG FT8719

2022-06-01 Thread Joel Selvaraj
Add bindings for the EBBG FT8719 6.18" 2246x1080 DSI video mode panel, which can be found on some Xiaomi Poco F1 phones. The backlight is managed through the QCOM WLED driver. Signed-off-by: Joel Selvaraj Reviewed-by: Krzysztof Kozlowski Reviewed-by: Linus Walleij --- Changes in v2: (Krzy

[PATCH v4 3/4] drm/mipi-dsi: Introduce mipi_dsi_dcs_write_seq macro

2022-06-01 Thread Joel Selvaraj
A helper macro that can be used to simplify sending DCS commands. It is useful in scenarios like panel initialization which can sometimes involve sending lot of DCS commands. Signed-off-by: Joel Selvaraj --- Changes in v4: (Linus Walleij's Suggestion) - Introduce mipi_dsi_dcs_write_seq mac

[PATCH v4 4/4] drm/panel: introduce ebbg,ft8719 panel

2022-06-01 Thread Joel Selvaraj
Add DRM panel driver for EBBG FT8719 6.18" 2246x1080 DSI video mode panel, which can be found on some Xiaomi Poco F1 phones. The panel's backlight is managed through QCOM WLED driver. Signed-off-by: Joel Selvaraj Reviewed-by: Sam Ravnborg --- Changes in v4: (Linus Walleij&#x

[PATCH v2 0/3] drm/panel: nt36672a: add backlight support

2022-03-31 Thread Joel Selvaraj
Changes in v2: - Remove qcom,enabled-strings property as either it or qcom,num-strings should be present. qcom,num-strings is specified and sufficient. (Marijn Suijten's Suggestion) Joel Selvaraj (3): drm/panel: nt36672a: add backlight support dt-bindings: display: novatek,nt3

[PATCH v2 1/3] drm/panel: nt36672a: add backlight support

2022-03-31 Thread Joel Selvaraj
Add support for backlight. This panel supports backlight control through the QCOM WLED driver in Xiaomi Poco F1 device. Signed-off-by: Joel Selvaraj --- drivers/gpu/drm/panel/panel-novatek-nt36672a.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-novatek

[PATCH v2 2/3] dt-bindings: display: novatek, nt36672a: add backlight property

2022-03-31 Thread Joel Selvaraj
Add backlight property and update example to include it. Signed-off-by: Joel Selvaraj --- .../devicetree/bindings/display/panel/novatek,nt36672a.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml b/Documentation

[PATCH v2 3/3] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable qcom wled backlight and link to panel

2022-03-31 Thread Joel Selvaraj
Xiaomi Poco F1 uses the QCOM WLED driver for backlight control. Enable and link it to the panel to use it. Signed-off-by: Joel Selvaraj --- Changes in v2: - Remove qcom,enabled-strings property as either it or qcom,num-strings should be present. qcom,num-strings is specified and sufficient

Re: [RFT PATCH v2 19/48] drm/panel: novatek-nt36672a: Don't call unprepare+disable at shutdown/remove

2024-05-04 Thread Joel Selvaraj
break anything and works as expected. So. Tested-by: Joel Selvaraj Regards Joel Selvaraj From: Douglas Anderson Sent: 04 May 2024 03:03 To: dri-devel@lists.freedesktop.org; Maxime Ripard Cc: Linus Walleij; Chris Morgan; Yuran Pereira; Neil Armstrong; Do

Re: [RFT PATCH v2 18/48] drm/panel: novatek-nt36672a: Stop tracking prepared

2024-05-04 Thread Joel Selvaraj
break anything and works as expected. So. Tested-by: Joel Selvaraj Regards Joel Selvaraj From: Douglas Anderson Sent: 04 May 2024 03:02 To: dri-devel@lists.freedesktop.org; Maxime Ripard Cc: Linus Walleij; Chris Morgan; Yuran Pereira; Neil Armstrong; Do

Re: [RFT PATCH v2 19/48] drm/panel: novatek-nt36672a: Don't call unprepare+disable at shutdown/remove

2024-05-04 Thread Joel Selvaraj
Sorry for the long lines. Had to use a different email client and ended messing it up. Regards Joel Selvaraj From: Joel Selvaraj Sent: 05 May 2024 05:28 To: Douglas Anderson; dri-devel@lists.freedesktop.org; Maxime Ripard Cc: Linus Walleij; Chris Morgan