Re: [PATCH 1/1] video: hyperv_fb: Add ratelimit on error message

2021-04-20 Thread Joe Perches
On Tue, 2021-04-20 at 08:44 -0700, Michael Kelley wrote: > Due to a full ring buffer, the driver may be unable to send updates to > the Hyper-V host. But outputing the error message can make the problem > worse because console output is also typically written to the frame > buffer. As a result, i

Re: [PATCH 1/8] drm/ingenic: Remove dead code

2021-08-08 Thread Joe Perches
On Sun, 2021-08-08 at 19:58 +0200, Thomas Zimmermann wrote: > > Am 08.08.21 um 15:45 schrieb Paul Cercueil: > > The priv->ipu_plane would get a different value further down the code, > > without the first assigned value being read first; so the first > > assignation can be dropped. > > > > Signed

Re: [PATCH] drm/bridge/tc358767: make the array ext_div static const, makes object smaller

2021-08-19 Thread Joe Perches
On Thu, 2021-08-19 at 14:38 +0100, Colin King wrote: > From: Colin Ian King > > Don't populate the array ext_div on the stack but instead it > static const. Makes the object code smaller by 118 bytes: > > Before: >    textdatabss dechex filename >   39449 17500128 57077

Re: [PATCH] drm/bridge/tc358767: make the array ext_div static const, makes object smaller

2021-08-19 Thread Joe Perches
On Thu, 2021-08-19 at 14:54 +0100, Colin Ian King wrote: > On 19/08/2021 14:51, Joe Perches wrote: > > On Thu, 2021-08-19 at 14:38 +0100, Colin King wrote: > > > From: Colin Ian King > > > > > > Don't populate the array ext_div on the stack but instea

Re: [PATCH] drm/bridge/tc358767: make the array ext_div static const, makes object smaller

2021-08-19 Thread Joe Perches
On Thu, 2021-08-19 at 15:51 +0100, Colin Ian King wrote: > it still makes sense for these kind of > janitorial changes as it makes sense to constify arrays when they are > read-only and making them static is sensible for const data. I'm not disagreeing. Marking unmodifiable arrays as const is gen

Re: [PATCH] drm: Few typo fixes

2021-03-18 Thread Joe Perches
On Thu, 2021-03-18 at 16:07 +0530, Bhaskar Chowdhury wrote: > s/instatiated/instantiated/ > s/unreference/unreferenced/ []> diff --git a/drivers/gpu/drm/drm_property.c b/drivers/gpu/drm/drm_property.c [] > @@ -644,7 +644,7 @@ EXPORT_SYMBOL(drm_property_blob_get); >   * @id: id of the blob property

Re: [PATCH] drm/imx: fix out of bounds array access warning

2021-03-23 Thread Joe Perches
On Tue, 2021-03-23 at 14:05 +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > When CONFIG_OF is disabled, building with 'make W=1' produces warnings > about out of bounds array access: > > drivers/gpu/drm/imx/imx-ldb.c: In function 'imx_ldb_set_clock.constprop': > drivers/gpu/drm/imx/imx-ldb

Re: [PATCH] video: mmp: Few typo fixes

2021-03-23 Thread Joe Perches
On Mon, 2021-03-22 at 12:36 -0700, Randy Dunlap wrote: > On 3/22/21 6:02 AM, Bhaskar Chowdhury wrote: > > > > s/configed/configured/ > > s/registed/registered/ > > s/defintions/definitions/ > > > > Signed-off-by: Bhaskar Chowdhury > > Acked-by: Randy Dunlap [] > > diff --git a/include/video/mm

Re: [PATCH] [v2] drm/imx: imx-ldb: fix out of bounds array access warning

2021-03-24 Thread Joe Perches
On Wed, 2021-03-24 at 13:17 +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > When CONFIG_OF is disabled, building with 'make W=1' produces warnings > about out of bounds array access: > > drivers/gpu/drm/imx/imx-ldb.c: In function 'imx_ldb_set_clock.constprop': > drivers/gpu/drm/imx/imx-ldb

Re: [PATCH] amdgpu: fix gcc -Wrestrict warning

2021-03-24 Thread Joe Perches
On Tue, 2021-03-23 at 14:04 +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc warns about an sprintf() that uses the same buffer as source > and destination, which is undefined behavior in C99: > > drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c: In function > 'amdgpu_securedisplay_de

Re: [PATCH] [v2] drm/imx: imx-ldb: fix out of bounds array access warning

2021-03-24 Thread Joe Perches
On Wed, 2021-03-24 at 17:42 +0100, Arnd Bergmann wrote: > On Wed, Mar 24, 2021 at 3:20 PM Joe Perches wrote: [] > > > diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c > > [] > > > @@ -197,6 +197,12 @@ static void imx_ldb_encoder_enable(struct

[RFC patch] vsprintf: Allow %pe to print non PTR_ERR %pe uses as decimal

2021-03-24 Thread Joe Perches
On Wed, 2021-03-24 at 09:52 -0700, Joe Perches wrote: > On Wed, 2021-03-24 at 17:42 +0100, Arnd Bergmann wrote: > > On Wed, Mar 24, 2021 at 3:20 PM Joe Perches wrote: > [] > > > > diff --git a/drivers/gpu/drm/imx/imx-ldb.c > > > > b/drivers/gpu/drm/imx/

Re: [RFC patch] vsprintf: Allow %pe to print non PTR_ERR %pe uses as decimal

2021-03-24 Thread Joe Perches
On Wed, 2021-03-24 at 18:33 +0100, Rasmus Villemoes wrote: > On 24/03/2021 18.20, Joe Perches wrote: > > On Wed, 2021-03-24 at 09:52 -0700, Joe Perches wrote: > > > On Wed, 2021-03-24 at 17:42 +0100, Arnd Bergmann wrote: > > > > On Wed, Mar 24, 2021

Re: [RFC patch] vsprintf: Allow %pe to print non PTR_ERR %pe uses as decimal

2021-03-24 Thread Joe Perches
On Wed, 2021-03-24 at 22:27 +0100, Rasmus Villemoes wrote: > On 24/03/2021 20.24, Joe Perches wrote: > > On Wed, 2021-03-24 at 18:33 +0100, Rasmus Villemoes wrote: > > > On 24/03/2021 18.20, Joe Perches wrote: > > > > > > > > > > > Maybe it&#x

Re: [RFC patch] vsprintf: Allow %pe to print non PTR_ERR %pe uses as decimal

2021-03-24 Thread Joe Perches
On Wed, 2021-03-24 at 23:36 +0100, Rasmus Villemoes wrote: > On 24/03/2021 23.18, Joe Perches wrote: > > There's no silly game here. %pe would either print a string or a value. > > A hashed value, that is, never the raw value. There is value in printing the raw value.

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread Joe Perches
On Wed, 2021-01-27 at 17:49 +0300, Dan Carpenter wrote: > On Wed, Jan 27, 2021 at 03:25:20PM +0100, Greg KH wrote: > > Andy and Joe, there's something wrong here that is missing the fact that > > a line is being indented with spaces and not tabs in the patch > > at > > https://lore.kernel.org/r/1

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread Joe Perches
> Comments are the exception to the "no spaces at the start of a line" > rule. I was expecting that the kbuild-bot would send a Smatch warning > for inconsistent indenting, but comments are not counted there either. > > I'm sort of surprised that we don't have checkpatch rule about the > missing

Re: [PATCH 08/29] dma-buf: Avoid comma separated statements

2021-01-30 Thread Joe Perches
On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote: > Use semicolons and braces. Ping? > Signed-off-by: Joe Perches > --- >  drivers/dma-buf/st-dma-fence.c | 7 +-- >  1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma-buf/st-dma-fence.c b/d

Re: [PATCH 09/29] drm/gma500: Avoid comma separated statements

2021-01-30 Thread Joe Perches
On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote: > Use semicolons and braces. Ping? > Signed-off-by: Joe Perches > --- >  drivers/gpu/drm/gma500/mdfld_intel_display.c | 44 +--- >  1 file changed, 28 insertions(+), 16 deletions(-) > > diff --git a/d

Re: [PATCH 10/29] drm/i915: Avoid comma separated statements

2021-01-30 Thread Joe Perches
On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote: > Use semicolons and braces. Ping? > Signed-off-by: Joe Perches > --- >  drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 8 +--- >  drivers/gpu/drm/i915/gt/intel_gt_requests.c| 6 -- >  drive

Re: [PATCH 08/29] dma-buf: Avoid comma separated statements

2021-01-31 Thread Joe Perches
On Wed, 2021-02-03 at 14:26 +0100, Christian König wrote: > Am 30.01.21 um 19:47 schrieb Joe Perches: > > On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote: > > > Use semicolons and braces. > > Ping? > > > Signed-off-by: Joe Perches > Reviewed-by: Chri

Re: [PATCH] drm/msm/dp: Add a missing semi-colon

2021-02-06 Thread Joe Perches
On Sat, 2021-02-06 at 20:18 -0800, Stephen Boyd wrote: > A missing semicolon here causes my external display to stop working. > Indeed, missing the semicolon on the return statement leads to > dp_panel_update_tu_timings() not existing because the compiler thinks > it's part of the return statement

Re: [PATCH] drm/msm/dp: Add a missing semi-colon

2021-02-12 Thread Joe Perches
On Mon, 2021-02-08 at 10:57 -0800, Stephen Boyd wrote: > Quoting Joe Perches (2021-02-06 21:06:54) > > Wow, that's really unfortunate that dp_panel_update_tu_timings > > is also void. > > > > Perhaps this as YA checkpatch warning: > > > > --- >

[PATCH] drm: Convert S_ permission uses to octal

2021-02-12 Thread Joe Perches
WORLD_WRITABLE: Exporting writable files is usually an error. Consider more restrictive permissions. #688: FILE: drivers/gpu/drm/msm/adreno/a5xx_debugfs.c:157: + debugfs_create_file("reset", 0222, minor->debugfs_root, dev, &reset_fops); Signed-off-b

[trivial PATCH] drm/amd/display: Fix typo of format termination newline

2021-05-15 Thread Joe Perches
/n should be \n Signed-off-by: Joe Perches --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c | 2 +- drivers/gpu/drm/amd/display/dc/dcn301/dcn301_resource.c | 2 +- drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-23 Thread Joe Perches
On Mon, 2020-11-23 at 07:58 -0800, James Bottomley wrote: > We're also complaining about the inability to recruit maintainers: > > https://www.theregister.com/2020/06/30/hard_to_find_linux_maintainers_says_torvalds/ > > And burn out: > > http://antirez.com/news/129 https://www.wired.com/story/o

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-23 Thread Joe Perches
On Tue, 2020-11-24 at 11:58 +1100, Finn Thain wrote: > it's not for me to prove that such patches don't affect code > generation. That's for the patch author and (unfortunately) for reviewers. Ideally, that proof would be provided by the compilation system itself and not patch authors nor reviewe

Re: [PATCH v1 02/28] video: fbcon: Use pr_debug() in fbcon

2020-11-27 Thread Joe Perches
On Fri, 2020-11-27 at 20:57 +0100, Sam Ravnborg wrote: > Replacing DPRINTK() statements with pr_debug fixes > W=1 warnings. > And moves to a more standard logging setup at the same time. [] > diff --git a/drivers/video/fbdev/core/fbcon.c > b/drivers/video/fbdev/core/fbcon.c [] > @@ -1015,9 +1007,9

Re: [PATCH V2] treewide: Add missing semicolons to __assign_str uses

2021-06-30 Thread Joe Perches
On Sat, 2021-06-12 at 08:42 -0700, Joe Perches wrote: > The __assign_str macro has an unusual ending semicolon but the vast > majority of uses of the macro already have semicolon termination. ping?

Re: [RFC PATCH v2 1/4] drm_print.h: rewrap __DRM_DEFINE_DBG_RATELIMITED macro

2021-07-11 Thread Joe Perches
On Sat, 2021-07-10 at 23:49 -0600, Jim Cromie wrote: > whitespace only, to diff-minimize a later commit. > no functional changes [] > diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h [] > @@ -524,19 +524,24 @@ void __drm_err(const char *format, ...); >  #define DRM_DEBUG_DP(fmt, ...)

Re: [PATCH] drm/amd/display: Fix identical code for different branches

2021-07-11 Thread Joe Perches
On Sun, 2021-07-11 at 19:24 +0200, Len Baker wrote: > The branches of the "if" statement are the same. So remove the > unnecessary if and goto statements. > > Addresses-Coverity-ID: 1456916 ("Identical code for different branches") > Fixes: 4c283fdac08ab ("drm/amd/display: Add HDCP module") > Sign

drm/amd/display: Simplify hdcp validate_bksv

2021-07-11 Thread Joe Perches
ksv buffer instead of a loop. This also avoid a possible unaligned access of the temporary bksv. Signed-off-by: Joe Perches --- It seems quite odd 20 bits set is a magic number here. Should it be a specific be/le value instead? drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execut

Re: drm/amd/display: Simplify hdcp validate_bksv

2021-07-11 Thread Joe Perches
t; > url: > https://github.com/0day-ci/linux/commits/Joe-Perches/drm-amd-display-Simplify-hdcp-validate_bksv/20210712-034708 > base: git://anongit.freedesktop.org/drm-intel for-linux-next > config: i386-randconfig-a003-20210712 (attached as .config) > compiler

Re: [PATCH v2 0/8] slab: provide and use krealloc_array()

2020-11-02 Thread Joe Perches
On Mon, 2020-11-02 at 16:20 +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Andy brought to my attention the fact that users allocating an array of > equally sized elements should check if the size multiplication doesn't > overflow. This is why we have helpers like kmalloc_array

Re: [PATCH v4 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-11-03 Thread Joe Perches
On Tue, 2020-11-03 at 16:56 +0200, Sakari Ailus wrote: > On Tue, Nov 03, 2020 at 04:47:47PM +0200, Andy Shevchenko wrote: > > On Tue, Nov 03, 2020 at 03:34:00PM +0200, Sakari Ailus wrote: > > > Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM > > > pixel formats denoted by f

Re: Subject: [RFC] clang tooling cleanups

2020-11-09 Thread Joe Perches
On Tue, 2020-10-27 at 09:42 -0700, t...@redhat.com wrote: > This rfc will describe > An upcoming treewide cleanup. > How clang tooling was used to programatically do the clean up. > Solicit opinions on how to generally use clang tooling. > > The clang warning -Wextra-semi-stmt produces about 10k w

Re: [PATCH v4 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-11-13 Thread Joe Perches
On Fri, 2020-11-13 at 12:54 +0200, Sakari Ailus wrote: > Hi Joe, > > On Tue, Nov 03, 2020 at 08:49:36AM -0800, Joe Perches wrote: > > On Tue, 2020-11-03 at 16:56 +0200, Sakari Ailus wrote: > > > On Tue, Nov 03, 2020 at 04:47:47PM +0200, Andy Shevchenko wrote: > > >

Re: [PATCH 01/40] drm/amd/include/vega10_ip_offset: Mark _BASE structs as __maybe_unused

2020-11-15 Thread Joe Perches
On Fri, 2020-11-13 at 13:48 +, Lee Jones wrote: > This patch fixes nearly 400 warnings! > > These structures are too widely used in too many varying > configurations to be split-up into different headers or moved into > source files. > > Instead, we'll mark them as __maybe_unused which tells

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-20 Thread Joe Perches
On Fri, 2020-11-20 at 12:21 -0600, Gustavo A. R. Silva wrote: > Hi all, > > This series aims to fix almost all remaining fall-through warnings in > order to enable -Wimplicit-fallthrough for Clang. > > In preparation to enable -Wimplicit-fallthrough for Clang, explicitly > add multiple break/goto

Re: [RFC] MAINTAINERS tag for cleanup robot

2020-11-21 Thread Joe Perches
On Sat, 2020-11-21 at 08:50 -0800, t...@redhat.com wrote: > A difficult part of automating commits is composing the subsystem > preamble in the commit log. For the ongoing effort of a fixer producing > one or two fixes a release the use of 'treewide:' does not seem appropriate. > > It would be be

Re: [RFC] MAINTAINERS tag for cleanup robot

2020-11-21 Thread Joe Perches
On Sat, 2020-11-21 at 09:18 -0800, James Bottomley wrote: > On Sat, 2020-11-21 at 08:50 -0800, t...@redhat.com wrote: > > A difficult part of automating commits is composing the subsystem > > preamble in the commit log. For the ongoing effort of a fixer > > producing one or two fixes a release the

Re: [RFC] MAINTAINERS tag for cleanup robot

2020-11-22 Thread Joe Perches
On Sun, 2020-11-22 at 08:33 -0800, Tom Rix wrote: > On 11/21/20 9:10 AM, Joe Perches wrote: > > On Sat, 2020-11-21 at 08:50 -0800, t...@redhat.com wrote: > > > A difficult part of automating commits is composing the subsystem > > > preamble in the commit log. For th

Re: [RFC] MAINTAINERS tag for cleanup robot

2020-11-22 Thread Joe Perches
On Sun, 2020-11-22 at 08:49 -0800, James Bottomley wrote: > We can enforce sysfs_emit going forwards > using tools like checkpatch It's not really possible for checkpatch to find or warn about sysfs uses of sprintf. checkpatch is really just a trivial line-by-line parser and it has no concept of c

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-22 Thread Joe Perches
On Sun, 2020-11-22 at 10:21 -0800, James Bottomley wrote: > Please tell me > our reward for all this effort isn't a single missing error print. There were quite literally dozens of logical defects found by the fallthrough additions. Very few were logging only. _

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-22 Thread Joe Perches
On Sun, 2020-11-22 at 11:12 -0800, James Bottomley wrote: > On Sun, 2020-11-22 at 10:25 -0800, Joe Perches wrote: > > On Sun, 2020-11-22 at 10:21 -0800, James Bottomley wrote: > > > Please tell me our reward for all this effort isn't a single > > > missing error

Re: [RFC] MAINTAINERS tag for cleanup robot

2020-11-22 Thread Joe Perches
On Mon, 2020-11-23 at 09:33 +1100, Finn Thain wrote: > On Sun, 22 Nov 2020, Joe Perches wrote: > > But provably correct conversions IMO _should_ be done and IMO churn > > considerations should generally have less importance. [] > Moreover, the patch review workload for skill

Re: [PATCH] drm/v3d: Use kvcalloc

2022-03-12 Thread Joe Perches
On Sat, 2022-03-12 at 07:26 -0800, Harshit Mogalapalli wrote: > kvcalloc is same as kvmalloc_array + __GFP_ZERO. [] > diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c [] > @@ -308,9 +308,8 @@ v3d_lookup_bos(struct drm_device *dev, > return -EINVAL; > }

Re: [PATCH 1/6] drivers: usb: remove usage of list iterator past the loop body

2022-02-28 Thread Joe Perches
On Mon, 2022-02-28 at 14:24 +0300, Dan Carpenter wrote: > a multi-line indent gets curly braces for readability even though > it's not required by C. And then both sides would get curly braces. That's more your personal preference than a coding style guideline.

Re: dt-bindings: treewide: Update @st.com email address to @foss.st.com

2021-10-27 Thread Joe Perches
On Wed, 2021-10-27 at 15:56 +0200, Patrice CHOTARD wrote: > On 10/27/21 8:11 AM, Patrice CHOTARD wrote: > > On 10/20/21 1:39 PM, Marc Zyngier wrote: > > > On Wed, 20 Oct 2021 08:45:02 +0100, > > > Krzysztof Kozlowski wrote: > > > > On 20/10/2021 08:50, patrice.chot...@foss.st.com wrote: > > > > >

Re: [PATCH 2/4] amdgpu_ucode: reduce number of pr_debug calls

2021-09-29 Thread Joe Perches
On Wed, 2021-09-29 at 19:44 -0600, Jim Cromie wrote: > There are blocks of DRM_DEBUG calls, consolidate their args into > single calls. With dynamic-debug in use, each callsite consumes 56 > bytes of callsite data, and this patch removes about 65 calls, so > it saves ~3.5kb. > > no functional cha

Re: [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

2022-01-20 Thread Joe Perches
On Wed, 2022-01-19 at 16:00 -0500, Steven Rostedt wrote: > On Wed, 19 Jan 2022 21:25:08 +0200 > Andy Shevchenko wrote: > > > > I say keep it one line! > > > > > > Reviewed-by: Steven Rostedt (Google) > > > > I believe Sakari strongly follows the 80 rule, which means... > > Checkpatch says "

Re: [PATCH v1 4/4] fbtft: Replace 'depends on FB_TFT' by 'if FB_TFT ... endif'

2022-01-26 Thread Joe Perches
On Tue, 2022-01-25 at 22:21 +0200, Andy Shevchenko wrote: > Replace 'depends on FB_TFT' by 'if FB_TFT ... endif' > for the sake of deduplication. [] > diff --git a/drivers/video/fbtft/Kconfig b/drivers/video/fbtft/Kconfig [] > @@ -10,87 +10,75 @@ menuconfig FB_TFT > select FB_DEFERRED_IO >

Re: [PATCH 2/2] MAINTAINERS: Mark VMware mailing list entries as private

2021-11-08 Thread Joe Perches
On Mon, 2021-11-08 at 12:30 -0800, Srivatsa S. Bhat wrote: > From: Srivatsa S. Bhat (VMware) > > VMware mailing lists in the MAINTAINERS file are private lists meant > for VMware-internal review/notification for patches to the respective > subsystems. So, in an earlier discussion [1][2], it was r

Re: [PATCH 2/2] MAINTAINERS: Mark VMware mailing list entries as private

2021-11-08 Thread Joe Perches
On Mon, 2021-11-08 at 16:16 -0800, Jakub Kicinski wrote: > On Mon, 08 Nov 2021 15:37:53 -0800 Joe Perches wrote: > > > @@ -6134,8 +6134,8 @@ T: git git://anongit.freedesktop.org/drm/drm-misc > > > F: drivers/gpu/drm/vboxvideo/ > > > > > > DRM

Re: [PATCH 2/2] MAINTAINERS: Mark VMware mailing list entries as private

2021-11-08 Thread Joe Perches
On Mon, 2021-11-08 at 16:22 -0800, Srivatsa S. Bhat wrote: > +Greg, Thomas > > Hi Joe, > > On 11/8/21 3:37 PM, Joe Perches wrote: > > On Mon, 2021-11-08 at 12:30 -0800, Srivatsa S. Bhat wrote: > > > From: Srivatsa S. Bhat (VMware) > > > > > >

Re: [PATCH 2/2] MAINTAINERS: Mark VMware mailing list entries as private

2021-11-09 Thread Joe Perches
On Tue, 2021-11-09 at 00:58 +, Nadav Amit wrote: > > On Nov 8, 2021, at 4:37 PM, Joe Perches wrote: > > On Mon, 2021-11-08 at 16:22 -0800, Srivatsa S. Bhat wrote: > > > > So it's an exploder not an actual maintainer and it likely isn't > > publically

Re: [PATCH v3 3/3] MAINTAINERS: Mark VMware mailing list entries as email aliases

2021-11-10 Thread Joe Perches
On Wed, 2021-11-10 at 17:39 -0800, Jakub Kicinski wrote: > On Wed, 10 Nov 2021 12:09:06 -0800 Srivatsa S. Bhat wrote: > > DRM DRIVER FOR VMWARE VIRTUAL GPU > > -M: "VMware Graphics" > > M: Zack Rusin > > +R: VMware Graphics Reviewers > > L: dri-devel@lists.freedesktop.org > > S: Supported >

Re: [PATCH] drm/amd/amdgpu: remove useless break after return

2021-11-14 Thread Joe Perches
On Sun, 2021-11-14 at 23:14 -0800, Bernard Zhao wrote: > This change is to remove useless break after return. [] > diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c > b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c [] > @@ -2092,22 +2092,18 @@ static int dce_v8_0_pick_dig_encoder(struct > drm_encoder *e

Re: [PATCH v4 3/3] MAINTAINERS: Mark VMware mailing list entries as email aliases

2021-11-16 Thread Joe Perches
.com". > > Signed-off-by: Srivatsa S. Bhat (VMware) Acked-by: Joe Perches > diff --git a/MAINTAINERS b/MAINTAINERS [] > @@ -6223,8 +6223,8 @@ T: git git://anongit.freedesktop.org/drm/drm-misc > F: drivers/gpu/drm/vboxvideo/ > > DRM DRIVER FOR VMWARE VI

Re: [PATCH v2] drm/tilcdc: add const to of_device_id

2021-12-16 Thread Joe Perches
On Thu, 2021-12-16 at 17:26 +0800, Xiang wangx wrote: > struct of_device_id should normally be const. [] > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c > b/drivers/gpu/drm/tilcdc/tilcdc_drv.c [] > @@ -60,7 +60,7 @@ void tilcdc_module_cleanup(struct tilcdc_module *mod) > list_del(&mod->li

[PATCH v12 1/2] kernel.h: add u64_to_user_ptr()

2016-04-26 Thread Joe Perches
On Tue, 2016-04-26 at 11:29 -0300, Gustavo Padovan wrote: > 2016-04-26 Lucas Stach : > > Am Donnerstag, den 21.04.2016, 12:38 -0300 schrieb Gustavo Padovan: > > > From: Gustavo Padovan > > > > > > This function had copies in 3 different files. Unify them in ke

[PATCH 6/7] drm: Add ratelimited versions of the DRM_DEBUG* macros

2016-08-06 Thread Joe Perches
On Fri, 2016-08-05 at 20:30 -0400, Lyude wrote: > There's a couple of places where this would be useful for drivers (such > as reporting DP aux transaction timeouts). Maybe a single static _rs or one for each type would be better than an individual _rs per callsite.

[PATCH 1/1] drm/amdgpu/gmc7: remove dead code

2016-08-21 Thread Joe Perches
On Sun, 2016-08-21 at 20:06 +0200, Heinrich Schuchardt wrote: > In an if block for (running == 0) running cannot be non-zero. This code could also be better unindented by one level (all of the block would fit 80 columns) by changing: if (running == 0) { [code...]

[PATCH] drm/gma500: dont expose bytes from kernel stack

2016-08-21 Thread Joe Perches
On Sun, 2016-08-21 at 20:39 +0200, Heinrich Schuchardt wrote: > Components m1, m2, p2, dot, vco of variable clock should be > initialized to avoid bytes from the kernel stack to be > exposed. How was this found? visual code inspection? And isn't this true for mrst_lvds_find_best_pll as well? >

[PATCH 1/1] drm/amdgpu/gmc7: remove dead code

2016-08-21 Thread Joe Perches
On Sun, 2016-08-21 at 20:45 +0200, Heinrich Schuchardt wrote: > On 08/21/2016 08:29 PM, Joe Perches wrote: > > On Sun, 2016-08-21 at 20:06 +0200, Heinrich Schuchardt wrote: > > > In an if block for (running == 0) running cannot be non-zero. > > This code could also be

[PATCH] drm/gma500: dont expose bytes from kernel stack

2016-08-21 Thread Joe Perches
On Sun, 2016-08-21 at 21:35 +0200, Heinrich Schuchardt wrote: > On 08/21/2016 08:46 PM, Joe Perches wrote: > > On Sun, 2016-08-21 at 20:39 +0200, Heinrich Schuchardt wrote: > > > Components m1, m2, p2, dot, vco of variable clock should be > > > initialized to avoid byt

[PATCH 1/1] drm/radeon: avoid NULL dereference, si_get_vce_clock_voltage

2016-08-21 Thread Joe Perches
On Sun, 2016-08-21 at 22:52 +0200, Heinrich Schuchardt wrote: > It does not make sense to check if table is NULL > and afterwards to dereference it without > considering the result. This makes no sense. > The inconsistency was indicated by cppcheck. Perhaps this is a defect in cppcheck? > An ac

[PATCH 1/1] drm/radeon: avoid NULL dereference, si_get_vce_clock_voltage

2016-08-21 Thread Joe Perches
On Sun, 2016-08-21 at 23:20 +0200, Heinrich Schuchardt wrote: > On 08/21/2016 11:06 PM, Joe Perches wrote: > > On Sun, 2016-08-21 at 22:52 +0200, Heinrich Schuchardt wrote: > > > > > > It does not make sense to check if table is NULL > > > and

Re: [PATCHv6 1/4] drm/omap: use DRM_DEBUG_DRIVER instead of CORE

2019-05-23 Thread Joe Perches
On Thu, 2019-05-23 at 22:07 +0200, Sebastian Reichel wrote: > This macro is only used by omapdrm, which should print > debug messages using the DRIVER category instead of the > default CORE category. [] > diff --git a/drivers/gpu/drm/omapdrm/omap_drv.h > b/drivers/gpu/drm/omapdrm/omap_drv.h [] > @

Re: [PATCH v1 0/19] drm/panel: drmP.h removal and DRM_DEV*

2019-02-01 Thread Joe Perches
On Fri, 2019-02-01 at 14:37 +0100, Sam Ravnborg wrote: > Hi Thierry. > > > I'm slightly on the fence about this patch. > > Please ignore patch 3-19, there is no consensus on the logging changes. > We do not want to apply these and then have to redo parts/all of > it later. > > But the first two

[PATCH] drm/msm: Add __printf verification

2019-01-17 Thread Joe Perches
Add a few __printf attribute specifiers to routines that could use them. Signed-off-by: Joe Perches --- drivers/gpu/drm/msm/msm_drv.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h index 9f51be5a637c..927e5d86f7c1 100644

Re: [PATCH] video/hdmi: Change strncpy() into memcpy() in hdmi_spd_infoframe_init

2019-01-18 Thread Joe Perches
On Fri, 2019-01-18 at 20:32 +0100, Mathieu Malaterre wrote: > Using strncpy() is less than perfect since the destination buffers do not > need to be NUL terminated. Replace strncpy() with memcpy() to address a > warning triggered by gcc using W=1 and optimize the code a bit. > > This commit remove

Re: [PATCH] video: fbdev: vesafb: fix indentation issue

2019-02-15 Thread Joe Perches
On Tue, 2019-02-12 at 13:29 +, Colin King wrote: > From: Colin Ian King > > There are a couple of statements that are indented too deeply, fix > this by removing tabs. Also add a space after a comma to clean up > a cppcheck warning. > > Signed-off-by: Colin Ian King > --- > drivers/video/f

Re: [PATCH v3 0/7] Hexdump Enhancements

2019-06-19 Thread Joe Perches
On Mon, 2019-06-17 at 12:04 +1000, Alastair D'Silva wrote: > From: Alastair D'Silva > > Apologies for the large CC list, it's a heads up for those responsible > for subsystems where a prototype change in generic code causes a change > in those subsystems. > > This series enhances hexdump. Still

Re: [PATCH v3 0/7] Hexdump Enhancements

2019-06-19 Thread Joe Perches
On Thu, 2019-06-20 at 09:15 +1000, Alastair D'Silva wrote: > On Wed, 2019-06-19 at 09:31 -0700, Joe Perches wrote: > > On Mon, 2019-06-17 at 12:04 +1000, Alastair D'Silva wrote: > > > From: Alastair D'Silva > > > > > > Apologies for the large C

Re: [PATCH v3 0/7] Hexdump Enhancements

2019-06-19 Thread Joe Perches
On Thu, 2019-06-20 at 11:14 +1000, Alastair D'Silva wrote: > On Wed, 2019-06-19 at 17:35 -0700, Joe Perches wrote: > > On Thu, 2019-06-20 at 09:15 +1000, Alastair D'Silva wrote: > > > On Wed, 2019-06-19 at 09:31 -0700, Joe Perches wrote: > > > > On Mon, 201

Re: [PATCH v4 0/7] Hexdump Enhancements

2019-06-24 Thread Joe Perches
On Tue, 2019-06-25 at 13:17 +1000, Alastair D'Silva wrote: > From: Alastair D'Silva > > Apologies for the large CC list, it's a heads up for those responsible > for subsystems where a prototype change in generic code causes a change > in those subsystems. [] > The default behaviour of hexdump is

Re: [PATCH v4 4/7] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

2019-06-24 Thread Joe Perches
On Tue, 2019-06-25 at 13:17 +1000, Alastair D'Silva wrote: > From: Alastair D'Silva > > In order to support additional features, rename hex_dump_to_buffer to > hex_dump_to_buffer_ext, and replace the ascii bool parameter with flags. [] > diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c > b/dr

Re: [PATCH v4 4/7] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

2019-06-24 Thread Joe Perches
On Tue, 2019-06-25 at 15:06 +1000, Alastair D'Silva wrote: > On Mon, 2019-06-24 at 22:01 -0700, Joe Perches wrote: > > On Tue, 2019-06-25 at 13:17 +1000, Alastair D'Silva wrote: > > > From: Alastair D'Silva > > > > > > In order to support addi

Re: [PATCH v4 4/7] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

2019-06-24 Thread Joe Perches
On Tue, 2019-06-25 at 15:06 +1000, Alastair D'Silva wrote: > The change actions Jani's suggestion: > https://lkml.org/lkml/2019/6/20/343 I suggest not changing any of the existing uses of hex_dump_to_buffer and only use hex_dump_to_buffer_ext when necessary for your extended use cases.

Re: [PATCH v4 5/7] lib/hexdump.c: Allow multiple groups to be separated by lines '|'

2019-06-24 Thread Joe Perches
On Tue, 2019-06-25 at 13:17 +1000, Alastair D'Silva wrote: > From: Alastair D'Silva > > With the wider display format, it can become hard to identify how many > bytes into the line you are looking at. > > The patch adds new flags to hex_dump_to_buffer() and print_hex_dump() to > print vertical l

Re: [PATCH] video: fbdev: s3c-fb: Mark expected switch fall-throughs

2019-06-25 Thread Joe Perches
On Tue, 2019-06-25 at 11:01 -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. [] > This patch is part of the ongoing efforts to enable > -Wimplicit-fallthrough. Just enable the thing already. If you s

Re: [PATCH] video: fbdev: s3c-fb: Mark expected switch fall-throughs

2019-06-25 Thread Joe Perches
On Tue, 2019-06-25 at 12:06 -0500, Gustavo A. R. Silva wrote: > > On 6/25/19 11:52 AM, Joe Perches wrote: > > On Tue, 2019-06-25 at 11:01 -0500, Gustavo A. R. Silva wrote: > > > In preparation to enabling -Wimplicit-fallthrough, mark switch > > > cases where we

Re: [PATCH] video: fbdev: s3c-fb: Mark expected switch fall-throughs

2019-06-25 Thread Joe Perches
On Tue, 2019-06-25 at 10:31 -0700, Kees Cook wrote: > On Tue, Jun 25, 2019 at 09:52:23AM -0700, Joe Perches wrote: > > On Tue, 2019-06-25 at 11:01 -0500, Gustavo A. R. Silva wrote: > > > In preparation to enabling -Wimplicit-fallthrough, mark switch > > > cases whe

Re: [PATCH V2] include: linux: Regularise the use of FIELD_SIZEOF macro

2019-06-29 Thread Joe Perches
On Sat, 2019-06-29 at 17:25 +0300, Alexey Dobriyan wrote: > On Tue, Jun 11, 2019 at 03:00:10PM -0600, Andreas Dilger wrote: > > On Jun 11, 2019, at 2:48 PM, Andrew Morton > > wrote: > > > On Wed, 12 Jun 2019 01:08:36 +0530 Shyam Saini > > > wrote: > > I did a check, and FIELD_SIZEOF() is used a

Re: mmotm 2019-07-04-15-01 uploaded (gpu/drm/i915/oa/)

2019-07-04 Thread Joe Perches
On Thu, 2019-07-04 at 22:09 -0700, Andrew Morton wrote: > diff(1) doesn't seem to know how to handle a zero-length file. > > y:/home/akpm> mkdir foo > y:/home/akpm> cd foo > y:/home/akpm/foo> touch x > y:/home/akpm/foo> diff -uN x y > y:/home/akpm/foo> date > x > y:/home/akpm/foo> diff -uN x y > -

[PATCH 03/12] drm: aspeed_gfx: Fix misuse of GENMASK macro

2019-07-09 Thread Joe Perches
Arguments are supposed to be ordered high then low. Signed-off-by: Joe Perches --- drivers/gpu/drm/aspeed/aspeed_gfx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx.h b/drivers/gpu/drm/aspeed/aspeed_gfx.h index a10358bb61ec..095ea03e5833

[PATCH 00/12] treewide: Fix GENMASK misuses

2019-07-09 Thread Joe Perches
These GENMASK uses are inverted argument order and the actual masks produced are incorrect. Fix them. Add checkpatch tests to help avoid more misuses too. Joe Perches (12): checkpatch: Add GENMASK tests clocksource/drivers/npcm: Fix misuse of GENMASK macro drm: aspeed_gfx: Fix misuse of

Re: [PATCH] drm/amd/display: Fix boolean expression in get_surf_rq_param

2019-03-21 Thread Joe Perches
On Thu, 2019-03-21 at 22:10 -0500, Gustavo A. R. Silva wrote: > Hi Harry, > > I noticed this patch is already in mainline, but the stable tag > was removed. What is the reason for that if this bug is present > in stable? It's not a bug, it's just a style issue and the && use in some compilers it

Re: [PATCH v5 0/3] drm/panel: Support Rocktech jh057n00900 DSI panel

2019-04-03 Thread Joe Perches
On Wed, 2019-04-03 at 18:17 +0200, Thierry Reding wrote: > On Mon, Apr 01, 2019 at 12:35:32PM +0200, Guido Günther wrote: > > v4 fixes up the DT binding example and uses a wider cc list since I > > failed to extend that when touching more files. [] > Applied, thanks. > > checkpatch does complain a

Re: [PATCH v5 0/3] drm/panel: Support Rocktech jh057n00900 DSI panel

2019-04-03 Thread Joe Perches
On Wed, 2019-04-03 at 10:11 -0700, Joe Perches wrote: > On Wed, 2019-04-03 at 18:17 +0200, Thierry Reding wrote: > > On Mon, Apr 01, 2019 at 12:35:32PM +0200, Guido Günther wrote: > > > v4 fixes up the DT binding example and uses a wider cc list since I > > > failed t

Re: [PATCH v5 0/3] drm/panel: Support Rocktech jh057n00900 DSI panel

2019-04-03 Thread Joe Perches
On Wed, 2019-04-03 at 23:07 +0200, Sam Ravnborg wrote: > Hi Joe. > > Thanks for your patch. > > > --- > > drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c | 210 > > + > > 1 file changed, 136 insertions(+), 74 deletions(-) > > Hmmm, add more lines than it deletes. Yeah,

[PATCH] drm/panel: Rocktech jh057n00900: Add terminating newlines to logging

2019-04-04 Thread Joe Perches
These were missing '\n' terminations, add them. Signed-off-by: Joe Perches --- drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c b/drivers/gpu

Re: [PATCH] drm/panel: Rocktech jh057n00900: Add terminating newlines to logging

2019-04-04 Thread Joe Perches
On Thu, 2019-04-04 at 17:48 +0200, Guido Günther wrote: > Hi Joe, [] > P.S.: The cc: list is huge, is there a reason for going way past what > get_maintainers puts out for this patch? No idea, I just used reply-all to your patch. ___ dri-devel mailing

Re: [PATCH] drm/panel: Rocktech jh057n00900: Add terminating newlines to logging

2019-04-04 Thread Joe Perches
On Thu, 2019-04-04 at 19:00 +0200, Sam Ravnborg wrote: > Hi Joe. > > On Thu, Apr 04, 2019 at 08:06:09AM -0700, Joe Perches wrote: > > These were missing '\n' terminations, add them. > > > > Signed-off-by: Joe Perches > > --- > > driver

Re: [PATCH 00/12] treewide: Fix GENMASK misuses

2019-07-10 Thread Joe Perches
On Wed, 2019-07-10 at 10:43 +0100, Russell King - ARM Linux admin wrote: > On Wed, Jul 10, 2019 at 11:17:31AM +0200, Johannes Berg wrote: > > On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: > > > These GENMASK uses are inverted argument order and the > > > actual m

Re: [PATCH 00/12] treewide: Fix GENMASK misuses

2019-07-10 Thread Joe Perches
On Wed, 2019-07-10 at 08:45 -0700, Joe Perches wrote: > On Wed, 2019-07-10 at 10:43 +0100, Russell King - ARM Linux admin wrote: > > On Wed, Jul 10, 2019 at 11:17:31AM +0200, Johannes Berg wrote: > > > On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: > > > > T

Re: [PATCH 03/12] drm: aspeed_gfx: Fix misuse of GENMASK macro

2019-07-24 Thread Joe Perches
On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: > Arguments are supposed to be ordered high then low. > > Signed-off-by: Joe Perches > --- > drivers/gpu/drm/aspeed/aspeed_gfx.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu

Re: [PATCH 03/12] drm: aspeed_gfx: Fix misuse of GENMASK macro

2019-07-24 Thread Joe Perches
On Thu, 2019-07-25 at 10:40 +0930, Andrew Jeffery wrote: > > On Thu, 25 Jul 2019, at 02:46, Joe Perches wrote: > > On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: > > > Arguments are supposed to be ordered high then low. > > > > > > Signed-off-by: Jo

Re: [PATCH 03/12] drm: aspeed_gfx: Fix misuse of GENMASK macro

2019-07-25 Thread Joe Perches
On Thu, 2019-07-25 at 02:52 +, Joel Stanley wrote: > On Thu, 25 Jul 2019 at 01:18, Joe Perches wrote: > > On Thu, 2019-07-25 at 10:40 +0930, Andrew Jeffery wrote: > > > On Thu, 25 Jul 2019, at 02:46, Joe Perches wrote: > > > > On Tue, 2019-07-09 at

  1   2   3   4   5   >