now be changed to depend on
> CONFIG_PM.
>
> Replace CONFIG_PM_RUNTIME with CONFIG_PM in 4 files under
> gpu/drm/exynos/.
>
> Signed-off-by: Rafael J. Wysocki
Reviewed-by: Jingoo Han
Best regards,
Jingoo Han
> ---
>
> Note: This depends on commit b2b49ccbdd54
Use devm_ioremap_resource() because devm_request_and_ioremap() is
obsoleted by devm_ioremap_resource().
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/armada/armada_crtc.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/armada/armada_crtc.c
b/drivers
On Monday, April 07, 2014 7:53 PM, Thierry Reding wrote:
> On Thu, Apr 03, 2014 at 09:31:04AM +0900, Jingoo Han wrote:
> > Use devm_ioremap_resource() because devm_request_and_ioremap() is
> > obsoleted by devm_ioremap_resource().
> >
> > Signed-off-by: Jingoo Han
&
Use devm_ioremap_resource() because devm_request_and_ioremap() is
obsoleted by devm_ioremap_resource().
Signed-off-by: Jingoo Han
---
Changes since v1:
- remove unnecessary error message, because devm_ioremap_resource()
already prints one in all failure cases.
drivers/gpu/drm/armada
Recently, Exynos DP driver was moved from drivers/video/exynos/
directory to drivers/gpu/drm/exynos/ directory. So, I update
and add maintainer entry for Exynos DP driver.
Signed-off-by: Jingoo Han
---
MAINTAINERS |6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b
This patches fix Exynos DRM for minor cleanup. This series is based
on exynos-drm-next-todo branch of Inki Dae's tree. [1]
[1] git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git
Jingoo Han (6):
drm/exynos: dpi: make local symbol static
drm/exynos: fb: make
Make local symbol static, because this is used only in this file.
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/exynos/exynos_drm_dpi.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c
b/drivers/gpu/drm/exynos/exynos_drm_dpi.c
index
Make local symbole static, because this is used only in this file.
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/exynos/exynos_drm_fbdev.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
b/drivers/gpu/drm/exynos
Make local symbols static, because these are used only in this
file.
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/exynos/exynos_hdmi.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm/exynos/exynos_hdmi.c
index
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/exynos/exynos_dp_core.c |8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/exynos
devm_ioremap_resource() retunrs an error pointer, not NULL. Thus,
the result should be checked with IS_ERR().
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
In the case of that only one branch of a conditional statement is
a single statement, braces are added to both branches.
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/exynos/exynos_drm_rotator.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos
eg & PLUG)
+ return DP_IRQ_TYPE_HP_CABLE_IN;
+
+ if (reg & HPD_LOST)
+ return DP_IRQ_TYPE_HP_CABLE_OUT;
+
+ if (reg & HOTPLUG_CHG)
+ return DP_IRQ_TYPE_HP_CHANGE;
+ }
return DP_IRQ_T
enable_delay = true;
> + }
> +
> + if (!IS_ERR_OR_NULL(dp_panel->lcd_fet)) {
> + regulator_disable(dp_panel->lcd_fet);
> + enable_delay = true;
> + }
> +
> + if (enable_delay)
> + msleep(dp_panel->pow
p;exynos_dp_panel_driver);
> +err_unregister_dp_panel:
> +#endif
Please add platform_driver_unregister() to exynos_drm_platform_remove(),
as well as exynos_drm_platform_probe().
Best regards,
Jingoo Han
> +
> #ifdef CONFIG_DRM_EXYNOS_IPP
> exynos_platform_device_ipp_unregister();
> err_
"samsung,exynos-dp-panel");
> + if (panel_node) {
> + dp->drm_panel = of_drm_find_panel(panel_node);
> + if (!dp->drm_panel) {
> + of_node_put(panel_node);
> + return -ENODEV;
&g
;
> - if (ret)
> + ret = exynos_drm_attach_lcd_bridge(dp->drm_dev, encoder, dp->drm_panel);
> + if (ret) {
> + /* Also set "dp->drm_panel = NULL" so that we don't end up
> + * controlling panel power both in exynos_dp and bridge
&g
On Saturday, April 19, 2014 4:51 AM, Ajay Kumar wrote:
> On Fri, Apr 18, 2014 at 2:27 PM, Jingoo Han wrote:
> > On Wednesday, April 16, 2014 11:33 PM, Ajay Kumar wrote:
[.]
> > > +#ifdef CONFIG_DRM_PANEL_EXYNOS_DP
> > > + platform_driver_unregis
On Saturday, April 19, 2014 4:43 AM, Ajay kumar wrote:
> On Fri, Apr 18, 2014 at 2:17 PM, Jingoo Han wrote:
> > On Wednesday, April 16, 2014 11:33 PM, Ajay Kumar wrote:
[.]
> > > +struct panel_exynos_dp {
> > > + struct drm_panelbase;
> > > +
Use %pad for dma_addr_t, because a dma_addr_t type can vary
based on build options. So, it prevents possible build warnings
in printks.
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/exynos/exynos_drm_dmabuf.c |2 +-
drivers/gpu/drm/exynos/exynos_drm_vidi.c |2 +-
2 files changed, 2
ed-off-by: Rahul Sharma
> Signed-off-by: Ajay Kumar
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> Changes since V1:
> Address reiew comments from Jingoo Han
>
> .../devicetree/bindings/video/exynos_dp.txt|4 ++
> drivers/gpu/drm/exynos/exynos_d
ig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -30,4 +30,13 @@ config DRM_PANEL_S6E8AA0
> select DRM_MIPI_DSI
> select VIDEOMODE_HELPERS
>
> +config DRM_PANEL_EXYNOS_DP
> + tristate "support for DP panels"
It looks very general. Please fix it as be
sn't matter if the regulators are turned off, but something
> + * else might keep them on. In that case, we want to assert the slp gpio
> + * to lower power.
> + */
> + if (gpio_is_valid(ps_bridge->gpio_slp_n))
> + gpio_set_value(ps_bridge->gpio_slp_n, 0);
> +
> + drm_panel_post_disable(ps_bridge->panel);
> + if (ps_bridge->v12)
> + regulator_disable(ps_bridge->v12);
> +
> + /*
> + * Sleep for at least the amount of time that it takes the power rail to
> + * fall to prevent asserting the rst gpio from doing anything.
> + */
> + usleep_range(PS8622_POWER_FALL_T16_MAX_US,
> + 2 * PS8622_POWER_FALL_T16_MAX_US);
> + if (gpio_is_valid(ps_bridge->gpio_rst_n))
> + gpio_set_value(ps_bridge->gpio_rst_n, 0);
> +
> + msleep(PS8622_POWER_OFF_T17_MS);
> +
> +out:
> + mutex_unlock(&ps_bridge->enable_mutex);
> +}
> +
> +static void ps8622_post_disable(struct drm_bridge *bridge)
> +{
> +}
How about just removing this empty function?
[.]
Best regards,
Jingoo Han
The usage of strict_strtol() is not preferred, because
strict_strtol() is obsolete. Thus, kstrtol() should be
used.
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/nouveau/nouveau_hwmon.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau
FB, and which to DRM.
>
> Signed-off-by: Tomi Valkeinen
Reviewed-by: Jingoo Han
I tested this patch. Menu becomes clearer!
Thanks.
Best regards,
Jingoo Han
> ---
> drivers/video/Kconfig | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/video/Kco
; the files are actually part of the fbdev framework, and which are part
> of device drivers.
>
> Signed-off-by: Tomi Valkeinen
Hi Tomi,
This is what I wanted for a long time!
Thank you for your effort!
Last year, I noticed that the current FB directory and files
are not clear. It looks goo
vm->dmt_flags & VESA_DMT_HSYNC_HIGH)
> + fbmode->sync |= FB_SYNC_HOR_HIGH_ACT;
> + if (vm->dmt_flags & VESA_DMT_HSYNC_HIGH)
Hi Steffen Trumtrar,
Um, it seems to be a type. 'H'SYNC -> 'V'SYNC
Thus, it would be changed as below:
vm->dmt_flags & VESA_DMT_HSYNC_HIGH)
> + fbmode->sync |= FB_SYNC_HOR_HIGH_ACT;
> + if (vm->dmt_flags & VESA_DMT_HSYNC_HIGH)
Hi Steffen Trumtrar,
Um, it seems to be a type. 'H'SYNC -> 'V'SYNC
Thus, it would be changed as below:
Use PCI_EXP_LNKCAP_SLS_2_5GB and PCI_EXP_LNKCAP_SLS_5_0GB instead
of hardcoded values for readability. These bit definitions were
added by commit 130f1b8 ("PCI: Add PCIe Link Capability link speed
and width names")
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/drm_pci.c |4 ++-
On Thursday, February 07, 2013 2:08 AM, Bjorn Helgaas wrote
>
> On Wed, Feb 6, 2013 at 7:27 AM, Alex Deucher wrote:
> > On Wed, Feb 6, 2013 at 12:18 AM, Jingoo Han wrote:
> >> Use PCI_EXP_LNKCAP_SLS_2_5GB and PCI_EXP_LNKCAP_SLS_5_0GB instead
> >> of hardcoded val
VESA_DMT_VSYNC_HIGH should be used instead of VESA_DMT_HSYNC_HIGH,
because FB_SYNC_VERT_HIGH_ACT is related to vsync, not to hsync.
Signed-off-by: Jingoo Han
Cc: Steffen Trumtrar
---
drivers/video/fbmon.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video
On Tuesday, January 21, 2014 3:58 PM, Dan Carpenter wrote:
>
> If exynos_drm_subdrv_open() fails then we re-use "file_priv".
>
> Fixes: 96f5421523df ('drm/exynos: use a new anon file for exynos gem mmaper')
> Signed-off-by: Dan Carpenter
Reviewed-by:
On Wednesday, January 22, 2014 2:04 PM, Liu Ying wrote:
>
> Ping...
>
> Regards,
> Liu Ying
Please, don't send the ping within 2 days.
It is not a good practice. You sent the v1 patch 6 months ago.
However, why I should review the patch within 2 days?
Please wait.
Best
says on the box, so for that (and for that alone) you can
> have my
>
> Reviewed-by: Jani Nikula
>
> *BUT* it would be laborous to figure out whether this change in
> behaviour might regress some drivers. I'm just punting on that. And that
> brings us back to the three changes above - in a bisect POV it might be
> helpful to split the patch up. Up to the maintainers.
I agree with Jani Nikula's opinion.
Please split this patch into three patches as above mentioned.
Best regards,
Jingoo Han
On Thursday, January 23, 2014 6:28 PM, Liu Ying wrote:
> On 01/23/2014 01:44 PM, Jingoo Han wrote:
> > On Wednesday, January 22, 2014 6:36 PM, Jani Nikula wrote:
> >> On Mon, 20 Jan 2014, Liu Ying wrote:
> >>> We don't have to turn backlight on/off everytime a
I have no objection against this patch. However, I will wait
for other people's opinions. Then, if there is no objection,
I will ask Andrew Morton to merge this patch into mm-tree.
Thanks.
Best regards,
Jingoo Han
>
> v3->v4:
> * Split v3 into 2 patches to separate the change fo
On Mon, May 21, 2012 at 04:25 PM +, Corentin Chary wrote:
>
> In all these files, the .power field was never correctly initialized.
>
> Signed-off-by: Corentin Chary
It looks good.
Best regards,
Jingoo Han
> ---
> drivers/gpu/drm/i915/intel_panel.c |
Fixed build warning as below:
arch/arm/mm/cache-l2x0.c:37:12: warning: 'l2_wt_override' defined but not used
[-Wunused-variable]
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/drm_pci.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/d
On Wednesday, November 07, 2012 2:37 PM Jingoo Han wrote
>
> Fixed build warning as below:
>
> arch/arm/mm/cache-l2x0.c:37:12: warning: 'l2_wt_override' defined but not
> used [-Wunused-variable]
Sorry, this error message is wrong.
I made a mistake.
I will fix the
may be used uninitialized
in this function [-Wuninitialized]
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/drm_pci.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/drm_pci.c b/drivers/gpu/drm/drm_pci.c
index ba33144..754bc96 100644
--- a/drivers/gpu/d
e tree
> bindings of DRM world. So I'd not like to merge this driver yet.
's3c-fb' driver is still used for other mass products projects.
Just, device tree support patch is not yet submitted.
Sean Paul,
When moving the driver, notify related Maintainers of that driver.
Please use
On Friday, November 01, 2013 8:12 AM, Tomasz Figa wrote:
> On Friday 01 of November 2013 08:06:00 Jingoo Han wrote:
> > On Thursday, October 31, 2013 7:47 PM, Inki Dae wrote:
> > > CCing Jingoo,
> > >
> > > Is that ok to remove eDP driver from video/exynos? Is
On Friday, November 01, 2013 8:27 AM, Tomasz Figa wrote:
> On Friday 01 of November 2013 08:23:59 Jingoo Han wrote:
> > On Friday, November 01, 2013 8:12 AM, Tomasz Figa wrote:
> > > On Friday 01 of November 2013 08:06:00 Jingoo Han wrote:
> > > > On Thursday, Octo
sted-by: Javier Martinez Canillas
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> Changes in v11: None
> Changes in v10: None
> Changes in v9: None
> Changes in v8: None
> Changes in v7: None
> Changes in v6: None
> Changes in v5:
> - Resequence this patch after an
gix/analogix_dp_core.h
> @@ -21,8 +21,9 @@
> #define MAX_EQ_LOOP 5
>
> enum link_rate_type {
> - LINK_RATE_1_62GBPS = 0x06,
> - LINK_RATE_2_70GBPS = 0x0a
> + LINK_RATE_1_62GBPS = DP_LINK_BW_1_62,
> + LINK_RATE_2_70GBPS = DP_LINK_BW_2_7,
> + LINK_RATE_5_40GBPS = DP_LINK_BW_5_4,
Then, how about removing 'enum link_rate_type'?
If DP_LINK_BW_* are used, LINK_RATE_* are not necessary.
Best regards,
Jingoo Han
> };
>
> enum link_lane_count_type {
> --
> 1.9.1
Javier Martinez Canillas
Reviewed-by: Jingoo Han < jingoohan1 at gmail.com >
Best regards,
Jingoo Han
> ---
> Changes in v11: None
> Changes in v10: None
> Changes in v9: None
> Changes in v8: None
> Changes in v7: None
> Changes in v6:
> - Fix Peach Pit hpd pr
.3cb3bf8
> --- /dev/null
> +++ b/drivers/phy/phy-rockchip-dp.c
> @@ -0,0 +1,151 @@
> +/*
> + * Rockchip DP PHY driver
> + *
> + * Copyright (C) 2015 FuZhou Rockchip Co., Ltd.
> + * Author: Yakir Yang
> + *
> + * This program is free software; you can redistribute it and/or
; timeout_loop++;
> - if (DP_TIMEOUT_LOOP_COUNT < timeout_loop) {
> + if (DP_TIMEOUT_LOOP_COUNT * 10 < timeout_loop) {
No, I hate this coding.
analogix_dp_reg.c is the common code that can be shared by various SoCs.
Please
= New DT;
else
wait_time_aux = 10;
> usleep_range(10, 11);
If there is NO new wait time value from DT file, the default value '10' is
used for sleep.
But, if there is new wait time value from DT file, new wait time value
can be used for sleep.
usleep_range(dp->wait_time_aux, dp->wait_time_aux + 1);
What I want to say is that there should be NO effect on Exynos platform,
because of the hardware bug of Rockchip platform.
Best regards,
Jingoo Han
> }
>
> --
> 1.9.1
On Wednesday, December 23, 2015 3:01 PM, Yakir Yang wrote:
>
> Hi Jingoo,
>
> On 12/23/2015 12:24 PM, Yakir Yang wrote:
> > Hi Jingoo,
> >
> > On 12/22/2015 08:26 PM, Jingoo Han wrote:
> >> On Wednesday, December 16, 2015 12:58 PM, Yakir Yang wrote:
&g
On Thursday, December 24, 2015 10:23 AM, Yakir Yang wrote:
>
> Hi Jingoo,
>
> Okay, fine, I would drop this patch, until I found the the root cause.
OK, I see.
Best regards,
Jingoo Han
>
> - Yakir
>
> On 12/23/2015 11:10 PM, Jingoo Han wrote:
> > On Wednes
Hi Steffen,
You can add my tested-by for this series.
I have tested them for Exynos: smdk4210 board.
Beat regards,
Jingoo Han
On Wednesday, January 23, 2013 6:12 PM, Steffen Trumtrar wrote
> On Tue, Jan 22, 2013 at 03:50:48PM -0600, Rob Clark wrote:
> > On Mon, Jan 21, 2013 at 5:07 AM
The usage of strict_strtol() is not preferred, because
strict_strtol() is obsolete. Thus, kstrtol() should be
used.
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/nouveau/nouveau_pm.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_pm.c
ave to review the code carefully, as others did.
I also cannot find the exact IP name. The "analogix" may be the vendor name
of this IP.
Best regards,
Jingoo Han
>
> Beyond that, there are three light registers setting differents bewteen
> exynos and rk3288.
> 1. RK3288 ha
ynos_dp_core.c
> b/drivers/gpu/drm/exynos/exynos_dp_core.c
> index a8097a4..aa99e23 100644
> --- a/drivers/gpu/drm/exynos/exynos_dp_core.c
> +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
> @@ -3,6 +3,7 @@
> *
> * Copyright (C) 2012 Samsung Electronics Co., Ltd.
> * Author:
vers/gpu/drm/bridge/analogix_dp_core.c
> @@ -1,7 +1,8 @@
> /*
> - * Samsung SoC DP (Display Port) interface driver.
> + * Analogix Core DP (Display Port) interface driver.
> *
> * Copyright (C) 2012 Samsung Electronics Co., Ltd.
> + * Copyright (C) FuZhou Rockchip Electron
nt exynos_dp_probe(struct platform_device
> > *pdev)
> > exynos_drm_component_del(&pdev->dev,
> >
> > EXYNOS_DEVICE_TYPE_CONNECTOR);
> >
> > +free_dp:
> > + devm_kfree(dev, dp
101 - 157 of 157 matches
Mail list logo
