iver,
> - TI LP8727 charger driver,
> - TI LP8788 MFD (ADC, LEDs, charger and regulator) drivers.
>
> Signed-off-by: Krzysztof Kozlowski
> Cc: Dan Murphy
> Acked-by: Dan Murphy
> Acked-by: Jonathan Cameron
> Acked-by: Sebastian Reichel
Ack
g: Excess function parameter 'trans'
> description in 's3c_fb_setcolreg'
> drivers/video/fbdev/s3c-fb.c:1142: warning: Function parameter or member
> 'sfb' not described in 's3c_fb_release_win'
> drivers/video/fbdev/s3c-fb.c:1172: warning: Funct
On 1/13/21, 9:50 AM, Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/video/fbdev/s3c-fb.c: In function ‘s3c_fb_probe_win’:
> drivers/video/fbdev/s3c-fb.c:1176:28: warning: variable ‘var’ set but not
> used [-Wunused-but-set-variable]
>
>
On 6/14/19, 11:46 PM, Bartlomiej Zolnierkiewicz wrote:
>
> Add COMPILE_TEST support to s3c-fb driver for better compile
> testing coverage.
>
> Cc: Jingoo Han
Acked-by: Jingoo Han
> Signed-off-by: Bartlomiej Zolnierkiewicz
> ---
> drivers/video/fbdev/Kconfig |3
On 6/14/19, 11:47 PM, Bartlomiej Zolnierkiewicz wrote:
>
> Fix error code from -ENOENT to -ENOMEM.
>
> Cc: Jingoo Han
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> Signed-off-by: Bartlomiej Zolnierkiewicz
> ---
> drivers/video/fbdev/s3c-fb.c |2 +-
> 1 file ch
On 6/27/19, 9:58 PM, Bartlomiej Zolnierkiewicz wrote:
>
> Use ->screen_buffer instead of ->screen_base to fix sparse warnings.
>
> [ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate screen_base
> pointer") for details. ]
>
> Reported-by: kbuild te
> privacy screens. :(
> >
> > I guess... although the Thinkpad code hasn't added any standard
> > interfaces (no other laptop should be placing controls for a privacy
> > screen in /proc/acpi/ibm/... ). Maybe its not too late.
>
> There's new interfa
On 9/4/19, 7:57 AM, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot
> Signed-off-by: YueHaibing
>
Acked-by: Jingoo Han
>
> ---
> drivers/video/fbdev/s3c-fb.c |
ewed-by: Emil Velikov
> Cc: Lee Jones
> Cc: Daniel Thompson
> Cc: Jingoo Han
It looks good!
Reviewed-by: Jingoo Han
For the rebase, if you don't know which branch of maintainer's git can be used,
linux-next tree [1] is useful. The linux-next git collects all next branches
pson
> Cc: Jingoo Han
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> Reviewed-by: Sam Ravnborg
> Reviewed-by: Daniel Thompson
> Acked-by: Lee Jones
> Signed-off-by: Noralf Trønnes
> ---
> drivers/video/backlight/backlight.c | 21 +
> include/lin
> Don't pollute the dmesg with EDID read success message as an error.
> Printing as debug should be fine.
>
> Signed-off-by: Krzysztof Kozlowski
Right, dev_err() is not right.
Thank you for sending the patch.
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
>
According to the header comment in the source file, the driver is
licensed under GPL v2, so update MODULE_LICENSE() to match that.
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/exynos/exynos_dp_core.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos
On Sunday, June 15, 2014 9:11 AM, Martin Kepplinger wrote:
>
> Fix a sparse warning: ttm_bo_reserve()'s last argument is a
> pointer to a struct, so use NULL as nullpointer.
>
> Signed-off-by: Martin Kepplinger
Reviewed-by: Jingoo Han
Best regards,
Jingoo Han
> ---
hpd_irq_event() is called, which in turns calls
> exynos_dpi_detect(), which dereferences ctx->panel without a check,
> causing a NULL pointer derefrence.
>
> This patch fixes the issue by adding necessary NULL pointer check.
>
> Signed-off-by: Tomasz Figa
(+cc Inki Dae)
l.org/lkml/2014/6/11/26
[2] https://lkml.org/lkml/2014/6/11/649
Best regards,
Jingoo Han
>
>Wolfram
>
>
> Tushar Behera (2):
> DRM: Armada: Use devm_ioremap_resource
> lib: devres: Remove deprecated devm_request_and_ioremap
>
> Wolfram Sang
xynos5 should be fine.
No, it should be selectable. Even some exynos5 based boards use MIPI LCD.
>
> Arndale and Arndale-Octa have MIPI/DSI interface with MIPI/LVDS bridge.
>
> >
> > Inki/Andrej - Shall I add it as an optional DT property?
>
> No, property is redundant.
1 patch.
Reviewed-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> Changes since V1:
> - Remove usage of driver_data to configure DP CLKCON register
> drivers/gpu/drm/exynos/exynos_dp_core.c | 2 ++
> drivers/gpu/drm/exynos/exynos_drm_drv.h | 8
> drivers/gpu/drm/exynos
On Thursday, May 22, 2014 1:59 PM, Sachin Kamat wrote:
>
> Silences the following warning:
> WARNING: space prohibited before semicolon
>
> Signed-off-by: Sachin Kamat
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> drivers/gpu/drm/exynos/exynos_dp_reg.c |2
ank you.
Reviewed-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> include/drm/drm_dp_helper.h | 78
> +
> 1 file changed, 78 insertions(+)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index c
ntainers
> > directly on both postings.
> >
> > What may be helpful for them is to hear from you if you're ok with the
> > acpi-video bits which are actually going to use this, since those will
> > be the only user of the new backlight api (for now).
>
> I'
Use devm_ioremap_resource() because devm_request_and_ioremap() is
obsoleted by devm_ioremap_resource().
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/armada/armada_crtc.c |8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/armada/armada_crtc.c
b
On Thursday, May 29, 2014 2:56 PM, Sachin Kamat wrote:
>
> PTR_ERR_OR_ZERO simplifies the code.
>
> Signed-off-by: Sachin Kamat
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> drivers/gpu/drm/exynos/exynos_dp_core.c |5 +
> 1 file changed, 1 inse
#x27;drivers/gpu/drm/exynos/exynos_hdmi.h' was not
removed yet. Thus, additional patch to remove this
'exynos_hdmi.h' should be submitted. Thank you.
[1]
http://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/commit/?h=exynos-drm-next&id=73c0a75ca9919c
The exynos_hdmi.h has been used for the dedicated i2c drivers
that were already removed. Thus, the unnecessary exynos_hdmi.h
should be removed.
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/exynos/exynos_hdmi.h | 23 ---
1 file changed, 23 deletions(-)
delete mode 100644
placed long time ago.
However, it was not removed for DT compatibility.
I think that now these old DT properties can be removed.
I added some comments below.
>
> Signed-off-by: Vivek Gautam
> Cc: Inki Dae
> Cc: Jingoo Han
> ---
>
> Changes from V1:
> - Reworked error
On Thursday, October 30, 2014 10:24 PM, Vivek Gautam wrote:
>
> DP PHY now require pmu-system-controller to handle PMU register
> to control PHY's power isolation. Adding the same to dp-phy
> node.
>
> Signed-off-by: Vivek Gautam
> Cc: Jingoo Han
Reviewed-by: Jingoo
vek Gautam
> Cc: Inki Dae
> Cc: Jingoo Han
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
>
> Changes from V2:
> - Moved devm_phy_get() call out of exynos_dp_dt_parse_phydata() to
>exynos_dp_bind() function and,
>removed exynos_dp_dt_parse_phydata(
>> point to get panel node.
>> - Add the new function point analogix_dp_platdata.get_modes init.
>> - Take Heiko suggest, add rockchip dp phy driver,
>> collect the phy clocks and power control.
>> - Add "analogix,need-force-hpd" to indicate whether driver need f
On 2015. 8. 20., at PM 3:23, Yakir Yang wrote:
>
> Hi Jingoo & Archit,
>
>
>> On 08/20/2015 12:54 AM, Jingoo Han wrote:
>>> On 2015. 8. 20., at PM 1:29, Archit Taneja
>>> wrote:
>>> Hi,
>>>
>>>> On 08/19/2015 08:18 P
guration of link rate and link
count
Best regards,
Jingoo Han
> so we don't need to config those repeatly after training finished, just
> remove them out.
>
> Beside Display Port 1.2 already support 5.4Gbps link rate, the maximum sets
> would change from {1.62Gbps, 2.7
o say is that there should not be harmful effect on the existing
Exynos boards, due to unrelated reasons.
Best regards,
Jingoo Han
> Signed-off-by: Yakir Yang
> ---
> Changes in v3: None
> Changes in v2: None
>
> drivers/gpu/drm/bridge/analogix_dp_core.c | 2 +-
> 1 file cha
On 2015. 8. 19., at PM 11:52, Yakir Yang wrote:
>
What is the reason to make this patch?
Please make commit message including the reason.
Best regards,
Jingoo Han
> Signed-off-by: Yakir Yang
> ---
> Changes in v3:
> - move dp hpd detect to connector detect function.
>
On 2015. 8. 21., at PM 7:01, Yakir Yang wrote:
>
> Hi Jingoo,
>
>> å¨ 2015/8/21 16:20, Jingoo Han åé:
>>> On 2015. 8. 19., at PM 11:48, Yakir Yang wrote:
>>
>> .
>>
>>> .../bindings/video/analogix_dp-rockchip.txt| 83
kefile|2 +-
> drivers/gpu/drm/exynos/analogix_dp-exynos.c| 347 +
Would you change this file name to "exynos_dp.c"?
Best regards,
Jingoo Han
> drivers/gpu/drm/exynos/exynos_dp_core.c| 1416
> drivers/
e maintainers to CC list. I don't understand
why you removed them from CC list.
Kukjin Kim
Krzysztof Kozlowski
Without their Ack, you will not change the codes of ARM Exynos Architecture.
Best regards,
Jingoo Han
>
> Best regards,
> Krzysztof
>
>
>>
>>
>
nk rate and
link count
drm: bridge: analogix/dp: dynamic parse sync_pol & interlace & dynamic_range
ARM: dts: exynos/dp: remove some properties that deprecated by analogix_dp
driver
drm: bridge: analogix/dp: add max link rate and lane count limit for RK3288
drm: brid
the new drm atomic modeset api simplified even the uapi to a
> simple bool. And there was never a valid technical reason to have the
> intermediate fbdev power states for backlights (those really only can
> be either off or on).
>
> Cleanup motivated by Meghana's questions abou
; aligned. And total activity in the backlight subsystem is miniscule
> compared to drm overall.
>
> Cc: Lee Jones
> Cc: Daniel Thompson
> Cc: Jingoo Han
> Acked-by: Daniel Thompson
> Acked-by: Jingoo Han
> Signed-off-by: Daniel Vetter
Acked-by: Jingoo Han
Best regards,
owski
> Cc: Marek Szyprowski
> Cc: Inki Dae
> Signed-off-by: Krzysztof Kozlowski
> ---
> drivers/video/backlight/Kconfig | 8 -
> drivers/video/backlight/Makefile| 1 -
> drivers/video/backlight/s6e63m0.c | 857
--------
> ----
Acked
> -Original Message-
> From: Krzysztof Kozlowski
> Sent: Monday, April 30, 2018 1:30 PM
> To: Lee Jones ; Daniel Thompson
> ; Jingoo Han ;
> Bartlomiej Zolnierkiewicz ; linux-
> ker...@vger.kernel.org; dri-devel@lists.freedesktop.org; linux-
> fb...@vger.ke
person who have
an experience to send patches to Linux mailing-list.
Best regards,
Jingoo Han
>
> pm8941-wled.c driver is supporting the WLED peripheral
> on pm8941. Rename it to qcom-wled.c so that it can support
> WLED on multiple PMICs.
>
> Signed-off-by: Kiran Gunda
> ---
Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro
is not preferred.
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/ast/ast_drv.c |2 +-
drivers/gpu/drm/cirrus/cirrus_drv.c|2 +-
drivers/gpu/drm/gma500/oaktrail_hdmi.c |2 +-
drivers/gpu/drm/gma500/psb_
gt; Cc: Douglas Anderson
> Signed-off-by: zain wang
> Signed-off-by: Sean Paul
> Signed-off-by: Thierry Escande
> Reviewed-by: Andrzej Hajda
> Signed-off-by: Enric Balletbo i Serra
> Tested-by: Marek Szyprowski
> Reviewed-by: Archit Taneja
Acked-by: Jingoo Han
Best regard
> Signed-off-by: Sean Paul
> Signed-off-by: Thierry Escande
> Reviewed-by: Andrzej Hajda
> Signed-off-by: Enric Balletbo i Serra
> Tested-by: Marek Szyprowski
> Reviewed-by: Archit Taneja
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
>
> .../gpu/drm/br
zain wang
> Signed-off-by: Douglas Anderson
> Signed-off-by: Sean Paul
> Signed-off-by: Thierry Escande
> Reviewed-by: Andrzej Hajda
> Signed-off-by: Enric Balletbo i Serra
> Tested-by: Marek Szyprowski
> Reviewed-by: Archit Taneja
Acked-by: Jingoo Han
Best regards,
off-by: zain wang
> Signed-off-by: Sean Paul
> Signed-off-by: Thierry Escande
> Reviewed-by: Andrzej Hajda
> Signed-off-by: Enric Balletbo i Serra
> Tested-by: Marek Szyprowski
> Reviewed-by: Archit Taneja
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
&g
g
> Signed-off-by: Douglas Anderson
> Signed-off-by: Sean Paul
> Signed-off-by: Thierry Escande
> Signed-off-by: Enric Balletbo i Serra
> Tested-by: Marek Szyprowski
> Reviewed-by: Heiko Stuebner
> Reviewed-by: Archit Taneja
Acked-by: Jingoo Han
Best regards,
Signed-off-by: Thierry Escande
> Reviewed-by: Andrzej Hajda
> Signed-off-by: Enric Balletbo i Serra
> Tested-by: Marek Szyprowski
> Reviewed-by: Archit Taneja
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
>
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 7 +++
ting their users at the same
> time to avoid breaking the compilation.
>
> Signed-off-by: Tomasz Figa
> Signed-off-by: Jeffy Chen
> Reviewed-by: Andrzej Hajda
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
>
> Changes in v3: None
> Changes in v2: N
ting their users at the same
> time to avoid breaking the compilation.
>
> Signed-off-by: Tomasz Figa
> Signed-off-by: Jeffy Chen
> Reviewed-by: Andrzej Hajda
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
>
> Changes in v4: None
> Changes in v3:
'len'
> is never read
>
> Signed-off-by: Colin Ian King
Acked-by: Jingoo Han
Thank you for sending the patch.
It looks good.
Best regards,
Jingoo Han
> ---
> drivers/video/backlight/ili922x.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> dif
On Wednesday, February 14, 2018 7:01 AM wrote:
>
> Exynos5, Exynos4 and S5PV210 platforms have been converted to
> use Device Tree and Exynos DRM driver long time ago. Remove
> dead platform code for these platforms and update Kconfig
> s3c-fb entry accordingly.
>
> Cc:
just makes sense to cross-post patches and keep
> > aligned. And total activity in the backlight subsystem is miniscule
> > compared to drm overall.
> >
> > Cc: Lee Jones
> > Cc: Daniel Thompson
> > Cc: Jingoo Han
> > Signed-off-by: Daniel Vetter
> Signed-off-by: Markus Elfring
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> drivers/video/fbdev/s3c-fb.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
> index 5f4f696c2e
ponding size
> determination a bit safer according to the Linux coding style convention.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> drivers/video/fbdev/s3c-fb.c | 2
may be used uninitialized
in this function [-Wuninitialized]
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/drm_pci.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/drm_pci.c b/drivers/gpu/drm/drm_pci.c
index ba33144..754bc96 100644
--- a/drivers/gpu/d
may be used uninitialized
in this function [-Wuninitialized]
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/drm_pci.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/drm_pci.c b/drivers/gpu/drm/drm_pci.c
index ba33144..754bc96 100644
--- a/drivers/gpu/d
Hi Steffen,
You can add my tested-by for this series.
I have tested them for Exynos: smdk4210 board.
Beat regards,
Jingoo Han
On Wednesday, January 23, 2013 6:12 PM, Steffen Trumtrar wrote
> On Tue, Jan 22, 2013 at 03:50:48PM -0600, Rob Clark wrote:
> > On Mon, Jan 21, 2013 at 5:07 AM
vm->dmt_flags & VESA_DMT_HSYNC_HIGH)
> + fbmode->sync |= FB_SYNC_HOR_HIGH_ACT;
> + if (vm->dmt_flags & VESA_DMT_HSYNC_HIGH)
Hi Steffen Trumtrar,
Um, it seems to be a type. 'H'SYNC -> 'V'SYNC
Thus, it would be changed as below:
vm->dmt_flags & VESA_DMT_HSYNC_HIGH)
> + fbmode->sync |= FB_SYNC_HOR_HIGH_ACT;
> + if (vm->dmt_flags & VESA_DMT_HSYNC_HIGH)
Hi Steffen Trumtrar,
Um, it seems to be a type. 'H'SYNC -> 'V'SYNC
Thus, it would be changed as below:
c registers
that handle extra operations. In this case, custom panel driver for this eDP
panel
will be necessary.
In my opinion, the panel framework would be helpful to solve this problem.
Best regards,
Jingoo Han
> I've brought up the issue with Tomi Valkeinen (OMAP DSS maintainer
Fixed build warning as below:
arch/arm/mm/cache-l2x0.c:37:12: warning: 'l2_wt_override' defined but not used
[-Wunused-variable]
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/drm_pci.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/d
On Wednesday, November 07, 2012 2:37 PM Jingoo Han wrote
>
> Fixed build warning as below:
>
> arch/arm/mm/cache-l2x0.c:37:12: warning: 'l2_wt_override' defined but not
> used [-Wunused-variable]
Sorry, this error message is wrong.
I made a mistake.
I will fix the
may be used uninitialized
in this function [-Wuninitialized]
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/drm_pci.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/drm_pci.c b/drivers/gpu/drm/drm_pci.c
index ba33144..754bc96 100644
--- a/drivers/gpu/d
On Mon, May 21, 2012 at 04:25 PM +, Corentin Chary wrote:
>
> In all these files, the .power field was never correctly initialized.
>
> Signed-off-by: Corentin Chary
It looks good.
Best regards,
Jingoo Han
> ---
> drivers/gpu/drm/i915/intel_panel.c |
On Monday, July 30, 2012 5:45 PM, Leela Krishna Amudala wrote:
>
> Moved the contents of regs-fb-v4.h and regs-fb.h from arch side
> to include/video/samsung_fimd.h
>
> Signed-off-by: Leela Krishna Amudala
> ---
> arch/arm/plat-samsung/include/plat/regs-fb-v4.h | 159 ---
> arch/arm/plat-s
On Monday, July 30, 2012 8:16 PM, Leela Krishna Amudala wrote:
>
> Hello Jingoo Han,
>
> On Mon, Jul 30, 2012 at 2:23 PM, Jingoo Han wrote:
> > On Monday, July 30, 2012 5:45 PM, Leela Krishna Amudala wrote:
> >>
> >> Moved the contents of regs-fb-v4.h
On Tuesday, July 31, 2012 3:37 PM, Tomasz Figa wrote:
>
> Hi,
>
> On Tuesday 31 of July 2012 at 09:47:57, Jingoo Han wrote:
> > On Monday, July 30, 2012 8:16 PM, Leela Krishna Amudala wrote:
> > > Hello Jingoo Han,
> > >
> > > On Mon, Jul 30, 2
On Tuesday, July 31, 2012 3:28 PM Marek Szyprowski wrote:
>
> Hello,
>
> On Tuesday, July 31, 2012 2:48 AM Jingoo Han wrote:
>
> > On Monday, July 30, 2012 8:16 PM, Leela Krishna Amudala wrote:
> > >
> > > Hello Jingoo Han,
> > >
> >
b/drivers/video/s3c-fb.c
> index 69bf9d0..1226fdd 100644
> --- a/drivers/video/s3c-fb.c
> +++ b/drivers/video/s3c-fb.c
> @@ -26,7 +26,7 @@
> #include
>
> #include
> -#include
> +#include
> #include
Please move header include to proper place as bellows:
#
rch/arm/mach-exynos/mach-nuri.c
> @@ -39,7 +39,7 @@
> #include
>
> #include
> -#include
> +#include
> #include
> #include
> #include
Please move header include to proper place as bellows, including other
machine files such as origen, smdk, and so on.
#include
#in
ollowing seems to be better.
/* EXYNOS5 specific register offset definitions */
Best regards,
Jingoo Han
> +#define EXYNOS5_VIDTCON0 (0x20010)
> +#define EXYNOS5_VIDTCON1 (0x20014)
> +#define EXYNOS5_VIDTCON2 (0x20018)
> +#define EXYNOS
Use PCI_EXP_LNKCAP_SLS_2_5GB and PCI_EXP_LNKCAP_SLS_5_0GB instead
of hardcoded values for readability. These bit definitions were
added by commit 130f1b8 ("PCI: Add PCIe Link Capability link speed
and width names")
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/drm_pci.c |4 ++-
On Thursday, February 07, 2013 2:08 AM, Bjorn Helgaas wrote
>
> On Wed, Feb 6, 2013 at 7:27 AM, Alex Deucher wrote:
> > On Wed, Feb 6, 2013 at 12:18 AM, Jingoo Han wrote:
> >> Use PCI_EXP_LNKCAP_SLS_2_5GB and PCI_EXP_LNKCAP_SLS_5_0GB instead
> >> of hardcoded val
VESA_DMT_VSYNC_HIGH should be used instead of VESA_DMT_HSYNC_HIGH,
because FB_SYNC_VERT_HIGH_ACT is related to vsync, not to hsync.
Signed-off-by: Jingoo Han
Cc: Steffen Trumtrar
---
drivers/video/fbmon.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video
The usage of strict_strtol() is not preferred, because
strict_strtol() is obsolete. Thus, kstrtol() should be
used.
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/nouveau/nouveau_pm.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_pm.c
c registers
that handle extra operations. In this case, custom panel driver for this eDP
panel
will be necessary.
In my opinion, the panel framework would be helpful to solve this problem.
Best regards,
Jingoo Han
> I've brought up the issue with Tomi Valkeinen (OMAP DSS maintainer
t;;
display-timings {
status of fimd node was disabled by exynos5.dtsi
./arch/arm/boot/dts/exynos5.dtsi
fimd@1440 {
status = "disabled";
Best regards,
Jingoo Han
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
How about adding 'status = "okay" as below?
pinctrl-names = "default";
pinctrl-0 = <&dp_hpd>;
status = "okay";
status of dp node was disabled by exynos5.dtsi.
./arch/arm/boot/dts/exynos5.dtsi
dp-controller@14
On Friday, June 27, 2014 7:12 PM, Ajay Kumar wrote:
>
> Add the missing setting for DP CLKCON register.
>
> This register is present on Exynos5 based FIMD controllers,
> and needs to be set if we are using DP.
>
> Signed-off-by: Ajay Kumar
Reviewed-by: Jingoo Han
Bes
pdate can be performed after VIDCON0 update. If yes the
> > solution of the whole problem
> I will check this.
>
> > seems to be simple:
> > - fimd should provide function fimd_set_dp_clk_gate or sth similar,
> > - this function should be called in exynos_dp_poweron/exynos_dp_poweroff.
> > I hope I have not missed anything this time.
> But, it won't look good to export a FIMD function which sets a FIMD register,
> and call it in DP driver!
> What does Inki/Jingoo have to say about this?
I agree with Ajay Kumar's opinion.
It doesn't look good to export the function to set FIMD register
and call it by DP driver.
Best regards,
Jingoo Han
>
> Regards,
> Ajay
>
[]
Use DPCD defines of drm_dp_helper.h; thus, duplicated DPCD defines
of exynos_dp_core.h can be removed. Also, DP_TEST_EDID_CHECKSUM
define is added to drm_dp_helper.h. There is no functional change.
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/exynos/exynos_dp_core.c | 98
drm_crtc.h is already included by exynos_dp_core.h.
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/exynos/exynos_dp_core.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c
b/drivers/gpu/drm/exynos/exynos_dp_core.c
index 92cfbb3..3c15e89 100644
--- a
On Wednesday, May 07, 2014 8:46 PM, Jingoo Han wrote:
>
> drm_crtc.h is already included by exynos_dp_core.h.
Please ignore this patch.
I think that it looks good to include this header directly,
even though exynos_dp_core.h includes this header.
It is not sure that drm_crtc.h header inc
On Tuesday, April 22, 2014 4:14 PM, Jingoo Han wrote:
> On Tuesday, April 22, 2014 7:39 AM, Ajay Kumar wrote:
> >
> > From: Andrew Bresticker
> >
> > Certain bridge chips use a GPIO to indicate the cable status instead
> > of the I_DP_HPD pin. This adds
en 'DP MST' and '1.2 MST'?
If there is no difference, would you use the same comment
as below?
+# define DP_DOWN_REP_MSG_RDY (1 << 4) /* 1.2 MST */
+# define DP_UP_REQ_MSG_RDY (1 << 5) /* 1.2 MST */
Best regards,
Jingoo Han
[.]
Within few releases, it can be changed
and removed. Actually, marking it as deprecated looks more urgent.
Thanks.
Best regards,
Jingoo Han
>
> Thierry
On Monday, July 30, 2012 5:45 PM, Leela Krishna Amudala wrote:
>
> Moved the contents of regs-fb-v4.h and regs-fb.h from arch side
> to include/video/samsung_fimd.h
>
> Signed-off-by: Leela Krishna Amudala
> ---
> arch/arm/plat-samsung/include/plat/regs-fb-v4.h | 159 ---
> arch/arm/plat-s
On Monday, July 30, 2012 8:16 PM, Leela Krishna Amudala wrote:
>
> Hello Jingoo Han,
>
> On Mon, Jul 30, 2012 at 2:23 PM, Jingoo Han wrote:
> > On Monday, July 30, 2012 5:45 PM, Leela Krishna Amudala wrote:
> >>
> >> Moved the contents of regs-fb-v4.h
On Tuesday, July 31, 2012 3:37 PM, Tomasz Figa wrote:
>
> Hi,
>
> On Tuesday 31 of July 2012 at 09:47:57, Jingoo Han wrote:
> > On Monday, July 30, 2012 8:16 PM, Leela Krishna Amudala wrote:
> > > Hello Jingoo Han,
> > >
> > > On Mon, Jul
On Tuesday, July 31, 2012 3:28 PM Marek Szyprowski wrote:
>
> Hello,
>
> On Tuesday, July 31, 2012 2:48 AM Jingoo Han wrote:
>
> > On Monday, July 30, 2012 8:16 PM, Leela Krishna Amudala wrote:
> > >
> > > Hello Jingoo Han,
> > >
> > >
b/drivers/video/s3c-fb.c
> index 69bf9d0..1226fdd 100644
> --- a/drivers/video/s3c-fb.c
> +++ b/drivers/video/s3c-fb.c
> @@ -26,7 +26,7 @@
> #include
>
> #include
> -#include
> +#include
> #include
Please move header include to proper place as bellows:
#
rch/arm/mach-exynos/mach-nuri.c
> @@ -39,7 +39,7 @@
> #include
>
> #include
> -#include
> +#include
> #include
> #include
> #include
Please move header include to proper place as bellows, including other
machine files such as origen, smdk, and so on.
#include
#in
ollowing seems to be better.
/* EXYNOS5 specific register offset definitions */
Best regards,
Jingoo Han
> +#define EXYNOS5_VIDTCON0 (0x20010)
> +#define EXYNOS5_VIDTCON1 (0x20014)
> +#define EXYNOS5_VIDTCON2 (0x20018)
> +#define EXYNOS5_VIDTCON3 (0x2001C)
> +#define EXYNOS5_VIDCON1 (0x20004)
> --
> 1.7.0.4
you said at '[PATCH 0/6] Rename DP
training vswing/pre-emph defines'.
Best regards.
Jingoo Han
>
> Signed-off-by: Sonika Jindal
> ---
> include/drm/drm_dp_helper.h | 16
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git
function-declaration]
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/sti/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/sti/Kconfig b/drivers/gpu/drm/sti/Kconfig
index 2d9d4252d598..bc7d9347ac89 100644
--- a/drivers/gpu/drm/sti/Kconfig
+++ b/drivers/gpu/drm/sti/Kconfig
@@
gt; > macros for each value seems isn't either.
> >
> I feel _LEVEL_* makes it more readable and since there are only 4 values
> possible, it is ok to have 4 different macros for readability purpose.
> What do you think?
(+cc Damien Lespiau)
P
s a rule when submitting patches.
Please, fix it as follows.
+ buf[lane] = DP_TRAIN_PRE_EMPHASIS_LEVEL_0|
+ DP_TRAIN_VOLTAGE_SWING_LEVEL_0;
Best regards,
Jingoo Han
>
> retval = exynos_dp_write_bytes_to_dpcd(dp, DP_TRAINING_LANE0_SET,
> lane_count, buf);
> --
> 1.7.10.4
On Thursday, August 28, 2014 1:33 PM, Sonika Sonika wrote:
> On 8/28/2014 6:25 AM, Jingoo Han wrote:
> > On Friday, August 08, 2014 7:54 PM, Sonika Jindal wrote:
> >>
> >> From: Sonika Jindal
> >>
> >> Rename the defines to have levels instead of valu
ding the same to dp-phy
> > node.
> >
> > Signed-off-by: Vivek Gautam
> > Reviewed-by: Jingoo Han
> > Tested-by: Javier Martinez Canillas
> > Cc: Kukjin Kim
>
> Any opinions about $subject?
>
> This patch is -rc material since is needed after commi
1 - 100 of 157 matches
Mail list logo
