t;;
brightness-levels = <0 243 245 247 248 249 251 252 255>;
default-brightness-level = <8>;
};
};
Signed-off-by: Jean-Jacques Hiblot
---
drivers/leds/led-class.c | 16
include/linux/leds.h | 11 +++
2 files changed, 2
Update the led binding to describe the possibility to add a "compatible"
option to create a child-device, user of the LED.
Signed-off-by: Jean-Jacques Hiblot
Cc: devicet...@vger.kernel.org
---
Documentation/devicetree/bindings/leds/common.txt | 3 +++
1 file changed, 3 insertions(+)
From: Tomi Valkeinen
This patch adds a led-backlight driver (led_bl), which is mostly similar to
pwm_bl except the driver uses a LED class driver to adjust the brightness
in the HW.
Signed-off-by: Tomi Valkeinen
Signed-off-by: Jean-Jacques Hiblot
---
drivers/video/backlight/Kconfig | 7
From: Tomi Valkeinen
Add DT binding for led-backlight.
Signed-off-by: Tomi Valkeinen
Signed-off-by: Jean-Jacques Hiblot
Cc: devicet...@vger.kernel.org
---
.../video/backlight/led-backlight.txt | 39 +++
1 file changed, 39 insertions(+)
create mode 100644
a child of the LED controller instead of
being another platform device that uses a phandle to reference a LED.
Jean-Jacques Hiblot (2):
leds: of: create a child device if the LED node contains a
"compatible" string
devicetree: Update led binding
Tomi Valkeinen (2):
backligh
Hi Daniel,
On 02/07/2019 11:54, Daniel Thompson wrote:
On Mon, Jul 01, 2019 at 05:14:22PM +0200, Jean-Jacques Hiblot wrote:
From: Tomi Valkeinen
This patch adds a led-backlight driver (led_bl), which is mostly similar to
pwm_bl except the driver uses a LED class driver to adjust the
Daniel,
On 02/07/2019 15:04, Daniel Thompson wrote:
On Tue, Jul 02, 2019 at 12:59:53PM +0200, Jean-Jacques Hiblot wrote:
Hi Daniel,
On 02/07/2019 11:54, Daniel Thompson wrote:
On Mon, Jul 01, 2019 at 05:14:22PM +0200, Jean-Jacques Hiblot wrote:
From: Tomi Valkeinen
This patch adds a led
Daniel,
On 02/07/2019 11:58, Daniel Thompson wrote:
On Mon, Jul 01, 2019 at 05:14:23PM +0200, Jean-Jacques Hiblot wrote:
From: Tomi Valkeinen
Add DT binding for led-backlight.
I think the patchset is in the wrong order; the DT bindings
documentation should appear *before* the binding is
Daniel,
On 03/07/2019 11:44, Daniel Thompson wrote:
On Tue, Jul 02, 2019 at 05:17:21PM +0200, Jean-Jacques Hiblot wrote:
Daniel,
On 02/07/2019 15:04, Daniel Thompson wrote:
On Tue, Jul 02, 2019 at 12:59:53PM +0200, Jean-Jacques Hiblot wrote:
Hi Daniel,
On 02/07/2019 11:54, Daniel Thompson
This would give us a WARN_ON() if the pin/unpin calls are unbalanced.
Signed-off-by: Jean-Jacques Hiblot
---
drivers/gpu/drm/omapdrm/omap_gem.c | 41 +++---
1 file changed, 20 insertions(+), 21 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c
b/drivers/gpu
space.
It is also the opportunity to do some cleanup in the flags and improve the
comments describing them.
JJ
Jean-Jacques Hiblot (1):
drm/omap: use refcount API to track the number of users of dma_addr
Tomi Valkeinen (7):
drm/omap: add omap_gem_unpin_locked()
drm/omap: accept NULL for
From: Tomi Valkeinen
Reorder OMAP_BO flags and improve the comments.
Signed-off-by: Tomi Valkeinen
---
include/uapi/drm/omap_drm.h | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/uapi/drm/omap_drm.h b/include/uapi/drm/omap_drm.h
index 1fccffef9e27.
From: Tomi Valkeinen
Allow NULL to be passed in 'dma_addr' for omap_gem_pin(), in case the
caller does not need the dma_addr.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/omap_gem.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/o
From: Tomi Valkeinen
OMAP_BO_TILED does not make sense, as OMAP_BO_TILED_* values are not
bitmasks but normal values. As we already have OMAP_BO_TILED_MASK for
the mask, we can remove OMAP_BO_TILED and use OMAP_BO_TILED_MASK
instead.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/om
From: Tomi Valkeinen
Add omap_gem_unpin_locked() which is a version of omap_gem_unpin() that
expects the caller to hold the omap_obj lock.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/omap_gem.c | 25 ++---
1 file changed, 18 insertions(+), 7 deletions(-)
diff
From: Tomi Valkeinen
On SoCs with DMM/TILER, we have two ways to allocate buffers: normal
dma_alloc or via DMM (which basically functions as an IOMMU). DMM can
map 128MB at a time, and we only map the DMM buffers when they are used
(i.e. not at alloc time). If DMM is present, omapdrm always uses
From: Tomi Valkeinen
omap_gem_new() has a comment about OMAP_BO_SCANOUT which does not make
sense. Also, for the TILER case, we drop OMAP_BO_SCANOUT flag for some
reason.
It's not clear what the original purpose of OMAP_BO_SCANOUT is, but
presuming it means "scanout buffer, something that can be
From: Tomi Valkeinen
Add a helper function omap_gem_validate_flags() which validates the
omap_bo flags passed from the userspace.
Also drop the dev_err() message, as the userspace can cause that at
will.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/omap_gem.c | 40 +++
Pavel
On 05/07/2019 12:08, Pavel Machek wrote:
Hi!
Also still relevant is whether the LED device is being correctly
modelled if the act of turning on the LED doesn't, in fact, turn the LED
on. Is it *really* a correct implementation of an LED device that
setting it to LED_FULL using sysfs does
On 05/07/2019 12:14, Pavel Machek wrote:
On Mon 2019-07-01 17:14:19, Jean-Jacques Hiblot wrote:
This series takes it from there and implements the binding that was
discussed in https://patchwork.kernel.org/patch/7293991/. In this new
binding the backlight device is a child of the LED
each LED
- led: improve the way of_get_led() works and add a managed version of it
Jean-Jacques Hiblot (2):
leds: Add managed API to get a LED from a device driver
dt-bindings: backlight: Add led-backlight binding
Tomi Valkeinen (2):
leds: Add of_led_get() and led_put()
backlight: ad
Jean-Jacques Hiblot
---
drivers/leds/led-class.c | 50
include/linux/leds.h | 4
2 files changed, 54 insertions(+)
diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
index e01b2d982564..0f67b13b0f1f 100644
--- a/drivers/leds/led-cl
If the LED is acquired by a consumer device with devm_led_get(), it is
automatically release when the device is detach.
Signed-off-by: Jean-Jacques Hiblot
---
drivers/leds/led-class.c | 42
include/linux/leds.h | 2 ++
2 files changed, 44 insertions
Add DT binding for led-backlight.
Signed-off-by: Jean-Jacques Hiblot
---
.../bindings/leds/backlight/led-backlight.txt | 29 +++
1 file changed, 29 insertions(+)
create mode 100644
Documentation/devicetree/bindings/leds/backlight/led-backlight.txt
diff --git a/Documentation
From: Tomi Valkeinen
This patch adds a led-backlight driver (led_bl), which is similar to
pwm_bl except the driver uses a LED class driver to adjust the
brightness in the HW. Multiple LEDs can be used for a single backlight.
Signed-off-by: Tomi Valkeinen
Signed-off-by: Jean-Jacques Hiblot
This would give us a WARN_ON() if the pin/unpin calls are unbalanced.
Proposed-by: Laurent Pinchart
Signed-off-by: Jean-Jacques Hiblot
---
drivers/gpu/drm/omapdrm/omap_gem.c | 45 +++---
1 file changed, 23 insertions(+), 22 deletions(-)
diff --git a/drivers/gpu/drm
From: Tomi Valkeinen
omap_gem_new() has a comment about OMAP_BO_SCANOUT which does not make
sense. Also, for the TILER case, we drop OMAP_BO_SCANOUT flag for some
reason.
It's not clear what the original purpose of OMAP_BO_SCANOUT is, but
presuming it means "scanout buffer, something that can be
From: Tomi Valkeinen
Allow NULL to be passed in 'dma_addr' for omap_gem_pin(), in case the
caller does not need the dma_addr.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/omap_gem.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/o
be be done when this series have been discussed and hopefully in
the process of getting merged.
JJ
changes in v2:
- fixed build error that crept in during rebase before sending (sorry
about that)
- rework the refcount part a bit.
Jean-Jacques Hiblot (1):
drm/omap: use refcount API to trac
From: Tomi Valkeinen
Add a helper function omap_gem_validate_flags() which validates the
omap_bo flags passed from the userspace.
Also drop the dev_err() message, as the userspace can cause that at
will.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/omap_gem.c | 40 +++
From: Tomi Valkeinen
On SoCs with DMM/TILER, we have two ways to allocate buffers: normal
dma_alloc or via DMM (which basically functions as an IOMMU). DMM can
map 128MB at a time, and we only map the DMM buffers when they are used
(i.e. not at alloc time). If DMM is present, omapdrm always uses
From: Tomi Valkeinen
Reorder OMAP_BO flags and improve the comments.
Signed-off-by: Tomi Valkeinen
---
include/uapi/drm/omap_drm.h | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/uapi/drm/omap_drm.h b/include/uapi/drm/omap_drm.h
index 1fccffef9e27.
From: Tomi Valkeinen
Add omap_gem_unpin_locked() which is a version of omap_gem_unpin() that
expects the caller to hold the omap_obj lock.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/omap_gem.c | 24 +---
1 file changed, 17 insertions(+), 7 deletions(-)
diff
From: Tomi Valkeinen
OMAP_BO_TILED does not make sense, as OMAP_BO_TILED_* values are not
bitmasks but normal values. As we already have OMAP_BO_TILED_MASK for
the mask, we can remove OMAP_BO_TILED and use OMAP_BO_TILED_MASK
instead.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/om
the option to use a GPIO enable.
- removed the option to use a regulator. It should be handled by the LED core
- don't make any change to the LED core (not needed anymore)
Jean-Jacques Hiblot (2):
leds: Add managed API to get a LED from a device driver
dt-bindings: backlight: Add led-ba
Jean-Jacques Hiblot
---
drivers/leds/led-class.c | 50
include/linux/leds.h | 4
2 files changed, 54 insertions(+)
diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
index e01b2d982564..0f67b13b0f1f 100644
--- a/drivers/leds/led-cl
From: Tomi Valkeinen
This patch adds a led-backlight driver (led_bl), which is similar to
pwm_bl except the driver uses a LED class driver to adjust the
brightness in the HW. Multiple LEDs can be used for a single backlight.
Signed-off-by: Tomi Valkeinen
Signed-off-by: Jean-Jacques Hiblot
Add DT binding for led-backlight.
Signed-off-by: Jean-Jacques Hiblot
---
.../bindings/leds/backlight/led-backlight.txt | 28 +++
1 file changed, 28 insertions(+)
create mode 100644
Documentation/devicetree/bindings/leds/backlight/led-backlight.txt
diff --git a/Documentation
If the LED is acquired by a consumer device with devm_led_get(), it is
automatically release when the device is detach.
Signed-off-by: Jean-Jacques Hiblot
---
drivers/leds/led-class.c | 42
include/linux/leds.h | 2 ++
2 files changed, 44 insertions
Add the following properties for planes:
* alpha
* pixel blend mode. Only "Pre-multiplied" and "Coverage" are supported
Signed-off-by: Jean-Jacques Hiblot
---
drivers/gpu/drm/omapdrm/omap_plane.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/dri
hi Pavel
On 10/07/2019 21:09, Pavel Machek wrote:
On Wed 2019-07-10 14:39:29, Jean-Jacques Hiblot wrote:
From: Tomi Valkeinen
This patch adds basic support for a kernel driver to get a LED device.
This will be used by the led-backlight driver.
Only OF version is implemented for now, and the
Pavel,
On 10/07/2019 21:13, Pavel Machek wrote:
On Wed 2019-07-10 14:39:31, Jean-Jacques Hiblot wrote:
Add DT binding for led-backlight.
Signed-off-by: Jean-Jacques Hiblot
---
.../bindings/leds/backlight/led-backlight.txt | 28 +++
1 file changed, 28 insertions(+)
create
#x27;t make any change to the LED core (not needed anymore)
Jean-Jacques Hiblot (2):
leds: Add managed API to get a LED from a device driver
dt-bindings: backlight: Add led-backlight binding
Tomi Valkeinen (2):
leds: Add of_led_get() and led_put()
backlight: add led-backlight driver
.../bi
If the LED is acquired by a consumer device with devm_led_get(), it is
automatically released when the device is detached.
Signed-off-by: Jean-Jacques Hiblot
Acked-by: Pavel Machek
---
drivers/leds/led-class.c | 42
include/linux/leds.h | 2 ++
2
From: Tomi Valkeinen
This patch adds a led-backlight driver (led_bl), which is similar to
pwm_bl except the driver uses a LED class driver to adjust the
brightness in the HW. Multiple LEDs can be used for a single backlight.
Signed-off-by: Tomi Valkeinen
Signed-off-by: Jean-Jacques Hiblot
Add DT binding for led-backlight.
Signed-off-by: Jean-Jacques Hiblot
---
.../bindings/leds/backlight/led-backlight.txt | 28 +++
1 file changed, 28 insertions(+)
create mode 100644
Documentation/devicetree/bindings/leds/backlight/led-backlight.txt
diff --git a/Documentation
Jean-Jacques Hiblot
---
drivers/leds/led-class.c | 50
include/linux/leds.h | 4
2 files changed, 54 insertions(+)
diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
index cadd43c30d50..9f48798a713d 100644
--- a/drivers/leds/led-cl
On 01/08/2019 11:02, Tomi Valkeinen wrote:
Hi JJ,
On 08/07/2019 13:45, Jean-Jacques Hiblot wrote:
A first version of this work had been sent by Tomi Valkeinen in may 2017
(https://www.spinics.net/lists/dri-devel/msg140663.html).
This series adds a few new OMAP_BO flags to help the userspace
On 01/08/2019 11:02, Tomi Valkeinen wrote:
Hi JJ,
On 08/07/2019 13:45, Jean-Jacques Hiblot wrote:
A first version of this work had been sent by Tomi Valkeinen in may 2017
(https://www.spinics.net/lists/dri-devel/msg140663.html).
This series adds a few new OMAP_BO flags to help the userspace
Hiblot wrote:
On 03/10/2019 12:42, Sebastian Reichel wrote:
On Thu, Oct 03, 2019 at 10:28:09AM +0200, Jean-Jacques Hiblot wrote:
This mail has nothing relevant in the subject line and pages of quotes
before the question for me, it's kind of lucky I noticed it
Isn't it all about creat
On 04/10/2019 13:39, Mark Brown wrote:
On Thu, Oct 03, 2019 at 10:27:26PM +0200, Jacek Anaszewski wrote:
On 10/3/19 9:41 PM, Mark Brown wrote:
Why would we want to do that? We'd continue to support only DT systems,
just with code that's less obviously DT only and would need to put
checks in.
On 04/10/2019 16:40, Mark Brown wrote:
On Fri, Oct 04, 2019 at 03:33:13PM +0200, Jean-Jacques Hiblot wrote:
On 04/10/2019 13:39, Mark Brown wrote:
Consumers should just be able to request a regulator without having to
worry about how that's being provided - they should have no knowled
Hi Lee,
On 04/10/2019 16:39, Lee Jones wrote:
On Wed, 18 Sep 2019, Jean-Jacques Hiblot wrote:
From: Tomi Valkeinen
This patch adds a led-backlight driver (led_bl), which is similar to
pwm_bl except the driver uses a LED class driver to adjust the
brightness in the HW. Multiple LEDs can be
On 04/10/2019 17:58, Mark Brown wrote:
On Fri, Oct 04, 2019 at 05:13:13PM +0200, Jean-Jacques Hiblot wrote:
On 04/10/2019 16:40, Mark Brown wrote:
Why is the LED core populating anything? Is the LED core copying bits
out of the struct device for the actual device into a synthetic device
From: Tomi Valkeinen
Allow NULL to be passed in 'dma_addr' for omap_gem_pin(), in case the
caller does not need the dma_addr.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/omap_gem.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/o
From: Tomi Valkeinen
Add a helper function omap_gem_validate_flags() which validates the
omap_bo flags passed from the userspace.
Also drop the dev_err() message, as the userspace can cause that at
will.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/omap_gem.c | 40 +++
From: Tomi Valkeinen
OMAP_BO_TILED does not make sense, as OMAP_BO_TILED_* values are not
bitmasks but normal values. As we already have OMAP_BO_TILED_MASK for
the mask, we can remove OMAP_BO_TILED and use OMAP_BO_TILED_MASK
instead.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/om
From: Tomi Valkeinen
Add omap_gem_unpin_locked() which is a version of omap_gem_unpin() that
expects the caller to hold the omap_obj lock.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/omap_gem.c | 24 +---
1 file changed, 17 insertions(+), 7 deletions(-)
diff
From: Tomi Valkeinen
On SoCs with DMM/TILER, we have two ways to allocate buffers: normal
dma_alloc or via DMM (which basically functions as an IOMMU). DMM can
map 128MB at a time, and we only map the DMM buffers when they are used
(i.e. not at alloc time). If DMM is present, omapdrm always uses
sorry
about that)
- rework the refcount part a bit.
Jean-Jacques Hiblot (1):
drm/omap: use refcount API to track the number of users of dma_addr
Tomi Valkeinen (7):
drm/omap: add omap_gem_unpin_locked()
drm/omap: accept NULL for dma_addr in omap_gem_pin
drm/omap: cleanup OMAP_BO flags
drm
From: Tomi Valkeinen
omap_gem_new() has a comment about OMAP_BO_SCANOUT which does not make
sense. Also, for the TILER case, we drop OMAP_BO_SCANOUT flag for some
reason.
It's not clear what the original purpose of OMAP_BO_SCANOUT is, but
presuming it means "scanout buffer, something that can be
From: Tomi Valkeinen
Reorder OMAP_BO flags and improve the comments.
Signed-off-by: Tomi Valkeinen
---
include/uapi/drm/omap_drm.h | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/uapi/drm/omap_drm.h b/include/uapi/drm/omap_drm.h
index 1fccffef9e27.
This would give us a WARN_ON() if the pin/unpin calls are unbalanced.
Proposed-by: Laurent Pinchart
Signed-off-by: Jean-Jacques Hiblot
Reviewed-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/omap_gem.c | 45 +++---
1 file changed, 23 insertions(+), 22 deletions
Add DT binding for led-backlight.
Signed-off-by: Jean-Jacques Hiblot
Reviewed-by: Daniel Thompson
Reviewed-by: Sebastian Reichel
---
.../bindings/leds/backlight/led-backlight.txt | 28 +++
1 file changed, 28 insertions(+)
create mode 100644
Documentation/devicetree/bindings
From: Tomi Valkeinen
This patch adds a led-backlight driver (led_bl), which is similar to
pwm_bl except the driver uses a LED class driver to adjust the
brightness in the HW. Multiple LEDs can be used for a single backlight.
Signed-off-by: Tomi Valkeinen
Signed-off-by: Jean-Jacques Hiblot
If the LED is acquired by a consumer device with devm_led_get(), it is
automatically released when the device is detached.
Signed-off-by: Jean-Jacques Hiblot
Acked-by: Pavel Machek
---
drivers/leds/led-class.c | 49
include/linux/leds.h | 2 ++
2
Jean-Jacques Hiblot
Acked-by: Pavel Machek
---
drivers/leds/led-class.c | 50
include/linux/leds.h | 4
2 files changed, 54 insertions(+)
diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
index bfa1b1033274..1d1f1d546dc7 100644
nable.
- removed the option to use a regulator. It should be handled by the LED
core
- don't make any change to the LED core (not needed anymore)
Jean-Jacques Hiblot (3):
leds: populate the device's of_node
leds: Add managed API to get a LED from a device driver
dt-bindings: backli
If initialization data is available and its fwnode is actually a of_node,
store this information in the led device's structure. This will allow the
device to use or provide OF-based API such (devm_xxx).
Signed-off-by: Jean-Jacques Hiblot
---
drivers/leds/led-class.c | 4 +++-
1 file chang
Hi Rob,
On 07/10/2019 18:15, Rob Herring wrote:
Please send DT bindings to DT list or it's never in my queue. IOW,
send patches to the lists that get_maintainers.pl tells you to.
On Mon, Oct 7, 2019 at 7:45 AM Jean-Jacques Hiblot wrote:
Add DT binding for led-backlight.
Signed-off-by:
Rob,
On 08/10/2019 14:51, Jean-Jacques Hiblot wrote:
Hi Rob,
On 07/10/2019 18:15, Rob Herring wrote:
Please send DT bindings to DT list or it's never in my queue. IOW,
send patches to the lists that get_maintainers.pl tells you to.
On Mon, Oct 7, 2019 at 7:45 AM Jean-Jacques Hiblot
On 07/10/2019 13:25, Jean-Jacques Hiblot wrote:
From: Tomi Valkeinen
Add omap_gem_unpin_locked() which is a version of omap_gem_unpin() that
expects the caller to hold the omap_obj lock.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/omap_gem.c | 24 +---
1
On 07/10/2019 13:25, Jean-Jacques Hiblot wrote:
From: Tomi Valkeinen
Allow NULL to be passed in 'dma_addr' for omap_gem_pin(), in case the
caller does not need the dma_addr.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/omap_gem.c | 6 --
1 file changed, 4
On 07/10/2019 13:25, Jean-Jacques Hiblot wrote:
From: Tomi Valkeinen
Reorder OMAP_BO flags and improve the comments.
Signed-off-by: Tomi Valkeinen
---
include/uapi/drm/omap_drm.h | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/uapi/drm
On 07/10/2019 13:25, Jean-Jacques Hiblot wrote:
From: Tomi Valkeinen
OMAP_BO_TILED does not make sense, as OMAP_BO_TILED_* values are not
bitmasks but normal values. As we already have OMAP_BO_TILED_MASK for
the mask, we can remove OMAP_BO_TILED and use OMAP_BO_TILED_MASK
instead.
Signed-off
On 07/10/2019 13:25, Jean-Jacques Hiblot wrote:
From: Tomi Valkeinen
omap_gem_new() has a comment about OMAP_BO_SCANOUT which does not make
sense. Also, for the TILER case, we drop OMAP_BO_SCANOUT flag for some
reason.
It's not clear what the original purpose of OMAP_BO_SCANOUT is
On 07/10/2019 13:25, Jean-Jacques Hiblot wrote:
From: Tomi Valkeinen
Add a helper function omap_gem_validate_flags() which validates the
omap_bo flags passed from the userspace.
Also drop the dev_err() message, as the userspace can cause that at
will.
Signed-off-by: Tomi Valkeinen
On 07/10/2019 13:25, Jean-Jacques Hiblot wrote:
From: Tomi Valkeinen
On SoCs with DMM/TILER, we have two ways to allocate buffers: normal
dma_alloc or via DMM (which basically functions as an IOMMU). DMM can
map 128MB at a time, and we only map the DMM buffers when they are used
(i.e. not at
On 07/10/2019 14:16, Tomi Valkeinen wrote:
On 07/10/2019 14:25, Jean-Jacques Hiblot wrote:
A first version of this work had been sent by Tomi Valkeinen in may 2017
(https://www.spinics.net/lists/dri-devel/msg140663.html).
This series adds a few new OMAP_BO flags to help the userspace manage
ls and default-brightness-level optional
- removed the option to use a GPIO enable.
- removed the option to use a regulator. It should be handled by the LED
core
- don't make any change to the LED core (not needed anymore)
Jean-Jacques Hiblot (4):
leds: populate the device's of_node
leds:
If initialization data is available and its fwnode is actually a of_node,
store this information in the led device's structure. This will allow the
device to use or provide OF-based API such (devm_xxx).
Signed-off-by: Jean-Jacques Hiblot
---
drivers/leds/led-class.c | 4 +++-
1 file chang
Jean-Jacques Hiblot
Acked-by: Pavel Machek
---
drivers/leds/led-class.c | 50
include/linux/leds.h | 4
2 files changed, 54 insertions(+)
diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
index bfa1b1033274..1d1f1d546dc7 100644
If the LED is acquired by a consumer device with devm_led_get(), it is
automatically released when the device is detached.
Signed-off-by: Jean-Jacques Hiblot
Acked-by: Pavel Machek
---
drivers/leds/led-class.c | 49
include/linux/leds.h | 2 ++
2
LED properties must be named "leds" in the same way that PWM, clocks or
PHY properties are names respectively "pwms", "clocks" and "phys".
Cc: devicet...@vger.kernel.org
Signed-off-by: Jean-Jacques Hiblot
---
.../devicetree/bindings/leds/common.txt
Add DT binding for led-backlight.
Cc: devicet...@vger.kernel.org
Signed-off-by: Jean-Jacques Hiblot
---
.../leds/backlight/led-backlight.yaml | 55 +++
1 file changed, 55 insertions(+)
create mode 100644
Documentation/devicetree/bindings/leds/backlight/led
From: Tomi Valkeinen
This patch adds a led-backlight driver (led_bl), which is similar to
pwm_bl except the driver uses a LED class driver to adjust the
brightness in the HW. Multiple LEDs can be used for a single backlight.
Signed-off-by: Tomi Valkeinen
Signed-off-by: Jean-Jacques Hiblot
From: Tomi Valkeinen
Reorder OMAP_BO flags and improve the comments.
Signed-off-by: Tomi Valkeinen
Reviewed-by: Jean-Jacques Hiblot
---
include/uapi/drm/omap_drm.h | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/uapi/drm/omap_drm.h b/include/uapi
From: Tomi Valkeinen
Add a helper function omap_gem_validate_flags() which validates the
omap_bo flags passed from the userspace.
Also drop the dev_err() message, as the userspace can cause that at
will.
Signed-off-by: Tomi Valkeinen
Reviewed-by: Jean-Jacques Hiblot
---
drivers/gpu/drm
From: Tomi Valkeinen
OMAP_BO_TILED does not make sense, as OMAP_BO_TILED_* values are not
bitmasks but normal values. As we already have OMAP_BO_TILED_MASK for
the mask, we can remove OMAP_BO_TILED and use OMAP_BO_TILED_MASK
instead.
Signed-off-by: Tomi Valkeinen
Reviewed-by: Jean-Jacques
- Document omap_gem_new() and the new flags using the kernel-doc format
changes in v2:
- fixed build error that crept in during rebase before sending (sorry
about that)
- rework the refcount part a bit.
Jean-Jacques Hiblot (1):
drm/omap: use refcount API to track the number of users of dma_addr
Tomi
one of the flags are given, the behavior is the same as currently.
Signed-off-by: Tomi Valkeinen
Reviewed-by: Jean-Jacques Hiblot
---
drivers/gpu/drm/omapdrm/omap_gem.c | 54 --
include/uapi/drm/omap_drm.h| 9 +
2 files changed, 61 insertions(+), 2 deletion
g that can be consumed by
DSS", this patch cleans up the above issues.
Signed-off-by: Tomi Valkeinen
Reviewed-by: Jean-Jacques Hiblot
---
drivers/gpu/drm/omapdrm/omap_gem.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c
b/drivers/
This would give us a WARN_ON() if the pin/unpin calls are unbalanced.
Proposed-by: Laurent Pinchart
Signed-off-by: Jean-Jacques Hiblot
Reviewed-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/omap_gem.c | 44 +++---
1 file changed, 22 insertions(+), 22 deletions
From: Tomi Valkeinen
Allow NULL to be passed in 'dma_addr' for omap_gem_pin(), in case the
caller does not need the dma_addr.
Signed-off-by: Tomi Valkeinen
Reviewed-by: Jean-Jacques Hiblot
---
drivers/gpu/drm/omapdrm/omap_gem.c | 6 --
1 file changed, 4 insertions(+), 2
From: Tomi Valkeinen
Add omap_gem_unpin_locked() which is a version of omap_gem_unpin() that
expects the caller to hold the omap_obj lock.
Signed-off-by: Tomi Valkeinen
Reviewed-by: Jean-Jacques Hiblot
---
drivers/gpu/drm/omapdrm/omap_gem.c | 25 ++---
1 file changed, 18
On 09/10/2019 21:26, Rob Herring wrote:
On Wed, Oct 09, 2019 at 10:51:25AM +0200, Jean-Jacques Hiblot wrote:
LED properties must be named "leds" in the same way that PWM, clocks or
PHY properties are names respectively "pwms", "clocks" and "phys".
Cc:
On 10/10/2019 11:45, Tomi Valkeinen wrote:
Hi JJ,
On 10/10/2019 12:34, Jean-Jacques Hiblot wrote:
A first version of this work had been sent by Tomi Valkeinen in may 2017
(https://www.spinics.net/lists/dri-devel/msg140663.html).
This series adds a few new OMAP_BO flags to help the userspace
From: Tomi Valkeinen
Add a helper function omap_gem_validate_flags() which validates the
omap_bo flags passed from the userspace.
Also drop the dev_err() message, as the userspace can cause that at
will.
Signed-off-by: Tomi Valkeinen
Reviewed-by: Jean-Jacques Hiblot
---
drivers/gpu/drm
From: Tomi Valkeinen
Allow NULL to be passed in 'dma_addr' for omap_gem_pin(), in case the
caller does not need the dma_addr.
Signed-off-by: Tomi Valkeinen
Reviewed-by: Jean-Jacques Hiblot
---
drivers/gpu/drm/omapdrm/omap_gem.c | 6 --
1 file changed, 4 insertions(+), 2
From: Tomi Valkeinen
Add omap_gem_unpin_locked() which is a version of omap_gem_unpin() that
expects the caller to hold the omap_obj lock.
Signed-off-by: Tomi Valkeinen
Reviewed-by: Jean-Jacques Hiblot
---
drivers/gpu/drm/omapdrm/omap_gem.c | 25 ++---
1 file changed, 18
1 - 100 of 141 matches
Mail list logo
