On Tue, 23 Mar 2021, Lyude Paul wrote:
> On Tue, 2021-03-23 at 16:06 +0200, Jani Nikula wrote:
>> On Thu, 18 Mar 2021, Lyude Paul wrote:
>> > Actually-NAK this. I just realized I've been misreading the bug and that
>> > this
>> > doesn't actually s
t yet support that in the kernel either.)
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
t,
and are all in sync, it's only the drm-next -> drm-misc-next backmerge
that's still needed.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedeskt
On Wed, 07 Apr 2021, Hans Verkuil wrote:
> On 07/04/2021 12:31, Jani Nikula wrote:
>> On Wed, 07 Apr 2021, Hans Verkuil wrote:
>>> It is the most complete EDID parser I know based on the various standards.
>>
>> Does it support pure DisplayID in addition to Displa
On Thu, 08 Apr 2021, Pekka Paalanen wrote:
> On Thu, 08 Apr 2021 16:49:37 +0300
> Jani Nikula wrote:
>
>> Anyway, this is only tangentially related to the library. I just think
>> we need to take DisplayID better into account also in the *users* of the
>> library, as
On Thu, 08 Apr 2021, Simon Ser wrote:
> On Thursday, April 8th, 2021 at 4:58 PM, Jani Nikula
> wrote:
>
>> Perhaps that should be the takeaway; try to minimize parsed data
>> where the consumer needs to know whether it originated from DisplayID or
>> EDID?
>
>
or tab, resulting in rst where the
code-block contents are only partially indented.
Please test the documentation build before applying.
Otherwise, the series seems like a nice cleanup.
Acked-by: Jani Nikula
--
Jani Nikula, Intel Open Source Graphics Center
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Mon, 12 Apr 2021, Thomas Zimmermann wrote:
> Hi
>
> Am 12.04.21 um 11:36 schrieb Jani Nikula:
>> Please test the documentation build before applying.
>
> I did and I'm pretty sure it looked correct. But I'll double check.
Cool, maybe someone added more sma
lly in the mmio macros), and it would be a terrible
> flag day.
FWIW, we had the dev_priv/dev macro trickery for a while to not have
that flag day conversion, until everything used i915 or &i915->drm. But
we got rid of it afterwards.
BR,
Jani.
--
Jani Nikula, I
915/intel_pm.c| 50 -
drivers/gpu/drm/i915/intel_uncore.c| 8 ++-
drivers/gpu/drm/i915/selftests/intel_uncore.c | 8 ++-
drivers/gpu/drm/i915/selftests/mock_gem_device.c | 2 +-
51 files changed, 376 inser
/drm/bridge/ti-sn65dsi86.c | 26 +++
> drivers/gpu/drm/drm_dp_aux_backlight.c | 191
> +
> include/drm/drm_dp_aux_backlight.h | 29
> 7 files changed, 264 insertions(+)
> create mode 100644 drivers/gpu/drm/drm_dp_
_attributes")
>> Signed-off-by: Arnd Bergmann
>> ---
>> drivers/gpu/drm/i915/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Oh kconfig stuff like this makes my head hurt, thanks for finding it
>
> I also can't see an alternati
disable_rpm_wakeref_asserts(&dev_priv->runtime_pm);
> @@ -1271,6 +1274,8 @@ static int i915_drm_resume(struct drm_device *dev)
>
> intel_gvt_resume(dev_priv);
>
> + intel_bxt_dsm_detect(pdev);
> +
In intel_display_resume() perhaps?
(Yay for confusing naming wrt display and modeset, it's a
work-in-progress.)
BR,
Jani.
> enable_rpm_wakeref_asserts(&dev_priv->runtime_pm);
>
> return 0;
--
Jani Nikula, Intel Open Source Graphics Center
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
gt; + "failed to register backlight (%d)\n", ret);
> + goto free_ddc;
> + }
> +
> + platform_set_drvdata(pdev, bd);
> +
> + return 0;
> +
> +free_ddc:
> + if (ddc)
> + put_device(&ddc->dev);
> +
>
On Mon, 26 Apr 2021, Kai-Heng Feng wrote:
> On Fri, Apr 23, 2021 at 3:35 PM Jani Nikula
> wrote:
>>
>> On Fri, 23 Apr 2021, Kai-Heng Feng wrote:
>> > On HP Fury G7 Workstations, graphics output is re-routed from Intel GFX
>> > to discrete GFX after S3. This
i915/hdcp: Fix
uninitialized symbol 'msg_end'").
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
> + * recommendation, port should be enabled before plane & pipe */
> if (is_cmd_mode(intel_dsi)) {
> for_each_dsi_port(port, intel_dsi->ports)
> intel_de_write(dev_priv,
--
Jani Nikula, Intel Open Source Graphics Center
_
> class is a module")
> Fixes: 44c1220a441c ("drm/i915: extract intel_panel.h from intel_drv.h")
> Signed-off-by: Randy Dunlap
> Cc: Ville Syrjälä
> Cc: Jani Nikula
> Cc: Damien Lespiau
> Cc: Daniel Vetter
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
&
n fix (Maarten)
Dan Carpenter (2):
drm/i915/gvt: Fix error code in intel_gvt_init_device()
drm/i915: fix an error code in intel_overlay_do_put_image()
Jani Nikula (1):
Merge tag 'gvt-next-fixes-2021-04-21' of
http
elevant for legacy drivers. In a later patchset, we may want to
> convert these as well and remove pdev entirely.
On the series,
Reviewed-by: Jani Nikula
How should we merge these?
>
> v7:
> * fix instances of pdev that have benn added under i915/
> v6:
> *
quot;drm/i915: Create stolen memory region from local
> memory")
> Cc: CQ Tang
> Cc: Matthew Auld
> Cc: Tvrtko Ursulin
> Cc: Xinyun Liu
> Cc: Tvrtko Ursulin
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
> Cc: Rodrigo Vivi
> Cc: Chris Wilson
> Cc: Mika Kuo
On Tue, 27 Apr 2021, Thomas Zimmermann wrote:
> Hi Jani
>
> Am 27.04.21 um 14:04 schrieb Jani Nikula:
>> On Tue, 27 Apr 2021, Thomas Zimmermann wrote:
>>> V7 of the patchset fixes some bitrot in the intel driver.
>>>
>>> The pdev field in struct drm_d
nn reported some of these a while back. I think we have some
of them fixed in our -next already, but not all. Thanks for the
reminder.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
+ /** Engine for which command streamer cycles is queried. */
> + struct i915_engine_class_instance engine;
> +
> + /** Must be zero. */
> + __u32 flags;
> +
> + /**
> + * Command streamer cycles as read from the command streamer
> + * register at 0x358 o
of that?
This is a bit off-topic, but DisplayID 2.0 defines primary use cases for
head mounted VR and AR, so we wouldn't have to quirk them.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
___
dri-devel mailing list
dri-devel@lists
longer as
>>the field will be moved into the struct's legacy section. Add a fix
>>for the rsp commit.
>
> Commit message match the patch.
>
> Reviewed-by: Michael J. Ruhl
> M
>
>>v2:
>> * fix an error in the commit description (Michael)
>>
>&g
patch, with a benign looking subject, and none of
the i915 maintainers in Cc. Not cool.
BR,
Jani.
> ret = drm_dp_mst_topology_mgr_init(&intel_dp->mst_mgr, &i915->drm,
> -&intel_dp->aux, 16, 3, conn_base_id);
> +
t; radeon_dp_mst_init(struct radeon_connector *radeon_connector)
>> {
>> struct drm_device *dev = radeon_connector->base.dev;
>> + int max_link_rate;
>>
>> if (!radeon_connector->ddc_bus->has_aux)
>> return 0;
te calculation
Colin Xu (1):
drm/i915/gvt: Prevent divided by zero when calculating refresh rate
Jani Nikula (1):
Merge tag 'gvt-next-fixes-2021-04-29' of
https://github.com/intel/gvt-linux into drm-intel-next-fixes
drivers/gpu/drm/i915/gvt/handl
On Fri, 30 Apr 2021, Jani Nikula wrote:
> On Thu, 29 Apr 2021, Lyude Paul wrote:
>> JFYI Jani and Ben: I will be pushing this patch to drm-misc-next sometime
>> today if there's no objections
>
> Thanks for the heads-up, I think this breaks i915. See my review
> com
On Mon, 03 May 2021, Jani Nikula wrote:
> On Fri, 30 Apr 2021, Jani Nikula wrote:
>> On Thu, 29 Apr 2021, Lyude Paul wrote:
>>> JFYI Jani and Ben: I will be pushing this patch to drm-misc-next sometime
>>> today if there's no objections
>>
>> Thank
CC all the maintainers.
The drivers we have are monsters, and it can be tricky to get the
details right. All the more important to get the Cc's right; then at
least you can blame us afterwards. ;)
Thanks for reacting quickly, though.
BR,
Jani.
--
Jani Nikula,
iver for all known devices.
>
> config DRM_I915_BACKLIGHT
> - tristate "Control backlight support"
> - depends on DRM_I915
> - default DRM_I915
> - select BACKLIGHT_CLASS_DEVICE
> - help
> - Say Y here if you want to control the backlight of your display
> - (e.g. a laptop panel).
> + def_tristate DRM_I915
>
> config DRM_I915_CAPTURE_ERROR
> bool "Enable capturing GPU state following a hang"
--
Jani Nikula, Intel Open Source Graphics Center
Avoid uintXX_t types in the driver.
Fixes: 213d50927763 ("drm/i915/ttm: Introduce a TTM i915 gem object backend")
Cc: Thomas Hellström
Cc: Matthew Auld
Cc: Maarten Lankhorst
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +-
1 file changed, 1 inser
On Tue, 10 Aug 2021, Daniel Vetter wrote:
> On Tue, Aug 10, 2021 at 11:41:28AM +0300, Jani Nikula wrote:
>> Avoid uintXX_t types in the driver.
>>
>> Fixes: 213d50927763 ("drm/i915/ttm: Introduce a TTM i915 gem object backend")
>> Cc: Thomas Hellström
using MCHBAR
Gwan-gyeong Mun (1):
drm/i915/dg2: Update lane disable power state during PSR
Imre Deak (2):
drm/i915/adlp: Add workaround to disable CMTG clock gating
drm/i915: Apply CMTG clock disabling WA while DPLL0 is enabled
Jani Nikula (1):
drm/i915/plane: add intel_plane_
ow much pain it is to fix that up, but
>> commit db47fe727e1fc516cf60fc9ab8299605ef3c2d54
>> Author: Anusha Srivatsa
>> Commit: Matt Roper
>>
>> drm/i915/step: s/_revid_tbl/_revids
>>
>> Simplify the stepping info array name.
>>
>> Cc: Jani
7:18:54)
>> > > > Hi all,
>> > > >
>> > > > Commit
>> > > >
>> > > > db47fe727e1f ("drm/i915/step:
>> > > > s/_revid_tbl/_revids")
>> > > >
>> > > > is missing a Signed-off-by from its committer.
>> > > >
>> > > > --
>> > > > Cheers,
>> > > > Stephen Rothwell
>> >
>> > --
>> > Daniel Vetter
>> > Software Engineer, Intel Corporation
>> > http://blog.ffwll.ch
>>
>> --
>> Matt Roper
>> Graphics Software Engineer
>> VTT-OSGC Platform Enablement
>> Intel Corporation
>> (916) 356-2795
--
Jani Nikula, Intel Open Source Graphics Center
+-
> drivers/gpu/drm/msm/dp/dp_display.c | 14 ++--
> drivers/gpu/drm/msm/dp/dp_panel.c | 9 ++-
> 4 files changed, 102 insertions(+), 61 deletions(-)
--
Jani Nikula, Intel Open Source Graphics Center
On Wed, 11 Aug 2021, Dave Airlie wrote:
> On Wed, 11 Aug 2021 at 17:11, Jani Nikula wrote:
>>
>> On Wed, 11 Aug 2021, Joonas Lahtinen wrote:
>> > Quoting Dave Airlie (2021-08-11 06:48:39)
>> >> dim: db47fe727e1f ("drm/i915/step:
>> >
On Wed, 11 Aug 2021, Daniel Vetter wrote:
> On Wed, Aug 11, 2021 at 10:16:41AM +0300, Jani Nikula wrote:
>> On Tue, 10 Aug 2021, Daniel Vetter wrote:
>> > On Mon, Aug 09, 2021 at 09:19:39AM -0700, Matt Roper wrote:
>> >> On Mon, Aug 09, 2021 at 04:05:59PM +0200, D
r.
> + */
> +struct i915_pxp_component {
> + struct device *tee_dev;
> + const struct i915_pxp_component_ops *ops;
> +
> + /* To protect the above members. */
> + struct mutex mutex;
> +};
> +
> +#endif /* _I915_TEE_PXP_INTERFACE_H_ */
--
Jani Nikula, Intel Open Source Graphics Center
I'll probably want to merge these to drm-intel-next and drm-misc-next
via a topic branch.
Jani Nikula (4):
drm/dp: add DP 2.0 UHBR link rate and bw code conversions
drm/dp: use more of the extended receiver cap
drm/dp: add LTTPR DP 2.0 DPCD addresses
drm/dp: add helper for extra
The bw code equals link_rate / 0.27 Gbps only for 8b/10b link
rates. Handle DP 2.0 UHBR rates as special cases, though this is not
pretty.
Cc: Manasi Navare
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_dp_helper.c | 26 ++
1 file changed, 22 insertions(+), 4
Extend the use of extended receiver cap at 0x2200 to cover
MAIN_LINK_CHANNEL_CODING_CAP in 0x2206, in case an implementation hides
the DP 2.0 128b/132b channel encoding cap.
Cc: Manasi Navare
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_dp_helper.c | 2 +-
1 file changed, 1 insertion
DP 2.0 brings some new DPCD addresses for PHY repeaters.
Cc: Manasi Navare
Signed-off-by: Jani Nikula
---
include/drm/drm_dp_helper.h | 4
1 file changed, 4 insertions(+)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 1d5b3dbb6e56..f3a61341011d 100644
--- a
The DP 2.0 128b/132b channel coding uses TX FFE presets instead of
vswing and pre-emphasis.
Cc: Manasi Navare
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_dp_helper.c | 14 ++
include/drm/drm_dp_helper.h | 2 ++
2 files changed, 16 insertions(+)
diff --git a/drivers/gpu
FB
> select DRM_KMS_HELPER
> select FB_CFB_FILLRECT
> select FB_CFB_COPYAREA
--
Jani Nikula, Intel Open Source Graphics Center
elper.ko is the module, enabled via DRM_KMS_HELPER, and it
has an implicit dependency on FB, and DRM_FBDEV_EMULATION selects
DRM_KMS_HELPER. Select just breaks dependencies in all kinds of ways.
This might help in config DRM_KMS_HELPER, and it might help the reader
because it'
setting driver"
> depends on DRM
> - depends on FB
> + depends on FB && FB != m
> select DRM_KMS_HELPER
> select FB_CFB_FILLRECT
> select FB_CFB_COPYAREA
>
> --
> Jackie Liu
>
> 在 2021/8/16 下午3:01, Jani N
depends on FB || FB=n
>
> --
> Thanks, BR, Jackie Liu
>
> 在 2021/8/16 下午4:33, Jani Nikula 写道:
>> On Mon, 16 Aug 2021, Jackie Liu wrote:
>>> Hi Jani.
>>>
>>> My CI report an randconfigs build failed. there are:
>>>
>>> drm_fb_h
On Mon, 16 Aug 2021, Jani Nikula wrote:
> On Mon, 16 Aug 2021, Jackie Liu wrote:
>> Hi Jani.
>>
>> Your suggestion is that?
>>
>> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
>> index 7ff89690a976..ba179a539497 100644
>> --- a/dri
bool "Enable legacy fbdev support for your modesetting driver"
> depends on DRM
> - depends on FB
> + depends on FB && FB != m
> select DRM_KMS_HELPER
> select FB_CFB_FILLRECT
> select FB_CFB_COPYAREA
--
Jani Nikula, Intel Open Source Graphics Center
The bw code equals link_rate / 0.27 Gbps only for 8b/10b link
rates. Handle DP 2.0 UHBR rates as special cases, though this is not
pretty.
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_dp_helper.c | 26 ++
1 file changed, 22
Extend the use of extended receiver cap at 0x2200 to cover
MAIN_LINK_CHANNEL_CODING_CAP in 0x2206, in case an implementation hides
the DP 2.0 128b/132b channel encoding cap.
Cc: dri-devel@lists.freedesktop.org
Reviewed-by: Manasi Navare
Signed-off-by: Jani Nikula
---
drivers/gpu/drm
The DP 2.0 128b/132b channel coding uses TX FFE presets instead of
vswing and pre-emphasis.
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_dp_helper.c | 14 ++
include/drm/drm_dp_helper.h | 2 ++
2 files changed, 16 insertions(+)
diff
DP 2.0 brings some new DPCD addresses for PHY repeaters.
Cc: dri-devel@lists.freedesktop.org
Reviewed-by: Manasi Navare
Signed-off-by: Jani Nikula
---
include/drm/drm_dp_helper.h | 4
1 file changed, 4 insertions(+)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
funcs); i++) {
>> -err = init_funcs[i].init();
>> - if (err < 0) {
>> -while (i--) {
>> -if (init_funcs[i].exit)
>> -init_funcs[i].exit();
>> -}
>> -return err;
>> -} else if (err > 0) {
>> -/*
>> - * Early-exit success is reserved for things which
>> - * don't have an exit() function because we have no
>> - * idea how far they got or how to partially tear
>> - * them down.
>> - */
>> -WARN_ON(init_funcs[i].exit);
>> -
>> -/*
>> - * We don't want to advertise devices with an only
>> - * partially initialized driver.
>> - */
>> -WARN_ON(i915_pci_driver.driver.owner);
>> -break;
>> -}
>> -}
>> -
>> -init_progress = i;
>> -
>> -return 0;
>> -}
>> -
>> -static void __exit i915_exit(void)
>> -{
>> -int i;
>> -
>> -for (i = init_progress - 1; i >= 0; i--) {
>> -GEM_BUG_ON(i >= ARRAY_SIZE(init_funcs));
>> -if (init_funcs[i].exit)
>> -init_funcs[i].exit();
>> -}
>> -}
>> -
>> -module_init(i915_init);
>> -module_exit(i915_exit);
>> -
>> -MODULE_AUTHOR("Tungsten Graphics, Inc.");
>> -MODULE_AUTHOR("Intel Corporation");
>> -
>> -MODULE_DESCRIPTION(DRIVER_DESC);
>> -MODULE_LICENSE("GPL and additional rights");
>> diff --git a/drivers/gpu/drm/i915/i915_pci.h
>> b/drivers/gpu/drm/i915/i915_pci.h
>> new file mode 100644
>> index ..b386f319f52e
>> --- /dev/null
>> +++ b/drivers/gpu/drm/i915/i915_pci.h
>> @@ -0,0 +1,8 @@
>> +/*
>> + * SPDX-License-Identifier: MIT
>> + *
>> + * Copyright © 2021 Intel Corporation
>> + */
>> +
>> +int i915_register_pci_driver(void);
>> +void i915_unregister_pci_driver(void);
--
Jani Nikula, Intel Open Source Graphics Center
The bw code equals link_rate / 0.27 Gbps only for 8b/10b link
rates. Handle DP 2.0 UHBR rates as special cases, though this is not
pretty.
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_dp_helper.c | 26 ++
1 file changed, 22
Extend the use of extended receiver cap at 0x2200 to cover
MAIN_LINK_CHANNEL_CODING_CAP in 0x2206, in case an implementation hides
the DP 2.0 128b/132b channel encoding cap.
Cc: dri-devel@lists.freedesktop.org
Reviewed-by: Manasi Navare
Signed-off-by: Jani Nikula
---
drivers/gpu/drm
DP 2.0 brings some new DPCD addresses for PHY repeaters.
Cc: dri-devel@lists.freedesktop.org
Reviewed-by: Manasi Navare
Signed-off-by: Jani Nikula
---
include/drm/drm_dp_helper.h | 4
1 file changed, 4 insertions(+)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
The DP 2.0 128b/132b channel coding uses TX FFE presets instead of
vswing and pre-emphasis.
Cc: dri-devel@lists.freedesktop.org
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_dp_helper.c | 14 ++
include/drm/drm_dp_helper.h | 2 ++
2 files
typec: altmodes/displayport: Notify drm subsys of hotplug events
>
> drivers/gpu/drm/drm_connector.c | 79 +
> drivers/gpu/drm/drm_crtc_internal.h | 2 +
> drivers/gpu/drm/drm_sysfs.c | 87
> +++-
> driver
On Thu, 19 Aug 2021, Ville Syrjälä wrote:
> On Fri, Aug 13, 2021 at 01:43:20PM +0300, Jani Nikula wrote:
>> Extend the use of extended receiver cap at 0x2200 to cover
>> MAIN_LINK_CHANNEL_CODING_CAP in 0x2206, in case an implementation hides
>> the DP 2.0 128b/132b channel en
7;re using GEM_BUG_ON()
in generic driver code.
BR,
Jani.
> + if (init_funcs[i].exit)
> + init_funcs[i].exit();
> + }
> +}
--
Jani Nikula, Intel Open Source Graphics Center
add this kind of
checks in the middle of the generic functions. What if the type was bool
or ulong, where the generic function is a debugfs helper outside of
i915?
See the comment in i915_debugfs_params() that I added there exactly
because I envisioned someone was going to need this facility:
display.c | 3 +++
drivers/gpu/drm/i915/gt/intel_migrate.c | 2 +-
drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 4 +--
drivers/gpu/drm/i915/i915_module.c | 37 ++--
4 files changed, 30 insertions(+), 16 deletions(-)
--
Jani Nikula, Intel Open Source Graphics Center
On Wed, 25 Aug 2021, Jani Nikula wrote:
> On Thu, 19 Aug 2021, Ville Syrjälä wrote:
>> On Fri, Aug 13, 2021 at 01:43:20PM +0300, Jani Nikula wrote:
>>> Extend the use of extended receiver cap at 0x2200 to cover
>>> MAIN_LINK_CHANNEL_CODING_CAP in 0x2206, in case an i
dbg_kms(&dp_to_i915(intel_dp)->drm,
>> -"[CONNECTOR:%d:%s] Link Training %s at link rate = %d, lane
>> count = %d, at %s",
>> +"[CONNECTOR:%d:%s] Link Training %s at link rate = %d, lane
>> co
e 100644 drivers/gpu/drm/i915/display/skl_scaler.c
create mode 100644 drivers/gpu/drm/i915/display/skl_scaler.h
create mode 100644 drivers/gpu/drm/i915/display/skl_universal_plane.c
create mode 100644 drivers/gpu/drm/i915/display/skl_universal_plane.h
--
Jani Nikula, Intel Open Source Graphics Cen
| 13 +
drivers/gpu/drm/i915/i915_reg.h | 23 ++-
drivers/gpu/drm/i915/intel_pm.c | 16 +++-
3 files changed, 42 insertions(+), 10 deletions(-)
--
Jani Nikula, Intel Open Source Graphics Center
___
dri-devel mailing list
gt; val = intel_de_read(dev_priv, enable_reg);
> --
> 2.26.2
>
--
Jani Nikula, Intel Open Source Graphics Center
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
)
I use this monster in my .gitconfig:
[alias]
cite = "!f() { git log -1 '--pretty=format:%H (\"%s\")%n' $1 | sed -e
's/\\([0-f]\\{12\\}\\)[0-f]*/\\1/'; }; f"
With that, 'git cite ' will give you the nice reference with
12 chars of sha1
nothign here.
> + * nothing here.
>*/
>
> val = intel_de_read(dev_priv, enable_reg);
> --
> 2.31.0
>
--
Jani Nikula, Intel Open Source Graphics Center
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
ms than via patches on the mailing list. Granted,
the TODO file enforces the discussion happens at a large enough
audience, but for at least some of the items I'd suggest filing gitlab
issues [1], with todo label, and tracking there.
BR,
Jani.
[1] https://gitlab.freedesktop.org/drm/intel/-
;>
>> So it's possible that this value might just need to be tweaked, but for now
>> let's just disable the VESA backlight interface unless it's specified in
>> the VBT just to be safe. We might be able to try enabling this again by
>> default in the fu
on't think there's an issue, but the code could use a bunch
of improvements.
Like, we have intel_print_wm_latency() for debug logging and
wm_latency_show() for debugfs, and there's a bunch of duplication and
ugh.
But this seems like the easiest fix for the warning.
Reviewed-by: Jani Nikula
#include "intel_vdsc.h"
> #include "intel_vrr.h"
>
> -#define DP_DPRX_ESI_LEN 14
> +#define DP_DPRX_ESI_LEN 16
>
> /* DP DSC throughput values used for slice count calculations KPixels/s */
> #define DP_DSC_PEAK_PIXEL_RATE
lay/intel_dp_hdcp.c | 45 ++--
> include/drm/drm_hdcp.h | 5 ++-
> 2 files changed, 36 insertions(+), 14 deletions(-)
Maarten, Maxime, Thomas -
Can I get an ack for merging this via drm-intel-next, please?
BR,
Jani.
--
Jani Nikula, Int
p_pcon_frl_prepare(struct drm_dp_aux *aux, bool
> enable_frl_ready_hpd);
> bool drm_dp_pcon_is_frl_ready(struct drm_dp_aux *aux);
> int drm_dp_pcon_frl_configure_1(struct drm_dp_aux *aux, int max_frl_gbps,
> - bool concurrent_mode);
> + u8 frl_mode);
> int drm_dp_pcon_frl_configure_2(struct drm_dp_aux *aux, int max_frl_mask,
> - bool extended_train_mode);
> + u8 frl_type);
> int drm_dp_pcon_reset_frl_config(struct drm_dp_aux *aux);
> int drm_dp_pcon_frl_enable(struct drm_dp_aux *aux);
--
Jani Nikula, Intel Open Source Graphics Center
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
in drm-next they will backmerge, and the -gt-next tree is open for
> business again.
I guess worth noting is that drm-intel-gt-next is now rebased on top of
current drm-next. Since the topic branch is part of drm-tip, I presume
the conflicts are manageable.
BR,
Jani.
--
Jani Nikula, Intel Ope
v2 of [1], addressing Ville's review comments, and adding a couple of
extra patches on top.
BR,
Jani.
[1] https://patchwork.freedesktop.org/series/87802/
Jani Nikula (8):
drm/edid: make a number of functions, parameters and variables const
drm/displayid: add separate drm_displayid.c
If there's no need to change it, it should be const. There's more to be
done, but start off with changes that make follow-up work easier. No
functional changes.
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_ed
lä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/Makefile| 2 +-
drivers/gpu/drm/drm_displayid.c | 59 +
drivers/gpu/drm/drm_edid.c | 58 ++--
include/drm/drm_displayid.h | 8 +
include/drm/drm_edid.h
ille)
- remove __ prefix from displayid_iter_block
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_displayid.c | 74 +
include/drm/drm_displayid.h | 18
2 files changed, 92 insertions(+)
diff --git a/drivers/gpu/drm/drm_displayid.c b/dr
Neatly reduce displayid boilerplate in code. No functional changes.
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 23 ++-
1 file changed, 6 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm
Neatly reduce displayid boilerplate in code. No functional changes.
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 25 +
1 file changed, 9 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm
Neatly reduce displayid boilerplate in code. Remove excessive debug
logging while at it, no other functional changes.
The old displayid iterator becomes unused; remove it as well as make
drm_find_displayid_extension() static.
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers
The DisplayID specifications explicitly call out 0 as a valid payload
length for data blocks. The mere presence of a data block, or the
information coded in the block specific data (bits 7:3 in offset 1), may
be enough to convey the necessary information.
Signed-off-by: Jani Nikula
---
drivers
Avoid any confusion with High Dynamic Range. No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_displayid.c | 10 +-
include/drm/drm_displayid.h | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/drm_displayid.c b/drivers
On Fri, 26 Mar 2021, Maxime Ripard wrote:
> Hi,
>
> On Fri, Mar 26, 2021 at 11:47:58AM +0200, Jani Nikula wrote:
>> On Tue, 23 Mar 2021, Ankit Nautiyal wrote:
>> > Currently the FRL training mode (Concurrent, Sequential) and
>> > training type (Normal, Exten
On Thu, 25 Mar 2021, Jani Nikula wrote:
> On Wed, 24 Mar 2021, Anshuman Gupta wrote:
>> HDCP DP 2.2 errata is part of HDCP DP 2.3 specs
>> as well.
>>
>> Anshuman Gupta (2):
>> drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg
>> drm/hdc
}
>> +}
>> +
>> byte = buf;
>> *byte = msg_id;
>>
>> diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h
>> index ac22c246542a..2b165a0f434f 100644
>> --- a/include/drm/drm_hdcp.h
>> +++ b/include/drm/drm_hdcp.h
>>
On Mon, 29 Mar 2021, Jani Nikula wrote:
> v2 of [1], addressing Ville's review comments, and adding a couple of
> extra patches on top.
>
> BR,
> Jani.
>
> [1] https://patchwork.freedesktop.org/series/87802/
Pushed to drm-misc-next, with Ville's review and Maxim
dst_stride!=width/height
drm/i915: Fix docbook header for __intel_runtime_pm_get_if_active()
Jani Nikula (23):
drm/i915: remove unused ADLS_REVID_* macros
drm/i915/bios: mass convert dev_priv to i915
drm/i915/bios: store bdb version in i915
drm/i915/bios: re
c;
> struct device *dev;
> + struct drm_device *drm_dev;
Bikeshed, I would probably have called it just drm for brevity, but no
strong feelings.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
___
dri-devel mailing lis
drm_dp_mst_topology_mgr
> to drm_dp_get_vc_payload_bw()" as this was the style in use
> previously, and 2 chars over the limit looks nicer then trying to
> line-wrap this
> * Don't rewrap comments
For anything touching i915, and for merging via whichever tree or branch
see
by the consumer (opposed to what was actually implemented in
> hardware in reply to the last request). To make this semantic obvious
> rename the function.
>
> Signed-off-by: Uwe Kleine-König
> ---
> drivers/gpu/drm/i915/display/intel_panel.c | 4 +--
Acked-by: Jani Nikula
-
gt_max_freq_mhz_store(struct device *kdev,
> @@ -387,8 +382,7 @@ static ssize_t gt_min_freq_mhz_show(struct device *kdev,
> struct device_attribute
> struct drm_i915_private *dev_priv = kdev_minor_to_i915(kdev);
> struct intel_rps *rps = &dev_priv->gt.rps;
>
> -
7;t:
if (!panel->backlight.level)
panel->backlight.level = intel_pwm_get_backlight(connector);
What do you think?
BR,
Jani.
> - val = intel_panel_compute_brightness(connector, val);
> - panel->backlight.level = clamp(val, panel->backlight.min,
> -
1 - 100 of 5910 matches
Mail list logo
