[PATCH] drm/vmwgfx: Split GMR2_REMAP commands if they are to large

2013-08-28 Thread Jakob Bornecrantz
This fixes the piglit test texturing/max-texture-size causing the VM to die due to a too large SVGA command. Signed-off-by: Jakob Bornecrantz Reviewed-by: Biran Paul Reviewed-by: Zack Rusin --- drivers/gpu/drm/vmwgfx/vmwgfx_gmr.c | 58 + 1 file changed, 39

[PATCH] drm/vmwgfx: fix lock breakage

2014-10-31 Thread Jakob Bornecrantz
ark >> --- >> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 8 >> 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Jakob Bornecrantz >> >> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c >> b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c >> index

[PATCH 07/18] libkms: add Android build

2014-09-08 Thread Jakob Bornecrantz
(-) > create mode 100644 libkms/Android.mk Not super familiar with Android build system but it looks good to me: Reviewed-by: Jakob Bornecrantz Cheers, Jakob. > > diff --git a/Android.mk b/Android.mk > index 97a7d75..4d02b05 100644 > --- a/Android.mk > +++ b/An

[PATCH 05/18] libkms: build the intel backend only when needed

2014-09-08 Thread Jakob Bornecrantz
On Sun, Sep 7, 2014 at 11:30 PM, Emil Velikov wrote: > Signed-off-by: Emil Velikov > --- > configure.ac | 3 +++ > libkms/Makefile.am | 5 - > libkms/linux.c | 16 +++- > 3 files changed, 18 insertions(+), 6 deletions(-) Reviewed-by: Jakob Bo

[PATCH 00/18] Final batch of Android related fixes

2014-09-08 Thread Jakob Bornecrantz
in branch 'android-final-fixes' at > https://github.com/evelikov/libdrm > > > Any comments, reviews, it builds or it works are appreciated. While I'm not that familiar with the Android build system patches 01, 02 and 03 - 18 are Reviewed-by: Jakob Bornecrantz You will have to ask the intel people about 810 and 830 headers removal. Cheers, Jakob.

Re: Shared atomic state causing Weston repaint failure

2018-07-05 Thread Jakob Bornecrantz
Hello Daniel² et al, I apologies in advance if the things I bring up are a bit orthogonal to the current discussion. And I'm writing this from the view of VR, but I have not written a VR compositor so take my comments with a bit of salt. And also changing modes while using a VR headset is probably

[PATCH] drm/vmwgfx: Split GMR2_REMAP commands if they are to large

2013-08-29 Thread Jakob Bornecrantz
This fixes the piglit test texturing/max-texture-size causing the VM to die due to a too large SVGA command. Signed-off-by: Jakob Bornecrantz Reviewed-by: Biran Paul Reviewed-by: Zack Rusin --- drivers/gpu/drm/vmwgfx/vmwgfx_gmr.c | 58 + 1 file changed, 39

[PATCH] drm: Push dirtyfb ioctl kms locking down to drivers

2013-12-04 Thread Jakob Bornecrantz
Looks good to me Reviewed-by: Jakob Bornecrant On Wed, Dec 4, 2013 at 1:13 PM, wrote: > From: Ville Syrj?l? > > Not all drivers will need take all the modeset locks for dirtyfb, so > push the locking down to the drivers. > > Signed-off-by: Ville Syrj?l? > Reviewed-by: Daniel Vetter > --- >

[PATCH] drm/ttm: Fix accesses through vmas with only partial coverage

2013-12-12 Thread Jakob Bornecrantz
Looks good to me. Cheers, Jakob. - Thomas Hellstrom wrote: > VMAs covering a bo but that didn't start at the same address space offset as > the bo they were mapping were incorrectly generating SEGFAULT errors in > the fault handler. > > Reported-by: Joseph Dolinak > Signed-off-by: Thomas H

[PATCH 00/50] more drm de-midlayering

2013-12-12 Thread Jakob Bornecrantz
The vmwgfx changes are: Reviewed-by: Jakob Bornecrantz On Wed, Dec 11, 2013 at 11:34 AM, Daniel Vetter wrote: > Hi all, > > This series almost removes drm_bus, the last thing remaining is the > ->setversion > callback. Unfortunately we can't kill that completely since

drm/vmwgfx: add MODULE_DEVICE_TABLE so vmwgfx loads at boot

2012-09-06 Thread Jakob Bornecrantz
On Thu, Sep 6, 2012 at 3:35 PM, Tim Gardner wrote: > Dave - I couldn't find this patch in your git repo at > git://people.freedesktop.org/~airlied/linux in the drm-next or drm-fixes > branches. > > https://patchwork.kernel.org/patch/1379071/ > > It appears to fix a real problem for Mac users - >

[PATCH] i915: Fix comments about cube layouts

2010-04-12 Thread Jakob Bornecrantz
--- src/mesa/drivers/dri/i915/i915_tex_layout.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i915/i915_tex_layout.c b/src/mesa/drivers/dri/i915/i915_tex_layout.c index 7026552..c98dede 100644 --- a/src/mesa/drivers/dri/i915/i915_tex_layout.c ++

[PATCH] drm: Check for invalid cursor flags

2012-08-16 Thread Jakob Bornecrantz
Signed-off-by: Jakob Bornecrantz --- drivers/gpu/drm/drm_crtc.c |2 +- include/drm/drm_mode.h |5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 08a7aa7..6fbfc24 100644 --- a/drivers/gpu/drm

Re: [PATCH] drm: stop vmgfx driver explosion

2012-08-20 Thread Jakob Bornecrantz
ection it's just another > oops, without it there are some "intriguing" possibilities. > > What it should do is an open question but that for the driver owners > to sort out. > > Signed-off-by: Alan Cox Thanks Alan! Reviewed-by: Jakob Bo

[PATCH] dri: Rework planar image interface

2012-08-25 Thread Jakob Bornecrantz
to get the dri- interface changes out as fast as possible for review. I have tested these changes on SVGA with the previus patch series I sent out (mines the last one), and everything seem to work just as before. Cheers, Jakob. Signed-off-by: Jakob Bornecrantz --- include/GL/internal/dri_i

Re: [PATCH] vmwgfx: add dumb ioctl support

2012-08-28 Thread Jakob Bornecrantz
Thanks for doing this. With an exception of a comment below all 3 patches are Reviewed-by: Jakob Bornecrantz - Original Message - > From: Dave Airlie > > Testing and works with the -modesetting driver at least so far. > > Signed-off-by: Dave Airlie > --- > d

Re: drm/vmwgfx: add MODULE_DEVICE_TABLE so vmwgfx loads at boot

2012-09-06 Thread Jakob Bornecrantz
On Thu, Sep 6, 2012 at 3:35 PM, Tim Gardner wrote: > Dave - I couldn't find this patch in your git repo at > git://people.freedesktop.org/~airlied/linux in the drm-next or drm-fixes > branches. > > https://patchwork.kernel.org/patch/1379071/ > > It appears to fix a real problem for Mac users - > h

Re: [PATCH 2/4] drm/doc: integrate crtc helper api into docbook

2012-11-01 Thread Jakob Bornecrantz
On Thu, Nov 1, 2012 at 2:45 PM, Daniel Vetter wrote: > - Add the missing doc for drm_helper_move_panel_connectors_to_head. > - Fixup any outdated stuff in existing sections. I've only looked at > those kerneldoc headers that actually resulted in a complaint from > the kerneldoc parser tool. >

Re: [PATCH] kms: Return a negative error code in kms_bo_create()

2012-11-02 Thread Jakob Bornecrantz
to detect > errors with a < 0 check. > > Signed-off-by: Laurent Pinchart Reviewed-by: Jakob Bornecrantz ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] kms: Make libkms.h usable in C++

2012-11-02 Thread Jakob Bornecrantz
On Thu, Nov 1, 2012 at 10:40 AM, Laurent Pinchart wrote: > Wrap the header in extern "C" { ... };. > > Signed-off-by: Laurent Pinchart Reviewed-by: Jakob Bornecrantz ___ dri-devel mailing list dri-devel@lists.f

Re: [PATCH 12/25] vmwgfx: Add screen object support

2011-10-02 Thread Jakob Bornecrantz
On Fri, Sep 30, 2011 at 12:05 AM, Konrad Rzeszutek Wilk wrote: > On Wed, Sep 28, 2011 at 04:10:08PM +0200, Thomas Hellstrom wrote: >> From: Jakob Bornecrantz >> >> Signed-off-by: Jakob Bornecrantz >> Signed-off-by: Thomas Hellstrom >> --- >>  driv

Re: [PATCH 10/25] vmwgfx: Refactor common display unit functions to shared file

2011-10-02 Thread Jakob Bornecrantz
On Thu, Sep 29, 2011 at 11:50 PM, Konrad Rzeszutek Wilk wrote: > On Wed, Sep 28, 2011 at 04:10:06PM +0200, Thomas Hellstrom wrote: >> From: Jakob Bornecrantz >> >> More preparation for Screen Object support. >> >> Signed-off-by: Jakob Bornecrantz &

Re: [PATCH 05/25] vmwgfx: Make sure the reserved area is at the start of vram

2011-10-02 Thread Jakob Bornecrantz
On Thu, Sep 29, 2011 at 11:42 PM, Konrad Rzeszutek Wilk wrote: > On Wed, Sep 28, 2011 at 04:10:01PM +0200, Thomas Hellstrom wrote: >> From: Jakob Bornecrantz >> >> Signed-off-by: Jakob Bornecrantz >> Reviewed-by: Thomas Hellstrom >> --- >>  dri

Re: [PATCH 06/25] vmwgfx: Some comments and BUG_ON

2011-10-02 Thread Jakob Bornecrantz
On Thu, Sep 29, 2011 at 11:42 PM, Konrad Rzeszutek Wilk wrote: > On Wed, Sep 28, 2011 at 04:10:02PM +0200, Thomas Hellstrom wrote: >> From: Jakob Bornecrantz >> >> Signed-off-by: Jakob Bornecrantz >> Reviewed-by: Thomas Hellstrom >> --- >>  drivers

Re: vmwgfx + libkms on VMware hardware 8

2011-10-18 Thread Jakob Bornecrantz
Thanks for taking interesting in our driver. - Original Message - > Hi, > > I 'm trying to test KMS functionality of latest vmwgfx module. > I tried the code from > http://permalink.gmane.org/gmane.comp.video.dri.devel/42908 > > as a simple test case, but all I get is a black screen inste

Re: vmwgfx + libkms on VMware hardware 8

2011-10-19 Thread Jakob Bornecrantz
- Original Message - > Thanks for taking interesting in our driver. > > - Original Message - > > Hi, > > > > I 'm trying to test KMS functionality of latest vmwgfx module. > > I tried the code from > > http://permalink.gmane.org/gmane.comp.video.dri.devel/42908 > > > > as a simple

Re: [PATCH 1/2] vmwgfx: Emulate depth 32 framebuffers

2011-10-24 Thread Jakob Bornecrantz
- Original Message - > On Sat, Oct 22, 2011 at 10:29:33AM +0200, Thomas Hellstrom wrote: > > From: Jakob Bornecrantz > > > > Signed-off-by: Jakob Bornecrantz > > Signed-off-by: Thomas Hellstrom > > --- > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c |

Re: [PATCH] vmwgfx: Use kcalloc instead of kzalloc to allocate array

2011-12-05 Thread Jakob Bornecrantz
Reviewed-by: Jakob Bornecrantz - Original Message - > The advantage of kcalloc is, that will prevent integer overflows > which could result from the multiplication of number of elements > and size and it is also a bit nicer to read. > > The semantic patch that makes

Re: [RFC] drm: implement DRM_IOCTL_MODE_SETROTATION

2012-01-05 Thread Jakob Bornecrantz
- Original Message - > From: Paulo Zanoni > > This ioctl is used to signal the drivers that the screen is rotated, > not to make the drivers rotate the screen. > - add a driver-specific "rotation_set" function > - implement Intel's rotation_set by setting the right values to the >PI

Re: [RFC PATCH] vmwgfx: Fix assignment in vmw_framebuffer_create_handle

2012-01-27 Thread Jakob Bornecrantz
send this to stable, since we are not leaking data to userspace (check drm_mode_getfb), but we might as well. Reviewed-by: Jakob Bornecrantz Cheers, Jakob. - Original Message - > Ryan, > > Thanks for pointing this out. Unfortunately there seems to be two > bugs here,

Re: [RFC PATCH] vmwgfx: Fix assignment in vmw_framebuffer_create_handle

2012-01-27 Thread Jakob Bornecrantz
- Original Message - > On 01/27/2012 03:24 PM, Jakob Bornecrantz wrote: > > I was asking around and this seems to only be used by X when it > > starts and we want to preserve the contents of the screen. That > > feature is implemented by the X driver. So we need to f

Re: [RFC PATCH] vmwgfx: Fix assignment in vmw_framebuffer_create_handle

2012-01-27 Thread Jakob Bornecrantz
- Original Message - > On 01/27/2012 03:41 PM, Jakob Bornecrantz wrote: > > - Original Message - > >> On 01/27/2012 03:24 PM, Jakob Bornecrantz wrote: > >>> I was asking around and this seems to only be used by X when it > >>> starts a

Re: [PATCH] [trivial] drm: Fix typo in vmwgfx_drv.c

2012-02-05 Thread Jakob Bornecrantz
Reviewed-by: Jakob Bornecrantz - Original Message - > Correct spelling "unsuported" to "unsupported" in > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > > Signed-off-by: Masanari Iida > --- > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c |2 +- > 1 fi

Re: [RFC] drm: atomic mode set API

2012-02-16 Thread Jakob Bornecrantz
- Original Message - > Many of us really want (and need) a way to set the whole display > configuration atomically, as well as test a global config. > > In talking with Rob and Alex here at ELC a bit, I think this may be > enough: > > diff --git a/include/drm/drm_mode.h b/include/drm/drm_

Re: [PATCH 1/5] drm/vgem: virtual GEM provider

2012-02-16 Thread Jakob Bornecrantz
- Original Message - > From: Adam Jackson > > This is about as minimal of a virtual GEM service as possible. My > plan is to use this with non-native-3D hardware for buffer sharing > between X and DRI. > > The current drisw winsys assumes an unmodified X server, which means > it's hopel

Re: [PATCH] Only build test programs with make check

2012-03-17 Thread Jakob Bornecrantz
With my limited knowledge of automake I'm going to have to NACK this patch. Most of these programs are used during driver bring up to test things out, often we also modify them a bit to suit our need. If this patch doesn't make this any harder then disregard my NACK. Cheers Jakob. - Original

Re: [PATCH 1/2] drm: call pci_disable_device on module onload

2012-06-08 Thread Jakob Bornecrantz
On Fri, Jun 8, 2012 at 4:52 PM, Daniel Vetter wrote: > Otherwise we'll nicely leak this reference counter. Now thanks to the > awesome layering in the drm core, the enable call is done by the pci > boilerplate in drm_pci.c. But the disable can't be done without adding > yet another neat indirectio

Re: [PATCH] kms: Allow compiling libkms without Intel support

2013-04-12 Thread Jakob Bornecrantz
Oh, how very x86 centric of me, the changes are Reviewed-by Jakob Bornecrantz Cheers, Jakob. On Fri, Apr 12, 2013 at 4:07 PM, Laurent Pinchart < laurent.pinch...@ideasonboard.com> wrote: > Signed-off-by: Laurent Pinchart > --- > libkms/Makefile.am | 5 - > libk

Re: [PATCH 2/3] drm/vmwgfx: Don't access file_priv in cursor_set when handle==0

2013-06-03 Thread Jakob Bornecrantz
Thanks, looks good and is Reviewed-by: Jakob Bornecrantz Cheers, Jakob. On Mon, Jun 3, 2013 at 3:10 PM, wrote: > From: Ville Syrjälä > > We want to disable the cursor by calling ->cursor_set() with handle=0 > from places where we don't have a file_priv, so don't

Re: [RFC] drm: add overlays as first class KMS objects

2011-04-28 Thread Jakob Bornecrantz
On Wed, Apr 27, 2011 at 11:12 PM, Jesse Barnes wrote: > On Wed, 27 Apr 2011 14:19:05 +0200 > Daniel Vetter wrote: > >> Hi Jesse, >> >> I like it. It's a bit of a chicken-egg api design problem, but if a >> proof-of-concept >> implementation exists for an embedded chip plus something to check whet

Re: Radeon support state in libkms

2011-02-11 Thread Jakob Bornecrantz
On Wed, Feb 9, 2011 at 7:35 PM, Corbin Simpson wrote: > On Wed, Feb 9, 2011 at 6:49 AM, James Simmons wrote: >> >>> I was looking at the radeon support state in libkms and I found out the >>> following patch was proposed back in September, but never commented nor >>> merged. The patch was submitt

Re: Radeon support state in libkms

2011-02-17 Thread Jakob Bornecrantz
On Wed, Feb 16, 2011 at 7:40 PM, nobled wrote: > On Tue, Feb 15, 2011 at 9:17 AM, Alexandre Demers > wrote: >> On 11-02-11 06:21 AM, Jakob Bornecrantz wrote: >>> On Wed, Feb 9, 2011 at 7:35 PM, Corbin Simpson >>> wrote: >>>> On Wed, Feb 9, 2011 at 6:4

[PATCH 12/25] vmwgfx: Add screen object support

2011-10-03 Thread Jakob Bornecrantz
On Fri, Sep 30, 2011 at 12:05 AM, Konrad Rzeszutek Wilk wrote: > On Wed, Sep 28, 2011 at 04:10:08PM +0200, Thomas Hellstrom wrote: >> From: Jakob Bornecrantz >> >> Signed-off-by: Jakob Bornecrantz >> Signed-off-by: Thomas Hellstrom >> --- >> ?driv

[PATCH 10/25] vmwgfx: Refactor common display unit functions to shared file

2011-10-03 Thread Jakob Bornecrantz
On Thu, Sep 29, 2011 at 11:50 PM, Konrad Rzeszutek Wilk wrote: > On Wed, Sep 28, 2011 at 04:10:06PM +0200, Thomas Hellstrom wrote: >> From: Jakob Bornecrantz >> >> More preparation for Screen Object support. >> >> Signed-off-by: Jakob Bornecrantz &

[PATCH 05/25] vmwgfx: Make sure the reserved area is at the start of vram

2011-10-03 Thread Jakob Bornecrantz
On Thu, Sep 29, 2011 at 11:42 PM, Konrad Rzeszutek Wilk wrote: > On Wed, Sep 28, 2011 at 04:10:01PM +0200, Thomas Hellstrom wrote: >> From: Jakob Bornecrantz >> >> Signed-off-by: Jakob Bornecrantz >> Reviewed-by: Thomas Hellstrom >> --- >> ?dri

[PATCH 06/25] vmwgfx: Some comments and BUG_ON

2011-10-03 Thread Jakob Bornecrantz
On Thu, Sep 29, 2011 at 11:42 PM, Konrad Rzeszutek Wilk wrote: > On Wed, Sep 28, 2011 at 04:10:02PM +0200, Thomas Hellstrom wrote: >> From: Jakob Bornecrantz >> >> Signed-off-by: Jakob Bornecrantz >> Reviewed-by: Thomas Hellstrom >> --- >> ?drivers

vmwgfx + libkms on VMware hardware 8

2011-10-18 Thread Jakob Bornecrantz
Thanks for taking interesting in our driver. - Original Message - > Hi, > > I 'm trying to test KMS functionality of latest vmwgfx module. > I tried the code from > http://permalink.gmane.org/gmane.comp.video.dri.devel/42908 > > as a simple test case, but all I get is a black screen inste

vmwgfx + libkms on VMware hardware 8

2011-10-19 Thread Jakob Bornecrantz
- Original Message - > Thanks for taking interesting in our driver. > > - Original Message - > > Hi, > > > > I 'm trying to test KMS functionality of latest vmwgfx module. > > I tried the code from > > http://permalink.gmane.org/gmane.comp.video.dri.devel/42908 > > > > as a simple

[PATCH 1/2] vmwgfx: Emulate depth 32 framebuffers

2011-10-24 Thread Jakob Bornecrantz
- Original Message - > On Sat, Oct 22, 2011 at 10:29:33AM +0200, Thomas Hellstrom wrote: > > From: Jakob Bornecrantz > > > > Signed-off-by: Jakob Bornecrantz > > Signed-off-by: Thomas Hellstrom > > --- > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c |

[PATCH] drm: Check for invalid cursor flags

2012-08-16 Thread Jakob Bornecrantz
Signed-off-by: Jakob Bornecrantz --- drivers/gpu/drm/drm_crtc.c |2 +- include/drm/drm_mode.h |5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 08a7aa7..6fbfc24 100644 --- a/drivers/gpu/drm

[PATCH] drm: stop vmgfx driver explosion

2012-08-20 Thread Jakob Bornecrantz
ection it's just another > oops, without it there are some "intriguing" possibilities. > > What it should do is an open question but that for the driver owners > to sort out. > > Signed-off-by: Alan Cox Thanks Alan! Reviewed-by: Jakob Bornecrantz I think CC stable is in order. Cheers, Jakob.

[PATCH] dri: Rework planar image interface

2012-08-25 Thread Jakob Bornecrantz
to get the dri- interface changes out as fast as possible for review. I have tested these changes on SVGA with the previus patch series I sent out (mines the last one), and everything seem to work just as before. Cheers, Jakob. Signed-off-by: Jakob Bornecrantz --- include/GL/internal/dri_i

[PATCH] vmwgfx: add dumb ioctl support

2012-08-28 Thread Jakob Bornecrantz
Thanks for doing this. With an exception of a comment below all 3 patches are Reviewed-by: Jakob Bornecrantz - Original Message - > From: Dave Airlie > > Testing and works with the -modesetting driver at least so far. > > Signed-off-by: Dave Airlie > --- > d

[PATCH] [trivial] drm: Fix typo in vmwgfx_drv.c

2012-02-05 Thread Jakob Bornecrantz
Reviewed-by: Jakob Bornecrantz - Original Message - > Correct spelling "unsuported" to "unsupported" in > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > > Signed-off-by: Masanari Iida > --- > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c |2 +- > 1 fi

[RFC] drm: atomic mode set API

2012-02-16 Thread Jakob Bornecrantz
- Original Message - > Many of us really want (and need) a way to set the whole display > configuration atomically, as well as test a global config. > > In talking with Rob and Alex here at ELC a bit, I think this may be > enough: > > diff --git a/include/drm/drm_mode.h b/include/drm/drm_

[PATCH 1/5] drm/vgem: virtual GEM provider

2012-02-16 Thread Jakob Bornecrantz
- Original Message - > From: Adam Jackson > > This is about as minimal of a virtual GEM service as possible. My > plan is to use this with non-native-3D hardware for buffer sharing > between X and DRI. > > The current drisw winsys assumes an unmodified X server, which means > it's hopel

[RFC] drm: implement DRM_IOCTL_MODE_SETROTATION

2012-01-05 Thread Jakob Bornecrantz
- Original Message - > From: Paulo Zanoni > > This ioctl is used to signal the drivers that the screen is rotated, > not to make the drivers rotate the screen. > - add a driver-specific "rotation_set" function > - implement Intel's rotation_set by setting the right values to the >PI

[RFC PATCH] vmwgfx: Fix assignment in vmw_framebuffer_create_handle

2012-01-27 Thread Jakob Bornecrantz
send this to stable, since we are not leaking data to userspace (check drm_mode_getfb), but we might as well. Reviewed-by: Jakob Bornecrantz Cheers, Jakob. - Original Message - > Ryan, > > Thanks for pointing this out. Unfortunately there seems to be two > bugs here,

[RFC PATCH] vmwgfx: Fix assignment in vmw_framebuffer_create_handle

2012-01-27 Thread Jakob Bornecrantz
- Original Message - > On 01/27/2012 03:24 PM, Jakob Bornecrantz wrote: > > I was asking around and this seems to only be used by X when it > > starts and we want to preserve the contents of the screen. That > > feature is implemented by the X driver. So we need to f

[RFC PATCH] vmwgfx: Fix assignment in vmw_framebuffer_create_handle

2012-01-27 Thread Jakob Bornecrantz
- Original Message - > On 01/27/2012 03:41 PM, Jakob Bornecrantz wrote: > > - Original Message - > >> On 01/27/2012 03:24 PM, Jakob Bornecrantz wrote: > >>> I was asking around and this seems to only be used by X when it > >>> starts a

[RFC] drm: add overlays as first class KMS objects

2011-04-28 Thread Jakob Bornecrantz
On Wed, Apr 27, 2011 at 11:12 PM, Jesse Barnes wrote: > On Wed, 27 Apr 2011 14:19:05 +0200 > Daniel Vetter wrote: > >> Hi Jesse, >> >> I like it. It's a bit of a chicken-egg api design problem, but if a >> proof-of-concept >> implementation exists for an embedded chip plus something to check whe

[PATCH] vmwgfx: Use kcalloc instead of kzalloc to allocate array

2011-12-05 Thread Jakob Bornecrantz
Reviewed-by: Jakob Bornecrantz - Original Message - > The advantage of kcalloc is, that will prevent integer overflows > which could result from the multiplication of number of elements > and size and it is also a bit nicer to read. > > The semantic patch that makes

Radeon support state in libkms

2011-02-11 Thread Jakob Bornecrantz
On Wed, Feb 9, 2011 at 7:35 PM, Corbin Simpson wrote: > On Wed, Feb 9, 2011 at 6:49 AM, James Simmons > wrote: >> >>> I was looking at the radeon support state in libkms and I found out the >>> following patch was proposed back in September, but never commented nor >>> merged. The patch was subm

[PATCH] i915: Fix comments about cube layouts

2010-04-13 Thread Jakob Bornecrantz
--- src/mesa/drivers/dri/i915/i915_tex_layout.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i915/i915_tex_layout.c b/src/mesa/drivers/dri/i915/i915_tex_layout.c index 7026552..c98dede 100644 --- a/src/mesa/drivers/dri/i915/i915_tex_layout.c ++

Radeon support state in libkms

2011-02-17 Thread Jakob Bornecrantz
On Wed, Feb 16, 2011 at 7:40 PM, nobled wrote: > On Tue, Feb 15, 2011 at 9:17 AM, Alexandre Demers > wrote: >> On 11-02-11 06:21 AM, Jakob Bornecrantz wrote: >>> On Wed, Feb 9, 2011 at 7:35 PM, Corbin Simpson >>> wrote: >>>> On Wed, Feb 9, 2011 at 6:4

[PATCH] kms: Allow compiling libkms without Intel support

2013-04-12 Thread Jakob Bornecrantz
Oh, how very x86 centric of me, the changes are Reviewed-by Jakob Bornecrantz Cheers, Jakob. On Fri, Apr 12, 2013 at 4:07 PM, Laurent Pinchart < laurent.pinchart at ideasonboard.com> wrote: > Signed-off-by: Laurent Pinchart > --- > libkms/Makefile.am | 5 - > libk

[PATCH 1/2] drm: call pci_disable_device on module onload

2012-06-08 Thread Jakob Bornecrantz
On Fri, Jun 8, 2012 at 4:52 PM, Daniel Vetter wrote: > Otherwise we'll nicely leak this reference counter. Now thanks to the > awesome layering in the drm core, the enable call is done by the pci > boilerplate in drm_pci.c. But the disable can't be done without adding > yet another neat indirectio

[PATCH] Only build test programs with make check

2012-03-17 Thread Jakob Bornecrantz
With my limited knowledge of automake I'm going to have to NACK this patch. Most of these programs are used during driver bring up to test things out, often we also modify them a bit to suit our need. If this patch doesn't make this any harder then disregard my NACK. Cheers Jakob. - Original

[PATCH 0/7] drm: Return -ENOENT when objects can't be found

2013-10-17 Thread Jakob Bornecrantz
> drm/vmwgfx: Return -ENOENT when a mode object can't be found > drm/vmwgfx: Return -ENOENT when a framebuffer can't be found Sounds good to me, vmwgfx patches are: Reviewed-By: Jakob Bornecrantz Cheers, Jakob.

[PATCH] drm/ttm: Handle in memory region copies

2013-10-18 Thread Jakob Bornecrantz
Reviewed-by: Thomas Hellstr?m Signed-off-by: Jakob Bornecrantz Cc: Dave Airlie Cc: dri-devel at lists.freedesktop.org Cc: stable at vger.kernel.org --- drivers/gpu/drm/ttm/ttm_bo_util.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b

TTM Locking order of bo::reserve -> vm::mmap_sem

2013-10-21 Thread Jakob Bornecrantz
On Mon, Oct 21, 2013 at 10:48 AM, Thomas Hellstrom wrote: > Hi! > > As discussed previously the current locking order in TTM of these locks is > bo::reserve -> vm::mmap_sem. This leads to a hack in > the TTM fault() handle to try and revert the locking order. If a tryreserve > failed, we tried to

[PATCH] drm/ttm: Make NO_EVICT bos available to shrinkers pending destruction

2013-10-29 Thread Jakob Bornecrantz
; Signed-off-by: Thomas Hellstrom Reviewed-by: Jakob Bornecrantz > --- > drivers/gpu/drm/ttm/ttm_bo.c | 14 +- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c > index f1a857e..6c1a38f

[PATCH] drm/ttm: Allow vm fault retries

2013-10-29 Thread Jakob Bornecrantz
ts.. > > Signed-off-by: Thomas Hellstrom Reviewed-by: Jakob Bornecrantz Tho somebody else should also take a look at this. > --- > drivers/gpu/drm/ttm/ttm_bo_vm.c | 62 > +++ > 1 file changed, 50 insertions(+), 12 deletions(-) >

[PATCH] drm/ttm: Don't clear page metadata of imported sg pages

2014-02-05 Thread Jakob Bornecrantz
om > --- > drivers/gpu/drm/ttm/ttm_tt.c |3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Jakob Bornecrantz > > diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c > index 9af9908..75f3190 100644 > --- a/drivers/gpu/drm/ttm/ttm_tt.c > +

[PATCH 82/85] drivers: gpu: Mark functions as static in vmwgfx_kms.c

2014-01-07 Thread Jakob Bornecrantz
mwgfx_kms.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) This and patch 83, 84, 85 are Reviewed-by: Jakob Bornecrantz Cheers, Jakob.

[patch] tests/kmstest: support exynos

2014-01-07 Thread Jakob Bornecrantz
/main.c |1 + > 3 files changed, 7 insertions(+) Reviewed-by: Jakob Bornecrantz Do you need somebody to push this to the drm repo? Cheers, Jakob.

[PATCH] drm/vmwgfx: Fix incorrect write to read-only register

2014-07-03 Thread Jakob Bornecrantz
pher Friedt > Signed-off-by: Thomas Hellstrom > --- > drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Jakob Bornecrantz > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c > b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c > index a89ad93..b031b48 100

[PATCH 2/4] drm/doc: integrate crtc helper api into docbook

2012-11-01 Thread Jakob Bornecrantz
On Thu, Nov 1, 2012 at 2:45 PM, Daniel Vetter wrote: > - Add the missing doc for drm_helper_move_panel_connectors_to_head. > - Fixup any outdated stuff in existing sections. I've only looked at > those kerneldoc headers that actually resulted in a complaint from > the kerneldoc parser tool. >

[PATCH] kms: Return a negative error code in kms_bo_create()

2012-11-02 Thread Jakob Bornecrantz
to detect > errors with a < 0 check. > > Signed-off-by: Laurent Pinchart Reviewed-by: Jakob Bornecrantz

[PATCH] kms: Make libkms.h usable in C++

2012-11-02 Thread Jakob Bornecrantz
On Thu, Nov 1, 2012 at 10:40 AM, Laurent Pinchart wrote: > Wrap the header in extern "C" { ... };. > > Signed-off-by: Laurent Pinchart Reviewed-by: Jakob Bornecrantz

dma-buf non-coherent mmap

2013-11-01 Thread Jakob Bornecrantz
On Fri, Nov 1, 2013 at 12:00 AM, Daniel Vetter wrote: > On Thu, Oct 31, 2013 at 10:07:25PM +0100, Thomas Hellstrom wrote: >> On 10/31/2013 09:48 PM, Dave Airlie wrote: >> >On Fri, Nov 1, 2013 at 6:40 AM, Thomas Hellstrom >> >wrote: >> >>Well, I'd be happy to avoid mmap, but then what does option

dma-buf non-coherent mmap

2013-11-01 Thread Jakob Bornecrantz
On Fri, Nov 1, 2013 at 1:25 AM, Rob Clark wrote: > On Thu, Oct 31, 2013 at 8:17 PM, Jakob Bornecrantz > wrote: >> On Fri, Nov 1, 2013 at 12:00 AM, Daniel Vetter wrote: >>> On Thu, Oct 31, 2013 at 10:07:25PM +0100, Thomas Hellstrom wrote: >>>> On 10/31/2013 09:4

[PATCH] drm/ttm: Don't move non-existing data

2013-11-18 Thread Jakob Bornecrantz
rom old stuff. So instead of a NOP, which would > be the most efficient, just clear the destination. > > Signed-off-by: Thomas Hellstrom Reviewed-by: Jakob Bornecrantz Cheers, Jakob. > --- > drivers/gpu/drm/ttm/ttm_bo_util.c |7 +-- > 1 file changed, 5 insertions(+

[PATCH] drm/ttm: Remove set_need_resched from the ttm fault handler

2013-11-18 Thread Jakob Bornecrantz
tablish the > locking order as mmap_sem -> bo::reserve. > > One slight issue that remains with this code is that the fault handler might > be prone to starvation if another thread countinously reserves the buffer. > IMO that usage pattern is highly unlikely. > > Signed-o

[PATCH 2/3] drm/vmwgfx: Don't access file_priv in cursor_set when handle==0

2013-06-03 Thread Jakob Bornecrantz
Thanks, looks good and is Reviewed-by: Jakob Bornecrantz Cheers, Jakob. On Mon, Jun 3, 2013 at 3:10 PM, wrote: > From: Ville Syrj?l? > > We want to disable the cursor by calling ->cursor_set() with handle=0 > from places where we don't have a file_priv, so don't