Re: [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver

2021-07-21 Thread Jagan Teki
I9341_MADCTL_MV; > + break; > + case 180: > + addr_mode = ILI9341_MADCTL_MY; > + break; > + case 270: > + addr_mode = ILI9341_MADCTL_MV | ILI9341_MADCTL_MY | > + ILI9341_MADCTL_MX; > + break; > + } > + addr_mode |= ILI9341_MADCTL_BGR; > + mipi_dbi_command(dbi, MIPI_DCS_SET_ADDRESS_MODE, addr_mode); > + mipi_dbi_enable_flush(dbidev, crtc_state, plane_state); > + DRM_DEBUG_KMS("initialized display serial interface\n"); > +out_exit: > + drm_dev_exit(idx); > +} > + > +static const struct drm_simple_display_pipe_funcs ili9341_dbi_funcs = { > + .enable = ili9341_dbi_enable, > + .disable = mipi_dbi_pipe_disable, > + .update = mipi_dbi_pipe_update, > + .prepare_fb = drm_gem_simple_display_pipe_prepare_fb, > +}; > + > +static const struct drm_display_mode ili9341_dbi_mode = { > + DRM_SIMPLE_MODE(240, 320, 37, 49), > +}; > + > +DEFINE_DRM_GEM_CMA_FOPS(ili9341_dbi_fops); > + > +static struct drm_driver ili9341_dbi_driver = { > + .driver_features= DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, > + .fops = &ili9341_dbi_fops, > + DRM_GEM_CMA_DRIVER_OPS_VMAP, > + .debugfs_init = mipi_dbi_debugfs_init, > + .name = "ili9341", > + .desc = "Ilitek ILI9341", > + .date = "20210716", > + .major = 1, > + .minor = 0, > +}; > + > +static int _ili9341_probe(struct spi_device *spi, bool dpi) > +{ > + struct gpio_desc *dc; > + struct gpio_desc *reset; > + struct device *dev = &spi->dev; > + int ret; > + > + reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); > + if (IS_ERR(reset)) > + DRM_DEV_ERROR(dev, "Failed to get gpio 'reset'\n"); > + > + dc = devm_gpiod_get_optional(dev, "dc", GPIOD_OUT_LOW); > + if (IS_ERR(dc)) > + DRM_DEV_ERROR(dev, "Failed to get gpio 'dc'\n"); Small nit. Moving the above dts parse code into the main probe and have functions for dpi and !dpi would make code more readable. Otherwise, Reviewed-by: Jagan Teki

Re: [PATCH 02/10] drm/bridge: Add a function to abstract away panels

2021-07-22 Thread Jagan Teki
Hi Maxime, On Tue, Jul 20, 2021 at 7:15 PM Maxime Ripard wrote: > > Display drivers so far need to have a lot of boilerplate to first > retrieve either the panel or bridge that they are connected to using > drm_of_find_panel_or_bridge(), and then either deal with each with ad-hoc > functions or c

Re: [PATCH 05/10] drm/panel: Create attach and detach callbacks

2021-07-22 Thread Jagan Teki
Hi Maxime, On Tue, Jul 20, 2021 at 7:15 PM Maxime Ripard wrote: > > In order to make the probe order expectation more consistent between > bridges, let's create attach and detach hooks for the panels as well to > match what is there for bridges. > > Signed-off-by: Maxime Ripard > --- > drivers/

Re: [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver

2021-07-22 Thread Jagan Teki
Hi Dillon, On Thu, Jul 22, 2021 at 4:38 AM Dillon Min wrote: > > Hi Jagan > > Thanks for your time to review my code. > > On Wed, 21 Jul 2021 at 23:48, Jagan Teki wrote: > > > > On Wed, Jul 21, 2021 at 1:11 PM wrote: > > > > > > From: Dillon Min

Re: [RFC PATCH 00/17] drm: bridge: Samsung MIPI DSIM bridge

2021-07-25 Thread Jagan Teki
Hi Sam, On Sun, Jul 25, 2021 at 10:35 PM Sam Ravnborg wrote: > > Hi Jagan, > > On Sun, Jul 04, 2021 at 02:32:13PM +0530, Jagan Teki wrote: > > This series supports common bridge support for Samsung MIPI DSIM > > which is used in Exynos and i.MX8MM SoC's. > >

[PATCH v2] drm/panel: panel-simple: Fix proper bpc for ytc700tlag_05_201c

2021-07-25 Thread Jagan Teki
ytc700tlag_05_201c panel support 8 bpc not 6 bpc as per recent testing in i.MX8MM platform. Fix it. Signed-off-by: Jagan Teki --- Changes for v2: - none drivers/gpu/drm/panel/panel-simple.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel

Re: [RFC PATCH 06/17] drm/exynos: dsi: Handle exynos specifics via driver_data

2021-07-25 Thread Jagan Teki
On Sun, Jul 25, 2021 at 10:55 PM Sam Ravnborg wrote: > > On Sun, Jul 04, 2021 at 02:32:19PM +0530, Jagan Teki wrote: > > Exynos DSI driver is actually a Samsung MIPI DSIM bridge > > IP which is also used in i.MX8MM platforms. > > > > Right now the existing drive

[PATCH v3] drm/panel: panel-simple: Fix proper bpc for ytc700tlag_05_201c

2021-07-25 Thread Jagan Teki
ytc700tlag_05_201c panel support 8 bpc not 6 bpc as per recent testing in i.MX8MM platform. Fix it. Fixes: 7a1f4fa4a629 ("drm/panel: simple: Add YTC700TLAG-05-201C") Signed-off-by: Jagan Teki --- Changes for v3: - add fixes tag Changes for v2: - none drivers/gpu/drm/panel/panel-si

Re: [PATCH 04/10] drm/bridge: Document the probe issue with MIPI-DSI bridges

2021-07-27 Thread Jagan Teki
On Tue, Jul 20, 2021 at 7:15 PM Maxime Ripard wrote: > > Interactions between bridges, panels, MIPI-DSI host and the component > framework are not trivial and can lead to probing issues when > implementing a display driver. Let's document the various cases we need > too consider, and the solution

Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for SN65DSI83/84/85

2021-04-08 Thread Jagan Teki
On Wed, Mar 24, 2021 at 7:26 PM Claudius Heine wrote: > > Hi Jagan, > > On 2021-02-14 18:44, Jagan Teki wrote: > > SN65DSI83/84/85 devices are MIPI DSI to LVDS based bridge > > controller IC's from Texas Instruments. > > > > SN65DSI83 - Single Channel DSI

Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for SN65DSI83/84/85

2021-04-22 Thread Jagan Teki
On Thu, Apr 22, 2021 at 4:04 AM Marek Vasut wrote: > > On 4/8/21 4:45 PM, Jagan Teki wrote: > > On Wed, Mar 24, 2021 at 7:26 PM Claudius Heine wrote: > >> > >> Hi Jagan, > >> > >> On 2021-02-14 18:44, Jagan Teki wrote: > >>&g

Re: [PATCH V2 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 bindings

2021-04-22 Thread Jagan Teki
On Thu, Apr 22, 2021 at 4:01 AM Marek Vasut wrote: > > Add DT binding document for TI SN65DSI83 and SN65DSI84 DSI to LVDS bridge. > > Signed-off-by: Marek Vasut > Cc: Douglas Anderson > Cc: Jagan Teki > Cc: Laurent Pinchart > Cc: Linus Walleij > Cc: Rob Herrin

Re: [PATCH V2 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-04-28 Thread Jagan Teki
tor is not implemented, but it is > >>>> easy to add if ever needed. Only RGB888 pixel format is implemented, the > >>>> LVDS666 is not supported, but could be added if needed. > >>>> > >>>> Signed-off-by: Marek Vasut > >

Re: [PATCH 04/10] drm/bridge: Document the probe issue with MIPI-DSI bridges

2021-08-05 Thread Jagan Teki
Hi Maxime, On Wed, Jul 28, 2021 at 7:05 PM Maxime Ripard wrote: > > Hi Jagan, > > On Tue, Jul 27, 2021 at 03:12:09PM +0530, Jagan Teki wrote: > > On Tue, Jul 20, 2021 at 7:15 PM Maxime Ripard wrote: > > > > > > Interactions between bridges, pan

Re: [PATCH v2 0/8] drm/bridge: Make panel and bridge probe order consistent

2021-08-09 Thread Jagan Teki
Hi Andrzej, On Wed, Aug 4, 2021 at 7:48 PM a.hajda wrote: > > Hi Maxime, > > I have been busy with other tasks, and I did not follow the list last > time, so sorry for my late response. > > On 28.07.2021 15:32, Maxime Ripard wrote: > > Hi, > > > > We've encountered an issue with the RaspberryPi D

Re: [RFC PATCH 05/11] drm/bridge: ti-sn65dsi86: Wrap panel with panel-bridge

2021-03-22 Thread Jagan Teki
all components in the display pipeline to be represented by > bridges. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Jagan Teki ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [RFC PATCH 02/11] drm/bridge: ti-sn65dsi86: Make enable GPIO optional

2021-03-22 Thread Jagan Teki
On Mon, Mar 22, 2021 at 8:32 AM Laurent Pinchart wrote: > > The enable signal may not be controllable by the kernel. Make it > optional. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Jagan Teki ___ dri-devel mail

Re: [RFC PATCH 01/11] dt-bindings: drm/bridge: ti-sn65dsi8: Make enable GPIO optional

2021-03-22 Thread Jagan Teki
On Mon, Mar 22, 2021 at 8:32 AM Laurent Pinchart wrote: > > The SN65DSI86 EN pin can be hardwired to a high level, or connected to a > global reset signal, not controllable by the kernel. Make it optional in > those cases. > > Signed-off-by: Laurent Pinchart > --- Re

[PATCH v5 1/2] dt-bindings: display: bridge: Add Chipone ICN6211 bindings

2021-03-22 Thread Jagan Teki
ICN6211 is MIPI-DSI to RGB Converter bridge from Chipone. It has a flexible configuration of MIPI DSI signal input and produces RGB565, RGB666, RGB888 output format. Add dt-bingings for it. Signed-off-by: Jagan Teki Reviewed-by: Robert Foss Reviewed-by: Rob Herring --- Changes for v5

[PATCH v5 2/2] drm: bridge: Add Chipone ICN6211 MIPI-DSI to RGB bridge

2021-03-22 Thread Jagan Teki
ICN6211 is MIPI-DSI to RGB Converter bridge from Chipone. It has a flexible configuration of MIPI DSI signal input and produce RGB565, RGB666, RGB888 output format. Add bridge driver for it. Signed-off-by: Jagan Teki Reviewed-by: Robert Foss --- Changes for v5: - rebase drm-misc-next

[PATCH v4 2/4] drm: sun4i: dsi: Add bridge support

2021-03-22 Thread Jagan Teki
bridge functionalities in Allwinner DSI controller. Cc: Samuel Holland Signed-off-by: Jagan Teki --- Note: Samuel Holland, The existing kms hotplug dropped in order to attach the bridge properly. However, I did try several ways to support hotplug with the bridge but it's resulting in a dea

[PATCH v4 0/4] drm: sun4i: dsi: Convert drm bridge

2021-03-22 Thread Jagan Teki
ts on this would be appreciated! Jagan. Jagan Teki (4): drm: sun4i: dsi: Use drm_of_find_panel_or_bridge drm: sun4i: dsi: Add bridge support drm: sun4i: dsi: Convert to bridge driver [DO NOT MERGE] ARM: dts: sun8i: bananapi-m2m: Enable S070WV20-CT16 panel arch/arm/boot/dts/sun8i-r16-banana

[PATCH v4 3/4] drm: sun4i: dsi: Convert to bridge driver

2021-03-22 Thread Jagan Teki
DRM bridge drivers have build-in handling of treating all display pipeline components as bridges. So, convert the existing to a drm bridge driver with a built-in encoder support for compatibility with existing component drivers. Signed-off-by: Jagan Teki --- Changes for v4: - none Changes for

[DO NOT MERGE] [PATCH v4 4/4] ARM: dts: sun8i: bananapi-m2m: Enable S070WV20-CT16 panel

2021-03-22 Thread Jagan Teki
bridge enable gpio pin - PB7 gpio for lcd enable gpio pin - PL4 gpio for backlight enable pin Signed-off-by: Jagan Teki --- Changes for v4: - replace reset with enable-gpios Changes for v3: - none arch/arm/boot/dts/sun8i-r16-bananapi-m2m.dts | 85 1 file changed, 85

[PATCH v4 1/4] drm: sun4i: dsi: Use drm_of_find_panel_or_bridge

2021-03-22 Thread Jagan Teki
Replace of_drm_find_panel with drm_of_find_panel_or_bridge for finding panel, this indeed help to find the bridge if bridge support added. Added NULL in bridge argument, same will replace with bridge parameter once bridge supported. Signed-off-by: Jagan Teki --- Changes for v4, v3: - none

Re: [PATCH v4 1/4] drm: sun4i: dsi: Use drm_of_find_panel_or_bridge

2021-03-24 Thread Jagan Teki
On Wed, Mar 24, 2021 at 8:18 AM Samuel Holland wrote: > > On 3/23/21 5:53 PM, Laurent Pinchart wrote: > > Hi Jagan, > > > > Thank you for the patch. > > > > On Mon, Mar 22, 2021 at 07:31:49PM +0530, Jagan Teki wrote: > >> Replace of_drm_find_panel with

Re: [PATCH v4 1/4] drm: sun4i: dsi: Use drm_of_find_panel_or_bridge

2021-03-24 Thread Jagan Teki
Hi Laurent, On Wed, Mar 24, 2021 at 3:09 PM Laurent Pinchart wrote: > > Hi Jagan, > > On Wed, Mar 24, 2021 at 02:44:57PM +0530, Jagan Teki wrote: > > On Wed, Mar 24, 2021 at 8:18 AM Samuel Holland wrote: > > > On 3/23/21 5:53 PM, Laurent Pinchart wrote: > > >

[PATCH 1/2] dt-bindings: display: bridge: Add documentation for SN65DSI84

2021-01-20 Thread Jagan Teki
documented with single link LVDS. Signed-off-by: Jagan Teki --- .../bindings/display/bridge/ti,sn65dsi84.yaml | 127 ++ 1 file changed, 127 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/ti,sn65dsi84.yaml diff --git a/Documentation/devicetree

[PATCH 2/2] drm: bridge: Add SN65DSI84 DSI to LVDS bridge

2021-01-20 Thread Jagan Teki
STM32MP1 MIPI DSI host design configuration. Signed-off-by: Matteo Lisi Signed-off-by: Jagan Teki --- MAINTAINERS | 6 + drivers/gpu/drm/bridge/Kconfig| 19 + drivers/gpu/drm/bridge/Makefile | 1 + drivers/gpu/drm/bridge/ti-sn65dsi84.c | 488

Re: [PATCH 2/2] drm: bridge: Add SN65DSI84 DSI to LVDS bridge

2021-01-20 Thread Jagan Teki
On Wed, Jan 20, 2021 at 4:55 PM Michael Nazzareno Trimarchi wrote: > > Hi Jagan > > On Wed, Jan 20, 2021 at 12:22 PM Jagan Teki > wrote: > > > > SN65DSI84 is a Single Channel DSI to Dual-link LVDS bridge from > > Texas Instruments. > > > > SN65DSI83,

[PATCH v2 1/2] dt-bindings: display: bridge: Add documentation for SN65DSI84

2021-02-02 Thread Jagan Teki
documented with single link LVDS. Signed-off-by: Jagan Teki --- Changes for v2: - none .../bindings/display/bridge/ti,sn65dsi84.yaml | 127 ++ 1 file changed, 127 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/ti,sn65dsi84.yaml diff --git a

[PATCH v2 2/2] drm: bridge: Add SN65DSI84 DSI to LVDS bridge

2021-02-02 Thread Jagan Teki
STM32MP1 MIPI DSI host design configuration. Signed-off-by: Jagan Teki --- Changes for v2: - dropped the mdelays between commands as delays in init script in datasheet is based Aardvark I2C host adaptor. https://e2e.ti.com/support/interface/f/138/t/974276 MAINTAINERS

[PATCH] drm/bridge: dw-mipi-dsi: Move drm_bridge_add into probe

2021-02-03 Thread Jagan Teki
component binding operations for stm drm drivers. Option 1 is a relatively possible solution as most of the mainline drm dsi with bridge drivers have a similar approach to their dsi host vs bridge registration. Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 35

Re: [PATCH v2 2/2] drm: bridge: Add SN65DSI84 DSI to LVDS bridge

2021-02-04 Thread Jagan Teki
On Wed, Feb 3, 2021 at 2:51 PM Michael Nazzareno Trimarchi wrote: > > Hi > > On Wed, Feb 3, 2021 at 8:13 AM Jagan Teki wrote: > > > > SN65DSI84 is a Single Channel DSI to Dual-link LVDS bridge from > > Texas Instruments. > > > > SN65DSI83, SN65DSI85

Re: [PATCH v2 2/2] drm: bridge: Add SN65DSI84 DSI to LVDS bridge

2021-02-05 Thread Jagan Teki
On Fri, Feb 5, 2021 at 4:50 AM Marek Vasut wrote: > > On 2/4/21 11:29 PM, Laurent Pinchart wrote: > > Hi Jagan, > > > > Thank you for the patch. > > > > On Wed, Feb 03, 2021 at 12:42:56PM +0530, Jagan Teki wrote: > >> SN65DSI84 is a Single Channel

[PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for SN65DSI83/84/85

2021-02-14 Thread Jagan Teki
er is supporting Channel A with single link, so dt-bindings documented according to it. Cc: Marek Vasut Signed-off-by: Jagan Teki --- Changes for v3: - fixed Rob comments - updated commit message and file name to support all chip variants Changes for v2: - none .../bindings/display/brid

[PATCH v3 2/2] drm: bridge: Add TI SN65DSI83/84/85 DSI to LVDS bridge

2021-02-14 Thread Jagan Teki
ridge configuration for Channel A, which is a common configuration across all the bridge variants. Add bridge driver for it. Cc: Marek Vasut Signed-off-by: Jagan Teki --- Changes for v3: - updated macro names to reflect datasheet - add compatible for 83, 84 variants - updated comments, kconfig - fixe

[PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for Chipone ICN6211

2021-02-14 Thread Jagan Teki
ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone. It has a flexible configuration of MIPI DSI signal input and produce RGB565, RGB666, RGB888 output format. Add dt-bingings for it. Signed-off-by: Jagan Teki --- Changes for v3: - updated to new dt-bindings style .../display/bridge

[PATCH v3 2/2] drm: bridge: Add Chipone ICN6211 MIPI-DSI to RGB bridge

2021-02-14 Thread Jagan Teki
ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone. It has a flexible configuration of MIPI DSI signal input and produce RGB565, RGB666, RGB888 output format. Add bridge driver for it. Signed-off-by: Jagan Teki --- Changes for v3: - updated the driver to inline with new drm bridge style

[PATCH v3 0/7] drm: sun4i: dsi: Convert drm bridge

2021-02-14 Thread Jagan Teki
several ways to support hotplug with the bridge but it's resulting in a deadlock where bind never attach bridge until bridge pointer found and bridge pointer cannot found until bind finishes. Any inputs on this would be appreciated. [1] https://lwn.net/Articles/783127/ Any inputs? Jagan.

[PATCH v3 1/7] drm: sun4i: dsi: Use drm_of_find_panel_or_bridge

2021-02-14 Thread Jagan Teki
Replace of_drm_find_panel with drm_of_find_panel_or_bridge for finding panel, this indeed help to find the bridge if bridge support added. Added NULL in bridge argument, same will replace with bridge parameter once bridge supported. Signed-off-by: Jagan Teki --- Changes for v3: - none drivers

[PATCH v3 2/7] drm: sun4i: dsi: Add bridge support

2021-02-14 Thread Jagan Teki
bridge functionalities in Allwinner DSI controller. Cc: Samuel Holland Signed-off-by: Jagan Teki --- Note: Samuel Holland, The existing kms hotplug dropped in order to attach the bridge properly. However, I did try several ways to support hotplug with the bridge but it's resulting in a dea

[PATCH v3 3/7] drm: sun4i: dsi: Convert to bridge driver

2021-02-14 Thread Jagan Teki
DRM bridge drivers have build-in handling of treating all display pipeline components as bridges. So, convert the existing to a drm bridge driver with a built-in encoder support for compatibility with existing component drivers. Signed-off-by: Jagan Teki --- Changes for v3: - new patch

[PATCH v3 4/7] drm: sun4i: dsi: Separate code for bridge pre_enable

2021-02-14 Thread Jagan Teki
, this new enablement code separation will help to initialize the host and slave bridge pre_enable, enable functions properly. Signed-off-by: Jagan Teki --- Changes for v3: - new patch drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a

[PATCH v3 5/7] drm: bridge: Queue the bridge chain instead of stacking

2021-02-14 Thread Jagan Teki
bridge chain instead of stacking it so-that the bridges that got enqueued first can have a chance to trigger first. Cc: Maarten Lankhorst Cc: Thomas Zimmermann Signed-off-by: Jagan Teki --- Changes for v3: - new patch drivers/gpu/drm/drm_bridge.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v3 6/7] drm: sun4i: dsi: Use drm_panel_bridge, connector API

2021-02-14 Thread Jagan Teki
drm_bridge. This allows splitting connector operations across multiple bridges when necessary, instead of having the last bridge in the chain creating the connector and handling all connector operations internally. Signed-off-by: Jagan Teki --- Changes for v3: - new patch drivers/gpu/drm/sun4i

[DO NOT MERGE] [PATCH v3 7/7] ARM: dts: sun8i: bananapi-m2m: Enable S070WV20-CT16 panel

2021-02-14 Thread Jagan Teki
bridge reset gpio pin - PB7 gpio for lcd enable gpio pin - PL4 gpio for backlight enable pin Signed-off-by: Jagan Teki --- Changes for v3: - none arch/arm/boot/dts/sun8i-r16-bananapi-m2m.dts | 85 1 file changed, 85 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-r16

Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for SN65DSI83/84/85

2021-02-15 Thread Jagan Teki
On Mon, Feb 15, 2021 at 2:32 PM Neil Armstrong wrote: > > Hi, > > On 14/02/2021 18:44, Jagan Teki wrote: > > SN65DSI83/84/85 devices are MIPI DSI to LVDS based bridge > > controller IC's from Texas Instruments. > > > > SN65DSI83 - Single Channel DSI

Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for Chipone ICN6211

2021-02-15 Thread Jagan Teki
, so I would suggest conforming to that just to > silence the checkpatch warning. > > This patch also passes 'dt_binding_check' and 'dtbs_check', but I > think I'd like to defer to Rob Herring for an actual r-b. > > On Sun, 14 Feb 2021 at 18:55, Jagan

Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for Chipone ICN6211

2021-02-24 Thread Jagan Teki
Hi Laurent, On Mon, Feb 15, 2021 at 5:48 PM Laurent Pinchart wrote: > > Hi Jagan, > > Thank you for the patch. > > On Sun, Feb 14, 2021 at 11:22:10PM +0530, Jagan Teki wrote: > > ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone. > > > > It has a flexi

Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for Chipone ICN6211

2021-02-24 Thread Jagan Teki
Hi Laurent, On Wed, Feb 24, 2021 at 6:44 PM Laurent Pinchart wrote: > > Hi Jagan, > > On Wed, Feb 24, 2021 at 06:07:43PM +0530, Jagan Teki wrote: > > On Mon, Feb 15, 2021 at 5:48 PM Laurent Pinchart wrote: > > > On Sun, Feb 14, 2021 at 11:22:10PM +0530, Jagan Teki wro

Re: [PATCH 2/2] drm: bridge: Add SN65DSI84 DSI to LVDS bridge

2021-02-24 Thread Jagan Teki
Hi Riadh, On Wed, Feb 17, 2021 at 8:44 PM Riadh Ghaddab wrote: > > Hi Jagan, > > On 20/01/2021 12:21, Jagan Teki wrote: > > SN65DSI84 is a Single Channel DSI to Dual-link LVDS bridge from > Texas Instruments. > > SN65DSI83, SN65DSI85 are variants of the same fam

Re: [PATCH] drm/bridge: dw-mipi-dsi: Move drm_bridge_add into probe

2021-02-24 Thread Jagan Teki
Hi Yannick, Thanks for testing this change. On Mon, Feb 15, 2021 at 1:39 PM yannick Fertre wrote: > > Hello Jagan, I tested your patch on the stm32mp1 board. > Unfortunately, the dsi panel does not probe well with this patch. The > problem is due to the panel which is placed in the node of the d

Re: [PATCH v3 6/7] drm: sun4i: dsi: Use drm_panel_bridge, connector API

2021-02-26 Thread Jagan Teki
On Fri, Feb 26, 2021 at 10:27 PM Maxime Ripard wrote: > > Hi, > > On Mon, Feb 15, 2021 at 01:11:01AM +0530, Jagan Teki wrote: > > Use drm_panel_bridge to replace manual panel handling code. > > > > This simplifies the driver to allows all components in the > &g

Re: [PATCH v3 6/7] drm: sun4i: dsi: Use drm_panel_bridge, connector API

2021-03-02 Thread Jagan Teki
On Tue, Mar 2, 2021 at 10:05 PM Maxime Ripard wrote: > > On Fri, Feb 26, 2021 at 10:40:24PM +0530, Jagan Teki wrote: > > On Fri, Feb 26, 2021 at 10:27 PM Maxime Ripard wrote: > > > > > > Hi, > > > > > > On Mon, Feb 15, 2021 at 01:11:01AM +0530, J

[PATCH] drm/stm: ltdc: Use simple encoder

2021-03-02 Thread Jagan Teki
STM ltdc driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. Signed-off-by: Jagan Teki --- drivers/gpu/drm/stm/ltdc.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm

Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for Chipone ICN6211

2021-03-03 Thread Jagan Teki
On Wed, Feb 24, 2021 at 6:44 PM Laurent Pinchart wrote: > > Hi Jagan, > > On Wed, Feb 24, 2021 at 06:07:43PM +0530, Jagan Teki wrote: > > On Mon, Feb 15, 2021 at 5:48 PM Laurent Pinchart wrote: > > > On Sun, Feb 14, 2021 at 11:22:10PM +0530, Jagan Teki wrote: > &g

Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for Chipone ICN6211

2021-03-04 Thread Jagan Teki
Hi Laurent, On Thu, Mar 4, 2021 at 4:29 AM Laurent Pinchart wrote: > > Hi Jagan, > > On Wed, Mar 03, 2021 at 08:08:35PM +0530, Jagan Teki wrote: > > On Wed, Feb 24, 2021 at 6:44 PM Laurent Pinchart wrote: > > > On Wed, Feb 24, 2021 at 06:07:43PM +0530, Jagan Teki wr

[PATCH v4 2/2] drm: bridge: Add Chipone ICN6211 MIPI-DSI to RGB bridge

2021-03-04 Thread Jagan Teki
ICN6211 is MIPI-DSI to RGB Converter bridge from Chipone. It has a flexible configuration of MIPI DSI signal input and produce RGB565, RGB666, RGB888 output format. Add bridge driver for it. Signed-off-by: Jagan Teki --- Changes for v4: - added regulators - replace reset with EN - fixed

[PATCH v4 1/2] dt-bindings: display: bridge: Add Chipone ICN6211 bindings

2021-03-04 Thread Jagan Teki
ICN6211 is MIPI-DSI to RGB Converter bridge from Chipone. It has a flexible configuration of MIPI DSI signal input and produces RGB565, RGB666, RGB888 output format. Add dt-bingings for it. Signed-off-by: Jagan Teki --- Changes for v4: - fixed Laurent comments - added regulators - replace

Re: [RFC PATCH 2/9] drm: bridge: Add Samsung SEC MIPI DSIM bridge driver

2021-06-30 Thread Jagan Teki
Hi Frieder, Thanks for sharing the details. On Mon, Jun 28, 2021 at 1:49 PM Frieder Schrempf wrote: > > Hi Jagan, > > On 24.06.21 10:30, Krzysztof Kozlowski wrote: > > On 24/06/2021 04:48, Fabio Estevam wrote: > >> Hi Jagan/Laurent, > >> > >> On Wed, Jun 23, 2021 at 7:23 PM Laurent Pinchart > >>

Re: [RFC PATCH 0/9] arm64: imx8mm: Add MIPI DSI support

2021-06-30 Thread Jagan Teki
Hi Peng, On Tue, Jun 29, 2021 at 12:40 PM Peng Fan (OSS) wrote: > > Hi Jagan, > > > Subject: [RFC PATCH 0/9] arm64: imx8mm: Add MIPI DSI support > > > > This series support MIPI DSI on i.MX8MM. > > > > It worked directly with existing mxsfb driver but the SEC DSIM timings has > > to > > be valid

Re: [PATCH] drm/panel: panel-simple: Fix proper bpc for ytc700tlag_05_201c

2021-07-01 Thread Jagan Teki
Hi Sam and Thierry, On Tue, May 25, 2021 at 12:12 AM Jagan Teki wrote: > > ytc700tlag_05_201c panel support 8 bpc not 6 bpc as per > recent testing in i.MX8MM platform. > > Fix it. > > Signed-off-by: Jagan Teki > --- > drivers/gpu/drm/panel/panel-simple.c | 2 +- >

[RFC PATCH 00/17] drm: bridge: Samsung MIPI DSIM bridge

2021-07-04 Thread Jagan Teki
appreciate anyone from the exynos team to test it on the exynos platform? Any inputs? Jagan. Jagan Teki (17): drm/exynos: dsi: Convert to bridge driver drm/exynos: dsi: Handle drm_device for bridge drm/exynos: dsi: Use the drm_panel_bridge API drm/exynos: dsi: Create bridge connector for enc

[RFC PATCH 01/17] drm/exynos: dsi: Convert to bridge driver

2021-07-04 Thread Jagan Teki
. Signed-off-by: Jagan Teki --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 57 + 1 file changed, 39 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index 1d777d8c1a83..90d2ce2c3055 100644 --- a

[RFC PATCH 02/17] drm/exynos: dsi: Handle drm_device for bridge

2021-07-04 Thread Jagan Teki
rve the drm_device in the bind call. 2. bridge case, the drm_bridge_attach will assign the drm_device into bridge->dev, so preserve the drm_device in the bridge_attach function call. Signed-off-by: Jagan Teki --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 17 - 1 file c

[RFC PATCH 03/17] drm/exynos: dsi: Use the drm_panel_bridge API

2021-07-04 Thread Jagan Teki
Use drm_panel_bridge to replace manual panel and bridge_chain handling code. This makes the driver simpler to allow all components in the display pipeline to be treated as bridges by cleaning the way to generic connector handling. Signed-off-by: Jagan Teki --- drivers/gpu/drm/exynos

[RFC PATCH 04/17] drm/exynos: dsi: Create bridge connector for encoder

2021-07-04 Thread Jagan Teki
connector operations internally. Signed-off-by: Jagan Teki --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index 24f0b082ac6d..d828be07c325

[RFC PATCH 05/17] drm/exynos: dsi: Get the mode from bridge

2021-07-04 Thread Jagan Teki
Now the exynos dsi driver is fully aware of bridge handling, so get the display mode from bridge, mode_set API instead of legacy encoder crtc. This makes bridge usage more efficient instead of relying on encoder stack. Add mode_set in drm_bridge_funcs. Signed-off-by: Jagan Teki --- drivers

[RFC PATCH 06/17] drm/exynos: dsi: Handle exynos specifics via driver_data

2021-07-04 Thread Jagan Teki
for option A in future. So, this patch is trying to add option B) changes to handle exynos specifics via driver_data. Signed-off-by: Jagan Teki --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 37 +++-- 1 file changed, 29 insertions(+), 8 deletions(-) diff --git a/drivers

[RFC PATCH 07/17] drm: bridge: Move exynos_drm_dsi into bridges

2021-07-04 Thread Jagan Teki
xynos drm maintainers along with Andrzej as he is the original author. Tomasz Figa has been not included in MAINTAINERS as he is not available via samsung.com. Signed-off-by: Jagan Teki --- MAINTAINERS | 11 + drivers/gpu/drm/bridge/Kconfig

[RFC PATCH 08/17] dt-bindings: display: bridge: Add Samsung MIPI DSIM bridge

2021-07-04 Thread Jagan Teki
msung,mipi-dsim.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung MIPI DSIM bridge controller + +maintainers: + - Inki Dae + - Joonyoung Shim + - Seung-Woo Kim + - Kyungmin Park + - Andrzej Hajda + - Jagan Teki + +description: | + Samsung MIPI DSIM bridge control

[RFC PATCH 09/17] drm: bridge: samsung-dsim: Add module init, exit

2021-07-04 Thread Jagan Teki
river is already registered. Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/samsung-dsim.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index eed6b3ffdea7..627580abd6df 100644

[RFC PATCH 10/17] drm: bridge: samsung-dsim: Update the of_node for port(s)

2021-07-04 Thread Jagan Teki
this patch will check if node is a port based and then update of_node. This way we can support the platforms which are using legacy or new DSI bindings. Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/samsung-dsim.c | 19 ++- 1 file changed, 14 insertions(+), 5 dele

[RFC PATCH 11/17] drm: bridge: samsung-dsim: Find the possible DSI devices

2021-07-04 Thread Jagan Teki
handle all these cases of finding the panel_or_bridge invoke the finding API in host attach and bridge attach with the DSIM_STATE_DEVICE_FOUND flag. This way we can handle all possible cases of finding the DSI devices. Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/samsung-dsim.c | 20

[RFC PATCH 12/17] dt-bindings: display: bridge: samsung, mipi-dsim: Add i.MX8MM support

2021-07-04 Thread Jagan Teki
Samsung MIPI DSIM bridge can also be found in i.MX8MM SoC. Add dt-bingings for it. Cc: Rob Herring Signed-off-by: Jagan Teki --- .../display/bridge/samsung,mipi-dsim.yaml | 84 ++- 1 file changed, 83 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree

[RFC PATCH 13/17] drm: bridge: samsung-dsim: Add i.MX8MM support

2021-07-04 Thread Jagan Teki
Samsung MIPI DSIM bridge can also be found in i.MX8MM SoC. Add compatible and associated driver_data it. Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/samsung-dsim.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b

[RFC PATCH 14/17] drm: bridge: samsung-dsim: Add input_bus_flags

2021-07-04 Thread Jagan Teki
eLCDIF is expecting to have input_bus_flags as DE_LOW in order to set active low during valid data transfer on each horizontal line. Add DE_LOW flag via drm bridge timings. Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/samsung-dsim.c | 5 + 1 file changed, 5 insertions(+) diff

[RFC PATCH 15/17] drm: bridge: samsung-dsim: Move DSI init in bridge enable

2021-07-04 Thread Jagan Teki
idges. So, move the DSI initialization from transfer to bridge enable as the bridge enable API as it is common across all classes of DSI device drivers. Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/samsung-dsim.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff

[RFC PATCH 16/17] drm: bridge: samsung-dsim: Fix PLL_P offset

2021-07-04 Thread Jagan Teki
value for i.MX8MM from the downstream driver. Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/samsung-dsim.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index 54767cbf231c

[RFC PATCH 17/17] drm: bridge: samsung-dsim: Add bridge mode_fixup

2021-07-04 Thread Jagan Teki
Fixing up the mode flags are required in order to correlate the correct sync flags in i.MX8MM eLCDIF. So, handle the mode flags via bridge, mode_fixup. Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/samsung-dsim.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers

[PATCH] drm: bridge: nwl-dsi: Drop unused nwl_dsi_plat_clk_config

2021-07-04 Thread Jagan Teki
nwl_dsi_plat_clk_config structure added in below commit but not used anywhere in the driver. commit <44cfc6233447c> ("drm/bridge: Add NWL MIPI DSI host controller support") Drop it. Cc: Guido Günther Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/nwl-dsi.c | 6 -- 1

[PATCH] drm: mxsfb: Support 24-bit SPWG, JEIDA bus formats

2021-07-04 Thread Jagan Teki
24-bit SPWG, JEIDA bus formats are considered as 24-bit bus widths for LCDC_CTRL register in mxsfb. Add support for it. Signed-off-by: Jagan Teki --- drivers/gpu/drm/mxsfb/mxsfb_kms.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c b/drivers/gpu/drm

Re: [PATCH] drm: mxsfb: Support 24-bit SPWG, JEIDA bus formats

2021-07-04 Thread Jagan Teki
Hi Marek, On Sun, Jul 4, 2021 at 3:23 PM Marek Vasut wrote: > > On 7/4/21 11:38 AM, Jagan Teki wrote: > > 24-bit SPWG, JEIDA bus formats are considered as 24-bit > > bus widths for LCDC_CTRL register in mxsfb. > > > > Add support for it. > > > > Signed

[PATCH] drm/stm: ltdc: Silence -EPROBE_DEFER till bridge attached

2021-07-04 Thread Jagan Teki
: [    3.099289] [drm:ltdc_load] *ERROR* init encoder endpoint 0 So, check the return value and cleanup the encoder only if it's not -EPROBE_DEFER. This make all components in the attached DSI bridge found properly. Signed-off-by: Jagan Teki --- drivers/gpu/drm/stm/ltdc.c | 8 +--- 1

[PATCH] drm/bridge: dw-mipi-dsi: Find the possible DSI devices

2021-07-04 Thread Jagan Teki
dw_mipi_dsi_bridge_attach(). done ltdc_encoder_init().done So, invoke the panel_or_bridge from host attach and bridge attach in order to find all possible DSI devices. Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 58 ++- 1 file changed, 43 insertions

Re: Questions over DSI within DRM.

2021-07-05 Thread Jagan Teki
On Fri, Jul 2, 2021 at 10:12 PM Laurent Pinchart wrote: > > Hi Dave, > > (Expanding the CC list a bit) > > On Fri, Jul 02, 2021 at 12:03:31PM +0100, Dave Stevenson wrote: > > Hi All > > > > I'm trying to get DSI devices working reliably on the Raspberry Pi, > > but I'm hitting a number of places w

Re: [RFC PATCH 03/17] drm/exynos: dsi: Use the drm_panel_bridge API

2021-07-05 Thread Jagan Teki
On Mon, Jul 5, 2021 at 5:18 PM Marek Szyprowski wrote: > > On 04.07.2021 11:02, Jagan Teki wrote: > > Use drm_panel_bridge to replace manual panel and > > bridge_chain handling code. > > > > This makes the driver simpler to allow all components > > in the displ

Re: [RFC PATCH 03/17] drm/exynos: dsi: Use the drm_panel_bridge API

2021-07-05 Thread Jagan Teki
On Mon, Jul 5, 2021 at 5:43 PM Marek Szyprowski wrote: > > On 05.07.2021 14:00, Jagan Teki wrote: > > On Mon, Jul 5, 2021 at 5:18 PM Marek Szyprowski > > wrote: > >> On 04.07.2021 11:02, Jagan Teki wrote: > >>> Use drm_panel_bridge to replace manual pan

Re: [PATCH 2/2 v3] drm/panel: ws2401: Add driver for WideChips WS2401

2021-07-09 Thread Jagan Teki
On Thu, Jul 8, 2021 at 5:25 AM Linus Walleij wrote: > > This adds a driver for panels based on the WideChips WS2401 display > controller. This display controller is used in the Samsung LMS380KF01 > display found in the Samsung GT-I8160 (Codina) mobile phone and > possibly others. > > As is common

Re: [PATCH] drm/panel: panel-simple: Fix proper bpc for ytc700tlag_05_201c

2021-07-09 Thread Jagan Teki
On Fri, Jul 2, 2021 at 10:58 AM Jagan Teki wrote: > > Hi Sam and Thierry, > > On Tue, May 25, 2021 at 12:12 AM Jagan Teki > wrote: > > > > ytc700tlag_05_201c panel support 8 bpc not 6 bpc as per > > recent testing in i.MX8MM platform. > > > &

Re: [RFC PATCH 08/17] dt-bindings: display: bridge: Add Samsung MIPI DSIM bridge

2021-07-12 Thread Jagan Teki
On Mon, Jul 12, 2021 at 8:43 PM Rob Herring wrote: > > On Sun, Jul 04, 2021 at 02:32:21PM +0530, Jagan Teki wrote: > > Samsing MIPI DSIM bridge can be found on Exynos and NXP's > > i.MX8M Mini and Nano SoC's. > > > > This dt-bindings replaces legacy exynos

Re: (subset) [PATCH] drm/bridge: parade-ps8622: switch to devm_drm_of_get_bridge

2022-03-08 Thread Jagan Teki
Hi Maxime, On Tue, Mar 8, 2022 at 4:51 PM Maxime Ripard wrote: > > On Mon, 28 Feb 2022 19:29:04 +0100, José Expósito wrote: > > The function "drm_of_find_panel_or_bridge" has been deprecated in > > favor of "devm_drm_of_get_bridge". > > > > Switch to the new function and reduce boilerplate. > > >

Re: [PATCH V3 05/13] drm: bridge: icn6211: Add DSI lane count DT property parsing

2022-03-08 Thread Jagan Teki
Hi Marek, On Tue, Mar 8, 2022 at 4:00 PM Marek Vasut wrote: > > On 3/8/22 11:07, Jagan Teki wrote: > > On Tue, Mar 8, 2022 at 3:19 PM Marek Vasut wrote: > >> > >> On 3/8/22 09:03, Jagan Teki wrote: > >> > >> Hi, > >> >

Re: [PATCH v6 0/6] drm: exynos: dsi: Convert drm bridge

2022-03-09 Thread Jagan Teki
Hi Frieder, On Wed, Mar 9, 2022 at 6:54 PM Frieder Schrempf wrote: > > Hi Jagan, > > Am 03.03.22 um 17:36 schrieb Jagan Teki: > > Updated series about drm bridge conversion of exynos dsi. > > > > Previous version can be accessible, here [1]. > > &g

Re: DSI Bridge switching

2022-03-09 Thread Jagan Teki
or a Hi All, On Thu, Oct 14, 2021 at 6:45 PM Jagan Teki wrote: > > Hi Laurent, > > On Fri, Oct 8, 2021 at 7:07 PM Laurent Pinchart > wrote: > > > > Hello, > > > > On Fri, Oct 08, 2021 at 03:27:43PM +0200, Andrzej Hajda wrote: > > > Hi, > >

Re: DSI Bridge switching

2022-03-10 Thread Jagan Teki
On Thu, Mar 10, 2022 at 6:15 AM Adam Ford wrote: > > On Wed, Mar 9, 2022 at 1:11 PM Jagan Teki wrote: > > > > or a Hi All, > > > > On Thu, Oct 14, 2021 at 6:45 PM Jagan Teki > > wrote: > > > > > > Hi Laurent, > > > >

Re: [PATCH V3 05/13] drm: bridge: icn6211: Add DSI lane count DT property parsing

2022-03-11 Thread Jagan Teki
2PM +0100, Marek Vasut wrote: > >>>>>>>> On 3/8/22 14:49, Maxime Ripard wrote: > >>>>>>>>> On Tue, Mar 08, 2022 at 02:27:40PM +0100, Marek Vasut wrote: > >>>>>>>>>> On 3/8/22 13:51, Maxime Ripard wrote: > &

Re: [PATCH V3 05/13] drm: bridge: icn6211: Add DSI lane count DT property parsing

2022-03-11 Thread Jagan Teki
Hi Marek, Small correction in the previous comment. On Sat, Mar 12, 2022 at 2:05 AM Jagan Teki wrote: > > Hi Marek, > > On Sat, Mar 12, 2022 at 1:32 AM Marek Vasut wrote: > > > > On 3/11/22 17:29, Maxime Ripard wrote: > > > On Fri, Mar 11, 2022 at 11:36:58AM +0

Re: [PATCH] drm: of: Properly try all possible cases for bridge/panel detection

2022-03-18 Thread Jagan Teki
Hi Paul, On Wed, Mar 9, 2022 at 8:02 PM Paul Kocialkowski wrote: > > While bridge/panel detection was initially relying on the usual > port/ports-based of graph detection, it was recently changed to > perform the lookup on any child node that is not port/ports > instead when such a node is availa

  1   2   3   4   5   6   7   8   9   10   >