[PATCH v2 0/7] New DRM driver for Intel VPU

2022-09-13 Thread Jacek Lawrynowicz
"drm/vpu" to "drm/ivpu" - Add a TODO file - Add support for WC buffers v1: https://lore.kernel.org/all/20220728131709.1087188-1-jacek.lawrynow...@linux.intel.com/ Regards, Jacek Jacek Lawrynowicz (7): drm/ivpu: Introduce a new DRM driver for Intel VPU drm/ivpu: Add Intel V

[PATCH v2 1/7] drm/ivpu: Introduce a new DRM driver for Intel VPU

2022-09-13 Thread Jacek Lawrynowicz
ludes only very besic functionality: - module, PCI device and IRQ initialization - register definitions and low level register manipulation functions - SET/GET_PARAM ioctls - power up without firmware Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz -

[PATCH v2 3/7] drm/ivpu: Add GEM buffer object management

2022-09-13 Thread Jacek Lawrynowicz
three new IOCTLs: BO_CREATE, BO_INFO, BO_USERPTR Signed-off-by: Jacek Lawrynowicz --- drivers/gpu/drm/ivpu/Makefile | 1 + drivers/gpu/drm/ivpu/ivpu_drv.c | 9 + drivers/gpu/drm/ivpu/ivpu_gem.c | 823 drivers/gpu/drm/ivpu/ivpu_gem.h | 128 + include

[PATCH v2 4/7] drm/ivpu: Add IPC driver and JSM messages

2022-09-13 Thread Jacek Lawrynowicz
The IPC driver is used to send and receive messages to/from firmware running on the VPU. The only supported IPC message format is Job Submission Model (JSM) defined in vpu_jsm_api.h header. Signed-off-by: Andrzej Kacprowski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz

[PATCH v2 2/7] drm/ivpu: Add Intel VPU MMU support

2022-09-13 Thread Jacek Lawrynowicz
ments a driver that programs the MMU device Signed-off-by: Karol Wachowski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz --- drivers/gpu/drm/ivpu/Makefile | 4 +- drivers/gpu/drm/ivpu/ivpu_drv.c | 59 +- drivers/gpu/drm/ivpu/ivpu_drv.h

[PATCH v2 5/7] drm/ivpu: Implement firmware parsing and booting

2022-09-13 Thread Jacek Lawrynowicz
Read, parse and boot VPU firmware image. Signed-off-by: Andrzej Kacprowski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz --- drivers/gpu/drm/ivpu/Makefile | 1 + drivers/gpu/drm/ivpu/ivpu_drv.c | 122 +++- drivers/gpu/drm/ivpu/ivpu_drv.h | 10

[PATCH v2 6/7] drm/ivpu: Add command buffer submission logic

2022-09-13 Thread Jacek Lawrynowicz
drm_sched. Signed-off-by: Andrzej Kacprowski Signed-off-by: Jacek Lawrynowicz --- drivers/gpu/drm/ivpu/Makefile | 1 + drivers/gpu/drm/ivpu/ivpu_drv.c | 26 +- drivers/gpu/drm/ivpu/ivpu_drv.h | 6 +- drivers/gpu/drm/ivpu/ivpu_gem.c | 13 + drivers/gpu/drm/ivpu/ivpu_job.c | 617

[PATCH v2 7/7] drm/ivpu: Add PM support

2022-09-13 Thread Jacek Lawrynowicz
- Implement cold and warm firmware boot flows - Add hang recovery support - Add runtime power management support Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz --- drivers/gpu/drm/ivpu/Makefile | 3 +- drivers/gpu/drm/ivpu/ivpu_drv.c| 34 ++- drivers/gpu

[PATCH v3 0/7] New DRM driver for Intel VPU

2022-09-22 Thread Jacek Lawrynowicz
0728131709.1087188-1-jacek.lawrynow...@linux.intel.com/ Jacek Lawrynowicz (7): drm/ivpu: Introduce a new DRM driver for Intel VPU drm/ivpu: Add Intel VPU MMU support drm/ivpu: Add GEM buffer object management drm/ivpu: Add IPC driver and JSM messages drm/ivpu: Implement firmware parsing an

[PATCH v3 1/7] drm/ivpu: Introduce a new DRM driver for Intel VPU

2022-09-22 Thread Jacek Lawrynowicz
ludes only very besic functionality: - module, PCI device and IRQ initialization - register definitions and low level register manipulation functions - SET/GET_PARAM ioctls - power up without firmware Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz -

[PATCH v3 2/7] drm/ivpu: Add Intel VPU MMU support

2022-09-22 Thread Jacek Lawrynowicz
ments a driver that programs the MMU device Signed-off-by: Karol Wachowski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz --- drivers/gpu/drm/ivpu/Makefile | 4 +- drivers/gpu/drm/ivpu/ivpu_drv.c | 59 +- drivers/gpu/drm/ivpu/ivpu_drv.h

[PATCH v3 3/7] drm/ivpu: Add GEM buffer object management

2022-09-22 Thread Jacek Lawrynowicz
three new IOCTLs: BO_CREATE, BO_INFO, BO_USERPTR Signed-off-by: Jacek Lawrynowicz --- drivers/gpu/drm/ivpu/Makefile | 1 + drivers/gpu/drm/ivpu/ivpu_drv.c | 9 + drivers/gpu/drm/ivpu/ivpu_gem.c | 823 drivers/gpu/drm/ivpu/ivpu_gem.h | 128 + include

[PATCH v3 5/7] drm/ivpu: Implement firmware parsing and booting

2022-09-22 Thread Jacek Lawrynowicz
Read, parse and boot VPU firmware image. Signed-off-by: Andrzej Kacprowski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz --- drivers/gpu/drm/ivpu/Makefile | 1 + drivers/gpu/drm/ivpu/ivpu_drv.c | 122 +++- drivers/gpu/drm/ivpu/ivpu_drv.h | 10

[PATCH v3 7/7] drm/ivpu: Add PM support

2022-09-22 Thread Jacek Lawrynowicz
- Implement cold and warm firmware boot flows - Add hang recovery support - Add runtime power management support Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz --- drivers/gpu/drm/ivpu/Makefile | 3 +- drivers/gpu/drm/ivpu/ivpu_drv.c| 34 ++- drivers/gpu

[PATCH v3 4/7] drm/ivpu: Add IPC driver and JSM messages

2022-09-22 Thread Jacek Lawrynowicz
The IPC driver is used to send and receive messages to/from firmware running on the VPU. The only supported IPC message format is Job Submission Model (JSM) defined in vpu_jsm_api.h header. Signed-off-by: Andrzej Kacprowski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz

[PATCH v3 6/7] drm/ivpu: Add command buffer submission logic

2022-09-22 Thread Jacek Lawrynowicz
drm_sched. Signed-off-by: Andrzej Kacprowski Signed-off-by: Jacek Lawrynowicz --- drivers/gpu/drm/ivpu/Makefile | 1 + drivers/gpu/drm/ivpu/ivpu_drv.c | 26 +- drivers/gpu/drm/ivpu/ivpu_drv.h | 6 +- drivers/gpu/drm/ivpu/ivpu_gem.c | 13 + drivers/gpu/drm/ivpu/ivpu_job.c | 617

[PATCH v3 RESEND 0/7] New DRM driver for Intel VPU

2022-09-24 Thread Jacek Lawrynowicz
Add support for WC buffers v1: https://lore.kernel.org/all/20220728131709.1087188-1-jacek.lawrynow...@linux.intel.com/ Jacek Lawrynowicz (7): drm/ivpu: Introduce a new DRM driver for Intel VPU drm/ivpu: Add Intel VPU MMU support drm/ivpu: Add GEM buffer object management drm/ivpu: Add IPC

[PATCH v3 1/7] drm/ivpu: Introduce a new DRM driver for Intel VPU

2022-09-24 Thread Jacek Lawrynowicz
ludes only very besic functionality: - module, PCI device and IRQ initialization - register definitions and low level register manipulation functions - SET/GET_PARAM ioctls - power up without firmware Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz -

[PATCH v3 3/7] drm/ivpu: Add GEM buffer object management

2022-09-24 Thread Jacek Lawrynowicz
three new IOCTLs: BO_CREATE, BO_INFO, BO_USERPTR Signed-off-by: Jacek Lawrynowicz --- drivers/gpu/drm/ivpu/Makefile | 1 + drivers/gpu/drm/ivpu/ivpu_drv.c | 9 + drivers/gpu/drm/ivpu/ivpu_gem.c | 823 drivers/gpu/drm/ivpu/ivpu_gem.h | 128 + include

[PATCH v3 7/7] drm/ivpu: Add PM support

2022-09-24 Thread Jacek Lawrynowicz
- Implement cold and warm firmware boot flows - Add hang recovery support - Add runtime power management support Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz --- drivers/gpu/drm/ivpu/Makefile | 3 +- drivers/gpu/drm/ivpu/ivpu_drv.c| 34 ++- drivers/gpu

[PATCH v3 2/7] drm/ivpu: Add Intel VPU MMU support

2022-09-24 Thread Jacek Lawrynowicz
ments a driver that programs the MMU device Signed-off-by: Karol Wachowski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz --- drivers/gpu/drm/ivpu/Makefile | 4 +- drivers/gpu/drm/ivpu/ivpu_drv.c | 59 +- drivers/gpu/drm/ivpu/ivpu_drv.h

[PATCH v3 6/7] drm/ivpu: Add command buffer submission logic

2022-09-24 Thread Jacek Lawrynowicz
drm_sched. Signed-off-by: Andrzej Kacprowski Signed-off-by: Jacek Lawrynowicz --- drivers/gpu/drm/ivpu/Makefile | 1 + drivers/gpu/drm/ivpu/ivpu_drv.c | 26 +- drivers/gpu/drm/ivpu/ivpu_drv.h | 6 +- drivers/gpu/drm/ivpu/ivpu_gem.c | 13 + drivers/gpu/drm/ivpu/ivpu_job.c | 617

[PATCH v3 4/7] drm/ivpu: Add IPC driver and JSM messages

2022-09-24 Thread Jacek Lawrynowicz
The IPC driver is used to send and receive messages to/from firmware running on the VPU. The only supported IPC message format is Job Submission Model (JSM) defined in vpu_jsm_api.h header. Signed-off-by: Andrzej Kacprowski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz

[PATCH v3 5/7] drm/ivpu: Implement firmware parsing and booting

2022-09-24 Thread Jacek Lawrynowicz
Read, parse and boot VPU firmware image. Signed-off-by: Andrzej Kacprowski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz --- drivers/gpu/drm/ivpu/Makefile | 1 + drivers/gpu/drm/ivpu/ivpu_drv.c | 122 +++- drivers/gpu/drm/ivpu/ivpu_drv.h | 10

[PATCH v1 0/7] New DRM driver for Intel VPU

2022-07-28 Thread Jacek Lawrynowicz
except for two headers imported from the firmware that are MIT licensed. User mode driver stack consists of Level Zero API driver and OpenVINO plugin. Both should be open-sourced by the end of Q3. The firmware for the VPU will be distributed as a closed source binary. Regards, Jacek Jacek

[PATCH v1 1/7] drm/vpu: Introduce a new DRM driver for Intel VPU

2022-07-28 Thread Jacek Lawrynowicz
ludes only very besic functionality: - module, PCI device and IRQ initialization - register definitions and low level register manipulation functions - SET/GET_PARAM ioctls - power up without firmware Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz -

[PATCH v1 4/7] drm/vpu: Add IPC driver and JSM messages

2022-07-28 Thread Jacek Lawrynowicz
The IPC driver is used to send and receive messages to/from firmware running on the VPU. The only supported IPC message format is Job Submission Model (JSM) defined in vpu_jsm_api.h header. Signed-off-by: Andrzej Kacprowski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz

[PATCH v1 7/7] drm/vpu: Add PM support

2022-07-28 Thread Jacek Lawrynowicz
- Implement cold and warm firmware boot flows - Add hang recovery support - Add runtime power management support Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz --- drivers/gpu/drm/vpu/Makefile | 3 +- drivers/gpu/drm/vpu/vpu_drv.c| 32 ++- drivers/gpu/drm

[PATCH v1 5/7] drm/vpu: Implement firmware parsing and booting

2022-07-28 Thread Jacek Lawrynowicz
Read, parse and boot VPU firmware image. Signed-off-by: Andrzej Kacprowski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz --- drivers/gpu/drm/vpu/Makefile | 1 + drivers/gpu/drm/vpu/vpu_boot_api.h | 222 drivers/gpu/drm/vpu/vpu_drv.c | 123

[PATCH v1 6/7] drm/vpu: Add command buffer submission logic

2022-07-28 Thread Jacek Lawrynowicz
drm_sched. Signed-off-by: Andrzej Kacprowski Signed-off-by: Jacek Lawrynowicz --- drivers/gpu/drm/vpu/Makefile | 1 + drivers/gpu/drm/vpu/vpu_drv.c | 26 +- drivers/gpu/drm/vpu/vpu_drv.h | 6 +- drivers/gpu/drm/vpu/vpu_gem.c | 13 + drivers/gpu/drm/vpu/vpu_job.c | 611

[PATCH v1 2/7] drm/vpu: Add Intel VPU MMU support

2022-07-28 Thread Jacek Lawrynowicz
nts a driver that programs the MMU device Signed-off-by: Karol Wachowski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz --- drivers/gpu/drm/vpu/Makefile | 4 +- drivers/gpu/drm/vpu/vpu_drv.c | 59 +- drivers/gpu/drm/vpu/vpu_drv.h | 6 + drivers/gp

[PATCH v1 3/7] drm/vpu: Add GEM buffer object management

2022-07-28 Thread Jacek Lawrynowicz
three new IOCTLs: BO_CREATE, BO_INFO, BO_USERPTR Signed-off-by: Jacek Lawrynowicz --- drivers/gpu/drm/vpu/Makefile | 1 + drivers/gpu/drm/vpu/vpu_drv.c | 9 + drivers/gpu/drm/vpu/vpu_gem.c | 833 ++ drivers/gpu/drm/vpu/vpu_gem.h | 113 + include/uapi/drm

Re: [PATCH] [v2] accel: fix CONFIG_DRM dependencies

2023-01-31 Thread Jacek Lawrynowicz
On 31.01.2023 09:53, Oded Gabbay wrote: > On Sat, Jan 28, 2023 at 12:15 AM Arnd Bergmann wrote: >> >> From: Arnd Bergmann >> >> At the moment, accel drivers can be built-in even with CONFIG_DRM=m, >> but this causes a link failure: >> >> x86_64-linux-ld: drivers/accel/ivpu/ivpu_drv.o: in function

Re: [PATCH 1/2] accep/ivpu: PM: remove broken ivpu_dbg() statements

2023-01-31 Thread Jacek Lawrynowicz
Applied to drm-misc-next. Thanks. On 26.01.2023 17:37, Arnd Bergmann wrote: > From: Arnd Bergmann > > When CONFIG_PM is disabled, the driver fails to build: > > drivers/accel/ivpu/ivpu_pm.c: In function 'ivpu_rpm_get': > drivers/accel/ivpu/ivpu_pm.c:240:84: error: 'struct dev_pm_info' has no >

Re: [PATCH] drivers: Restore alignment and newline in Makefile

2023-01-31 Thread Jacek Lawrynowicz
Applied to drm-misc-next. Thanks. On 24.01.2023 11:41, Geert Uytterhoeven wrote: > The introduction of drivers/accel/ broke alignment, and removed the > newline at the end of the file. Fix all of that. > > Fixes: 35b137630f08d913 ("accel/ivpu: Introduce a new DRM driver for Intel > VPU") > Sign

Re: [PATCH 2/2] accel/ivpu: avoid duplciate assignment

2023-01-31 Thread Jacek Lawrynowicz
Applied to drm-misc-next. Thanks. On 26.01.2023 17:37, Arnd Bergmann wrote: > From: Arnd Bergmann > > With extra warnings enabled, gcc warns about two assignments > of the same .mmap callback: > > In file included from drivers/accel/ivpu/ivpu_drv.c:10: > include/drm/drm_accel.h:31:27: error: in

Re: [PATCH 1/4] accel/ivpu: Fix FW API data alignment issues

2023-02-03 Thread Jacek Lawrynowicz
Hi, On 02.02.2023 16:04, Jeffrey Hugo wrote: > On 2/2/2023 2:21 AM, Stanislaw Gruszka wrote: >> From: Andrzej Kacprowski >> >> FW API structures have been updated to fix misaligned >> structure members. >> >> Also changed JSM message header format to account for >> future improvements. >> >> Adde

Re: [PATCH 0/4] accel/ivpu: Fixes for 6.3

2023-02-06 Thread Jacek Lawrynowicz
Patchset applied to drm-misc-next and cherry-picked to drm-misc-next-fixes. Thanks. On 02.02.2023 10:21, Stanislaw Gruszka wrote: > Few fixes intended for 6.3. > > Andrzej Kacprowski (2): > accel/ivpu: Fix FW API data alignment issues > accel/ivpu: Send VPU_JSM_MSG_CONTEXT_DELETE when deletin

Re: [PATCH v2 1/8] accel/qaic: Add documentation for AIC100 accelerator driver

2023-02-14 Thread Jacek Lawrynowicz
Hi, On 06.02.2023 16:41, Jeffrey Hugo wrote: > The Qualcomm Cloud AI 100 (AIC100) device is an Artificial Intelligence > accelerator PCIe card. It contains a number of components both in the > SoC and on the card which facilitate running workloads: > > QSM: management processor > NSPs: workload

Re: [PATCH v2 2/8] accel/qaic: Add uapi and core driver file

2023-02-16 Thread Jacek Lawrynowicz
Hi, On 06.02.2023 16:41, Jeffrey Hugo wrote: > Add the QAIC driver uapi file and core driver file that binds to the PCIe > device. The core driver file also creates the accel device and manages > all the interconnections between the different parts of the driver. > > The driver can be built as a

Re: [PATCH v2 1/8] accel/qaic: Add documentation for AIC100 accelerator driver

2023-02-16 Thread Jacek Lawrynowicz
Hi, On 15.02.2023 16:41, Jeffrey Hugo wrote: > On 2/14/2023 4:08 AM, Jacek Lawrynowicz wrote: >> Hi, > > Thank you for the review. > >> On 06.02.2023 16:41, Jeffrey Hugo wrote: >>> The Qualcomm Cloud AI 100 (AIC100) device is an Artificial Intelligence >>

Re: [PATCH v5 1/7] accel/ivpu: Introduce a new DRM driver for Intel VPU

2023-01-13 Thread Jacek Lawrynowicz
Hi, On 12.01.2023 18:34, Jeffrey Hugo wrote: > On 1/9/2023 5:23 AM, Jacek Lawrynowicz wrote: >> VPU stands for Versatile Processing Unit and it's a CPU-integrated >> inference accelerator for Computer Vision and Deep Learning >> applications. >> >> The VPU

Re: [PATCH v5 3/7] accel/ivpu: Add GEM buffer object management

2023-01-13 Thread Jacek Lawrynowicz
Hi, On 12.01.2023 18:52, Jeffrey Hugo wrote: > On 1/9/2023 5:23 AM, Jacek Lawrynowicz wrote: >> Adds four types of GEM-based BOs for the VPU: >>    - shmem >>    - userptr >>    - internal >>    - prime >> >> All types are implemented as struct iv

Re: [PATCH v5 4/7] accel/ivpu: Add IPC driver and JSM messages

2023-01-13 Thread Jacek Lawrynowicz
Hi, On 12.01.2023 19:18, Jeffrey Hugo wrote: > On 1/9/2023 5:23 AM, Jacek Lawrynowicz wrote: >> The IPC driver is used to send and receive messages to/from firmware >> running on the VPU. >> >> The only supported IPC message format is Job Submission Model (JSM) >>

Re: [PATCH v5 0/7] New DRM accel driver for Intel VPU

2023-01-13 Thread Jacek Lawrynowicz
Hi, On 12.01.2023 18:10, Jeffrey Hugo wrote: > On 1/9/2023 5:23 AM, Jacek Lawrynowicz wrote: >> Hi, >> >> This patchset contains a new Linux* Kernel Driver for Intel® VPUs. >> >> VPU stands for Versatile Processing Unit and it is an AI inference >> accelera

[PATCH v6 0/7] New DRM accel driver for Intel VPU

2023-01-17 Thread Jacek Lawrynowicz
uilding with W=1 v2: https://lore.kernel.org/all/20220913121017.993825-1-jacek.lawrynow...@linux.intel.com/ - Rename the driver from "drm/vpu" to "drm/ivpu" - Add a TODO file - Add support for WC buffers v1: https://lore.kernel.org/all/20220728131709.1087188-1-jacek.lawrynow..

[PATCH v6 1/7] accel/ivpu: Introduce a new DRM driver for Intel VPU

2023-01-17 Thread Jacek Lawrynowicz
ludes only very besic functionality: - module, PCI device and IRQ initialization - register definitions and low level register manipulation functions - SET/GET_PARAM ioctls - power up without firmware Co-developed-by: Krystian Pradzynski Signed-off-by: Krystian Pradzynski Signed-off-by: Ja

[PATCH v6 3/7] accel/ivpu: Add GEM buffer object management

2023-01-17 Thread Jacek Lawrynowicz
IOCTLs: BO_CREATE, BO_INFO Signed-off-by: Jacek Lawrynowicz Reviewed-by: Oded Gabbay Reviewed-by: Jeffrey Hugo --- drivers/accel/ivpu/Makefile | 1 + drivers/accel/ivpu/ivpu_drv.c | 30 +- drivers/accel/ivpu/ivpu_drv.h | 1 + drivers/accel/ivpu/ivpu_gem.c | 727

[PATCH v6 4/7] accel/ivpu: Add IPC driver and JSM messages

2023-01-17 Thread Jacek Lawrynowicz
Pradzynski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz Reviewed-by: Oded Gabbay Reviewed-by: Jeffrey Hugo --- drivers/accel/ivpu/Makefile | 2 + drivers/accel/ivpu/ivpu_drv.c | 13 + drivers/accel/ivpu/ivpu_drv.h | 2 + drivers/accel/ivpu/ivpu_hw_mtl.c | 4

[PATCH v6 2/7] accel/ivpu: Add Intel VPU MMU support

2023-01-17 Thread Jacek Lawrynowicz
mmu.c implements a driver that programs the MMU device Co-developed-by: Karol Wachowski Signed-off-by: Karol Wachowski Co-developed-by: Krystian Pradzynski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz Reviewed-by: Oded Gabbay Reviewed-by: Jeffrey Hugo --- drivers/accel

[PATCH v6 5/7] accel/ivpu: Implement firmware parsing and booting

2023-01-17 Thread Jacek Lawrynowicz
Read, parse and boot VPU firmware image. Co-developed-by: Andrzej Kacprowski Signed-off-by: Andrzej Kacprowski Co-developed-by: Krystian Pradzynski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz Reviewed-by: Oded Gabbay Reviewed-by: Jeffrey Hugo --- drivers/accel/ivpu

[PATCH v6 7/7] accel/ivpu: Add PM support

2023-01-17 Thread Jacek Lawrynowicz
- Implement cold and warm firmware boot flows - Add hang recovery support - Add runtime power management support Co-developed-by: Krystian Pradzynski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo --- drivers/accel/ivpu/Makefile | 3

[PATCH v6 6/7] accel/ivpu: Add command buffer submission logic

2023-01-17 Thread Jacek Lawrynowicz
drm_sched. Co-developed-by: Andrzej Kacprowski Signed-off-by: Andrzej Kacprowski Signed-off-by: Jacek Lawrynowicz Reviewed-by: Oded Gabbay Reviewed-by: Jeffrey Hugo --- drivers/accel/ivpu/Makefile | 1 + drivers/accel/ivpu/ivpu_drv.c | 34 +- drivers/accel/ivpu/ivpu_drv.h | 5 + drivers

Re: [PATCH v6 0/7] New DRM accel driver for Intel VPU

2023-01-19 Thread Jacek Lawrynowicz
Hi, On 19.01.2023 12:11, Daniel Vetter wrote: > On Tue, Jan 17, 2023 at 10:27:16AM +0100, Jacek Lawrynowicz wrote: >> Hi, >> >> This patchset contains a new Linux* Kernel Driver for Intel® VPUs. >> >> VPU stands for Versatile Processing Unit and it is an AI infere

Re: [PATCH v3 5/7] drm/ivpu: Implement firmware parsing and booting

2022-11-14 Thread Jacek Lawrynowicz
Hi, On 11/1/2022 11:08 AM, Thomas Zimmermann wrote: > Hi > > Am 24.09.22 um 17:11 schrieb Jacek Lawrynowicz: >> Read, parse and boot VPU firmware image. >> >> Signed-off-by: Andrzej Kacprowski >> Signed-off-by: Krystian Pradzynski >> Signed-off-by: Jac

Re: [PATCH v3 2/7] drm/ivpu: Add Intel VPU MMU support

2022-11-17 Thread Jacek Lawrynowicz
Hi, On 10/27/2022 7:44 PM, Jeffrey Hugo wrote: > On 10/27/2022 3:14 AM, Jacek Lawrynowicz wrote: >> Hi, >> >> Thanks for an in-depth review. My responses are inline. >> >> On 10/26/2022 2:12 AM, Jeffrey Hugo wrote: >>> On 9/24/2022 9:11 AM, Jacek Lawrynow

Re: [PATCH v3 2/7] drm/ivpu: Add Intel VPU MMU support

2022-11-18 Thread Jacek Lawrynowicz
Hi, On 11/1/2022 10:00 AM, Thomas Zimmermann wrote: > Hi > > Am 24.09.22 um 17:11 schrieb Jacek Lawrynowicz: >> VPU Memory Management Unit is based on ARM MMU-600. >> It allows to create multiple virtual address spaces for the device and >> map noncontinuous host me

Re: [PATCH v3 2/7] drm/ivpu: Add Intel VPU MMU support

2022-11-18 Thread Jacek Lawrynowicz
Hi, On 11/1/2022 9:56 AM, Thomas Zimmermann wrote: > Hi > > Am 24.09.22 um 17:11 schrieb Jacek Lawrynowicz: >> VPU Memory Management Unit is based on ARM MMU-600. >> It allows to create multiple virtual address spaces for the device and >> map noncontinuous host me

Re: [PATCH v4 0/4] new subsystem for compute accelerator devices

2022-11-22 Thread Jacek Lawrynowicz
base next version of Intel VPU patchest on top of this. Acked-by: Jacek Lawrynowicz Tested-by: Jacek Lawrynowicz Regards, Jacek

Re: [PATCH v3 1/7] drm/ivpu: Introduce a new DRM driver for Intel VPU

2022-10-25 Thread Jacek Lawrynowicz
Hi, thanks for detailed review. My responses inline. On 10/25/2022 1:00 AM, Jeffrey Hugo wrote: > On 9/24/2022 9:11 AM, Jacek Lawrynowicz wrote: >> VPU stands for Versatile Processing Unit and it's a CPU-integrated >> inference accelerator for Computer Vision and Deep Lear

Re: [PATCH v3 3/7] drm/ivpu: Add GEM buffer object management

2022-10-26 Thread Jacek Lawrynowicz
Hi, On 10/25/2022 2:41 PM, Thomas Zimmermann wrote: > Hi > > Am 24.09.22 um 17:11 schrieb Jacek Lawrynowicz: >> Adds four types of GEM-based BOs for the VPU: >>    - shmem >>    - userptr >>    - internal >>    - prime >> >> All types ar

Re: [PATCH v3 1/7] drm/ivpu: Introduce a new DRM driver for Intel VPU

2022-10-26 Thread Jacek Lawrynowicz
Hi, On 10/25/2022 1:57 PM, Thomas Zimmermann wrote: > Hi > > Am 25.10.22 um 13:42 schrieb Jacek Lawrynowicz: >> Hi, thanks for detailed review. My responses inline. >> >> On 10/25/2022 1:00 AM, Jeffrey Hugo wrote: >>> On 9/24/2022 9:11 AM, Jacek Lawrynowicz

Re: [PATCH v3 1/7] drm/ivpu: Introduce a new DRM driver for Intel VPU

2022-10-26 Thread Jacek Lawrynowicz
On 10/25/2022 4:08 PM, Jeffrey Hugo wrote: > On 10/25/2022 5:42 AM, Jacek Lawrynowicz wrote: >> Hi, thanks for detailed review. My responses inline. >> >> On 10/25/2022 1:00 AM, Jeffrey Hugo wrote: >>> On 9/24/2022 9:11 AM, Jacek Lawrynowicz wrote: >>>> VP

Re: [PATCH v3 2/7] drm/ivpu: Add Intel VPU MMU support

2022-10-27 Thread Jacek Lawrynowicz
Hi, Thanks for an in-depth review. My responses are inline. On 10/26/2022 2:12 AM, Jeffrey Hugo wrote: > On 9/24/2022 9:11 AM, Jacek Lawrynowicz wrote: >> VPU Memory Management Unit is based on ARM MMU-600. >> It allows to create multiple virtual address spaces for the device and

Re: [PATCH v3 1/7] drm/ivpu: Introduce a new DRM driver for Intel VPU

2022-10-28 Thread Jacek Lawrynowicz
Hi, thanks for in-depth review. On 10/25/2022 2:38 PM, Thomas Zimmermann wrote: > Hi, > > please find some review comments below. > > Am 24.09.22 um 17:11 schrieb Jacek Lawrynowicz: >> +static int ivpu_irq_init(struct ivpu_device *vdev) >> +{ >> +    struc

Re: [PATCH v3 4/7] drm/ivpu: Add IPC driver and JSM messages

2022-12-07 Thread Jacek Lawrynowicz
Hi, On 11/1/2022 11:02 AM, Thomas Zimmermann wrote: > Hi > > Am 24.09.22 um 17:11 schrieb Jacek Lawrynowicz: >> The IPC driver is used to send and receive messages to/from firmware >> running on the VPU. >> >> The only supported IPC message format is Job Sub

Re: [PATCH v3 RESEND 0/7] New DRM driver for Intel VPU

2022-12-07 Thread Jacek Lawrynowicz
Hi, On 11/1/2022 11:17 AM, Thomas Zimmermann wrote: > Hi > > Am 01.11.22 um 09:58 schrieb Thomas Zimmermann: >> Hi >> >> Am 24.09.22 um 17:11 schrieb Jacek Lawrynowicz: >>> Hi, >>> >>> This patchset contains a new Linux* Kernel Driver for In

[PATCH v4 0/7] New DRM accel driver for Intel VPU

2022-12-08 Thread Jacek Lawrynowicz
/lore.kernel.org/all/20220913121017.993825-1-jacek.lawrynow...@linux.intel.com/ - Rename the driver from "drm/vpu" to "drm/ivpu" - Add a TODO file - Add support for WC buffers v1: https://lore.kernel.org/all/20220728131709.1087188-1-jacek.lawrynow...@linux.intel.com/ Jacek Lawrynowic

[PATCH v4 2/7] accel/ivpu: Add Intel VPU MMU support

2022-12-08 Thread Jacek Lawrynowicz
mmu.c implements a driver that programs the MMU device Co-developed-by: Karol Wachowski Signed-off-by: Karol Wachowski Co-developed-by: Krystian Pradzynski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/Makefile | 4 +- drivers/accel

[PATCH v4 1/7] accel/ivpu: Introduce a new DRM driver for Intel VPU

2022-12-08 Thread Jacek Lawrynowicz
ludes only very besic functionality: - module, PCI device and IRQ initialization - register definitions and low level register manipulation functions - SET/GET_PARAM ioctls - power up without firmware Co-developed-by: Krystian Pradzynski Signed-off-by: Krystian Pradzynski Signed-off-by: Ja

[PATCH v4 6/7] accel/ivpu: Add command buffer submission logic

2022-12-08 Thread Jacek Lawrynowicz
drm_sched. Co-developed-by: Andrzej Kacprowski Signed-off-by: Andrzej Kacprowski Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/Makefile | 1 + drivers/accel/ivpu/ivpu_drv.c | 34 +- drivers/accel/ivpu/ivpu_drv.h | 5 + drivers/accel/ivpu/ivpu_gem.c | 26 ++ drivers/accel/ivpu

[PATCH v4 3/7] accel/ivpu: Add GEM buffer object management

2022-12-08 Thread Jacek Lawrynowicz
three new IOCTLs: BO_CREATE, BO_INFO, BO_USERPTR Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/Makefile | 1 + drivers/accel/ivpu/ivpu_drv.c | 31 +- drivers/accel/ivpu/ivpu_drv.h | 1 + drivers/accel/ivpu/ivpu_gem.c | 820 ++ drivers/accel/ivpu

[PATCH v4 5/7] accel/ivpu: Implement firmware parsing and booting

2022-12-08 Thread Jacek Lawrynowicz
Read, parse and boot VPU firmware image. Co-developed-by: Andrzej Kacprowski Signed-off-by: Andrzej Kacprowski Co-developed-by: Krystian Pradzynski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/Makefile | 1 + drivers/accel/ivpu

[PATCH v4 7/7] accel/ivpu: Add PM support

2022-12-08 Thread Jacek Lawrynowicz
- Implement cold and warm firmware boot flows - Add hang recovery support - Add runtime power management support Co-developed-by: Krystian Pradzynski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/Makefile | 3 +- drivers/accel/ivpu

[PATCH v4 4/7] accel/ivpu: Add IPC driver and JSM messages

2022-12-08 Thread Jacek Lawrynowicz
Pradzynski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/Makefile | 2 + drivers/accel/ivpu/ivpu_drv.c | 13 + drivers/accel/ivpu/ivpu_drv.h | 2 + drivers/accel/ivpu/ivpu_hw_mtl.c | 4 + drivers/accel/ivpu/ivpu_ipc.c | 508

Re: [PATCH v4 3/7] accel/ivpu: Add GEM buffer object management

2022-12-19 Thread Jacek Lawrynowicz
Hi, On 18.12.2022 11:23, Oded Gabbay wrote: > On Thu, Dec 8, 2022 at 1:08 PM Jacek Lawrynowicz > wrote: >> Adds four types of GEM-based BOs for the VPU: >> - shmem >> - userptr >> - internal >> - prime >> >> All types are implemented as s

Re: [PATCH v4 2/7] accel/ivpu: Add Intel VPU MMU support

2022-12-19 Thread Jacek Lawrynowicz
Hi, On 18.12.2022 10:13, Oded Gabbay wrote: > On Thu, Dec 8, 2022 at 1:08 PM Jacek Lawrynowicz > wrote: >> >> VPU Memory Management Unit is based on ARM MMU-600. >> It allows the creation of multiple virtual address spaces for >> the device and map nonconti

Re: [PATCH v4 1/7] accel/ivpu: Introduce a new DRM driver for Intel VPU

2022-12-21 Thread Jacek Lawrynowicz
Hi, On 20.12.2022 21:17, Oded Gabbay wrote: > On Thu, Dec 8, 2022 at 1:08 PM Jacek Lawrynowicz > wrote: >> >> VPU stands for Versatile Processing Unit and it's a CPU-integrated >> inference accelerator for Computer Vision and Deep Learning >> applicatio

Re: [PATCH v4 4/7] accel/ivpu: Add IPC driver and JSM messages

2023-01-03 Thread Jacek Lawrynowicz
Hi, On 27.12.2022 16:34, Oded Gabbay wrote: > On Thu, Dec 8, 2022 at 1:08 PM Jacek Lawrynowicz > wrote: >> >> The IPC driver is used to send and receive messages to/from firmware >> running on the VPU. >> >> The only supported IPC message format is Job

Re: [PATCH v4 3/7] accel/ivpu: Add GEM buffer object management

2023-01-09 Thread Jacek Lawrynowicz
Hi, On 06.01.2023 14:29, Stanislaw Gruszka wrote: > Hi > > On Thu, Jan 05, 2023 at 12:46:51PM -0600, Andrew Davis wrote: >> On 12/8/22 5:07 AM, Jacek Lawrynowicz wrote: >>> Adds four types of GEM-based BOs for the VPU: >>>- shmem >>>- userpt

Re: [PATCH v4 3/7] accel/ivpu: Add GEM buffer object management

2023-01-09 Thread Jacek Lawrynowicz
Hi, On 06.01.2023 19:25, Daniel Vetter wrote: > On Fri, 6 Jan 2023 at 14:23, Stanislaw Gruszka > wrote: >> >> On Fri, Jan 06, 2023 at 11:50:05AM +0100, Daniel Vetter wrote: >>> On Thu, Dec 08, 2022 at 12:07:29PM +0100, Jacek Lawrynowicz wrote: >>>> Adds

[PATCH v5 0/7] New DRM accel driver for Intel VPU

2023-01-09 Thread Jacek Lawrynowicz
.intel.com/ - Rename the driver from "drm/vpu" to "drm/ivpu" - Add a TODO file - Add support for WC buffers v1: https://lore.kernel.org/all/20220728131709.1087188-1-jacek.lawrynow...@linux.intel.com/ Jacek Lawrynowicz (7): accel/ivpu: Introduce a new DRM driver for Intel VPU

[PATCH v5 1/7] accel/ivpu: Introduce a new DRM driver for Intel VPU

2023-01-09 Thread Jacek Lawrynowicz
ludes only very besic functionality: - module, PCI device and IRQ initialization - register definitions and low level register manipulation functions - SET/GET_PARAM ioctls - power up without firmware Co-developed-by: Krystian Pradzynski Signed-off-by: Krystian Pradzynski Signed-off-by: Ja

[PATCH v5 2/7] accel/ivpu: Add Intel VPU MMU support

2023-01-09 Thread Jacek Lawrynowicz
mmu.c implements a driver that programs the MMU device Co-developed-by: Karol Wachowski Signed-off-by: Karol Wachowski Co-developed-by: Krystian Pradzynski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/Makefile | 4 +- drivers/accel

[PATCH v5 3/7] accel/ivpu: Add GEM buffer object management

2023-01-09 Thread Jacek Lawrynowicz
. Add three new IOCTLs: BO_CREATE, BO_INFO, BO_USERPTR Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/Makefile | 1 + drivers/accel/ivpu/ivpu_drv.c | 31 +- drivers/accel/ivpu/ivpu_drv.h | 1 + drivers/accel/ivpu/ivpu_gem.c | 820 ++ drivers/accel/ivpu

[PATCH v5 4/7] accel/ivpu: Add IPC driver and JSM messages

2023-01-09 Thread Jacek Lawrynowicz
Pradzynski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/Makefile | 2 + drivers/accel/ivpu/ivpu_drv.c | 13 + drivers/accel/ivpu/ivpu_drv.h | 2 + drivers/accel/ivpu/ivpu_hw_mtl.c | 4 + drivers/accel/ivpu/ivpu_ipc.c | 505

[PATCH v5 5/7] accel/ivpu: Implement firmware parsing and booting

2023-01-09 Thread Jacek Lawrynowicz
Read, parse and boot VPU firmware image. Co-developed-by: Andrzej Kacprowski Signed-off-by: Andrzej Kacprowski Co-developed-by: Krystian Pradzynski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/Makefile | 1 + drivers/accel/ivpu

[PATCH v5 6/7] accel/ivpu: Add command buffer submission logic

2023-01-09 Thread Jacek Lawrynowicz
drm_sched. Co-developed-by: Andrzej Kacprowski Signed-off-by: Andrzej Kacprowski Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/Makefile | 1 + drivers/accel/ivpu/ivpu_drv.c | 34 +- drivers/accel/ivpu/ivpu_drv.h | 5 + drivers/accel/ivpu/ivpu_gem.c | 26 ++ drivers/accel/ivpu

[PATCH v5 7/7] accel/ivpu: Add PM support

2023-01-09 Thread Jacek Lawrynowicz
- Implement cold and warm firmware boot flows - Add hang recovery support - Add runtime power management support Co-developed-by: Krystian Pradzynski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/Makefile | 3 +- drivers/accel/ivpu

Re: [PATCH v5 3/7] accel/ivpu: Add GEM buffer object management

2023-01-10 Thread Jacek Lawrynowicz
Hi, On 10.01.2023 15:34, Oded Gabbay wrote: > On Mon, Jan 9, 2023 at 2:24 PM Jacek Lawrynowicz > wrote: >> Adds four types of GEM-based BOs for the VPU: >> - shmem >> - userptr >> - internal >> - prime >> >> All types are implemented as s

Re: [PATCH v5 5/7] accel/ivpu: Implement firmware parsing and booting

2023-01-11 Thread Jacek Lawrynowicz
Hi, On 10.01.2023 16:34, Oded Gabbay wrote: > On Mon, Jan 9, 2023 at 2:24 PM Jacek Lawrynowicz > wrote: >> Read, parse and boot VPU firmware image. >> >> Co-developed-by: Andrzej Kacprowski >> Signed-off-by: Andrzej Kacprowski >> Co-developed-by: Krystian Pr

Re: [PATCH v5 0/8] QAIC accel driver

2023-04-05 Thread Jacek Lawrynowicz
Hi, On 03.04.2023 19:22, Jeffrey Hugo wrote: > On 3/27/2023 9:54 AM, Jeffrey Hugo wrote: >> This series introduces a driver under the accel subsystem (QAIC - >> Qualcomm AIC) for the Qualcomm Cloud AI 100 product (AIC100).  AIC100 is >> a PCIe adapter card that hosts a dedicated machine learning i

Re: [PATCH v5 0/8] QAIC accel driver

2023-04-05 Thread Jacek Lawrynowicz
I've merged the patchset to drm-misc-next. Congrats Jeffrey :) On 05.04.2023 16:28, Jeffrey Hugo wrote: > On 4/5/2023 7:27 AM, Daniel Vetter wrote: >> On Wed, Apr 05, 2023 at 03:35:19PM +0300, Oded Gabbay wrote: >>> On Wed, Apr 5, 2023 at 2:26 PM Jacek Lawrynowicz &

Re: [PATCH] Revert "accel/qaic: Add mhi_qaic_cntl"

2023-04-13 Thread Jacek Lawrynowicz
Hi, On 13.04.2023 10:49, Daniel Vetter wrote: > On Wed, Apr 12, 2023 at 04:05:42PM +0200, Stanislaw Gruszka wrote: >> On Wed, Apr 12, 2023 at 07:57:44AM -0600, Jeffrey Hugo wrote: >>> This reverts commit 566fc96198b4bb07ca6806386956669881225271. >>> >>> This exposes a userspace API that is still

Re: [PATCH] accel: Build sub-directories based on config options

2023-03-13 Thread Jacek Lawrynowicz
Thanks. Applied to drm-misc-next and cherry-picked to drm-misc-fixes. On 01.03.2023 17:53, Stanislaw Gruszka wrote: > On Wed, Mar 01, 2023 at 09:31:10AM -0700, Jeffrey Hugo wrote: >> On 3/1/2023 9:25 AM, Stanislaw Gruszka wrote: >>> When accel drivers are disabled do not process into >>> sub-direc

Re: [PATCH v3 1/8] accel/qaic: Add documentation for AIC100 accelerator driver

2023-03-13 Thread Jacek Lawrynowicz
Reviewed-by: Jacek Lawrynowicz On 06.03.2023 22:33, Jeffrey Hugo wrote: > The Qualcomm Cloud AI 100 (AIC100) device is an Artificial Intelligence > accelerator PCIe card. It contains a number of components both in the > SoC and on the card which facilitate running workloads: > >

Re: [PATCH v3 2/8] accel/qaic: Add uapi and core driver file

2023-03-13 Thread Jacek Lawrynowicz
Hi, On 06.03.2023 22:33, Jeffrey Hugo wrote: > Add the QAIC driver uapi file and core driver file that binds to the PCIe > device. The core driver file also creates the accel device and manages > all the interconnections between the different parts of the driver. > > The driver can be built as a

Re: [PATCH v3 7/8] accel/qaic: Add qaic driver to the build system

2023-03-13 Thread Jacek Lawrynowicz
Reviewed-by: Jacek Lawrynowicz On 06.03.2023 22:34, Jeffrey Hugo wrote: > Now that we have all the components of a minimum QAIC which can boot and > run an AIC100 device, add the infrastructure that allows the QAIC driver > to be built. > > Signed-off-by: Jeffrey Hugo >

Re: [PATCH v3 3/8] accel/qaic: Add MHI controller

2023-03-13 Thread Jacek Lawrynowicz
Hi, On 06.03.2023 22:33, Jeffrey Hugo wrote: > An AIC100 device contains a MHI interface with a number of different > channels for controlling different aspects of the device. The MHI > controller works with the MHI bus to enable and drive that interface. > > AIC100 uses the BHI protocol in PBL t

Re: [PATCH v3 2/8] accel/qaic: Add uapi and core driver file

2023-03-14 Thread Jacek Lawrynowicz
Hi, On 13.03.2023 18:37, Jeffrey Hugo wrote: > On 3/13/2023 7:21 AM, Jacek Lawrynowicz wrote: >> Hi, >> >> On 06.03.2023 22:33, Jeffrey Hugo wrote: >>> Add the QAIC driver uapi file and core driver file that binds to the PCIe >>> device. The core driver

  1   2   3   4   5   6   >