[Resend][RFC PATCH v6 0/2] Introduce buffer synchronization framework

2013-08-13 Thread Inki Dae
gnal |<-- Displayed on screen | | | | <- vsync signal Thanks, Inki Dae References: [1] http://lwn.net/Articles/470339/ [2] https://patchwork.kernel.org/patch/2625361/ [3] http://linux.die.net/man/2/fcntl Inki Dae (2): [RFC PATCH v6] dmabuf-sync: Add a buffer synchronization f

[PATCH 3/3] drm: exynos: hdmi: Add dt support for hdmiphy settings

2013-08-14 Thread Inki Dae
e the hdmiphy config data to the hdmiphy driver. Thanks, Inki Dae 2013/8/13 Shirish S > This patch adds dt support to hdmiphy config settings > as it is board specific and depends on the signal pattern > of board. > > Signed-off-by: Shirish S > --- > .../devicetree/bind

[PATCHv3 1/4] drm/exynos: add device tree support for rotator

2013-08-19 Thread Inki Dae
e should keep different tables for each of them. >> This patch also includes desciptions of each nodes for the rotator and specifies >> a example how to bind it. >> >> Signed-off-by: Chanho Park >> Cc: Inki Dae > > Inki, do you OK on this? If so, let me take this

[PATCH 0/2] update pixel format setting to fimd driver

2013-08-20 Thread Inki Dae
This patch series fix pixel format setting according to drm_framebuffer's pixel_format, and check if a given window supports alpha channel or not. Inki Dae (2): drm/exynos: fix fimd pixel format setting drm/exynos: check a pixel format to a particular window layer drivers/gpu/drm/e

[PATCH 2/2] drm/exynos: check a pixel format to a particular window layer

2013-08-20 Thread Inki Dae
This patch checks if a requested window supports alpha channel or not. In case of s3c64xx, window 0 doesn't support alpha channel so if the request pixel format is ARGB then change it to XRGB. Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/e

[PATCH 1/2] drm/exynos: fix fimd pixel format setting

2013-08-20 Thread Inki Dae
ormat which is set by addfb with bpp and depth, or addfb2 with user-requested format. Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 34 +++-- 1 files changed, 13 insertions(+), 21 deletions(-) diff --git a/drivers/gp

[PATCH 1/2] [RFC PATCH v6] dmabuf-sync: Add a buffer synchronization framework

2013-08-21 Thread Inki Dae
Thanks for the review, Inki Dae > -Original Message- > From: linux-fbdev-owner at vger.kernel.org [mailto:linux-fbdev- > owner at vger.kernel.org] On Behalf Of Konrad Rzeszutek Wilk > Sent: Wednesday, August 21, 2013 4:22 AM > To: Inki Dae > Cc: dri-devel at lists.free

[PATCH v7 0/2] Introduce buffer synchronization framework

2013-08-21 Thread Inki Dae
| <- vsync signal Thanks, Inki Dae References: [1] http://lwn.net/Articles/470339/ [2] https://patchwork.kernel.org/patch/2625361/ [3] http://linux.die.net/man/2/fcntl Inki Dae (2): dmabuf-sync: Add a buffer synchronization framework dma-buf: Add user interfaces for dma

[PATCH v7 1/2] dmabuf-sync: Add a buffer synchronization framework

2013-08-21 Thread Inki Dae
buffer. If no anyone then select system call will be returned at once. References: [1] http://lwn.net/Articles/470339/ [2] https://patchwork.kernel.org/patch/2625361/ [3] http://linux.die.net/man/2/fcntl Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- Documentation/dma-buf-sync.txt |

[PATCH v2 2/2] dma-buf: Add user interfaces for dmabuf sync support

2013-08-21 Thread Inki Dae
ler doesn't use intefaces for the DMA device driver. Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/base/dma-buf.c | 81 1 files changed, 81 insertions(+), 0 deletions(-) diff --git a/drivers/base/dma-buf.c b/drivers/

[PATCH v2 2/2] dma-buf: Add user interfaces for dmabuf sync support

2013-08-22 Thread Inki Dae
Thanks for your comments, Inki Dae > -Original Message- > From: David Herrmann [mailto:dh.herrmann at gmail.com] > Sent: Wednesday, August 21, 2013 10:17 PM > To: Inki Dae > Cc: dri-devel at lists.freedesktop.org; linux-fbdev at vger.kernel.org; linux- > arm-kernel at l

[PATCH] drm/exynos: Add fallback option to get non physically contiguous memory for gem_dumb_create

2013-08-27 Thread Inki Dae
Applied. Thanks, Inki Dae > -Original Message- > From: Vikas Sajjan [mailto:vikas.sajjan at linaro.org] > Sent: Friday, August 23, 2013 3:35 PM > To: dri-devel at lists.freedesktop.org; inki.dae at samsung.com > Cc: kgene.kim at samsung.com; s.nawrocki at samsung.co

[PATCH 0/3] drm/exynos: fimd: get signal polarities from device tree

2013-08-27 Thread Inki Dae
> -Original Message- > From: linux-samsung-soc-owner at vger.kernel.org [mailto:linux-samsung-soc- > owner at vger.kernel.org] On Behalf Of Andrzej Hajda > Sent: Wednesday, August 21, 2013 11:22 PM > To: open list:DRM DRIVERS FOR E... > Cc: Andrzej Hajda; Inki Dae; Joo

[PATCH 1/6] drm/exynos: Remove non-DT support in exynos_drm_fimd

2013-08-27 Thread Inki Dae
Hi Sachin, Could you rebase your patch set to the below patch series? [PATCH 0/3] drm/exynos: fimd: get signal polarities from device tree Your patch set is conflicted. Thanks, Inki Dae > -Original Message- > From: Sachin Kamat [mailto:sachin.kamat at linaro.org]

[PATCH] drm/exynos: Add fallback option to get non physically contiguous memory for gem_dumb_create

2013-08-27 Thread Inki Dae
One more thing, changed the subject to "Consider fallback option to allocation fail". The subject is too long :) Thanks, Inki Dae > -Original Message- > From: linux-samsung-soc-owner at vger.kernel.org [mailto:linux-samsung-soc- > owner at vger.kernel.org] On Beh

[RFC 0/2] exynos5250/hdmi: replace dummy hdmiphy clock with pmu reg control

2013-08-28 Thread Inki Dae
Rahul, ping~~~ 2013/8/1 Rahul Sharma > Thanks Sylwester, > > On Wed, Jul 31, 2013 at 5:41 PM, Sylwester Nawrocki > wrote: > > Hi Rahul, > > > > On 07/31/2013 01:23 PM, Rahul Sharma wrote: > I think your hdmiphy pmu patch is good enough just if dt binding for > pmu > >> is in hdmiphy

[PATCH v2 2/2] dma-buf: Add user interfaces for dmabuf sync support

2013-08-29 Thread Inki Dae
ler doesn't use intefaces for the DMA device driver. Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/base/dma-buf.c | 81 1 files changed, 81 insertions(+), 0 deletions(-) diff --git a/drivers/base/dma-buf.c b/drivers/

[PATCH v8 0/2] Introduce buffer synchronization framework

2013-08-29 Thread Inki Dae
rred) | <- vsync signal |<-- Displayed on screen | | | | <- vsync signal Thanks, Inki Dae References: [1] http://lwn.net/Articles/470339/ [2] https://patchwork.kernel.org/patch/2625361/ [3]

[PATCH v8 1/2] dmabuf-sync: Add a buffer synchronization framework

2013-08-29 Thread Inki Dae
ll be returned at once. References: [1] http://lwn.net/Articles/470339/ [2] https://patchwork.kernel.org/patch/2625361/ [3] http://linux.die.net/man/2/fcntl Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- Documentation/dma-buf-sync.txt | 286 drivers/base/Kconfig

[PATCH 0/7] drm/exynos: move hdmiphy related code to hdmiphy driver

2013-08-30 Thread Inki Dae
ret = i2c_add_driver(&hdmiphy_i2c_driver); ... } else { ret = platform_driver_register(&hdmiphy_platform_driver); ... } return ret; } Thanks, Inki Dae > -Original Message- > From: R

[PATCH 0/7] drm/exynos: move hdmiphy related code to hdmiphy driver

2013-08-30 Thread Inki Dae
failed. Thanks, Inki Dae > -Original Message- > From: dri-devel-bounces+inki.dae=samsung.com at lists.freedesktop.org > [mailto:dri-devel-bounces+inki.dae=samsung.com at lists.freedesktop.org] On > Behalf Of Inki Dae > Sent: Friday, August 30, 2013 5:33 PM > To: &#x

[PATCH 1/1] drm/exynos: Fix build error with exynos_drm_connector.c

2013-08-30 Thread Inki Dae
> is not selected (introduced by commit cf796235a6 "drm/exynos: fimd: > replace struct fb_videomode with videomode"): > drivers/built-in.o: In function `exynos_drm_connector_get_modes': > drivers/gpu/drm/exynos/exynos_drm_connector.c:86: > undefined reference to `drm_display

[GIT PULL] exynos-drm-fixes

2013-12-02 Thread Inki Dae
Hi Dave, This pull request includes two fixup patches pended for long time. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 1b28c3e628315ac0d9ef2d3fac0403f05ae692db: drm/qxl: fix memory leak in release list handling (2013-11-29 08:36

[PATCH v3 29/32] drm/exynos: Implement drm_connector directly in dp driver

2013-12-03 Thread Inki Dae
Hi Sean, 2013/10/30 Sean Paul : > This patch implements drm_connector directly in the dp driver, this will > allow us to move away from the exynos_drm_connector layer. > > Signed-off-by: Sean Paul > --- > > Changes in v3: > - Added to the patchset > > drivers/gpu/drm/exynos/exynos_dp_co

[PATCH v3 30/32] drm/exynos: Implement drm_connector directly in vidi driver

2013-12-03 Thread Inki Dae
2013/10/30 Sean Paul : > This patch implements drm_connector directly in the vidi > driver, this will allow us to move away from the exynos_drm_connector > layer. > > Signed-off-by: Sean Paul > --- > > Changes in v3: > - Added to the patchset > > drivers/gpu/drm/exynos/exynos_drm_vidi.c |

[PATCH v3 27/32] drm/exynos: Add create_connector callback

2013-12-03 Thread Inki Dae
2013/10/30 Sean Paul : > This creates a new display hook called create_connector. The purpose is > to allow the display driver to create its own drm_connector instead of > using the exynos_drm_connector. This moves things closer to completely > removing the exynos_drm_connector abstraction. > > Sig

[PATCH v3 29/32] drm/exynos: Implement drm_connector directly in dp driver

2013-12-04 Thread Inki Dae
2013/12/3 Inki Dae : > Hi Sean, > > > 2013/10/30 Sean Paul : >> This patch implements drm_connector directly in the dp driver, this will >> allow us to move away from the exynos_drm_connector layer. >> >> Signed-off-by: Sean Paul >> --- >> >

[PATCH v3 30/32] drm/exynos: Implement drm_connector directly in vidi driver

2013-12-04 Thread Inki Dae
Sorry, there was my missing point. Ignore the below my comments. Thanks, Inki Dae 2013/12/3 Inki Dae : > 2013/10/30 Sean Paul : >> This patch implements drm_connector directly in the vidi >> driver, this will allow us to move away from the exynos_drm_connector >> layer

[PATCH v3 26/32] drm/exynos: Consolidate suspend/resume in drm_drv

2013-12-20 Thread Inki Dae
Hi, Below is my comments. Thanks for your contributions, Inki Dae 2013/10/30 Sean Paul : > This patch removes all of the suspend/resume logic from the individual > drivers and consolidates it in drm_drv. This consolidation reduces the > number of functions which enable/disable the ha

Re: [PATCH] dt-bindings: MAINTAINERS: drop stale exynos file pattern

2024-09-05 Thread Inki Dae
tof Kozlowski Applied. Seems that RC7 is already late, so I have merged it into the eynox-drm-next branch. Thanks, Inki Dae > --- > MAINTAINERS | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 028186bb4e8d..c75918994a53 100644 > ---

Re: [PATCH] drm/exynos: Constify struct exynos_drm_ipp_funcs

2024-09-06 Thread Inki Dae
4461714 16 2217656a0 > drivers/gpu/drm/exynos/exynos_drm_fimc.o > > Signed-off-by: Christophe JAILLET Applied. Thank for contribution, Inki Dae > --- > Compile tested-only. > --- > drivers/gpu/drm/exynos/exynos_drm_fimc.c | 2 +- > drivers/gpu/drm/exynos/exyno

Re: [PATCH] drm/exynos: Remove unnecessary code

2024-09-06 Thread Inki Dae
Hi Kwanghoon, 2024년 8월 14일 (수) 오후 12:57, Kwanghoon Son 님이 작성: > > Function usage exynos_atomic_commit was removed in > commit 41cbf0fdaa28 ("drm/exynos: use atomic helper commit"). > Remove unnecessary function declare. It's true. Applied. Thanks, Inki Dae >

Re: [PATCH v1] drivers:drm:exynos_drm_gsc:Fix wrong assignment in gsc_bind()

2024-09-06 Thread Inki Dae
ev = drm_dev; > - ctx->drm_dev = drm_dev; > + ipp->drm_dev = drm_dev; Correct. drm_dev should be set to ipp->drm_dev like other sub modules of ipp - fimc, scaler and rotator - did. Applied. Thanks, Inki Dae > exynos_drm_register_dma(drm_dev, dev, &ctx->dma_priv); > > exynos_drm_ipp_register(dev, ipp, &ipp_funcs, > -- > 2.34.1 > >

[GIT PULL] exynos-drm-next

2024-09-06 Thread Inki Dae
Hi Dave and Daniel, Just three cleanups and one fixup. Please kindly let me know if there is any problem. Thanks, The following changes since commit b1aa0491fad27f030c94ed42c873c3f46f5e7364: drm/xe: Fix merge fails related to display runtime PM (2024-09-02 14:14:07 +0200) are available

[RESEND GIT PULL] exynos-drm-next

2024-09-08 Thread Inki Dae
Hi Dave and Daniel, Just three cleanups and one fixup. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit e066e9aa4d9c869c92d1d03647472e4ce96c0919: MAINATINERS: update drm maintainer contacts (2024-09-03 20:07:57 +0200) are available

Re: [PATCH -next] drm/exynos: fix a potential error pointer dereference

2023-08-28 Thread Inki Dae
e ERR_PTR(-ENODEV), > which can not be used directly. Fix this by checking the return value > before using it. > Applied. Thanks, Inki Dae > > Signed-off-by: Xiang Yang > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --g

Re: [PATCH 1/5] drm/bridge: samsung-dsim: add more mipi-dsi device debug information

2023-09-03 Thread Inki Dae
MIPI device attach step. > > > > Signed-off-by: Marco Felsch > > Signed-off-by: Michael Tretter > > Reviewed-by: Adam Ford #imx8mm-beacon > Tested-by: Adam Ford #imx8mm-beacon Reviewed-by: Inki Dae Acked-by: Inki Dae > > > --- > > drivers/gpu/drm

Re: [PATCH 2/5] drm/bridge: samsung-dsim: reread ref clock before configuring PLL

2023-09-03 Thread Inki Dae
samsung,mipi-dsim.yaml It says, "DISM oscillator clock frequency. If absent, the clock frequency of sclk_mipi will be used instead." However, this patch makes the sclk_mipi to be used first. Thanks, Inki Dae > fout = samsung_dsim_pll_find_pms(dsi, fin, freq, &p, &m, &am

Re: [PATCH 3/5] drm/bridge: samsung-dsim: update PLL reference clock

2023-09-03 Thread Inki Dae
be between 2MHz and 30MHz? To other I.MX and Exynos engineers, please do not merge this patch until two SoC platforms are tested correctly. Thanks, Inki Dae > > Signed-off-by: Michael Tretter > --- > drivers/gpu/drm/bridge/samsung-dsim.c | 15 +-- > 1 file changed, 1

Re: [PATCH 2/5] drm/bridge: samsung-dsim: reread ref clock before configuring PLL

2023-09-05 Thread Inki Dae
2023년 9월 4일 (월) 오후 8:05, Michael Tretter 님이 작성: > On Mon, 04 Sep 2023 13:38:33 +0900, Inki Dae wrote: > > 2023년 8월 29일 (화) 오전 12:59, Michael Tretter 님이 > 작성: > > > > > > > > The PLL reference clock may change at runtime. Thus, reading the clock > >

Re: [PATCH 2/5] drm/bridge: samsung-dsim: reread ref clock before configuring PLL

2023-09-05 Thread Inki Dae
ulating the PLL > configuration parameters. > > Signed-off-by: Michael Tretter > Reviewed-by: Inki Dae Acked-by: Inki Dae Thanks, Inki Dae --- > drivers/gpu/drm/bridge/samsung-dsim.c | 16 +--- > include/drm/bridge/samsung-dsim.h | 1 + > 2 files ch

Re: [RFT PATCH v2 09/12] drm/exynos: Call drm_atomic_helper_shutdown() at shutdown/unbind time

2023-10-10 Thread Inki Dae
Hi, 2023년 10월 6일 (금) 오후 10:51, Doug Anderson 님이 작성: > > Hi, > > On Thu, Oct 5, 2023 at 7:20 PM Inki Dae wrote: > > > > Thanks for testing. :) > > > > Acked-by : Inki Dae > > Inki: does that mean you'd like this to go through drm-misc? I'm ha

[GIT PULL] exynos-drm-next

2024-07-03 Thread Inki Dae
Hi Dave and Daniel, Just three cleanup patches to Exynos Virtual Display driver for improved management. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit fb625bf6187d97c3cd28d680b14bf80f84207e5a: Merge tag 'drm-habanalabs

Re: [RFT PATCH v2 09/12] drm/exynos: Call drm_atomic_helper_shutdown() at shutdown/unbind time

2023-10-05 Thread Inki Dae
Thanks for testing. :) Acked-by : Inki Dae 2023년 9월 22일 (금) 오후 3:00, Marek Szyprowski 님이 작성: > > > On 21.09.2023 21:26, Douglas Anderson wrote: > > Based on grepping through the source code this driver appears to be > > missing a call to drm_atomic_helper_shutdown() at

Re: [PATCH] drm: exynos: dsi: Convert to platform remove callback returning void

2023-10-05 Thread Inki Dae
are converted, .remove_new() is renamed to .remove(). > > samsung_dsim_remove() returned 0 unconditionally. Make it return void > instead to convert the two related platform drivers to use > .remove_new(). > > Signed-off-by: Uwe Kleine-König It'd be better to go to drm-misc. R

[GIT PULL] exynos-drm-fixes

2023-10-05 Thread Inki Dae
Hi Dave and Daniel, Just one fixup to a potential error pointer dereference. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 8a749fd1a8720d4619c91c8b6e7528c0a355c0aa: Linux 6.6-rc4 (2023-10-01 14:15:13 -0700) are available in

[PATCH] drm/exynos: fix a wrong error checking

2023-11-01 Thread Inki Dae
)), which doesn't provide a suitable error value. So check if 'mapping' is NULL, and if it is, return ERR_PTR(-ENODEV). This issue[1] was reported by Dan. [1] https://www.spinics.net/lists/dri-devel/msg418271.html Reported-by : Dan Carpenter Signed-off-by: Inki Dae --- drivers

Re: [PATCH v3 08/16] drm/exynos: Convert to platform remove callback returning void

2023-11-07 Thread Inki Dae
Hi, Sorry for late. There was a merge conflict so I fixed it manually and merged. And seems your patch description is duplicated so dropped duplicated one. Thanks, Inki Dae 2023년 11월 3일 (금) 오전 1:57, Uwe Kleine-König 님이 작성: > The .remove() callback for a platform driver returns an int wh

[GIT PULL] drm-misc-fixes

2024-01-26 Thread Inki Dae
te to the drm-exynos tree. This pull request is based on the latest drm-misc-fixes branch of the drm-misc tree. Please kindly let me know if there is any problem. Thanks, Inki Dae [1] https://gitlab.freedesktop.org/freedesktop/freedesktop/-/issues/1151 The following changes since c

Re: [PATCH] drm/exynos: hdmi: report safe 640x480 mode as a fallback when no EDID found

2024-05-13 Thread Inki Dae
; able to drive such mode, so report a safe 640x480 mode instead of nothing > in case of the EDID reading failure. > > This fixes the following issue observed on Trats2 board since commit > 13d5b040363c ("drm/exynos: do not return negative values from .get_modes()"): Applied

[GIT PULL] exynos-drm-fixes

2023-11-20 Thread Inki Dae
Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 98b1cc82c4affc16f5598d4fa14b1858671b2263: Linux 6.7-rc2 (2023-11-19 15:02:14 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos

Re: [GIT PULL] exynos-drm-fixes

2023-11-27 Thread Inki Dae
Hi Dave, 2023년 11월 24일 (금) 오전 10:14, Dave Airlie 님이 작성: > On Tue, 21 Nov 2023 at 09:00, Inki Dae wrote: > > > > Hi Dave and Daniel, > > > >Two fixups - fixing a potential error pointer dereference and wrong > >error checking. > Hi Inki, > > This

[PATCH v2] drm/exynos: fix a wrong error checking

2023-11-27 Thread Inki Dae
rpenter Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_dma.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dma.c b/drivers/gpu/drm/exynos/exynos_drm_dma.c index a971590b8132..e2c7373f20c6 100644 --- a/drivers

[GIT PULL] exynos-drm-next

2024-04-24 Thread Inki Dae
problem. Thanks, Inki Dae The following changes since commit 83221064c28a0f9fdc4f63ab4fce2e51bfe23315: Merge tag 'drm-xe-next-2024-04-23' of https://gitlab.freedesktop.org/drm/xe/kernel into drm-next (2024-04-24 10:51:29 +1000) are available in the Git repository at: git://git.kern

Re: [PATCH] gpu: drm: exynos: hdmi: eliminate uses of of_node_put()

2024-04-25 Thread Inki Dae
Good cleanup. Applied. :) Thanks, Inki Dae 2024년 4월 15일 (월) 오전 9:40, Shivani Gupta 님이 작성: > > Utilize the __free() cleanup handler within the hdmi_get_phy_io function > to automatically release the device node when it is out of scope. > This eliminates the manual invocation of

Re: [PATCH 06/13] drm/exynos: Stop updating plane->crtc

2018-04-05 Thread Inki Dae
2018년 04월 06일 01:45에 Daniel Vetter 이(가) 쓴 글: > On Thu, Apr 05, 2018 at 06:13:53PM +0300, Ville Syrjala wrote: >> From: Ville Syrjälä >> >> We want to get rid of plane->crtc on atomic drivers. Stop setting it. >> >> Cc: Inki Dae >> Cc: Joonyoung Shim

Re: [PATCH 16/24] drm/exynos: Move GEM BOs to drm_framebuffer

2018-04-13 Thread Inki Dae
reuse those. Looks good and I will apply it including other two patches - 17 and 18 - after test. Thanks, Inki Dae > > Signed-off-by: Daniel Stone > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Seung-Woo Kim > Cc: Kyungmin Park > --- > drivers

[GIT PULL] exynos-drm-fixes

2018-04-19 Thread Inki Dae
Hi Dave, Just cleanup by removing Exynos specific framebuffer structure and relevant two callback functions. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 97130968839a2928869a2d25500b5855017aac7d: Merge tag 'drm-amdkfd-

Re: [PATCH 0/2] drm/exynos/mixer: fixes for interlaced mode

2018-04-22 Thread Inki Dae
;>> This is reviewed/updated/tested Tobias's patch addressing page-faults >>>> in Video Processor in interlaced mode. Plus preliminary patch fixing Mixer >>>> interlaced mode. >>>> >>>> Regards >>>> Andrzej >>>

Re: [PATCH v3] drm: exynos: Add driver for HDMI audio interface

2017-10-15 Thread Inki Dae
ej Hajda > > Any comments on this patch? I will review this patch including other patch series which should go to -next at end of this week. Thanks, Inki Dae > > Thanks, > Sylwester > >> --- >> Tested on Odroid XU3 and Odroid XU4 with Ubuntu 14.04. >>

[GIT PULL] exynos-drm-fixes

2017-10-15 Thread Inki Dae
Hi Dave, Just two regression fixups to potential use-after-free and NULL pointer dereference issues in suspend/resume. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit a480f30846d19b50106b3243d9d48683d2966249: Merge tag 

Re: [PATCH v2 05/11] drm/exynos/mixer: remove mixer_resources sub-structure

2017-10-16 Thread Inki Dae
- struct mixer_resources *res = &mixer_ctx->mixer_res; > > __set_bit(MXR_BIT_VSYNC, &mixer_ctx->flags); > if (!test_bit(MXR_BIT_POWERED, &mixer_ctx->flags)) > return 0; > > /* enable vsync interrupt */ > - mixer_reg_writem

Re: [PATCH v2 09/11] drm/exynos/hdmi: quirk for support mode timings conversion

2017-10-17 Thread Inki Dae
> + if ((m->vdisplay != am->vdisplay) && > + (m->hdisplay == 1280 || m->hdisplay == 1024)) > + hquirk = 258; Andrzej, The distorted value couldn't be described logically? Just I wonder why the difference happens. Thanks, Inki Dae &g

Re: [PATCH v2 10/11] drm/exynos/mixer: enable support for 1024x768 and 1280x1024 modes

2017-10-17 Thread Inki Dae
return MODE_OK; mixer_mode_valid function is common to all Exynos SoC managed by Exynos DRM driver. So is it valid for all of them? Thanks, Inki Dae > + > return MODE_BAD; > } > > ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 09/11] drm/exynos/hdmi: quirk for support mode timings conversion

2017-10-17 Thread Inki Dae
2017년 10월 17일 17:04에 Andrzej Hajda 이(가) 쓴 글: > On 17.10.2017 09:38, Inki Dae wrote: >> >> 2017년 09월 29일 19:05에 Andrzej Hajda 이(가) 쓴 글: >>> MIXER in SoCs prior to Exynos5420 supports only 4 video modes: >>> 720x480, 720x576, 1280x720, 1920x1080. Support for

Re: [PATCH v3] drm: exynos: Add driver for HDMI audio interface

2017-10-22 Thread Inki Dae
work_struct *work) > { > struct hdmi_context *hdata; > @@ -1588,11 +1700,14 @@ static void hdmiphy_clk_enable(struct exynos_drm_clk > *clk, bool enable) > { > struct hdmi_context *hdata = container_of(clk, struct hdmi_context, >

Re: [PATCH v2 00/11] drm/exynos: TV path improvements

2017-10-22 Thread Inki Dae
Hi Andrzej, Merged. And regarding below patch 9, I will try to contact HW guy to ask for why the difference happens. [PATCH v2 09/11] drm/exynos/hdmi: quirk for support mode timings conversion Thanks, Inki Dae 2017년 09월 29일 19:05에 Andrzej Hajda 이(가) 쓴 글: > Hi all, > > This patchset

Re: [PATCH v4] drm: exynos: Add driver for HDMI audio interface

2017-10-23 Thread Inki Dae
Merged. Thanks, Inki Dae 2017년 10월 23일 21:49에 Sylwester Nawrocki 이(가) 쓴 글: > The hdmi-codec interface added in this patch is required to properly > support HDMI audio. Currently the audio part of the SoC internal > HDMI transmitter is configured with fixed values, which makes HDM

[GIT PULL] exynos-drm-next

2017-10-25 Thread Inki Dae
to request git pull one more time after review. Thanks, Inki Dae [1] https://www.spinics.net/lists/linux-samsung-soc/msg60981.html This is a link to v3 patch set and now v4 has been posted. The following changes since commit 62884cd386b876638720ef88374b31a84ca7ee5f: drm: Add four

Re: [PATCH v4 2/9] drm/exynos: ipp: Add IPP v2 framework

2017-10-31 Thread Inki Dae
exynos_drm_ipp_check_size_limits(src, src_format->limits, > + rotation != DRM_MODE_ROTATE_0, false); > + if (ret) > + return ret; > + ret = exynos_drm_ipp_check_scale_limits(&src->rect, &dst->rect, > +

Re: [PATCH v4 3/9] drm/exynos: rotator: Convert driver to IPP v2 core API

2017-10-31 Thread Inki Dae
rm_get_irq(pdev, 0); > + if (irq < 0) { > dev_err(dev, "failed to get irq\n"); > - return rot->irq; > + return irq; > } > > - ret = devm_request_threaded_irq(dev, rot->irq, NULL, > -

Re: [PATCH v4 4/9] drm/exynos: gsc: Convert driver to IPP v2 core API

2017-10-31 Thread Inki Dae
c = &ctx->sc; > int ret; > > /* reset h/w block */ > ret = gsc_sw_reset(ctx); > if (ret < 0) { > - dev_err(dev, "failed to reset hardware.\n"); > + dev_err(ctx->dev, "failed to reset hardware.\n"); >

Re: [PATCH v4 5/9] drm/exynos: Add generic support for devices shared with V4L2 subsystem

2017-10-31 Thread Inki Dae
DRM FIMC driver is able to various transfomations such as color space conversion, scaling up/down and rotation. And this driver is used as mem to mem device driver. However, 'writeback' feature means 'dma to memory', which delivers one blended image in display controller in

Re: [PATCH] drm/exynos: gem: Drop NONCONTIG flag for buffers allocated without IOMMU

2017-10-31 Thread Inki Dae
m_iommu_supported(dev)) > + flags &= ~EXYNOS_BO_NONCONTIG; Even through iommu isn't supported, there could be 3D GPU or other DMA devices which support IOMMU. Of course, in this case, at least one memory copy will be required to pass it to Display controller. So I'm n

Re: [PATCH] drm/exynos: gem: Drop NONCONTIG flag for buffers allocated without IOMMU

2017-11-02 Thread Inki Dae
Hi Marek, 2017년 11월 02일 15:51에 Marek Szyprowski 이(가) 쓴 글: > Hi Inki, > > On 2017-11-01 07:31, Inki Dae wrote: >> 2017년 11월 01일 01:28에 Marek Szyprowski 이(가) 쓴 글: >>> When no IOMMU is available, all GEM buffers allocated by Exynos DRM driver >>> are cont

Re: [PATCH libdrm] exynos: change the license to X11/MIT

2017-11-02 Thread Inki Dae
Hi Email, Since I posted this patch, much time has been passed. But no answer. We got already many Acked-by so could you merge this patch? Thanks, Inki Dae 2017년 08월 10일 13:52에 Inki Dae 이(가) 쓴 글: > Chnage GPL license of Exynos relevant code to X11/MIT. > > I'd like to keep licen

Re: [PATCH v4 5/9] drm/exynos: Add generic support for devices shared with V4L2 subsystem

2017-11-05 Thread Inki Dae
Hi Marek, 2017년 11월 03일 21:28에 Marek Szyprowski 이(가) 쓴 글: > Hi Inki, > > On 2017-11-01 07:26, Inki Dae wrote: >> 2017년 10월 23일 16:54에 Marek Szyprowski 이(가) 쓴 글: >>> Some hardware modules, like FIMC in Exynos4 series are shared between >>> V4L2 (camera s

Re: [PATCH libdrm] exynos: change the license to X11/MIT

2017-11-06 Thread Inki Dae
want to change it to X11/MIT, so you should clarify this particular > choice. You kinda did this in [1], but it's totally missing here. So I just wanted to keep a consistent license across all Exynos code. Thanks, Inki Dae > > More comments inline. > > With these c

Re: [PATCH libdrm] exynos: change the license to X11/MIT

2017-11-06 Thread Inki Dae
2017년 08월 11일 00:48에 Jan Vesely 이(가) 쓴 글: > On Thu, 2017-08-10 at 13:52 +0900, Inki Dae wrote: >> Chnage GPL license of Exynos relevant code to X11/MIT. >> >> I'd like to keep license consistency to all Exynos code >> because License checker notices two

Re: [PATCH libdrm] exynos: change the license to X11/MIT

2017-11-06 Thread Inki Dae
2017년 11월 03일 23:03에 Emil Velikov 이(가) 쓴 글: > On 3 November 2017 at 13:59, Tobias Jakobi > wrote: >> Inki Dae wrote: >>> Hi Email, >>> >>> Since I posted this patch, much time has been passed. >>> But no answer. We got already many Acked-by so

Re: [PATCH] dt-bindings: exynos: Document #sound-dai-cells property of the HDMI node

2018-03-07 Thread Inki Dae
. I mean that if this property never affect HDMI driver then this property would be a dead thing even through this can be declared optionally. Thanks, Inki Dae > Example: > > hdmi { > ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] dt-bindings: exynos: Document #sound-dai-cells property of the HDMI node

2018-03-07 Thread Inki Dae
Hi Marek, 2018년 03월 08일 15:29에 Marek Szyprowski 이(가) 쓴 글: > Hi Inki, > > On 2018-03-08 05:01, Inki Dae wrote: >> Hi Sylwester, >> >> 2018년 03월 08일 02:11에 Sylwester Nawrocki 이(가) 쓴 글: >>> The #sound-dai-cells DT property is required to describe link between

Re: [PATCH] dt-bindings: exynos: Document #sound-dai-cells property of the HDMI node

2018-03-08 Thread Inki Dae
Hi Marek, 2018년 03월 08일 16:36에 Marek Szyprowski 이(가) 쓴 글: > Hi Inki, > > On 2018-03-08 07:50, Inki Dae wrote: >> 2018년 03월 08일 15:29에 Marek Szyprowski 이(가) 쓴 글: >>> On 2018-03-08 05:01, Inki Dae wrote: >>>> 2018년 03월 08일 02:11에 Sylwester Nawrocki 이(가) 쓴 글: &g

Re: [PATCH] dt-bindings: exynos: Document #sound-dai-cells property of the HDMI node

2018-03-08 Thread Inki Dae
Hi Sylwester, 2018년 03월 08일 20:22에 Sylwester Nawrocki 이(가) 쓴 글: > Hi Inki, > > Cc: alsa-de...@alsa-project.org > > On 03/08/2018 09:15 AM, Inki Dae wrote: >> By the way, it seems 'sound-dai-cells' property never affect >> Exynos4210/4212> 5420/5433. I

Re: [PATCH v2] dt-bindings: exynos: Document #sound-dai-cells property of the HDMI node

2018-03-11 Thread Inki Dae
dmi.txt | 1 + >> 1 file changed, 1 insertion(+) > > Reviewed-by: Rob Herring Applied. Thanks, Inki Dae > > > > ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[GIT PULL] exynos-drm-fixes

2018-03-18 Thread Inki Dae
Hi Dave, Just adding a missed description, '#sound-dai-cells', which is a device tree propery of hdmi device node that Exynos SoC device tree files have already. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes si

[PATCH libdrm] tests: fix memory leak issue

2018-03-19 Thread Inki Dae
Fixed memory leak issue to drmModeRes object. This object was allocated by drmModeGetResources function but not freed when device->screens failed. So this patch frees the drmModeRes object when device->screens failed by calling drmModeFreeResources function. Signed-off-by: Inki Dae ---

[RESEND PATCH libdrm] tests: fix memory leak issue

2018-03-19 Thread Inki Dae
. Signed-off-by: Inki Dae --- tests/kms/libkms-test-device.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/kms/libkms-test-device.c b/tests/kms/libkms-test-device.c index 53c7349..042ae05 100644 --- a/tests/kms/libkms-test-device.c +++ b/tests/kms/libkms-test

Re: [PATCH v5 2/6] drm/exynos: Let core take care of normalizing the zpos

2018-03-22 Thread Inki Dae
2018년 03월 21일 19:20에 Peter Ujfalusi 이(가) 쓴 글: > Instead of re-implementing the drm_atomic_helper_check() locally with just > adding drm_atomic_normalize_zpos() into it, set the > drm_mode_config->normalize_zpos. > > Signed-off-by: Peter Ujfalusi > CC: Inki Dae >

Re: [PATCH 00/14] clean up drm_bridge_add

2017-08-18 Thread Inki Dae
2017년 08월 08일 07:55에 Inki Dae 이(가) 쓴 글: > Daniel, please ping~ Sean, please ping~ > > 2017년 07월 03일 17:42에 Inki Dae 이(가) 쓴 글: >> This patch series changes return type of drm_bridge_add >> function to void one and also removes unnecessary checking >> of the return

Re: [PATCH 12/14] drm/exynos: mic: clean up drm_bridge_add call

2017-08-18 Thread Inki Dae
2017년 07월 03일 17:42에 Inki Dae 이(가) 쓴 글: > This patch removes unnecessary checking of return value. > > Ps. this patch depends on below one, > http://www.spinics.net/lists/dri-devel/msg145687.html Above patch has been already merged to mainline so no dependency, and can go

Re: [PATCH 12/14] drm/exynos: mic: clean up drm_bridge_add call

2017-08-18 Thread Inki Dae
2017년 07월 05일 18:14에 Archit Taneja 이(가) 쓴 글: > > > On 07/05/2017 02:35 PM, Inki Dae wrote: >> >> >> 2017년 07월 05일 18:00에 Archit Taneja 이(가) 쓴 글: >>> >>> >>> On 07/03/2017 02:12 PM, Inki Dae wrote: >>>> This patch removes unneces

Re: [PATCH 12/14] drm/exynos: mic: clean up drm_bridge_add call

2017-08-18 Thread Inki Dae
2017년 07월 05일 20:12에 Emil Velikov 이(가) 쓴 글: > On 5 July 2017 at 10:14, Archit Taneja wrote: >> >> >> On 07/05/2017 02:35 PM, Inki Dae wrote: >>> >>> >>> >>> 2017년 07월 05일 18:00에 Archit Taneja 이(가) 쓴 글: >>>> >>>>

Re: [PATCH 00/14] clean up drm_bridge_add

2017-08-21 Thread Inki Dae
Hi Archit, 2017년 07월 06일 17:58에 Archit Taneja 이(가) 쓴 글: > > > On 07/03/2017 02:12 PM, Inki Dae wrote: >> This patch series changes return type of drm_bridge_add >> function to void one and also removes unnecessary checking >> of the return type from relevant drivers.

Re: [PATCH v2 03/10] drm/exynos/dsi: refactor panel detection logic

2017-08-24 Thread Inki Dae
drm_helper_hpd_irq_event(dsi->connector.dev); > - > - return 0; > -} > - > -static ssize_t exynos_dsi_host_transfer(struct mipi_dsi_host *host, > - const struct mipi_dsi_msg *msg) I fixed below error. ERROR: code indent should use tabs where possible #364: FILE: drivers/gpu/drm/exynos/exynos_drm_dsi.c:1581: +^I^I^I^Iconst struct mipi_dsi_msg *msg)$ Thanks, Inki Dae ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 08/10] drm/exynos/decon5433: use mode info stored in CRTC to detect i80 mode

2017-08-24 Thread Inki Dae
poned until panel communicate its requirements, ie to > mode validation phase - mode_valid callback. Same patch will be required for other Exynos SoCs for consistency later. Thanks, Inki Dae > > Signed-off-by: Andrzej Hajda > --- > drivers/gpu/drm/ex

Re: [PATCH v2 02/10] drm/exynos: use helper to set possible crtcs

2017-08-24 Thread Inki Dae
nos_drm_crtc.h" > #include "exynos_drm_drv.h" > @@ -191,16 +192,30 @@ struct exynos_drm_crtc *exynos_drm_crtc_create(struct > drm_device *drm_dev, > return ERR_PTR(ret); > } > > -int exynos_drm_crtc_get_pipe_from_type(struct drm_device *drm_dev, > +s

Re: [PATCH v2 05/10] drm/exynos/mic: use mode info stored in CRTC to detect i80 mode

2017-08-24 Thread Inki Dae
/exynos/exynos_drm_mic.c > @@ -21,9 +21,12 @@ > #include > #include > #include > +#include > #include > #include > > +#include Build error happened at here. It should be modified to '#include "exynos_drm_drv.h"'. I can fix it. Thanks,

Re: [PATCH v2 1/9] drm/exynos: mixer: fix chroma comment in vp_video_buffer()

2017-08-24 Thread Inki Dae
r.c:535: + /* the chroma plane for NV12/NV21 is half the height of the luma plane */ I just removed a word, 'the', in front of 'chroma' word. Thanks, Inki Dae > vp_reg_write(res, VP_IMG_SIZE_C, VP_IMG_HSIZE(fb->pitches[0]) | > VP_IMG_VSIZ

[GIT PULL] exynos-drm-next

2017-08-24 Thread Inki Dae
Hi Dave, Just refactoring to KMS drivers - NV12MT pixel format, possible_crtc, panel detection way and video/command mode supports. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 7c0059dd832cc686bf0febefdcf8295cdd93007f: Merge

<    4   5   6   7   8   9   10   11   12   13   >