[PATCH v2] drm/exynos: update to use component match support

2014-09-11 Thread Inki Dae
Update Exynos's DRM driver to use component match support rater than add_components. Changelog v2: - release devices and drivers if failed. - change compare_of to compare_dev. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 44 +++ 1

[PATCH 5/9] drm/exynos/crtc: fix framebuffer reference sequence

2014-09-12 Thread Inki Dae
rtc = crtc; > plane->fb = crtc->primary->fb; > drm_framebuffer_reference(plane->fb); > > + if (old_fb) > + drm_framebuffer_unreference(old_fb); This time would be a good chance that we can consider drm flip queue to make sure that whole memory region to old_fb is scanned out completely before dropping a reference of old_fb. the reference of old_fb should be dropped at irq handler of each crtc devices, fimd and mixer. Thanks, Inki Dae > + > return 0; > } > >

[PATCH 5/9] drm/exynos/crtc: fix framebuffer reference sequence

2014-09-12 Thread Inki Dae
On 2014? 09? 12? 17:57, Daniel Vetter wrote: > On Fri, Sep 12, 2014 at 05:34:50PM +0900, Inki Dae wrote: >> Hi Andrzej, >> >> On 2014? 09? 09? 22:16, Andrzej Hajda wrote: >>> Adding reference to framebuffer should be accompanied with removing >>> reference t

[PATCH 5/9] drm/exynos/crtc: fix framebuffer reference sequence

2014-09-12 Thread Inki Dae
On 2014? 09? 12? 18:27, Andrzej Hajda wrote: > On 09/12/2014 10:57 AM, Daniel Vetter wrote: >> On Fri, Sep 12, 2014 at 05:34:50PM +0900, Inki Dae wrote: >>> Hi Andrzej, >>> >>> On 2014? 09? 09? 22:16, Andrzej Hajda wrote: >>>> Adding reference to

[PATCH 5/9] drm/exynos/crtc: fix framebuffer reference sequence

2014-09-12 Thread Inki Dae
On 2014? 09? 12? 20:04, Andrzej Hajda wrote: > On 09/12/2014 12:45 PM, Inki Dae wrote: >> On 2014? 09? 12? 18:27, Andrzej Hajda wrote: >>> On 09/12/2014 10:57 AM, Daniel Vetter wrote: >>>> On Fri, Sep 12, 2014 at 05:34:50PM +0900, Inki Dae wrote: >>>>>

[PATCH] drm/exynos: fix plane-framebuffer linkage

2014-09-17 Thread Inki Dae
is sounds very much like exynos should switch to universal planes so >> that the fake primary plane created by the helpers doesn't get in the way. >> And for chips which already use planes for everything internally this >> shouldn't be a lot more than a few lines. >>

-next mostly closed, what have I missed?

2014-09-17 Thread Inki Dae
nd will have a pull with them by the end of the week. Thanks for notice, Inki Dae > > Please continue to send fixes for -next pulls, and I'm kinda open to > new hw support depending on how intrusive it is to other code. > > Now we have a strange new time of a few weeks where ma

[PATCH 0/9] drm/exynos: initialization/deinitialization fixes

2014-09-17 Thread Inki Dae
ied all patches except patch #5. As of now, it seems good to merge also patch #5 if you couldn't post next version of that patch until the end of this week. In this case, I will have a pull request including that patch so that we can fix it up correctly later. Give me your opinion if there is other

[PATCH 0/2] drm/exynos: use drm generic mmap interface

2014-09-17 Thread Inki Dae
This patch set removes unnecessary DRM_EXYNOS_GEM_MAP_OFFSET interface which isn't used anymore and also uses drm generic mmap interface instead of a mmap interface specific to Exynos drm. So this patch set removes a existing mmap interface and relevant codes specific to Exynos drm. Inki D

[PATCH 2/2] drm/exynos: use drm generic mmap interface

2014-09-17 Thread Inki Dae
cific mmap interface because the drm generic mmap which uses vm offset manager stuff can also do mmap directly. This patch makes a userspace region to be mapped with whole physical memory region allocated by userspace request when mmap system call is requested. Signed-off-by: Inki Dae --- driver

[PATCH 1/2] drm/exynos: remove DRM_EXYNOS_GEM_MAP_OFFSET ioctl

2014-09-17 Thread Inki Dae
This interface and relevant codes aren't used anymore. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_drv.c |3 --- drivers/gpu/drm/exynos/exynos_drm_gem.c | 17 - drivers/gpu/drm/exynos/exynos_drm_gem.h |4 include/uapi/drm/exynos_

[PATCH 2/2] drm/exynos: use drm generic mmap interface

2014-09-18 Thread Inki Dae
Thanks for review. Below trivial things you pointed out will be fixed soon. On 2014? 09? 18? 13:56, Joonyoung Shim wrote: > Hi, > > On 09/17/2014 10:48 PM, Inki Dae wrote: >> This patch removes DRM_EXYNOS_GEM_MMAP ictrl feature specific >> to Exynos drm and instead

[PATCH v2] drm/exynos: use drm generic mmap interface

2014-09-18 Thread Inki Dae
VM_IO, VM_DONTEXPEND and VM_DONTDUMP. These flags were already set by drm_gem_mmap - do not include , which isn't needed anymore. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 26 - drivers/gpu/drm/exynos/exynos_drm_drv.h |1 - drivers/gpu/drm/exynos/exynos

[PATCH v2] drm/exynos: switch to universal plane API

2014-09-20 Thread Inki Dae
nup of crtcs to core, > this way planes and crtcs are cleaned in correct order. > > Signed-off-by: Andrzej Hajda > --- > Hi Inki, Joonyoung, > > This is 2nd version of the patch with addressed comments of Joonyoung. Picked it up. Thanks, Inki Dae > > Regards

[PATCH] drm/exynos: factor out initial setting of each driver

2014-09-20 Thread Inki Dae
2014-09-18 17:50 GMT+09:00 Joonyoung Shim : > From fimd driver and vidi driver, dev->irq_enabled and > dev->vblank_disable_allowed are set and also mixer needs them even if > missed. It's duplicated so set them when loads drm driver. Picked it up. Thanks, Inki Dae > >

[PATCH v2] drm/exynos: switch to universal plane API

2014-09-20 Thread Inki Dae
2014-09-20 1:04 GMT+09:00 Inki Dae : > 2014-09-19 21:58 GMT+09:00 Andrzej Hajda : >> The patch replaces legacy functions >> drm_plane_init() / drm_crtc_init() with >> drm_universal_plane_init() and drm_crtc_init_with_planes(). >> It allows to replace fake prim

[PATCH] drm/exynos: fimd: fix screen shaking issue on i80 mode

2014-09-24 Thread Inki Dae
before updating overlay registers. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index 2f896df..8a45a70 100644 --- a

[PATCH] drm/exynos: remove ifdeferry from initialization code

2014-10-01 Thread Inki Dae
detest with -v option from second times. 2. error occurs when we try to test unbind. Now we are checking these problems. Can you try to also check it? Thanks, Inki Dae > > Andrzej > > On 09/10/2014 01:53 PM, Andrzej Hajda wrote: >> The patch replaces separate calls to driver (

[PATCH] drm/exynos: remove ifdeferry from initialization code

2014-10-01 Thread Inki Dae
On 2014? 10? 01? 14:48, Inki Dae wrote: > On 2014? 09? 30? 20:29, Andrzej Hajda wrote: >> Hi Inki, >> >> Gently ping. > > Hi Andrzej, > > I merged it to local repository to test. But now exynos drm doesn't work > correctly since pulling drm-next of Dav

[PATCH 09/14] drm/exynos: remove call to drm_gem_free_mmap_offset()

2015-09-25 Thread Inki Dae
On 2015년 09월 24일 10:01, Joonyoung Shim wrote: > Hi Inki, > > On 08/17/2015 06:03 PM, Inki Dae wrote: >> On 2015년 08월 17일 17:17, Joonyoung Shim wrote: >>> On 08/17/2015 04:52 PM, Inki Dae wrote: >>>> On 2015년 08월 17일 14:29, Joonyoung Shim wrote

[PATCH] drm/exynos: dp: remove suspend/resume functions

2015-09-30 Thread Inki Dae
This patch removes unnecessary pm suspend/resume functions. All kms sub drivers will be controlled by top of Exynos drm driver and connector dpms so these sub drivers shouldn't have their own pm interfaces. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_dp_core.c

[PATCH] drm/exynos: Avoid NULL pointer dereference in resume if bind failed

2015-09-30 Thread Inki Dae
m_dev exists. Thanks for your patch. However, the pm interfaces of KMS drivers aren't required because these are controlled by top of Exynos drm driver and connector dpms. So I posted a patch that it removes pm interfaces of dp driver. Thanks, Inki Dae > > Signed-off-by: Charles Keepax &

[PATCH] drm/exynos: dp: remove suspend/resume functions

2015-09-30 Thread Inki Dae
Hi Emil, On 2015년 09월 30일 21:19, Emil Velikov wrote: > Hi Inki, > > On 30 September 2015 at 12:21, Inki Dae wrote: >> This patch removes unnecessary pm suspend/resume functions. >> >> All kms sub drivers will be controlled by top of Exynos drm driver >>

[GIT PULL] exynos-drm-fixes

2015-10-01 Thread Inki Dae
Hi Dave, This pull request includes regression fixups, build warnings, and trivial cleanups which mostly remove some codes not used anymore. Please, kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit

[RFC 0/6] drm/fences: add in-fences to DRM

2016-04-04 Thread Inki Dae
2016년 03월 31일 23:10에 Rob Clark 이(가) 쓴 글: > On Thu, Mar 31, 2016 at 7:26 AM, Inki Dae wrote: >> Hi Daniel, >> >> 2016-03-31 19:56 GMT+09:00 Daniel Stone : >>> Hi Inki, >>> >>> On 31 March 2016 at 11:05, Inki Dae wrote: >>>&

[PATCH 1/3] drm/exynos: clean up wait_for_vblank

2016-04-05 Thread Inki Dae
olves page fault issue so keep it. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos7_drm_decon.c | 1 - drivers/gpu/drm/exynos/exynos_drm_drv.h| 3 --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 1 - drivers/gpu/drm/exynos/exynos_mixer.c | 39 -- 4

[PATCH 2/3] drm/exynos: fimd: add HW trigger support

2016-04-05 Thread Inki Dae
FIMD controller. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 47 1 file changed, 47 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index 752c6b0..c4cd16a 100644 --- a

[PATCH 3/3] drm/exynos: decon: clean up interface type

2016-04-05 Thread Inki Dae
This patch cleans up interface type relevant codes. Trigger mode is determinded only by i80 mode, which isn't related to Display types - HDMI or Display controller. So this patch makes the trigger mode to be set only in case of i80 mode. Signed-off-by: Inki Dae --- drivers/gpu/drm/e

[PATCH 0/3] drm/exynos: support HW trigger on i80 mode

2016-04-05 Thread Inki Dae
, HW trigger mode will be used in default if SoC suppots HW trigger - Exynos3250, 3472, 4415, 5260 5410, 5420 and 5422. P.s. HW trigger support for Exynos 7 series will be added later. Thanks, Inki Dae Inki Dae (3): drm/exynos: clean up wait_for_vblank drm/exynos: fimd: add HW trigger support

[PATCH 3/3] drm/exynos: decon: clean up interface type

2016-04-05 Thread Inki Dae
Hi Andrzej, 2016-04-05 20:07 GMT+09:00 Andrzej Hajda : > Hi Inki, > > On 04/05/2016 10:27 AM, Inki Dae wrote: >> This patch cleans up interface type relevant codes. >> >> Trigger mode is determinded only by i80 mode, which isn't >> related to Display typ

[PATCH 3/3] drm/exynos: decon: clean up interface type

2016-04-12 Thread Inki Dae
Hi Andrzej, 2016년 04월 05일 21:52에 Inki Dae 이(가) 쓴 글: > Hi Andrzej, > > 2016-04-05 20:07 GMT+09:00 Andrzej Hajda : >> Hi Inki, >> >> On 04/05/2016 10:27 AM, Inki Dae wrote: >>> This patch cleans up interface type relevant codes. >>> >

[PATCH] drm/exynos: clean up register definions for fimd and decon

2016-04-12 Thread Inki Dae
This patch removes suffixes from I80 relevant register definitions, which are misleading. This is based on top of below patch set, http://www.spinics.net/lists/dri-devel/msg104057.html Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 +- drivers/gpu/drm

[PATCH 5/7] drm/exynos/decon5433: fix DECON standalone update

2016-04-12 Thread Inki Dae
HDMI output? In addition, we would need another patch which updates TV relevant registers only in case of DECON-TV. DECON_UPDATE is a register for DECON-TV. Thanks, Inki Dae > > Signed-off-by: Andrzej Hajda > --- > drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 15

[PATCH 3/3] drm/exynos: decon: clean up interface type

2016-04-12 Thread Inki Dae
2016년 04월 12일 14:55에 Andrzej Hajda 이(가) 쓴 글: > Hi Inki, > > On 04/12/2016 02:40 AM, Inki Dae wrote: >> Hi Andrzej, >> >> 2016년 04월 05일 21:52에 Inki Dae 이(가) 쓴 글: >>> Hi Andrzej, >>> >>> 2016-04-05 20:07 GMT+

[PATCH v2] drm/exynos: decon: clean up interface type

2016-04-12 Thread Inki Dae
orily because HDMI Timing Generator generates VSYNC signal which works as a hardware trigger. Changelog v2. - If interface type is HDMI then set out_type to I80. - fix compile warning. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 57 ++- 1 file ch

[PATCH 5/7] drm/exynos/decon5433: fix DECON standalone update

2016-04-12 Thread Inki Dae
2016년 04월 12일 16:33에 Andrzej Hajda 이(가) 쓴 글: > On 04/12/2016 04:25 AM, Inki Dae wrote: >> Hi Andrzej, >> >> 2016년 03월 23일 22:15에 Andrzej Hajda 이(가) 쓴 글: >>> DECON should be updated after un-protecting windows and after changing &g

[GIT PULL] exynos-drm-fixes

2016-04-13 Thread Inki Dae
HI Dave, This pull request includes several regression fixups. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 928815245cbdaa611873424759d5e7a7293dd18b: Merge tag 'drm-intel-fixes-2016-04-07' of git://anongit.freedeskt

[PATCH 2/7] drm/exynos: dsi: use generic of_device_get_match_data helper

2016-04-18 Thread Inki Dae
gt;driver_data = of_device_get_match_data(dev); drivers/gpu/drm/exynos/exynos_drm_dsi.c: In function 'exynos_dsi_probe': drivers/gpu/drm/exynos/exynos_drm_dsi.c:1827:19: warning: assignment discards 'const' qualifier from pointer target type Looks you missed const prefix and for patch 3 also but I can fix them. Thanks, Inki Dae > > ret = exynos_dsi_parse_dt(dsi); > if (ret) >

[PATCH 2/2] ARM: dts: add exynos5420-fimd compatible

2016-04-21 Thread Inki Dae
;> to "exynos5420-fimd". To support mic bypass from display >>>> path, the new compatible is introduced for exynos5420. >>>> >>>> Cc: Inki Dae >>>> Cc: Kukjin Kim >>>> Cc: Krzysztof Kozlowski >>>> Signed-off-by:

[PATCH] Revert "drm/exynos/decon5433: implement frame counter"

2018-10-04 Thread Inki Dae
er. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 9 - drivers/gpu/drm/exynos/exynos_drm_crtc.c | 11 --- drivers/gpu/drm/exynos/exynos_drm_drv.h | 1 - 3 files changed, 21 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_deco

Re: [PATCH] Revert "drm/exynos/decon5433: implement frame counter"

2018-10-05 Thread Inki Dae
On 2018년 10월 05일 15:26, Daniel Vetter wrote: > On Fri, Oct 5, 2018 at 8:22 AM Daniel Vetter wrote: >> >> On Fri, Oct 5, 2018 at 4:59 AM Inki Dae wrote: >>> >>> This reverts commit 0586feba322e1de05075700eb4b835c8b683e62b >>> >>> This patch m

Re: [PATCH] drm/exynos: fimc: signedness bug in fimc_setup_clocks()

2018-05-22 Thread Inki Dae
2018년 05월 18일 17:04에 Dan Carpenter 이(가) 쓴 글: > "id" needs to be signed for the error handling to work. Applied to exynos-drm-fixes-v4.18-rc1. Thanks, Inki Dae > > Fixes: 7a2d5c77c558 ("drm/exynos: fimc: Convert driver to IPP v2 core API") > Signed-off-by:

[PATCH] drm/exynos: scaler: fix static checker warning

2018-05-22 Thread Inki Dae
drivers/gpu/drm/exynos/exynos_drm_scaler.c:402 scaler_task_done() warn: signedness bug returning '(-22)' Reported-by: Dan Carpenter Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_scaler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/

[PATCH v2] drm/exynos: ipp: fix image broken issue

2018-05-23 Thread Inki Dae
Call fixup buffer function before calling size limit check. - Remove checking align of image offset, x and y. The offest values have no any limit but only size. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_gsc.c | 94 +++-- drivers/gpu/drm/e

[PATCH] drm/bridge: sil_sii8620: do not have a dependency of RC_CORE

2018-05-24 Thread Inki Dae
i8620 driver only for HDMI. Signed-off-by: Inki Dae --- drivers/gpu/drm/bridge/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig index 3aa65bd..0290fc3 100644 --- a/drivers/gpu/drm/bridge/Kconfig +++ b/dr

Re: [PATCH 0/3] Exynos DRM - add 2 more planes to Decon on Exynos5433

2018-05-24 Thread Inki Dae
lan for this patchset: > 1. dts (patch 2/3) - please schedule for v4.18 merge window > 2. driver (patch 3/3) - please schedule for the next release after dts is >merged > 3. bindings (patch 1/3) - probably can go together with the driver patch Merged 1 and 3. Thanks, Inki Dae

Re: [PATCH] drm/bridge: sil_sii8620: do not have a dependency of RC_CORE

2018-05-24 Thread Inki Dae
2018년 05월 24일 17:03에 Andrzej Hajda 이(가) 쓴 글: > On 24.05.2018 09:07, Inki Dae wrote: >> This patch makes RC_CORE to be selected with this driver. >> >> sil_sii8620 driver calls remote controller interfaces directly >> so RC_CORE should be enabled mandatorily. >

[PATCH v2] drm/bridge: sil_sii8620: do not have a dependency of RC_CORE

2018-05-24 Thread Inki Dae
i8620 driver only for HDMI. Changelog v2: - select INPUT because compiling will fail without INPUT. Signed-off-by: Inki Dae --- drivers/gpu/drm/bridge/Kconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig

[GIT PULL v2] exynos-drm-next

2018-05-24 Thread Inki Dae
Hi Dave, Since previous git-pull request, it includes more HW overlays support of DECON controller and several fixups and one cleanup. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit bec923c50ab550d1d53b297dd4c753db18a13204

Re: [PATCH v2] drm/exynos: ipp: fix image broken issue

2018-05-28 Thread Inki Dae
This patch changes userspace parameter but Kernel driver shouldn't touch such parameter. Please ignore this patch. Marek will post a generic solution soon, which fixes the image broken issue without touching userspace parameter. Thanks, Inki Dae 2018년 05월 24일 10:04에 Inki Dae 이(가) 쓴 글: &g

[GIT PULL] exynos-drm-fixes

2018-05-08 Thread Inki Dae
Hi Dave, Just fixup to pagefault issue of mixer driver I missed and a trivial cleanup to avoid duplicated drm_bridge_attach. Please kindly let me know if there is any problem Thanks, Inki Dae The following changes since commit a02cbe2e34c576cdc5e7846a3cd55245ab81db47: Merge branch

Re: [PATCH v7 6/7] ARM: dts: exynos: Add mem-2-mem Scaler devices

2018-05-09 Thread Inki Dae
20.dtsi earlier, > so bind them to newly added devices. > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Marek Szyprowski Reviewed-by: Inki Dae Thanks, Inki Dae > --- > arch/arm/boot/dts/exynos5420.dtsi | 36 +++ > 1 file changed, 36 inse

Re: [PATCH v7 7/7] ARM64: dts: exynos: Add mem-2-mem Scaler devices

2018-05-09 Thread Inki Dae
2018년 05월 09일 17:59에 Marek Szyprowski 이(가) 쓴 글: > From: Andrzej Pietrasiewicz > > There are two Scaler devices in Exynos5433 SoCs. Add nodes for them and > their SYSMMU controllers. > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Marek Szyprowski Reviewed-

Re: [PATCH] gpu: drm: exynos: Change return type to vm_fault_t

2018-05-11 Thread Inki Dae
r_of(x, struct exynos_drm_gem, base) >> >> @@ -111,7 +112,7 @@ int exynos_drm_gem_dumb_create(struct drm_file >> *file_priv, >> struct drm_mode_create_dumb *args); >> >> /* page fault handler and mmap fault address(virtual) to phys

[GIT PULL] exynos-drm-next

2018-05-13 Thread Inki Dae
any problem. Thanks, Inki Dae The following changes since commit a02cbe2e34c576cdc5e7846a3cd55245ab81db47: Merge branch 'vmwgfx-fixes-4.17' of git://people.freedesktop.org/~thomash/linux into drm-fixes (2018-05-04 10:03:27 +1000) are available in the git repository a

[PATCH] drm/exynos: ipp: fix image broken issue

2018-05-16 Thread Inki Dae
gem buffer is enough for it or not. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_gsc.c | 87 +++-- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 15 ++ drivers/gpu/drm/exynos/exynos_drm_ipp.h | 12 + 3 files changed, 100 insertions(+), 14 deletions

[GIT PULL] exynos-drm-fixes

2018-11-05 Thread Inki Dae
Hi Dave, Just three regression fixups - fix extension and clone mode issue, fix lack of fbdev on Rinato and trats boards, and check for dsi->panel object correctlY. Please kindely let me know if there is any problem. Thanks, Inki Dae The following changes since com

Re: [PATCH 0/6] drm/exynos/iommu: refactoring

2018-11-27 Thread Inki Dae
os-drm-next-todo for more tests last week. I had a review for your patch series and Looked good but I'd like to have more tests. Thanks, Inki Dae > > Regards > > Andrzej > > > >> >> Regards >> Andrzej >> >> >> Andrzej Hajda (

Re: [PATCH v5 2/9] drm/exynos: move connector creation to attach callback

2018-08-16 Thread Inki Dae
2018년 08월 13일 20:17에 Andrzej Hajda 이(가) 쓴 글: > On 07.08.2018 10:53, Inki Dae wrote: >> >> 2018년 07월 26일 00:46에 Andrzej Hajda 이(가) 쓴 글: >>> From: Maciej Purski >>> >>> The current implementation assumes that the only possible peripheral >>>

Re: [PATCH v5 2/9] drm/exynos: move connector creation to attach callback

2018-08-20 Thread Inki Dae
2018년 08월 20일 18:00에 Andrzej Hajda 이(가) 쓴 글: > On 17.08.2018 03:56, Inki Dae wrote: >> >> 2018년 08월 13일 20:17에 Andrzej Hajda 이(가) 쓴 글: >>> On 07.08.2018 10:53, Inki Dae wrote: >>>> 2018년 07월 26일 00:46에 Andrzej Hajda 이(가) 쓴 글: >>>>> From: Ma

Re: [PATCH v5 2/9] drm/exynos: move connector creation to attach callback

2018-08-21 Thread Inki Dae
2018년 08월 21일 20:21에 Andrzej Hajda 이(가) 쓴 글: > On 21.08.2018 07:27, Inki Dae wrote: >> >> 2018년 08월 20일 18:00에 Andrzej Hajda 이(가) 쓴 글: >>> On 17.08.2018 03:56, Inki Dae wrote: >>>> 2018년 08월 13일 20:17에 Andrzej Hajda 이(가) 쓴 글: >>>>> On 07.08.2018

Re: [PATCH 1/3] drm: drm_fourcc: add Samsung 16x16 tile format

2018-08-26 Thread Inki Dae
2018년 08월 10일 22:28에 Marek Szyprowski 이(가) 쓴 글: > From: Andrzej Pietrasiewicz > > Add modifier for tiled formats used by graphics modules found in Samsung > Exynos5250/542x/5433 SoCs. This is a simple tiled layout using tiles > of 16x16 pixels in a row-major layout. Review

Re: [PATCH 1/3] drm: drm_fourcc: add Samsung 16x16 tile format

2018-09-06 Thread Inki Dae
Hi, 2018년 08월 27일 09:38에 Inki Dae 이(가) 쓴 글: > > > 2018년 08월 10일 22:28에 Marek Szyprowski 이(가) 쓴 글: >> From: Andrzej Pietrasiewicz >> >> Add modifier for tiled formats used by graphics modules found in Samsung >> Exynos5250/542x/5433 SoCs. This is a simple til

Re: [PATCH v2 01/10] drm/exynos: rename "bridge_node" to "mic_bridge_node"

2018-06-24 Thread Inki Dae
Hi, I will start to review patch sets for -fixes first so I queued your four patches and you can check exynos-drm-next-todo branch for it. Thanks, Inki Dae 2018년 05월 30일 21:15에 Maciej Purski 이(가) 쓴 글: > When adding support for peripheral out bridges, the "bridge" name > becomes

Re: [PATCH 0/9] Exynos DRM IPP fixes

2018-06-25 Thread Inki Dae
orizontal > and vertial flips or used incorrect variant of the YUV modes. This > patchset fixes those issues. This patchset had been reviewed and verified already on review.tizen.org so merged to exynos-drm-fixes. Thanks, Inki Dae > > Best regards > Marek Szyprowski > Samsung

[GIT PULL]: exynos-drm-fixes

2018-07-01 Thread Inki Dae
Hi Dave, Several fixups to Exynos DRM IPP v2 framework and relevant drivers merged to mainline recently, and some clenaups. Please kindely let me know if there is any problem. Thanks, Inki Dae The following changes since commit 2d8aa4ef6aac566617052640e9bb07ecb9c45183: Merge tag

[GIT PULL] exynos-drm-next

2018-12-05 Thread Inki Dae
Hi Dave, Three patch series - code refactoring for simplifying DMA mapping, enhancing plane alpha and blend mode support for Exynos5433 Decon device, and fixing color format setting of Mixer driver. Please kindly let me know if there is any problem. Thanks, Inki Dae The following

Re: [PATCH 0/3] drm/exynos: add support for dynamic zpos in DECON and FIMD

2018-12-06 Thread Inki Dae
rent exynos-drm-next, or on all > Christoph's patches? I missed to merge Christoph's patches. Thanks for notice. Now you can rebase your patch on top of exynos-drm-next. Thanks, Inki Dae > > > Regards > > Andrzej > > >> >> Regards >> Andrzej &g

Re: [PATCH 0/3] drm/exynos: add support for dynamic zpos in DECON and FIMD

2018-12-09 Thread Inki Dae
e by user space doesn't guarantee correct HW overlay priority. Why do you want to support mutable zpos? Thanks, Inki Dae > It was tested on tm2 and trats2. > > Regards > Andrzej > > > Andrzej Hajda (3): > drm/exynos/decon5433: add dynamic zpos support >

Re: [PATCH 0/3] drm/exynos: add support for dynamic zpos in DECON and FIMD

2018-12-10 Thread Inki Dae
Hi Andrzej, 18. 12. 10. 오후 4:35에 Andrzej Hajda 이(가) 쓴 글: > Hi Inki, > > On 10.12.2018 03:25, Inki Dae wrote: >> Hi Andrzej, >> >> 18. 12. 6. 오후 6:38에 Andrzej Hajda 이(가) 쓴 글: >>> Hi Inki, >>> >>> This small patchset adds dynamic zpos support f

Re: [PATCH 0/3] drm/exynos: add support for dynamic zpos in DECON and FIMD

2018-12-11 Thread Inki Dae
18. 12. 11. 오후 4:49에 Andrzej Hajda 이(가) 쓴 글: > On 11.12.2018 00:45, Inki Dae wrote: >> Hi Andrzej, >> >> 18. 12. 10. 오후 4:35에 Andrzej Hajda 이(가) 쓴 글: >>> Hi Inki, >>> >>> On 10.12.2018 03:25, Inki Dae wrote: >>>> Hi Andrzej, >>

Re: [PATCH 0/3] drm/exynos: add support for dynamic zpos in DECON and FIMD

2018-12-11 Thread Inki Dae
18. 12. 11. 오후 5:36에 Andrzej Hajda 이(가) 쓴 글: > On 11.12.2018 09:01, Inki Dae wrote: >> >> 18. 12. 11. 오후 4:49에 Andrzej Hajda 이(가) 쓴 글: >>> On 11.12.2018 00:45, Inki Dae wrote: >>>> Hi Andrzej, >>>> >>>> 18. 12. 10. 오후 4:35에 Andrzej Ha

Re: [PATCH 0/3] drm/exynos: add support for dynamic zpos in DECON and FIMD

2018-12-11 Thread Inki Dae
18. 12. 11. 오후 10:20에 Andrzej Hajda 이(가) 쓴 글: > Hi again, > > It seems I have missed two questions: > > On 11.12.2018 09:36, Andrzej Hajda wrote: >> On 11.12.2018 09:01, Inki Dae wrote: >>> 18. 12. 11. 오후 4:49에 Andrzej Hajda 이(가) 쓴 글: >>>> On 11.12.20

Re: [PATCH 0/3] drm/exynos: add support for dynamic zpos in DECON and FIMD

2018-12-12 Thread Inki Dae
18. 12. 12. 오후 5:30에 Andrzej Hajda 이(가) 쓴 글: > On 12.12.2018 00:48, Inki Dae wrote: >> >> 18. 12. 11. 오후 10:20에 Andrzej Hajda 이(가) 쓴 글: >>> Hi again, >>> >>> It seems I have missed two questions: >>> >>> On 11.12.2018 09:36, Andrzej Haj

Re: [PATCH 0/3] drm/exynos: add support for dynamic zpos in DECON and FIMD

2018-12-12 Thread Inki Dae
18. 12. 12. 오후 5:43에 Andrzej Hajda 이(가) 쓴 글: > On 12.12.2018 00:26, Inki Dae wrote: >> >> 18. 12. 11. 오후 5:36에 Andrzej Hajda 이(가) 쓴 글: >>> On 11.12.2018 09:01, Inki Dae wrote: >>>> 18. 12. 11. 오후 4:49에 Andrzej Hajda 이(가) 쓴 글: >>>>> On

[GIT PULL v2] exynos-drm-next

2018-12-13 Thread Inki Dae
Hi Dave, Just adding configurable plane alpha and pixel blend mode support for FIMD device I missed. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 2a3c83f5fe0770d13bbb71b23674886ff4111f44: Merge tag 'vmwgfx-next-2018-

Re: [PATCH 2/3] drm/exynos: scaler: Add support for tiled formats

2018-09-11 Thread Inki Dae
plane has always same tile size. And also RGB formats have 16 x 16 tile size in tile mode but you declared it as 0. Could you check it out again? Thanks, Inki Dae > +}; > + > +static const struct scaler_format *scaler_get_format(u32 drm_fmt) > { > - switch (drm_fmt)

Re: [PATCH 2/3] drm/exynos: scaler: Add support for tiled formats

2018-09-12 Thread Inki Dae
2018년 09월 12일 15:59에 Andrzej Pietrasiewicz 이(가) 쓴 글: > Hi Inki, > > W dniu 12.09.2018 o 01:54, Inki Dae pisze: >> Hi Marek and Andrzej, >> >> 2018년 08월 10일 22:29에 Marek Szyprowski 이(가) 쓴 글: >>> From: Andrzej Pietrasiewicz >>> >>> Add suppo

Re: [PATCH 2/3] drm/exynos: scaler: Add support for tiled formats

2018-09-13 Thread Inki Dae
Hi Marek, 2018년 09월 13일 17:03에 Marek Szyprowski 이(가) 쓴 글: > Hi Inki, > > On 2018-09-13 07:14, Inki Dae wrote: >> 2018년 09월 12일 15:59에 Andrzej Pietrasiewicz 이(가) 쓴 글: >>> W dniu 12.09.2018 o 01:54, Inki Dae pisze: >>>> Hi Marek and Andrzej, >>>> >

Re: [PATCH 2/3] drm/exynos: scaler: Add support for tiled formats

2018-09-13 Thread Inki Dae
2018년 09월 13일 17:49에 Marek Szyprowski 이(가) 쓴 글: > Hi Inki, > > On 2018-09-13 10:23, Inki Dae wrote: >> 2018년 09월 13일 17:03에 Marek Szyprowski 이(가) 쓴 글: >>> On 2018-09-13 07:14, Inki Dae wrote: >>>> 2018년 09월 12일 15:59에 Andrzej Pietrasiewicz 이(가) 쓴 글: >&

Re: [PATCH v4] gpu/drm/exynos: Convert drm_atomic_helper_suspend/resume()

2018-09-20 Thread Inki Dae
ed for 4.20 ? Queued already to exynos-drm-next below so please wait. I will have pull-request soon. https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git/log/?h=exynos-drm-next Thanks, Inki Dae > >>> --- >>> v2: Address Inki Dae's comment. Remove

Re: [PATCH 2/3] drm/exynos: scaler: Add support for tiled formats

2018-09-20 Thread Inki Dae
src.buf.fourcc); > struct drm_exynos_ipp_task_rect *src_pos = &task->src.rect; > > - u32 dst_fmt = scaler_get_format(task->dst.buf.fourcc); > + const struct scaler_format *dst_fmt = > scaler_get_format(task->dst.buf.fourcc); > struct drm_exynos_ipp_task_rect *dst_pos

[GIT PULL] exynos-drm-fixes

2018-09-30 Thread Inki Dae
U and DMA-IOMMU frameworks in v4.20 Please kindly let me know if there is any problem. [1] https://www.spinics.net/lists/arm-kernel/msg676098.html Thanks, Inki Dae The following changes since commit fcb1349a2af5a3c4a1d789bb5d1a9b3e582652a3: Merge branch 'drm-fixes-4.

[GIT PULL] exynos-drm-next

2018-10-01 Thread Inki Dae
] https://patchwork.freedesktop.org/patch/243921/ Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 0320ac5188eab5c6e8b92b110d1eae967ac272d2: Merge tag 'du-next-20180914' of git://linuxtv.org/pinchartl/media into drm-next (201

Re: [PATCH v2 2/3] iommu/dma: Use fast DMA domain lookup

2018-10-01 Thread Inki Dae
+ dri-devel This patch may also break other ARM DRM drivers. I cced dri-devel so that they could manage this. And below relevant link for ARM DRM maintainers, https://www.spinics.net/lists/arm-kernel/msg676098.html Thanks, Inki Dae 2018년 9월 29일 (토) 오전 1:19, Marek Szyprowski 님이 작성: > &

Re: [PATCH] gpu/drm/exynos: Convert drm_atomic_helper_suspend/resume()

2018-07-23 Thread Inki Dae
> - drm_kms_helper_poll_enable(drm_dev); > + ret = drm_mode_config_helper_resume(drm_dev); Ditto. return drm_mode_config_helper_resume(drm_dev); With this patch, you could remove 'int ret' declaration including one from exynos_drm_suspend. Thanks, Inki Dae > > -

Re: [PATCH 1/3] drm/exynos: Drop useless check from exynos_drm_{suspend,resume}

2018-07-24 Thread Inki Dae
- return 0; > + if (!drm_dev) > + return; return 0. I will fix it. Thanks, Inki Dae > > private = drm_dev->dev_private; > drm_atomic_helper_resume(drm_dev, private->suspend_state); > ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v3 1/9] drm/exynos: rename "bridge_node" to "mic_bridge_node"

2018-07-24 Thread Inki Dae
nderstand what you say. And in case of Exynos5433 SoC, SMIES(Samsung Mobile Image Enhancement System) can be located between DECON and MIPI-DSI devices also. Therefore, having specific name isn't reasonable. Thanks, Inki Dae > > Signed-off-by: Maciej Purski > --- > drivers/gp

Re: [PATCH 1/3] drm/exynos: Drop useless check from exynos_drm_{suspend,resume}

2018-07-24 Thread Inki Dae
2018년 07월 24일 16:49에 Marek Szyprowski 이(가) 쓴 글: > Hi Inki, > > On 2018-07-24 09:12, Inki Dae wrote: >> 2018년 06월 11일 21:24에 Marek Szyprowski 이(가) 쓴 글: >>> The virtual Exynos DRM device has no runtime PM enabled, so checking >>> for its runtime suspended state

Re: [PATCH v3 3/9] drm/exynos: enable out_bridge in exynos_dsi_enable()

2018-07-24 Thread Inki Dae
able(dsi, false); > - drm_panel_unprepare(dsi->panel); > - pm_runtime_put_sync(dsi->dev); > - return; > + if (dsi->panel) { > + ret = drm_panel_enable(dsi->panel); > + if (ret &l

Re: [PATCH v3 2/9] drm/exynos: move connector creation to attach callback

2018-07-24 Thread Inki Dae
hich is a DSI > peripheral bridge device. Right, we should consider DSI to LVDS bridge. Thanks, Inki Dae > > Signed-off-by: Maciej Purski > --- > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 38 > ++--- > 1 file changed, 25 insertions(+), 13 deletions

Re: [PATCH v3 2/9] drm/exynos: move connector creation to attach callback

2018-07-24 Thread Inki Dae
2018년 07월 24일 17:04에 Inki Dae 이(가) 쓴 글: > Hi, > > 2018년 06월 19일 17:19에 Maciej Purski 이(가) 쓴 글: >> The current implementation assumes that the only possible peripheral >> device for DSIM is a panel. Using an output bridge child device >> should also be possible. &

[GIT PULL] exynos-drm-next

2018-07-25 Thread Inki Dae
Hi Dave, Two big cleanups to suspend/resume code and g2d driver including trivial one. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 2d3bda7071a713fa4ecf9d0acb7faede6d59100a: Merge tag 'exynos-drm-fixes-for-v4.18-rc

Re: [PATCH v3 1/9] drm/exynos: rename "bridge_node" to "mic_bridge_node"

2018-07-25 Thread Inki Dae
2018년 07월 25일 17:11에 Andrzej Hajda 이(가) 쓴 글: > On 24.07.2018 09:49, Inki Dae wrote: >> Hi, >> >> 2018년 06월 19일 17:19에 Maciej Purski 이(가) 쓴 글: >>> When adding support for peripheral out bridges, the "bridge" name >>> becomes imprecise as it refe

Re: [PATCH v5 2/9] drm/exynos: move connector creation to attach callback

2018-08-07 Thread Inki Dae
ge without considering device tree graph binding? Then, you embedded bridge device node in dsi device node[1] but the binding document below doesn't mention about this, Documentation/devicetree/bindings/display/exynos/exynos_dsim.txt [1] https://lkml.org/lkml/2018/6/19/237 Thanks, Inki Da

[PATCH] drm/exynos: Add missing includes

2013-08-13 Thread Inki Dae
ader file differs from the one of .c file? I will apply it to -next but I'd like to understand why this patch is needed surely. And it seems like that other drivers have same issue also. :) Thanks, Inki Dae > Signed-off-by: Mark Brown > --- > drivers/gpu/drm/exynos/exynos_drm_co

[RFC PATCH v6 0/2] Introduce buffer synchronization framework

2013-08-13 Thread Inki Dae
<- vsync signal |<-- Displayed on screen | | | | <- vsync signal Thanks, Inki Dae References: [1] http://lwn.net/Articles/470339/ [2] https://patchwork.kernel.org/patch/2625361/ [3] htt

[PATCH 1/2] [RFC PATCH v6] dmabuf-sync: Add a buffer synchronization framework

2013-08-13 Thread Inki Dae
once. References: [1] http://lwn.net/Articles/470339/ [2] https://patchwork.kernel.org/patch/2625361/ [3] http://linux.die.net/man/2/fcntl Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- Documentation/dma-buf-sync.txt | 285 + drivers/base/Kconfig |7 +

[PATCH 2/2] [RFC PATCH v2] dma-buf: Add user interfaces for dmabuf sync support.

2013-08-13 Thread Inki Dae
ler doesn't use intefaces for the DMA device driver. Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/base/dma-buf.c | 81 +++ include/linux/dmabuf-sync.h |1 + 2 files changed, 82 insertions(+), 0 deletions(-) diff --gi

[PATCH] drm/exynos: Add missing includes

2013-08-13 Thread Inki Dae
> -Original Message- > From: linux-samsung-soc-owner at vger.kernel.org [mailto:linux-samsung-soc- > owner at vger.kernel.org] On Behalf Of Mark Brown > Sent: Tuesday, August 13, 2013 6:54 PM > To: Inki Dae > Cc: 'David Airlie'; linux-samsung-soc at vger

<    3   4   5   6   7   8   9   10   11   12   >