agreement with media guys. for this patch, you can refer to below link,
http://comments.gmane.org/gmane.comp.video.dri.devel/74504
if there is any problem, please let me know.
Thanks.
Inki Dae
The following changes since commit 29cb602532b0a82f22322cece8a89f022368d557:
drm/exynos: added
/74504
if there is any problem, please let me know.
Thanks,
Inki Dae
The following changes since commit 29cb602532b0a82f22322cece8a89f022368d557:
drm/exynos: added device object to subdrv's remove callback as argument
(2012-10-04 10:05:59 +0900)
are available in the git repository at:
2012/10/9 Rob Clark :
> From: Rob Clark
>
> Add a helper fxn to send vblank event after pageflip, plus a handful
> of fixes for other issues that I noticed in the process.
>
patches 1, 5 and 6 are:
Reviewed-by: Inki Dae
2012? 10? 12? Rahul Sharma?? ??:
> This patch moved the exynos-drm-hdmi platform device registration to the
> drm
> driver. When DT is enabled, platform devices needs to be registered within
> the
> driver code. This patch fits the requirement of both DT and Non DT based
> drm
> drivers.
>
>
this makes unnecessary
declarations and definitions are included. and also leave comments to each
declaration.
"int exynos_platform_device_hdmi_register(void);
void exynos_platform_device_hdmi_unregister(void);"
Thanks,
Inki Dae
>
> #define DRIVER_NAME "exynos"
Applied.
Thanks,
Inki Dae
2012/10/16 Rahul Sharma :
> This patch adds drm-exynos and drm-exynos-hdmi device registration to the
> drm driver. It was happening in machine init code earlier which is not
> acceptable for dt enabled platforms.
>
> Patch which cleans the respective cod
llback call be ignored so display power
couldn't become on again.
This patch removes exynos_encoder->dpms changing and adds 'updated'
variable to exynos_drm_encoder structure to avoid duplicated overlay
updating.
Signed-off-by: Inki Dae
Signed-off-by: Kyungmin Park
---
dr
el support
> video: panel: Add R61517 panel support
how about using 'buses' directory instead of 'panel' and adding
'panel' under that like below?
video/buess: display bus frameworks such as MIPI-DBI/DSI and eDP are placed.
video/buess/panel: panel drivers
ld start the video stream in between.
>
> I realize this could be done with the PANEL_ENABLE_* levels in your RFC,
> but I don't think the concepts quite match:
>
> - PANEL_ENABLE_BLANK level is needed for "smart panels", as we need to
> configure them and send the
correct some typo. Sorry for this.
2012/10/20 Inki Dae :
> Hi Laurent. sorry for being late.
>
> 2012/8/17 Laurent Pinchart :
>> Hi everybody,
>>
>> While working on DT bindings for the Renesas Mobile SoC display controller
>> (a.k.a. LCDC) I quickly realized
e above patch is in progress so we have to wait
for the patch to be merged to mainline.
Thanks,
Inki Dae
Inki Dae (3):
drm/exynos: add iommu support for exynos drm framework
drm/exynos: add iommu support to fimd driver
drm/exynos: add iommu support for hdmi driver
drivers/gpu/drm/exynos/Kconfi
dma mapping api so
this patch uses one iommu mapping for all sub drivers. In other words,
all sub drivers have same iommu mapping.
Signed-off-by: Inki Dae
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/Kconfig | 6 +
drivers/gpu/drm/exynos/Makefile| 1
From: Inki Dae
The iommu will be enabled when fimd sub driver is probed and
will be disabled when removed.
Signed-off-by: Inki Dae
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu
From: Inki Dae
The iommu will be enabled when hdmi sub driver is probed and
will be disabled when removed.
Signed-off-by: Inki Dae
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 15 +++
drivers/gpu/drm/exynos/exynos_drm_hdmi.h | 1 +
drivers/gpu/drm
From: Inki Dae
Changelog v2:
- fix dma_ops check condition of drm_iommu_attach_device function.
. check archdata.dma_ops of drm device instead of
subdrv device's one.
- code clean to exynos_drm_iommu.c file.
. remove '#ifdef CONFIG_ARM_DMA_USE_IOMMU' from exynos_drm_iomm
mmu table and removed some existing codes and added
new some codes for iommu support.
GEM allocation requires one device object to use dma mapping api so
this patch uses one iommu mapping for all sub drivers. In other words,
all sub drivers have same iommu mapping.
Signed-off-by: Inki Dae
Signed-
functions take a reference to a gem handle so that the gem
object used by g2d dma is released properly.
And runqueue_node has a pointer to drm_file object of current
process to manage gem handles to owner.
Signed-off-by: Inki Dae
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos
2012/10/18 Eunchul Kim :
> Hi All.
>
> I am responsible for a display part from Samsung Electronics
> Telecommunication Division.
> and I am going to add post-processing features in exynos drm.
> If you have some opinion of this patch,
> please give some comments about my patch.
>
> IPP is stands
iled to allocate event.\n");
> + spin_lock_irqsave(&drm_dev->event_lock, flags);
> + file->event_space += sizeof(e->event);
> + spin_unlock_irqrestore(&drm_dev->event_lock, flags);
> + return -ENOMEM;
> + }
> +
> + /* make event */
> + e->event.base.type = DRM_EXYNOS_IPP_EVENT;
> + e->event.base.length = sizeof(e->event);
> + e->event.user_data = qbuf->user_data;
> + e->event.prop_id = qbuf->prop_id;
> + e->event.buf_id[EXYNOS_DRM_OPS_DST] = qbuf->buf_id;
> + e->base.event = &e->event.base;
> + e->base.file_priv = file;
> + e->base.destroy = ipp_free_event;
> + list_add_tail(&e->base.link, &c_node->event_list);
> +
> + return 0;
> +}
> +
> +static void ipp_put_event(struct drm_exynos_ipp_cmd_node *c_node,
> + struct drm_exynos_ipp_queue_buf *qbuf)
> +{
> + struct drm_exynos_ipp_send_event *e, *te;
> + int count = 0;
> +
> + if (list_empty(&c_node->event_list)) {
> + DRM_DEBUG_KMS("%s:event_list is empty.\n", __func__);
> + return;
> + }
> +
> + list_for_each_entry_safe(e, te, &c_node->event_list, base.link) {
> + DRM_DEBUG_KMS("%s:count[%d]e[0x%x]\n",
> + __func__, count++, (int)e);
> +
> + if (!qbuf) {
> + /* delete list */
> + list_del(&e->base.link);
> + kfree(e);
> + } else if (e->event.buf_id[EXYNOS_DRM_OPS_DST]
> + == qbuf->buf_id) {
> + /* delete list */
> + list_del(&e->base.link);
> + kfree(e);
> + return;
> + }
> + }
> +
> + return;
> +}
> +
> +void ipp_handle_cmd_work(struct device *dev,
> + struct exynos_drm_ippdrv *ippdrv,
> + struct drm_exynos_ipp_cmd_work *cmd_work,
> + struct drm_exynos_ipp_cmd_node *c_node)
> +{
> + struct ipp_context *ctx = get_ipp_context(dev);
> +
> + cmd_work->ippdrv = ippdrv;
> + cmd_work->c_node = c_node;
> + queue_work(ctx->cmd_workq, (struct work_struct *)cmd_work);
> +}
> +
> +int exynos_drm_ipp_queue_buf(struct drm_device *drm_dev, void *data,
> + struct drm_file *file)
> +{
> + struct drm_exynos_file_private *file_priv = file->driver_priv;
> + struct exynos_drm_ipp_private *priv = file_priv->ipp_priv;
> + struct device *dev = priv->dev;
> + struct ipp_context *ctx = get_ipp_context(dev);
> + struct drm_exynos_ipp_queue_buf *qbuf = data;
> + struct exynos_drm_ippdrv *ippdrv;
> + struct drm_exynos_ipp_property *property;
> + struct exynos_drm_ipp_ops *ops;
> + struct drm_exynos_ipp_cmd_node *c_node;
> + struct drm_exynos_ipp_mem_node *m_node, *tm_node;
> + int ret;
> +
> + DRM_DEBUG_KMS("%s\n", __func__);
> +
> + if (!qbuf) {
> + DRM_ERROR("invalid buf parameter.\n");
> + return -EINVAL;
> + }
> +
> + ippdrv = ipp_find_drv_node(qbuf->prop_id);
> +
> + if (!ippdrv) {
> + DRM_ERROR("failed to get ipp driver.\n");
> + return -EINVAL;
return -EFAULT;
> + }
> +
> + if (qbuf->ops_id >= EXYNOS_DRM_OPS_MAX) {
> + DRM_ERROR("invalid ops parameter.\n");
> + return -EINVAL;
> + }
> +
> + ops = ippdrv->ops[qbuf->ops_id];
> + if (!ops) {
> + DRM_ERROR("failed to get ops.\n");
> + return -EINVAL;
return -EFAULT;
> + }
> +
> + DRM_DEBUG_KMS("%s:prop_id[%d]ops_id[%s]buf_id[%d]buf_type[%d]\n",
> + __func__, qbuf->prop_id, qbuf->ops_id ? "dst" : "src",
> + qbuf->buf_id, qbuf->buf_type);
> +
> + /* find command node */
> + c_node = ipp_find_id(&ctx->prop_idr, &ctx->prop_lock,
> + qbuf->prop_id);
> + if (!c_node) {
> + DRM_ERROR("failed to get command node.\n");
> + return -EINVAL;
return -EFAULT;
Eunchul, it seems like that your patch set should be more cleared and
simply. Please re-post them again as RFC after more clean.
Thanks,
Inki Dae
Signed-off-by: Inki Dae
Signed-off-by: Kyungmin Park
---
MAINTAINERS |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 027ec2b..8a8529f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2500,6 +2500,7 @@ M:Joonyoung Shim
M: Seung
s.
>>
>> Signed-off-by: Rob Clark
>> ---
>> drivers/gpu/drm/exynos/Kconfig |2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> As this isn't in the drivers/staging/ directory, I can't take this, it
> should
's better to go to -fixes. So will apply it to -fixes.
Thanks,
Inki Dae
> Signed-off-by: Rahul Sharma
> ---
> drivers/gpu/drm/exynos/exynos_mixer.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c
> b/d
.html
And this just flags ARCH_MULTIPLATFORM in Kconfig.
Thanks,
Inki Dae
2012/10/31 :
> Hi Dave,
>
> As I posted before, we have added a new git repository for Exynos drm
> to MAINTAINERS file so change it to new one like below,
>from git://git.infradead.org/users/kmpark/
Applied. Thanks.
2012/8/29 Sachin Kamat :
> On 29 August 2012 12:32, Joonyoung Shim wrote:
>> On 08/28/2012 05:41 PM, Sachin Kamat wrote:
>>>
>>> Fixes the following warning:
>>> drivers/gpu/drm/exynos/exynos_drm_g2d.c:897:1: warning:
>>> symbol 'g2d_pm_ops' was not declared. Should it be static?
Applied. Thanks.
2012/8/31 Sachin Kamat :
> Fixes the following checkpatch warnings:
> WARNING: sizeof *res should be sizeof(*res)
> WARNING: sizeof res->regul_bulk[0] should be sizeof(res->regul_bulk[0])
> WARNING: sizeof *res should be sizeof(*res)
>
> Signed-off-by: Sachin Kamat
> ---
> drive
Applied. Thanks.
2012/8/31 Sachin Kamat :
> Fixes the following checkpatch warnings:
> WARNING: sizeof filter_y_horiz_tap8 should be sizeof(filter_y_horiz_tap8)
> WARNING: sizeof filter_y_vert_tap4 should be sizeof(filter_y_vert_tap4)
> WARNING: sizeof filter_cr_horiz_tap4 should be sizeof(filter_
problem, please let me know.
Thanks,
Inki Dae
Inki Dae (11):
drm/exynos: added device object to subdrv's remove callback as argument
drm/exynos: separated subdrv_probe function into two parts.
drm/exynos: fixed page align bug.
drm/exynos: separeated fimd_power_on into s
2012/9/3 Dave Airlie :
> On Mon, Sep 3, 2012 at 2:47 PM, Inki Dae wrote:
>> Hi Dave,
>>
>> this patch set fixes minor issues and also includes exception codes
>> and code clean.
>>
>> Highlights:
>> - fix modesetting
>> - check pixel format
Hi Dave,
this patch set fixes build warnings and includes minor code cleanup.
other patches posted before will go to -next because they include big changes.
Highlights:
- fix build warnings
- minor code cleanup
if there is any problem, please let me know.
Thanks.
Inki Dae
The following
2012/8/16 Leela Krishna Amudala :
> Add device tree based discovery support for DRM-FIMD driver.
>
> Signed-off-by: Leela Krishna Amudala
> ---
> Documentation/devicetree/bindings/fb/drm-fimd.txt | 80 +
> drivers/gpu/drm/exynos/exynos_drm_fimd.c | 95
> +
2012/8/16 Leela Krishna Amudala :
> The name of the exynos drm fimd device is renamed to exynos-drm-fimd
> and two device ids are created for exynos4-fb and exynos5-drm-fimd.
> Also, added driver data for exynos5 to pick the fimd version at runtime and
> to choose the VIDTCON register offsets accor
Hi Dave.
please do not pull it yet. this pull request includes a wrong patch so
I will fix it soon. sorry for inconvenient.
Thanks.
Inki Dae
2012/9/3 Inki Dae :
> Hi Dave,
>
> this patch set fixes build warnings and includes minor code cleanup.
> other patches posted before will
From: Tomasz Stanislawski
This patch adds a stub function for DMABUF mmap.
This allows to export a DMABUF.
Signed-off-by: Tomasz Stanislawski
Signed-off-by: Kyungmin Park
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_drm_dmabuf.c |7 +++
1 files changed, 7 insertions
r:
>
> [6.363842] drm_prime_init_file edc2e5d0
> [6.363994] drm_prime_destroy_file edc2e5d0
> [6.364260] drm_prime_init_file edc2e750
> [8.004837] drm_prime_init_file ee36ded0
>
> Signed-off-by: Mandeep Singh Baines
> CC: St?phane Marchesin
> CC: Pawel Osciak
> CC
device name of fimd clock. so to
use 'exynos4-fimd', we should modify the device name of fimd clock
from 'exynos4-fb' to 'exynos4-fimd' and also ids definitions of
s3c-fb and drm fimd driver. so my conclusion is that it merges this
patch set as is and then let's modify related things later.
any opinions, welcome~ anytime.
Thanks.
Inki Dae
Hi,
2012/9/6 Paul Menzel :
> Dear Inki Dae,
>
>
> Am Donnerstag, den 06.09.2012, 11:35 +0900 schrieb InKi Dae:
>
>> 2012/9/6 Mandeep Singh Baines :
>> > The double invocations are incorrect but seem to be safe so I don't
>> > think this will fix any bug
Applied.
Thanks,
Inki Dae
2012/9/7 Mandeep Singh Baines :
> The double invocations are incorrect but seem to be safe so I don't
> think this will fix any bugs.
>
> Before:
>
> [7.639366] drm_prime_init_file ee3675d0
> [7.639377] drm_prime_init_fil
Hi
2012/9/7 Leela Krishna Amudala :
> Hi,
>
> On Thu, Sep 6, 2012 at 4:35 PM, Sylwester Nawrocki
> wrote:
>> Hi,
>>
>> On 09/06/2012 09:21 AM, InKi Dae wrote:
>>>>> +Required properties:
>>>>> + - compatible: Should be "samsung,exy
2012/9/7 Inki Dae :
> Hi
>
> 2012/9/7 Leela Krishna Amudala :
>> Hi,
>>
>> On Thu, Sep 6, 2012 at 4:35 PM, Sylwester Nawrocki
>> wrote:
>>> Hi,
>>>
>>> On 09/06/2012 09:21 AM, InKi Dae wrote:
>>>>>> +Required propertie
Applied.
Thanks.
Inki Dae
2012/9/7 Leela Krishna Amudala :
> This patch set adds device tree support for DRM-FIMD for Samsung's Exynos5250.
> It includes parsing platform data from dts file. Also, adds the driver data
> for exynos4 and exynos5 devices.
>
> This patchset is
this patch removes DRM_FORMAT_NV12M from plane module because this format
is same as DRM_FORMAT_NV12. DRM_FORMAT_NV12M will be identified by
mode_cmd->handles and mode_cmd->offsets fields internally.
Signed-off-by: Inki Dae
Signed-off-by: Kyungmin.park
---
drivers/gpu/drm/
know.
Thanks.
Inki Dae
The following changes since commit df5c2b713f6bda08f7d668fe5b95a36a4b70a000:
Merge branch 'drm-fixes' of git://people.freedesktop.org/~airlied/linux into
drm-fixes (2012-09-07 15:35:27 +0900)
are available in the git repository at:
git://git.infradead
Changelog v2:
fix pm operation when resume.
Changelog v1:
this patch separetes fimd_power_on into fimd_activate and fimd_clock and
fimd_activate function will call fimd_clock to control fimd power and
vsync interrupt.
Signed-off-by: Inki Dae
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm
overlay data aren't applied
to real hardware when dpms off goes to on after setcrtc
was requested like below,
dpms off -> setcrtc -> dpms off -> dpms on
For this, it makes encoder's dpms to be updated when
setcrtc is requested.
Signed-off-by: Inki Dae
Signed-off-by: Kyu
branch of
git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos
Signed-off-by: Inki Dae
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/exynos_drm_gem.c | 23 ++-
1 files changed, 22 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_
need vblank signal.
Signed-off-by: Inki Dae
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/exynos_drm_encoder.c | 17 +++--
1 files changed, 7 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_encoder.c
b/drivers/gpu/drm/exynos/exynos_drm_enco
eference to gem object when
specific gem mmap is requested. For this, it sets
dev->driver->gem_vm_ops to vma->vm_ops.
And this patch is based on exynos-drm-next-iommu branch of
git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos
Signed-off-by: Inki Dae
Sign
erlay data to real hardware does need vblank signal.
Signed-off-by: Inki Dae
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/exynos_drm_encoder.c | 43 --
drivers/gpu/drm/exynos/exynos_drm_encoder.h |1 +
drivers/gpu/drm/exynos/exynos_drm_fb.c |4
2012/11/15 Prathyush K
> This patch adds a exynos drm specific implementation of fb_mmap.
> The root framebuffer is allocated using dma_alloc_attrs which can
> allocate a contig or noncontig buffer depending on whether an iommu
> is attached to drm device or not. The default fb_mmap function
> al
Hi All,
This patch has been tested with only Exynos driver so other maintainers may
need to test this.
Acked-by: Inki Dae
2012/11/15 Seung-Woo Kim
> Increasing ref counts of both dma-buf and gem for imported dma-buf
> come from gem makes memory leak. release function of dma-buf canno
> drm_encoder *encoder, void *data)
>* because the setting for disabling the overlay will be updated
>* at vsync.
>*/
> - if (overlay_ops->wait_for_vblank)
> + if (overlay_ops && overlay_ops->wait_for_vblank)
>
Please, combine these patches.
Thanks,
Inki Dae
> -Original Message-
> From: Sachin Kamat [mailto:sachin.ka...@linaro.org]
> Sent: Monday, November 19, 2012 5:38 PM
> To: dri-devel@lists.freedesktop.org
> Cc: inki@samsung.com; jy0922.s...@samsung.com;
sachin.ka...@lin
> -Original Message-
> From: Sachin Kamat [mailto:sachin.ka...@linaro.org]
> Sent: Monday, November 19, 2012 6:56 PM
> To: Inki Dae
> Cc: dri-devel@lists.freedesktop.org; jy0922.s...@samsung.com;
> patc...@linaro.org
> Subject: Re: [PATCH 1/1] drm/exynos: Fix p
Applied.
Thanks,
Inki Dae
> -Original Message-
> From: Sachin Kamat [mailto:sachin.ka...@linaro.org]
> Sent: Monday, November 19, 2012 6:53 PM
> To: dri-devel@lists.freedesktop.org
> Cc: inki@samsung.com; jy0922.s...@samsung.com;
sachin.ka...@linaro.org;
>
vma->vm_flags |= VM_IO | VM_DONTEXPAND | VM_DONTDUMP;
> How do you sure VM_MIXEDMAP is not required?
>
With iommu, VM_MIXEDMAP flag would be set internally.
> > +
> > + vm_size = vma->vm_end - vma->vm_start;
> > +
> > + if (vm_size > buffer->s
Hi Dave,
This pull request fixes minor issues and includes code cleanup.
If there is any problem, please let me know.
Thanks,
Inki Dae
The following changes since commit 6f755116c93ca35f496ccf1910dcd28cd16713e3:
Merge branch 'drm-intel-fixes' of
git://people.freedesktop.org/~
Could you please re-send this patch updating like below?
For example,
[PATCH ] drm/exynos: fix memory leak to edid
some comments.
Thanks,
Inki Dae
2012/11/20 Egbert Eich
> Signed-off-by: Egbert Eich
> ---
> drivers/gpu/drm/exynos/exynos_hdmi.c |1 +
> 1 files changed,
drm/exynos: remove 'pages' and 'page_size' elements in exynos gem buffer
And this includes also previous pull request to exynos-drm-fixes.
If there is any problem, plese let me know.
Thanks,
Inki Dae
The following changes since commit bf6f036848ab2151c2498f11cb7d31a52a95
Signed-off-by: YoungJun Cho
Signed-off-by: Inki Dae
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/exynos_drm_plane.c | 12 +++-
1 files changed, 11 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_plane.c
b/drivers/gpu/drm/exynos/exynos_drm_plane
Ok, I modifed the subject of your patch like below and applied.
drm/exynos: fix memory lean to EDID block
Thanks,
Inki Dae
2012/11/20 Egbert Eich
> drm_get_edid() returns a pointer to an EDID block. The caller
> is responsible to free this pointer itself.
> Here the pointer gets as
Applied.
Thanks,
Inki Dae
2012/11/20 Rahul Sharma
> This patch is to preserve the display mode header during the mode
> adjustment.
> Display mode header is overwritten with the adjusted mode header which is
> throwing the stack dump.
>
> Signed-off-by: Rahul Sharma
> -
Applied.
Thanks,
Inki Dae
2012/11/20 Prathyush K
> Changelog v2:
>
> Removed redundant check for invalid sgl.
> Added check for valid page_offset in the beginning of
> exynos_drm_gem_map_buf.
>
> Changelog v1:
>
> The 'pages' structure is not required
exynos: add ipp subsystem
drm/exynos: add fimc ipp driver
drm/exynos: add rotator ipp driver
drm/exynos: add gsc ipp driver
but they didn't reviewed enough yet so may not be merged to -next this time.
Thanks,
Inki Dae
2012/11/20 Inki Dae
> Hi Dave,
>
> Thi
Right, I missed.
Thanks,
Inki Dae
> -Original Message-
> From: Prathyush K [mailto:prathyus...@samsung.com]
> Sent: Thursday, November 22, 2012 3:49 PM
> To: dri-devel@lists.freedesktop.org
> Cc: inki@samsung.com
> Subject: [PATCH] drm/exynos: use sgt instead of pag
> -Original Message-
> From: Sachin Kamat [mailto:sachin.ka...@linaro.org]
> Sent: Thursday, November 22, 2012 3:13 PM
> To: Inki Dae
> Cc: dri-devel@lists.freedesktop.org; jy0922.s...@samsung.com;
> patc...@linaro.org
> Subject: Re: [PATCH 1/1] drm/exynos: Fix p
> -Original Message-
> From: Sachin Kamat [mailto:sachin.ka...@linaro.org]
> Sent: Thursday, November 22, 2012 5:19 PM
> To: Inki Dae
> Cc: dri-devel@lists.freedesktop.org; jy0922.s...@samsung.com;
> patc...@linaro.org
> Subject: Re: [PATCH 1/1] drm/exynos: Fix p
s-drm-fixes branch of
> git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git
>
>
Please rebase these patches to be based on exynos-drm-next. These should go
to -next.
Thanks,
Inki Dae
> Rahul Sharma (1):
> drm: exynos: compose and send avi and aui info frames
ev)
>
> err_clk:
> clk_disable(ctx->lcd_clk);
> - clk_put(ctx->lcd_clk);
clk_disable shouldn't be called here so let's cleanup this also to reduce
unnecessary cleanup commits.
>
> err_bus_clk:
> clk_disable(ctx->bus_clk);
> - clk_put(ctx->
ed patches?
You've been submitting patches into too small pieces.
Because they are trivial enough and in the same context, please merge this
kind of patches as long as they are related with the same class or topics. I
think you can combine them. :)
Thanks,
Inki Dae
> e
> -Original Message-
> From: Sachin Kamat [mailto:sachin.ka...@linaro.org]
> Sent: Friday, November 23, 2012 12:42 PM
> To: dri-devel@lists.freedesktop.org
> Cc: inki@samsung.com; jy0922.s...@samsung.com; airl...@linux.ie;
> sachin.ka...@linaro.org; patc...@linaro.org
> Subject: [PATC
Applied.
Thanks,
Inki Dae
> -Original Message-
> From: Sachin Kamat [mailto:sachin.ka...@linaro.org]
> Sent: Friday, November 23, 2012 12:42 PM
> To: dri-devel@lists.freedesktop.org
> Cc: inki@samsung.com; jy0922.s...@samsung.com; airl...@linux.ie;
> sachin.ka..
This was my missing point. Applied.
Thanks,
Inki Dae
> -Original Message-
> From: Sachin Kamat [mailto:sachin.ka...@linaro.org]
> Sent: Friday, November 23, 2012 12:42 PM
> To: dri-devel@lists.freedesktop.org
> Cc: inki@samsung.com; jy0922.s...@samsung.com; a
Applied.
Thanks,
Inki Dae
> -Original Message-
> From: Sachin Kamat [mailto:sachin.ka...@linaro.org]
> Sent: Friday, November 23, 2012 5:43 PM
> To: dri-devel@lists.freedesktop.org
> Cc: inki@samsung.com; sachin.ka...@linaro.org; patc...@linaro.org
> Subject:
Applied.
Thanks,
Inki Dae
> -Original Message-
> From: Sachin Kamat [mailto:sachin.ka...@linaro.org]
> Sent: Friday, November 23, 2012 5:43 PM
> To: dri-devel@lists.freedesktop.org
> Cc: inki@samsung.com; sachin.ka...@linaro.org; patc...@linaro.org
> Subject:
The subject mentions just only 'use devm_clk_get in exynos_dev_fimd.c' but
this patch removes unnecessary clk_disable calls also. Just separate this
patch into two as you mentioned. For this, already applied old one. So could
you send another one? Sorry for inconvenient. :)
Thanks
Sorry but could you re-send this one more time? below is my comment.
Thanks,
Inki Dae
> -Original Message-
> From: Rahul Sharma [mailto:rahul.sha...@samsung.com]
> Sent: Friday, November 23, 2012 6:17 PM
> To: dri-devel@lists.freedesktop.org
> Cc: airl...@redhat.com; inki.
0, "drm_fimd", ctx);
> if (ret) {
> dev_err(dev, "irq request failed.\n");
> - goto err_clk;
> + return ret;
> }
>
> ctx->vidcon0 = pdata->vidcon0;
> @@ -915,15 +912,6 @@ sta
Let's update one more time. Below is my comments.
> -Original Message-
> From: Rahul Sharma [mailto:rahul.sha...@samsung.com]
> Sent: Friday, November 23, 2012 9:04 PM
> To: dri-devel@lists.freedesktop.org
> Cc: inki@samsung.com; kgene@samsung.com; r.sh.o...@gmail.com;
> sw0312
Please, comply with patch format next time. Applied.
Thank,
Inki Dae
> -Original Message-
> From: Rahul Sharma [mailto:rahul.sha...@samsung.com]
> Sent: Monday, November 26, 2012 2:23 PM
> To: dri-devel@lists.freedesktop.org
> Cc: inki@samsung.com; kgene@sams
Applied.
Thanks,
Inki Dae
> -Original Message-
> From: Sachin Kamat [mailto:sachin.ka...@linaro.org]
> Sent: Monday, November 26, 2012 1:17 PM
> To: dri-devel@lists.freedesktop.org
> Cc: inki@samsung.com; sachin.ka...@linaro.org; patc...@linaro.org;
> airl...@
know.
Thanks,
Inki Dae
The following changes since commit 660c51e92f5357f351b483fa9d82451344ed25a4:
drm/exynos: add exynos drm specific fb_mmap function (2012-11-29 03:30:38
-0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git
exyno
2012/11/29 Daniel Vetter
> On Thu, Nov 29, 2012 at 1:11 PM, Inki Dae wrote:
> > - add sending AVI and AVI info frames.
> > . this adds some codes for composing AVI and AUI info frames
> > and send them every VSYNC for HDMI Certification.
>
> Imo we have a
count = 0(released)
b. obj_refcount = 0(released) once name_ref_count = 0
There may be my missing point so please give me any advice.
Thanks,
Inki Dae
Signed-off-by: Inki Dae
---
drivers/gpu/drm/drm_gem.c | 41 ++---
include/drm/drmP.h| 12
2012/11/30 Inki Dae
> Hello, all.
>
> This patch introduces reference count of gem object name and resolves
> the below issue.
>
> In case that proces A shares its own gem object with process B,
> process B opens a gem object name from process A to get its own
> gem
From: Inki Dae
Hello, all.
This patch introduces reference count of gem object name and resolves
the below issue.
In case that proces A shares its own gem object with process B,
process B opens a gem object name from process A to get its own
gem handle. But if process A closes the gem handle
sn't
released instead of handle.
And this is the reason that we need this patch.
Thanks,
Inki Dae
>
> Cheers, Daniel
>
> On Fri, Nov 30, 2012 at 10:10 AM, Inki Dae wrote:
> > Hello, all.
> >
> > This patch introduces reference count of gem object name and reso
s is complicated a little bit.
Thanks for your checking. :)
Thanks,
Inki Dae
And below addes my comments on your codes.
/* obj->handle_count = 1, obj->refcount = 1 */
ret = ioctl(fd2, DRM_IOCTL_I915_GEM_CREATE, &create);
assert(ret == 0);
flink.handle = create.handle;
/*
2012/12/3 Prathyush K
> Changelog v2:
>
> Implement copy sgt code in exynos_get_sgt itself instead of calling
> sg_clone_table.
>
>
Now we are working on dmabuf feature update that adds attach and detach
callbacks and with this patch, exynos_get_sgt function will be removed.
For this, please refe
we are enough to leave
comment so that this can be fixed. Otherwise, unnecessary commits could be
applied to mainline.
So I will post patch v2 for hdmi iommu support.
Thanks,
Inki Dae
>
> And this patch is based on exynos-drm-next-iommu branch of
> git://git.kernel.org/pub/scm/linux/
ow in exynos5250.dtsi
sysmmu-tv {
-
mmu-master = <&mixer>;
};
Changelog v1:
The iommu will be enabled when hdmi sub driver is probed and
will be disabled when removed.
Signed-off-by: Inki Dae
Signed-off-by: Kyungmin Park
---
drivers
And Below is my comments and please send them as code cleanup. Actually,
your patch includes code cleanup also.
Thanks,
Inki Dae
2012/12/3 Prathyush K
> According to the new IOMMU framework for exynos sysmmus, the owner
> of the sysmmu-tv is mixer (which is the actual device that do
y if dma is going to access memory region to fb and decreases
old fb's because the old fb isn't accessed by dma anymore.
This could guarantee releasing gem buffer to the fb after dma
access to the gem buffer has been completed.
Signed-off-by: Inki Dae
Signed-off-by: Kyungmin Par
2012/12/4 Prathyush K
>
>
>
> On Tue, Dec 4, 2012 at 5:44 PM, Inki Dae wrote:
>
>> Changelog v2:
>> fix page fault issue.
>> - defer to unreference old fb to avoid page fault issue.
>> So with this fixup, new fb would be updated to hardware
>>
;drm/exynos: release fb pended by
> page flip"
> I could not find any crash/page_fault in drm with fimd/hdmi during hotplug
> and page flips.
>
>
It seems better than old one and also including some exception codes, Patch
3 we did't consider. Ok, we will test these patches a
2012/12/5 Daniel Vetter
> On Tue, Dec 4, 2012 at 1:14 PM, Inki Dae wrote:
> > Changelog v2:
> > fix page fault issue.
> > - defer to unreference old fb to avoid page fault issue.
> > So with this fixup, new fb would be updated to hardware
> > prior to old
2012/12/5 Inki Dae
>
>
> 2012/12/4 Prathyush K
>
>>
>>
>>
>> On Tue, Dec 4, 2012 at 5:44 PM, Inki Dae wrote:
>>
>>> Changelog v2:
>>> fix page fault issue.
>>> - defer to unreference old fb to avoid page fault issue.
>>
2012/12/5 Inki Dae
>
>
> 2012/12/5 Prathyush K
>
>> This patchset fixes a few issues with use of wait for vblank in
>> exynos drm.
>>
>> Please apply these three patches without "drm/exynos: release fb pended
>> by page flip"
>> patch.
uffer allocate and deallocate and
> you can see that deallocate does not get called for fb1.
>
> And also, I see a new dma-address getting created each time - e.g.
> 2040, 2080, 20C0.
>
> Please check modetest without enabling flipping. modetest -s 17@4
> :1280x720.
&g
2012/12/5 Prathyush K
>
>
>
> On Wed, Dec 5, 2012 at 11:40 AM, Inki Dae wrote:
>
>>
>>
>> 2012/12/5 Inki Dae
>>
>>>
>>>
>>> 2012/12/5 Prathyush K
>>>
>>>> This patchset fixes a few issues with use of wait
2012/12/5 Inki Dae
>
>
> 2012/12/5 Prathyush K
>
>>
>>
>>
>> On Wed, Dec 5, 2012 at 11:40 AM, Inki Dae wrote:
>>
>>>
>>>
>>> 2012/12/5 Inki Dae
>>>
>>>>
>>>>
>>>>
1001 - 1100 of 3085 matches
Mail list logo
