Re: [PATCH v6 00/10] rockchip: kevin: Enable edp display

2017-10-30 Thread Heiko Stuebner
Hi Jeffy, Sean, Am Donnerstag, 19. Oktober 2017, 11:48:02 CET schrieb Jeffy Chen: > > Make edp display works on chromebook kevin(at least for boot animation). > > Also solve some issues i meet during the bringup. > > Changes in v6: > Don't change order of rockchip_drm_psr_register(). > > Chang

Re: [PATCH v4 01/38] drm/bridge: analogix_dp: set psr activate/deactivate when enable/disable bridge

2018-03-08 Thread Heiko Stuebner
Am Montag, 5. März 2018, 23:22:53 CET schrieb Enric Balletbo i Serra: > From: zain wang > > There's a race between when bridge_disable and when vop_crtc_disable > are called. If the flush timer triggers a new psr work between these, > we will operate eDP without power shutdowned by bridge_disable

Re: [PATCH v4 02/38] drm/rockchip: Don't use atomic constructs for psr

2018-03-08 Thread Heiko Stuebner
Am Montag, 5. März 2018, 23:22:54 CET schrieb Enric Balletbo i Serra: > From: Sean Paul > > Instead of using timer and spinlocks, use delayed_work and > mutexes for rockchip psr. This allows us to make blocking > calls when enabling/disabling psr (which is sort of important > given we're talking

Re: [PATCH v4 03/38] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2018-03-08 Thread Heiko Stuebner
Hi Enric, Am Montag, 5. März 2018, 23:22:55 CET schrieb Enric Balletbo i Serra: > From: Yakir Yang > > Make sure the request PSR state takes effect in analogix_dp_send_psr_spd() > function, or print the sink PSR error state if we failed to apply the > requested PSR setting. > > Cc: 征增 王 > Cc:

Re: [PATCH v5 07/36] drm/bridge: analogix_dp: Move enable video into config_video()

2018-03-17 Thread Heiko Stuebner
Hi Archit, Am Mittwoch, 14. März 2018, 06:59:59 CET schrieb Archit Taneja: > On Saturday 10 March 2018 03:52 AM, Enric Balletbo i Serra wrote: > > From: Lin Huang > > > > We need to enable video before analogix_dp_is_video_stream_on(), so > > we can get the right video stream status. > > > > Cc

Re: [PATCH v7 1/3] dt-bindings: display: Add Document for Rockchip Soc LVDS

2017-08-29 Thread Heiko Stuebner
Am Dienstag, 29. August 2017, 18:17:11 CEST schrieb Mark yao: > On 2017年08月23日 14:26, Sandy Huang wrote: > > This patch add Document for Rockchip Soc RK3288 LVDS, > > This based on the patches from Mark yao and Heiko Stuebner. > > > > Signed-off-by: Sandy Huang

Re: [PATCH v8 3/3] drm/rockchip: Add support for Rockchip Soc LVDS

2017-09-07 Thread Heiko Stuebner
Am Freitag, 8. September 2017, 09:23:09 CEST schrieb Mark yao: > On 2017年09月07日 20:09, Heiko Stübner wrote: > > Hi Mark, > > > > Am Donnerstag, 7. September 2017, 18:16:29 CEST schrieb Mark yao: > >> Looks good for me, so: > >> Reviewed-by: Mark Yao > >> > >> I'd like to apply these lvds patches t

Re: [PATCH v2 6/8] arm64: dts: rockchip: rk3399: Correct MIPI DPHY PLL clock

2017-09-26 Thread Heiko Stuebner
Am Dienstag, 26. September 2017, 15:55:21 CEST schrieb Nickey Yang: > Mipi-dphy's ref_clk connect to clk_dphy_pll inside rk3399. > clk_24m -> Gate11[14] -> clk_mipidphy_ref -> Gate21[0] -> clk_dphy_pll > So correct it. > > Signed-off-by: Nickey Yang I've already applied this patch from the previ

Re: [PATCH v2 7/8] arm64: dts: rockchip: add a grf clk for dw-mipi-dsi

2017-09-26 Thread Heiko Stuebner
Am Dienstag, 26. September 2017, 15:55:22 CEST schrieb Nickey Yang: > The clk of grf must be enabled before writing grf > register for rk3399. > > Signed-off-by: Nickey Yang applied as fix for 4.14 Thanks Heiko ___ dri-devel mailing list dri-devel@li

Re: [PATCH v5 05/12] drm/bridge/synopsys: dw-hdmi: don't clobber drvdata

2018-02-15 Thread Heiko Stuebner
..@rock-chips.com > Cc: he...@sntech.de > Acked-by: Neil Armstrong > Signed-off-by: Jernej Skrabec For the Rockchip-part Tested-by: Heiko Stuebner Acked-by: Heiko Stuebner ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v2 3/8] drm/bridge: dw-hdmi: allow overriding of phy-type reading

2018-02-16 Thread Heiko Stuebner
-off-by: Heiko Stuebner --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 +++- include/drm/bridge/dw_hdmi.h | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index f9802399cc0d

[PATCH v2 0/8] drm/rockchip: hdmi support for rk3328

2018-02-16 Thread Heiko Stuebner
opped patch exporting some dw-hdmi phy functions as a similar patch entered drm-misc already Heiko Stuebner (6): drm/bridge: dw-hdmi: allow overriding of phy-type reading drm/rockchip: dw_hdmi: Allow outputs that don't need output switching dt-bindings: allow optional phys in Rockchip dw_hd

[PATCH v2 8/8] drm/rockchip: dw_hdmi: add dw-hdmi support for the rk3328

2018-02-16 Thread Heiko Stuebner
The rk3328 uses an external hdmi phy from Innosilicon which uses the generic phy framework for access. Add the necessary data and the compatible for it. Signed-off-by: Heiko Stuebner --- .../bindings/display/rockchip/dw_hdmi-rockchip.txt | 1 + drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c

[PATCH v2 1/8] dt-bindings: add binding for Rockchip hdmi phy using an Innosilicon IP

2018-02-16 Thread Heiko Stuebner
From: Zheng Yang The phy is used so far in two Rockchip socs the rk3228 and the rk3328. Signed-off-by: Zheng Yang Signed-off-by: Heiko Stuebner --- .../bindings/phy/phy-rockchip-inno-hdmi.txt| 42 ++ 1 file changed, 42 insertions(+) create mode 100644

[PATCH v2 7/8] drm/rockchip: dw_hdmi: store rockchip_hdmi reference in phy_data object

2018-02-16 Thread Heiko Stuebner
milar to how meson-hdmi does it for example. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c

[PATCH v2 4/8] drm/rockchip: dw_hdmi: Allow outputs that don't need output switching

2018-02-16 Thread Heiko Stuebner
-switching is necessary. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c index 3574b0ae2ad1..6dc03f1a5709

[PATCH v2 6/8] drm/rockchip: dw_hdmi: allow including external phys

2018-02-16 Thread Heiko Stuebner
Some variants of the dw-hdmi on Rockchip socs use a separate phy block accessed via the generic phy framework, so allow them to be included if such a phy reference is found. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 10 ++ 1 file changed, 10

[PATCH v2 2/8] phy: add Rockchip Innosilicon hdmi phy

2018-02-16 Thread Heiko Stuebner
From: Zheng Yang Add a driver for the Innosilicon hdmi phy used on rk3228/rk3229 and rk3328 socs from Rockchip. Signed-off-by: Zheng Yang Signed-off-by: Heiko Stuebner --- Patches 1+2 expected to go through the phy-tree drivers/phy/rockchip/Kconfig |7 + drivers/phy

[PATCH v2 5/8] dt-bindings: allow optional phys in Rockchip dw_hdmi binding

2018-02-16 Thread Heiko Stuebner
Some newer Rockchip SoCs use an Innosilicon hdmiphy accessed via general mmio, so allow these to be referenced via the regular phy interfaces and therefore add optional phy-related properties to the binding. Signed-off-by: Heiko Stuebner --- Documentation/devicetree/bindings/display/rockchip

Re: [PATCH v2 1/8] dt-bindings: add binding for Rockchip hdmi phy using an Innosilicon IP

2018-02-16 Thread Heiko Stuebner
Am Freitag, 16. Februar 2018, 21:41:51 CET schrieb Heiko Stuebner: > From: Zheng Yang > > The phy is used so far in two Rockchip socs the rk3228 and the rk3328. > > Signed-off-by: Zheng Yang > Signed-off-by: Heiko Stuebner Forgot to add that the v1 binding already got a r

Re: [PATCH v5] drm/rockchip: Add device links for master and components

2018-02-18 Thread Heiko Stuebner
ume and shutdown ordering. > > Signed-off-by: Jeffy Chen > Signed-off-by: Enric Balletbo i Serra looks good to me right now. So if anybody else wants to apply it, Reviewed-by: Heiko Stuebner @Sean: does this address the issue you saw with the previous version? It looks like it, but I'd lik

Re: [PATCH 4/7] drm/rockchip: inno_hdmi: Remove unnecessary platform_get_resource() error check

2018-02-18 Thread Heiko Stuebner
Am Montag, 18. Dezember 2017, 14:02:27 CET schrieb Fabio Estevam: > From: Fabio Estevam > > devm_ioremap_resource() already checks if the resource is NULL, so > remove the unnecessary platform_get_resource() error check. > > Cc: Heiko Stübner > Signed-off-by: Fabio Estevam applied to drm-misc

Re: [PATCH 3/7] drm/rockchip: dsi: Remove unnecessary platform_get_resource() error check

2018-02-18 Thread Heiko Stuebner
Am Montag, 18. Dezember 2017, 14:02:26 CET schrieb Fabio Estevam: > From: Fabio Estevam > > devm_ioremap_resource() already checks if the resource is NULL, so > remove the unnecessary platform_get_resource() error check. > > Cc: Heiko Stübner > Signed-off-by: Fabio Estevam applied to drm-misc

Re: [PATCH v3 01/43] drm/rockchip: Get rid of unnecessary struct fields

2018-02-18 Thread Heiko Stuebner
Am Dienstag, 30. Januar 2018, 21:28:31 CET schrieb Thierry Escande: > From: Tomasz Figa > > This patch removes unused fields from vop structure. > > Signed-off-by: Tomasz Figa > Signed-off-by: Sean Paul > Signed-off-by: Thierry Escande applied to drm-misc Thanks Heiko _

Re: [PATCH v3 02/43] drm/rockchip: support prime import sg table

2018-02-18 Thread Heiko Stuebner
decode, camera). > > Signed-off-by: Haixia Shi > Signed-off-by: Sean Paul > Signed-off-by: Thierry Escande > Tested-by: Heiko Stuebner applied to drm-misc Thanks Heiko ___ dri-devel mailing list dri-devel@lists.freedesktop.org https:/

Re: [PATCH v3 03/43] drm/rockchip: Respect page offset for PRIME mmap calls

2018-02-18 Thread Heiko Stuebner
retains the original offset. > > Cc: Daniel Kurtz > Signed-off-by: Ørjan Eide > Signed-off-by: Tomasz Figa > Signed-off-by: Sean Paul > Signed-off-by: Thierry Escande > Tested-by: Heiko Stuebner applied to drm-misc. So I've picked up the "easy" patches that I

Re: [PATCH v2 4/8] drm/rockchip: dw_hdmi: Allow outputs that don't need output switching

2018-02-19 Thread Heiko Stuebner
Hi Robin, Am Montag, 19. Februar 2018, 12:43:11 CET schrieb Robin Murphy: > Hi Heiko, > > On 16/02/18 20:41, Heiko Stuebner wrote: > > So far we always encountered socs with 2 output crtcs needing the driver > > to tell the hdmi block which output to connect to. But ther

Re: [PATCH v2 3/8] drm/bridge: dw-hdmi: allow overriding of phy-type reading

2018-02-19 Thread Heiko Stuebner
Hi Laurent, Am Montag, 19. Februar 2018, 17:59:02 CET schrieb Laurent Pinchart: > On Friday, 16 February 2018 22:41:53 EET Heiko Stuebner wrote: > > In some IP implementations the reading of the phy-type may be broken. > > One example are the Rockchip rk3228 and rk3328 socs that

Re: [PATCH v2 8/8] drm/rockchip: dw_hdmi: add dw-hdmi support for the rk3328

2018-02-19 Thread Heiko Stuebner
Hi Rob, Am Montag, 19. Februar 2018, 21:28:53 CET schrieb Rob Herring: > On Fri, Feb 16, 2018 at 09:41:58PM +0100, Heiko Stuebner wrote: > > The rk3328 uses an external hdmi phy from Innosilicon which uses > > the generic phy framework for access. Add the necessary data > > a

Re: [PATCH v2 3/8] drm/bridge: dw-hdmi: allow overriding of phy-type reading

2018-02-21 Thread Heiko Stuebner
Hi Laurent, Am Montag, 19. Februar 2018, 20:06:40 CET schrieb Laurent Pinchart: > On Monday, 19 February 2018 20:46:46 EET Heiko Stuebner wrote: > > Am Montag, 19. Februar 2018, 17:59:02 CET schrieb Laurent Pinchart: > > > On Friday, 16 February 2018 22:41:53 EET Heiko Stuebne

[PATCH] drm/rockchip: analogix_dp: reorder psr_unregister call in unbind

2018-03-01 Thread Heiko Stuebner
In bind the psr handler gets registered first before the core analogix_dp_bind() gets called. So it should be the other way around in unbind, first unbind the analogix_dp and then unregister the psr. Signed-off-by: Jeffy Chen Signed-off-by: Thierry Escande Signed-off-by: Heiko Stuebner

Re: [PATCH v8 4/8] drm/rockchip: dw-mipi-dsi: Fix error handling path

2018-03-02 Thread Heiko Stuebner
Hi Enric, Am Freitag, 2. März 2018, 13:09:02 CET schrieb Enric Balletbo i Serra: > Hi Heiko, > > On 01/03/18 16:50, Heiko Stübner wrote: > > Hi Jeffy, Thierry, Enric, > > > > Am Mittwoch, 10. Januar 2018, 17:23:44 CET schrieb Thierry Escande: > >> From: Jeffy Chen > >> > >> Add missing pm_runti

Re: [PATCH 02/40] drm/rockchip: support prime import sg table

2018-01-22 Thread Heiko Stuebner
decode, camera). > > Signed-off-by: Haixia Shi > Signed-off-by: Sean Paul > Signed-off-by: Thierry Escande On rk3036 + lima and rk3328 + lima Tested-by: Heiko Stuebner ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://li

Re: [PATCH 03/40] drm/rockchip: Respect page offset for PRIME mmap calls

2018-01-22 Thread Heiko Stuebner
the original offset. > > Cc: Daniel Kurtz > Signed-off-by: Ørjan Eide > Signed-off-by: Tomasz Figa > Signed-off-by: Sean Paul > Signed-off-by: Thierry Escande On rk3036 + lima and rk3328 + lima Tested-by: Heiko Stuebner ___ dri-de

[PATCH 4/9] drm/bridge: dw-hdmi: export hotplug functions

2018-02-05 Thread Heiko Stuebner
From: Algea Cao External phys may not provide their own hotplug-related routines but instead rely on the dw-hdmi ones. Export these functions so that external hdmi-phys can use them if necessary. Signed-off-by: Algea Cao [export all 3 hotplug-related functions] Signed-off-by: Heiko Stuebner

[PATCH 6/9] dt-bindings: allow optional phys in Rockchip dw_hdmi binding

2018-02-05 Thread Heiko Stuebner
Some newer Rockchip SoCs use an Innosilicon hdmiphy accessed via general mmio, so allow these to be referenced via the regular phy interfaces and therefore add optional phy-related properties to the binding. Signed-off-by: Heiko Stuebner --- Documentation/devicetree/bindings/display/rockchip

[PATCH 5/9] drm/rockchip: dw_hdmi: Allow outputs that don't need output switching

2018-02-05 Thread Heiko Stuebner
-switching is necessary. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c index 1eb02a82fd91..304f61bd2eec

[PATCH 2/9] phy: add Rockchip Innosilicon hdmi phy

2018-02-05 Thread Heiko Stuebner
From: Zheng Yang Add a driver for the Innosilicon hdmi phy used on rk3228/rk3229 and rk3328 socs from Rockchip. Signed-off-by: Zheng Yang Signed-off-by: Heiko Stuebner --- drivers/phy/rockchip/Kconfig |7 + drivers/phy/rockchip/Makefile |1 + drivers

[PATCH 3/9] drm/bridge: dw-hdmi: allow overriding of phy-type reading

2018-02-05 Thread Heiko Stuebner
-off-by: Heiko Stuebner --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 +++- include/drm/bridge/dw_hdmi.h | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index a38db40ce990

[PATCH 0/9] drm/rockchip: hdmi support for rk3328

2018-02-05 Thread Heiko Stuebner
ready. Algea Cao (1): drm/bridge: dw-hdmi: export hotplug functions Heiko Stuebner (6): drm/bridge: dw-hdmi: allow overriding of phy-type reading drm/rockchip: dw_hdmi: Allow outputs that don't need output switching dt-bindings: allow optional phys in Rockchip dw_hdmi binding dr

[PATCH 7/9] drm/rockchip: dw_hdmi: allow including external phys

2018-02-05 Thread Heiko Stuebner
Some variants of the dw-hdmi on Rockchip socs use a separate phy block accessed via the generic phy framework, so allow them to be included if such a phy reference is found. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 10 ++ 1 file changed, 10

[PATCH 9/9] drm/rockchip: dw_hdmi: add dw-hdmi support for the rk3328

2018-02-05 Thread Heiko Stuebner
The rk3328 uses an external hdmi phy from Innosilicon which uses the generic phy framework for access. Add the necessary data and the compatible for it. Signed-off-by: Heiko Stuebner --- .../bindings/display/rockchip/dw_hdmi-rockchip.txt | 1 + drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c

[PATCH 8/9] drm/rockchip: dw_hdmi: store rockchip_hdmi reference in phy_data object

2018-02-05 Thread Heiko Stuebner
milar to how meson-hdmi does it for example. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c

[PATCH 1/9] dt-bindings: add binding for Rockchip hdmi phy using an Innosilicon IP

2018-02-05 Thread Heiko Stuebner
From: Zheng Yang The phy is used so far in two Rockchip socs the rk3228 and the rk3328. Signed-off-by: Zheng Yang Signed-off-by: Heiko Stuebner --- .../bindings/phy/phy-rockchip-inno-hdmi.txt| 42 ++ 1 file changed, 42 insertions(+) create mode 100644

Re: [2/9] phy: add Rockchip Innosilicon hdmi phy

2018-02-09 Thread Heiko Stuebner
Hi Martin, Am Montag, 5. Februar 2018, 22:32:08 CET schrieb Martin Cerveny: > On Mon, 5 Feb 2018, Heiko Stuebner wrote: > > From: Zheng Yang > > > > Add a driver for the Innosilicon hdmi phy used on rk3228/rk3229 > > and rk3328 socs from Rockchip. > > > >

Re: [2/9] phy: add Rockchip Innosilicon hdmi phy

2018-02-09 Thread Heiko Stuebner
Am Freitag, 9. Februar 2018, 11:06:49 CET schrieb Andrzej Hajda: > On 09.02.2018 10:24, Heiko Stuebner wrote: > > Hi Martin, > > > > Am Montag, 5. Februar 2018, 22:32:08 CET schrieb Martin Cerveny: > >> On Mon, 5 Feb 2018, Heiko Stuebner wrote: > >>> From

Re: [PATCH] drm/rockchip: Don't use spin_lock_irqsave in interrupt context

2018-02-10 Thread Heiko Stuebner
Hi Marc, Am Samstag, 10. Februar 2018, 15:35:01 CET schrieb Marc Zyngier: > The rockchip DRM driver is quite careful to disable interrupts > when taking a lock that is also taken in interrupt context, > which is a good thing. > > What is a bit over the top is to use spin_lock_irqsave when > alrea

Re: [PATCH v2 0/5] arm64: dts: rockchip: support mail and IPA thermal for rk3399

2017-07-19 Thread Heiko Stuebner
Am Mittwoch, 19. Juli 2017, 17:06:59 CEST schrieb Caesar Wang: > Hi Rob & Heiko, > > Do we have the chance to merge these patches? From the mali-thermal thingy, it doesn't look like Rob likes that IPA stuff. So I'll most likely pick the other patches that rely on approved bindings after I return

Re: [PATCH v2 1/5] dt-bindings: gpu: add the RK3399 mali for rockchip specifics

2017-07-22 Thread Heiko Stuebner
Am Montag, 17. Juli 2017, 16:14:27 CEST schrieb Caesar Wang: > RK3399's GPU uses the quad-core Mali-T860, which is the new generation of > high-end graphics processors from ARM. > > This patch added "rockchip,rk3399-mali" for dt-bindings, in order to > support IPA of gpu thermal in later. > > Sig

Re: [PATCH v5 2/7] drm/rockchip: vop: move write_relaxed flags to vop register

2017-07-25 Thread Heiko Stuebner
Hi Mark, Am Donnerstag, 20. Juli 2017, 10:43:27 CEST schrieb Mark Yao: > Since the drm atomic framework, only a small part of the vop > register needs sync write, Currently seems only following registers > need sync write: >cfg_done, standby and interrupt related register. > > All ctrl regist

Re: [PATCH v5 3/7] drm/rockchip: vop: move line_flag_num to interrupt registers

2017-07-25 Thread Heiko Stuebner
Hi Mark, Am Donnerstag, 20. Juli 2017, 10:43:32 CEST schrieb Mark Yao: > In the hardware design process, the design of line flags > register is associated with the interrupt register, > placing the line flags in the interrupt definition is > more reasonable, and it would make multi-vop define easi

Re: [PATCH v5 1/7] drm/rockchip: vop: initialize registers directly

2017-07-25 Thread Heiko Stuebner
Hi Mark, Am Donnerstag, 20. Juli 2017, 10:43:22 CEST schrieb Mark Yao: > At present we are using init_table to initialize some > registers, but the Register init table use un-document define, > it is unreadable, and sometimes we only want to update tiny > bits, init table method is not friendly, i

Re: [PATCH v6 1/7] drm/rockchip: vop: initialize registers directly

2017-07-26 Thread Heiko Stuebner
iendly, it's diffcult to > reuse for difference chips. > > To make it clean, initialize registers directly, and drops > init_table mechanism out. > > Signed-off-by: Mark Yao on rk3036 and rk3288 Tested-by: Heiko Stuebner Heiko _

Re: [PATCH v6 2/7] drm/rockchip: vop: move write_relaxed flags to vop register

2017-07-26 Thread Heiko Stuebner
ctrl registers are using the sync write method that is > inefficient, hardcode the write_relaxed flags to vop registers, > then can only do synchronize write for those actual needed register. > > Signed-off-by: Mark Yao on rk3036 and rk3288 Test

Re: [PATCH v6 3/7] drm/rockchip: vop: move line_flag_num to interrupt registers

2017-07-26 Thread Heiko Stuebner
ine easilier. > > Signed-off-by: Mark Yao > Reviewed-by: Sean Paul on rk3036 and rk3288 Tested-by: Heiko Stuebner Heiko ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v6.1 4/7] drm/rockchip: vop: group vop registers

2017-07-28 Thread Heiko Stuebner
d rk3288 Tested-by: Heiko Stuebner ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v6 6/7] dt-bindings: display: rockchip: fill Documents for vop series

2017-07-28 Thread Heiko Stuebner
Hi Mark, Am Mittwoch, 26. Juli 2017, 14:19:35 CEST schrieb Mark Yao: > Signed-off-by: Mark Yao > Acked-by: Rob Herring > --- > Changes in v5: > - clean document commit title > - move changes description out of docummit commit msg > > Changes in v2: > - rename rk322x to rk3228 > - correct some v

Re: [PATCH v6 5/7] drm/rockchip: vop: add a series of vop support

2017-07-28 Thread Heiko Stuebner
l framework is 3, >vop little framework is 2. > minor version: on same structure, newer design vop will bigger >then old one. > > Signed-off-by: Mark Yao on rk3036 and rk3288 Tested-by: Heiko Stuebner Heiko __

Re: [PATCH v6 7/7] drm/rockchip: vop: rk3328: fix overlay abnormal

2017-07-28 Thread Heiko Stuebner
nd rk3288 are not negatively affected by this, so on rk3036 and rk3288 Tested-by: Heiko Stuebner ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] MAINTAINERS: change maintainer for Rockchip drm drivers

2017-11-24 Thread Heiko Stuebner
> > For personal reasons, Mark Yao will leave rockchip, > > can not continue maintain drm/rockchip, Sandy Huang > > will take over the drm/rockchip. > > > > Cc: Sandy Huang > > Cc: Heiko Stuebner > > > > Signed-off-by: Mark Yao > > Since r

Re: [PATCH 0/4] Move DP phy switch to PHY driver

2017-12-01 Thread Heiko Stuebner
Am Freitag, 1. Dezember 2017, 13:42:46 CET schrieb Doug Anderson: > Hi, > > On Wed, Nov 29, 2017 at 6:27 PM, Chris Zhong wrote: > > Hi Doug > > > > Thank you for mentioning this patch. > > > > I think the focus of the discussion is: can we put the grf control bit to > > dts. > > > > The RK3399 ha

Re: [PATCH v4] arm64: dts: rockchip: update mipi cells for RK3399

2017-12-04 Thread Heiko Stuebner
Am Mittwoch, 29. November 2017, 10:47:55 CET schrieb Brian Norris: > From: Nickey Yang > > We might include additional ports in derivative device trees, so the > 'port' node should have an address, and the parent 'ports' node needs > /#{addres,size}-cells. > > v4: > * keep #{address,size}-cells

Re: [PATCH v4] arm64: dts: rockchip: update mipi cells for RK3399

2017-12-04 Thread Heiko Stuebner
Hi Laurent, Am Montag, 4. Dezember 2017, 15:22:07 CET schrieb Laurent Pinchart: > On Wednesday, 29 November 2017 20:47:55 EET Brian Norris wrote: > > From: Nickey Yang > > > > We might include additional ports in derivative device trees, so the > > 'port' node should have an address, and the par

Re: [PATCH 8/8] phy: rockchip: add inno hdmi phy to makefile

2017-12-09 Thread Heiko Stuebner
Hi Algea, Am Montag, 25. September 2017, 19:43:56 CET schrieb Algea Cao: > Support some SOCs,such as RK3328. > > Signed-off-by: Algea Cao I've tried tracking down the 8 patches of this series, but the only one I could find was this patch 8/8. Are you still working on this and could you resend

Re: [PATCH v2 4/7] drm/rockchip: dw_hdmi: add inno hdmi phy ops

2017-12-09 Thread Heiko Stuebner
Hi Algea, Am Samstag, 30. September 2017, 09:44:46 CET schrieb Algea Cao: > Because some RK chips use inno hdmi phy, such as RK3328, we add > inno hdmi phy ops. > > Signed-off-by: Algea Cao > --- > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 110 > +++- > 1 file chang

Re: [PATCH v2 5/7] drm/rockchip: dw_hdmi: add hclk_vio

2017-12-10 Thread Heiko Stuebner
Hi Algea, Am Samstag, 30. September 2017, 09:45:12 CET schrieb Algea Cao: > Add clk hclk_vio and enable it when hdmi bind. Could you explain what the hclk_vio reference is needed for please? Because from from what I tracked down in the TRM and code, this hclk_vio is defined wrong in the clock-dr

Re: [PATCH 02/41] drm/rockchip: Get rid of some unnecessary code

2017-12-12 Thread Heiko Stuebner
seemingly unsused mutex, which I guess falls under the "some unused fields" part. In any case, I didn't see any ill effects when testing this patch, so Tested-by: Heiko Stuebner > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 5 - > 1 file changed, 5

Re: [PATCH 03/41] drm/rockchip: support prime import sg table

2017-12-12 Thread Heiko Stuebner
decode, camera). > > Signed-off-by: Haixia Shi missing a further Signed-off from Sean Paul as the sender. I've tested this on the rk3328 together with the wip Lima driver and my wip Mesa Rockchip Pipe and the kmscube improved from a failure about importing the buffer to producing actual ou

Re: [PATCH 04/41] drm/rockchip: Respect page offset for PRIME mmap calls

2017-12-12 Thread Heiko Stuebner
the original offset. > > BUG=chrome-os-partner:56615 > TEST=graphics_GLBench Unneeded chromeos-cruft. > Cc: Daniel Kurtz > Signed-off-by: Ørjan Eide > Signed-off-by: Tomasz Figa > Signed-off-by: Sean Paul With the same

[RFC PATCH v1 0/4] Add Rockchip RGA support

2016-03-22 Thread Heiko Stuebner
Hi Yakir, Am Montag, 21. März 2016, 20:17:46 schrieb Yakir Yang: > On 03/21/2016 07:29 PM, Heiko Stübner wrote: > > Am Montag, 21. März 2016, 17:28:38 schrieb Yakir Yang: > >> This patch set would add the RGA direct rendering based 2d graphics > >> acceleration module. > > > > very cool to see

Re: [PATCH 0/2] drm/panel: ltk050h3146w: error-path debug message improvements

2024-01-04 Thread Heiko Stuebner
; > [...] Applied, thanks! [1/2] drm/panel: ltk050h3146w: only print message when GPIO getting is not EPROBE_DEFER commit: 65afd91e8d70e10c7f99126d61bf0045ef52d271 [2/2] drm/panel: ltk050h3146w: use dev_err_probe wherever possible commit: 056a9965e58e47928e8afd4dc017221f9221b3d3 Best regards, -- Heiko Stuebner

Re: [PATCH v2] drm/rockchip: vop2: Drop unused if_dclk_rate variable

2024-01-05 Thread Heiko Stuebner
905f7daab29c56974f1aba9a7a Best regards, -- Heiko Stuebner

Re: (subset) [PATCH v4 00/29] Add HDMI support for RK3128

2024-01-25 Thread Heiko Stuebner
tem for RK3128 commit: 695b9b57443d88a1c8e0567c88a79d1a4532c75e [28/29] ARM: dts: rockchip: Add HDMI node for RK3128 commit: 3fd6e33f8fde16869d4cd9cef71ca964b2b0789b [29/29] ARM: dts: rockchip: Enable HDMI output for XPI-3128 commit: 5aab66e319df2a6fc4ab06bcb4bd974c1ac4

Re: [PATCH 00/31] Fix and improve Rockchip RK3128 support

2023-12-12 Thread Heiko Stuebner
Hi Alex, Am Dienstag, 29. August 2023, 19:16:16 CET schrieb Alex Bee: > this series fixes some issues I found when testing my "new" RK3128 board > with the mainline kernel and adds some core functionality like SMP bringup, > usb and networking. before I discard this thread, is everything from her

Re: (subset) [PATCH v1 1/3] dt-bindings: drm: rockchip: convert inno_hdmi-rockchip.txt to yaml

2023-12-12 Thread Heiko Stuebner
ctor node commit: 569b26af7919c15a8ce231b4fae29cfbd811f144 And changed the connector-type to "a" :-) Best regards, -- Heiko Stuebner

Re: (subset) [PATCH v5 00/16] Add VOP2 support on rk3588

2023-12-13 Thread Heiko Stuebner
80 > > [...] Applied, thanks! [09/16] dt-bindings: soc: rockchip: add rk3588 vop/vo syscon commit: 1a648f8b7994dca4c323911607cf28d1eb44c198 Best regards, -- Heiko Stuebner

Re: (subset) [PATCH v5 00/16] Add VOP2 support on rk3588

2023-12-13 Thread Heiko Stuebner
prescan dly at vop2_post_config commit: 075a5b3969becb1ebc2f1d4fa1a1fe9163679273 [08/16] drm/rockchip: vop2: rename grf to sys_grf commit: c408af1afc4b74ea6df69e0313be97f1f83e981a Best regards, -- Heiko Stuebner

Re: (subset) [PATCH v5 00/16] Add VOP2 support on rk3588

2023-12-13 Thread Heiko Stuebner
ewer for rockchip drm commit: 6c3ab21f37a97a868193ccbeb8a492e51210ff31 I skipped the debugfs patch for now, as I need to look at that separately and of course the dts patch as that needs to wait for iommu maintainers to pick up the binding addition. Best regards, -- Heiko Stuebner

Re: [PATCH] drm/panel: ltk050h3146w: Set burst mode for ltk050h3148w

2023-12-13 Thread Heiko Stuebner
st mode can keep using the lane_mbps. So add > MIPI_DSI_MODE_VIDEO_BURST as part of the mode_flags for the dsi host. > > [...] Applied, thanks! [1/1] drm/panel: ltk050h3146w: Set burst mode for ltk050h3148w commit: 6c9dbee84cd005bed5f9d07b3a2797ae6414b435 Best regards, -- Heiko Stuebner

Re: (subset) [PATCH v5 00/16] Add VOP2 support on rk3588

2023-12-15 Thread Heiko Stuebner
80 > > [...] Applied, thanks! [15/16] arm64: dts: rockchip: Add vop on rk3588 commit: d895dbef3f3a31ab50491bb48552e798cf555987 Best regards, -- Heiko Stuebner

Re: [PATCH] drm/rockchip: vop2: clean up some inconsistent indenting

2023-12-24 Thread Heiko Stuebner
nsistent indenting commit: f40e61eb538d35661d6dda1de92867954d776c4a Best regards, -- Heiko Stuebner

Re: [PATCH] drm/rockchip: vop2: Avoid use regmap_reinit_cache at runtime

2023-12-24 Thread Heiko Stuebner
; > I can reproduce this warning with: > CONFIG_PROVE_LOCKING=y > CONFIG_DEBUG_LOCKDEP=y > > [...] Applied, thanks! [1/1] drm/rockchip: vop2: Avoid use regmap_reinit_cache at runtime commit: 3ee348eb36f14e9303a7e9757efb91b0bbf3f7a9 Best regards, -- Heiko Stuebner

Re: (subset) [PATCH v4 00/29] Add HDMI support for RK3128

2023-12-29 Thread Heiko Stuebner
from structure commit: 5f92474844a4fcb7997da20dd1de2031aed1d794 Best regards, -- Heiko Stuebner

Re: (subset) [PATCH v4 00/29] Add HDMI support for RK3128

2023-12-29 Thread Heiko Stuebner
fc80450a2d085acdc3da3e [21/29] drm/rockchip: inno_hdmi: Don't power up the phy after resetting commit: 71892cee6ceb3e1b88e0bb44b05c8397d8261a85 [22/29] drm/rockchip: inno_hdmi: Split power mode setting commit: f01e33cb586b5fd354cba73052f82c3b4246109d Best regards, -- Heiko Stuebner

Re: [PATCH] drm/rockchip: analogix_dp: get encoder port ID from DT

2024-01-04 Thread Heiko Stuebner
Best regards, -- Heiko Stuebner

Re: (subset) [PATCH v4 00/29] Add HDMI support for RK3128

2024-01-04 Thread Heiko Stuebner
drm/rockchip: inno_hdmi: Drop custom fill_modes hook commit: 50a3c772bd927dd409c484832ddd9f6bf00b7389 For reference, Rob has applied the rk3128 compatible in https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?id=21960bda59852ca961fcd27fba9f92750caccd06 Best regards, -- Heiko Stuebner

Re: [PATCH v2 0/2] drm/rockchip: lvds: improve erroring out when drm_of_find_panel_or_bridge fails

2024-01-04 Thread Heiko Stuebner
message when probing defer commit: 52d11c863ac92e36a0365249f7f6d27ac48c78bc Best regards, -- Heiko Stuebner

Re: [PATCH v6 3/3] drm/rockchip: Add basic RK3588 HDMI output support

2024-09-14 Thread Heiko Stuebner
Am Samstag, 14. September 2024, 20:28:59 CEST schrieb Cristian Ciocaltea: > On 9/10/24 10:08 PM, Heiko Stübner wrote: > > Am Freitag, 6. September 2024, 03:17:42 CEST schrieb Cristian Ciocaltea: > > That hdmi->ref_clk just accidentially falls out of that loop at the end > > looks somewhat strange,

Re: [PATCH 00/14] Add initial support for the Rockchip RK3588 HDMI TX Controller

2024-06-03 Thread Heiko Stuebner
Am Montag, 3. Juni 2024, 14:14:17 CEST schrieb Andy Yan: > Hi Neil: > > On 6/3/24 16:55, Neil Armstrong wrote: > > Hi Christian, > > > > On 01/06/2024 15:12, Cristian Ciocaltea wrote: > >> The RK3588 SoC family integrates a Quad-Pixel (QP) variant of the > >> Synopsys DesignWare HDMI TX controlle

Re: [PATCH v3 1/2] drm/rockchip: vop: clear DMA stop bit upon vblank on RK3066

2024-06-08 Thread Heiko Stuebner
Am Sonntag, 2. Juni 2024, 05:35:36 CEST schrieb Val Packett: > > On Mon, May 27 2024 at 20:11:49 -03:00:00, Val Packett > wrote: > > The RK3066 VOP sets a dma_stop bit when it's done scanning out a frame > > and needs the driver to acknowledge that by clearing the bit. > > > > So unless we clea

[PATCH 0/3] add power-supply support to dw_hdmi

2015-03-10 Thread Heiko Stuebner
iet in the deferring case and could go directly to the regulator tree, if ok. Patch3 is the addition of the supplies to the rk3288 boards and I would take it into my dts branch if patch2 gets deemed acceptable. Heiko Stuebner (3): regulator: don't emit errors in {devm_}regulator_bulk_get when

[PATCH 1/3] regulator: don't emit errors in {devm_}regulator_bulk_get when defering

2015-03-10 Thread Heiko Stuebner
When {devm_}regulator_get returns -EPROBE_DEFER the driver in question will try probing again at a later time. So don't spam the log with failure messages as this is an expected result of probe ordering. Signed-off-by: Heiko Stuebner --- drivers/regulator/core.c | 5 +++-- drivers/regu

[PATCH 2/3] drm/bridge: dw-hdmi: support optional supply regulators

2015-03-10 Thread Heiko Stuebner
At least the Rockchip variant of the dw_hdmi can have controllable power supplies providing 1.0 and 1.8V. Therefore add the possibility for the generic bridge driver to enable supplies provided by the hw-specific drivers. Signed-off-by: Heiko Stuebner --- .../devicetree/bindings/drm/bridge

[PATCH 3/3] ARM: dts: rockchip: add hdmi analog power supplies to rk3288 boards

2015-03-10 Thread Heiko Stuebner
Add the recently added hdmi power supplies to evb and firefly boards. Signed-off-by: Heiko Stuebner --- arch/arm/boot/dts/rk3288-evb.dtsi | 2 ++ arch/arm/boot/dts/rk3288-firefly.dtsi | 2 ++ 2 files changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi b/arch/arm/boot

[PATCH 2/3] drm/bridge: dw-hdmi: support optional supply regulators

2015-03-10 Thread Heiko Stuebner
Hi Philipp, Am Dienstag, 10. März 2015, 10:16:53 schrieb Philipp Zabel: [cut the obvious stuff I need to fix] > Am Dienstag, den 10.03.2015, 00:22 +0100 schrieb Heiko Stuebner: > > @@ -879,6 +883,12 @@ static int dw_hdmi_phy_init(struct dw_hdmi *hdmi) > > > > int

[PATCH 1/3] regulator: don't emit errors in {devm_}regulator_bulk_get when defering

2015-03-10 Thread Heiko Stuebner
Am Dienstag, 10. März 2015, 12:07:50 schrieb Mark Brown: > On Tue, Mar 10, 2015 at 12:22:06AM +0100, Heiko Stuebner wrote: > > When {devm_}regulator_get returns -EPROBE_DEFER the driver in question > > will > > try probing again at a later time. So don't spam the log wi

[PATCH v2 1/2] drm/bridge: dw-hdmi: support optional supply regulators

2015-03-10 Thread Heiko Stuebner
At least the Rockchip variant of the dw_hdmi can have controllable power supplies providing 1.0 and 1.8V. Therefore add the possibility for the generic bridge driver to enable supplies provided by the hw-specific drivers. Signed-off-by: Heiko Stuebner --- changes since v1: - follow suggestion

[PATCH v2 2/2] ARM: dts: rockchip: add hdmi analog power supplies to rk3288 boards

2015-03-10 Thread Heiko Stuebner
Add the recently added hdmi power supplies to evb and firefly boards. Signed-off-by: Heiko Stuebner --- arch/arm/boot/dts/rk3288-evb.dtsi | 2 ++ arch/arm/boot/dts/rk3288-firefly.dtsi | 2 ++ 2 files changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi b/arch/arm/boot

[PATCH v2 1/2] drm/bridge: dw-hdmi: support optional supply regulators

2015-03-11 Thread Heiko Stuebner
Hi Philipp, Am Mittwoch, 11. März 2015, 10:28:29 schrieb Philipp Zabel: > Am Dienstag, den 10.03.2015, 22:45 +0100 schrieb Heiko Stuebner: > > At least the Rockchip variant of the dw_hdmi can have controllable power > > supplies providing 1.0 and 1.8V. Therefore add the poss

[PATCH 2/2] drm/bridge: Add IT6151 bridge driver

2015-03-12 Thread Heiko Stuebner
Am Donnerstag, 12. März 2015, 10:00:47 schrieb Paul Bolle: > > --- /dev/null > > +++ b/drivers/gpu/drm/bridge/it6151.c > > > > +#include > > This file can only be built-in. So I couldn't help but notice this > include. And if I remove it > make drivers/gpu/drm/bridge/it6151.o > > still run

<    2   3   4   5   6   7   8   9   >