[RFC PATCH v3 1/4] drm: Introduce generic probe function for component based masters.

2015-11-09 Thread Heiko Stuebner
Hi Liviu, Am Montag, 9. November 2015, 12:07:20 schrieb Liviu Dudau: > On Mon, Nov 09, 2015 at 12:03:35PM +, Russell King - ARM Linux wrote: > > On Mon, Nov 09, 2015 at 11:57:27AM +, Liviu Dudau wrote: > > > Meanwhile, what is your suggestion regarding the patchset. I've seen > > > David

[PATCH 1/2] drm/rockchip: create the fake mmap offset during gem creation

2015-11-09 Thread Heiko Stuebner
ion of the gem to only create that offset once. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_g

[PATCH 2/2] drm/rockchip: unset pgoff when mmap'ing gems

2015-11-09 Thread Heiko Stuebner
way to go for rockchip as well. Fixes: 371f0f085f629 ("ARM: 8426/1: dma-mapping: add missing range check in dma_mmap()") Signed-off-by: Heiko Stuebner --- This patch is definitly necessary to keep the rockchip-drm working with kernel 4.4. drivers/gpu/drm/rockchip/rockchip_drm_gem.c |

[PATCH 1/2] drm/rockchip: create the fake mmap offset during gem creation

2015-11-10 Thread Heiko Stuebner
nd these two to Dave as fixes for 4.4? Thanks Heiko > > > On 2015年11月10日 03:50, Heiko Stuebner wrote: > > Similarly to the equivalent exynos-fix in commit 48cf53f4343a > > ("drm/exynos: create a fake mmap offset with gem creation") the rockchip &g

[PATCH 1/2] drm/rockchip: create the fake mmap offset during gem creation

2015-11-10 Thread Heiko Stuebner
Am Dienstag, 10. November 2015, 17:26:10 schrieb Mark yao: > On 2015年11月10日 14:46, Heiko Stuebner wrote: > > Hi Mark, > > > > Am Dienstag, 10. November 2015, 14:17:43 schrieb Mark yao: > >> Hi Heiko > >>I don't think this patch is needed fo

[PATCH] drm/rockchip: vop: fix window origin calculation

2015-11-10 Thread Heiko Stuebner
hat shift, but now that you mention it, I see it too on my Chromebook and the patch fixes this. I've also looked up the matching data in the TRM, so Reviewed-by: Heiko Stuebner Tested-by: Heiko Stuebner Heiko

[PATCH] drm/rockchip: vop: fix window origin calculation

2015-11-10 Thread Heiko Stuebner
Am Dienstag, 10. November 2015, 17:59:10 schrieb Mark Yao: > From: Dominik Behr > > VOP_WINx_DSP_ST does not require subtracting 1 from the values written to > it. It actually causes the screen to be shifted by one pixel. > > Signed-off-by: Mark Yao One thing I noticed, the original patch [0]

[PATCH v8 10/17] phy: Add driver for rockchip Display Port PHY

2015-11-12 Thread Heiko Stuebner
Hi Yakir, Am Mittwoch, 28. Oktober 2015, 16:30:33 schrieb Yakir Yang: > Add phy driver for the Rockchip DisplayPort PHY module. This > is required to get DisplayPort working in Rockchip SoCs. > > Reviewed-by: Heiko Stuebner > Signed-off-by: Yakir Yang a general thing I have bee

[PATCH v3 02/10] drm/rockchip: analogix_dp: split the lcdc select setting into device data

2016-06-23 Thread Heiko Stuebner
Am Donnerstag, 23. Juni 2016, 10:32:53 schrieb Sean Paul: > On Tue, Jun 14, 2016 at 7:46 AM, Yakir Yang wrote: > > eDP controller need to declare which vop provide the video source, > > and it's defined in GRF registers. > > > > But different chips have different GRF register address, so we need

[patch] drm: rockchip: signedness bug in dw_mipi_dsi_get_lane_bps()

2016-01-21 Thread Heiko Stuebner
Hi Dan, Am Mittwoch, 20. Januar 2016, 12:53:52 schrieb Dan Carpenter: > "bpp" needs to be signed for the error handling to work. > > Fixes: 84e05408fcfe ('drm: rockchip: Support Synopsys DW MIPI DSI') > Signed-off-by: Dan Carpenter There's also "drm/rockchip/dsi: fix handling mipi_dsi_pixel_for

[PATCH v12.1 07/17] drm: rockchip: dp: add rockchip platform dp driver

2016-01-21 Thread Heiko Stuebner
Hi Yakir, Am Dienstag, 19. Januar 2016, 18:04:53 schrieb Yakir Yang: > Rockchip have three clocks for dp controller, we leave pclk_edp > to analogix_dp driver control, and keep the sclk_edp_24m and > sclk_edp in platform driver. > > Signed-off-by: Yakir Yang > Tested-by: Javier Martinez Canillas

[PATCH v4 0/3] drm_of_encoder_active_endpoint helpers

2016-01-30 Thread Heiko Stuebner
Hi Philipp, Am Freitag, 29. Januar 2016, 10:58:57 schrieb Philipp Zabel: > I'm just looking for feedback whether > I should include the rockchip patch in the next imx-drm pull request. I'm hoping that we'd get the analogix dp driver sorted for 4.6 as well, which having that change in the imx-tre

[PATCH v1 3/5] ARM: dts: rockchip: add eDP/panel display device nodes for rk3288-evb

2016-07-08 Thread Heiko Stuebner
Am Dienstag, 28. Juni 2016, 12:51:18 schrieb Yakir Yang: > The default eDP panel on RK3288 EVB board is LG LP079QX1-SP0V TFT LCD, > we haven't declared the panel regulator in the 'panel-simple' device > node here, so the specific board like ACT8846 / RK8080 need to support > the panel power supply.

[PATCH v1 4/5] ARM: dts: rockchip: add the panel power supply for rk3288-evb board with act8846 pmu

2016-07-08 Thread Heiko Stuebner
Am Dienstag, 28. Juni 2016, 12:51:21 schrieb Yakir Yang: > Panel regulator is controller by a normal GPIO, so we need to > write a regulator-fixed node for it. > > Signed-off-by: Yakir Yang applied, thanks. Heiko

[PATCH v1 5/5] ARM: dts: rockchip: add the panel power supply for rk3288-evb board with rk808 pmu

2016-07-08 Thread Heiko Stuebner
Am Dienstag, 28. Juni 2016, 12:51:24 schrieb Yakir Yang: > Panel regulator is controller by a normal GPIO, so we need to > write a regulator-fixed node for it. > > Signed-off-by: Yakir Yang applied after rewording the commit message a bit. On the rk808-evb vcc_lcd comes from the rk808 directly a

[PATCH v3 3/3] drm/rockchip: remove rockchip_drm_encoder_get_mux_id

2015-08-27 Thread Heiko Stuebner
mi currently is probably Yakir Yang (included now). But even to me with my general Rockchip work area outside the drm this looks good, as there isn't any functional change present in the moved function, so Reviewed-by: Heiko Stuebner Heiko > --- > drivers/gpu/drm/rockchip/dw_hdmi-roc

[PATCH v3 06/14] Documentation: drm/bridge: add document for analogix_dp

2015-08-24 Thread Heiko Stuebner
Hi Yakir, Am Montag, 24. August 2015, 20:48:01 schrieb Yakir Yang: > 在 08/24/2015 12:20 PM, Krzysztof Kozlowski 写道: > > On 24.08.2015 11:42, Yakir Yang wrote: > >> Hi Krzysztof, > >> > >> 在 08/23/2015 07:43 PM, Krzysztof Kozlowski 写道: > >>> 2015-08-24 8:23 GMT+09:00 Rob Herring : > >>

[PATCH v3 06/14] Documentation: drm/bridge: add document for analogix_dp

2015-08-24 Thread Heiko Stuebner
Am Montag, 24. August 2015, 09:48:27 schrieb Rob Herring: > On Mon, Aug 24, 2015 at 7:57 AM, Russell King - ARM Linux > > When we adopted the graph bindings for iMX DRM, I thought exactly at that > > time "it would be nice if this could become the standard for binding DRM > > components together" b

[PATCH v7 0/5] Add mipi dsi support for rk3288

2016-02-08 Thread Heiko Stuebner
Hi Archit, Am Montag, 8. Februar 2016, 15:42:04 schrieb Archit Taneja: > On 01/06/2016 09:33 AM, Chris Zhong wrote: > > The rk3288 MIPI DSI is a Synopsys DesignWare MIPI DSI host controller > > IP. This series adds support for a Synopsys DesignWare MIPI DSI host > > controller DRM driver. > > > >

[PATCH v8 0/2] Add Rockchip Inno-HDMI driver

2016-02-16 Thread Heiko Stuebner
Hi Mark, Am Dienstag, 16. Februar 2016, 08:44:41 schrieb Mark yao: > Ping, it seems inno hdmi driver is ready, So I'd like to merge it into > drm/rockchip if there is no doubt these days. I think you can just go ahead with picking them up, I think they have ripened enough :-) Heiko

[PATCH RFC v2 06/12] dt-bindings: Add documentation for rockchip lvds

2015-04-01 Thread Heiko Stuebner
From: Mark Yao Add binding documentation for Rockchip SoC LVDS driver. Signed-off-by: Mark Yao Signed-off-by: Heiko Stuebner --- .../devicetree/bindings/video/rockchip-lvds.txt| 74 ++ 1 file changed, 74 insertions(+) create mode 100644 Documentation/devicetree

[PATCH RFC v2 04/12] drm/components: add generic vga encoder driver

2015-04-01 Thread Heiko Stuebner
converted to the component framework. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/components/Kconfig | 5 + drivers/gpu/drm/components/Makefile | 2 + drivers/gpu/drm/components/vga-encoder.c | 315 +++ 3 files changed, 322 insertions(+) create mode

[PATCH RFC v2 03/12] drm: add components subdirectory and infrastructure

2015-04-01 Thread Heiko Stuebner
components like the mentioned external encoders that can be used by component-based drm drivers. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/Kconfig | 2 ++ drivers/gpu/drm/Makefile| 1 + drivers/gpu/drm/components/Kconfig | 4 drivers/gpu/drm/components/Makefile | 1

[PATCH RFC v2 08/12] drm/rockchip: lvds: register a bridge when no panel is set

2015-04-01 Thread Heiko Stuebner
On socs using the lvds components it also controls the use of the general rgb outputs and must thus be configured for things like external encoders. Therefore register a drm_bridge in this case and try to find the encoder in the output port. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm

[PATCH RFC v2 07/12] drm/rockchip: Add support for Rockchip Soc LVDS

2015-04-01 Thread Heiko Stuebner
From: Mark Yao This adds support for Rockchip soc lvds found on rk3288 Signed-off-by: Mark Yao Signed-off-by: Heiko Stuebner --- This still needs to address Laurent's comment about trying to get the lvds settings from the panel/connected device instead of encoding them as separate prope

[PATCH RFC v2 01/12] drm/encoder: add functionality to register encoders to a global list

2015-04-01 Thread Heiko Stuebner
-off-by: Heiko Stuebner --- drivers/gpu/drm/drm_crtc.c | 41 + include/drm/drm_crtc.h | 8 2 files changed, 49 insertions(+) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index f6d04c7..b63e69d 100644 --- a/drivers/gpu

[PATCH RFC v2 05/12] drm/components: add generic vga connector driver

2015-04-01 Thread Heiko Stuebner
This adds a driver for generic vga connectors using a system i2c-bus for ddc. An exception is included for rcar-du which implements the vga-connector binding interally already and is not yet converted to the component framework. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/components

[PATCH RFC v2 00/12] drm/rockchip: add support for lvds controller and external encoders

2015-04-01 Thread Heiko Stuebner
oducing the new components element and of_graph structure. Tested on a firefly board using the vga connector. Thanks Heiko Heiko Stuebner (10): drm/encoder: add functionality to register encoders to a global list drm/connector: add functionality to register connectors to a global

[PATCH RFC v2 02/12] drm/connector: add functionality to register connectors to a global list

2015-04-01 Thread Heiko Stuebner
. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/drm_crtc.c | 41 + include/drm/drm_crtc.h | 7 +++ 2 files changed, 48 insertions(+) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index b63e69d..8b49ea7 100644 --- a/drivers/gpu

[PATCH RFC v2 09/12] drm/rockchip: enable rgb output of vops for all other connectors

2015-04-01 Thread Heiko Stuebner
The socs itself contains encoders for a lot of different outputs. But every unsupported connector will be routed through the lvds, as it controls the pins in question. Therefore enable the lvds output for all of those. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip

[PATCH RFC v2 11/12] ARM: dts: rockchip: add rk3288 lvds node

2015-04-01 Thread Heiko Stuebner
Add the basic node for the lvds controller of rk3288 and hook it into the display-subsystem hirarchy. Signed-off-by: Heiko Stuebner --- arch/arm/boot/dts/rk3288.dtsi | 42 ++ 1 file changed, 42 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi b

[PATCH RFC v2 10/12] ARM: dts: rockchip: add rk3288 lcdc0 pinmux settings

2015-04-01 Thread Heiko Stuebner
Add pinctrl settings for the configurable lcdc0 signals dclk, den, hsync and vsync. The lcdc0 data pin configuration is not software controlable. Signed-off-by: Heiko Stuebner --- arch/arm/boot/dts/rk3288.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/rk3288

[PATCH RFC v2 12/12] ARM: dts: rockchip: add vga encoder and enable lvds on rk3288-firefly

2015-04-01 Thread Heiko Stuebner
Add the sda7123 simple vga encoder, connect it to the vop outputs and enable the lvds controller with the correct settings. Signed-off-by: Heiko Stuebner --- arch/arm/boot/dts/rk3288-firefly.dtsi | 68 +++ 1 file changed, 68 insertions(+) diff --git a/arch/arm

Re: [PATCH] drm/rockchip: psr: do not dereference encoder before it is null checked.

2018-10-16 Thread Heiko Stuebner
Am Samstag, 13. Oktober 2018, 12:56:54 CEST schrieb Enric Balletbo i Serra: > 'encoder' is deferenced before it is null sanity checked, hence we > potentially have a null pointer dereference bug. Instead, initialise > drm_drv from encoder->dev->dev_private after we are sure 'encoder' is > not null.

[PATCH v4 RESEND] drm/panel: add Kingdisplay kd097d04 panel driver

2018-10-30 Thread Heiko Stuebner
. Matches how tegra and pending rockchip dual-dsi handle (dual-)dsi lanes - spdx header instead of license boilerplate Signed-off-by: Nickey Yang Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile|

Re: [PATCH] drm/rockchip: vop: fix irq disabled after vop driver probed

2018-05-25 Thread Heiko Stuebner
y > > also track its enabled state and ignore irqs in that case. > > > > So remove the enable/disable handling and add appropriate condition > > to the irq handler. > > > > Signed-off-by: Sandy Huang > > [added an actual commit message] > > Signed-off-by: Heik

[PATCH v2 0/2] drm/rockchip: try to fix vblank hang resulting from iommu irq change

2018-05-28 Thread Heiko Stuebner
t usage ourself, because of possible concurrency issues with vop enable/disable Heiko Stuebner (1): drm/rockchip: vop: split out core clock enablement into separate functions Sandy Huang (1): drm/rockchip: vop: fix irq disabled after vop driver probed drivers/gpu/drm/rockchip/rockchip

[PATCH v2 2/2] drm/rockchip: vop: fix irq disabled after vop driver probed

2018-05-28 Thread Heiko Stuebner
handler. changes in v2: - move to just check the power-domain state - add clock handling Signed-off-by: Sandy Huang [add commit message, moved to pm_runtime_get_if_in_use] Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 28 ++--- 1 file changed, 19

[PATCH v2 1/2] drm/rockchip: vop: split out core clock enablement into separate functions

2018-05-28 Thread Heiko Stuebner
Judging from the iommu code, both the hclk and aclk are necessary for register access. Split them off into separate functions from the regular vop enablement, so that we can use them elsewhere as well. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 44

Re: [RFC v2 2/2] dt-bindings: mipi-dsi: Add dual-channel DSI related info

2018-06-04 Thread Heiko Stuebner
operating in dual-channel DSI mode. > > Signed-off-by: Archit Taneja Looks like a great solution for that problem, so Reviewed-by: Heiko Stuebner As I'm looking into that for my rk3399-scarlet device right now and couldn't find this patchset in the kernel yet, is it planned to me

Re: [RFC v2 2/2] dt-bindings: mipi-dsi: Add dual-channel DSI related info

2018-06-06 Thread Heiko Stuebner
übner wrote: > >>> Am Mittwoch, 6. Juni 2018, 07:59:29 CEST schrieb Archit Taneja: > >>>> On Monday 04 June 2018 05:47 PM, Heiko Stuebner wrote: > >>>>> Am Donnerstag, 18. Januar 2018, 05:53:55 CEST schrieb Archit Taneja: > >>>>>>

Re: [RFC v2 2/2] dt-bindings: mipi-dsi: Add dual-channel DSI related info

2018-06-07 Thread Heiko Stuebner
your DSI-related writings below, did provide some new thought- directions for me, so thanks for that. > On Thu, Jun 07, 2018 at 03:25:18PM +0200, Heiko Stuebner wrote: > > Am Donnerstag, 7. Juni 2018, 12:39:03 CEST schrieb Andrzej Hajda: > > > On 07.06.2018 01:08, Heiko Stuebner wr

[PATCH 1/8] drm/bridge/synopsys: dsi: move mipi_dsi_host_unregister to __dw_mipi_dsi_remove

2018-06-11 Thread Heiko Stuebner
-by: Heiko Stuebner --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index 226171a3ece1..5ee605cbcf9d 100644 --- a/drivers/gpu/drm

[PATCH 4/8] dt-bindings: display: rockchip: update DSI controller

2018-06-11 Thread Heiko Stuebner
From: Nickey Yang This patch update describe panel/port links, including unit addresses in documentation of device tree bindings for the rockchip DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Nickey Yang Reviewed-by: Brian Norris Signed-off-by: Heiko

[PATCH v8 5/8] drm/rockchip: dsi: migrate to use dw-mipi-dsi bridge driver

2018-06-11 Thread Heiko Stuebner
robe Signed-off-by: Nickey Yang Signed-off-by: Brian Norris Reviewed-by: Brian Norris Reviewed-by: Sean Paul Reviewed-by: Archit Taneja Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/Kconfig |2 +- drivers/gpu/drm/rockchip/Makefile |2 +- .../gpu/drm/r

[PATCH 2/8] drm/bridge/synopsys: dsi: don't call __dw_mipi_dsi_probe from dw_mipi_dsi_bind

2018-06-11 Thread Heiko Stuebner
dw_mipi_dsi instead of the platform-device. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 15 +++ include/drm/bridge/dw_mipi_dsi.h | 5 + 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw

[PATCH 3/8] drm/bridge/synopsys: dsi: defer probing if panel not available in bridge-attach

2018-06-11 Thread Heiko Stuebner
) drm_bridge_attach fails with -EINVAL due to empty panel_bridge So emit a -EPROBE_DEFER in that case to give the driver another chance at getting the display later. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a

[RFC PATCH 0/8] drm/rockchip: migrate to common dw-mipi-dsi bridge and dual-dsi

2018-06-11 Thread Heiko Stuebner
ses it is possible to just pick half the series (till patch 5) to get the migration to the bridge driver first, so that we can get rid of the dw-dsi copy in the Rockchip driver. [0] https://patchwork.kernel.org/patch/10172381/ [1] https://lkml.org/lkml/2014/8/5/396 [2] https://patchwork.kernel.org/p

[PATCH 7/8] drm/bridge/synopsys: dsi: add dual-dsi support

2018-06-11 Thread Heiko Stuebner
outputs. To activate, the implementation-specific code should set the slave using dw_mipi_dsi_set_slave() before calling __dw_mipi_dsi_bind(). Signed-off-by: Nickey Yang Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 93 +-- include/drm/bridge

[PATCH 6/8] drm/dsi: add helper function to find the second host in a dual-dsi setup

2018-06-11 Thread Heiko Stuebner
From a specified output port of one dsi controller this function allows to iterate over the list of registered dsi controllers trying to find a second instance connected to the same display, like it is used in dual-dsi setups. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/drm_mipi_dsi.c

[PATCH 8/8] drm/rockchip: dsi: add dual mipi support

2018-06-11 Thread Heiko Stuebner
determine the dual-dsi state and get access to both controller instances. Signed-off-by: Heiko Stuebner --- .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 67 ++- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 1 + drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 3 + drivers/gpu

Re: [RFC v2 2/2] dt-bindings: mipi-dsi: Add dual-channel DSI related info

2018-06-11 Thread Heiko Stuebner
he node of the other dual-dsi part via separate ports as well. So no more hackery with endpoints and I can just follow Archit's dual-dsi binding text. Am Freitag, 8. Juni 2018, 10:47:05 CEST schrieb Andrzej Hajda: > On 08.06.2018 00:50, Heiko Stuebner wrote: > > Am Donnerstag, 7.

[PATCH v3 2/2] drm/rockchip: vop: fix irq disabled after vop driver probed

2018-06-12 Thread Heiko Stuebner
Signed-off-by: Heiko Stuebner Tested-by: Ezequiel Garcia --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 28 ++--- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 9a

[PATCH v3 0/2] drm/rockchip: try to fix vblank hang resulting from iommu irq change

2018-06-12 Thread Heiko Stuebner
t usage ourself, because of possible concurrency issues with vop enable/disable changes in v3: - fix comment in patch2 - add stable+fixes tags Heiko Stuebner (1): drm/rockchip: vop: split out core clock enablement into separate functions Sandy Huang (1): drm/rockchip: vop: fix irq disabled a

[PATCH v3 1/2] drm/rockchip: vop: split out core clock enablement into separate functions

2018-06-12 Thread Heiko Stuebner
;) Cc: sta...@vger.kernel.org Signed-off-by: Heiko Stuebner Tested-by: Ezequiel Garcia --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 44 +++-- 1 file changed, 31 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip

Re: [PATCH v3 2/2] drm/rockchip: vop: fix irq disabled after vop driver probed

2018-06-12 Thread Heiko Stuebner
Am Dienstag, 12. Juni 2018, 14:39:03 CEST schrieb Marc Zyngier: > Hi Heiko, > > On 12/06/18 13:15, Heiko Stuebner wrote: > > From: Sandy Huang > > > > The vop irq is shared between vop and iommu and irq probing in the > > iommu driver moved to the probe fu

[PATCH v4 1/2] drm/rockchip: vop: split out core clock enablement into separate functions

2018-06-12 Thread Heiko Stuebner
;) Cc: sta...@vger.kernel.org Signed-off-by: Heiko Stuebner Tested-by: Ezequiel Garcia --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 44 +++-- 1 file changed, 31 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip

[PATCH v4 2/2] drm/rockchip: vop: fix irq disabled after vop driver probed

2018-06-12 Thread Heiko Stuebner
st irqs in rk_iommu_probe()") Cc: sta...@vger.kernel.org Signed-off-by: Sandy Huang Signed-off-by: Heiko Stuebner Tested-by: Ezequiel Garcia --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 25 ++--- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/drivers/g

[PATCH v4 0/2] drm/rockchip: try to fix vblank hang resulting from iommu irq change

2018-06-12 Thread Heiko Stuebner
t usage ourself, because of possible concurrency issues with vop enable/disable changes in v3: - fix comment in patch2 - add stable+fixes tags changes in v4: - address Marc's comments to patch2 Heiko Stuebner (1): drm/rockchip: vop: split out core clock enablement into separate funct

Re: [PATCH v4 1/3] drm/panel: refactor INNOLUX P079ZCA panel driver

2018-06-14 Thread Heiko Stuebner
Am Mittwoch, 14. März 2018, 13:02:13 CEST schrieb Emil Velikov: > Hi Lin, > > On 14 March 2018 at 09:12, Lin Huang wrote: > > From: huang lin > > > > Refactor Innolux P079ZCA panel driver, let it support > > multi panel. > > > > Change-Id: If89be5e56dba8cb498e2d50c1bbeb0e8016123a2 > > Signed-off

Re: [PATCH] video: fbdev: remove unused auo_k190xfb drivers

2018-04-27 Thread Heiko Stuebner
I'll ever continue on trying to mainline these and if later someone wants to resurrect these (very old now) devices, they'll probably need a drm- driver anyway. So for the removal Reviewed-by: Heiko Stuebner Heiko ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v3 4/6] drm/rockchip: dw_hdmi: allow including external phys

2018-05-15 Thread Heiko Stuebner
Some variants of the dw-hdmi on Rockchip socs use a separate phy block accessed via the generic phy framework, so allow them to be included if such a phy reference is found. Signed-off-by: Heiko Stuebner Tested-by: Robin Murphy --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 10 ++ 1

[PATCH v3 2/6] drm/rockchip: dw_hdmi: Allow outputs that don't need output switching

2018-05-15 Thread Heiko Stuebner
-switching is necessary. Signed-off-by: Heiko Stuebner Tested-by: Robin Murphy --- changes in v3: - fixed wording issue found by Robin Murphy drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c

[PATCH v3 5/6] drm/rockchip: dw_hdmi: store rockchip_hdmi reference in phy_data object

2018-05-15 Thread Heiko Stuebner
t and use this reference later on. Inspiration for this comes from meson and sunxi dw-hdmi, which are using the same method. Signed-off-by: Heiko Stuebner Tested-by: Robin Murphy --- changes in v3: - reword commit message drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 9 +++-- 1 file chang

[PATCH v3 6/6] drm/rockchip: dw_hdmi: add dw-hdmi support for the rk3328

2018-05-15 Thread Heiko Stuebner
The rk3328 uses a dw-hdmi controller with an external hdmi phy from Innosilicon which uses the generic phy framework for access. Add the necessary data and the compatible for the rk3328 to the rockchip dw-hdmi driver. Signed-off-by: Heiko Stuebner Tested-by: Robin Murphy --- changes in v3

[PATCH v3 0/6] drm/rockchip: hdmi support for rk3328

2018-05-15 Thread Heiko Stuebner
Cerveny - phy: use unsigned long for all tmdsclk rate uses - phy: simplify tmds rate calculation - dropped patch exporting some dw-hdmi phy functions as a similar patch entered drm-misc already Heiko Stuebner (6): drm/bridge: dw-hdmi: allow forcing vendor phy-type drm/rockchip: dw_hdmi: Allow

[PATCH v3 3/6] dt-bindings: allow optional phys in Rockchip dw_hdmi binding

2018-05-15 Thread Heiko Stuebner
Some newer Rockchip SoCs use an Innosilicon hdmiphy accessed via general mmio, so allow these to be referenced via the regular phy interfaces and therefore add optional phy-related properties to the binding. Signed-off-by: Heiko Stuebner Reviewed-by: Rob Herring --- .../devicetree/bindings

[PATCH v3 1/6] drm/bridge: dw-hdmi: allow forcing vendor phy-type

2018-05-15 Thread Heiko Stuebner
may be necessary to allow forcing other types, but for now we'll keep it simply to the case actually seen in the wild. Signed-off-by: Heiko Stuebner Tested-by: Robin Murphy --- changes in v3: - only allow forcing vendor type, as suggested by Laurent drivers/gpu/drm/bridge/synopsys/dw-hdmi.

Re: [PATCH v5 4/4] drm/rockchip: support dp training outside dp firmware

2018-05-18 Thread Heiko Stuebner
Am Freitag, 18. Mai 2018, 03:45:46 CEST schrieb Brian Norris: > On Thu, May 17, 2018 at 6:41 PM, hl wrote: > > On Thursday, May 17, 2018 09:51 PM, Sean Paul wrote: > >> On Thu, May 17, 2018 at 05:18:00PM +0800, Lin Huang wrote: > >>> DP firmware uses fixed phy config values to do training, but som

Re: [PATCH v5 2/4] Documentation: bindings: add phy_config for Rockchip USB Type-C PHY

2018-05-18 Thread Heiko Stuebner
Am Donnerstag, 17. Mai 2018, 11:17:58 CEST schrieb Lin Huang: > If want to do training outside DP Firmware, need phy voltage swing > and pre_emphasis value. > > Signed-off-by: Lin Huang > --- > Changes in v2: > - None > Changes in v3: > - modify property description and add this property to Exam

Re: [PATCH v5 3/4] phy: rockchip-typec: support variable phy config value

2018-05-18 Thread Heiko Stuebner
Hi, Am Donnerstag, 17. Mai 2018, 11:17:59 CEST schrieb Lin Huang: > the phy config values used to fix in dp firmware, but some boards > need change these values to do training and get the better eye diagram > result. So support that in phy driver. > > Signed-off-by: Chris Zhong > Signed-off-by:

Re: [PATCH v5 4/4] drm/rockchip: support dp training outside dp firmware

2018-05-18 Thread Heiko Stuebner
Am Freitag, 18. Mai 2018, 17:36:56 CEST schrieb Sean Paul: > On Fri, May 18, 2018 at 10:52:17AM +0200, Heiko Stuebner wrote: > > Am Freitag, 18. Mai 2018, 03:45:46 CEST schrieb Brian Norris: > > > On Thu, May 17, 2018 at 6:41 PM, hl wrote: > > > > On Thursday, Ma

Re: [PATCH v3 01/26] drm/bridge: allow optionally specifying an owner .odev device

2018-05-19 Thread Heiko Stuebner
t;odev->of_node; > if (of_property_read_string(dev->of_node, "rockchip,output", &name)) > /* default set it as output rgb */ > lvds->output = DISPLAY_OUTPUT_RGB; for the Rockchip-part Acked-by: Heiko Stuebner ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v3 24/26] drm/bridge: remove the .of_node member

2018-05-19 Thread Heiko Stuebner
nel->dev->of_node; > - else if (lvds->bridge->of_node) > - remote = lvds->bridge->of_node; > else > remote = lvds->bridge->odev->of_node; > if (of_property_read_strin

Re: [PATCH 2/3] drm/rockchip: lvds: avoid duplicating drm_bridge_attach

2018-05-20 Thread Heiko Stuebner
Am Mittwoch, 2. Mai 2018, 09:40:24 CEST schrieb Peter Rosin: > drm_bridge_attach takes care of these assignments, so there is no need > to open-code them a second time. > > Signed-off-by: Peter Rosin applied to drm-misc-next Thanks Heiko ___ dri-de

[PATCH] backlight: pwm_bl: re-add driver internal enabled tracking

2018-11-09 Thread Heiko Stuebner
unmatched regulator-disable call, as it never got enabled from the pwm-bl before. To prevent these consistency issues, reintroduce the driver-internal tracking of the enabled state. Fixes: e6bcca0890b9 ("backlight: pwm_bl: Switch to using "atomic" PWM API") Signed-off-by: Heik

[PATCH] backlight: pwm_bl: fix devicetree parsing with auto-generated brightness tables

2018-11-12 Thread Heiko Stuebner
From: Heiko Stuebner Commit 88ba95bedb79 ("backlight: pwm_bl: Compute brightness of LED linearly to human eye") made the parse-dt function return early when using an auto- generated brightness-table, but didn't take into account that some more settings were handled below the brig

Re: [PATCH 2/2] drm/atomic: Create and use __drm_atomic_helper_crtc_reset() everywhere

2018-11-12 Thread Heiko Stuebner
_state), GFP_KERNEL); > - if (crtc->state) > - crtc->state->crtc = crtc; > + __drm_atomic_helper_crtc_reset(crtc, &crtc_state->base); > } > > static struct drm_crtc_state *vop_crtc_duplicate_state(struct drm_crtc *crtc) for the Rockchip-part Acked-by: Heiko

[PATCH] dt-bindings: display: add binding for Innolux ee101ia-01d panel

2018-11-13 Thread Heiko Stuebner
From: Heiko Stuebner This is a panel handled through the generic lvds-panel binding, so only needs its additional compatible specified. Signed-off-by: Heiko Stuebner --- .../bindings/display/panel/innolux,ee101ia-01d.txt | 7 +++ 1 file changed, 7 insertions(+) create mode 100644

Re: [PATCH] drm/rockchip: fix for mailbox read size

2018-11-19 Thread Heiko Stuebner
Am Dienstag, 6. November 2018, 16:37:05 CET schrieb Damian Kos: > Some of the functions (like cdn_dp_dpcd_read, cdn_dp_get_edid_block) > allow to read 64KiB, but the cdn_dp_mailbox_read_receive, that is > used by them, can read only up to 255 bytes at once. Normally, it's > not a big issue as DPCD

Re: [PATCH] drm/rockchip: update cursors asynchronously through atomic.

2018-08-13 Thread Heiko Stuebner
Am Montag, 13. August 2018, 09:11:07 CEST schrieb Tomasz Figa: > Hi Enric, > > On Tue, Aug 7, 2018 at 12:53 AM Enric Balletbo i Serra > wrote: > > > > Add support to async updates of cursors by using the new atomic > > interface for that. > > > > Signed-off-by: Enric Balletbo i Serra > > --- > >

Re: [PATCH v3 3/8] drm/bridge/synopsys: dsi: add ability to check dsi-device attachment

2018-08-13 Thread Heiko Stuebner
Hi Andrzej, Am Montag, 13. August 2018, 10:28:39 CEST schrieb Andrzej Hajda: > On 09.07.2018 15:48, Heiko Stuebner wrote: > > When the panel-driver is build as a module it currently fails hard as the > > panel cannot be probed directly: > > > > dw_mipi_dsi_bind(

Re: [PATCH v3 3/8] drm/bridge/synopsys: dsi: add ability to check dsi-device attachment

2018-08-14 Thread Heiko Stuebner
Hi Andrzej, Am Montag, 13. August 2018, 12:23:21 CEST schrieb Andrzej Hajda: > On 13.08.2018 10:44, Heiko Stuebner wrote: > > Am Montag, 13. August 2018, 10:28:39 CEST schrieb Andrzej Hajda: > >> On 09.07.2018 15:48, Heiko Stuebner wrote: > >>> +bool dw_mipi_dsi_devi

[PATCH v4 4/8] dt-bindings: display: rockchip: update DSI controller

2018-08-14 Thread Heiko Stuebner
Herring Signed-off-by: Heiko Stuebner --- .../display/rockchip/dw_mipi_dsi_rockchip.txt | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt b/Documentation/devicetree/bindings/display

[PATCH v4 8/8] drm/rockchip: dsi: add dual mipi support

2018-08-14 Thread Heiko Stuebner
determine the dual-dsi state and get access to both controller instances. Signed-off-by: Heiko Stuebner v4: add component directly in probe when adding empty dsi slave controller --- .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 93 +++ drivers/gpu/drm/rockchip

[PATCH v4 7/8] drm/bridge/synopsys: dsi: add dual-dsi support

2018-08-14 Thread Heiko Stuebner
settings - disable slave before master - lane-sum calculation comments Signed-off-by: Nickey Yang Signed-off-by: Heiko Stuebner Tested-by: Philippe Cornu --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 80 +-- include/drm/bridge/dw_mipi_dsi.h | 1 + 2 files

[PATCH v4 2/8] drm/bridge/synopsys: dsi: don't call __dw_mipi_dsi_probe from dw_mipi_dsi_bind

2018-08-14 Thread Heiko Stuebner
dw_mipi_dsi instead of the platform-device. Signed-off-by: Heiko Stuebner Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 15 +++ include/drm/bridge/dw_mipi_dsi.h | 5 + 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a

[PATCH v4 0/8] drm/rockchip: migrate to common dw-mipi-dsi bridge and dual-dsi

2018-08-14 Thread Heiko Stuebner
;s description - kept dual-dsi handling that mimicks tegra Heiko Stuebner (5): drm/bridge/synopsys: dsi: move mipi_dsi_host_unregister to __dw_mipi_dsi_remove drm/bridge/synopsys: dsi: don't call __dw_mipi_dsi_probe from dw_mipi_dsi_bind drm/bridge/synopsys: dsi: add ability to

[PATCH v4 6/8] drm/dsi: add helper function to find the second host in a dual-dsi setup

2018-08-14 Thread Heiko Stuebner
From a specified output port of one dsi controller this function allows to iterate over the list of registered dsi controllers trying to find a second instance connected to the same display, like it is used in dual-dsi setups. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/drm_mipi_dsi.c

[PATCH v4 5/8] drm/rockchip: dsi: migrate to use dw-mipi-dsi bridge driver

2018-08-14 Thread Heiko Stuebner
t rockchip-dsi changes move to call component_add in the new glue host-attach Signed-off-by: Nickey Yang Signed-off-by: Brian Norris Reviewed-by: Brian Norris Reviewed-by: Sean Paul Reviewed-by: Archit Taneja Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/Kconfig |

[PATCH v4 3/8] drm/bridge/synopsys: dsi: add ability to have glue-specific attach and detach

2018-08-14 Thread Heiko Stuebner
glue drivers, add a new struct for host_ops so that glue drivers can tell the bridge to call specific functions after the common host-attach and before the common host-detach run. Suggested-by: Andrzej Hajda Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c

[PATCH v4 1/8] drm/bridge/synopsys: dsi: move mipi_dsi_host_unregister to __dw_mipi_dsi_remove

2018-08-14 Thread Heiko Stuebner
-by: Heiko Stuebner Reviewed-by: Andrzej Hajda Reviewed-by: Philippe Cornu Tested-by: Philippe Cornu --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge

[PATCH] drm/panel: p079zca: unconditionally remove the panel on removal

2018-08-16 Thread Heiko Stuebner
There is no need to check innolux->base.dev when trying to remove the panel, as that variable is always set directly before the panel gets added and will still be available on panel_remove. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/panel/panel-innolux-p079zca.c | 3 +-- 1 file chan

[PATCH v3] drm/panel: add Kingdisplay kd097d04 panel driver

2018-08-16 Thread Heiko Stuebner
ble/prepare tracking seems something all panels do - document origins of the init sequence - lanes per dsi interface to 4 (two interfaces). Matches how tegra and pending rockchip dual-dsi handle (dual-)dsi lanes - spdx header instead of license boilerplate Signed-off-by: Nickey Yang Signed-of

[PATCH v4] drm/panel: add Kingdisplay kd097d04 panel driver

2018-08-17 Thread Heiko Stuebner
sequence - lanes per dsi interface to 4 (two interfaces). Matches how tegra and pending rockchip dual-dsi handle (dual-)dsi lanes - spdx header instead of license boilerplate Signed-off-by: Nickey Yang Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/panel/Kconfig | 11 + drive

Re: [PATCH v3] backlight: pwm_bl: switch to using "atomic" PWM API

2018-08-21 Thread Heiko Stuebner
xes a potential bug where pwm_get_state > can be called before pwm_init_state. > > Signed-off-by: Enric Balletbo i Serra On a Rockchip rk3399-scarlet tablet Tested-by: Heiko Stuebner This patch also _fixes_ the kernel bug below. Scarlet is not yet submitted upstream, but when I remove

Re: [PATCH v4 3/8] drm/bridge/synopsys: dsi: add ability to have glue-specific attach and detach

2018-08-21 Thread Heiko Stuebner
Hi, Am Montag, 20. August 2018, 12:34:37 CEST schrieb Andrzej Hajda: > On 14.08.2018 12:26, Heiko Stuebner wrote: > > With the regular means of adding the dsi-component in probe it creates > > a race condition with the panel probing, as the panel device only gets > > created

Re: [PATCH v4 6/8] drm/dsi: add helper function to find the second host in a dual-dsi setup

2018-08-21 Thread Heiko Stuebner
Hi Andrzej, Am Montag, 20. August 2018, 13:37:24 CEST schrieb Andrzej Hajda: > On 14.08.2018 12:26, Heiko Stuebner wrote: > > >From a specified output port of one dsi controller this function allows to > > iterate over the list of registered dsi controllers trying to find a s

[PATCH v5 0/8] drm/rockchip: migrate to common dw-mipi-dsi bridge and dual-dsi

2018-08-21 Thread Heiko Stuebner
e from glue drivers - kept dual-dsi handling that mimicks tegra Heiko Stuebner (4): drm/bridge/synopsys: dsi: move mipi_dsi_host_unregister to __dw_mipi_dsi_remove drm/bridge/synopsys: dsi: don't call __dw_mipi_dsi_probe from dw_mipi_dsi_bind drm/bridge/synopsys: dsi: add abil

[PATCH v5 6/7] drm/bridge/synopsys: dsi: add dual-dsi support

2018-08-21 Thread Heiko Stuebner
settings - disable slave before master - lane-sum calculation comments Signed-off-by: Nickey Yang Signed-off-by: Heiko Stuebner Tested-by: Philippe Cornu --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 80 +-- include/drm/bridge/dw_mipi_dsi.h | 1 + 2 files

<    1   2   3   4   5   6   7   8   9   >