Re: [PATCH] drm/i915:Remove unused parameter in marco.

2024-09-05 Thread HeLuang
在 2024/9/6 01:08, Jani Nikula 写道: On Thu, 05 Sep 2024, Rodrigo Vivi wrote: On Sat, Aug 31, 2024 at 09:51:14PM +0800, He Lugang wrote: The parameter dev_priv is actually not used in macro PORT_ALPM_CTL and PORT_ALPM_LFPS_CTL,so remove it to simplify the code. It is magically used on our ba

Re: [PATCH 1/3] drm/xe: use devm_add_action_or_reset() helper

2024-09-07 Thread HeLuang
sorry, pls just pass over this email. Best Regards, Lugang 在 2024/9/7 14:51, He Lugang 写道: Use devm_add_action_or_reset() to release resources in case of failure, because the cleanup function will be automatically called. Signed-off-by: He Lugang --- drivers/gpu/drm/xe/xe_gt_freq.c | 2

Re: [PATCH 1/3] drm/xe: use devm_add_action_or_reset() helper

2024-09-07 Thread HeLuang
sorry pls just pass over this email. -- Sincerely, Lugang 在 2024/9/7 14:51, He Lugang 写道: Use devm_add_action_or_reset() to release resources in case of failure, because the cleanup function will be automatically called. Signed-off-by: He Lugang --- drivers/gpu/drm/xe/xe_gt_freq.c | 2 +-

Re: [PATCH 1/3] drm/xe: use devm_add_action_or_reset() helper

2024-09-11 Thread HeLuang
在 2024/9/11 02:57, Rodrigo Vivi 写道: On Sat, Sep 07, 2024 at 02:54:39PM +0800, He Lugang wrote: Use devm_add_action_or_reset() to release resources in case of failure, because the cleanup function will be automatically called. Signed-off-by: He Lugang --- drivers/gpu/drm/xe/xe_gt_freq.c |