Re: [PATCH] drm/vbox: Convert to Linux IRQ interfaces

2021-08-02 Thread Hans de Goede
oks good to me: Reviewed-by: Hans de Goede And to make sure things don't regress I've also given this a test spin: Tested-by: Hans de Goede Note I assume that you will push this out do drmi-misc yourself (if you've not done so already given that this patch is somewhat old). Re

Re: [PATCH 1/2] drm/i915/display/vlv_dsi: Do not skip panel_pwr_cycle_delay when disabling the panel

2021-04-07 Thread Hans de Goede
Hi, On 4/7/21 2:34 PM, Ville Syrjälä wrote: > On Tue, Apr 06, 2021 at 03:57:32PM +0200, Hans de Goede wrote: >> Hi, >> >> On 3/25/21 12:48 PM, Hans de Goede wrote: >>> After the recently added commit fe0f1e3bfdfe ("drm/i915: Shut down >>> displays grace

Re: [PATCH 1/2] drm/i915/display/vlv_dsi: Do not skip panel_pwr_cycle_delay when disabling the panel

2021-04-12 Thread Hans de Goede
Hi, On 4/7/21 3:57 PM, Ville Syrjälä wrote: > On Wed, Apr 07, 2021 at 03:50:35PM +0200, Hans de Goede wrote: >> Hi, >> >> On 4/7/21 2:34 PM, Ville Syrjälä wrote: >>> On Tue, Apr 06, 2021 at 03:57:32PM +0200, Hans de Goede wrote: >>>> Hi, >>

[PATCH resend 0/9] drm: Add privacy-screen class and connector properties

2021-04-14 Thread Hans de Goede
ded. This means that initrd generation tools will need to be updated to include thinkpad_acpi when the i915 driver is added to the initrd. Without this the loading of the i915 driver will be delayed to after the switch to real rootfs. Regards, Hans Hans de Goede (8): drm: Add privacy-screen class

[PATCH resend 2/9] drm: Add privacy-screen class

2021-04-14 Thread Hans de Goede
driver for these other devices to register themselves as a privacy-screen provider; and allowing the drm/kms code to get a privacy-screen provider associated with a specific GPU/connector combo. Signed-off-by: Hans de Goede --- Documentation/gpu/drm-kms-helpers.rst | 15 + MAINTAINERS

[PATCH resend 1/9] drm/connector: Add support for privacy-screen properties (v4)

2021-04-14 Thread Hans de Goede
From: Rajat Jain Add support for generic electronic privacy screen properties, that can be added by systems that have an integrated EPS. Changes in v2 (Hans de Goede) - Create 2 properties, "privacy-screen sw-state" and "privacy-screen hw-state", to deal with devices w

[PATCH resend 3/9] drm/privacy-screen: Add X86 specific arch init code

2021-04-14 Thread Hans de Goede
. + * + * Authors: + * Hans de Goede + */ + +#include +#include + +static struct drm_privacy_screen_lookup arch_lookup; + +struct arch_init_data { + struct drm_privacy_screen_lookup lookup; + bool (*detect)(void); +}; + +static acpi_status __init acpi_set_handle(acpi_handle handle, u32

[PATCH resend 4/9] drm/privacy-screen: Add notifier support

2021-04-14 Thread Hans de Goede
Add support for privacy-screen consumers to register a notifier to be notified of external (e.g. done by the hw itself on a hotkey press) state changes. Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_privacy_screen.c | 67 +++ include/drm

[PATCH resend 6/9] platform/x86: thinkpad_acpi: Add hotkey_notify_extended_hotkey() helper

2021-04-14 Thread Hans de Goede
...). Signed-off-by: Hans de Goede --- drivers/platform/x86/thinkpad_acpi.c | 30 ++-- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index 0d9e2ddbf904..683c175cc28a 100644 --- a/drivers

[PATCH resend 5/9] drm/connector: Add a drm_connector privacy-screen helper functions

2021-04-14 Thread Hans de Goede
status. 2. drm_connector_update_privacy_screen(), Check if the passed in atomic state contains a privacy-screen sw_state change for the connector and if it does, call drm_privacy_screen_set_sw_state() with the new sw_state. Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_connector.c | 113

[PATCH resend 7/9] platform/x86: thinkpad_acpi: Get privacy-screen / lcdshadow ACPI handles only once

2021-04-14 Thread Hans de Goede
Get the privacy-screen / lcdshadow ACPI handles once and cache them, instead of retrieving them every time we need them. Signed-off-by: Hans de Goede --- drivers/platform/x86/thinkpad_acpi.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/platform

[PATCH resend 8/9] platform/x86: thinkpad_acpi: Register a privacy-screen device

2021-04-14 Thread Hans de Goede
de Goede --- Changes in v2: - Make the new lcdshadow_set_sw_state, lcdshadow_get_hw_state and lcdshadow_ops symbols static - Update state and call drm_privacy_screen_call_notifier_chain() when the state is changed by pressing the Fn + D hotkey combo --- drivers/platform/x86/Kconfig

[PATCH resend 9/9] drm/i915: Add privacy-screen support

2021-04-14 Thread Hans de Goede
h other encoder operations. Since no GPU poking is involved having this as a separate step of the commit process actually is the logical thing to do. Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/display/intel_display.c | 5 + drivers/gpu/drm/i915/display/intel_dp.c

[PATCH v2 0/9] drm: Add privacy-screen class and connector properties

2021-04-21 Thread Hans de Goede
cy screen, until the thinkpad_acpi driver is loaded. This means that initrd generation tools will need to be updated to include thinkpad_acpi when the i915 driver is added to the initrd. Without this the loading of the i915 driver will be delayed to after the switch to real rootfs. Regards, Hans Hans

[PATCH v2 2/9] drm: Add privacy-screen class (v2)

2021-04-21 Thread Hans de Goede
related code now that this is part of the main drm.ko - Use drm_class as class for the privacy-screen devices instead of adding a separate class for this Signed-off-by: Hans de Goede --- Documentation/gpu/drm-kms-helpers.rst | 15 + MAINTAINERS | 8

[PATCH v2 1/9] drm/connector: Add support for privacy-screen properties (v4)

2021-04-21 Thread Hans de Goede
From: Rajat Jain Add support for generic electronic privacy screen properties, that can be added by systems that have an integrated EPS. Changes in v2 (Hans de Goede) - Create 2 properties, "privacy-screen sw-state" and "privacy-screen hw-state", to deal with devices w

[PATCH v2 3/9] drm/privacy-screen: Add X86 specific arch init code

2021-04-21 Thread Hans de Goede
Red Hat, Inc. + * + * Authors: + * Hans de Goede + */ + +#include +#include + +#ifdef CONFIG_X86 +static struct drm_privacy_screen_lookup arch_lookup; + +struct arch_init_data { + struct drm_privacy_screen_lookup lookup; + bool (*detect)(void); +}; + +#if IS_ENABLED

[PATCH v2 4/9] drm/privacy-screen: Add notifier support

2021-04-21 Thread Hans de Goede
Add support for privacy-screen consumers to register a notifier to be notified of external (e.g. done by the hw itself on a hotkey press) state changes. Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_privacy_screen.c | 67 +++ include/drm

[PATCH v2 6/9] platform/x86: thinkpad_acpi: Add hotkey_notify_extended_hotkey() helper

2021-04-21 Thread Hans de Goede
...). Signed-off-by: Hans de Goede --- drivers/platform/x86/thinkpad_acpi.c | 30 ++-- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index 0d9e2ddbf904..683c175cc28a 100644 --- a/drivers

[PATCH v2 7/9] platform/x86: thinkpad_acpi: Get privacy-screen / lcdshadow ACPI handles only once

2021-04-21 Thread Hans de Goede
Get the privacy-screen / lcdshadow ACPI handles once and cache them, instead of retrieving them every time we need them. Signed-off-by: Hans de Goede --- drivers/platform/x86/thinkpad_acpi.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/platform

[PATCH v2 5/9] drm/connector: Add a drm_connector privacy-screen helper functions

2021-04-21 Thread Hans de Goede
status. 2. drm_connector_update_privacy_screen(), Check if the passed in atomic state contains a privacy-screen sw_state change for the connector and if it does, call drm_privacy_screen_set_sw_state() with the new sw_state. Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_connector.c | 113

[PATCH v2 8/9] platform/x86: thinkpad_acpi: Register a privacy-screen device

2021-04-21 Thread Hans de Goede
de Goede --- Changes in v2: - Make the new lcdshadow_set_sw_state, lcdshadow_get_hw_state and lcdshadow_ops symbols static - Update state and call drm_privacy_screen_call_notifier_chain() when the state is changed by pressing the Fn + D hotkey combo --- drivers/platform/x86/Kconfig

[PATCH v2 9/9] drm/i915: Add privacy-screen support

2021-04-21 Thread Hans de Goede
h other encoder operations. Since no GPU poking is involved having this as a separate step of the commit process actually is the logical thing to do. Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/display/intel_display.c | 5 + drivers/gpu/drm/i915/display/intel_dp.c

Re: [PATCH v2 0/9] drm: Add privacy-screen class and connector properties

2021-04-22 Thread Hans de Goede
Hi, On 4/22/21 10:51 AM, Simon Ser wrote: > Hi, > > On Wednesday, April 21st, 2021 at 10:47 PM, Hans de Goede > wrote: > >> There now is GNOME userspace code using the new properties: >> https://hackmd.io/@3v1n0/rkyIy3BOw > > Thanks for working on this. >

[PATCH 0/9] drm + usb-type-c: Add support for out-of-band hotplug notification

2021-04-28 Thread Hans de Goede
see a whole lot of changes. So I believe it would be best to just merge the entire series through drm-misc, Assuming we can get an ack from Greg for merging the typec_displayport.c changes this way. Regards, Hans Hans de Goede (8): drm/connector: Make the drm_sysfs connector->kdev device h

[PATCH 1/9] drm/connector: Make the drm_sysfs connector->kdev device hold a reference to the connector

2021-04-28 Thread Hans de Goede
extra info. So this extends the uevent part of the userspace API. Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_sysfs.c | 54 +++-- 1 file changed, 46 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c inde

[PATCH 2/9] drm/connector: Add a fwnode pointer to drm_connector and register with ACPI

2021-04-28 Thread Hans de Goede
are properly matched. Co-authored-by: Heikki Krogerus Signed-off-by: Heikki Krogerus Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_sysfs.c | 37 + include/drm/drm_connector.h | 2 ++ 2 files changed, 39 insertions(+) diff --git a/drivers/gpu/drm

[PATCH 3/9] drm/connector: Add drm_connector_find_by_fwnode() function

2021-04-28 Thread Hans de Goede
/drm_sysfs.c because it needs access to the drm_sysfs_device_connector device_type struct. Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_sysfs.c | 38 + include/drm/drm_connector.h | 1 + 2 files changed, 39 insertions(+) diff --git a/drivers/gpu/drm

[PATCH 4/9] drm/connector: Add support for out-of-band hotplug notification

2021-04-28 Thread Hans de Goede
ff-by: Hans de Goede --- drivers/gpu/drm/drm_connector.c | 20 include/drm/drm_connector.h | 33 + 2 files changed, 53 insertions(+) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index 87c68563e6c3..7d3adc4

[PATCH 7/9] usb: typec: altmodes/displayport: Make dp_altmode_notify() more generic

2021-04-28 Thread Hans de Goede
Make dp_altmode_notify() handle the dp->data.conf == 0 case too, rather then having separate code-paths for this in various places which call it. Signed-off-by: Hans de Goede --- drivers/usb/typec/altmodes/displayport.c | 35 +--- 1 file changed, 13 insertions(+),

[PATCH 6/9] drm/i915/dp: Add support for out-of-bound hotplug events

2021-04-28 Thread Hans de Goede
ommit adds support for this. Together with the recent addition of DP alt-mode support to the Type-C subsystem this makes DP over Type-C work on these devices. Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/display/intel_dp.c | 13 + 1 file changed, 13 insertions(+) diff --git

[PATCH 5/9] drm/i915: Associate ACPI connector nodes with connector entries

2021-04-28 Thread Hans de Goede
connector node for a connector entry straightforward (it's one-on-one mapping). Signed-off-by: Heikki Krogerus [hdego...@redhat.com: Move intel_acpi_assign_connector_fwnodes() to intel_acpi.c] Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/display/intel_acpi.c

[PATCH 9/9] platform/x86/intel_cht_int33fe: Correct "displayport" fwnode reference

2021-04-28 Thread Hans de Goede
The Type-C connector on these devices is connected to DP-2 not DP-1, so the reference must be to the DD04 child-node of the GPU, rather then the DD02 child-node. Signed-off-by: Hans de Goede --- drivers/platform/x86/intel_cht_int33fe_typec.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 8/9] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events

2021-04-28 Thread Hans de Goede
Use the new drm_connector_find_by_fwnode() and drm_connector_oob_hotplug_event() functions to let drm/kms drivers know about DisplayPort over Type-C hotplug events. Signed-off-by: Hans de Goede --- drivers/usb/typec/altmodes/displayport.c | 45 +++- 1 file changed, 44

Re: [PATCH 0/9] drm + usb-type-c: Add support for out-of-band hotplug notification

2021-04-28 Thread Hans de Goede
Hi, On 4/28/21 11:52 PM, Hans de Goede wrote: > Hi All, > > Here is a new attempt to make DP over Type-C work on devices where the > Type-C controller does not drive the HPD pin on the GPU, but instead > we need to forward HPD events from the Type-C controller to the DRM driver.

Re: [PATCH 1/9] drm/connector: Make the drm_sysfs connector->kdev device hold a reference to the connector

2021-04-29 Thread Hans de Goede
Hi, On 4/29/21 1:40 PM, Daniel Vetter wrote: > On Wed, Apr 28, 2021 at 11:52:49PM +0200, Hans de Goede wrote: >> Userspace could hold open a reference to the connector->kdev device, >> through e.g. holding a sysfs-atrtribute open after >> drm_sysfs_connector_remove() has b

Re: [PATCH 1/9] drm/connector: Make the drm_sysfs connector->kdev device hold a reference to the connector

2021-04-29 Thread Hans de Goede
Hi, On 4/29/21 2:04 PM, Daniel Vetter wrote: > On Thu, Apr 29, 2021 at 01:54:46PM +0200, Greg Kroah-Hartman wrote: >> On Thu, Apr 29, 2021 at 01:40:28PM +0200, Daniel Vetter wrote: >>> On Wed, Apr 28, 2021 at 11:52:49PM +0200, Hans de Goede wrote: >>>> Userspace coul

Re: [PATCH 1/9] drm/connector: Make the drm_sysfs connector->kdev device hold a reference to the connector

2021-04-30 Thread Hans de Goede
Hi, On 4/29/21 9:09 PM, Daniel Vetter wrote: > On Thu, Apr 29, 2021 at 02:33:17PM +0200, Hans de Goede wrote: >> Hi, >> >> On 4/29/21 2:04 PM, Daniel Vetter wrote: >>> On Thu, Apr 29, 2021 at 01:54:46PM +0200, Greg Kroah-Hartman wrote: >>>> On Thu, Apr 2

Re: [PATCH 1/9] drm/connector: Make the drm_sysfs connector->kdev device hold a reference to the connector

2021-04-30 Thread Hans de Goede
Hi, On 4/30/21 1:38 PM, Daniel Vetter wrote: > On Fri, Apr 30, 2021 at 1:28 PM Hans de Goede wrote: >> >> Hi, >> >> On 4/29/21 9:09 PM, Daniel Vetter wrote: >>> On Thu, Apr 29, 2021 at 02:33:17PM +0200, Hans de Goede wrote: >>>> Hi, >>>>

Re: [PATCH 1/9] drm/connector: Make the drm_sysfs connector->kdev device hold a reference to the connector

2021-04-30 Thread Hans de Goede
p.s. On 4/30/21 1:38 PM, Daniel Vetter wrote: Offtopic: > I'm also not sure why we have to use the kdev stuff here. For other > random objects we need to look up we're building that functionality on > that object. It means you need to keep another list_head around for > that lookup, but that's r

[PATCH 0/8] drm + usb-type-c: Add support for out-of-band hotplug notification (v4 resend)

2021-08-17 Thread Hans de Goede
les but it also touches drivers/usb/typec/altmodes/typec_displayport.c, that file usually does not see a whole lot of changes. So I believe it would be best to just merge the entire series through drm-misc, Assuming we can get an ack from Greg for merging the typec_displayport.c changes this way. Regard

[PATCH 1/8] drm/connector: Give connector sysfs devices there own device_type

2021-08-17 Thread Hans de Goede
: Heikki Krogerus Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_sysfs.c | 50 +++-- 1 file changed, 37 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c index 968a9560b4aa..f9d92bbb1f98 100644 --- a/drivers/gpu

[PATCH 2/8] drm/connector: Add a fwnode pointer to drm_connector and register with ACPI (v2)

2021-08-17 Thread Hans de Goede
are properly matched. Changes in v2: - Make drm_connector_cleanup() call fwnode_handle_put() on connector->fwnode and document this Co-developed-by: Heikki Krogerus Signed-off-by: Heikki Krogerus Tested-by: Heikki Krogerus Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_connecto

[PATCH 3/8] drm/connector: Add drm_connector_find_by_fwnode() function (v3)

2021-08-17 Thread Hans de Goede
-iter in drm_sysfs.c Changes in v3: - Add forward declaration for struct fwnode_handle to drm_crtc_internal.h (fixes warning reported by kernel test robot ) Tested-by: Heikki Krogerus Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_connector.c | 50 + drivers

[PATCH 4/8] drm/connector: Add support for out-of-band hotplug notification (v3)

2021-08-17 Thread Hans de Goede
o the drm_connector_oob_hotplug_event function since it is not used atm. This can be re-added later when a use for it actually arises. Tested-by: Heikki Krogerus Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_connector.c | 27 +++ include/drm/drm_connector.h | 9 +++

[PATCH 5/8] drm/i915: Associate ACPI connector nodes with connector entries (v2)

2021-08-17 Thread Hans de Goede
connector node for a connector entry straightforward (it's one-on-one mapping). Changes in v2 (Hans de goede): - Take a reference on the fwnode which we assign to the connector, for ACPI nodes this is a no-op but in the future we may see software-fwnodes assigned to connectors which are ref-co

[PATCH 6/8] drm/i915/dp: Add support for out-of-bound hotplug events

2021-08-17 Thread Hans de Goede
ommit adds support for this. Together with the recent addition of DP alt-mode support to the Type-C subsystem this makes DP over Type-C work on these devices. Tested-by: Heikki Krogerus Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/display/intel_dp.c | 12 1 file changed, 12

[PATCH 7/8] usb: typec: altmodes/displayport: Make dp_altmode_notify() more generic

2021-08-17 Thread Hans de Goede
Make dp_altmode_notify() handle the dp->data.conf == 0 case too, rather then having separate code-paths for this in various places which call it. Reviewed-by: Heikki Krogerus Tested-by: Heikki Krogerus Signed-off-by: Hans de Goede --- drivers/usb/typec/altmodes/displayport.c |

[PATCH 8/8] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events

2021-08-17 Thread Hans de Goede
Use the new drm_connector_oob_hotplug_event() functions to let drm/kms drivers know about DisplayPort over Type-C hotplug events. Reviewed-by: Heikki Krogerus Tested-by: Heikki Krogerus Signed-off-by: Hans de Goede --- Changes in v3: - Only call drm_connector_oob_hotplug_event() on hpd status

[GIT PULL] drm-misc + drm-intel: Add support for out-of-band hotplug notification

2021-08-20 Thread Hans de Goede
events (2021-08-20 12:35:59 +0200) Topic branch for drm-misc / drm-intel for OOB hotplug support for Type-C connectors -------- Hans de Goede (6): drm/connector:

Re: [GIT PULL] drm-misc + drm-intel: Add support for out-of-band hotplug notification

2021-08-24 Thread Hans de Goede
Hi, On 8/24/21 10:45 AM, Jani Nikula wrote: > On Fri, 20 Aug 2021, Hans de Goede wrote: >> Hello drm-misc and drm-intel maintainers, >> >> My "Add support for out-of-band hotplug notification" patchset: >> https://patchwork.freedesktop.org/series/9376

Re: [PATCH] drm/i915/display/vlv_dsi: Do no shut down displays on reboot if a DSI panel is used

2021-03-19 Thread Hans de Goede
Hi, On 3/1/21 4:43 PM, Hans de Goede wrote: > After the recently added commit fe0f1e3bfdfe ("drm/i915: Shut down > displays gracefully on reboot"), the DSI panel on a Cherry Trail based > Predia Basic tablet would no longer properly light up after reboot. > > The back

Re: [Intel-gfx] [PATCH] drm/i915/display/vlv_dsi: Do no shut down displays on reboot if a DSI panel is used

2021-03-22 Thread Hans de Goede
Hi, On 3/22/21 9:59 PM, Ville Syrjälä wrote: > On Mon, Mar 22, 2021 at 04:51:47PM -0400, Rodrigo Vivi wrote: >> On Fri, Mar 19, 2021 at 04:45:32PM +0100, Hans de Goede wrote: >>> Hi, >>> >>> On 3/1/21 4:43 PM, Hans de Goede wrote: >>>> After the rec

Re: [Intel-gfx] [PATCH resend 2/2] drm/i915/display: Make vlv_find_free_pps() skip pipes which are in use for non DP purposes

2021-03-23 Thread Hans de Goede
Hi, On 3/2/21 3:51 PM, Ville Syrjälä wrote: > On Tue, Mar 02, 2021 at 01:00:40PM +0100, Hans de Goede wrote: >> As explained by a long comment block, on VLV intel_setup_outputs() >> sometimes thinks there might be an eDP panel connected while there is none. >> In this cas

Re: [Intel-gfx] [PATCH] drm/i915/display/vlv_dsi: Do no shut down displays on reboot if a DSI panel is used

2021-03-23 Thread Hans de Goede
Hi, On 3/22/21 10:47 PM, Ville Syrjälä wrote: > On Mon, Mar 22, 2021 at 10:28:06PM +0100, Hans de Goede wrote: >> Hi, >> >> On 3/22/21 9:59 PM, Ville Syrjälä wrote: >>> On Mon, Mar 22, 2021 at 04:51:47PM -0400, Rodrigo Vivi wrote: >>>> On Fri, Mar 19, 202

Re: [Intel-gfx] [PATCH] drm/i915/display/vlv_dsi: Do no shut down displays on reboot if a DSI panel is used

2021-03-23 Thread Hans de Goede
Hi, On 3/23/21 6:51 PM, Ville Syrjälä wrote: > On Tue, Mar 23, 2021 at 06:29:53PM +0100, Hans de Goede wrote: >> Hi, >> >> On 3/22/21 10:47 PM, Ville Syrjälä wrote: >>> On Mon, Mar 22, 2021 at 10:28:06PM +0100, Hans de Goede wrote: >>>> Hi, >>

Re: [Intel-gfx] [PATCH] drm/i915/display/vlv_dsi: Do no shut down displays on reboot if a DSI panel is used

2021-03-23 Thread Hans de Goede
HI, On 3/23/21 8:13 PM, Hans de Goede wrote: > Hi, > > On 3/23/21 6:51 PM, Ville Syrjälä wrote: >> On Tue, Mar 23, 2021 at 06:29:53PM +0100, Hans de Goede wrote: >>> Hi, >>> >>> On 3/22/21 10:47 PM, Ville Syrjälä wrote: >>>> On Mon, Mar 22, 2

Re: [Intel-gfx] [PATCH resend 2/2] drm/i915/display: Make vlv_find_free_pps() skip pipes which are in use for non DP purposes

2021-03-24 Thread Hans de Goede
Hi, On 3/24/21 3:02 PM, Ville Syrjälä wrote: > On Tue, Mar 23, 2021 at 11:39:09AM +0100, Hans de Goede wrote: >> Hi, >> >> On 3/2/21 3:51 PM, Ville Syrjälä wrote: >>> On Tue, Mar 02, 2021 at 01:00:40PM +0100, Hans de Goede wrote: >>>> As

Re: [PATCH v2 00/10] drm: Support simple-framebuffer devices and firmware fbs

2021-03-25 Thread Hans de Goede
Hi, On 3/18/21 11:29 AM, Thomas Zimmermann wrote: > This patchset adds support for simple-framebuffer platform devices and > a handover mechanism for native drivers to take-over control of the > hardware. > > The new driver, called simpledrm, binds to a simple-frambuffer platform > device. The ke

[PATCH 1/2] drm/i915/display/vlv_dsi: Do not skip panel_pwr_cycle_delay when disabling the panel

2021-03-25 Thread Hans de Goede
off and directly on again in quick succession. Change the msleep for the panel_pwr_cycle_delay to a normal msleep() call to avoid the panel staying black after a quick off + on cycle. Cc: Ville Syrjälä Fixes: fe0f1e3bfdfe ("drm/i915: Shut down displays gracefully on reboot") Signed-off-

[PATCH 2/2] drm/i915/display/vlv_dsi: Move panel_pwr_cycle_delay to next panel-on

2021-03-25 Thread Hans de Goede
. Cc: Ville Syrjälä Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/display/intel_dsi.h | 1 + drivers/gpu/drm/i915/display/vlv_dsi.c | 25 ++-- 2 files changed, 20 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dsi.h b/drivers/gpu/drm

Re: [PATCH v2 00/10] drm: Support simple-framebuffer devices and firmware fbs

2021-03-29 Thread Hans de Goede
Hi, On 3/29/21 2:31 PM, Thomas Zimmermann wrote: > Hi > > Am 25.03.21 um 12:29 schrieb Hans de Goede: >> Hi, >> >> On 3/18/21 11:29 AM, Thomas Zimmermann wrote: >>> This patchset adds support for simple-framebuffer platform devices and >>> a hando

Re: [PATCH v2 00/10] drm: Support simple-framebuffer devices and firmware fbs

2021-03-30 Thread Hans de Goede
Hi, On 3/30/21 9:09 AM, Thomas Zimmermann wrote: > Hi > > Am 29.03.21 um 16:50 schrieb Hans de Goede: >> Hi, >> >> On 3/29/21 2:31 PM, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 25.03.21 um 12:29 schrieb Hans de Goede: >>>> Hi,

Re: [PATCH 11/11] [RFC] drm/i915/dp: fix array overflow warning

2021-03-30 Thread Hans de Goede
Hi, On 3/22/21 5:02 PM, Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc-11 warns that intel_dp_check_mst_status() has a local array of > fourteen bytes and passes the last four bytes into a function that > expects a six-byte array: > > drivers/gpu/drm/i915/display/intel_dp.c: In function >

Re: [PATCH 1/2] drm/i915/display/vlv_dsi: Do not skip panel_pwr_cycle_delay when disabling the panel

2021-04-06 Thread Hans de Goede
Hi, On 3/25/21 12:48 PM, Hans de Goede wrote: > After the recently added commit fe0f1e3bfdfe ("drm/i915: Shut down > displays gracefully on reboot"), the DSI panel on a Cherry Trail based > Predia Basic tablet would no longer properly light up after reboot. > > I

Re: [PATCH] drm/ttm: stop using GFP_TRANSHUGE_LIGHT

2021-01-15 Thread Hans de Goede
Hi, On 1/15/21 1:14 PM, Christian König wrote: > Hans do you have any more comments or a tested-by? Sorry, I've been busy chasing after another 5.11 regression, no comments, also no tested-by, but I do fully expect this to solve the issue. > Otherwise I push it to drm-misc-fixes today. That so

Re: [PATCH] video: fbdev: simplefb: Fix info message during probe

2021-01-20 Thread Hans de Goede
Hi, On 1/7/21 6:04 PM, Daniel Vetter wrote: > Hi Hans, > > On Tue, Dec 29, 2020 at 02:02:30PM +0100, Hans de Goede wrote: >> Hi, >> >> On 12/28/20 7:39 PM, Peter Robinson wrote: >>> The info message was showing the mapped address for the framebuffer. To

Re: [PATCH] drm: Added orientation quirk for OneGX1 Pro

2021-01-20 Thread Hans de Goede
Hi, On 1/20/21 9:56 PM, Jared Baldridge wrote: > The OneGX1 Pro has a fairly unique combination of generic strings, > but we additionally match on the BIOS date just to be safe. > > Signed-off-by: Jared Baldridge Thanks, patch looks good to me: Reviewed-by: Hans de Goede I will

Re: [PATCH] drm: Added orientation quirk for OneGX1 Pro

2021-01-20 Thread Hans de Goede
Hi, On 1/20/21 10:18 PM, Hans de Goede wrote: > Hi, > > On 1/20/21 9:56 PM, Jared Baldridge wrote: >> The OneGX1 Pro has a fairly unique combination of generic strings, >> but we additionally match on the BIOS date just to be safe. >> >> Signed-off-by: Jared Ba

Re: [GIT PULL] ib-drm-gpio-pdx86-rtc-wdt-v5.12-1

2021-01-26 Thread Hans de Goede
Hi, On 1/26/21 1:38 PM, Andy Shevchenko wrote: > Hi guys, > > This is first part of Intel MID outdated platforms removal. It's collected > into > immutable branch with a given tag, please pull to yours subsystems. > > (All changes are tagged by the respective maintainers) > > Thanks, > > With

Re: [GIT PULL] ib-drm-gpio-pdx86-rtc-wdt-v5.12-1

2021-01-26 Thread Hans de Goede
Hi, On 1/26/21 6:14 PM, Andy Shevchenko wrote: > On Tue, Jan 26, 2021 at 6:55 PM Patrik Jakobsson > wrote: >> On Tue, Jan 26, 2021 at 4:51 PM Andy Shevchenko >> wrote: >>> >>> On Tue, Jan 26, 2021 at 5:25 PM Patrik Jakobsson >>> wrote: On Tue, Jan 26, 2021 at 1:37 PM Andy Shevchenko

Re: [GIT PULL] ib-drm-gpio-pdx86-rtc-wdt-v5.12-1

2021-01-27 Thread Hans de Goede
Hi, On 1/26/21 9:54 PM, Andy Shevchenko wrote: > On Tue, Jan 26, 2021 at 8:33 PM Hans de Goede wrote: >> On 1/26/21 6:14 PM, Andy Shevchenko wrote: >>> On Tue, Jan 26, 2021 at 6:55 PM Patrik Jakobsson >>> wrote: >>>> On Tue, Jan 26, 2021 at 4:51 PM Andy Sh

[PATCH 1/2] drm/i915/display: Add a intel_pipe_is_enabled() helper

2021-01-29 Thread Hans de Goede
Factor the code to check if a pipe is currently enabled out of assert_pipe() and put it in a new intel_pipe_is_enabled() helper, so that it can be re-used without copy-pasting it. Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/display/intel_display.c | 20 ++-- drivers

[PATCH 2/2] drm/i915/display: Make vlv_find_free_pps() skip pipes which are in use for non DP purposes

2021-01-29 Thread Hans de Goede
i915 :00:02.0: [drm] failed to retrieve link info, disabling eDP Indicating that everything is working as it should. Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/display/intel_dp.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/gpu/drm/i915/disp

Re: [GIT PULL] ib-drm-gpio-pdx86-rtc-wdt-v5.12-1

2021-02-03 Thread Hans de Goede
Hi, On 2/3/21 10:54 AM, Andy Shevchenko wrote: > On Tue, Jan 26, 2021 at 4:23 PM Hans de Goede wrote: >> On 1/26/21 1:38 PM, Andy Shevchenko wrote: >>> Hi guys, >>> >>> This is first part of Intel MID outdated platforms removal. It's collected >&

Re: [PATCH] drm/vboxvideo: Vmap/vunmap cursor BO in prepare_fb and cleanup_fb

2021-02-03 Thread Hans de Goede
Hi, On 2/3/21 12:14 PM, Thomas Zimmermann wrote: > Hi > > Am 03.02.21 um 11:44 schrieb Daniel Vetter: >> On Wed, Feb 03, 2021 at 11:34:21AM +0100, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 03.02.21 um 11:29 schrieb Daniel Vetter: On Wed, Jan 27, 2021 at 03:05:03PM +0100, Thomas Zimmermann w

Re: [GIT PULL] ib-drm-gpio-pdx86-rtc-wdt-v5.12-1

2021-02-04 Thread Hans de Goede
Hi, On 2/4/21 11:36 AM, Daniel Vetter wrote: > On Thu, Feb 4, 2021 at 11:19 AM Patrik Jakobsson > wrote: >> >> On Wed, Feb 3, 2021 at 1:00 PM Andy Shevchenko >> wrote: >>> >>> On Tue, Jan 26, 2021 at 5:25 PM Patrik Jakobsson >>> wrote: On Tue, Jan 26, 2021 at 1:37 PM Andy Shevchenko

Re: [PATCH v2 0/2] drm/vboxvideo: Use struct drm_shadow_plane_state for cursor plane

2021-02-08 Thread Hans de Goede
in in a virtualbox vm using VboxSVGA graphics and I've not found any problems: Tested-by: Hans de Goede Regards, Hans > > drivers/gpu/drm/drm_gem_atomic_helper.c | 148 +++- > drivers/gpu/drm/vboxvideo/vbox_mode.c | 28 ++--- > include/drm/drm_ge

Re: [PATCH v2 0/2] drm/vboxvideo: Use struct drm_shadow_plane_state for cursor plane

2021-02-09 Thread Hans de Goede
Hi, On 2/9/21 9:13 AM, Thomas Zimmermann wrote: > Hi > > Am 08.02.21 um 18:43 schrieb Hans de Goede: >> Hi, >> >> On 2/8/21 2:50 PM, Thomas Zimmermann wrote: >>> (was: drm/vboxvideo: Vmap/vunmap cursor BO in prepare_fb and cleanup_fb) >>> >>&g

[PATCH] drm/i915/display/vlv_dsi: Do no shut down displays on reboot if a DSI panel is used

2021-03-01 Thread Hans de Goede
s known to cause problems. Which is a nice and simple way to deal with this. Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/display/vlv_dsi.c | 3 +++ drivers/gpu/drm/i915/i915_drv.c| 3 +++ drivers/gpu/drm/i915/i915_drv.h| 1 + 3 files changed, 7 insertions(+) diff --git

[PATCH resend 2/2] drm/i915/display: Make vlv_find_free_pps() skip pipes which are in use for non DP purposes

2021-03-02 Thread Hans de Goede
i915 :00:02.0: [drm] failed to retrieve link info, disabling eDP Indicating that everything is working as it should. Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/display/intel_pps.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/gpu/drm/i915/di

[PATCH resend 0/2] drm/i915/display: Make vlv_find_free_pps() skip pipes which are in use for non DP purposes

2021-03-02 Thread Hans de Goede
ble to actually apply and test it, please review. Regards, Hans Hans de Goede (2): drm/i915/display: Add a intel_pipe_is_enabled() helper drm/i915/display: Make vlv_find_free_pps() skip pipes which are in use for non DP purposes drivers/gpu/drm/i915/display/intel

[PATCH resend 1/2] drm/i915/display: Add a intel_pipe_is_enabled() helper

2021-03-02 Thread Hans de Goede
Factor the code to check if a pipe is currently enabled out of assert_pipe() and put it in a new intel_pipe_is_enabled() helper, so that it can be re-used without copy-pasting it. Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/display/intel_display.c | 20 ++-- drivers

Re: [PATCH] drm/vboxvideo: Use managed VRAM-helper initialization

2021-03-11 Thread Hans de Goede
nel-work workflow, so it is always a bit of a task-switch for me to switch to dealing with the "dim" workflow. ATM I don't have any other drm work pending, so I would appreciate it if someone else can pick this up. The change does look good to me: Reviewed-by: Ha

Re: [PATCH 4/9] drm/connector: Add support for out-of-band hotplug notification

2021-05-03 Thread Hans de Goede
Hi, On 5/3/21 10:00 AM, Heikki Krogerus wrote: > Hi Hans, > > On Wed, Apr 28, 2021 at 11:52:52PM +0200, Hans de Goede wrote: >> +/** >> + * struct drm_connector_oob_hotplug_event_data: OOB hotplug event data >> + * >> + * Contains data about out-of-band

[PATCH 0/9] drm + usb-type-c: Add support for out-of-band hotplug notification (v2)

2021-05-03 Thread Hans de Goede
o test patches for this). Regards, Hans Hans de Goede (8): drm/connector: Give connector sysfs devices there own device_type drm/connector: Add a fwnode pointer to drm_connector and register with ACPI drm/connector: Add drm_connector_find_by_fwnode() function (v2) drm/connector: Add

[PATCH 2/9] drm/connector: Add a fwnode pointer to drm_connector and register with ACPI

2021-05-03 Thread Hans de Goede
are properly matched. Co-authored-by: Heikki Krogerus Signed-off-by: Heikki Krogerus Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_sysfs.c | 37 + include/drm/drm_connector.h | 2 ++ 2 files changed, 39 insertions(+) diff --git a/drivers/gpu/drm

[PATCH 1/9] drm/connector: Give connector sysfs devices there own device_type

2021-05-03 Thread Hans de Goede
: Hans de Goede --- drivers/gpu/drm/drm_sysfs.c | 50 +++-- 1 file changed, 37 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c index f0336c804639..553024bcda8a 100644 --- a/drivers/gpu/drm/drm_sysfs.c +++ b

[PATCH 3/9] drm/connector: Add drm_connector_find_by_fwnode() function (v2)

2021-05-03 Thread Hans de Goede
-iter in drm_sysfs.c Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_connector.c | 50 + drivers/gpu/drm/drm_crtc_internal.h | 1 + include/drm/drm_connector.h | 8 + 3 files changed, 59 insertions(+) diff --git a/drivers/gpu/drm/drm_connector.c b

[PATCH 4/9] drm/connector: Add support for out-of-band hotplug notification (v2)

2021-05-03 Thread Hans de Goede
call drm_connector_find_by_fwnode() internally. This allows making drm_connector_find_by_fwnode() a drm-internal function and avoids code outside the drm subsystem potentially holding on the a drm_connector reference for a longer period. Signed-off-by: Hans de Goede --- drivers/gp

[PATCH 6/9] drm/i915/dp: Add support for out-of-bound hotplug events

2021-05-03 Thread Hans de Goede
ommit adds support for this. Together with the recent addition of DP alt-mode support to the Type-C subsystem this makes DP over Type-C work on these devices. Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/display/intel_dp.c | 13 + 1 file changed, 13 insertions(+) diff --git

[PATCH 5/9] drm/i915: Associate ACPI connector nodes with connector entries

2021-05-03 Thread Hans de Goede
connector node for a connector entry straightforward (it's one-on-one mapping). Signed-off-by: Heikki Krogerus [hdego...@redhat.com: Move intel_acpi_assign_connector_fwnodes() to intel_acpi.c] Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/display/intel_acpi.c

[PATCH 7/9] usb: typec: altmodes/displayport: Make dp_altmode_notify() more generic

2021-05-03 Thread Hans de Goede
Make dp_altmode_notify() handle the dp->data.conf == 0 case too, rather then having separate code-paths for this in various places which call it. Signed-off-by: Hans de Goede --- drivers/usb/typec/altmodes/displayport.c | 35 +--- 1 file changed, 13 insertions(+),

[PATCH 8/9] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events

2021-05-03 Thread Hans de Goede
Use the new drm_connector_find_by_fwnode() and drm_connector_oob_hotplug_event() functions to let drm/kms drivers know about DisplayPort over Type-C hotplug events. Signed-off-by: Hans de Goede --- Changes in v2: - Add missing depends on DRM to TYPEC_DP_ALTMODE Kconfig entry --- drivers/usb

[PATCH 9/9] platform/x86/intel_cht_int33fe: Correct "displayport" fwnode reference

2021-05-03 Thread Hans de Goede
The Type-C connector on these devices is connected to DP-2 not DP-1, so the reference must be to the DD04 child-node of the GPU, rather then the DD02 child-node. Signed-off-by: Hans de Goede --- drivers/platform/x86/intel_cht_int33fe_typec.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH 3/9] drm/connector: Add drm_connector_find_by_fwnode() function (v2)

2021-05-04 Thread Hans de Goede
Hi, On 5/4/21 10:00 AM, Andy Shevchenko wrote: > > > On Monday, May 3, 2021, Hans de Goede <mailto:hdego...@redhat.com>> wrote: > > Add a function to find a connector based on a fwnode. > > This will be used by the new drm_connector_oob_hotplug_event()

Re: [PATCH 4/9] drm/connector: Add support for out-of-band hotplug notification

2021-05-04 Thread Hans de Goede
Hi, On 5/4/21 4:52 PM, Heikki Krogerus wrote: > On Mon, May 03, 2021 at 04:35:29PM +0200, Hans de Goede wrote: >> Hi, >> >> On 5/3/21 10:00 AM, Heikki Krogerus wrote: >>> Hi Hans, >>> >>> On Wed, Apr 28, 2021 at 11:52:52PM +0200

Re: [PATCH 4/9] drm/connector: Add support for out-of-band hotplug notification (v2)

2021-05-04 Thread Hans de Goede
Hi, On 5/4/21 5:10 PM, Heikki Krogerus wrote: >> +/** >> + * drm_connector_oob_hotplug_event - Report out-of-band hotplug event to >> connector >> + * @connector: connector to report the event on >> + * @data: data related to the event >> + * >> + * On some hardware a hotplug event notification m

Re: [PATCH 5/9] drm/i915: Associate ACPI connector nodes with connector entries

2021-05-05 Thread Hans de Goede
Hi, On 5/4/21 9:52 AM, Andy Shevchenko wrote: > > > On Monday, May 3, 2021, Hans de Goede <mailto:hdego...@redhat.com>> wrote: > > From: Heikki Krogerus <mailto:heikki.kroge...@linux.intel.com>> > > On Intel platforms we know that the ACPI

Re: [PATCH 5/9] drm/i915: Associate ACPI connector nodes with connector entries

2021-05-05 Thread Hans de Goede
Hi, On 5/5/21 11:17 AM, Andy Shevchenko wrote: > On Wed, May 5, 2021 at 12:07 PM Hans de Goede wrote: >> On 5/4/21 9:52 AM, Andy Shevchenko wrote: >>> On Monday, May 3, 2021, Hans de Goede >> <mailto:hdego...@redhat.com>> wrote: > >

  1   2   3   4   5   6   7   8   9   10   >