Without this fix the 5120x1440@240 timing of these monitors
leads to screen flickering.
Cc: sta...@vger.kernel.org # 6.1+
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1442
Co-developed-by: Harry Wentland
Signed-off-by: Harry Wentland
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm
On 11/2/23 12:24, Nathan Chancellor wrote:
When building ARCH=x86_64 allmodconfig with clang, which have sanitizers
enabled, there is a warning about a large stack frame.
drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:6265:13:
error: stack frame size (2520) exceeds limit (
On 11/2/23 13:12, Nathan Chancellor wrote:
On Thu, Nov 02, 2023 at 12:59:00PM -0400, Hamza Mahfooz wrote:
On 11/2/23 12:24, Nathan Chancellor wrote:
When building ARCH=x86_64 allmodconfig with clang, which have sanitizers
enabled, there is a warning about a large stack frame.
drivers/gpu
On 11/1/23 17:36, Alex Deucher wrote:
On Wed, Nov 1, 2023 at 5:01 PM Hamza Mahfooz wrote:
Without this fix the 5120x1440@240 timing of these monitors
leads to screen flickering.
Cc: sta...@vger.kernel.org # 6.1+
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1442
Co-developed-by
it.
Cc: Alex Deucher
Cc: Mario Limonciello
Signed-off-by: Hamza Mahfooz
---
Documentation/gpu/amdgpu/display/dc-debug.rst | 41 +
.../gpu/amdgpu/display/trace-groups-table.csv | 29 ++
.../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 91 +++
.../gpu/drm/amd/display
it.
Cc: Alex Deucher
Cc: Mario Limonciello
Signed-off-by: Hamza Mahfooz
---
v2: only return -ETIMEDOUT for DMUB_STATUS_TIMEOUT
---
Documentation/gpu/amdgpu/display/dc-debug.rst | 41
.../gpu/amdgpu/display/trace-groups-table.csv | 29 ++
.../amd/display/amdgpu_dm
On 11/14/23 01:36, José Pekkarinen wrote:
The following patch will fix a minor issue where a debug message is
referencing an struct that has just being checked whether is null or
not. This has been noticed by using coccinelle, in the following output:
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu
On 11/14/23 10:27, José Pekkarinen wrote:
The following patch will fix a minor issue where a debug message is
referencing an struct that has just being checked whether is null or
not. This has been noticed by using coccinelle, in the following output:
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu
# 6.5.x
Cc: Hamza Mahfooz
Cc: Tsung-hua Lin
Cc: Chris Chi
Cc: Harry Wentland
Tested-by: Daniel Wheeler
Reviewed-by: Sun peng Li
Acked-by: Rodrigo Siqueira
Signed-off-by: Ivan Lipski
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 6 ++
1 file changed, 6 insertions(+)
di
ute.
Cc: Mario Limonciello
Signed-off-by: Hamza Mahfooz
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 59 +++
1 file changed, 59 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index cd98b3565178..b3fc
On 1/30/24 11:12, Alex Deucher wrote:
Add a helper so that drm drivers can consistently report
shared status via the fdinfo shared memory stats interface.
In addition to handle count, show buffers as shared if they
are shared via dma-buf as well (e.g., shared with v4l or some
other subsystem).
ute.
Cc: Mario Limonciello
Signed-off-by: Hamza Mahfooz
---
v2: hide ABM_LEVEL_IMMEDIATE_DISABLE in the read case, force an atomic
commit when setting the value, call sysfs_remove_group() in
amdgpu_dm_connector_unregister() and add some documentation.
---
.../gpu/drm/amd/display/amdgpu_dm/a
() callback to allow drivers to indicate if it isn't
appropriate to remove a device at the given time.
Cc: sta...@vger.kernel.org
Signed-off-by: Hamza Mahfooz
---
drivers/base/bus.c | 4
include/linux/device/bus.h | 2 ++
2 files changed, 6 insertions(+)
diff --git a/drivers/base/bu
Wire up the can_remove() callback, such that pci drivers can implement
their own version of it.
Cc: sta...@vger.kernel.org
Signed-off-by: Hamza Mahfooz
---
drivers/pci/pci-driver.c | 12
include/linux/pci.h | 5 +
2 files changed, 17 insertions(+)
diff --git a/drivers
Removing an amdgpu device that still has user space references allocated
to it causes undefined behaviour. So, implement amdgpu_pci_can_remove()
and disallow devices that still have files allocated to them from being
unbound.
Cc: sta...@vger.kernel.org
Signed-off-by: Hamza Mahfooz
---
drivers
On 2/9/24 08:02, Dan Carpenter wrote:
These ANDs should be ORs or it will lead to a NULL dereference.
Fixes: fb5a3d037082 ("drm/amd/display: Add NULL test for 'timing generator' in
'dcn21_set_pipe()'")
Fixes: 886571d217d7 ("drm/amd/display: Fix 'panel_cntl' could be null in
'dcn21_set_backligh
On 2/16/24 03:19, Pekka Paalanen wrote:
On Fri, 2 Feb 2024 10:28:35 -0500
Hamza Mahfooz wrote:
We want programs besides the compositor to be able to enable or disable
panel power saving features.
Could you also explain why, in the commit message, please?
It is unexpected for arbitrary
On 2/16/24 03:19, Pekka Paalanen wrote:
On Fri, 2 Feb 2024 10:28:35 -0500
Hamza Mahfooz wrote:
We want programs besides the compositor to be able to enable or disable
panel power saving features.
Could you also explain why, in the commit message, please?
It is unexpected for arbitrary
+ amd-gfx
+ Felix
On 11/20/23 10:16, bugzilla-dae...@kernel.org wrote:
https://bugzilla.kernel.org/show_bug.cgi?id=218168
Bug ID: 218168
Summary: amdgpu: kfd_topology.c warning: the frame size of 1408
bytes is larger than 1024 bytes
Prod
Hi André,
On 11/22/23 11:19, André Almeida wrote:
Hi,
This work from me and Simon adds support for DRM_MODE_PAGE_FLIP_ASYNC through
the atomic API. This feature is already available via the legacy API. The use
case is to be able to present a new frame immediately (or as soon as
possible), even i
On 11/27/23 09:54, Christian König wrote:
Try to fill up VRAM as well by setting the busy flag on GTT allocations.
This fixes the issue that when VRAM was evacuated for suspend it's never
filled up again unless the application is restarted.
Link: https://gitlab.freedesktop.org/drm/amd/-/issue
Cc: Nathan Chancellor
On 11/29/23 13:12, Jani Nikula wrote:
At least the i915 and amd drivers enable a bunch more compiler warnings
than the kernel defaults.
Extend the W=1 warnings to the entire drm subsystem by default. Use the
copy-pasted warnings from scripts/Makefile.extrawarn with
s/KBUI
On 6/27/24 16:30, Matthew Schwartz wrote:
From: John Schoenick
Since this patch is from John, you would need his S-o-b in here as well
(assuming you have his permission to add it).
Valve's Steam Deck Galileo revision has a 800x1280 OLED panel
Suggested-by: John Schoenick
Link:
https://gi
On 6/28/24 16:58, Matthew Schwartz wrote:
This is a series of 2 patches.
The first patch is from Valve's public kernel
source tree. It adds a panel rotation quirk for Valve's Steam Deck Galileo
revision, which has an 800x1280 OLED panel. The previous Steam Deck panel
orientation quirk does not a
feel
that would require too much back and forth, I'm okay with what is
currently proposed.
Reviewed-by: Hamza Mahfooz
---
The below approximates when each driver's date was last updated.
$ git grepblame "\(\.date = \".*\"\|#define.*DRIVER_DATE\)" -- drivers/g
Ripard
Cc: Thomas Zimmermann
Cc: Alex Deucher
Cc: Christian König
Cc: Pan, Xinhui
Cc: Karol Herbst
Cc: Lyude Paul
Cc: Danilo Krummrich
Cc: Rob Clark
Cc: Abhinav Kumar
Cc: Dmitry Baryshkov
Cc: Sean Paul
Cc: Marijn Suijten
Cc: Hamza Mahfooz
Acked-by: Javier Martinez Canillas
Acked-by
: Hamza Mahfooz
---
drivers/gpu/drm/Kconfig | 18 ++
drivers/gpu/drm/Makefile | 3 +++
2 files changed, 21 insertions(+)
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index 6ec33d36f3a4..36a00cba2540 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm
On 1/13/24 09:58, Christophe JAILLET wrote:
It is likely that the statement related to 'dml_edp' is misplaced. So move
it in the correct "case SIGNAL_TYPE_EDP".
Fixes: 7966f319c66d ("drm/amd/display: Introduce DML2")
Signed-off-by: Christophe JAILLET
Nice catch! Applied, thanks!
---
drive
s update it won't be part of it.
Thus, it's not truly a "global state", unlike object state structures
that do contain the entire state of a given object.
Signed-off-by: Maxime Ripard
Reviewed-by: Hamza Mahfooz
---
include/drm/drm_atomic.h | 8 +++-
1 file chang
On 12/29/23 11:25, Melissa Wen wrote:
IGT `amdgpu/amd_color/crtc-lut-accuracy` fails right at the beginning of
the test execution, during atomic check, because DC rejects the
bandwidth state for a fb sizing 64x64. The test was previously working
with the deprecated dc_commit_state(). Now using
dc
e OVT Algorithm, to extract all of the missing OVT
modes.
Suggested-by: Karol Herbst
Signed-off-by: Hamza Mahfooz
---
v3: move ovt stuff above add_cea_modes() and break up
calculate_ovt_mode() to make it easier to read.
v4: fix 32 bit build and constify read-only vars.
---
drivers/gp
17 PM Hamza Mahfooz wrote:
+
+/* OVT Algorthim as specified in CTA-861-I */
+static struct drm_display_mode *
+calculate_ovt_mode(struct drm_connector *connector, const struct cta_rid *rid,
+ u16 vrate)
Also all instances of CEA should probably be replaced with CTA, not
necessari
On 9/10/24 08:05, Jani Nikula wrote:
On Mon, 09 Sep 2024, Hamza Mahfooz wrote:
Video Format Data Blocks (VFDBs) contain the necessary information that
needs to be fed to the Optimized Video Timings (OVT) Algorithm.
Also, we require OVT support to cover modes that aren't supported by
ea
e OVT Algorithm, to extract all of the missing OVT
modes.
Cc: Ian Forbes
Cc: Jani Nikula
Suggested-by: Karol Herbst
Signed-off-by: Hamza Mahfooz
---
v3: move ovt stuff above add_cea_modes() and break up
calculate_ovt_mode() to make it easier to read.
v4: fix 32 bit build and constify read
On 9/26/24 09:32, Andi Kleen wrote:
I have an old monitor that reports a zero EDID block, which results in a
warning message. This happens on every screen save cycle, and maybe in
some other situations, and over time the whole kernel log gets filled
with these redundant messages. Printing it only
On 9/19/24 13:29, Alex Deucher wrote:
On Thu, Sep 19, 2024 at 12:06 PM Mario Limonciello
wrote:
On 9/19/2024 11:03, Alex Hung wrote:
A minor comment (see inline below).
Otherwise
Reviewed-by: Alex Hung
On 2024-09-18 15:38, Mario Limonciello wrote:
Some manufacturers have intentionally pu
e OVT Algorithm, to extract all of the missing OVT
modes.
Cc: Ian Forbes
Cc: Jani Nikula
Suggested-by: Karol Herbst
Signed-off-by: Hamza Mahfooz
---
v3: move ovt stuff above add_cea_modes() and break up
calculate_ovt_mode() to make it easier to read.
v4: fix 32 bit build and constify read
On Thu, Jan 16, 2025 at 09:13:18AM -0500, Alex Deucher wrote:
> On Tue, Nov 5, 2024 at 9:14 PM Hamza Mahfooz wrote:
> >
> > Video Format Data Blocks (VFDBs) contain the necessary information that
> > needs to be fed to the Optimized Video Timings (OVT) Algorithm.
> > A
On Wed, Feb 19, 2025 at 06:02:39PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Video players (eg. mpv) do periodic XResetScreenSaver() calls to
> keep the screen on while the video playing. The modesetting ddx
> plumbs these straight through into the kernel as DPMS setproperty
> ioctls,
201 - 239 of 239 matches
Mail list logo
