Re: [PATCH] drm/ingenic: Fix pixclock rate for 24-bit serial panels

2021-04-12 Thread H. Nikolaus Schaller
dingly, but clk_set_rate() >> used crtc_state->adjusted_mode->clock instead. >> Fixes: 28ab7d35b6e0 ("drm/ingenic: Properly compute timings when using a >> 3x8-bit panel") >> Cc: sta...@vger.kernel.org # v5.10 Tested-by: H. Nikolaus Schaller # CI20/jz4780 (HDM

[PATCH v2 2/8] drm/ingenic: Add jz4780 Synopsys HDMI driver

2021-08-05 Thread H. Nikolaus Schaller
From: Paul Boddie A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 HDMI support. This requires a new driver, plus device tree and configuration modifications. Signed-off-by: Paul Boddie Signed-off-by: Ezequiel Garcia Signed-off-by: H. Nikolaus Schaller --- drivers

[PATCH v2 3/8] drm/ingenic: Add support for JZ4780 and HDMI output

2021-08-05 Thread H. Nikolaus Schaller
. As soon as the overlay plane is enabled things go south :P Tested on MIPS Creator CI20 board. Signed-off-by: Paul Boddie Signed-off-by: Ezequiel Garcia Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 163 -- drivers/gpu/drm/ingenic

[PATCH v2 7/8] MIPS: CI20: defconfig: configure for DRM_DW_HDMI_JZ4780

2021-08-05 Thread H. Nikolaus Schaller
Enable CONFIG options as modules. Signed-off-by: Ezequiel Garcia Signed-off-by: H. Nikolaus Schaller --- arch/mips/configs/ci20_defconfig | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/mips/configs/ci20_defconfig b/arch/mips/configs/ci20_defconfig index ab7ebb0668340

[PATCH v2 5/8] MIPS: DTS: jz4780: account for Synopsys HDMI driver and LCD controller

2021-08-05 Thread H. Nikolaus Schaller
From: Paul Boddie A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 HDMI support. This requires a new driver, plus device tree and configuration modifications. Signed-off-by: Paul Boddie Signed-off-by: H. Nikolaus Schaller --- arch/mips/boot/dts/ingenic/jz4780.dtsi

[PATCH v2 8/8] [RFC] drm/ingenic: convert to component framework for jz4780 hdmi

2021-08-05 Thread H. Nikolaus Schaller
-authored-by: Paul Boddie Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c | 57 ++- 1 file changed, 46 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c b/drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c index

[PATCH v2 1/8] drm/bridge: synopsis: Add mode_fixup and bridge timings support

2021-08-05 Thread H. Nikolaus Schaller
From: Paul Boddie The platform-specific configuration structure is augmented with mode_fixup and timings members so that specialisations of the Synopsys driver can introduce mode flags and bus flags. Signed-off-by: Paul Boddie Signed-off-by: Ezequiel Garcia Signed-off-by: H. Nikolaus Schaller

[PATCH v2 4/8] dt-bindings: display: Add ingenic-jz4780-hdmi DT Schema

2021-08-05 Thread H. Nikolaus Schaller
From: Sam Ravnborg Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. Based on .txt binding from Zubair Lutfullah Kakakhel Signed-off-by: Sam Ravnborg Signed-off-by: H. Nikolaus Schaller Cc: Rob Herring Cc: devicet...@vger.kernel.org --- .../bindings/display/ingenic-jz4780

[PATCH v2 6/8] MIPS: DTS: CI20: add HDMI setup

2021-08-05 Thread H. Nikolaus Schaller
From: Paul Boddie We need to hook up * HDMI power regulator * HDMI connector * DDC pinmux * HDMI and LCD endpoint connections Signed-off-by: Paul Boddie Signed-off-by: H. Nikolaus Schaller --- arch/mips/boot/dts/ingenic/ci20.dts | 64 + 1 file changed, 64

[PATCH v2 0/8] MIPS: jz4780 HDMI

2021-08-05 Thread H. Nikolaus Schaller
This series adds HDMI support for JZ4780 and CI20 board V2: - code and commit messages revisited for checkpatch warnings - rebased on v5.14-rc4 - include (failed, hence RFC 8/8) attempt to convert to component framework (was suggested by Paul Cercueil a while ago) H. Nikolaus Schaller (2

Re: [PATCH v2 1/8] drm/bridge: synopsis: Add mode_fixup and bridge timings support

2021-08-05 Thread H. Nikolaus Schaller
Hi Robert, > Am 05.08.2021 um 16:32 schrieb Robert Foss : > > Hey Nikolaus, > > Thanks for submitting this series. > > On Thu, 5 Aug 2021 at 16:08, H. Nikolaus Schaller wrote: >> >> From: Paul Boddie >> >> + .mode_fixup = dw_hdmi_

Re: [PATCH v2 3/8] drm/ingenic: Add support for JZ4780 and HDMI output

2021-08-05 Thread H. Nikolaus Schaller
Hi Paul, > Am 05.08.2021 um 17:22 schrieb Paul Cercueil : > > Hi Nikolaus & Paul, > > Le jeu., août 5 2021 at 16:07:52 +0200, H. Nikolaus Schaller > a écrit : >> From: Paul Boddie >> Add support for the LCD controller present on JZ4780 SoCs. >> This

Re: [PATCH v2 8/8] [RFC] drm/ingenic: convert to component framework for jz4780 hdmi

2021-08-05 Thread H. Nikolaus Schaller
Hi Laurent, > Am 05.08.2021 um 17:04 schrieb Laurent Pinchart > : > > Hi Nikolaus, > > Thank you for the patch. > > On Thu, Aug 05, 2021 at 04:07:57PM +0200, H. Nikolaus Schaller wrote: >> This patch attempts to convert the ingenic-dw-hdmi driver >> in

Re: [PATCH v2 8/8] [RFC] drm/ingenic: convert to component framework for jz4780 hdmi

2021-08-05 Thread H. Nikolaus Schaller
Hi Paul, > Am 05.08.2021 um 18:17 schrieb Paul Cercueil : > > Hi Nikolaus and Laurent, > > Le jeu., août 5 2021 at 18:07:20 +0200, H. Nikolaus Schaller > a écrit : >> Hi Laurent, >>> Am 05.08.2021 um 17:04 schrieb Laurent Pinchart >>> : >>&g

Re: [PATCH v2 1/8] drm/bridge: synopsis: Add mode_fixup and bridge timings support

2021-08-07 Thread H. Nikolaus Schaller
Hi Robert, > Am 05.08.2021 um 16:32 schrieb Robert Foss : > > Hey Nikolaus, > > Thanks for submitting this series. > > On Thu, 5 Aug 2021 at 16:08, H. Nikolaus Schaller wrote: >> >> From: Paul Boddie >> >> static void dw_h

Re: [PATCH v2 3/8] drm/ingenic: Add support for JZ4780 and HDMI output

2021-08-07 Thread H. Nikolaus Schaller
Hi Paul, we have v3 ready and I'll post soon. Before, here are some feedback to your comments. > Am 05.08.2021 um 17:22 schrieb Paul Cercueil : > > Hi Nikolaus & Paul, >> + >> +if (priv->soc_info->hwdesc_size == sizeof(struct >> ingenic_dma_hwdesc_ext)) { > > I'd prefer a boolean fl

[PATCH v3 1/9] drm/ingenic: fix drm_init error path if IPU was registered

2021-08-07 Thread H. Nikolaus Schaller
From: Paul Boddie Code structure is in preparation to add hdmi unregistration in error case following the same pattern. Signed-off-by: Paul Boddie Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion

[PATCH v3 0/9] MIPS: JZ4780 and CI20 HDMI

2021-08-07 Thread H. Nikolaus Schaller
messages revisited for checkpatch warnings - rebased on v5.14-rc4 - include (failed, hence RFC 8/8) attempt to convert to component framework (was suggested by Paul Cercueil a while ago) H. Nikolaus Schaller (1): MIPS: CI20: defconfig: configure for DRM_DW_HDMI_JZ4780 Paul Boddie (7): drm/ingenic

[PATCH v3 3/9] drm/ingenic: Add jz4780 Synopsys HDMI driver

2021-08-07 Thread H. Nikolaus Schaller
From: Paul Boddie A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 HDMI support. This requires a new driver, plus device tree and configuration modifications. Signed-off-by: Paul Boddie Signed-off-by: Ezequiel Garcia Signed-off-by: H. Nikolaus Schaller --- drivers

[PATCH v3 5/9] dt-bindings: display: Add ingenic-jz4780-hdmi DT Schema

2021-08-07 Thread H. Nikolaus Schaller
From: Sam Ravnborg Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. Based on .txt binding from Zubair Lutfullah Kakakhel Signed-off-by: Sam Ravnborg Signed-off-by: H. Nikolaus Schaller Cc: Rob Herring Cc: devicet...@vger.kernel.org --- .../bindings/display/ingenic-jz4780

[PATCH v3 4/9] drm/ingenic: Add support for JZ4780 and HDMI output

2021-08-07 Thread H. Nikolaus Schaller
. As soon as the overlay plane is enabled things go south :P Tested on MIPS Creator CI20 board. Signed-off-by: Paul Boddie Signed-off-by: Ezequiel Garcia Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 119 +++--- drivers/gpu/drm/ingenic

[PATCH v3 2/9] drm/bridge: synopsis: Add mode_fixup and bridge timings support

2021-08-07 Thread H. Nikolaus Schaller
From: Paul Boddie The platform-specific configuration structure is augmented with mode_fixup and timings members so that specialisations of the Synopsys driver can introduce mode flags and bus flags. Signed-off-by: Paul Boddie Signed-off-by: Ezequiel Garcia Signed-off-by: H. Nikolaus Schaller

[PATCH v3 8/9] MIPS: CI20: defconfig: configure for DRM_DW_HDMI_JZ4780

2021-08-07 Thread H. Nikolaus Schaller
Enable CONFIG options as modules. Signed-off-by: Ezequiel Garcia Signed-off-by: H. Nikolaus Schaller --- arch/mips/configs/ci20_defconfig | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/mips/configs/ci20_defconfig b/arch/mips/configs/ci20_defconfig index ab7ebb0668340

[PATCH v3 6/9] MIPS: DTS: jz4780: account for Synopsys HDMI driver and LCD controllers

2021-08-07 Thread H. Nikolaus Schaller
From: Paul Boddie A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 HDMI support. This requires a new driver, plus device tree and configuration modifications. Signed-off-by: Paul Boddie Signed-off-by: H. Nikolaus Schaller --- arch/mips/boot/dts/ingenic/jz4780.dtsi

[PATCH v3 7/9] MIPS: DTS: CI20: add HDMI setup

2021-08-07 Thread H. Nikolaus Schaller
From: Paul Boddie We need to hook up * HDMI power regulator * HDMI connector * DDC pinmux * HDMI and LCD endpoint connections Signed-off-by: Paul Boddie Signed-off-by: H. Nikolaus Schaller --- arch/mips/boot/dts/ingenic/ci20.dts | 64 + 1 file changed, 64

[PATCH v3 9/9] drm/ingenic: add some jz4780 specific features

2021-08-07 Thread H. Nikolaus Schaller
From: Paul Boddie The jz4780 has some features which need initialization according to the vendor kernel. Signed-off-by: Paul Boddie Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a

Re: [PATCH 8/8] drm/ingenic: Attach bridge chain to encoders

2021-08-08 Thread H. Nikolaus Schaller
Hi Paul, all other patches apply cleanly but this one fails on top of v5.14-rc4. What base are you using? BR and thanks, Nikolaus > Am 08.08.2021 um 15:45 schrieb Paul Cercueil : > > Attach a top-level bridge to each encoder, which will be used for > negociating the bus format and flags. > > Al

Re: [PATCH 8/8] drm/ingenic: Attach bridge chain to encoders

2021-08-08 Thread H. Nikolaus Schaller
> Am 08.08.2021 um 21:04 schrieb Paul Cercueil : > > Hi Nikolaus, > > Le dim., août 8 2021 at 20:57:09 +0200, H. Nikolaus Schaller > a écrit : >> Hi Paul, >> all other patches apply cleanly but this one fails on top of v5.14-rc4. >> What base are you

Re: [PATCH 8/8] drm/ingenic: Attach bridge chain to encoders

2021-08-08 Thread H. Nikolaus Schaller
> Am 08.08.2021 um 21:06 schrieb H. Nikolaus Schaller : > > > >> Am 08.08.2021 um 21:04 schrieb Paul Cercueil : >> >> Hi Nikolaus, >> >> Le dim., août 8 2021 at 20:57:09 +0200, H. Nikolaus Schaller >> a écrit : >>> Hi Paul, >>

Re: [Letux-kernel] [PATCH 8/8] drm/ingenic: Attach bridge chain to encoders

2021-08-09 Thread H. Nikolaus Schaller
b H. Nikolaus Schaller : > > > >> Am 08.08.2021 um 21:06 schrieb H. Nikolaus Schaller : >> >> >> >>> Am 08.08.2021 um 21:04 schrieb Paul Cercueil : >>> >>> Hi Nikolaus, >>> >>> Le dim., août 8 2021 at 20:57:09 +0200, H. Nik

Re: [PATCH v3 4/4] drm/ingenic: Fix non-OSD mode

2021-01-24 Thread H. Nikolaus Schaller
Hi Paul, we observed the same issue on the jz4730 (which is almost identical to the jz4740 wrt. LCDC) and our solution [1] was simpler. It leaves the hwdesc f0 and f1 as they are and just takes f1 for really programming the first DMA descriptor if there is no OSD. We have tested on jz4730 and jz4

Re: [PATCH v3 4/4] drm/ingenic: Fix non-OSD mode

2021-01-24 Thread H. Nikolaus Schaller
Hi Paul, > Am 24.01.2021 um 10:43 schrieb Paul Cercueil : > > Hi Nikolaus, > > Le dim. 24 janv. 2021 à 10:30, H. Nikolaus Schaller a > écrit : >> Hi Paul, >> we observed the same issue on the jz4730 (which is almost identical >> to the jz4740 wrt. LCDC) and

Re: [PATCH v3 4/4] drm/ingenic: Fix non-OSD mode

2021-01-26 Thread H. Nikolaus Schaller
Hi Paul, > Am 24.01.2021 um 10:47 schrieb H. Nikolaus Schaller : > > Hi Paul, > >> Am 24.01.2021 um 10:43 schrieb Paul Cercueil : >> >> Hi Nikolaus, >> >> Le dim. 24 janv. 2021 à 10:30, H. Nikolaus Schaller a >> écrit : >>> Hi Pau

Re: [Letux-kernel] What ist the standard way to define connector type and bus format with device tree?

2021-01-31 Thread H. Nikolaus Schaller
ping? > Am 12.01.2021 um 12:41 schrieb H. Nikolaus Schaller : > > Hi, > according to bindings/display/panel/panel-common.yaml > and by using "panel-simple" as compatible string we > can define almost all properties of a DSI panel by a > device tree entry. > &

Re: [PATCH 0/5] drm/omap: hdmi: improve hdmi4 CEC, add CEC for hdmi5

2021-02-15 Thread H . Nikolaus Schaller
Hi, > Am 11.02.2021 um 11:36 schrieb Hans Verkuil : > > This series improves the drm_bridge support for CEC by introducing two > new bridge ops in the first patch, and using those in the second patch. > > This makes it possible to call cec_s_conn_info() and set > CEC_CAP_CONNECTOR_INFO for the C

Q: What ist the standard way to define connector type and bus format with device tree?

2021-02-28 Thread H. Nikolaus Schaller
know so that we can suggest a patch. BR and thanks, Nikolaus > Am 31.01.2021 um 11:54 schrieb H. Nikolaus Schaller : > > ping? > >> Am 12.01.2021 um 12:41 schrieb H. Nikolaus Schaller : >> >> Hi, >> according to bindings/display/panel/panel-common.yaml >&

[PATCH] drm: panel-simple: fix missing DRM_MODE_CONNECTOR_DPI for Ortustech com37h3m

2021-03-02 Thread H. Nikolaus Schaller
Without we get an "Specify missing connector_type" warning. Fixes: ddb8e853dc85 ("drm/panel: panel-simple: validate panel description") Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/panel/panel-simple.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers

Re: [REGRESSION] omapdrm/N900 display broken

2020-12-01 Thread H . Nikolaus Schaller
Hi Ivaylo, > Am 27.11.2020 um 19:44 schrieb Ivaylo Dimitrov : > > Hi, > > On 27.11.20 г. 19:30 ч., Tomi Valkeinen wrote: >> On 27/11/2020 17:37, Ivaylo Dimitrov wrote: >>> With 5.9.11 and the patch on top, n900 boots fine, albeit display remains >>> blank, could be related to >>> brightness, we

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-06 Thread H. Nikolaus Schaller
Hi Tomi, > Am 05.11.2020 um 13:02 schrieb Tomi Valkeinen : > > Hi, > > This is third version of the series sent by Sebastian in February: > > https://www.spinics.net/lists/linux-omap/msg153465.html > > I took the patches from his git tree, and rebased on 5.10-rc2. There > were some conflicts a

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-06 Thread H. Nikolaus Schaller
> Am 05.11.2020 um 18:36 schrieb Tomi Valkeinen : > > Hi, > > On 05/11/2020 19:15, H. Nikolaus Schaller wrote: > >> Next, I migrated my long waiting mipi_dsi/drm_panel driver conversion for >> the panel of the Pyra handheld (omap 5 based) to compile on 5.10-rc2

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-06 Thread H. Nikolaus Schaller
> Am 05.11.2020 um 19:28 schrieb Tomi Valkeinen : > > On 05/11/2020 20:14, H. Nikolaus Schaller wrote: >> >>> Am 05.11.2020 um 18:36 schrieb Tomi Valkeinen : >>> >>> Hi, >>> >>> On 05/11/2020 19:15, H. Nikolaus Schaller wrote: &

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-08 Thread H. Nikolaus Schaller
Hi Tomi, > Am 06.11.2020 um 16:04 schrieb Tomi Valkeinen : > >> >> I took the driver and make my omap4-sdp dts to use it. It probes for me, but >> stop after that: >> >> [ 119.346374] omapdss_dss 5800.dss: supply vdda_video not found, using >> dummy regulator >> [ 119.358398] DSS: OMAP

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-10 Thread H. Nikolaus Schaller
> Am 09.11.2020 um 11:22 schrieb Tomi Valkeinen : > > On 09/11/2020 11:30, H. Nikolaus Schaller wrote: >> >>> Am 09.11.2020 um 09:04 schrieb Tomi Valkeinen : >>> >>> On 07/11/2020 14:19, H. Nikolaus Schaller wrote: >>> >>>> I

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-10 Thread H. Nikolaus Schaller
> Am 09.11.2020 um 09:04 schrieb Tomi Valkeinen : > > On 07/11/2020 14:19, H. Nikolaus Schaller wrote: > >> I have set up based on our complete letux-5.10-rc2 tree and maybe using our >> private config makes >> the difference. Anyways, the driver is now pr

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-10 Thread H. Nikolaus Schaller
> Am 09.11.2020 um 11:34 schrieb Tomi Valkeinen : > > On 09/11/2020 12:31, H. Nikolaus Schaller wrote: >> >>> Am 09.11.2020 um 11:22 schrieb Tomi Valkeinen : >>> >>> On 09/11/2020 11:30, H. Nikolaus Schaller wrote: >>>> >>>>&g

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-10 Thread H. Nikolaus Schaller
> Am 11.11.2020 um 07:40 schrieb Tomi Valkeinen : > > On 10/11/2020 23:04, H. Nikolaus Schaller wrote: >> >>> Am 10.11.2020 um 17:52 schrieb Tomi Valkeinen : >>> >>> On 10/11/2020 18:49, H. Nikolaus Schaller wrote: >>> >>> I gue

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-10 Thread H. Nikolaus Schaller
> Am 10.11.2020 um 17:52 schrieb Tomi Valkeinen : > > On 10/11/2020 18:49, H. Nikolaus Schaller wrote: > > I guess you have the same issue. It goes to dsi_bridge_mode_valid, then > __dsi_calc_config, and stays > there finding good clocks. Yes, I could trace it down to ex

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-10 Thread H. Nikolaus Schaller
> Am 10.11.2020 um 14:49 schrieb H. Nikolaus Schaller : > > Hi Tomi, > >> Am 09.11.2020 um 12:33 schrieb Tomi Valkeinen : >> >> On 09/11/2020 13:09, H. Nikolaus Schaller wrote: >> >>>>> I see. >>>>> Anyways there is missing so

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-10 Thread H. Nikolaus Schaller
Hi Tomi, > Am 09.11.2020 um 12:33 schrieb Tomi Valkeinen : > > On 09/11/2020 13:09, H. Nikolaus Schaller wrote: > >>>> I see. >>>> Anyways there is missing some simple thing which makes the driver not >>>> prepared/enabled. >>>> Or i

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-12 Thread H. Nikolaus Schaller
> Am 11.11.2020 um 11:11 schrieb Tomi Valkeinen : > > On 11/11/2020 09:48, H. Nikolaus Schaller wrote: >> >>> Am 11.11.2020 um 07:40 schrieb Tomi Valkeinen : >>> >>> On 10/11/2020 23:04, H. Nikolaus Schaller wrote: >>>> >>>>&g

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-17 Thread H. Nikolaus Schaller
Hi Tomi, I hope you had a good weekend. And I have added back the CC: list because I think we have progress after our internal discussion and only one issue remaining. > Am 13.11.2020 um 15:49 schrieb Tomi Valkeinen : > > On 13/11/2020 16:41, H. Nikolaus Schaller wrote: >> Hi T

Re: [PATCH v15 4/7] drm/bridge: dw-hdmi: repair interworking with hdmi-connector for jz4780

2022-02-26 Thread H. Nikolaus Schaller
Hi Neil, > Am 21.02.2022 um 09:11 schrieb Neil Armstrong : > > Hi, > > On 12/02/2022 16:50, H. Nikolaus Schaller wrote: >> Commit 7cd70656d1285b ("drm/bridge: display-connector: implement bus fmts >> callbacks") >> introduced a new mechanism to n

[PATCH v16 0/4] MIPS: JZ4780 and CI20 HDMI

2022-02-26 Thread H. Nikolaus Schaller
rsion to component framework dropped (suggested by laurent.pinch...@ideasonboard.com and p...@crapouillou.net) PATCH V2 2021-08-05 16:08:05: - code and commit messages revisited for checkpatch warnings - rebased on v5.14-rc4 - include (failed, hence RFC 8/8) attempt to convert to component framework (

[PATCH v16 3/4] drm/bridge: display-connector: add ddc-en gpio support

2022-02-26 Thread H. Nikolaus Schaller
ddc gpio after probe and deactivates after remove so it is "almost on". But only if this driver is loaded (and not e.g. blacklisted as module). Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/bridge/display-connector.c | 15 +++ 1 file changed, 15 insertions(+) diff

[PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

2022-02-26 Thread H. Nikolaus Schaller
display-connector: implement bus fmts callbacks") Fixes: 6c3c719936dafe ("drm/bridge: synopsys: dw-hdmi: add bus format negociation") Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 10 ++ 1 file changed, 6 insertions(+), 4 deleti

[PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-02-26 Thread H. Nikolaus Schaller
so that specialization drivers like ingenic-dw-hdmi can enable polling. Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 9 + include/drm/bridge/dw_hdmi.h | 1 + 2 files changed, 10 insertions(+) diff --git a/drivers/gpu/drm/bridge

[PATCH v16 2/4] drm/ingenic: Add dw-hdmi driver specialization for jz4780

2022-02-26 Thread H. Nikolaus Schaller
drm_kms_helper_hotplug_event() introduced before. Signed-off-by: Paul Boddie Signed-off-by: Ezequiel Garcia Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/Kconfig | 9 ++ drivers/gpu/drm/ingenic/Makefile | 1 + drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c | 105

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

2022-03-01 Thread H. Nikolaus Schaller
Hi Neil, > Am 01.03.2022 um 10:18 schrieb Neil Armstrong : > > Hi, > > On 26/02/2022 18:13, H. Nikolaus Schaller wrote: >> Commit 7cd70656d1285b ("drm/bridge: display-connector: implement bus fmts >> callbacks") >> introduced a new mechanism to ne

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

2022-03-02 Thread H. Nikolaus Schaller
Hi Neil, > Am 02.03.2022 um 11:25 schrieb Neil Armstrong : > >> I added a printk for hdmi->sink_is_hdmi. This returns 1. Which IMHO is to be >> expected >> since I am using a HDMI connector and panel... So your patch will still add >> the UYVY formats. >> Either the synposys module inside the j

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

2022-03-02 Thread H. Nikolaus Schaller
Hi Neil, > Am 02.03.2022 um 15:34 schrieb Neil Armstrong : > > Hi, > >> (cross-checked: RGB mode still works if I force hdmi->sink_is_hdmi = false) > > I don't understand what's wrong, can you try to make the logic select > MEDIA_BUS_FMT_YUV8_1X24 instead of DRM_COLOR_FORMAT_YCBCR422 ? I have

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

2022-03-03 Thread H. Nikolaus Schaller
Hi Neil, > Am 03.03.2022 um 09:35 schrieb Neil Armstrong : > > Hi, > > On 02/03/2022 23:24, H. Nikolaus Schaller wrote: >> Hi Neil, >>> Am 02.03.2022 um 15:34 schrieb Neil Armstrong : >>> >>> Hi, >>> >>>> (cross-checked: R

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

2022-03-03 Thread H. Nikolaus Schaller
Hi Neil, > Am 03.03.2022 um 12:42 schrieb Neil Armstrong : > >> So how can we get that merged? IMHO your proposal should be before we add >> ingenic-dw-hdmi. >> If you have a version with proper commit message I can add it to the >> beginning of my >> seried and include it in a v17. Or if you g

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

2022-03-03 Thread H. Nikolaus Schaller
Hi Neil, > Am 03.03.2022 um 12:45 schrieb H. Nikolaus Schaller : > > Hi Neil, > >> Am 03.03.2022 um 12:42 schrieb Neil Armstrong : >> >>> So how can we get that merged? IMHO your proposal should be before we add >>> ingenic-dw-hdmi. >>> If

Re: [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-03 Thread H. Nikolaus Schaller
Hi Neil, > Am 03.03.2022 um 17:23 schrieb Neil Armstrong : > > Hi, > > On 26/02/2022 18:12, H. Nikolaus Schaller wrote: >> so that specialization drivers like ingenic-dw-hdmi can enable polling. >> Signed-off-by: H. Nikolaus Schaller >> --- >> driver

Re: [Letux-kernel] [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-03 Thread H. Nikolaus Schaller
Hi Neil, > Am 03.03.2022 um 17:30 schrieb H. Nikolaus Schaller : > > Hi Neil, > >> Am 03.03.2022 um 17:23 schrieb Neil Armstrong : >> >> Hi, >> >> On 26/02/2022 18:12, H. Nikolaus Schaller wrote: >>> so that specialization drivers like ingen

Re: [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-03 Thread H. Nikolaus Schaller
Hi Paul and Neil, > Am 03.03.2022 um 17:46 schrieb Paul Cercueil : > > Hi Neil, > > Le jeu., mars 3 2022 at 17:23:02 +0100, Neil Armstrong > a écrit : >> Hi, >> On 26/02/2022 18:12, H. Nikolaus Schaller wrote: >>> so that specialization drivers

Re: [Letux-kernel] [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-03 Thread H. Nikolaus Schaller
Hi Paul, > Am 03.03.2022 um 17:51 schrieb Paul Cercueil : > > Hi Nikolaus, > > Le jeu., mars 3 2022 at 17:43:05 +0100, H. Nikolaus Schaller > a écrit : >> Hi Neil, >>> Am 03.03.2022 um 17:30 schrieb H. Nikolaus Schaller : >>> Hi Neil, >>

Re: [Letux-kernel] [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-03 Thread H. Nikolaus Schaller
Hi Paul, Neil, > Am 03.03.2022 um 18:20 schrieb Paul Cercueil : > > Hi Nikolaus, > > [snip] > >>> Well he said "the Ingenic DRM core" aka ingenic-drm-drv.c. You do have >>> access to the main drm_device in the ingenic_drm_bind() function, so you >>> can add it there (with a cleanup function c

Re: [Letux-kernel] [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-04 Thread H. Nikolaus Schaller
Hi Paul, Neil, > Am 04.03.2022 um 17:47 schrieb Paul Cercueil : > > From what I understood in Nikolaus' last message, HDMI hotplug is actually > correctly detected, so there's no need for polling. What is missing is the > call to drm_kms_helper_hotplug_event *somewhere*, so that the information

Re: [Letux-kernel] [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-04 Thread H. Nikolaus Schaller
Hi Paul, > Am 04.03.2022 um 19:04 schrieb Paul Cercueil : > > > > Le ven., mars 4 2022 at 18:51:14 +0100, H. Nikolaus Schaller > a écrit : >> Hi Paul, Neil, >>> Am 04.03.2022 um 17:47 schrieb Paul Cercueil : >>> From what I understood in Nikola

Re: [Letux-kernel] [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-04 Thread H. Nikolaus Schaller
> Am 04.03.2022 um 19:33 schrieb Paul Cercueil : > > > > Le ven., mars 4 2022 at 19:15:13 +0100, H. Nikolaus Schaller > a écrit : >> Hi Paul, >>> Am 04.03.2022 um 19:04 schrieb Paul Cercueil : >>> Le ven., mars 4 2022 at 18:51:14 +0100, H. Niko

Re: [Letux-kernel] [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-04 Thread H. Nikolaus Schaller
Hi Paul, > Am 04.03.2022 um 19:41 schrieb H. Nikolaus Schaller : > > > >> Am 04.03.2022 um 19:33 schrieb Paul Cercueil : >> >> >> >> Le ven., mars 4 2022 at 19:15:13 +0100, H. Nikolaus Schaller >> a écrit : >>> Hi Paul, >&g

Re: [RESEND PATCH v3 0/6] drm/ingenic: Various improvements v3

2021-10-26 Thread H. Nikolaus Schaller
Hi Paul, > Am 26.10.2021 um 20:12 schrieb Paul Cercueil : > > Hi, > > I resend the V3 of my patchset for drm/ingenic, verbatim. > > The previous submission of my V3 received a lot of replies, but none of > these replies were actually talking about the patches themselves. Indeed. And since we h

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-22 Thread H. Nikolaus Schaller
Hi Paul, thanks for another update. We have been delayed to rework the CI20 HDMI code on top of your series but it basically works in some situations. There is for example a problem if the EDID reports DRM_COLOR_FORMAT_YCRCB422 but it appears to be outside of your series. The only issue we have i

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread H. Nikolaus Schaller
Hi Paul, > Am 23.09.2021 um 10:49 schrieb Paul Cercueil : > > Hi Nikolaus, > > Le jeu., sept. 23 2021 at 07:52:08 +0200, H. Nikolaus Schaller > a écrit : >> Hi Paul, >> thanks for another update. >> We have been delayed to rework the CI20 HDMI code on to

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread H. Nikolaus Schaller
Hi Laurent, > Am 23.09.2021 um 11:27 schrieb Laurent Pinchart > : > > Hi Nikolaus, > > On Thu, Sep 23, 2021 at 11:19:23AM +0200, H. Nikolaus Schaller wrote: >> >>>>> + ret = drm_b

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread H. Nikolaus Schaller
Hi Laurent, > Am 23.09.2021 um 12:03 schrieb Laurent Pinchart > : > > Hi Nikolaus, > > On Thu, Sep 23, 2021 at 11:55:56AM +0200, H. Nikolaus Schaller wrote: >>> Am 23.09.2021 um 11:27 schrieb Laurent Pinchart: >>> On Thu, Sep 23, 2021 at 11:19:23

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread H. Nikolaus Schaller
Hi Laurent, > IMHO it is leaving (mature) dw-hdmi untouched and make attachment of a > connector > in ingenic_drm_bind() depend on some condition. Since I don't know details of the DRM bridge/encoder/connector APIs), let me reformulate the quersion for a condition specifically. How can one

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread H . Nikolaus Schaller
Hi Paul, > Am 23.09.2021 um 15:30 schrieb Paul Cercueil : > > Hi Nikolaus, > > Le jeu., sept. 23 2021 at 13:41:28 +0200, H. Nikolaus Schaller > a écrit : >> Hi Laurent, >> Ah, ok. >> But then we still have issues. >> Firstly I would assume

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread H. Nikolaus Schaller
Hi Paul, > Am 23.09.2021 um 21:39 schrieb Paul Cercueil : > > > > Le jeu., sept. 23 2021 at 20:52:23 +0200, H. Nikolaus Schaller > a écrit : >> Hi Paul, >>> Am 23.09.2021 um 15:30 schrieb Paul Cercueil : >>> Hi Nikolaus, >>> Le jeu., se

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-24 Thread H. Nikolaus Schaller
Hi Paul, > Am 23.09.2021 um 22:23 schrieb H. Nikolaus Schaller : > > >> Because your "it doesn't work" arguments have zero weight otherwise. > > I hope I still can find it. So I can't promise anything. > We have had it complete in DTS and added code

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-25 Thread H. Nikolaus Schaller
Hi Paul, > Am 25.09.2021 um 21:08 schrieb Paul Cercueil : > > Hi Paul & Nikolaus, > > If you spent some time debugging the issue we did ... > instead of complaining that my patchset breaks things... ... we did have a working version (without hdmi-connector) and bisect pointed at your patch...

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-27 Thread H. Nikolaus Schaller
Hi Paul, > Am 25.09.2021 um 21:39 schrieb Paul Cercueil : > > > > Le sam., sept. 25 2021 at 21:26:42 +0200, H. Nikolaus Schaller > a écrit : >> Hi Paul, >>> Am 25.09.2021 um 21:08 schrieb Paul Cercueil : >>> Hi Paul & Nikolaus, >>&g

[PATCH v4 02/10] drm/ingenic: Add support for JZ4780 and HDMI output

2021-09-27 Thread H. Nikolaus Schaller
. Nikolaus Schaller --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 85 +-- drivers/gpu/drm/ingenic/ingenic-drm.h | 42 +++ 2 files changed, 122 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic

[PATCH v4 01/10] drm/ingenic: Fix drm_init error path if IPU was registered

2021-09-27 Thread H. Nikolaus Schaller
From: Paul Boddie If ingenic drm driver can not be registered, the IPU driver won't be deregistered. Code structure is chosen in preparation to add hdmi unregistration in error case following the same pattern by a later patch. Signed-off-by: Paul Boddie Signed-off-by: H. Nikolaus Sch

[PATCH v4 03/10] dt-bindings: display: Add ingenic, jz4780-dw-hdmi DT Schema

2021-09-27 Thread H. Nikolaus Schaller
From: Sam Ravnborg Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. Based on .txt binding from Zubair Lutfullah Kakakhel Signed-off-by: Sam Ravnborg Signed-off-by: H. Nikolaus Schaller Cc: Rob Herring Cc: devicet...@vger.kernel.org --- .../bindings/display/ingenic-jz4780

[PATCH v4 05/10] drm/bridge: synopsis: Fix to properly handle HPD

2021-09-27 Thread H. Nikolaus Schaller
It appears that dw-hdmi plugin detection is not properly propagated unless we call drm_kms_helper_hotplug_event(). Maybe drm_bridge_hpd_notify should have been setup to call this. Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 ++ 1 file changed, 2

[PATCH v4 08/10] MIPS: DTS: CI20: Add DT nodes for HDMI setup

2021-09-27 Thread H. Nikolaus Schaller
From: Paul Boddie We need to hook up * HDMI connector * HDMI power regulator * DDC pinmux * HDMI and LCDC endpoint connections Signed-off-by: Paul Boddie Signed-off-by: H. Nikolaus Schaller --- arch/mips/boot/dts/ingenic/ci20.dts | 67 + 1 file changed, 67

[PATCH v4 10/10] drm/ingenic: add some jz4780 specific features

2021-09-27 Thread H. Nikolaus Schaller
From: Paul Boddie The jz4780 has some features which need initialization according to the vendor kernel. Signed-off-by: Paul Boddie Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a

[PATCH v4 00/10] MIPS: JZ4780 and CI20 HDMI

2021-09-27 Thread H. Nikolaus Schaller
checkpatch warnings - rebased on v5.14-rc4 - include (failed, hence RFC 8/8) attempt to convert to component framework (was suggested by Paul Cercueil a while ago) H. Nikolaus Schaller (2): drm/bridge: synopsis: Fix to properly handle HPD MIPS: defconfig: CI20: configure for DRM_DW_HDMI_JZ

[PATCH v4 09/10] MIPS: defconfig: CI20: configure for DRM_DW_HDMI_JZ4780

2021-09-27 Thread H. Nikolaus Schaller
Enable CONFIG options as modules. Signed-off-by: Ezequiel Garcia Signed-off-by: H. Nikolaus Schaller --- arch/mips/configs/ci20_defconfig | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/mips/configs/ci20_defconfig b/arch/mips/configs/ci20_defconfig index ab7ebb066834

[PATCH v4 07/10] MIPS: DTS: jz4780: Account for Synopsys HDMI driver and LCD controllers

2021-09-27 Thread H. Nikolaus Schaller
From: Paul Boddie A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 HDMI support. This requires a new driver, plus device tree and configuration modifications. Signed-off-by: Paul Boddie Signed-off-by: H. Nikolaus Schaller --- arch/mips/boot/dts/ingenic/jz4780.dtsi

[PATCH v4 04/10] drm/bridge: synopsis: Add mode_fixup and bridge timings support

2021-09-27 Thread H. Nikolaus Schaller
From: Paul Boddie The platform-specific configuration structure is augmented with mode_fixup and timings members so that specialisations of the Synopsys driver can introduce mode flags and bus flags. Signed-off-by: Paul Boddie Signed-off-by: Ezequiel Garcia Signed-off-by: H. Nikolaus Schaller

[PATCH v4 06/10] drm/ingenic: Add dw-hdmi driver for jz4780

2021-09-27 Thread H. Nikolaus Schaller
From: Paul Boddie A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 HDMI support. This requires a new driver, plus device tree and configuration modifications. Signed-off-by: Paul Boddie Signed-off-by: Ezequiel Garcia Signed-off-by: H. Nikolaus Schaller --- drivers

Re: [PATCH v4 05/10] drm/bridge: synopsis: Fix to properly handle HPD

2021-09-27 Thread H. Nikolaus Schaller
> Am 27.09.2021 um 19:00 schrieb Maxime Ripard : > > Hi, > > On Mon, Sep 27, 2021 at 06:44:23PM +0200, H. Nikolaus Schaller wrote: >> It appears that dw-hdmi plugin detection is not properly >> propagated unless we call drm_kms_helper_hotplug_event(). >> >

Re: [PATCH v4 06/10] drm/ingenic: Add dw-hdmi driver for jz4780

2021-09-27 Thread H. Nikolaus Schaller
> Am 27.09.2021 um 19:08 schrieb Maxime Ripard : > > On Mon, Sep 27, 2021 at 06:44:24PM +0200, H. Nikolaus Schaller wrote: >> From: Paul Boddie >> >> A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 >> HDMI support. This requires a

Re: [PATCH v4 03/10] dt-bindings: display: Add ingenic, jz4780-dw-hdmi DT Schema

2021-09-28 Thread H. Nikolaus Schaller
Hi, > Am 27.09.2021 um 19:07 schrieb max...@cerno.tech: > > Hi, > > On Mon, Sep 27, 2021 at 06:44:21PM +0200, H. Nikolaus Schaller wrote: >> From: Sam Ravnborg >> >> Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. >> Based on .txt

Re: [PATCH v4 03/10] dt-bindings: display: Add ingenic, jz4780-dw-hdmi DT Schema

2021-09-28 Thread H. Nikolaus Schaller
> Am 28.09.2021 um 11:18 schrieb Maxime Ripard : > > On Tue, Sep 28, 2021 at 10:59:45AM +0200, H. Nikolaus Schaller wrote: >>>> +properties: >>>> + compatible: >>>> +items: >>>> + - const: ingenic,jz4780-dw-hdmi >>

Re: [PATCH v4 10/10] drm/ingenic: add some jz4780 specific features

2021-09-28 Thread H. Nikolaus Schaller
Hi Paul, > Am 28.09.2021 um 11:58 schrieb Paul Cercueil : > > Hi, > > Le lun., sept. 27 2021 at 18:44:28 +0200, H. Nikolaus Schaller > a écrit : >> From: Paul Boddie >> The jz4780 has some features which need initialization >> according to the vendor k

Re: [PATCH v4 02/10] drm/ingenic: Add support for JZ4780 and HDMI output

2021-09-28 Thread H. Nikolaus Schaller
Hi, > Am 28.09.2021 um 11:35 schrieb Paul Cercueil : > > Hi Nikolaus / Paul, > > Le lun., sept. 27 2021 at 18:44:20 +0200, H. Nikolaus Schaller > a écrit : >> From: Paul Boddie >> Add support for the LCD controller present on JZ4780 SoCs. >> This SoC uses

  1   2   3   4   5   6   >