Hi Sam,
On Mon, Jul 19, 2021 at 9:23 PM Sam Ravnborg wrote:
> On Wed, Jul 14, 2021 at 04:57:59PM +0200, Geert Uytterhoeven wrote:
> > This patch series optimizes console operations on ssd1307fb, after the
> > customary fixes and cleanups.
> >
> > Currently, each sc
Hi Sam,
On Mon, Jul 19, 2021 at 9:05 PM Sam Ravnborg wrote:
> On Wed, Jul 14, 2021 at 04:58:01PM +0200, Geert Uytterhoeven wrote:
> > Simplify the nested loops to handle conversion from linear frame buffer
> > to ssd1307 page layout:
> > 1. Move last page handling one leve
Hi Sam,
On Mon, Jul 19, 2021 at 9:07 PM Sam Ravnborg wrote:
> On Wed, Jul 14, 2021 at 04:58:02PM +0200, Geert Uytterhoeven wrote:
> > Extract the code to set the column and page ranges into a helper
> > function.
> >
> > Signed-off-by: Geert Uytterhoeven
>
Hi Sam,
On Mon, Jul 19, 2021 at 9:21 PM Sam Ravnborg wrote:
> On Wed, Jul 14, 2021 at 04:58:03PM +0200, Geert Uytterhoeven wrote:
> > Currently, each screen update triggers an I2C transfer of all screen
> > data, up to 1 KiB of data for a 128x64 display, which takes at least 20
Hi Sam,
On Tue, Jul 20, 2021 at 9:56 AM Geert Uytterhoeven wrote:
> On Mon, Jul 19, 2021 at 9:21 PM Sam Ravnborg wrote:
> > On Wed, Jul 14, 2021 at 04:58:03PM +0200, Geert Uytterhoeven wrote:
> > > Currently, each screen update triggers an I2C transfer of all screen
> >
(par->init_sequence[i] >= 0) {
> dev_err(par->info->device,
> "missing delimiter at position %d\n", i);
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge
ependency for SYSFB_SIMPLEFB, but also causes the
inclusion of drivers/firmware/sysfb.c.
>
> config SYSFB_SIMPLEFB
> bool "Mark VGA/VBE/EFI FB as generic system framebuffer"
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's
Hi Javier,
On Tue, Jul 27, 2021 at 12:22 PM Javier Martinez Canillas
wrote:
> On 7/27/21 12:03 PM, Geert Uytterhoeven wrote:
> >> --- a/drivers/firmware/Kconfig
> >> +++ b/drivers/firmware/Kconfig
> >> @@ -254,7 +254,7 @@ config QCOM_SCM_DOWNLOAD_MODE_DEFAULT
> &
Hi Javier,
On Tue, Jul 27, 2021 at 1:32 PM Javier Martinez Canillas
wrote:
> On 7/27/21 1:17 PM, Geert Uytterhoeven wrote:
> >> Not enabling this, would mean that a platform device to match a driver
> >> supporting the EFI GOP framebuffer (e.g: simple{drm,fb} or ef
Make ssd1307fb_update_display() return an error code, so callers that
can handle failures can propagate it.
Signed-off-by: Geert Uytterhoeven
Acked-by: Sam Ravnborg
---
v2:
- Add Acked-by.
---
drivers/video/fbdev/ssd1307fb.c | 18 --
1 file changed, 12 insertions(+), 6
Extract the code to set the column and page ranges into two helper
functions.
Signed-off-by: Geert Uytterhoeven
Acked-by: Sam Ravnborg
---
v2:
- Use two separate helpers instead of a single combined helper,
- Add Acked-by.
---
drivers/video/fbdev/ssd1307fb.c | 57
ssd1307fb_set_page_range() during initialization, as
ssd1307fb_update_rect() now takes care of that.
Note that for now the optimized operation is only used for fillrect,
copyarea, and imageblit, which are used by fbcon.
Signed-off-by: Geert Uytterhoeven
---
v2:
- Reorder operands in DIV_ROUND_UP
Cache the column and page ranges, to avoid doing unneeded I2C transfers
when the values haven't changed.
Signed-off-by: Geert Uytterhoeven
Acked-by: Sam Ravnborg
---
v2:
- Add Acked-by,
- Rebase.
---
drivers/video/fbdev/ssd1307fb.c | 27 +--
1 file change
over and over again; a simple increment is
sufficient.
Signed-off-by: Geert Uytterhoeven
Acked-by: Sam Ravnborg
---
v2:
- Add Acked-by.
---
drivers/video/fbdev/ssd1307fb.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/video/fbdev/ssd1307fb.c b/
, connected to an OrangeCrab ECP5 FPGA board
running a 64 MHz VexRiscv RISC-V softcore, where it reduced the CPU
usage for blinking the cursor from more than 70% to ca. 10%.
Thanks for applying!
[1]
https://lore.kernel.org/dri-devel/20210714145804.2530727-1-ge...@linux-m68k.org
Geert Uytterhoeven (5
G_EFI) += efi/
drivers/firmware/Makefile:obj-$(CONFIG_UEFI_CPER) += efi/
Looks like UEFI_CPER is not related to EFI at all (it's not set in
my arm64 config which has CONFIG_EFI=y). Perhaps it should be moved
to drivers/acpi/ instead?
Gr{oetje,eeting}s,
pends on DRM
> + depends on ARM64 && (ARCH_MXC || COMPILE_TEST)
As you now have two depends statements, I think this would be easier
to read by maintaining a strict separation between "hard" and "soft"
dependencies:
depends on DRM && ARM64
depends on ARCH_MXC
d as a replacement for offb, too...
> Patches 4 to 8 add the simpledrm driver. It's build on simple DRM helpers
> and SHMEM. It supports 16-bit, 24-bit and 32-bit RGB framebuffers. During
if support for 8-bit frame buffers would be added?
Gr{oetje,eeting}s,
Ge
c_bus_type.p && !early_soc_dev_attr)
> + return ERR_PTR(-EPROBE_DEFER);
> +
> while (!ret) {
> if (!(matches->machine || matches->family ||
> matches->revision || matches->soc_id))
Gr{oetje,eeting}s,
me drivers may be used on
multiple platforms, some of them registering an SoC device, some of
them not registering an SoC device. So there is no way to know the
difference between "SoC device not registered, intentionally", and
"SoC device not yet registered".
soc_device_match()
Hi Daniel,
On Tue, Apr 20, 2021 at 10:46 AM Daniel Vetter wrote:
> On Mon, Apr 19, 2021 at 10:00:56AM +0200, Geert Uytterhoeven wrote:
> > On Fri, Apr 16, 2021 at 11:00 AM Thomas Zimmermann
> > wrote:
> > > This patchset adds support for simple-framebuffer platform devi
88 or rgb565
> (depending on display resolution). We could pull off the same trick
> here and convert to rgb332 (assuming we can program the palette with the
> color cube needed for that). Wouldn't look pretty, but would probably
> work better than expecting userspace know what co
Hi Thomas,
On Mon, Apr 26, 2021 at 2:22 PM Thomas Zimmermann wrote:
> Am 20.04.21 um 11:27 schrieb Geert Uytterhoeven:
> > On Tue, Apr 20, 2021 at 11:22 AM Gerd Hoffmann wrote:
> >>>>> Patches 4 to 8 add the simpledrm driver. It's build on simple DRM
>
have
SoC-specific rules making it required.
Fixes: 99d66127fad25ebb ("dt-bindings: display: renesas,du: Convert binding to
YAML")
Signed-off-by: Geert Uytterhoeven
---
Documentation/devicetree/bindings/display/renesas,du.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documenta
000:
'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dt.yaml: display@feb0:
'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+'
Fix this by documenting the power-domains property
Hi Laurent,
On Thu, Apr 29, 2021 at 5:59 PM Laurent Pinchart
wrote:
> On Thu, Apr 29, 2021 at 02:47:56PM +0200, Geert Uytterhoeven wrote:
> > "make dtbs_check" complains:
> >
> > arch/arm/boot/dts/r8a7779-marzen.dt.yaml: display@fff8:
> >
+ /* CYAN_SKILLFISH */
> + {0x1002, 0x13FE, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> CHIP_CYAN_SKILLFISH|AMD_IS_APU},
> +
> {0, 0, 0}
> };
next-20210806 and later have a different resolution, duplicating the
BEIGE_GOBY entries before and after the CYAN_SKILL
emove(struct device *dev)
> > if (aux_ep_drv->remove)
> > aux_ep_drv->remove(aux_ep);
> > dev_pm_domain_detach(dev, true);
> > -
> > - return 0;
> > }
>
> This looks right.
>
> Greg provided a tag containing fc7a6209d571 ("bus:
is commit fixes the issue.
Note that I have no actual display device attached, so I do not know
if display out really works.
Salvator-X(S) seems to be fine, with the same disclaimer.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia
Hi Laurent,
On Tue, Aug 10, 2021 at 5:47 PM Geert Uytterhoeven wrote:
> On Thu, May 20, 2021 at 8:51 AM Laurent Pinchart
> wrote:
> > Replace the manual panel handling with usage of the DRM panel bridge
> > helper. This simplifies the driver, and
onnector creation in that
> case, and also skip creation of the DRM encoder as there's no point in
> an encoder without a connector.
>
> Fixes: e9e056949c92 ("drm: rcar-du: lvds: Convert to DRM panel bridge helper")
> Reported-by: Geert Uytterhoeven
Can you please chan
sdev->clks[i] = clock;
> + }
of_clk_bulk_get_all() + clk_bulk_prepare_enable()?
There's also devm_clk_bulk_get_all(), but not for the OF variant.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge..
t; Avoid these by using no_printk(), which adds format string checking as
> well.
>
> Signed-off-by: Arnd Bergmann
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In
2 00b3
>002e84b3 WAMS 0 0 4096
>
> Maybe you have some evidence showing an improvement? Ah, OK. I
> disassembled ti_sn_bridge_enable() and your patch saves 12 bytes, but
> I guess maybe alignment washes it out in reality
years and 9
months ago!
https://lore.kernel.org/linux-m68k/f5513ae92a5a1047ac2f91aebb9202680288cbba3...@e2k7-ms2.ds.strath.ac.uk/
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations wit
20210329?
Your tree has a second copy of the first conflict block after the second:
/* skip suspend of gfx and psp for S0ix
[...]
/* skip unnecessary suspend if we do not initialize them yet */
[...]
/* skip suspend o
ak bug reported by syzbot at:
> https://syzkaller.appspot.com/bug?id=741578659feabd108ad9e06696f0c1f2e69c4b6e
>
> Reported-by: syzbot+47fa9c9c648b76530...@syzkaller.appspotmail.com
> Signed-off-by: Phillip Potter
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
for encoders")
> Reported-by: Geert Uytterhoeven
> Signed-off-by: Kieran Bingham
Tested-by: Geert Uytterhoeven
As in "the WARNING from drm_encoder_init() is gone".
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond
e off. At that point, all information
you can extract from the system is valuable, and additional locking
issues are moot.
> Also adding dri-devel since defacto that's the only place where
> display people hang out nowadays.
Please keep on CCing linux-fbdev, e
Hi Daniel,
On Thu, Jan 14, 2021 at 5:11 PM Daniel Vetter wrote:
> On Thu, Jan 14, 2021 at 4:56 PM Geert Uytterhoeven
> wrote:
> > On Tue, Jan 12, 2021 at 5:00 PM Daniel Vetter wrote:
> > > On Sat, Jan 9, 2021 at 12:11 AM Linus Torvalds
> > > wrote:
> >
Hi Phillip,
On Fri, Jan 22, 2021 at 8:26 PM Phillip Susi wrote:
> Geert Uytterhoeven writes:
> Judging from some of the comments in the code, it looks like you were
> one of the original authors of fbcon? I haven't been able to find any
Indeed, a long time ago... Before DRM
Mike Rapoport
> Cc: Oscar Salvador
> Cc: Michal Hocko
> Cc: Wei Yang
> Cc: "Gustavo A. R. Silva"
> Cc: Sam Ravnborg
> Signed-off-by: David Hildenbrand
Fixes: ffd29195ed720188 ("drivers/video/acornfb.c: remove dead code")
Gr{oetje,eeting}s,
t; but this also fixes the crash...
While this fixes the crash, it does not propagate the error condition
(which may be -EPROBE_DEFER) upstream.
Same for devm_request_irq().
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge
pr_info("TE request_irq completion.\n");
> + }
> + } else {
> + pr_info("%s:%d, TE gpio not specified\n",
> + __func__, __LINE__);
> + }
> /* turn off sleep mode */
> write_reg(par, MIPI_DCS_E
gt; IRQF_TRIGGER_RISING,
> + "TE_GPIO", par);
> + if (rc) {
> + dev_err(par->info->device, "TE request_irq
> failed.\n");
> + devm_gpiod_put(dev, par->gpio.
iod_to_irq(par->gpio.te));
> + } else {
> + dev_info(par->info->device, "%s:%d, TE gpio not specified\n",
> +__func__, __LINE__);
> + }
> /* turn off sleep mode */
> write_reg(par, MIPI_DCS_EXIT_SLEEP_MODE);
&
gt; > return PTR_ERR(par->gpio.te);
>
> Not exactly. I'm suggesting something like this.
>
> if (IS_ERR(par->gpio.te) == -EPROBE_DEFER) {
> return -EPROBE_DEFER;
>
> if (IS_ERR(par->gpio.te))
> par-gpio.te = NULL;
>
> This
Hi Carlis,
On Thu, Jan 28, 2021 at 12:03 PM carlis wrote:
> On Thu, 28 Jan 2021 10:42:54 +0100
> Geert Uytterhoeven wrote:
> > On Thu, Jan 28, 2021 at 7:53 AM Kari Argillander
> > wrote:
> > > On Thu, Jan 28, 2021 at 09:42:58AM +0800, carlis wrote:
> > >
- - renesas,pfc-r8a73a4
> - - renesas,pfc-r8a7740
> - - renesas,pfc-sh73a0
> + enum:
> +- renesas,pfc-r8a73a4
> +- renesas,pfc-r8a7740
> +- renesas,pfc-sh73a0
Missing "contains"?
Gr{oetje,eeting}s,
Gee
Hi Rob,
On Wed, Feb 3, 2021 at 4:55 PM Rob Herring wrote:
> On Wed, Feb 03, 2021 at 09:01:23AM +0100, Geert Uytterhoeven wrote:
> > On Tue, Feb 2, 2021 at 9:55 PM Rob Herring wrote:
> > > Properties in if/then schemas weren't getting checked by the meta-schemas.
>
e still use this driver?
>
> I currently have this problem on my machine.
> I have submitted a revised patch -- which includes the console log.
Your machine is "QEMU Standard"?
Can this happen on real hardware, too, or is this a deficiency in QEMU,
which should be fixed there?
G
On Thu, Jan 14, 2021 at 11:00 AM Geert Uytterhoeven
wrote:
> On Wed, Jan 13, 2021 at 6:02 PM Kieran Bingham
> wrote:
> > The encoder allocation was converted to a DRM managed resource at the
> > same time as the addition of a new helper drmm_encoder_alloc() which
> > sim
ted by: scripts/coccinelle/misc/semicolon.cocci
> >
> > Fixes: ade896460e4a ("drm: DRM_KMB_DISPLAY should depend on ARCH_KEEMBAY")
This Fixed-tag is completely bogus. The right one is
Fixes: 98521f4d4b4cb265 ("drm/kmb: Mipi DSI part of the display driver")
> &g
l = get_number(fp);
+ maxval = get_maxval(fp);
and:
/* Plain PPM */
- maxval = get_number(fp);
+ maxval = get_maxval(fp);
+
+val = get_number(fp);
return (255*val+maxval/2)/maxval;
}
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- The
over and over again; a simple increment is
sufficient.
Signed-off-by: Geert Uytterhoeven
---
drivers/video/fbdev/ssd1307fb.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
index e6b
Extract the code to set the column and page ranges into a helper
function.
Signed-off-by: Geert Uytterhoeven
---
drivers/video/fbdev/ssd1307fb.c | 61 +++--
1 file changed, 36 insertions(+), 25 deletions(-)
diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers
Convert the Solomon SSD1307 Framebuffer Device Tree binding
documentation to json-schema.
Fix the spelling of the "pwms" property.
Document default values.
Make properties with default values not required.
Signed-off-by: Geert Uytterhoeven
---
I have listed Maxime as the maintainer, a
Make ssd1307fb_update_display() return an error code, so callers that
can handle failures can propagate it.
Signed-off-by: Geert Uytterhoeven
---
drivers/video/fbdev/ssd1307fb.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/video/fbdev
your comments!
Geert Uytterhoeven (5):
video: fbdev: ssd1307fb: Propagate errors via
ssd1307fb_update_display()
video: fbdev: ssd1307fb: Simplify ssd1307fb_update_display()
video: fbdev: ssd1307fb: Extract ssd1307fb_set_address_range()
video: fbdev: ssd1307fb: Optimize screen updates
initialization, as ssd1307fb_update_rect() now takes care of that.
Note that for now the optimized operation is only used for fillrect,
copyarea, and imageblit, which are used by fbcon.
Signed-off-by: Geert Uytterhoeven
---
drivers/video/fbdev/ssd1307fb.c | 43
Cache the column and page ranges, to avoid doing unneeded I2C transfers
when the values haven't changed.
Signed-off-by: Geert Uytterhoeven
---
drivers/video/fbdev/ssd1307fb.c | 52 +++--
1 file changed, 36 insertions(+), 16 deletions(-)
diff --git a/drivers/
Hi Maxime,
On Tue, May 18, 2021 at 4:33 PM Maxime Ripard wrote:
> On Tue, May 18, 2021 at 09:51:31AM +0200, Geert Uytterhoeven wrote:
> > Convert the Solomon SSD1307 Framebuffer Device Tree binding
> > documentation to json-schema.
> >
> > Fix the spelling of the &q
default y if SPARC64 && PCI
> help
What about letting FB_ATY select FB_ATY_CT if SPARC64 && PCI, and
dropping the "default y"-line, instead?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Lin
sed uninitialized" warnings thrown up by gcc-4.1, until
(a bit later than) support for that compiler was removed...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal con
> check this here.
>
> Signed-off-by: Uwe Kleine-König
Thanks for your patch!
Reviewed-by: Geert Uytterhoeven
Note that there are similar checks in snd_ps3_driver_probe(), which
can be removed, too:
if (WARN_ON(!firmware_has_feature(FW_FEATURE_PS3_LV1)))
return -E
ave
> accordingly.
>
> Signed-off-by: Uwe Kleine-König
Thanks for your patch!
Reviewed-by: Geert Uytterhoeven
Note that the same can be done for ps3_vuart_port_driver.remove().
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyon
b.ko] undefined!
>
> Fixes: f7018c213502 ("video: move fbdev to drivers/video/fbdev")
> Signed-off-by: Randy Dunlap
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@li
off-by: Laurent Pinchart
Thanks for your patch!
I think this warrants a Fixes tag, to assist the stable team in backporting
this fix.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conve
n in the _56_
fbdev drivers using acceleration (some of them unusable without),
despite commit 39aead8373b3 claiming "No other driver supportes
accelerated fbcon"...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
Hi Hamza,
On Fri, Jul 9, 2021 at 11:28 PM Hamza Mahfooz
wrote:
> On Fri, Jul 9 2021 at 09:49:02 AM +0200, Geert Uytterhoeven
> wrote:
> > Bummer, more code to revert to re-enable acceleration in the _56_
> > fbdev drivers using acceleration (some of them unusable without),
75,7 +273,7 @@ static int shmob_drm_probe(struct platform_device *pdev)
> return 0;
>
> err_irq_uninstall:
> - drm_irq_uninstall(ddev);
> + free_irq(platform_get_irq(pdev, 0), ddev);
Similar issue here.
> err_modeset_cleanup:
> drm_kms_helper_p
bit platforms
only, where long is 64-bit, so this cannot happen. But the issue will
start to happen when the driver is reused for a 32-bit SoC (e.g.
i.MX7ULP), or when code is copied for a new driver.
Signed-off-by: Geert Uytterhoeven
Reviewed-by: Fabio Estevam
Reviewed-by: Laurent Pinch
have
SoC-specific rules making it required.
Fixes: 99d66127fad25ebb ("dt-bindings: display: renesas,du: Convert binding to
YAML")
Signed-off-by: Geert Uytterhoeven
Reviewed-by: Laurent Pinchart
---
v2:
- Add Reviewed-by.
---
Documentation/devicetree/bindings/display/renesas,d
Convert the Solomon SSD1307 Framebuffer Device Tree binding
documentation to json-schema.
Fix the spelling of the "pwms" property.
Document default values.
Make properties with default values not required.
Signed-off-by: Geert Uytterhoeven
Reviewed-by: Rob Herring
---
v2:
- Add R
Make ssd1307fb_update_display() return an error code, so callers that
can handle failures can propagate it.
Signed-off-by: Geert Uytterhoeven
---
drivers/video/fbdev/ssd1307fb.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/video/fbdev
Extract the code to set the column and page ranges into a helper
function.
Signed-off-by: Geert Uytterhoeven
---
drivers/video/fbdev/ssd1307fb.c | 61 +++--
1 file changed, 36 insertions(+), 25 deletions(-)
diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers
initialization, as ssd1307fb_update_rect() now takes care of that.
Note that for now the optimized operation is only used for fillrect,
copyarea, and imageblit, which are used by fbcon.
Signed-off-by: Geert Uytterhoeven
---
drivers/video/fbdev/ssd1307fb.c | 43
your comments!
Geert Uytterhoeven (5):
video: fbdev: ssd1307fb: Propagate errors via
ssd1307fb_update_display()
video: fbdev: ssd1307fb: Simplify ssd1307fb_update_display()
video: fbdev: ssd1307fb: Extract ssd1307fb_set_address_range()
video: fbdev: ssd1307fb: Optimize screen updates
Cache the column and page ranges, to avoid doing unneeded I2C transfers
when the values haven't changed.
Signed-off-by: Geert Uytterhoeven
---
drivers/video/fbdev/ssd1307fb.c | 52 +++--
1 file changed, 36 insertions(+), 16 deletions(-)
diff --git a/drivers/
over and over again; a simple increment is
sufficient.
Signed-off-by: Geert Uytterhoeven
---
drivers/video/fbdev/ssd1307fb.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
index e6b
Hi Sam,
On Wed, Jul 14, 2021 at 5:27 PM Sam Ravnborg wrote:
> On Wed, Jul 14, 2021 at 04:57:59PM +0200, Geert Uytterhoeven wrote:
> > This patch series optimizes console operations on ssd1307fb, after the
> > customary fixes and cleanups.
>
> What is required to to have a
sdev->irq, shmob_drm_irq, 0, ddev->driver->name,
> + ddev);
> if (ret < 0) {
> dev_err(&pdev->dev, "failed to install IRQ handler\n");
> goto err_modeset_cleanup;
Gr{oetje,eeting}s,
. the real danger is the
strcat(msg, str);
on the next line.
Fortunately this whole debug printing block (including the strcpy)
can (and should) be rewritten to just use "%*ph".
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots o
;& DRM_SIMPLEDRM=n
> select FB_CFB_FILLRECT
> select FB_CFB_COPYAREA
> select FB_CFB_IMAGEBLIT
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical p
Hi Andreas,
On Sun, Nov 1, 2020 at 1:47 PM Andreas Schwab wrote:
> On Nov 01 2020, Sam Ravnborg wrote:
> > On Sun, Nov 01, 2020 at 11:29:41AM +0100, Geert Uytterhoeven wrote:
> >> The horizontal resolution (640) for the TT High video mode (1280x960) is
> >> definitel
macro ‘min’
2115 | size_t alloc_size = min(count, PAGE_SIZE);
| ^~~
Indeed, on 32-bit size_t is "unsigned int", not "unsigned long".
Fixes: 222ec45f4c69dfa8 ("drm/fb_helper: Support framebuffers in I/O memory")
Sig
ridge_init':
kmb_dsi.c:(.text+0xb14): undefined reference to `mipi_dsi_host_register'
Fix this be selecting DRM_MIPI_DSI, like other drivers do.
Fixes: ed794057b052b52a ("drm/kmb: Build files for KeemBay Display driver")
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu
are only
supported in arm64 kernel builds,
2. The dependencies on OF and COMMON_CLK can be dropped for
compile-testing, as the driver builds fine regardless.
Fixes: ed794057b052b52a ("drm/kmb: Build files for KeemBay Display driver")
Signed-off-by: Geert Uytterhoeven
---
d
Hi Daniel,
Replying "early" (see below), as this was applied to
drm-misc/for-linux-next.
On Sat, Oct 31, 2020 at 3:17 PM Daniel Vetter wrote:
> On Sat, Oct 31, 2020 at 11:28 AM Geert Uytterhoeven
> wrote:
> > On Thu, 29 Oct 2020, Daniel Vetter wrote:
> > > So eve
gt; + start_offset = clip->x1 % 8;
> + end_len = clip->x2 % 8;
> +
> + vaddr += clip_offset(clip, fb->pitches[0], cpp);
> + for (y = 0; y < lines; y++) {
> + src32 = memcpy(src32, vaddr, len_src32);
> + drm_fb_xrgb_to_gray8_line(gray8
s rendered correctly, but "L"
turns into "Γ" (Greek Gamma).
I suspect something went wrong with the display initialization
sequence.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In person
On Tue, Mar 8, 2022 at 10:16 PM Lad Prabhakar
wrote:
> The Renesas RZ/V2L SoC (a.k.a R9A07G054) has a Bifrost Mali-G31 GPU,
> add a compatible string for it.
>
> Signed-off-by: Lad Prabhakar
> Reviewed-by: Biju Das
Reviewed-by: Geert Uytterhoeven
Gr
rmat=a8r8g8b8,
> mode=640x480x32, linelength=2560
> 8<--- cut here ---
> Unable to handle kernel paging request at virtual address f0aac000
So support for images with offsets or widths that are not a multiple
of 8 got broken in cfb_imageblit(). Oops...
BTW, the various drawing routine
ored display on my Adafruit
FeatherWing 128x32 OLED.
Tested-by: Geert Uytterhoeven
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical
Hi Javier,
On Wed, Mar 9, 2022 at 1:14 PM Javier Martinez Canillas
wrote:
> On 3/8/22 17:30, Geert Uytterhoeven wrote:
> > Unfortunately a regression was introduced since your v3: printed
> > text is mirrored upside-down. I.e. "E" is rendered correctly, but "L&qu
Hi Javier,
On Wed, Mar 9, 2022 at 2:10 PM Javier Martinez Canillas
wrote:
> On 3/7/22 21:52, Geert Uytterhoeven wrote:
> > Add support for color-indexed frame buffer formats with two, four, and
> > sixteen colors to the DRM framebuffer helper functions:
> > 1. Add support
struct drm_rect *rect)
> +{
> + struct ssd130x_device *ssd130x = drm_to_ssd130x(fb->dev);
> + void *vmap = map->vaddr; /* TODO: Use mapping abstraction properly */
> + int ret = 0;
> + u8 *buf = NULL;
> +
> + buf = kcalloc(fb->width, fb->height, GFP
Hi Thomas,
On Thu, Mar 10, 2022 at 8:22 PM Thomas Zimmermann wrote:
> Am 09.03.22 um 11:39 schrieb Geert Uytterhoeven:
> > On Wed, Mar 9, 2022 at 10:22 AM Marek Szyprowski
> > wrote:
> >> On 09.03.2022 09:22, Thomas Zimmermann wrote:
> >>> Am 08.03.
Hi Ilia,
On Tue, Mar 8, 2022 at 8:57 AM Geert Uytterhoeven wrote:
> On Mon, Mar 7, 2022 at 10:23 PM Ilia Mirkin wrote:
> > On Mon, Mar 7, 2022 at 3:53 PM Geert Uytterhoeven
> > wrote:
> > > diff --git a/tests/util/pattern.c b/tests/util/pattern.c
> > > index 9
On Mon, Mar 7, 2022 at 9:53 PM Geert Uytterhoeven wrote:
> Introduce fourcc codes for color-indexed frame buffer formats with two,
> four, and sixteen colors, and provide a mapping from bit per pixel and
> depth to fourcc codes.
>
> As the number of bits per pixel is less than ei
1 - 100 of 1879 matches
Mail list logo
