here's over 100 places using DRIVER_MODESET we need to roll out
> this change without a flag day.
>
> v2: Update docs.
>
> Signed-off-by: Daniel Vetter
Reviewed-by: Frank Binns
> ---
> Documentation/gpu/drm-internals.rst | 9 ++---
> drivers/gpu/drm/i810/i810_drv.c
#x27;firstopen' callback says that it's called for legacy UMS drivers
but it does a check based on DRIVER_MODESET. There are also some
places in drm_pci.c that should be changed as well.
Anyway, this is progress so:
Reviewed-by: Frank Binns
> ---
> drivers/gpu/drm/drm_
o
> DRM_MINOR_PRIMARY (to match the actual struct-member name).
>
> Furthermore, this is in no way a legacy node, so lets not call it that.
>
> Signed-off-by: David Herrmann
Reviewed-by: Frank Binns
> ---
> drivers/gpu/drm/drm_drv.c | 14 +++---
> include/d
On 04/08/16 09:20, Daniel Vetter wrote:
> On Thu, Aug 04, 2016 at 08:37:49AM +0100, Frank Binns wrote:
>> On 03/08/16 20:11, Daniel Vetter wrote:
>>> Except for nouveau, only legacy drivers need this really. And nouveau
>>> is already marked up with DRIVER_KMS_LE
Reviewed-by: Frank Binns
Thierry Reding writes:
> From: Thierry Reding
>
> The array subscription operator ([]) has higher precedence than the
> indirection operator (*), so we need to use parentheses to properly
> instruct the compiler to dereference the pointer to an array fi
Hi Krzysztof,
On Tue, 2023-06-13 at 20:24 +0200, Krzysztof Kozlowski wrote:
> On 13/06/2023 16:47, Sarah Walker wrote:
> > Add the device tree binding documentation for the Series AXE GPU used in
> > TI AM62 SoCs.
> >
>
> I don't see improvements. That's a NAK :(
>
> This is a friendly reminder
Hi Andrew,
On Tue, 2023-06-13 at 13:12 -0500, Andrew Davis wrote:
> On 6/13/23 9:47 AM, Sarah Walker wrote:
> > Acquire clock, regulator and register resources, and enable/map as
> > appropriate.
> >
> > Signed-off-by: Sarah Walker
> > ---
> > drivers/gpu/drm/imagination/Makefile | 1 +
>
Hi Rob,
On Thu, 2023-06-15 at 14:50 -0600, Rob Herring wrote:
> On Tue, Jun 13, 2023 at 9:20 AM Sarah Walker wrote:
> > Add the device tree binding documentation for the Series AXE GPU used in
> > TI AM62 SoCs.
> >
> > Signed-off-by: Sarah Walker
> > ---
> > .../devicetree/bindings/gpu/img,pow
riesaxe";
> > +reg = <0x0fd0 0x2>;
> > +power-domains = <&some_pds 187>;
> > +clocks = <&k3_clks 187 0>;
> > +clock-names = "core";
> > +interrupts = ;
> > +interrupt-names = "gpu";
> > +};
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index b344e1318ac3..a41517843a10 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -10084,6 +10084,13 @@ IMGTEC IR DECODER DRIVER
> > S:Orphan
> > F:drivers/media/rc/img-ir/
> >
> > +IMGTEC POWERVR DRM DRIVER
> > +M: Frank Binns
> > +M: Sarah Walker
> > +M: Donald Robson
> > +S: Supported
> > +F: Documentation/devicetree/bindings/gpu/img,powervr.yaml
> > +
> > IMON SOUNDGRAPH USB IR RECEIVER
> > M:Sean Young
> > L:linux-me...@vger.kernel.org
Hi Adam,
On Sat, 2023-06-17 at 07:48 -0500, Adam Ford wrote:
> On Tue, Jun 13, 2023 at 10:20 AM Sarah Walker wrote:
> > Read the GPU ID register at probe time and select the correct
> > features/quirks/enhancements. Use the GPU ID to form the firmware
> > file name and load the firmware.
>
> I h
Hi Linus,
On Fri, 2023-06-16 at 14:10 +0200, Linus Walleij wrote:
> On Tue, Jun 13, 2023 at 5:20 PM Sarah Walker wrote:
>
> > From: Matt Coster
> >
> > Signed-off-by: Matt Coster
>
> Looks useful.
> Reviewed-by: Linus Walleij
Thank you for the review!
Frank
>
> Yours,
> Linus Walleij
Hi Linus,
On Fri, 2023-06-16 at 14:29 +0200, Linus Walleij wrote:
> Hi Sarah,
>
> thanks for starting this long awaited work!
>
> On Tue, Jun 13, 2023 at 5:20 PM Sarah Walker wrote:
>
> > This patch series adds the initial DRM driver for Imagination Technologies
> > PowerVR
> > GPUs, starting
Hi Nikolaus,
On Fri, 2023-06-16 at 16:06 +0200, H. Nikolaus Schaller wrote:
> Hi Linus,
> thanks for sharing this conversation with me.
>
> > Am 16.06.2023 um 14:29 schrieb Linus Walleij :
> >
> > Hi Sarah,
> >
> > thanks for starting this long awaited work!
> >
> > On Tue, Jun 13, 2023 at 5:2
Hi Michel,
Thank you for the feedback (comments below).
On Tue, 2023-08-08 at 15:46 +0200, Michel Dänzer wrote:
> On 7/14/23 16:25, Sarah Walker wrote:
> > +/**
> > + * DOC: PowerVR IOCTL CREATE_BO interface
> > + */
> > +
> > +/**
> > + * DOC: Flags for CREATE_BO
> > + *
> > + * The &struct drm_
Hi Linus,
On Fri, 2023-06-16 at 14:48 +0200, Linus Walleij wrote:
> Hi Sarah,
>
> thanks for your patch!
>
> On Tue, Jun 13, 2023 at 5:20 PM Sarah Walker wrote:
>
> > Add the device tree binding documentation for the Series AXE GPU used in
> > TI AM62 SoCs.
> >
> > Signed-off-by: Sarah Walker
On Mon, 2023-06-26 at 10:38 -0500, Adam Ford wrote:
> On Mon, Jun 26, 2023 at 8:22 AM Frank Binns wrote:
> > Hi Adam,
> >
> > On Sat, 2023-06-17 at 07:48 -0500, Adam Ford wrote:
> > > On Tue, Jun 13, 2023 at 10:20 AM Sarah Walker
> > > wrote:
> > &
Hi Maxime,
Thank you for your feedback (comments below).
On Fri, 2023-07-07 at 14:46 +0200, Maxime Ripard wrote:
> Hi,
>
> [I just noticed I dropped the Cc list, resending]
>
> Thanks for contributing this driver, it's awesome to see it moving
> forward.
>
> And congrats on the documentation t
Hi Maxime,
On Fri, 2023-07-07 at 14:47 +0200, Maxime Ripard wrote:
> On Tue, Jun 13, 2023 at 03:47:48PM +0100, Sarah Walker wrote:
> > Acquire clock, regulator and register resources, and enable/map as
> > appropriate.
> >
> > Signed-off-by: Sarah Walker
> > ---
> > drivers/gpu/drm/imagination/
Hi Maxime,
On Fri, 2023-07-07 at 14:48 +0200, Maxime Ripard wrote:
> On Tue, Jun 13, 2023 at 03:47:52PM +0100, Sarah Walker wrote:
> > @@ -503,21 +506,31 @@ pvr_device_init(struct pvr_device *pvr_dev)
> > if (err)
> > goto err_device_clk_fini;
> >
> > + /* Explicitly power
Hi Conor,
Thank you for your feedback (comments below).
On Sat, 2023-07-15 at 11:40 +0100, Conor Dooley wrote:
> Hey Sarah,
>
> Your series does not appear to be threaded. `git send-email` can be
> passed, for example, a directory containing a whole series & will set
> the correct in-reply-to he
Hi Krzysztof,
On Mon, 2023-07-17 at 09:29 +0200, Krzysztof Kozlowski wrote:
> On 14/07/2023 16:25, Sarah Walker wrote:
> > Add the device tree binding documentation for the Series AXE GPU used in
> > TI AM62 SoCs.
> >
>
> ...
>
> > +
> > + clocks:
> > +minItems: 1
> > +maxItems: 3
> >
Hi Krzysztof,
On Tue, 2023-07-18 at 13:10 +0200, Krzysztof Kozlowski wrote:
> On 18/07/2023 13:08, Frank Binns wrote:
> > > And this
> > > items:
> > > - const: gpu
> > > can just be
> > > const: gpu
> > >
> > > Although, if t
Hi Krzysztof,
On Tue, 2023-07-18 at 08:20 +0200, Krzysztof Kozlowski wrote:
> On 14/07/2023 16:25, Sarah Walker wrote:
> > Add the device tree binding documentation for the Series AXE GPU used in
> > TI AM62 SoCs.
> >
>
> ...
>
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +
Hi Krzysztof,
On Tue, 2023-07-18 at 08:19 +0200, Krzysztof Kozlowski wrote:
> On 14/07/2023 16:30, Sarah Walker wrote:
> > Add the Series AXE GPU node to the AM62 device tree.
> >
> > Signed-off-by: Sarah Walker
> > ---
> > arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 13 +
> > 1 file
On 29/11/16 09:45, Daniel Vetter wrote:
> Encoders&planes can't be hotplugged, we dont need looking for this
s/looking/locking/
With that changed:
Reviewed-by: Frank Binns
> since it's all single-threaded driver setup/teardown code. CRTCs
> already don't grab lock
Hi Philipp,
Comments below.
On 12/01/16 15:15, Philipp Zabel wrote:
> From: CK Hu
>
> Add an interface to allocate Mediatek GEM buffers, allow the IOCTLs
> to be used by render nodes.
> This patch also sets the RENDER driver feature.
>
> Signed-off-by: CK Hu
> Signed-off-by: Nicolas Boichat
>
Signed-off-by: Frank Binns
---
drivers/gpu/drm/drm_irq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c
index 8ca3d2b..149453c 100644
--- a/drivers/gpu/drm/drm_irq.c
+++ b/drivers/gpu/drm/drm_irq.c
@@ -532,7 +532,7
Stop claiming that UMS support is disabled when it's not actually
supported anymore.
Signed-off-by: Frank Binns
---
drivers/gpu/drm/i915/i915_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 3e
patches that have
been rebased are marked as v2.
[1] https://lwn.net/Articles/588016/
Frank Binns (4):
drm/vmwgfx: Stop checking minor type directly
drm: Rename DRM_MINOR_LEGACY to DRM_MINOR_PRIMARY
drm/amd/amdgpu: Set DRIVER_MODESET feature flag at build time
drm: Separate DRIVER_MODESE
Use the appropriate drm minor type helper instead.
Cc: Sinclair Yeh
Cc: Thomas Hellstrom
Signed-off-by: Frank Binns
---
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
b/drivers/gpu/drm/vmwgfx
This brings the minor type name into line with how the actual minor,
using this type, is referenced throughout the rest of drm.
Signed-off-by: Frank Binns
---
drivers/gpu/drm/drm_drv.c | 16
include/drm/drmP.h| 4 ++--
2 files changed, 10 insertions(+), 10 deletions
This flag was being set unconditionally at runtime so just set it at
compile time instead.
Signed-off-by: Frank Binns
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
b/drivers/gpu/drm/amd
From: Thierry Reding
The QXL driver sets DRIVER_MODESET unconditionally, so testing for the
absence of the feature will always fail.
Signed-off-by: Thierry Reding
---
drivers/gpu/drm/qxl/qxl_kms.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_kms.c b/drivers/gp
ive
of whether it is legacy or not.
Mark all legacy drivers appropriately.
Signed-off-by: Thierry Reding
v2:
- Rebase
- Add legacy flag to r128
- Don't add legacy flag to radeon
- Build fix for tdfx (use the correct field name)
- Add documentation to drm-internals
Signed-off-by: Frank Bi
- Move a core check
Signed-off-by: Frank Binns
---
drivers/gpu/drm/drm_bufs.c| 22 +++---
drivers/gpu/drm/drm_context.c | 24
drivers/gpu/drm/drm_dma.c | 4 ++--
drivers/gpu/drm/drm_fops.c| 10 ++
drivers/gpu/drm/drm_ioctl.c | 4
On 24/06/16 23:08, Alex Deucher wrote:
> On Fri, Jun 24, 2016 at 1:15 PM, Frank Binns
> wrote:
>> This flag was being set unconditionally at runtime so just set it at
>> compile time instead.
>>
>> Signed-off-by: Frank Binns
> Reviewed-by: Alex Deucher
>
&
On Wed, 2024-08-28 at 13:09 +, Matt Coster wrote:
> I missed this open-coded kref_get() while trying to debug a refcount
> bug, so let's use the helper function here to avoid that waste of time
> again in the future.
>
Reviewed-by: Frank Binns
> Signed-off-by:
On Wed, 2024-08-28 at 13:13 +, Matt Coster wrote:
> This caused a measurable memory leak. Although the individual
> allocations are small, the leaks occurs in a high-usage codepath
> (remapping or unmapping device memory) so they add up quickly.
>
Reviewed-by: Frank Binns
>
On Fri, 2024-08-30 at 15:06 +, Matt Coster wrote:
> I missed this open-coded kref_get() while trying to debug a refcount
> bug, so let's use the helper function here to avoid that waste of time
> again in the future.
>
Reviewed-by: Frank Binns
> Signed-off-by:
On Fri, 2024-08-30 at 15:07 +, Matt Coster wrote:
> This caused a measurable memory leak. Although the individual
> allocations are small, the leaks occurs in a high-usage codepath
> (remapping or unmapping device memory) so they add up quickly.
>
Reviewed-by: Frank Binns
>
On Sat, 2024-08-31 at 18:29 +0800, Jinjie Ruan wrote:
> Switching to memdup_user(), which combines kmalloc() and copy_from_user(),
> and it can simplfy code.
>
Reviewed-by: Frank Binns
> Signed-off-by: Jinjie Ruan
> ---
> drivers/gpu/drm/imagination/pvr_job.c | 13 +++--
On Mon, 2024-09-02 at 10:33 +0800, Jinjie Ruan wrote:
> Switching to memdup_user(), which combines kmalloc() and copy_from_user(),
> and it can simplfy code.
>
Reviewed-by: Frank Binns
> Signed-off-by: Jinjie Ruan
> Suggested-by: Christophe JAILLET
> ---
> v2:
, I have added it for now.
Thank you - it looks like something went wrong when the patch was sent.
>
> On Wed, Aug 16, 2023 at 10:26 AM Sarah Walker wrote:
>
> > Add the device tree binding documentation for the Series AXE GPU used in
> > TI AM62 SoCs.
> >
> >
Hi Paul,
On Wed, 2023-08-16 at 12:56 +0200, Paul Cercueil wrote:
> Hi Sarah,
>
> Le mercredi 16 août 2023 à 09:25 +0100, Sarah Walker a écrit :
> > Add power management to the driver, using runtime pm. The power off
> > sequence depends on firmware commands which are not implemented in
> > this
>
Hi Adam,
Sorry for not responding sooner. I've recently just returned from paternity
leave, so just catching up on everything.
On Thu, 2024-02-15 at 11:22 -0600, Adam Ford wrote:
> On Thu, Feb 15, 2024 at 11:10 AM Adam Ford wrote:
> > On Thu, Feb 15, 2024 at 10:54 AM Geert Uytterhoeven
> > wrot
On Tue, 2024-03-05 at 07:47 -0600, Adam Ford wrote:
> On Tue, Mar 5, 2024 at 5:58 AM Frank Binns wrote:
> > Hi Adam,
> >
> > Sorry for not responding sooner. I've recently just returned from paternity
> > leave, so just catching up on everything.
>
> Co
Hi Geert,
On Tue, 2024-02-27 at 12:04 +0100, Geert Uytterhoeven wrote:
> Hi Matt,
>
> On Tue, Feb 27, 2024 at 10:31 AM Matt Coster wrote:
> > Hi Adam,
> >
> > Thanks for these patches! I'll just reply to this one patch, but my
> > comments apply to them all.
> >
> > On 27/02/2024 03:45, Adam F
On Tue, 2024-02-27 at 05:50 -0600, Adam Ford wrote:
> On Tue, Feb 27, 2024 at 3:31 AM Matt Coster wrote:
> > Hi Adam,
> >
> > Thanks for these patches! I'll just reply to this one patch, but my
> > comments apply to them all.
> >
> > On 27/02/2024 03:45, Adam Ford wrote:
> > > The GPU on the RZ/
On Thu, 2024-03-07 at 12:26 +, Frank Binns wrote:
> On Tue, 2024-02-27 at 05:50 -0600, Adam Ford wrote:
> > On Tue, Feb 27, 2024 at 3:31 AM Matt Coster wrote:
> > > Hi Adam,
> > >
> > > Thanks for these patches! I'll just reply to this one patch
Hi Adam,
On Mon, 2024-02-26 at 21:45 -0600, Adam Ford wrote:
> Update the binding to add support for various Renesas SoC's with PowerVR
> Rogue GX6250 and GX6650 GPUs. These devices only need one clock, so update
> the table to indicate such like what was done for the ti,am62-gpu.
>
> Signed-off
On Thu, 2024-03-07 at 07:31 -0600, Adam Ford wrote:
> On Thu, Mar 7, 2024 at 6:37 AM Frank Binns wrote:
> > On Thu, 2024-03-07 at 12:26 +0000, Frank Binns wrote:
> > > On Tue, 2024-02-27 at 05:50 -0600, Adam Ford wrote:
> > > > On Tue, Feb 27, 2024 at 3:31
Hi,
Thank you for the patch.
On Mon, 2023-11-27 at 09:04 +0800, Yang Li wrote:
> ./drivers/gpu/drm/imagination/pvr_free_list.c:258:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7635
> Signed-off-by: Yang Li
Rev
Hi Colin,
Thank you for the patch.
On Fri, 2023-11-24 at 16:39 +, Colin Ian King wrote:
> There are a couple of spelling mistakes in literal strings in the
> stid_fmts array. Fix these.
>
> Signed-off-by: Colin Ian King
Reviewed-by: Frank Binns
> ---
> drivers/g
gt;
>
> base-commit: 46990918f35c1bf6e367cf8e0423e7344fec9fcb
For the series:
Tested-by: Frank Binns
I'll leave it to Donald to do the review.
Thanks
Frank
Hi,
Thank you for the patches.
On Thu, 2023-11-30 at 10:26 +0300, Dan Carpenter wrote:
> There is a cut and paste error so this code returns the wrong variable.
>
> Fixes: 1f88f017e649 ("drm/imagination: Get GPU resources")
> Signed-off-by: Dan Carpenter
Re
f-by: Dan Carpenter
Reviewed-by: Frank Binns
> ---
> drivers/gpu/drm/imagination/pvr_device.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/imagination/pvr_device.c
> b/drivers/gpu/drm/imagination/pvr_device.c
> index e1d
ssor and
> MMU support")
> Signed-off-by: Dan Carpenter
Reviewed-by: Frank Binns
> ---
> drivers/gpu/drm/imagination/pvr_vm_mips.c | 11 +--
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/imagination/pvr_vm_mips.c
> b/driver
This is the tree used by nearly all other DRM drivers, so use it for the
PowerVR driver as well.
Signed-off-by: Frank Binns
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 0ba904b46efe..d4b46b3db022 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
28012313.5934-1-ya...@kylinos.cn
> Closes:
> https://lore.kernel.org/dri-devel/20240228012313.5934-1-ya...@kylinos.cn
> Fixes: 927f3e0253c1 ("drm/imagination: Implement MIPS firmware processor and
> MMU support")
> Signed-off-by: Matt Coster
Reviewed-by: Frank Binns
> --
Signed-off-by: Frank Binns
---
include/linux/dma-fence.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h
index ca97422..efdabbb 100644
--- a/include/linux/dma-fence.h
+++ b/include/linux/dma-fence.h
@@ -128,7 +128,7
Reviewed-by: Frank Binns
Eric Engestrom writes:
> Signed-off-by: Eric Engestrom
> ---
> xf86drmMode.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/xf86drmMode.c b/xf86drmMode.c
> index e010547602c6f38ba5a0..6111f477ba0ee25c1f05 100644
Reviewed-by: Frank Binns
Eric Engestrom writes:
> Signed-off-by: Eric Engestrom
> ---
> xf86drmMode.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/xf86drmMode.c b/xf86drmMode.c
> index e010547602c6f38ba5a0..6111f477ba0ee25c1f05 100644
'IMG'. Can you change the title to:
Imagination Technologies PowerVR and IMG Rogue GPUs
With that changed and Javier's suggestions addressed:
Reviewed-by: Frank Binns
>
> maintainers:
>- Frank Binns
> diff --git a/MAINTAINERS b/MAINTAINERS
> index fa67e262472
rm/imagination: Add GEM and VM related code")
> Signed-off-by: Dan Carpenter
Reviewed-by: Frank Binns
> ---
> drivers/gpu/drm/imagination/pvr_mmu.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/imagination/pvr_mmu.c
> b/dr
Hi ChenYu,
On Fri, 2024-05-31 at 12:00 +0800, Chen-Yu Tsai wrote:
> On Thu, May 30, 2024 at 4:35 PM Chen-Yu Tsai wrote:
> > Hi everyone,
> >
> > This series enables the PowerVR GPU found in the MT8173 SoC, found in
> > some Chromebooks.
Thank you for the patches, I'm really happy to see these!
On Thu, 2024-05-30 at 18:16 +0800, Chen-Yu Tsai wrote:
> On Thu, May 30, 2024 at 5:59 PM AngeloGioacchino Del Regno
> wrote:
> > Il 30/05/24 10:35, Chen-Yu Tsai ha scritto:
> > > The MFG (GPU) block on the MT8173 has a small glue layer, named MFG_TOP
> > > in the datasheet, that contains clock gat
On Thu, 2024-05-30 at 16:35 +0800, Chen-Yu Tsai wrote:
> The MediaTek MT8173 comes with a PowerVR Rogue GX6250, which is part
> of the Series6XT, another variation of the Rogue family of GPUs.
>
> Signed-off-by: Chen-Yu Tsai
> ---
> drivers/gpu/drm/imagination/pvr_drv.c | 1 +
> 1 file changed,
Hi ChenYu,
On Thu, 2024-05-30 at 16:35 +0800, Chen-Yu Tsai wrote:
> The MediaTek MT8173 comes with a PowerVR Rogue GX6250, which is one
> of the Series6XT GPUs, another sub-family of the Rogue family.
I've added Adam Ford who sent out some DT related patches [1] for the Renesas
variant of GX6250
if a driver's probe
function returns 0. Make sure that an attempt to add the panic notifier is made
only when adding an element to kernel_fb_helper_list.
Signed-off-by: Frank Binns
---
drivers/gpu/drm/drm_fb_helper.c | 21 ++---
1 files changed, 10 insertions(+), 11 deletion
.binns=imgtec@lists.freedesktop.org
> [mailto:dri-devel-bounces+frank.binns=imgtec@lists.freedesktop.org] On
> Behalf Of Frank Binns
> Sent: 14 May 2012 16:28
> To: 'airl...@linux.ie'; 'dri-devel@lists.freedesktop.org'
> Subject: [PATCH] drm: fix case
if a driver's probe
function returns 0. Make sure that an attempt to add the panic notifier is made
only when adding an element to kernel_fb_helper_list.
Signed-off-by: Frank Binns
---
This should hopefully have none of the whitespace damage introduced by my email
client last time.
drive
Hi,
We are currently in negotiations with one of our customers (Mediatek) on a
strategy that will allow them to push a DRM modesetting driver into the
upstream kernel. We are writing to get people's opinions and feedback on our
proposed approach.
Currently, our driver is structured in such a w
On 01/12/14 15:28, Daniel Vetter wrote:
> On Mon, Dec 01, 2014 at 10:01:37AM +0000, Frank Binns wrote:
>> Hi,
>>
>> We are currently in negotiations with one of our customers (Mediatek) on
>> a strategy that will allow them to push a DRM modesetting driver into
>
if a driver's probe
function returns 0. Make sure that an attempt to add the panic notifier is made
only when adding an element to kernel_fb_helper_list.
Signed-off-by: Frank Binns
---
drivers/gpu/drm/drm_fb_helper.c | 21 ++---
1 files changed, 10 insertions(+), 11 deletion
s+frank.binns=imgtec.com at lists.freedesktop.org
> [mailto:dri-devel-bounces+frank.binns=imgtec.com at lists.freedesktop.org] On
> Behalf Of Frank Binns
> Sent: 14 May 2012 16:28
> To: 'airlied at linux.ie'; 'dri-devel at lists.freedesktop.org'
> Subject: [PATCH] drm:
if a driver's probe
function returns 0. Make sure that an attempt to add the panic notifier is made
only when adding an element to kernel_fb_helper_list.
Signed-off-by: Frank Binns
---
This should hopefully have none of the whitespace damage introduced by my email
client last time.
drive
Now that there are render nodes it doesn't seem appropriate for the type of
the card nodes to be DRM_NODE_RENDER. For this reason, rename this type to
DRM_NODE_PRIMARY as this name better represents the purpose of these nodes.
Signed-off-by: Frank Binns
---
tests/dristat.c | 2 +-
xf86
Add a new function, drmOpenRender, that can be used to open render nodes. This
can be used in the same way that drmOpenControl is used to open control nodes.
Signed-off-by: Frank Binns
---
xf86drm.c | 40 ++--
xf86drm.h | 2 ++
2 files changed, 40 insertions
Ping
On 14/01/15 14:07, Frank Binns wrote:
> Now that there are render nodes it doesn't seem appropriate for the type of
> the card nodes to be DRM_NODE_RENDER. For this reason, rename this type to
> DRM_NODE_PRIMARY as this name better represents the purpose of these nodes.
>
Is this not the issue fixed by 8e43c9c75?
Thanks
Frank
On 15/12/15 13:30, Gustavo Padovan wrote:
> 2015-12-14 Dmitry Torokhov :
>
>> Userspace can close the sync device while there are still active fence
>> points, in which case kernel produces the following warning:
>>
>> [ 43.853176]
On 02/02/15 10:06, Jammy Zhou wrote:
> v2: Add drmGetMinorBase, and call drmOpenWithType in drmOpen
> v3: Pass 'type' to drmOpenByBusid and drmOpenDevice in drmOpenByName
>
> Signed-off-by: Jammy Zhou
> ---
> xf86drm.c | 63
> ---
> xf8
Reviewed-by: Frank Binns
On 11/02/15 04:40, Jammy Zhou wrote:
> v2: Add drmGetMinorBase, and call drmOpenWithType in drmOpen
> v3: Pass 'type' to drmOpenByBusid and drmOpenDevice in drmOpenByName
> v4: Renumber node type definitions, and return -1 for unsupported type
>
Hi Emil,
On 02/02/15 00:14, Emil Velikov wrote:
> The add a simple helper which returns the node type of the opened fd.
> Likely to be used in conjunction with the previous two helpers.
>
> Cc: Daniel Vetter
> Cc: David Herrmann
> Signed-off-by: Emil Velikov
> ---
> xf86drm.c | 43
Add a helper function that returns the type of device node from an fd.
Signed-off-by: Frank Binns
---
xf86drm.c | 39 +++
xf86drm.h | 1 +
2 files changed, 40 insertions(+)
diff --git a/xf86drm.c b/xf86drm.c
index d85115c..e117bc6 100644
--- a/xf86drm.c
Hi Emil,
On 02/02/15 00:14, Emil Velikov wrote:
> Currently most places assume reliable primary <> render node mapping.
> Although this may work in some cases, it is not correct.
>
> Add a couple of helpers that hide the details and safes all the
> guesswork for the user.
>
> Cc: Daniel Vetter
>
Hi Emil,
On 13/02/15 09:18, Emil Velikov wrote:
> On 12/02/15 18:21, David Herrmann wrote:
>> Hi
>>
>> On Tue, Feb 10, 2015 at 11:37 PM, Emil Velikov
>> wrote:
>>> On 02/02/15 00:14, Emil Velikov wrote:
Hi all,
As mentioned a couple of days ago at #dri-devel some(most) users of
>>
Hi Emil,
On 13/02/15 16:38, Emil Velikov wrote:
> Hi Frank,
> On 13/02/15 10:51, Frank Binns wrote:
>> Add a helper function that returns the type of device node from an fd.
>>
>> Signed-off-by: Frank Binns
> Reviewed-by: Emil Velikov
>
> Thank you for getting r
device name, given an render/master FD.
>
> v2:
> - Rename Device and Primary to Master (aka the /dev/dri/cardX device).
> - Check for the file via readdir_r() rather than stat().
> - Wrap the check into a single function.
> - Return NULL for non-linux platforms.
>
> Cc:
from the list and destroyed
> when not in interrupt context.
>
Reviewed-by: Frank Binns
> Signed-off-by: Brendan King
> Signed-off-by: Matt Coster
> ---
> Changes in v1 -> v2:
> - Add justification to the commit message so it stands on its own (e.g.
>during
> To break the reference loop during cleanup, free the outstanding
> VM mappings before destroying the PVR Context associated with the
> VM context.
>
Reviewed-by: Frank Binns
> Signed-off-by: Brendan King
> Signed-off-by: Matt Coster
> ---
> Changes in v1 -> v2:
>
t; ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 18 --
> drivers/gpu/drm/etnaviv/etnaviv_sched.c| 20 +++
> drivers/gpu/drm/imagination/pvr_queue.c| 18 --
Imagination changes are:
Reviewed-by: Frank Binns
> drivers/gpu/drm/lima/lima_sched.c
91 matches
Mail list logo
