ved with mergeing similar part.
>
> Some comments are below.
>
> On 2012? 10? 29? 22:10, Eunchul Kim wrote:
>> FIMC is stand for Fully Interfactive Mobile Camera and
>> supports image scaler/rotator/crop/flip/csc and input/output DMA operations.
>> input DMA reads image da
driver for each hardware.
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu/drm/exynos/Kconfig |6 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c | 24 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |7 +
drivers/gpu
output operations.
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu/drm/exynos/Kconfig |6 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c | 15 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |1 +
drivers/gpu/drm
format, position, rotation, flip about
source/destination.
DRM_EXYNOS_IPP_QUEUE_BUF : enqueue/dequeue buffer and make event list.
DRM_EXYNOS_IPP_CMD_CTRL : play/stop/pause/resume control.
- event
DRM_EXYNOS_IPP_EVENT : event to give notification completion of buffer DMA with
buffer list
Eunchul Kim (4
and display output operations.
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu/drm/exynos/Kconfig |6 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c | 15 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |1
Rotator supports rotation/crop/flip and input/output DMA operations
Rotator ipp driver supports 90,180,270 degree rotaion and vertical, horizontal
flip.
and has some limitations(source and destination format have to be same, no
scaler)
Signed-off-by: Eunchul Kim
Signed-off-by: Youngjun Cho
format, position, rotation, flip about
source/destination.
DRM_EXYNOS_IPP_QUEUE_BUF : enqueue/dequeue buffer and make event list.
DRM_EXYNOS_IPP_CMD_CTRL : play/stop/pause/resume control.
- event
DRM_EXYNOS_IPP_EVENT : event to give notification completion of buffer DMA with
buffer list
Eunchul Kim (4
and display output operations.
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu/drm/exynos/Kconfig |6 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c | 15 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |1
Rotator supports rotation/crop/flip and input/output DMA operations
Rotator ipp driver supports 90,180,270 degree rotaion and vertical, horizontal
flip.
and has some limitations(source and destination format have to be same, no
scaler)
Signed-off-by: Eunchul Kim
Signed-off-by: Youngjun Cho
output operations.
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu/drm/exynos/Kconfig |6 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c | 15 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |1 +
drivers/gpu/drm
driver for each hardware.
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu/drm/exynos/Kconfig |6 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c | 24 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |7 +
drivers/gpu
Thank's comment
and I will modify description of Exynos5 series. and than I will send it.
On 10/26/2012 11:43 PM, Inki Dae wrote:
> 2012/10/18 Eunchul Kim :
>> Hi All.
>>
>> I am responsible for a display part from Samsung Electronics
>> Telecommunication Divisio
Thank's quick review
I have some question about your some comment's
please check my comment and send one more time.
On 10/27/2012 12:47 AM, Inki Dae wrote:
> below is quick review.
>
> 2012/10/18 Eunchul Kim :
>> IPP stand for Image Post Processing and supports image sca
/* For destination buffer dequeue to IPP */
for (i = 0; i < MAX_BUF; i++) {
ret = exynos_drm_ipp_queue_buf(fd, &qbuf2[i],
EXYNOS_DRM_OPS_DST,
IPP_BUF_DEQUEUE,
property.prop_id, i, gem2[i].handle);
driver for each hardware.
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu/drm/exynos/Kconfig |6 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c | 24 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |7 +
drivers/gpu
and display output operations.
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu/drm/exynos/Kconfig |6 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c | 15 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |1
Rotator supports rotation/crop/flip and input/output DMA operations
Rotator ipp driver supports 90,180,270 degree rotaion and vertical, horizontal
flip.
and has some limitations(source and destination format have to be same, no
scaler)
Signed-off-by: Eunchul Kim
Signed-off-by: Youngjun Cho
output operations.
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu/drm/exynos/Kconfig |6 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c | 15 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |1 +
drivers/gpu/drm
ake up queue. */
+ atomic_set(&ctx->wait_vsync_event, 0);
+ DRM_WAKEUP(&ctx->wait_vsync_queue);
+ }
I lost your PATCH mail. so, I send my comment using this body mail.
Thank's
BR
Eunchul Kim.
On 12/05/2012 04:27 PM, Inki Dae wrote:
2012/12/5 Inki Dae
This patch adds iommu support for ipp. For this, it
adds subdrv_probe/remove callback to enable or disable ipp iommu.
we can get or put device address to a gem handle from user
through exynos_drm_gem_get/put_dma_addr().
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu
fprintf(stderr, "failed to ipp buf dst dequeue\n");
}
/* For destination buffer dequeue to IPP */
for (i = 0; i < MAX_BUF; i++) {
ret = exynos_drm_ipp_queue_buf(fd, &qbuf2[i],
EXYNOS_DRM_OPS_DST,
IPP_BUF_DEQUEUE
Rotator supports rotation/crop/flip and input/output DMA operations
Rotator ipp driver supports 90,180,270 degree rotaion and vertical, horizontal
flip.
and has some limitations(source and destination format have to be same, no
scaler)
Signed-off-by: Eunchul Kim
Signed-off-by: Youngjun Cho
output operations.
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu/drm/exynos/Kconfig |5 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c | 15 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |1 +
drivers/gpu/drm
IPP */
for (i = 0; i < MAX_BUF; i++) {
ret = exynos_drm_ipp_queue_buf(fd, &qbuf2[i],
EXYNOS_DRM_OPS_DST,
IPP_BUF_DEQUEUE,
property.prop_id, i, gem2[i].handle);
if (ret < 0)
fprintf(std
This patch adds iommu support for ipp.
For this, it adds subdrv_probe/remove callback to enable or disable ipp iommu.
we can get or put device address to a gem handle from user
through exynos_drm_gem_get/put_dma_addr().
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu
Rotator supports rotation/crop/flip and input/output DMA operations
Rotator ipp driver supports 90,180,270 degree rotaion and vertical, horizontal
flip.
and has some limitations(source and destination format have to be same, no
scaler)
Signed-off-by: Eunchul Kim
Signed-off-by: Youngjun Cho
Thank's your comment.
I answer your comment. please check that.
Thank's
BR
Eunchul Kim
On 12/12/2012 05:29 PM, Inki Dae wrote:
-Original Message-----
From: Eunchul Kim [mailto:chulspro@samsung.com]
Sent: Wednesday, December 12, 2012 4:35 PM
To: dri-devel@lists.freed
Thank's your comment
BR
Eunchul Kim
On 12/12/2012 07:39 PM, Inki Dae wrote:
-Original Message-
From: Inki Dae [mailto:inki@samsung.com]
Sent: Wednesday, December 12, 2012 7:01 PM
To: 'Inki Dae'; 'Eunchul Kim'
Cc: jy0.j...@samsung.com; sw0312
Thank's for your comment.
BR
Eunchul Kim.
On 12/12/2012 06:46 PM, Inki Dae wrote:
One more comment.
-Original Message-
From: Eunchul Kim [mailto:chulspro@samsung.com]
Sent: Wednesday, December 12, 2012 6:26 PM
To: Inki Dae
Cc: dri-devel@lists.freedesktop.org;
e_buf(fd, &qbuf2[i],
EXYNOS_DRM_OPS_DST,
IPP_BUF_DEQUEUE,
property.prop_id, i, gem2[i].handle);
if (ret < 0)
fprintf(stderr, "failed to ipp buf dst dequeue\n");
}
/* Stop */
This patch adds iommu support for ipp.
For this, it adds subdrv_probe/remove callback to enable or disable ipp iommu.
we can get or put device address to a gem handle from user
through exynos_drm_gem_get/put_dma_addr().
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu
Rotator supports rotation/crop/flip and input/output DMA operations
Rotator ipp driver supports 90,180,270 degree rotaion and vertical, horizontal
flip.
and has some limitations(source and destination format have to be same, no
scaler)
Signed-off-by: Eunchul Kim
Signed-off-by: Youngjun Cho
This patch adds iommu support for ipp.
For this, it adds subdrv_probe/remove callback to enable or disable ipp iommu.
we can get or put device address to a gem handle from user
through exynos_drm_gem_get/put_dma_addr().
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu
IPP_BUF_DEQUEUE,
property.prop_id, i, gem2[i].handle);
if (ret < 0)
fprintf(stderr, "failed to ipp buf dst dequeue\n");
}
/* Stop */
ret = exynos_drm_ipp_cmd_ctrl(fd, &cmd_ctrl, property.prop_id,
IPP_CT
Rotator supports rotation/crop/flip and input/output DMA operations
Rotator ipp driver supports 90,180,270 degree rotaion and vertical, horizontal
flip.
and has some limitations(source and destination format have to be same, no
scaler)
Signed-off-by: Eunchul Kim
Signed-off-by: Youngjun Cho
be NULL. so, we
removed error handling about NULL.
* cleanup comment of abbreviation : we changed comments for right grammar.
* cleanup needless parenthesis : we missed changing of fimc side. so, I added
it.
* removed color bar pattern display : we don't use color display at writeback.
so
This patch changed current command name from cmd to c_node.
because we already use cmd for command control ioctl in another structure.
so, this name make some confusion.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c|8
drivers/gpu/drm/exynos
This patch removed property error handling. property couldn't be NULL.
so, I removed it.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 12
drivers/gpu/drm/exynos/exynos_drm_gsc.c | 12
drivers/gpu/drm/exynos/exynos_drm_ipp.c |
This patch fixed vflip, hflip at the same time. If we want to change 180 degree
about buffer,
then we can use h,vflip or 180 degree. we supports 180 degree using h,vflip.
but we make error handling in this case. so, fixed it.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos
This patch fixed warnning in GSC build.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_gsc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c
b/drivers/gpu/drm/exynos/exynos_drm_gsc.c
index ba5fefd..4546833
This patch cleanup comment of abbreviation.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c |2 +-
drivers/gpu/drm/exynos/exynos_drm_gsc.c |2 +-
drivers/gpu/drm/exynos/exynos_drm_ipp.c |2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a
From: JoongMock Shin
This patch removed color bar pattern register. we not use color bar
any more. and don't support color bar at writeback operation.
Signed-off-by: JoongMock Shin
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c |9 +++--
1 files chang
From: Jinyoung Jeon
This patch fixed unnormal interrupt at m2m operation sometimes.
m2m operation called s/w reset during every frame.
but m2m occured interrupt after s/w reset sometimes.
so, we cleared dma operation and capture operation.
Signed-off-by: Jinyoung Jeon
Signed-off-by: Eunchul
This patch cleanup needless parenthesis. we got the comment from GSC.
but we missed fimc side. so, we cleanup the code.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/exynos
Thank's for comment.
Oops, sorry that is my fault.
I will resend it.
BR
Eunchul Kim
On 12/20/2012 06:48 PM, Inki Dae wrote:
-Original Message-
From: Eunchul Kim [mailto:chulspro@samsung.com]
Sent: Thursday, December 20, 2012 6:32 PM
To: dri-devel@lists.freedesktop.org;
ent of abbreviation : we changed comments for right grammar.
* cleanup needless parenthesis : we missed changing of fimc side. so, I added
it.
* removed color bar pattern display : we don't use color display at writeback.
so, removed it.
Thank's
BR
Eunchul Kim
Eunchul Kim (6):
drm/exyn
This patch changed current command name from cmd to c_node.
because we already use cmd for command control ioctl in another structure.
so, this name make some confusion.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c|8
drivers/gpu/drm/exynos
This patch fixed warnning in GSC build.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_gsc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c
b/drivers/gpu/drm/exynos/exynos_drm_gsc.c
index 3e5b456..410175a
This patch cleanup comment of abbreviation.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c |2 +-
drivers/gpu/drm/exynos/exynos_drm_gsc.c |2 +-
drivers/gpu/drm/exynos/exynos_drm_ipp.c |2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a
This patch removed property error handling. property couldn't be NULL.
so, I removed it.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 12
drivers/gpu/drm/exynos/exynos_drm_gsc.c | 12
drivers/gpu/drm/exynos/exynos_drm_ipp.c |
From: JoongMock Shin
This patch removed color bar pattern register. we not use color bar
any more. and don't support color bar at writeback operation.
Signed-off-by: JoongMock Shin
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c |9 +++--
1 files chang
From: Jinyoung Jeon
This patch fixed unnormal interrupt at m2m operation sometimes.
m2m operation called s/w reset during every frame.
but m2m occured interrupt after s/w reset sometimes.
so, we cleared dma operation and capture operation.
Signed-off-by: Jinyoung Jeon
Signed-off-by: Eunchul
case. so, fixed it.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c|1 +
drivers/gpu/drm/exynos/exynos_drm_gsc.c |2 +-
drivers/gpu/drm/exynos/exynos_drm_rotator.c |1 +
include/uapi/drm/exynos_drm.h |2 ++
4 files changed, 5
This patch cleanup needless parenthesis. we got the comment from GSC.
but we missed fimc side. so, we cleanup the code.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/exynos
's
BR
Eunchul Kim
Eunchul Kim (1):
drm/exynos: added hdcp driver for contents protection.
drivers/gpu/drm/exynos/Kconfig |6 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c | 12 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |1 +
d
evice.
- compare Ri,Rj. If same and not repeater, then start encryption.
- If not same, retry. If repeater, then start second authentication.
- stop encryption.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/Kconfig |6 +
drivers/gpu/drm/exynos/Makefile |1 +
driver
Thank's for your advice.
Your opinion is very helpful to me.
I will consider your comments, and then I resend it.
Thank's
BR
Eunchul Kim
On 12/21/2012 08:53 PM, Alan Cox wrote:
On Fri, 21 Dec 2012 18:47:57 +0900
Eunchul Kim wrote:
HDCP stands for High-bandwidth Digital Content
This patch removes property error handling. because property couldn't be NULL.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 12
drivers/gpu/drm/exynos/exynos_drm_gsc.c | 12
drivers/gpu/drm/exynos/exynos_drm_ipp.c |5 ---
ULL. so,
we remove error handling about NULL.
* correct some comments to abbreviation : we change comments for right grammar.
* remove needless parenthesis : we misse changing of fimc side. so, I added it.
* remove color bar pattern operation : we don't use color display at
writeback. so,
This patch change current command name from cmd to c_node.
because we are using the member name, 'cmd', for command control ioctl in
another structure.
so, this patch changes it to c_node to avoid such confusing.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c
This patch considers both case of vflip and hflip.
If we want that the contents in buffer to be rotated to 180 degree,
then we can use h,vflip or 180 degree.
Changelog v2:
- added EXYNOS_DRM_FLIP_BOTH enum value to avoid build warnning.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos
This patch fixes erroneous register read.
reall function needs register base address + offset but
exynos_drm_gsc module used only offset to read a register.
so this patch uses gsc_read function instead of readl.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_gsc.c |2 +-
1
This patch cleanup corrects some comments to abbreviation.
We would like to prevent it stands misunderstood.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c |2 +-
drivers/gpu/drm/exynos/exynos_drm_gsc.c |2 +-
drivers/gpu/drm/exynos/exynos_drm_ipp.c |2
f-by: JoongMock Shin
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
index 8cfc5a9..a99ceef 100644
--- a/
incorrect interrupt.
Signed-off-by: Jinyoung Jeon
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
This patch removes needless parenthesis.
This was pointed out but in case of fimc side. we missed it.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
b
format, position, rotation, flip about
source/destination.
DRM_EXYNOS_IPP_QUEUE_BUF : enqueue/dequeue buffer and make event list.
DRM_EXYNOS_IPP_CMD_CTRL : play/stop/pause/resume control.
- event
DRM_EXYNOS_IPP_EVENT : event to give notification completion of buffer DMA with
buffer list
Eunchul Kim (4
output operations.
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu/drm/exynos/Kconfig |6 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c | 15 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |1 +
drivers/gpu/drm
Rotator supports rotation/crop/flip and input/output DMA operations
Rotator ipp driver supports 90,180,270 degree rotaion and vertical, horizontal
flip.
and has some limitations(source and destination format have to be same, no
scaler)
Signed-off-by: Eunchul Kim
Signed-off-by: Youngjun Cho
format, position, rotation, flip about
source/destination.
DRM_EXYNOS_IPP_QUEUE_BUF : enqueue/dequeue buffer and make event list.
DRM_EXYNOS_IPP_CMD_CTRL : play/stop/pause/resume control.
- event
DRM_EXYNOS_IPP_EVENT : event to give notification completion of buffer DMA with
buffer list
Eunchul Kim (4
Rotator supports rotation/crop/flip and input/output DMA operations
Rotator ipp driver supports 90,180,270 degree rotaion and vertical, horizontal
flip.
and has some limitations(source and destination format have to be same, no
scaler)
Signed-off-by: Eunchul Kim
Signed-off-by: Youngjun Cho
output operations.
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu/drm/exynos/Kconfig |6 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c | 15 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |1 +
drivers/gpu/drm
Thank's comment
and I will modify description of Exynos5 series. and than I will send it.
On 10/26/2012 11:43 PM, Inki Dae wrote:
2012/10/18 Eunchul Kim :
Hi All.
I am responsible for a display part from Samsung Electronics Telecommunication
Division.
and I am going to add post-proce
Thank's quick review
I have some question about your some comment's
please check my comment and send one more time.
On 10/27/2012 12:47 AM, Inki Dae wrote:
below is quick review.
2012/10/18 Eunchul Kim :
IPP stand for Image Post Processing and supports image scaler/rotator
/cro
t;);
}
/* For destination buffer dequeue to IPP */
for (i = 0; i < MAX_BUF; i++) {
ret = exynos_drm_ipp_queue_buf(fd, &qbuf2[i],
EXYNOS_DRM_OPS_DST,
IPP_BUF_DEQUEUE,
property.prop_id, i, gem2[i].ha
Rotator supports rotation/crop/flip and input/output DMA operations
Rotator ipp driver supports 90,180,270 degree rotaion and vertical, horizontal
flip.
and has some limitations(source and destination format have to be same, no
scaler)
Signed-off-by: Eunchul Kim
Signed-off-by: Youngjun Cho
output operations.
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu/drm/exynos/Kconfig |6 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c | 15 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |1 +
drivers/gpu/drm
Dear Sylwester Nawrocki
Thank you for your update. I have some question of your patch.
please give your information to me.
Thank's
BR
Eunchul Kim.
On 04/17/2013 06:53 PM, Sylwester Nawrocki wrote:
The clocks handling is refactored and a "mux" clock handling is
added to account
Dear Sylwester Nawrocki.
Sorry. I didn't check your third patch. I understand the "mux", "parent"
meaning. please ignore my comment of "mux", "parent"
and please check below comments.
Thank's
BR
Eunchul Kim.
On 04/17/2013 02:31
base them to be
> based on exynos-drm-next.
>
> Below is a little bit comments. Please, describe your codes as much as
> possible.
>
> Thanks,
> Inki Dae
>
>> -Original Message-
>> From: Eunchul Kim [mailto:chulspro.kim at samsung.com]
>> Sent: Monday
ake up queue. */
+ atomic_set(&ctx->wait_vsync_event, 0);
+ DRM_WAKEUP(&ctx->wait_vsync_queue);
+ }
I lost your PATCH mail. so, I send my comment using this body mail.
Thank's
BR
Eunchul Kim.
On 12/05/2012 04:27 PM, Inki Dae wrote:
> 2012/12/5 Inki
This patch adds iommu support for ipp. For this, it
adds subdrv_probe/remove callback to enable or disable ipp iommu.
we can get or put device address to a gem handle from user
through exynos_drm_gem_get/put_dma_addr().
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu
f dst dequeue\n");
}
/* For destination buffer dequeue to IPP */
for (i = 0; i < MAX_BUF; i++) {
ret = exynos_drm_ipp_queue_buf(fd, &qbuf2[i],
EXYNOS_DRM_OPS_DST,
IPP_BUF_DEQUEUE,
property.prop_id,
Rotator supports rotation/crop/flip and input/output DMA operations
Rotator ipp driver supports 90,180,270 degree rotaion and vertical, horizontal
flip.
and has some limitations(source and destination format have to be same, no
scaler)
Signed-off-by: Eunchul Kim
Signed-off-by: Youngjun Cho
and display output operations.
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu/drm/exynos/Kconfig |6 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c | 15 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |1
output operations.
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu/drm/exynos/Kconfig |5 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c | 15 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |1 +
drivers/gpu/drm
driver for each hardware.
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu/drm/exynos/Kconfig |6 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c | 24 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |7 +
drivers/gpu
Thank's your comments.
I answer your requestion. please check that.
Thank's
BR
Eunchul Kim
On 12/11/2012 01:37 PM, Inki Dae wrote:
>
>
>> -Original Message-----
>> From: Eunchul Kim [mailto:chulspro.kim at samsung.com]
>> Sent: Monday, December 10,
Thank's your comments.
I answer your comments. please check that.
Thank's
BR
Eunchul Kim
On 12/11/2012 02:16 PM, Inki Dae wrote:
>
>
>> -Original Message-----
>> From: Eunchul Kim [mailto:chulspro.kim at samsung.com]
>> Sent: Monday, December 10,
Thank's your comments
I answer your comments. please check that.
Thank's
BR
Eunchul Kim
On 12/11/2012 02:49 PM, Joonyoung Shim wrote:
> Hi,
>
> On 12/10/2012 10:45 PM, Eunchul Kim wrote:
>> GSC is stand for General SCaler and supports supports
>> image scaler/
Thank's for comments.
I answer your comment, please check that.
Thank's
BR
Eunchul Kim.
On 12/11/2012 04:17 PM, Inki Dae wrote:
>
>
>> -Original Message-----
>> From: Eunchul Kim [mailto:chulspro.kim at samsung.com]
>> Sent: Tuesday, December 11, 2012
OK, I know what you mean.
I talk about GSC feature with Inki.Dae.
I will re-send our final source instead of first commit.
please one more time review about next RFC v3.
Thank's
BR
Eunchul Kim
On 12/11/2012 05:31 PM, Joonyoung Shim wrote:
> Hi,
>
> I want to see only just curr
< MAX_BUF; i++) {
ret = exynos_drm_ipp_queue_buf(fd, &qbuf2[i],
EXYNOS_DRM_OPS_DST,
IPP_BUF_DEQUEUE,
property.prop_id, i, gem2[i].handle);
if (ret < 0)
fprintf(stderr, "failed
This patch adds iommu support for ipp.
For this, it adds subdrv_probe/remove callback to enable or disable ipp iommu.
we can get or put device address to a gem handle from user
through exynos_drm_gem_get/put_dma_addr().
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu
driver for each hardware.
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu/drm/exynos/Kconfig |6 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c | 24 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |7 +
drivers/gpu
Rotator supports rotation/crop/flip and input/output DMA operations
Rotator ipp driver supports 90,180,270 degree rotaion and vertical, horizontal
flip.
and has some limitations(source and destination format have to be same, no
scaler)
Signed-off-by: Eunchul Kim
Signed-off-by: Youngjun Cho
and display output operations.
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu/drm/exynos/Kconfig |6 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c | 15 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |1
output operations.
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu/drm/exynos/Kconfig |5 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c | 15 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |1 +
drivers/gpu/drm
Thank's your comment.
I anwer your comment, please check that.
Thank's
BR
Eunchul Kim.
On 12/12/2012 05:18 PM, Inki Dae wrote:
>
>
>> -Original Message-----
>> From: Eunchul Kim [mailto:chulspro.kim at samsung.com]
>> Sent: Wednesday, December 12
Thank's your comment.
I answer your comment. please check that.
Thank's
BR
Eunchul Kim
On 12/12/2012 05:29 PM, Inki Dae wrote:
>
>
>> -Original Message-----
>> From: Eunchul Kim [mailto:chulspro.kim at samsung.com]
>> Sent: Wednesday, December 12
1 - 100 of 149 matches
Mail list logo
