[PATCH] drm/vgem: fix use-after-free when drm_gem_handle_create() fails

2019-02-26 Thread Eric Biggers
From: Eric Biggers If drm_gem_handle_create() fails in vgem_gem_create(), then the drm_vgem_gem_object is freed twice: once when the reference is dropped by drm_gem_object_put_unlocked(), and again by __vgem_gem_destroy(). This was hit by syzkaller using fault injection. Fix it by skipping the

Re: [PATCH] drm/vgem: fix use-after-free when drm_gem_handle_create() fails

2019-02-26 Thread Eric Biggers
On Tue, Feb 26, 2019 at 09:01:29PM +, Chris Wilson wrote: > Quoting Eric Biggers (2019-02-26 20:47:26) > > From: Eric Biggers > > > > If drm_gem_handle_create() fails in vgem_gem_create(), then the > > drm_vgem_gem_object is freed twice: once when the

[PATCH v2] drm/vgem: fix use-after-free when drm_gem_handle_create() fails

2019-02-26 Thread Eric Biggers
From: Eric Biggers If drm_gem_handle_create() fails in vgem_gem_create(), then the drm_vgem_gem_object is freed twice: once when the reference is dropped by drm_gem_object_put_unlocked(), and again by __vgem_gem_destroy(). This was hit by syzkaller using fault injection. Fix it by skipping the

[PATCH] drm/vkms: fix use-after-free when drm_gem_handle_create() fails

2019-02-26 Thread Eric Biggers
From: Eric Biggers If drm_gem_handle_create() fails in vkms_gem_create(), then the vkms_gem_object is freed twice: once when the reference is dropped by drm_gem_object_put_unlocked(), and again by the extra calls to drm_gem_object_release() and kfree(). Fix it by skipping the second release and

Reminder: 1 open syzbot bug in drm subsystem

2019-07-01 Thread Eric Biggers
[This email was generated by a script. Let me know if you have any suggestions to make it better, or if you want it re-generated with the latest status.] Of the currently open syzbot reports against the upstream kernel, I've manually marked 1 of them as possibly being a bug in the drm subsystem.

Reminder: 1 open syzbot bug in drm subsystem

2019-07-23 Thread Eric Biggers
[This email was generated by a script. Let me know if you have any suggestions to make it better, or if you want it re-generated with the latest status.] Of the currently open syzbot reports against the upstream kernel, I've manually marked 1 of them as possibly being a bug in the drm subsystem.

Re: [PATCH AUTOSEL 5.19 07/16] drm/amdgpu: use dirty framebuffer helper

2022-10-19 Thread Eric Biggers
On Wed, Sep 21, 2022 at 11:53:23AM -0400, Sasha Levin wrote: > From: Hamza Mahfooz > > [ Upstream commit 66f99628eb24409cb8feb5061f78283c8b65f820 ] > > Currently, we aren't handling DRM_IOCTL_MODE_DIRTYFB. So, use > drm_atomic_helper_dirtyfb() as the dirty callback in the amdgpu_fb_funcs > struc

Re: [PATCH 7/8] arm64: dts: qcom: sm8450: remove invalid reg-names from ufs node

2023-03-23 Thread Eric Biggers
Hi Neil, On Thu, Mar 23, 2023 at 02:10:44PM +0100, Neil Armstrong wrote: > Hi, > > On 23/03/2023 11:49, Krzysztof Kozlowski wrote: > > On 23/03/2023 11:25, Neil Armstrong wrote: > > > Fixes the following DT bindings check error: > > > ufshc@1d84000: Unevaluated properties are not allowed ('reg-na

Re: [PATCH RFC PKS/PMEM 22/58] fs/f2fs: Utilize new kmap_thread()

2020-10-09 Thread Eric Biggers
On Fri, Oct 09, 2020 at 12:49:57PM -0700, ira.we...@intel.com wrote: > From: Ira Weiny > > The kmap() calls in this FS are localized to a single thread. To avoid > the over head of global PKRS updates use the new kmap_thread() call. > > Cc: Jaegeuk Kim > Cc: Chao Yu > Signed-off-by: Ira Weiny

Re: [PATCH RFC PKS/PMEM 22/58] fs/f2fs: Utilize new kmap_thread()

2020-10-09 Thread Eric Biggers
On Sat, Oct 10, 2020 at 01:39:54AM +0100, Matthew Wilcox wrote: > On Fri, Oct 09, 2020 at 02:34:34PM -0700, Eric Biggers wrote: > > On Fri, Oct 09, 2020 at 12:49:57PM -0700, ira.we...@intel.com wrote: > > > The kmap() calls in this FS are localized to a single thread. To avoid &

Re: [PATCH RFC PKS/PMEM 22/58] fs/f2fs: Utilize new kmap_thread()

2020-10-12 Thread Eric Biggers
On Sun, Oct 11, 2020 at 11:56:35PM -0700, Ira Weiny wrote: > > > > And I still don't really understand. After this patchset, there is still > > code > > nearly identical to the above (doing a temporary mapping just for a memcpy) > > that > > would still be using kmap_atomic(). > > I don't unde

Re: [PATCH 12/15] drm/amdgpu/display: add a late register connector callback

2020-04-07 Thread Eric Biggers
On Fri, Feb 07, 2020 at 02:50:55PM -0500, Alex Deucher wrote: > To handle debugfs setup on non DP MST connectors. > > Reviewed-by: Harry Wentland > Acked-by: Christian König > Signed-off-by: Alex Deucher > --- > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 18 ++ > 1 file c

Re: 6.10/bisected/regression - commits bc87d666c05 and 6d4279cb99ac cause appearing green flashing bar on top of screen on Radeon 6900XT and 120Hz

2024-07-22 Thread Eric Biggers
OTG_TRIGA_SOURCE_SELECT, 21, > OTG_TRIGA_SOURCE_PIPE_SELECT, optc->inst, > -- > 2.45.2 This patch fixes the bug for me too. I am using a Radeon RX 6400, and I've been encountering the bug when using 1920x1080 resolution on a monitor whose native resolution is 2560x1440. Feel free to add: Tested-by: Eric Biggers Thanks, - Eric

[PATCH] idr: remove WARN_ON_ONCE() when trying to replace negative ID

2017-09-06 Thread Eric Biggers
From: Eric Biggers IDR only supports non-negative IDs. There used to be a 'WARN_ON_ONCE(id < 0)' in idr_replace(), but it was intentionally removed by commit 2e1c9b286765 ("idr: remove WARN_ON_ONCE() on negative IDs"). Then it was added back by commit 0a835c4f090a (&

Re: [PATCH RESEND v2 07/19] fscrypt: Include in fs/crypto/keyring.c

2024-09-10 Thread Eric Biggers
On Mon, Sep 09, 2024 at 09:53:50AM +0200, Uros Bizjak wrote: > Include header to allow the removal of legacy > inclusion of from . > > Signed-off-by: Uros Bizjak > Cc: Eric Biggers > Cc: "Theodore Y. Ts'o" > Cc: Jaegeuk Kim > --- > v2: Include in

[Linux v4.3-rc6] i915: issues with Skylake integrated graphics

2015-10-22 Thread Eric Biggers
Hi, I am testing Linux v4.3-rc6 on a laptop with Intel 'Skylake' integrated graphics. The integrated display works, but I noticed several warnings in the kernel log, and a VGA monitor attached to the HDMI input via a VGA->HDMI adapter did not work. Furthermore, the system hung for several second

[Linux v4.3-rc6] i915: issues with Skylake integrated graphics

2015-10-26 Thread Eric Biggers
On Mon, Oct 26, 2015 at 03:28:37PM +0200, Jani Nikula wrote: > Please file two separate bugs at [1], one for the above, and another for > the below. Please add drm.debug=14 module parameter, and attach dmesg > all the way from boot to the problem. I have filed https://bugs.freedesktop.org/show_bug

Re: [linux-next:master] [fs] d91ea8195e: stress-ng.ring-pipe.ops_per_sec -5.1% regression (stress-ng.ring-pipe.pipe_read+write_calls_per_sec 7.3% improvement)

2024-10-15 Thread Eric Biggers
On Wed, Oct 16, 2024 at 10:19:25AM +0800, kernel test robot wrote: > kernel test robot noticed a -5.1% regression of > stress-ng.ring-pipe.ops_per_sec These emails that talk about negative regressions keep confusing me. A negative regression would be an improvement. But that is not actually wha

[PATCH] drm/bridge: it6505: Use SHA-1 library instead of crypto_shash

2025-08-01 Thread Eric Biggers
Instead of using the "sha1" crypto_shash, simply call the sha1() library function. This is simpler and faster. Signed-off-by: Eric Biggers --- Note: this patch depends on the SHA-1 library functions that were merged in v6.17-rc1. drivers/gpu/drm/bridge/Kconfig | 3 +-- drive