Re: [PATCH libdrm 5/5] android: silence ~550 warnings

2017-01-26 Thread Emil Velikov
On 22 January 2017 at 18:34, Emil Velikov wrote: > Analogous to the autoconf build add the following to the build > >-Wno-unused-parameter >-Wno-missing-field-initializers > > Cc: Chih-Wei Huang > Cc: Rob Herring > Signed-off-by: Emil Velikov > --- > Ac

Re: [PATCH libdrm] tests/util: Add support for meson module

2017-01-26 Thread Emil Velikov
On 26 January 2017 at 15:49, Thierry Reding wrote: > On Fri, Jan 20, 2017 at 06:28:39PM +0000, Emil Velikov wrote: >> On 20 January 2017 at 16:17, Thierry Reding wrote: >> > On Fri, Jan 20, 2017 at 02:13:00PM +, Emil Velikov wrote: >> >> On 19 January 2017 a

Re: [PATCH 2/4] drm: qxl: Drop duplicated device pointer attribute

2017-01-26 Thread Emil Velikov
On 27 January 2017 at 01:05, Gabriel Krisman Bertazi wrote: > qxl_device duplicates a pointer to struct device, which is not needed > since we already have it in the drm_device structure. Clean it up. > > Signed-off-by: Gabriel Krisman Bertazi > --- > drivers/gpu/drm/qxl/qxl_drv.h| 1 - >

Re: [PATCH 2/4] drm: qxl: Drop duplicated device pointer attribute

2017-01-26 Thread Emil Velikov
On 27 January 2017 at 01:23, Emil Velikov wrote: > On 27 January 2017 at 01:05, Gabriel Krisman Bertazi > wrote: >> qxl_device duplicates a pointer to struct device, which is not needed >> since we already have it in the drm_device structure. Clean it up. >> >>

Re: [PATCH libdrm] tests/util: Add support for meson module

2017-01-27 Thread Emil Velikov
On 27 January 2017 at 07:47, Thierry Reding wrote: > On Thu, Jan 26, 2017 at 04:14:56PM +0000, Emil Velikov wrote: >> On 26 January 2017 at 15:49, Thierry Reding wrote: >> > On Fri, Jan 20, 2017 at 06:28:39PM +, Emil Velikov wrote: >> >> On 20 January 2017 a

Re: [PATCH libdrm] tests: Use -pthread in CFLAGS instead of -lpthread

2017-01-27 Thread Emil Velikov
On 27 January 2017 at 07:21, Tomasz Figa wrote: > -lpthread is not always a valid flag to pull pthread support, especially > on Android it will fail to link due to a missing libpthread.so. The more > generic way to build-in pthread support is to use the -pthread CFLAG, so > let's use it instead. >

Re: [v3 PATCH 0/3] Allow ASYNC flip with atomic helpers.

2017-01-30 Thread Emil Velikov
Hi Andrey, Unrelated suggestion: A handy trick - to save yourself a bit of time (and "get it right") you can use `git format-patch -vX ...' [it also works with send-email] to have the version in the subject prefix. Feel free to share it with the team - it seems that many people manually edit the

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-01-31 Thread Emil Velikov
On 31 January 2017 at 21:17, Thierry Reding wrote: > On Tue, Jan 31, 2017 at 10:49:51AM -0500, Sean Paul wrote: >> On Tue, Jan 31, 2017 at 04:02:26PM +0100, Thierry Reding wrote: >> > On Tue, Jan 31, 2017 at 09:38:53AM -0500, Sean Paul wrote: >> > > On Tue, Jan 31, 2017 at 09:54:49AM +0100, Thierr

Re: [PATCH libdrm 2/3] tests/util: Make util_open() use drmDevice

2017-02-01 Thread Emil Velikov
unsigned int type) > +{ > + if (type >= DRM_NODE_MAX) > +return NULL; > + IMHO it's better to honour the ::available_nodes bitmask here, since we already check if we're within range. This the above the series is Reviewed-by: Emil Velikov -Emil ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH libdrm 0/3] some -pro patches for integration

2017-02-01 Thread Emil Velikov
u: Free/uninit vamgr_32 in theoretically correct order > amdgpu: vamgr can be a struct instead of a pointer > amdgpu: vamgr_32 can be a struct instead of a pointer > Nice cleanups/fixes indeed. Fwiw Reviewed-by: Emil Velikov Unless someone beats me to it I'll collect all the

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-02-01 Thread Emil Velikov
On 1 February 2017 at 14:52, Thierry Reding wrote: > On Tue, Jan 31, 2017 at 02:54:53PM -0800, Eric Anholt wrote: >> Thierry Reding writes: >> >> > [ Unknown signature status ] >> > On Tue, Jan 31, 2017 at 10:15:10AM -0800, Eric Anholt wrote: >> >> Thierry Reding writes: >> >> >> >> > [ Unknown

[PATCH libdrm] Remove unused tests/drmstat.c

2017-02-01 Thread Emil Velikov
From: Emil Velikov Earlier commit removed all the legacy 'tests' but a file was left danglig. Cc: Andreas Boll Reported-by: Andreas Boll Fixes: 0c80fddd1d0 "tests: remove useless legacy tests" Signed-off-by: Emil Velikov --- t

Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

2017-02-02 Thread Emil Velikov
On 1 February 2017 at 11:35, Daniel Vetter wrote: > On Wed, Feb 01, 2017 at 10:58:43AM +, Peter Senna Tschudin wrote: >> Hi Archit, >> >> On 01 February, 2017 10:44 CET, Archit Taneja wrote: >> >> > >> > >> > On 01/30/2017 10:35 PM, Jani Nikula wrote: >> > > On Sat, 28 Jan 2017, Peter Senna T

Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

2017-02-02 Thread Emil Velikov
On 2 February 2017 at 11:53, Peter Senna Tschudin wrote: > > On 02 February, 2017 02:46 CET, Emil Velikov wrote: > >> On 1 February 2017 at 11:35, Daniel Vetter wrote: >> > On Wed, Feb 01, 2017 at 10:58:43AM +, Peter Senna Tschudin wrote: >> >> Hi Archit,

Re: [PATCH libdrm 2/2] autogen.sh: run git commands in the (potentially) git dir

2017-02-03 Thread Emil Velikov
On 3 February 2017 at 18:21, Eric Engestrom wrote: > If the build dir is outside of the git dir, the order matters :) > > Signed-off-by: Eric Engestrom > --- Wondering if you've got hit by this or you noticed my identical patch on xorg-devel ;-) Either way, for both Reviewed

Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

2017-02-05 Thread Emil Velikov
On 3 February 2017 at 08:00, Daniel Vetter wrote: > On Thu, Feb 02, 2017 at 12:37:21PM +0000, Emil Velikov wrote: >> - Daniel, gents - is drm-misc aimed at devs with limited (no?) >> review/commit history in the area and/or the kernel in general ? >> In this case, Peter

Re: [PATCH 03/11] drm/msm: Add hint to DRM_IOCTL_MSM_GEM_INFO to return an object IOVA

2017-02-06 Thread Emil Velikov
Hi Jordan, On 6 February 2017 at 17:39, Jordan Crouse wrote: > Modify the 'pad' member of struct drm_msm_gem_info to 'hint'. If the > user sets 'hint' to non-zero it means that they want a IOVA for the > GEM object instead of a mmap() offset. Return the iova in the 'offset' > member. > > Signed-o

Re: [PATCH 03/11] drm/msm: Add hint to DRM_IOCTL_MSM_GEM_INFO to return an object IOVA

2017-02-06 Thread Emil Velikov
On 6 February 2017 at 19:57, Rob Clark wrote: > On Mon, Feb 6, 2017 at 2:20 PM, Emil Velikov wrote: >> Hi Jordan, >> >> On 6 February 2017 at 17:39, Jordan Crouse wrote: >>> Modify the 'pad' member of struct drm_msm_gem_info to 'hint'. If the &

Re: [Intel-gfx] [PATCH] drm/fb-helper: Automatically clean up fb_info

2017-02-07 Thread Emil Velikov
On 7 February 2017 at 14:29, Daniel Vetter wrote: > Noticed that everyone duplicates the same logic here and we could safe > a few lines per driver. Yay for lots of drivers to make such tiny > refactors worth-while! > > v2: Forgot to git add everything :( > Hmm afaict this patch inlines drm_fb_hel

Re: [Intel-gfx] [PATCH] drm/fb-helper: Automatically clean up fb_info

2017-02-07 Thread Emil Velikov
On 7 February 2017 at 14:49, Chris Wilson wrote: > On Tue, Feb 07, 2017 at 02:38:16PM +0000, Emil Velikov wrote: >> On 7 February 2017 at 14:29, Daniel Vetter wrote: >> > Noticed that everyone duplicates the same logic here and we could safe >> > a few lines per driv

Re: [PATCH 2/6] drm: Introduce drm_mode_object_{get,put}()

2017-02-09 Thread Emil Velikov
On 9 February 2017 at 20:41, Thierry Reding wrote: > On Thu, Feb 09, 2017 at 06:08:10PM +0100, Daniel Vetter wrote: >> On Wed, Feb 08, 2017 at 02:28:14PM -0500, Sean Paul wrote: >> > On Wed, Feb 08, 2017 at 07:24:04PM +0100, Thierry Reding wrote: >> > > From: Thierry Reding >> > > >> > > For cons

Re: [PATCH libdrm 0/4] libdrm: add new GPU sensor interface for AMDGPU

2017-02-13 Thread Emil Velikov
On 14 February 2017 at 00:08, Samuel Pitoiset wrote: > Hi, > > This series implements a new GPU sensor interface which will allow to > query the current temperature and the shader/memory clocks via the > GALLIUM_HUD. This adds the same functionality as the Radeon driver. > > The first patch of the

Re: [PATCH 0/8] ARM: sun8i: a33: Mali improvements

2017-02-16 Thread Emil Velikov
On 16 February 2017 at 12:43, Tobias Jakobi wrote: > Hello, > > I was wondering about the following. Wasn't there some strict > requirement about code going upstream, which also included that there > was a full open-source driver stack for it? > > I don't see how this is the case for Mali, neither

Re: [PATCH 2/2] drm/ast: Support AST2500

2017-02-16 Thread Emil Velikov
On 16 February 2017 at 09:09, Benjamin Herrenschmidt wrote: > From: "Y.C. Chen" > > Add detection and POST code for AST2500 generation chip, > code originally from Aspeed and slightly reworked for > coding style mostly by Ben. > > Signed-off-by: Y.C. Chen > Signed-off-by: Benjamin Herrenschmidt

Re: [PATCH 0/8] ARM: sun8i: a33: Mali improvements

2017-02-17 Thread Emil Velikov
On 17 February 2017 at 12:45, Tobias Jakobi wrote: > Hello Maxime, > > Maxime Ripard wrote: >> Hi, >> >> On Thu, Feb 16, 2017 at 01:43:06PM +0100, Tobias Jakobi wrote: >>> I was wondering about the following. Wasn't there some strict >>> requirement about code going upstream, which also included t

Re: [PATCH 0/8] ARM: sun8i: a33: Mali improvements

2017-02-17 Thread Emil Velikov
Hi Maxime, As I feared things have taken a turn for the bitter end :-] It seems that this is a heated topic, so I'l kindly ask that we try the following: - For people such as myself/Tobias/others who feel that driver and DT bindings should go hand in hand, prove them wrong. But please, do so by

Re: [PATCH 2/2] drm/ast: Support AST2500

2017-02-17 Thread Emil Velikov
Hi Ben, On 16 February 2017 at 21:09, Benjamin Herrenschmidt wrote: > On Thu, 2017-02-16 at 17:33 +0000, Emil Velikov wrote: >> On 16 February 2017 at 09:09, Benjamin Herrenschmidt >> wrote: >> > From: "Y.C. Chen" >> > >> > Add detection

Re: [PATCH 2/2] drm/ast: Support AST2500

2017-02-18 Thread Emil Velikov
On 17 February 2017 at 21:36, Benjamin Herrenschmidt wrote: > On Fri, 2017-02-17 at 21:27 +0000, Emil Velikov wrote: >> > Heh ok. I don't want to change that POST code too much as I'm not >> > equipped to test it, but I'll have a look later today. >> &g

Re: [PATCH 2/9] drm/ast: const'ify mode setting tables

2017-02-18 Thread Emil Velikov
On 17 February 2017 at 05:32, Benjamin Herrenschmidt wrote: > And fix some comment alignment & space/tabs while at it > > Signed-off-by: Benjamin Herrenschmidt Could have kept the white space changes separate, but that's me being pedantic :-] Either way: Reviewed-by: Em

Re: [PATCH 3/9] drm/ast: Remove spurrious include

2017-02-18 Thread Emil Velikov
On 17 February 2017 at 05:32, Benjamin Herrenschmidt wrote: > Signed-off-by: Benjamin Herrenschmidt Nice - this should shave a few bytes of off the module size. Reviewed-by: Emil Velikov -Emil ___ dri-devel mailing list dri-de

Re: [PATCH 4/9] drm/ast: Fix calculation of MCLK

2017-02-18 Thread Emil Velikov
it will eventually > to filter modes) so the issue isn't catastrophic. > > Also make the printed value a bit more meaningful > > Signed-off-by: Benjamin Herrenschmidt Reviewed-by: Emil Velikov -Emil ___ dri-devel mailing

Re: [PATCH 6/9] drm/ast: Factor mmc_test code in POST code

2017-02-18 Thread Emil Velikov
On 17 February 2017 at 05:32, Benjamin Herrenschmidt wrote: > There's a lot of duplication for what's essentially N copies of > the same loop, so factor it. The upcoming AST2500 POST code adds > more of this. > > Signed-off-by: Benjamin Herrenschmidt Here is where things go fun: Original code d

Re: [PATCH 2/2] drm/ast: Support AST2500

2017-02-18 Thread Emil Velikov
On 18 February 2017 at 03:41, Benjamin Herrenschmidt wrote: > On Fri, 2017-02-17 at 21:27 +0000, Emil Velikov wrote: >> Hi Ben, > > .../... > >> Not sure why you opted for splitting each suggestion in separate >> email, but it seems to have lead to a [serious] bugfi

Re: [PATCH 2/2] drm/ast: Support AST2500

2017-02-20 Thread Emil Velikov
On 18 February 2017 at 22:22, Benjamin Herrenschmidt wrote: > On Sat, 2017-02-18 at 15:43 +0000, Emil Velikov wrote: >> >> Out of curiosity - can you try testing with and w/o the ddr_test_2500 >> bug fix(?). >> Would be interesting to see if any of the omitted code [in

Re: [PATCH 4/8] drm/sun4i: add support for sun8i DE2 mixers and display engines

2017-02-23 Thread Emil Velikov
On 22 February 2017 at 15:18, Icenowy Zheng wrote: > Allwinner have a new "Display Engine 2.0" in there new SoCs, which comes > in a new "Display Engine" (mixers instead of old backends and > frontends). > > Add support for the mixer on Allwinner V3s SoC; it's the simplest one. > > Signed-off-by:

Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

2017-02-23 Thread Emil Velikov
On 23 February 2017 at 17:18, Joe Perches wrote: > On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote: >> On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches wrote: >> > There are ~4300 uses of pr_warn and ~250 uses of the older >> > pr_warning in the kernel source tree. >> > >> > Make the use of pr_w

Re: [PATCH 0/8] ARM: sun8i: a33: Mali improvements

2017-02-26 Thread Emil Velikov
Hi Maxime, Thanks for the links. On 24 February 2017 at 00:19, Maxime Ripard wrote: > Hi, > > On Fri, Feb 17, 2017 at 08:39:33PM +0000, Emil Velikov wrote: >> As I feared things have taken a turn for the bitter end :-] >> >> It seems that this is a heated topic, so

Re: ABI navigator for libdrm

2017-02-27 Thread Emil Velikov
On 27 February 2017 at 12:30, Rob Clark wrote: > On Mon, Feb 27, 2017 at 1:41 AM, Andrey Ponomarenko > wrote: >> 26.02.2017, 22:15, "Daniel Vetter": >>> On Sun, Feb 26, 2017 at 10:51 AM, Andrey Ponomarenko: Hello, I'd like to present the ABI Navigator project to search for binary

[PATCH] PCI: create revision file in sysfs

2016-11-01 Thread Emil Velikov
From: Emil Velikov Currently the revision isn't available via sysfs/libudev thus if one wants to know the value they need to read through the config file. This in itself wakes/powers up the device, causing unwanted delay since it can be quite costly. Expose the revision as a separate

[PATCH libdrm] xf86drm: Parse the separate files to retrieve the vendor/device info

2016-11-01 Thread Emil Velikov
From: Emil Velikov Parsing config sysfs file wakes up the device. The latter of which may be slow and isn't required to begin with. Reading through config is/was required since the revision is not available by other means, although with a kernel patch in the way we can 'cheat&#x

[PATCH libdrm] xf86drm: Parse the separate files to retrieve the vendor/device info

2016-11-02 Thread Emil Velikov
On 2 November 2016 at 11:14, Peter Wu wrote: > On Tue, Nov 01, 2016 at 06:13:34PM +0000, Emil Velikov wrote: >> sysfs file wakes up the device. The latter of which may >> be slow and isn't required to begin with. >> >> Reading through config is/was required since

[Spice-devel] [drm/qxl 5/6] qxl: Don't notify userspace when monitors config is unchanged

2016-11-03 Thread Emil Velikov
Hi guys, On 2 November 2016 at 16:31, Christophe Fergeau wrote: > Hey, > > On Mon, Oct 31, 2016 at 08:00:09AM -0400, Frediano Ziglio wrote: >> > diff --git a/drivers/gpu/drm/qxl/qxl_display.c >> > b/drivers/gpu/drm/qxl/qxl_display.c >> > index 156b7de..edb90f6 100644 >> > --- a/drivers/gpu/drm/qx

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-07 Thread Emil Velikov
On 7 November 2016 at 07:43, Sharma, Shashank wrote: > If I was not very clear for the first time, every time we send a patch to > drm-intel/dri-devel, we do basic testing on Gnome-desktop too (Not only > Android). > > So even these aspect ratio patches were tested with full gnome-desktop, and >

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-07 Thread Emil Velikov
On 7 November 2016 at 15:48, Sharma, Shashank wrote: > Regards > > Shashank > > > On 11/7/2016 8:56 PM, Emil Velikov wrote: >> >> On 7 November 2016 at 07:43, Sharma, Shashank >> wrote: >>> >>> If I was not very clear for the first time, eve

[PATCH libdrm] xf86drm: Parse the separate files to retrieve the vendor/device info

2016-11-08 Thread Emil Velikov
On 1 November 2016 at 18:47, Mauro Santos wrote: > On 01-11-2016 18:13, Emil Velikov wrote: >> From: Emil Velikov >> >> Parsing config sysfs file wakes up the device. The latter of which may >> be slow and isn't required to begin with. >> >> Read

[PATCH] PCI: create revision file in sysfs

2016-11-08 Thread Emil Velikov
[Dropping Jammy since his email bounces] On 1 November 2016 at 15:47, Alex Deucher wrote: > On Tue, Nov 1, 2016 at 11:42 AM, Emil Velikov > wrote: >> From: Emil Velikov >> >> Currently the revision isn't available via sysfs/libudev thus if one >> wants

[PATCH libdrm] xf86drm: Parse the separate files to retrieve the vendor/device info

2016-11-08 Thread Emil Velikov
On 8 November 2016 at 13:38, Mauro Santos wrote: > On 08-11-2016 11:06, Emil Velikov wrote: >> On 1 November 2016 at 18:47, Mauro Santos >> wrote: >>> On 01-11-2016 18:13, Emil Velikov wrote: >>>> From: Emil Velikov >>>> >>>> Parsin

[PATCH libdrm] xf86drm: Parse the separate files to retrieve the vendor/device info

2016-11-08 Thread Emil Velikov
On 8 November 2016 at 15:27, Mauro Santos wrote: > On 08-11-2016 15:00, Emil Velikov wrote: >> On 8 November 2016 at 13:38, Mauro Santos >> wrote: >>> On 08-11-2016 11:06, Emil Velikov wrote: >>>> On 1 November 2016 at 18:47, Mauro Santos >>>>

[Nouveau] [PATCH] drm/nouveau: fix LEDS_CLASS=m configuration

2016-11-08 Thread Emil Velikov
On 8 November 2016 at 16:21, Karol Herbst wrote: > 2016-11-08 17:12 GMT+01:00 Arnd Bergmann : >> On Tuesday, November 8, 2016 5:07:01 PM CET Lukas Wunner wrote: >>> On Tue, Nov 08, 2016 at 04:52:49PM +0100, Arnd Bergmann wrote: >>> > The underlying problem is that we already have a number of other

[PATCH libdrm] xf86drm: Parse the separate files to retrieve the vendor/device info

2016-11-08 Thread Emil Velikov
On 8 November 2016 at 16:57, Mauro Santos wrote: > On 08-11-2016 15:57, Emil Velikov wrote: >> On 8 November 2016 at 15:27, Mauro Santos >> wrote: >>> On 08-11-2016 15:00, Emil Velikov wrote: >>>> On 8 November 2016 at 13:38, Mauro Santos >>>>

[PATCH libdrm] xf86drm: Parse the separate files to retrieve the vendor/device info

2016-11-08 Thread Emil Velikov
On 8 November 2016 at 18:36, Mauro Santos wrote: > On 08-11-2016 18:08, Mauro Santos wrote: >> On 08-11-2016 17:13, Emil Velikov wrote: >>> On 8 November 2016 at 16:57, Mauro Santos >>> wrote: >>>> On 08-11-2016 15:57, Emil Velikov wrote: >>

[PATCH v2] PCI: create revision file in sysfs

2016-11-09 Thread Emil Velikov
From: Emil Velikov Currently the revision isn't available via sysfs/libudev thus if one wants to know the value they need to read through the config file. This in itself wakes/powers up the device, causing unwanted delays. There are at least two userspace components which could make us

[PATCH libdrm v2] xf86drm: Parse the separate files to retrieve the vendor, ... info

2016-11-09 Thread Emil Velikov
From: Emil Velikov Parsing config sysfs file wakes up the device. The latter of which may be slow and isn't required to begin with. Reading through config is/was required since the revision is not available by other means, although with a kernel patch in the way that is about to change.

[PATCH v2] PCI: create revision file in sysfs

2016-11-10 Thread Emil Velikov
On 10 November 2016 at 07:13, Greg KH wrote: > On Wed, Nov 09, 2016 at 04:56:07PM +0000, Emil Velikov wrote: >> From: Emil Velikov >> >> Currently the revision isn't available via sysfs/libudev thus if one >> wants to know the value they need to read through the c

[PATCH libdrm v2] xf86drm: Parse the separate files to retrieve the vendor, ... info

2016-11-10 Thread Emil Velikov
On 10 November 2016 at 12:40, Nicolai Hähnle wrote: > On 09.11.2016 19:08, Emil Velikov wrote: >> >> From: Emil Velikov >> >> Parsing config sysfs file wakes up the device. The latter of which may >> be slow and isn't required to begin with. >> >

[PATCH] headers: add i915-perf interface to i915_drm.h

2016-11-10 Thread Emil Velikov
Hi Robert Just a couple of trivial suggestions: - git config --local format.subjectPrefix "PATCH libdrm" - make sure that the headers are generated via `make headers_install' and state the tree/sha that you've used. See 9af2ccdef cc9a53f07 or 89cdda3d5. Thanks Emil P.S. /me goes to add a README

[PATCH libdrm] headers: Add README file

2016-11-10 Thread Emil Velikov
From: Emil Velikov Since we're trying to standardise and make things more consistent in the area, add a basic README which covers some of the more popular topics. Cc: Dave Airlie Cc: Daniel Vetter Signed-off-by: Emil Velikov --- Dave, did I get it right on the "why only drm files s

[PATCH libdrm] xf86drm: introduce drmGetDeviceNameFromFd2

2016-11-10 Thread Emil Velikov
From: Emil Velikov The original version considered only card devices, while this will pick the device/node name regardless - card, control, renderD, other... Current implementation is "linux" specific, in such that it relies on sysfs/uevent file. At the same time this gives us the f

[Intel-gfx] [PATCH] make intel_chipset.h public

2016-11-10 Thread Emil Velikov
On 28 October 2016 at 04:38, Gurchetan Singh wrote: > This file has useful information regarding the pci-id --> gen > conversion. The gen determines which scanout formats a chipset > supports (for example, the SKL display engine can scanout Y-tiled > formats). This would be useful for the ozone-

[PATCH v2] PCI: create revision file in sysfs

2016-11-11 Thread Emil Velikov
On 10 November 2016 at 23:59, Bjorn Helgaas wrote: > Hi Emil, > > On Thu, Nov 10, 2016 at 01:14:35PM +0000, Emil Velikov wrote: >> On 10 November 2016 at 07:13, Greg KH wrote: >> > On Wed, Nov 09, 2016 at 04:56:07PM +, Emil Velikov wrote: >> >> From: Emi

[PATCH libdrm] headers: Add README file

2016-11-11 Thread Emil Velikov
On 10 November 2016 at 21:07, Alex Deucher wrote: > On Thu, Nov 10, 2016 at 11:44 AM, Emil Velikov > wrote: >> From: Emil Velikov >> >> Since we're trying to standardise and make things more consistent in >> the area, add a basic README which covers some of t

[PATCH] Gpu: drm: arm: - Fix possible dereference of NULL

2016-11-11 Thread Emil Velikov
On 11 November 2016 at 10:56, Liviu Dudau wrote: > Hi Shailendra, > > On Fri, Nov 11, 2016 at 02:16:08PM +0530, Shailendra Verma wrote: >> From: "Shailendra Verma" >> >> There is possible dereference of NULL pointer if kmalloc fails. > > You could add: ... when the function returns. From the patc

[PATCH v3] PCI: create revision file in sysfs

2016-11-11 Thread Emil Velikov
From: Emil Velikov Currently the revision isn't available via sysfs/libudev thus if one wants to know the value they need to read through the config file. This in itself wakes/powers up the device, causing unwanted delay since it can be quite costly. There are at least two userspace compo

[PATCH v2] PCI: create revision file in sysfs

2016-11-11 Thread Emil Velikov
Hi Bjorn, On 11 November 2016 at 14:49, Bjorn Helgaas wrote: > On Fri, Nov 11, 2016 at 12:31:47AM +0000, Emil Velikov wrote: >> On 10 November 2016 at 23:59, Bjorn Helgaas wrote: >> > Hi Emil, >> > >> > On Thu, Nov 10, 2016 at 01:14:35PM +, Emil Velikov

[PATCH libdrm] xd86drm: read more than 128 bytes of uevent in drmParsePciBusInfo

2016-11-11 Thread Emil Velikov
From: Emil Velikov Some platforms (such as Macs using OF) can have more information in the uevent file thus reading only the first 128 might not be sufficient. Bump it to 512, which "should be enough for everybody" ;-) Cc: Mingcong Bai Bugzilla: https://bugs.freedesktop.org/show_

[PATCH libdrm] headers: Add README file

2016-11-11 Thread Emil Velikov
On 11 November 2016 at 18:33, Marek Olšák wrote: > On Fri, Nov 11, 2016 at 5:21 PM, Alex Deucher > wrote: >> On Fri, Nov 11, 2016 at 8:44 AM, Emil Velikov >> wrote: >>> On 10 November 2016 at 21:07, Alex Deucher wrote: >>>> On Thu, Nov 10, 2016

[PATCH libdrm v2] xf86drm: Parse the separate files to retrieve the vendor, ... info

2016-11-14 Thread Emil Velikov
On 14 November 2016 at 09:56, Michel Dänzer wrote: > On 10/11/16 10:38 PM, Emil Velikov wrote: >> On 10 November 2016 at 12:40, Nicolai Hähnle wrote: >>> On 09.11.2016 19:08, Emil Velikov wrote: >>>> >>>> From: Emil Velikov >>>> >>

[ANNOUNCE] libdrm 2.4.73

2016-11-14 Thread Emil Velikov
Emil Velikov (3): headers: Add README file xd86drm: read more than 128 bytes of uevent in drmParsePciBusInfo Bump version for release git tag: libdrm-2.4.73 https://dri.freedesktop.org/libdrm/libdrm-2.4.73.tar.bz2 MD5: bc1cee09cde72ffe3b952e8f50ccdaa8 libdrm-2.4.73.tar.bz2

[PATCH libdrm] automake: make the build less chatty

2016-11-15 Thread Emil Velikov
Having the "Entering|Leaving directory X" messages it not required nor useful in vast majority of the cases. One can always have them printed by `make -w' or by overriding the AM_MAKEFLAGS variable. Signed-off-by: Emil Velikov --- Makefile.am | 1 + 1 file changed, 1 insertion(+

[PATCH libdrm] xf86drm: introduce drmGetDeviceNameFromFd2

2016-11-22 Thread Emil Velikov
On 16 November 2016 at 11:14, Nicolai Hähnle wrote: > On 10.11.2016 18:43, Emil Velikov wrote: >> >> From: Emil Velikov >> >> The original version considered only card devices, while this will pick >> the device/node name regardless - card, control

[PATCH libdrm] libdrm: random typo fixes

2016-11-22 Thread Emil Velikov
On 21 November 2016 at 19:55, Alex Deucher wrote: > On Sun, Nov 20, 2016 at 1:25 PM, Grazvydas Ignotas > wrote: >> Just some trivial boring typo fixes all over the tree. >> READMEs and comments only. >> >> Signed-off-by: Grazvydas Ignotas > > Reviewed-by: Alex Deucher > Thanks gents. Just push

[PATCH libdrm v3 0/4] etna_pipe_wait_ns(..)

2016-11-23 Thread Emil Velikov
On 23 November 2016 at 07:26, Christian Gmeiner wrote: > Add an API to pass the timeout value (ns) from pipe->fence_finish(..) > to the kernel. The current API accepts ms and special handling is needed > for PIPE_TIMEOUT_INFINITE. > > The idea is not to break old mesa (out-of-tree) + new libdrm. I

[PATCH libdrm v3 0/4] etna_pipe_wait_ns(..)

2016-11-23 Thread Emil Velikov
On 23 November 2016 at 18:45, Rob Clark wrote: > On Wed, Nov 23, 2016 at 1:18 PM, Emil Velikov > wrote: >> On 23 November 2016 at 07:26, Christian Gmeiner >> wrote: >>> Add an API to pass the timeout value (ns) from pipe->fence_finish(..) >>> to the

[PATCH libdrm v4 0/2] etna_pipe_wait_ns(..)

2016-11-24 Thread Emil Velikov
tree) + new libdrm. > > Changes from v2 to v3: > - Builds at each step > - Keep the _ns postfix of get_abs_timeout_ns(..) > > Changes from v3 to v4: > - Rework the patches based on Emil's suggestion. > Fwiw v4 is Reviewed-by: Emil Velikov Thanks Emil

[PATCH libdrm 1/5] xf86drm: implement drmGetMinorNameForFD for non-sysfs

2016-11-29 Thread Emil Velikov
On 26 November 2016 at 00:40, Jonathan Gray wrote: > Implement drmGetMinorNameForFD for systems without sysfs by > adapting drm_get_device_name_for_fd() from the Mesa loader. > > Signed-off-by: Jonathan Gray > --- > xf86drm.c | 20 +++- > 1 file changed, 19 insertions(+), 1 delet

[PATCH libdrm 2/5] xf86drm: implement drmParseSubsystemType for OpenBSD

2016-11-29 Thread Emil Velikov
On 26 November 2016 at 00:40, Jonathan Gray wrote: > Implement drmParseSubsystemType for OpenBSD by always returning > DRM_BUS_PCI. No non-pci drm drivers are in the kernel and this is > unlikely to change anytime soon as the existing ones aren't permissively > licensed. > A few noticeable X11 MI

[PATCH libdrm 3/5] xf86drm: implement drmParsePciDeviceInfo for OpenBSD

2016-11-29 Thread Emil Velikov
On 26 November 2016 at 00:40, Jonathan Gray wrote: > Implement drmParsePciDeviceInfo for OpenBSD by using the new > DRM_IOCTL_GET_PCIINFO ioctl. > > Signed-off-by: Jonathan Gray > --- > xf86drm.c | 51 +++ > 1 file changed, 51 insertions(+) > > dif

[PATCH libdrm 5/5] xf86drm: implement an OpenBSD specific drmGetDevice

2016-11-29 Thread Emil Velikov
On 26 November 2016 at 00:40, Jonathan Gray wrote: > This avoids walking all of /dev and directly maps the fd to a path to a > primary node. > I realise that the code is pretty ugly/bad/etc, but I would stay way from similar optimisations. As-is it will just work as you guys get support for render

Re: [PATCH] drm: hibmc: Use set_busid function from drm core

2017-06-13 Thread Emil Velikov
Hi Daniel, On 9 June 2017 at 07:57, Daniel Axtens wrote: > Currently, calling drmGetBusid from libdrm on a hibmc VGA > card returns a string like "0007:a1:00.0". > > The busid reported by most cards begins with "pci:". For > example, on an amd64 system, a VGA card reported > "pci::00:02.0". >

Re: [PATCH libdrm v8] amdgpu: move asic id table to a separate file

2017-06-14 Thread Emil Velikov
u.ids > * Set libdrmdatadir variable in configure.ac instead of Makefile.am > [Emil Velikov] > * Use isblank() instead of open-coding it [Emil Velikov] > * Don't leak asic_id_table memory if realloc fails [Emil Velikov] > * Check and bump table_max_size at the begin

Re: [PATCH libdrm v8] amdgpu: move asic id table to a separate file

2017-06-15 Thread Emil Velikov
On 15 June 2017 at 04:16, Michel Dänzer wrote: > On 14/06/17 08:34 PM, Emil Velikov wrote: >> On 13 June 2017 at 10:45, Michel Dänzer wrote: >>> From: Xiaojie Yuan >>> >>> v2: fix an off by one error and leading white spaces >>> v3: use thread s

Re: R7-250X: Vulkan: Doom lockups.

2017-06-15 Thread Emil Velikov
Hi Mike, On 16 June 2017 at 05:48, Mike Mestnik wrote: > I can tell by the 2 color(green and violet) rendering that this driver > is experimental. Attached is kern.log from some testing I've done. > You might be interested in the following bug report. It's the first hit on google under "radv doo

Re: [PATCH 1/2] drm/exynos/decon: Add include guard to the Exynos7 header

2017-06-20 Thread Emil Velikov
On 19 June 2017 at 17:31, Krzysztof Kozlowski wrote: > Although header is included only once but still having an include guard > is a good practice. To avoid confusion, add SoC prefix to existing > Exynos5433 header include guard. > > Signed-off-by: Krzysztof Kozlowski > --- > include/video/exy

Re: [PATCH 1/2] drm/exynos/decon: Add include guard to the Exynos7 header

2017-06-20 Thread Emil Velikov
On 20 June 2017 at 11:02, Krzysztof Kozlowski wrote: > On Tue, Jun 20, 2017 at 11:53 AM, Emil Velikov > wrote: >> On 19 June 2017 at 17:31, Krzysztof Kozlowski wrote: >>> Although header is included only once but still having an include guard >>> is a good prac

Re: [PATCH 3/4] drm/i915: Add format modifiers for Intel

2017-06-26 Thread Emil Velikov
ntel_primary_plane_format_mod_supported(struct drm_plane *plane, > +uint32_t format, > + uint64_t modifier) > +{ > + struct drm_i915_private *dev_priv = to_i915(plane->

Re: [PATCH 0/8] Cleanup CRTC .enable()/.disable() cargo-cult

2017-06-28 Thread Emil Velikov
Hi Laurent, On 27 June 2017 at 21:38, Laurent Pinchart wrote: > Hello, > > The atomic helpers favour the .enable() and .atomic_disable() CRTC helper > operations, but still support the legacy .prepare(), .commit(), .disable() and > .dpms() operations. Some drivers have been updated, but most stil

Re: [PATCH 0/8] Cleanup CRTC .enable()/.disable() cargo-cult

2017-06-29 Thread Emil Velikov
On 28 June 2017 at 14:10, Laurent Pinchart wrote: > Hi Emil, > > On Wednesday 28 Jun 2017 12:27:06 Emil Velikov wrote: >> On 27 June 2017 at 21:38, Laurent Pinchart wrote: >> > Hello, >> > >> > The atomic helpers favour the .enable() and .atomic_disabl

Re: [PATCH 01/14] drm/bridge: change return type of drm_bridge_add function

2017-07-03 Thread Emil Velikov
Hi Inki, On 3 July 2017 at 09:42, Inki Dae wrote: > This patch changes return type of drm_bridge_add function. > > This function never return negative value but returns only 0. > So it changes the return type of this function to void one. > This patch should be the final in the series. Otherwise

Re: [PATCH libdrm] amdgpu: move asic id table to a separate file

2017-07-05 Thread Emil Velikov
Dänzer] >> * Move amdgpu.ids to new data directory >> * Remove placeholder entries from amdgpu.ids >> * Set libdrmdatadir variable in configure.ac instead of Makefile.am >> [Emil Velikov] >> * Use isblank() instead of open-coding it [Emil Velikov] >> * Don't leak asi

Re: [PATCH libdrm 1/2] util: move some files to an ASIC neutral directory.

2017-07-05 Thread Emil Velikov
On 30 June 2017 at 20:24, Samuel Li wrote: Commit message should explain why we want this - aka "Will be reused in radeon with a later commit" > Change-Id: Iac1c4870253e8b8860a61b7cf175e7a25cc95921 > Signed-off-by: Samuel Li > --- > Makefile.sources | 10 +- > amdgpu/Makefile.am

Re: [PATCH libdrm 2/2] radeon: use asic id table to get chipset name

2017-07-05 Thread Emil Velikov
Hi Samuel, On 30 June 2017 at 20:25, Samuel Li wrote: > Change-Id: I24b6624789d1a9dc0fd3a446b0e6f21ed5183ff2 > Signed-off-by: Samuel Li > --- > radeon/Makefile.am | 6 +++ > radeon/Makefile.sources | 6 ++- > radeon/radeon_asic_id.c | 106 >

Re: [PATCH libdrm] amdgpu: move asic id table to a separate file

2017-07-05 Thread Emil Velikov
On 5 July 2017 at 11:44, Chih-Wei Huang wrote: > 2017-07-05 17:35 GMT+08:00 Emil Velikov : >> On 4 July 2017 at 07:40, Chih-Wei Huang wrote: >>> >>> Unfortunately this patch breaks Android build >>> since the two macros are not defined. >>> >>&g

Re: [PATCH 12/14] drm/exynos: mic: clean up drm_bridge_add call

2017-07-05 Thread Emil Velikov
On 5 July 2017 at 10:14, Archit Taneja wrote: > > > On 07/05/2017 02:35 PM, Inki Dae wrote: >> >> >> >> 2017년 07월 05일 18:00에 Archit Taneja 이(가) 쓴 글: >>> >>> >>> >>> On 07/03/2017 02:12 PM, Inki Dae wrote: This patch removes unnecessary checking of return value. Ps. this patch d

Re: [PATCH libdrm 2/2] radeon: use asic id table to get chipset name

2017-07-06 Thread Emil Velikov
On 5 July 2017 at 22:31, Li, Samuel wrote: >> - above all, as-is make check will fail > Right, I did not check that. > >> - keeping the radeon API symmetrical to the amdgpu one would a good idea > The issue is Radeon does not have a struct similar to amdgpu_device_handle. Attach it to analogous

Re: DRM_STM breaks fbdev mmap on ARCH_MULTIPLATFORM

2017-07-10 Thread Emil Velikov
On 10 July 2017 at 12:49, Benjamin Gaignard wrote: > 2017-07-10 12:53 GMT+02:00 Noralf Trønnes : >> Hi >> >> DRM_STM is 'default y' on ARCH_MULTIPLATFORM and it selects >> FB_PROVIDE_GET_FB_UNMAPPED_AREA. This breaks fbdev mmap for me on >> Raspberry Pi. mmap returns -ENOMEM. >> >> Disabling DRM_S

Re: [PATCH] drm: stm: remove "default y" in Kconfig

2017-07-10 Thread Emil Velikov
On 10 July 2017 at 16:07, Benjamin Gaignard wrote: > To do not force stm driver to be build by default > > Signed-off-by: Benjamin Gaignard Yes, please. You might want to double-check the default board config has it set. Reviewed-by: Emil Velikov Th

Re: [PATCH libdrm 2/2] radeon: use asic id table to get chipset name

2017-07-11 Thread Emil Velikov
On 6 July 2017 at 13:46, Deucher, Alexander wrote: >> Attach it to analogous primitive? > > Radeon libdrm is much different than amdgpu. There is no analog. > Upon a closer look, indeed there isn't. Must have gotten confused earlier. >> >> > I think the current radeon API is simpler. Maybe a fo

Re: [RFC PATCH 06/12] staging: android: ion: Remove crufty cache support

2017-03-06 Thread Emil Velikov
On 6 March 2017 at 10:29, Daniel Vetter wrote: > On Fri, Mar 03, 2017 at 10:46:03AM -0800, Laura Abbott wrote: >> On 03/03/2017 08:39 AM, Laurent Pinchart wrote: >> > Hi Daniel, >> > >> > On Friday 03 Mar 2017 10:56:54 Daniel Vetter wrote: >> >> On Thu, Mar 02, 2017 at 01:44:38PM -0800, Laura Abbo

Re: [PATCH v6 4/4] drm/rockchip: Implement CRC debugfs API

2017-03-06 Thread Emil Velikov
Hi Tomeu, Pardon for dropping in late. On 3 March 2017 at 13:39, Tomeu Vizoso wrote: > Implement the .set_crc_source() callback and call the DP helpers > accordingly to start and stop CRC capture. > > This is only done if this CRTC is currently using the eDP connector. > > v3: Remove superfluous

Re: [PATCH 3/3] drm/msm: Fix compilation error when CONFIG_DEBUG_FS undefined

2017-03-06 Thread Emil Velikov
On 6 March 2017 at 20:27, Sean Paul wrote: > Fixes the following compilation error when CONFIG_DEBUG_FS undefined: > > CC [M] drivers/gpu/drm/msm/adreno/a5xx_gpu.o > ../drivers/gpu/drm/msm/adreno/a5xx_gpu.c:863:3: error: unknown field ‘show’ > specified in initializer > ../drivers/gpu/drm/msm/ad

<    1   2   3   4   5   6   7   8   9   10   >