Dave Airlie writes:
> On Thu, 16 Jul 2020 at 00:59, Thomas Zimmermann wrote:
> >
> > This patchset puts device initialization in the correct order and
> > adds support for G200 Desktop chips (PCI ids 0x520 and 0x521).
>
> why? :-)
>
> I'm pretty sure I NAKed the previous version because
> {
> struct ast_private *ast = dev->dev_private;
> uint32_t data, jreg;
> +ast_open_key(ast);
>
> if (dev->pdev->device == PCI_CHIP_AST1180) {
> ast->chip = AST1100;
> --
> 1.8.3.1
>
Reviewed-by: Egbert Eich
}
> ast->vga2_clone = false;
> } else {
> -ast->chip = 2000;
> +ast->chip = AST2000;
> DRM_INFO("AST 2000 detected\n");
> }
> }
> --
> 1.8.3.1
>
Reviewed-by: Egbert Eich
Takashi Iwai writes:
> On Thu, 20 Jul 2017 06:17:58 +0200,
> Dave Airlie wrote:
> >
> > On 19 July 2017 at 00:43, Takashi Iwai wrote:
> > > From: Egbert Eich
> > >
> > > Add two more models G200_PCI and G200 for PCI device IDs 0x520 and
>
Sean Paul writes:
> On Tue, Nov 20, 2012 at 4:30 AM, Egbert Eich wrote:
> > drm_get_edid() returns a pointer to an EDID block. The caller
> > is responsible to free this pointer itself.
> > Here the pointer gets assigned to the local variable raw_edid.
> > Therefor
The patches have been reordered and the changes suggested by
Takashi Iwai have been worked in.
Egbert Eich (18):
1. Make error handling of EDID extension blocks a bit more fault
tolorant:
* Don't fail when EDID extension blocks cannot be read or memory
cannot be allocated.
*
When we fail to allocate space for EDID extensions we should just
warn, fix up the EDID block count and return the base block instead
of failing.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu
address is not taken into account, this block will
be identical to the base block in which case we stop reading further
EEDID blocks, correct the extension flag and just return the base
block.
v2: Split up EDID fixup code into separate commit.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c
is less time consuming. For v1.3 we scrap any exsisting map
blocks and recreate them from scratch.
v2: Fixed conflits due to reordering of commits.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c | 89
1 files changed, 89 insertions(+), 0
EDID extension blogs are only expected for EDIDs version 1.3 or higher.
If an EDID with a lower version is found fix the block count in the
extension flags and return the base block.
This should help to avoid issues with older displays with broken
DDC implementations.
Signed-off-by: Egbert Eich
the same
block.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index da2f7fa..0fe61fb 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/
monitor is changed
but still prevents permanent EDID errors from piling up
the the kernel logs.
v2: Fixed conflits due to reordering of commits.
Set error state where missing.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c | 115 +---
drivers/gpu
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/mgag200/mgag200_mode.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c
b/drivers/gpu/drm/mgag200/mgag200_mode.c
index d3d99a2..f89a0c1 100644
--- a/drivers/gpu/drm/mgag200
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/gma500/cdv_intel_dp.c|1 +
drivers/gpu/drm/gma500/oaktrail_lvds.c |1 +
drivers/gpu/drm/gma500/psb_intel_modes.c |1 +
3 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c
b/drivers
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/ast/ast_mode.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
index 7fc9f72..c27aa8d 100644
--- a/drivers/gpu/drm/ast/ast_mode.c
+++ b/drivers/gpu/drm/ast
e drm core.
v2: a. Also adapt Kconfig
b. Add missing 'select FW_LOADER'
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/Kconfig |3 ++-
drivers/gpu/drm/Makefile |2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kco
v2: Use offsetof().
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c | 16 +---
1 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 049fa52..9e64069 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b
when reading a 'firmware'-supplied EDID or on error.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_crtc.c |1 +
drivers/gpu/drm/drm_edid.c | 57 +--
include/drm/drm_crtc.h |1 +
include/drm/drm_edid.h |1 +
4 files c
different connector
sections.
The option now looks like this:
edid_firmware="[:][;:]..."
v2: Check for edidname != NULL before entering loop.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid_load.c | 45 ++
1 files changed, 31 inserti
Signed-off-by: Egbert Eich
---
include/drm/drm_crtc.h |8
include/drm/drm_edid.h |9 +
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
index d402b3b..7eed9bd 100644
--- a/include/drm/drm_crtc.h
+++ b/include
This patch is a bit cosmetic as the variable size will truncate
the start address anyway but for readability it should be made
explicite that the lowest bit in the EDID block number determines
the I2C start address.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c |2 +-
1 files
one (except for detecting the presence of a device thru
EDID). Also it does so not on the helper level any more, the possibility for
EDID loading now happens on the DRM KMS core level.
v2: Fixed formatting and conflicts due to reordering of commits.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/dr
If I2C readout fails for an extension block but we have read a
valid base block, don't fail completely but at least return the
base block.
v2: Make goto target names more telling.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c |7 +--
1 files changed, 5 insertions(
ff-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c | 64 +++
drivers/gpu/drm/drm_edid_load.c | 54 +++-
include/drm/drm_edid.h |1 +
3 files changed, 71 insertions(+), 48 deletions(-)
diff --git a/drivers/gp
Ville Syrj?l? writes:
> On Thu, Nov 22, 2012 at 05:22:55AM -0500, Egbert Eich wrote:
> > There are displays which announce EDID extension blocks in the
> > Extension Flag of the EDID base block although they are not EDDC
> > capable (ie. take a segment address at I
Ville Syrj?l? writes:
>
> Me neither. I just figured it might reduce the chance of false
> positives. But if you say that can't happen, I'll take your word
> for it.
>
> > Regarding memcmp() you are definitely right, I will change the code.
> >
> > >
> > > Also the comment is somehow
Ville Syrj?l? writes:
> On Thu, Nov 22, 2012 at 05:23:03AM -0500, Egbert Eich wrote:
> >
> > - /* if there's no extensions, we're done */
> > + /* if there are no extensions, we're done - don't bother caching */
> >if (block[EDID_EXTE
? :
Reworded comment,
Used memcmp(),
Compared entire base block instead of signature only.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index
when reading a 'firmware'-supplied EDID or on error.
V3: Uncache when only one extension block is found. This chunk had
accidentally gone into the next patch of the series. Found by
Ville Syrj?l? .
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_crtc.c |1 +
drive
monitor is changed
but still prevents permanent EDID errors from piling up
the the kernel logs.
v2: Fixed conflits due to reordering of commits.
Set error state where missing.
v3: Don't update cache when returning block from cache.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_e
Ville Syrj?l? writes:
> >
> > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> > index dd0df60..aa9b34d 100644
> > --- a/drivers/gpu/drm/drm_edid.c
> > +++ b/drivers/gpu/drm/drm_edid.c
> > @@ -157,6 +157,17 @@ int drm_edid_header_is_valid(const u8 *raw_edid)
> > }
>
state.
Included results of extension block checking in the
overall error state.
Removed drm_edid_block_valid() as there is noone
using it.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c | 136
drivers/gpu/drm/r
v2: Adjusted to apply cleanly.
Signed-off-by: Egbert Eich
---
include/drm/drm_crtc.h |8
include/drm/drm_edid.h |9 +
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
index 7a3ccbf..7eed9bd 100644
--- a
Ville Syrj?l? writes:
> On Thu, Nov 22, 2012 at 07:28:44PM +0100, Egbert Eich wrote:
> >
> > Something similar should be done for drm_edid_is_valid() - even if the
> > driver doesn't bother (for instance because this function is only called
> > onc
Fixed drm_edid_is_valid() to return the actual error
state.
Included results of extension block checking in the
overall error state.
Removed drm_edid_block_valid() as there is noone
using it.
v5: Added missing radeon/radeon_combios.c.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_e
This may happen when this function prints out debugging information over
a slow (ie serial) line.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_irq.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c
index 3a3d
a double free resulting in a kernel panic when unloading
the radeon driver.
Removing destroy code from radeon_ext_tmds_enc_destroy() fixes this
problem.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/radeon/radeon_legacy_encoders.c |5 +
1 files changed, 1 insertions(+), 4 deletions(
TV DAC load detection did not take into account that there are
chips with a single CRTC when attempted to enable the 2nd CRTC.
This fix adds support for single CRTC chips and cleans up handling
of different chipset generations.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/radeon
An uninitialized variable led to broken load detection.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/radeon/radeon_legacy_encoders.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
b/drivers/gpu/drm/radeon
For Radeon 7500 ATI recommends a DAC_FORCE value of 0x1ac. This value
works better on ES1000 (RV100) chips, too, as it doesn't produce any false
positives on any cards I have tested. Therefore let's assume that this
value is good for all RV100 and RV200 chipset generations.
Signed-off-
(bogus) EDID is found it
assumes a digital display is connected.
This works around problems with some crappy IPMI devices using
Radeon ES1000.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/radeon/radeon_connectors.c | 28 +---
1 files changed, 21 insertions(+), 7 deletions
r bpp to 16 when memory is 24MB or lower
and to 8 only if 8MB or less VRAM is found.
This should be a reasonable compromise for us.
This patch will most likely not ever make it upstream.
This works around ugly modes on crappy IPMI cards using ES1000.
Signed-off-by: Egbert Eich
---
drivers/gp
Dave Airlie writes:
> On Thu, Oct 25, 2012 at 3:07 AM, Alex Deucher
> wrote:
> > On Wed, Oct 24, 2012 at 12:33 PM, Egbert Eich wrote:
> >> The Radeon driver reduces the framebuffer resolution to 8bpp if
> >> a device with less than 32 Mb VRAM is found. This c
DAC on those GPUs and adds
code to handle R200 GPUs.
This basically separates the different items in:
DRM/Radeon: Fix TV DAC Load Detection for single CRTC chips.
Egbert Eich (3):
DRM/Radeon: Clean up code in TV DAC load detection.
DRM/Radeon: Add Handling for R200 to TV DAC Load Detection
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 17 -
1 files changed, 16 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
index a1409e9..ef18569
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 18 ++
1 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
index a13ad9d..a1409e9
The RN50 has a TV DAC but only a single CRTC. For load detection this
DAC is controlled by the primary CRTC.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 80 +-
1 files changed, 47 insertions(+), 33 deletions(-)
diff --git a/drivers/gpu
outed.
Therefore we set it here. This avoids an elaborate on/off state tracking
since both primary_dac_dpms() and tv_dac_dpms() functions would have
to touch this bit.
On single CRTC GPUs with just one DAC it's irrelevant where this bit
is handled.
Signed-off-by: Egbert Eich
---
drivers/gpu/
alexdeucher at gmail.com writes:
> From: Alex Deucher
>
> The R200 asics use an external DAC for the secondary DAC.
> The current KMS code tries to use code for the integrated
> TV DAC for R200 which leads to unpredictable results since
> R200 does not have an integrated TV DAC. This patch
If I2C readout fails for an extension block but we have read a
valid base block, don't fail completely but at least return the
base block.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gp
This patch is a bit cosmetic as the variable size will truncate
the start address anyway but for readability it should be made
explicite that the lowest bit in the EDID block number determines
the I2C start address.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c |2 +-
1 files
only disable it for those errors which have been
seen also on the previous DDC read cycle.
6. Move EDID-related functions to drm_edid.h
The handling of EDID related DRM functions seemed to be a bit arbitrary:
although drm_edid.h had been created, new functions were often added to
drm_crtc
address is not taken into account, this block will
be identical to the base block in which case we stop reading further
EEDID blocks, correct the extension flag and just return the base
block.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c | 13 +
1 files changed, 13 insertions
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/exynos/exynos_hdmi.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm/exynos/exynos_hdmi.c
index 2c115f8..bc87bca 100644
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c
+++ b
is less time consuming. For v1.3 we scrap any exsisting map
blocks and recreate them from scratch.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c | 105 +--
1 files changed, 100 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm
e drm core.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/Makefile |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
index 2ff5cef..76ca269 100644
--- a/drivers/gpu/drm/Makefile
+++ b/drivers/gpu/drm/Makefile
@@ -16,11 +16
one (except for detecting the presence of a device thru
EDID). Also it does so not on the helper level any more, the possibility for
EDID loading now happens on the DRM KMS core level.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_crtc_helper.c |6 +-
drivers/gpu/drm/drm_edid.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c | 77 ---
drivers/gpu/drm/drm_edid_load.c | 54 ++-
include/drm/drm_edid.h |1 +
3 files changed, 77 insertions(+), 55 deletions(-)
diff --git a/drivers
is larger
than one page and the kernel is not able to find consecutive
pages to allocate.
In this case it is still better to return what we already have
(in most cases the base block) and correct the extension block
flag and the checksum accordingly than to fail completely.
Signed-off-by: Egbert
consuming
a considerable amount on CPU time for just that.
This patch caches the EDID block if it contains at least one extension.
To determine if the blocks match we only tranfer the base block, on a match
we use the cached data.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_crtc.c |1
monitor is changed
but still prevents permanent EDID errors from piling up
the the kernel logs.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c | 101 +---
drivers/gpu/drm/radeon/radeon_connectors.c |2 +-
include/drm/drm_crtc.h
different connector
sections.
The option now looks like this:
edid_firmware="[:][;:]..."
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid_load.c | 45 ++
1 files changed, 31 insertions(+), 14 deletions(-)
diff --git a/drive
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/ast/ast_mode.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
index 7fc9f72..c27aa8d 100644
--- a/drivers/gpu/drm/ast/ast_mode.c
+++ b/drivers/gpu/drm/ast
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/gma500/cdv_intel_dp.c|1 +
drivers/gpu/drm/gma500/oaktrail_lvds.c |1 +
drivers/gpu/drm/gma500/psb_intel_modes.c |1 +
3 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c
b/drivers
Signed-off-by: Egbert Eich
---
include/drm/drm_crtc.h |8
include/drm/drm_edid.h |9 +
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
index 171aa33..06254bc 100644
--- a/include/drm/drm_crtc.h
+++ b/include
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/mgag200/mgag200_mode.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c
b/drivers/gpu/drm/mgag200/mgag200_mode.c
index d3d99a2..f89a0c1 100644
--- a/drivers/gpu/drm/mgag200
drm_get_edid() returns a pointer to an EDID block. The caller
is responsible to free this pointer itself.
Here the pointer gets assigned to the local variable raw_edid.
Therefore it should be freed before the variable goes out of
scope.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/exynos
Sean Paul writes:
> On Tue, Nov 20, 2012 at 4:30 AM, Egbert Eich wrote:
> > drm_get_edid() returns a pointer to an EDID block. The caller
> > is responsible to free this pointer itself.
> > Here the pointer gets assigned to the local variable raw_edid.
> > Therefor
The patches have been reordered and the changes suggested by
Takashi Iwai have been worked in.
Egbert Eich (18):
1. Make error handling of EDID extension blocks a bit more fault
tolorant:
* Don't fail when EDID extension blocks cannot be read or memory
cannot be allocated.
*
When we fail to allocate space for EDID extensions we should just
warn, fix up the EDID block count and return the base block instead
of failing.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu
address is not taken into account, this block will
be identical to the base block in which case we stop reading further
EEDID blocks, correct the extension flag and just return the base
block.
v2: Split up EDID fixup code into separate commit.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c
is less time consuming. For v1.3 we scrap any exsisting map
blocks and recreate them from scratch.
v2: Fixed conflits due to reordering of commits.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c | 89
1 files changed, 89 insertions(+), 0
EDID extension blogs are only expected for EDIDs version 1.3 or higher.
If an EDID with a lower version is found fix the block count in the
extension flags and return the base block.
This should help to avoid issues with older displays with broken
DDC implementations.
Signed-off-by: Egbert Eich
the same
block.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index da2f7fa..0fe61fb 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/ast/ast_mode.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
index 7fc9f72..c27aa8d 100644
--- a/drivers/gpu/drm/ast/ast_mode.c
+++ b/drivers/gpu/drm/ast
monitor is changed
but still prevents permanent EDID errors from piling up
the the kernel logs.
v2: Fixed conflits due to reordering of commits.
Set error state where missing.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c | 115 +---
drivers/gpu
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/mgag200/mgag200_mode.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c
b/drivers/gpu/drm/mgag200/mgag200_mode.c
index d3d99a2..f89a0c1 100644
--- a/drivers/gpu/drm/mgag200
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/gma500/cdv_intel_dp.c|1 +
drivers/gpu/drm/gma500/oaktrail_lvds.c |1 +
drivers/gpu/drm/gma500/psb_intel_modes.c |1 +
3 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c
b/drivers
e drm core.
v2: a. Also adapt Kconfig
b. Add missing 'select FW_LOADER'
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/Kconfig |3 ++-
drivers/gpu/drm/Makefile |2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kco
v2: Use offsetof().
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c | 16 +---
1 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 049fa52..9e64069 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b
when reading a 'firmware'-supplied EDID or on error.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_crtc.c |1 +
drivers/gpu/drm/drm_edid.c | 57 +--
include/drm/drm_crtc.h |1 +
include/drm/drm_edid.h |1 +
4 files c
different connector
sections.
The option now looks like this:
edid_firmware="[:][;:]..."
v2: Check for edidname != NULL before entering loop.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid_load.c | 45 ++
1 files changed, 31 inserti
Signed-off-by: Egbert Eich
---
include/drm/drm_crtc.h |8
include/drm/drm_edid.h |9 +
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
index d402b3b..7eed9bd 100644
--- a/include/drm/drm_crtc.h
+++ b/include
This patch is a bit cosmetic as the variable size will truncate
the start address anyway but for readability it should be made
explicite that the lowest bit in the EDID block number determines
the I2C start address.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c |2 +-
1 files
one (except for detecting the presence of a device thru
EDID). Also it does so not on the helper level any more, the possibility for
EDID loading now happens on the DRM KMS core level.
v2: Fixed formatting and conflicts due to reordering of commits.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/dr
If I2C readout fails for an extension block but we have read a
valid base block, don't fail completely but at least return the
base block.
v2: Make goto target names more telling.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c |7 +--
1 files changed, 5 insertions(
ff-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c | 64 +++
drivers/gpu/drm/drm_edid_load.c | 54 +++-
include/drm/drm_edid.h |1 +
3 files changed, 71 insertions(+), 48 deletions(-)
diff --git a/drivers/gp
Ville Syrj?l? writes:
> On Thu, Nov 22, 2012 at 05:22:55AM -0500, Egbert Eich wrote:
> > There are displays which announce EDID extension blocks in the
> > Extension Flag of the EDID base block although they are not EDDC
> > capable (ie. take a segment address at I
Ville Syrj?l? writes:
>
> Me neither. I just figured it might reduce the chance of false
> positives. But if you say that can't happen, I'll take your word
> for it.
>
> > Regarding memcmp() you are definitely right, I will change the code.
> >
> > >
> > > Also the comment is somehow
Ville Syrj?l? writes:
> On Thu, Nov 22, 2012 at 05:23:03AM -0500, Egbert Eich wrote:
> >
> > - /* if there's no extensions, we're done */
> > + /* if there are no extensions, we're done - don't bother caching */
> >if (block[EDID_EXTE
:
Reworded comment,
Used memcmp(),
Compared entire base block instead of signature only.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index
when reading a 'firmware'-supplied EDID or on error.
V3: Uncache when only one extension block is found. This chunk had
accidentally gone into the next patch of the series. Found by
Ville Syrjälä .
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_crtc.c |1 +
drive
monitor is changed
but still prevents permanent EDID errors from piling up
the the kernel logs.
v2: Fixed conflits due to reordering of commits.
Set error state where missing.
v3: Don't update cache when returning block from cache.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_e
Ville Syrj?l? writes:
> >
> > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> > index dd0df60..aa9b34d 100644
> > --- a/drivers/gpu/drm/drm_edid.c
> > +++ b/drivers/gpu/drm/drm_edid.c
> > @@ -157,6 +157,17 @@ int drm_edid_header_is_valid(const u8 *raw_edid)
> > }
>
state.
Included results of extension block checking in the
overall error state.
Removed drm_edid_block_valid() as there is noone
using it.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c | 136
drivers/gpu/drm/r
v2: Adjusted to apply cleanly.
Signed-off-by: Egbert Eich
---
include/drm/drm_crtc.h |8
include/drm/drm_edid.h |9 +
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
index 7a3ccbf..7eed9bd 100644
--- a
Ville Syrj?l? writes:
> On Thu, Nov 22, 2012 at 07:28:44PM +0100, Egbert Eich wrote:
> >
> > Something similar should be done for drm_edid_is_valid() - even if the
> > driver doesn't bother (for instance because this function is only called
> > onc
Fixed drm_edid_is_valid() to return the actual error
state.
Included results of extension block checking in the
overall error state.
Removed drm_edid_block_valid() as there is noone
using it.
v5: Added missing radeon/radeon_combios.c.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_e
We are a little less than one month into XDC 2012 so
here's some update:
Registration:
-
So far we have 32 registered participants - which is pretty good.
If you plan to come and haven't added yourself to the participants
list at http://wiki.x.org/wiki/Events/XDC2012/Attendees, plea
We are now less than a week into the conference so here's
an update with the latest infos:
Registration
We have close to 50 registered participants now. If you haven't
registered yourself please take a minute to go to
http://wiki.x.org/wiki/Events/XDC2012/Attendees
to put your
1 - 100 of 194 matches
Mail list logo
