Re: [RFC PATCH 1/8] dt-bindings: drm/panel-simple: Introduce generic eDP panels

2021-07-29 Thread Doug Anderson
Hi, On Thu, Jul 29, 2021 at 1:27 PM Rob Herring wrote: > > IMO, you should move any applicable compatibles to the edp-panel schema. > Also, I don't think you should add 'edp-panel' to them. If they can work > better with the generic eDP driver, then that should be an internal > kernel change with

Re: [PATCH v2 11/14] drm/bridge: ti-sn65dsi86: Power things properly for reading the EDID

2021-04-14 Thread Doug Anderson
e itself can work when these rails are turned on. The panel is on a separate power rail and you can't talk to the panel at all until it's powered on and then asserts HPD to us to say it finished its boot sequence. > W dniu 01.04.2021 o 16:57, Doug Anderson pisze: > > Hi, >

Re: [PATCH v3 01/12] drm/bridge: Fix the stop condition of drm_bridge_chain_pre_enable()

2021-04-14 Thread Doug Anderson
Hi, On Sun, Apr 4, 2021 at 5:50 PM Laurent Pinchart wrote: > > Hi Doug, > > Thank you for the patch. > > On Fri, Apr 02, 2021 at 03:28:35PM -0700, Douglas Anderson wrote: > > The drm_bridge_chain_pre_enable() is not the proper opposite of > > drm_bridge_chain_post_disable(). It continues along th

Re: [PATCH v3 12/12] drm/panel: panel-simple: Use runtime pm to avoid excessive unprepare / prepare

2021-04-14 Thread Doug Anderson
Hi, On Wed, Apr 14, 2021 at 5:58 PM Laurent Pinchart wrote: > > Hi Doug, > > Thank you for the patch. > > On Fri, Apr 02, 2021 at 03:28:46PM -0700, Douglas Anderson wrote: > > Unpreparing and re-preparing a panel can be a really heavy > > operation. Panels datasheets often specify something on th

Re: [PATCH v3 01/12] drm/bridge: Fix the stop condition of drm_bridge_chain_pre_enable()

2021-04-15 Thread Doug Anderson
Hi, On Wed, Apr 14, 2021 at 6:56 PM Laurent Pinchart wrote: > > Hi Doug, > > On Wed, Apr 14, 2021 at 06:19:13PM -0700, Doug Anderson wrote: > > On Sun, Apr 4, 2021 at 5:50 PM Laurent Pinchart wrote: > > > On Fri, Apr 02, 2021 at 03:28:35PM -0700, Douglas

Re: [v1 0/3] drm: Add support for backlight control of eDP panel on ti-sn65dsi86 bridge

2021-04-16 Thread Doug Anderson
Hi, On Wed, Apr 14, 2021 at 9:41 AM Rajeev Nandan wrote: > > The backlight level of an eDP panel can be controlled through the AUX > channel using DPCD registers of the panel. > > The capability for the Source device to adjust backlight characteristics > within the panel, using the Sink device DP

Re: [PATCH v4 15/27] drm/bridge: ti-sn65dsi86: Break GPIO and MIPI-to-eDP bridge into sub-drivers

2021-04-19 Thread Doug Anderson
Hi, On Fri, Apr 16, 2021 at 7:32 PM kernel test robot wrote: > > Hi Douglas, > > I love your patch! Yet something to improve: > > [auto build test ERROR on next-20210416] > [cannot apply to wsa/i2c/for-next robh/for-next linus/master v5.12-rc7 > v5.12-rc6 v5.12-rc5 v5.12-rc7] > [If your patch is

Re: [PATCH v4 00/27] drm: Fix EDID reading on ti-sn65dsi86; solve some chicken-and-egg problems

2021-04-20 Thread Doug Anderson
Hi, On Fri, Apr 16, 2021 at 3:40 PM Douglas Anderson wrote: > > The primary goal of this series is to try to properly fix EDID reading > for eDP panels using the ti-sn65dsi86 bridge. > > Previously we had a patch that added EDID reading but it turned out > not to work at bootup. This caused some

Re: [RFC PATCH 1/3] dt-bindings: display: simple: Add the panel on sc7180-trogdor-pompom

2021-04-22 Thread Doug Anderson
Hi, On Mon, Mar 29, 2021 at 9:25 AM Doug Anderson wrote: > > Hi, > > On Thu, Mar 25, 2021 at 5:09 PM Rob Herring wrote: > > > > On Tue, Mar 16, 2021 at 02:08:19PM -0700, Douglas Anderson wrote: > > > The sc7180-trogdor-pompom board might be attached to any num

Re: [PATCH v4 24/27] drm/panel: panel-simple: Cache the EDID as long as we retain power

2021-04-23 Thread Doug Anderson
Hi, On Fri, Apr 23, 2021 at 9:12 AM Bjorn Andersson wrote: > > On Fri 16 Apr 17:39 CDT 2021, Douglas Anderson wrote: > > > It doesn't make sense to go out to the bus and read the EDID over and > > over again. Let's cache it and throw away the cache when we turn power > > off from the panel. Autos

Re: [PATCH v4 27/27] drm/panel: panel-simple: Prepare/unprepare are refcounted, not forced

2021-04-23 Thread Doug Anderson
Hi, On Fri, Apr 16, 2021 at 3:41 PM Douglas Anderson wrote: > > Historically simple-panel had code to make sure that if prepare() was > called on an already-prepared panel that it was a no-op. Similarly if > unprepare() was called on an already-unprepared panel it was also a > no-op. Essentially

Re: [2/2] drm/panel: lms397kf04: Add driver for LMS397KF04

2021-04-29 Thread Doug Anderson
Hi, On Thu, Apr 29, 2021 at 8:40 AM Linus Walleij > @@ -33,6 +33,7 @@ obj-$(CONFIG_DRM_PANEL_RASPBERRYPI_TOUCHSCREEN) += > panel-raspberrypi-touchscreen > obj-$(CONFIG_DRM_PANEL_RAYDIUM_RM67191) += panel-raydium-rm67191.o > obj-$(CONFIG_DRM_PANEL_RAYDIUM_RM68200) += panel-raydium-rm68200.o >

Re: [1/2] drm/panel: Add DT bindings for Samsung LMS397KF04

2021-04-29 Thread Doug Anderson
Hi, On Thu, Apr 29, 2021 at 8:39 AM Linus Walleij wrote: > > This adds device tree bindings for the Samsung LMS397KF04 > RGB DPI display panel. > > Cc: devicet...@vger.kernel.org > Signed-off-by: Linus Walleij > Reviewed-by: Rob Herring > --- > .../display/panel/samsung,lms397kf04.yaml | 7

Re: [PATCH 1/2] drm/panel: Add DT bindings for Samsung LMS397KF04

2021-04-29 Thread Doug Anderson
Hi, On Thu, Apr 29, 2021 at 7:34 AM Linus Walleij wrote: > > On Tue, Apr 6, 2021 at 1:47 AM Linus Walleij wrote: > > > This adds device tree bindings for the Samsung LMS397KF04 > > RGB DPI display panel. > > > > Cc: devicet...@vger.kernel.org > > Signed-off-by: Linus Walleij > > Someone on DRM

Re: [v3 1/2] dt-bindings: backlight: add DisplayPort aux backlight

2021-04-29 Thread Doug Anderson
Hi, On Thu, Apr 29, 2021 at 11:04 AM Rob Herring wrote: > > On Mon, Apr 26, 2021 at 11:29:15AM +0530, Rajeev Nandan wrote: > > Add bindings for DisplayPort aux backlight driver. > > > > Changes in v2: > > - New > > > > Signed-off-by: Rajeev Nandan > > --- > > .../bindings/leds/backlight/dp-aux-

Re: [PATCH v5 01/20] drm/panel: panel-simple: Add missing pm_runtime_disable() calls

2021-04-29 Thread Doug Anderson
Hi, On Thu, Apr 29, 2021 at 5:58 PM Linus Walleij wrote: > > On Fri, Apr 23, 2021 at 6:59 PM Douglas Anderson > wrote: > > > In commit 3235b0f20a0a ("drm/panel: panel-simple: Use runtime pm to > > avoid excessive unprepare / prepare") we started using pm_runtime, but > > my patch neglected to a

Re: [PATCH v5 01/20] drm/panel: panel-simple: Add missing pm_runtime_disable() calls

2021-04-30 Thread Doug Anderson
Hi, On Thu, Apr 29, 2021 at 6:28 PM Linus Walleij wrote: > > On Fri, Apr 30, 2021 at 3:25 AM Doug Anderson wrote: > > > > I think pm_runtime_disable(); need to be added there? > > > > I'm a bit confused. You're saying that I need to add > > pm_runti

Re: [v3 1/2] dt-bindings: backlight: add DisplayPort aux backlight

2021-04-30 Thread Doug Anderson
Hi, On Fri, Apr 30, 2021 at 8:10 AM wrote: > > On 30-04-2021 02:33, Doug Anderson wrote: > > Hi, > > > > On Thu, Apr 29, 2021 at 11:04 AM Rob Herring wrote: > >> > >> On Mon, Apr 26, 2021 at 11:29:15AM +0530, Rajeev Nandan wrote: > >>

Re: [PATCH v2 0/6] eDP: Support probing eDP panels dynamically instead of hardcoding

2021-08-09 Thread Doug Anderson
Hi, On Tue, Aug 3, 2021 at 1:41 PM Sam Ravnborg wrote: > > Hi Douglas, > > On Fri, Jul 30, 2021 at 02:26:19PM -0700, Douglas Anderson wrote: > > The goal of this patch series is to move away from hardcoding exact > > eDP panels in device tree files. As discussed in the various patches > > in this

Re: [PATCH v2 1/6] dt-bindings: drm/panel-simple: Introduce generic eDP panels

2021-08-09 Thread Doug Anderson
Hi, On Mon, Aug 2, 2021 at 6:39 AM Rob Herring wrote: > > On Fri, 30 Jul 2021 14:26:20 -0700, Douglas Anderson wrote: > > eDP panels generally contain almost everything needed to control them > > in their EDID. This comes from their DP heritage were a computer needs > > to be able to properly con

Re: [PATCH v2 0/6] eDP: Support probing eDP panels dynamically instead of hardcoding

2021-08-12 Thread Doug Anderson
Hi, On Thu, Aug 12, 2021 at 2:38 AM Sam Ravnborg wrote: > > Hi Doug, > On Mon, Aug 09, 2021 at 03:18:03PM -0700, Doug Anderson wrote: > > Hi, > > > > On Tue, Aug 3, 2021 at 1:41 PM Sam Ravnborg wrote: > > > > > > Hi Douglas, > > > > >

Re: [PATCH 1/4] drm/bridge: ti-sn65dsi86: Avoid creating multiple connectors

2021-08-12 Thread Doug Anderson
Hi, On Wed, Aug 11, 2021 at 4:51 PM Rob Clark wrote: > > From: Rob Clark > > If we created our own connector because the driver does not support the > NO_CONNECTOR flag, we don't want the downstream bridge to *also* create > a connector. And if this driver did pass the NO_CONNECTOR flag (and we

Re: [PATCH 4/4] drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support

2021-08-12 Thread Doug Anderson
Hi, On Wed, Aug 11, 2021 at 4:51 PM Rob Clark wrote: > > From: Rob Clark > > Slightly awkward to fish out the display_info when we aren't creating > own connector. But I don't see an obvious better way. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 34 ++

Re: [PATCH 3/4] drm/bridge: ti-sn65dsi86: Implement bridge->mode_valid()

2021-08-12 Thread Doug Anderson
Hi, On Wed, Aug 11, 2021 at 4:51 PM Rob Clark wrote: > > From: Rob Clark > > For the brave new world of bridges not creating their own connectors, we > need to implement the max clock limitation via bridge->mode_valid() > instead of connector->mode_valid(). > > Signed-off-by: Rob Clark > --- >

Re: [PATCH 4/4] drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support

2021-08-12 Thread Doug Anderson
Laurent, On Thu, Aug 12, 2021 at 12:26 PM Laurent Pinchart wrote: > > Hi Rob, > > Thank you for the patch. > > On Wed, Aug 11, 2021 at 04:52:50PM -0700, Rob Clark wrote: > > From: Rob Clark > > > > Slightly awkward to fish out the display_info when we aren't creating > > own connector. But I do

Re: linux-next: build failure after merge of the driver-core tree

2021-08-12 Thread Doug Anderson
Hi, On Tue, Aug 10, 2021 at 5:13 AM Geert Uytterhoeven wrote: > > On Fri, Jul 23, 2021 at 7:35 AM Uwe Kleine-König > wrote: > > On Fri, Jul 23, 2021 at 03:09:44PM +1000, Stephen Rothwell wrote: > > > After merging the driver-core tree, today's linux-next build (arm > > > multi_v7_defconfig) fail

Re: [PATCH] drm/bridge: parade-ps8640: Reorg the macros

2021-08-24 Thread Doug Anderson
Hi, On Fri, Aug 20, 2021 at 4:22 PM Philip Chen wrote: > > From: Philip Chen > > Reorg the macros as follows: > (1) Group the registers on the same page together. > (2) Group the register and its bit operation together while indenting > the macros of the bit operation with one space. > > Also fi

Re: [PATCH v1 2/2] dt-bindings: Add SC7280 compatible string

2021-08-24 Thread Doug Anderson
Hi, On Wed, Aug 11, 2021 at 5:08 PM Sankeerth Billakanti wrote: > > The Qualcomm SC7280 platform supports an eDP controller, add > compatible string for it to msm/binding. > > Signed-off-by: Sankeerth Billakanti > --- > Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 3 +++ >

Re: [v2 0/2] Add driver for BOE tv110c9m-ll3 panel

2021-08-26 Thread Doug Anderson
Hi, On Mon, Aug 23, 2021 at 6:41 PM yangcong wrote: > > Hi Sam, > This driver support boe tv1110c9m-ll3 and inx hj110iz-01a panel.The IC chip > is used NT36523, which is a new IC. > > 1: panel-boe-tv101wum-nl6.c driver cannot meet the timing requirements of the > current two panel. > > 2: The

Re: [v3 1/2] drm/panel: support for BOE tv1110c9m-ll3 wuxga dsi video mode panel

2021-08-26 Thread Doug Anderson
Hi, On Thu, Aug 26, 2021 at 4:03 AM yangcong wrote: > > Add driver for BOE tv110c9m-ll3 panel is a 10.95" 1200x2000 panel. > > Signed-off-by: yangcong > --- > drivers/gpu/drm/panel/Kconfig | 10 + > drivers/gpu/drm/panel/Makefile |1 + > drivers/gpu/drm/panel/pane

Re: [PATCH v2] drm/bridge: parade-ps8640: Reorg the macros

2021-08-26 Thread Doug Anderson
Hi, On Tue, Aug 24, 2021 at 6:12 PM Philip Chen wrote: > > Reorg the macros as follows: > (1) Group the registers on the same page together. > (2) Group the register and its bit operation together while indenting > the macros of the bit operation with one space. > > Also fix a misnomer for the nu

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-08-26 Thread Doug Anderson
Hi, On Mon, Jul 26, 2021 at 4:15 PM Bjorn Andersson wrote: > > +static int dp_parser_find_panel(struct dp_parser *parser) > +{ > + struct device_node *np = parser->pdev->dev.of_node; > + int rc; > + > + rc = drm_of_find_panel_or_bridge(np, 2, 0, &parser->drm_panel, NULL); > +

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-08-26 Thread Doug Anderson
Hi, On Wed, Aug 25, 2021 at 6:31 PM Stephen Boyd wrote: > > Quoting Bjorn Andersson (2021-07-26 16:13:51) > > eDP panels might need some power sequencing and backlight management, > > so make it possible to associate a drm_panel with a DP instance and > > prepare and enable the panel accordingly.

Re: [PATCH 2/3] drm/bridge: ti-sn65dsi86: Move code in prep for EDID read fix

2021-03-15 Thread Doug Anderson
Hi, On Sat, Mar 13, 2021 at 1:13 PM Laurent Pinchart wrote: > > Hi Douglas, > > Thank you for the patch. > > On Thu, Mar 04, 2021 at 03:52:00PM -0800, Douglas Anderson wrote: > > This patch is _only_ code motion to prepare for the patch > > ("drm/bridge: ti-sn65dsi86: Properly get the EDID, but o

Re: [PATCH 3/3] drm/bridge: ti-sn65dsi86: Properly get the EDID, but only if refclk

2021-03-15 Thread Doug Anderson
Hi, On Sat, Mar 13, 2021 at 1:17 PM Laurent Pinchart wrote: > > Hi Doug, > > Thank you for the patch. > > On Thu, Mar 04, 2021 at 03:52:01PM -0800, Douglas Anderson wrote: > > In commit 58074b08c04a ("drm/bridge: ti-sn65dsi86: Read EDID blob over > > DDC") we attempted to make the ti-sn65dsi86 br

Re: [PATCH 3/3] drm/bridge: ti-sn65dsi86: Properly get the EDID, but only if refclk

2021-03-16 Thread Doug Anderson
Hi, On Tue, Mar 16, 2021 at 2:46 PM Laurent Pinchart wrote: > > Hi Doug, > > On Mon, Mar 15, 2021 at 09:25:37AM -0700, Doug Anderson wrote: > > On Sat, Mar 13, 2021 at 1:17 PM Laurent Pinchart wrote: > > > On Thu, Mar 04, 2021 at 03:52:01PM -0800, Douglas Anders

Re: [PATCH] drm/msm: Ratelimit invalid-fence message

2021-03-17 Thread Doug Anderson
Hi, On Wed, Mar 17, 2021 at 9:40 AM Rob Clark wrote: > > From: Rob Clark > > We have seen a couple cases where low memory situations cause something > bad to happen, followed by a flood of these messages obscuring the root > cause. Lets ratelimit the dmesg spam so that next time it happens we >

Re: [v1] drm/msm/disp/dpu1: fix display underruns during modeset.

2021-03-19 Thread Doug Anderson
Hi, On Fri, Mar 19, 2021 at 5:54 AM Kalyan Thota wrote: > > During crtc disable, display perf structures are reset to 0 > which includes state varibles which are immutable. On crtc > enable, we use the same structures and they don't refelect > the actual values > > 1) Fix is to avoid updating the

Re: [PATCH v3 3/4] drm/bridge: ti-sn65dsi86: Read EDID blob over DDC

2021-03-23 Thread Doug Anderson
Hi, On Mon, Mar 22, 2021 at 8:17 PM Stephen Boyd wrote: > > Quoting Laurent Pinchart (2021-03-17 17:20:43) > > Hi Stephen, > > > > Reviving a bit of an old thread, for a question. > > > > On Mon, Nov 02, 2020 at 10:11:43AM -0800, Stephen Boyd wrote: > > > @@ -265,6 +267,23 @@ connector_to_ti_sn_b

Re: [RFC PATCH 01/11] dt-bindings: drm/bridge: ti-sn65dsi8: Make enable GPIO optional

2021-03-23 Thread Doug Anderson
Hi, On Sun, Mar 21, 2021 at 8:02 PM Laurent Pinchart wrote: > > The SN65DSI86 EN pin can be hardwired to a high level, or connected to a > global reset signal, not controllable by the kernel. Make it optional in > those cases. > > Signed-off-by: Laurent Pinchart > --- > .../devicetree/bindings/

Re: [RFC PATCH 02/11] drm/bridge: ti-sn65dsi86: Make enable GPIO optional

2021-03-23 Thread Doug Anderson
Hi, On Sun, Mar 21, 2021 at 8:02 PM Laurent Pinchart wrote: > > The enable signal may not be controllable by the kernel. Make it > optional. > > Signed-off-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by

Re: [RFC PATCH 03/11] drm/bridge: ti-sn65dsi86: Unregister AUX adapter in remove()

2021-03-23 Thread Doug Anderson
Hi, On Sun, Mar 21, 2021 at 8:02 PM Laurent Pinchart wrote: > > The AUX adapter registered in probe() need to be unregistered in > remove(). Do so. > > Fixes: b814ec6d4535 ("drm/bridge: ti-sn65dsi86: Implement AUX channel") > Signed-off-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/ti-sn6

Re: [RFC PATCH 04/11] drm/bridge: ti-sn65dsi86: Use bitmask to store valid rates

2021-03-23 Thread Doug Anderson
Hi, On Sun, Mar 21, 2021 at 8:02 PM Laurent Pinchart wrote: > > The valid rates are stored in an array of 8 booleans. Replace it with a > bitmask to save space. I'm curious: do you have evidence that this does anything useful? I guess you're expecting it to save .text space, right? Stack usage a

Re: [RFC PATCH 04/11] drm/bridge: ti-sn65dsi86: Use bitmask to store valid rates

2021-03-23 Thread Doug Anderson
Hi, On Tue, Mar 23, 2021 at 2:46 PM Laurent Pinchart wrote: > > Hi Doug, > > On Tue, Mar 23, 2021 at 02:08:55PM -0700, Doug Anderson wrote: > > On Sun, Mar 21, 2021 at 8:02 PM Laurent Pinchart wrote: > > > > > > The valid rates are stored in an ar

Re: [RFC PATCH 03/11] drm/bridge: ti-sn65dsi86: Unregister AUX adapter in remove()

2021-03-23 Thread Doug Anderson
Hi, On Tue, Mar 23, 2021 at 2:42 PM Laurent Pinchart wrote: > > Hi Doug, > > On Tue, Mar 23, 2021 at 02:08:42PM -0700, Doug Anderson wrote: > > On Sun, Mar 21, 2021 at 8:02 PM Laurent Pinchart wrote: > > > > > > The AUX adapter registered in probe() need to b

Re: [RFC PATCH 05/11] drm/bridge: ti-sn65dsi86: Wrap panel with panel-bridge

2021-03-24 Thread Doug Anderson
Hi, On Sun, Mar 21, 2021 at 8:02 PM Laurent Pinchart wrote: > > To simplify interfacing with the panel, wrap it in a panel-bridge and > let the DRM bridge helpers handle chaining of operations. > > This also prepares for support of DRM_BRIDGE_ATTACH_NO_CONNECTOR, which > requires all components i

Re: [RFC PATCH 06/11] drm/bridge: ti-sn65dsi86: Group code in sections

2021-03-24 Thread Doug Anderson
Hi, On Sun, Mar 21, 2021 at 8:02 PM Laurent Pinchart wrote: > > Reorganize the functions in sections, related to connector operations, > bridge operations, AUX adapter, GPIO controller and probe & remove. > > This prepares for proper support of DRM_BRIDGE_ATTACH_NO_CONNECTOR that > will add more

Re: [RFC PATCH 07/11] drm/bridge: ti-sn65dsi86: Split connector creation to a function

2021-03-24 Thread Doug Anderson
Hi, On Sun, Mar 21, 2021 at 8:02 PM Laurent Pinchart wrote: > > To prepare for making connector creation option, move connector creation > out of ti_sn_bridge_attach to a separate function. > > No functional change intended. > > Signed-off-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/ti-

Re: [RFC PATCH 08/11] drm/bridge: ti-sn65dsi86: Implement bridge connector operations

2021-03-24 Thread Doug Anderson
Hi, On Sun, Mar 21, 2021 at 8:02 PM Laurent Pinchart wrote: > > Implement the bridge connector-related .get_edid() operation, and report > the related bridge capabilities and type. The .get_edid() operation is > implemented with the same backend as the EDID retrieval from the > connector .get_mod

Re: [RFC PATCH 10/11] drm/bridge: ti-sn65dsi86: Support DisplayPort (non-eDP) mode

2021-03-24 Thread Doug Anderson
Hi, On Sun, Mar 21, 2021 at 8:02 PM Laurent Pinchart wrote: > > Despite the SN65DSI86 being an eDP bridge, on some systems its output is > routed to a DisplayPort connector. Enable DisplayPort mode when the next > component in the display pipeline is not a panel, and disable eDP > features in tha

Re: [RFC PATCH 11/11] drm/bridge: ti-sn65dsi86: Support hotplug detection

2021-03-24 Thread Doug Anderson
Hi, On Sun, Mar 21, 2021 at 8:02 PM Laurent Pinchart wrote: > > When the SN65DSI86 is used in DisplayPort mode, its output is likely > routed to a DisplayPort connector, which can benefit from hotplug > detection. Support it in such cases, with polling mode only for now. > > The implementation is

Re: [RFC PATCH 03/11] drm/bridge: ti-sn65dsi86: Unregister AUX adapter in remove()

2021-03-25 Thread Doug Anderson
Hi, On Tue, Mar 23, 2021 at 4:03 PM Laurent Pinchart wrote: > > Hi Doug, > > On Tue, Mar 23, 2021 at 03:55:05PM -0700, Doug Anderson wrote: > > On Tue, Mar 23, 2021 at 2:42 PM Laurent Pinchart wrote: > > > On Tue, Mar 23, 2021 at 02:08:42PM -0700, Doug Anderson wr

Re: [RFC PATCH 1/3] dt-bindings: display: simple: Add the panel on sc7180-trogdor-pompom

2021-03-29 Thread Doug Anderson
Hi, On Fri, Mar 26, 2021 at 12:48 PM Rob Herring wrote: > > On Fri, Mar 26, 2021 at 9:20 AM Rob Clark wrote: > > > > On Fri, Mar 26, 2021 at 8:18 AM Rob Clark wrote: > > > > > > On Fri, Mar 26, 2021 at 5:38 AM Thierry Reding > > > wrote: > > > > > > > > On Wed, Mar 17, 2021 at 06:53:04PM -070

Re: [RFC PATCH 1/3] dt-bindings: display: simple: Add the panel on sc7180-trogdor-pompom

2021-03-29 Thread Doug Anderson
Hi, On Fri, Mar 26, 2021 at 5:38 AM Thierry Reding wrote: > > The point remains that unless we describe exactly which panel we're > dealing with, we ultimately have no way of properly quirking anything if > we ever have to. Just to clarify here: with my initial proposal we actually could still q

Re: [RFC PATCH 1/3] dt-bindings: display: simple: Add the panel on sc7180-trogdor-pompom

2021-03-29 Thread Doug Anderson
Hi, On Thu, Mar 25, 2021 at 5:09 PM Rob Herring wrote: > > On Tue, Mar 16, 2021 at 02:08:19PM -0700, Douglas Anderson wrote: > > The sc7180-trogdor-pompom board might be attached to any number of a > > pile of eDP panels. At the moment I'm told that the list might include: > > - KD KD116N21-30NV-

Re: [PATCH 3/3] drm/bridge: ti-sn65dsi86: Properly get the EDID, but only if refclk

2021-03-29 Thread Doug Anderson
Hi, On Tue, Mar 16, 2021 at 5:44 PM Doug Anderson wrote: > > Hi, > > On Tue, Mar 16, 2021 at 2:46 PM Laurent Pinchart > wrote: > > > > Hi Doug, > > > > On Mon, Mar 15, 2021 at 09:25:37AM -0700, Doug Anderson wrote: > > > On Sat, Mar 13, 2021 a

Re: [PATCH v2 09/14] drm/edid: Use the cached EDID in drm_get_edid() if eDP

2021-03-30 Thread Doug Anderson
Hi, On Tue, Mar 30, 2021 at 7:01 AM Ville Syrjälä wrote: > > > @@ -2049,15 +2049,39 @@ struct edid *drm_get_edid(struct drm_connector > > *connector, > > struct i2c_adapter *adapter) > > { > > struct edid *edid; > > + size_t old_edid_size; > > + const struc

Re: [PATCH v2 10/14] drm/bridge: ti-sn65dsi86: Stop caching the EDID ourselves

2021-03-31 Thread Doug Anderson
Hi, On Wed, Mar 31, 2021 at 3:12 AM Andrzej Hajda wrote: > > > W dniu 30.03.2021 o 04:53, Douglas Anderson pisze: > > Now that we have the patch ("drm/edid: Use the cached EDID in > > drm_get_edid() if eDP") we no longer need to maintain our own > > cache. Drop this code. > > > > Signed-off-by: D

Re: [PATCH v2 11/14] drm/bridge: ti-sn65dsi86: Power things properly for reading the EDID

2021-03-31 Thread Doug Anderson
Hi, On Wed, Mar 31, 2021 at 4:08 AM Andrzej Hajda wrote: > > > W dniu 30.03.2021 o 04:53, Douglas Anderson pisze: > > eDP panels won't provide their EDID unless they're powered on. Let's > > chain a power-on before we read the EDID. This roughly matches what > > was done in 'parade-ps8640.c'. > >

Re: [v1] drm/msm/disp/dpu1: fix warn stack reported during dpu resume

2021-03-31 Thread Doug Anderson
Hi, On Wed, Mar 31, 2021 at 4:27 AM Kalyan Thota wrote: > > @@ -294,6 +294,9 @@ static int dpu_kms_parse_data_bus_icc_path(struct dpu_kms > *dpu_kms) > struct icc_path *path1; > struct drm_device *dev = dpu_kms->dev; > > + if (!dpu_supports_bw_scaling(dev)) > +

Re: [PATCH v2 05/14] drm/bridge: ti-sn65dsi86: Move MIPI detach() / unregister() to detach()

2021-03-31 Thread Doug Anderson
Hi, On Wed, Mar 31, 2021 at 2:53 AM Andrzej Hajda wrote: > > > W dniu 30.03.2021 o 04:53, Douglas Anderson pisze: > > The register() / attach() for MIPI happen in the bridge's > > attach(). That means that the inverse belongs in the bridge's > > detach(). > > > As I commented in previous patch, i

Re: [PATCH 2/4] drm/msm: Avoid mutex in shrinker_count()

2021-03-31 Thread Doug Anderson
Hi, On Wed, Mar 31, 2021 at 3:14 PM Rob Clark wrote: > > @@ -818,11 +820,19 @@ static void update_inactive(struct msm_gem_object > *msm_obj) > mutex_lock(&priv->mm_lock); > WARN_ON(msm_obj->active_count != 0); > > + if (msm_obj->dontneed) > + mark_unpurgable(m

Re: [PATCH 3/4] drm/msm: Fix debugfs deadlock

2021-03-31 Thread Doug Anderson
Hi, On Wed, Mar 31, 2021 at 3:14 PM Rob Clark wrote: > > @@ -111,23 +111,15 @@ static const struct file_operations msm_gpu_fops = { > static int msm_gem_show(struct drm_device *dev, struct seq_file *m) > { > struct msm_drm_private *priv = dev->dev_private; > - struct msm_gpu *gpu

Re: [PATCH 4/4] drm/msm: Improved debugfs gem stats

2021-03-31 Thread Doug Anderson
Hi, On Wed, Mar 31, 2021 at 3:14 PM Rob Clark wrote: > > From: Rob Clark > > The last patch lost the breakdown of active vs inactive GEM objects in > $debugfs/gem. But we can add some better stats to summarize not just > active vs inactive, but also purgable/purged to make up for that. > > Sign

Re: [PATCH 2/4] drm/msm: Avoid mutex in shrinker_count()

2021-03-31 Thread Doug Anderson
Hi, On Wed, Mar 31, 2021 at 4:23 PM Rob Clark wrote: > > On Wed, Mar 31, 2021 at 3:44 PM Doug Anderson wrote: > > > > Hi, > > > > On Wed, Mar 31, 2021 at 3:14 PM Rob Clark wrote: > > > > > > @@ -818,11 +820,19 @@ static void updat

Re: [PATCH 0/4] drm/msm: Shrinker (and related) fixes

2021-03-31 Thread Doug Anderson
Hi, On Wed, Mar 31, 2021 at 3:14 PM Rob Clark wrote: > > From: Rob Clark > > I've been spending some time looking into how things behave under high > memory pressure. The first patch is a random cleanup I noticed along > the way. The second improves the situation significantly when we are > ge

Re: [PATCH 1/4] drm/msm: Remove unused freed llist node

2021-03-31 Thread Doug Anderson
Hi, On Wed, Mar 31, 2021 at 3:14 PM Rob Clark wrote: > > From: Rob Clark > > Unused since c951a9b284b907604759628d273901064c60d09f Not terribly important, but checkpatch always yells at me when I don't reference commits by saying: commit c951a9b284b9 ("drm/msm: Remove msm_gem_free_work") > S

Re: [PATCH v2 11/14] drm/bridge: ti-sn65dsi86: Power things properly for reading the EDID

2021-04-01 Thread Doug Anderson
Hi, On Thu, Apr 1, 2021 at 4:12 AM Andrzej Hajda wrote: > > > W dniu 31.03.2021 o 16:48, Doug Anderson pisze: > > Hi, > > > > On Wed, Mar 31, 2021 at 4:08 AM Andrzej Hajda wrote: > >> > >> W dniu 30.03.2021 o 04:53, Douglas Anderson pisze: >

Re: [PATCH v2 1/4] drm/msm: Remove unused freed llist node

2021-04-01 Thread Doug Anderson
Hi, On Wed, Mar 31, 2021 at 6:23 PM Rob Clark wrote: > > From: Rob Clark > > Unused since commit c951a9b284b9 ("drm/msm: Remove msm_gem_free_work") > > Signed-off-by: Rob Clark > Tested-by: Douglas Anderson > --- > drivers/gpu/drm/msm/msm_gem.h | 2 -- > 1 file changed, 2 deletions(-) Review

Re: [PATCH v2 2/4] drm/msm: Avoid mutex in shrinker_count()

2021-04-01 Thread Doug Anderson
Hi, On Wed, Mar 31, 2021 at 6:24 PM Rob Clark wrote: > > @@ -45,6 +30,9 @@ msm_gem_shrinker_scan(struct shrinker *shrinker, struct > shrink_control *sc) > list_for_each_entry(msm_obj, &priv->inactive_dontneed, mm_list) { > if (freed >= sc->nr_to_scan) >

Re: [PATCH v2 3/4] drm/msm: Fix debugfs deadlock

2021-04-01 Thread Doug Anderson
Hi, On Wed, Mar 31, 2021 at 6:24 PM Rob Clark wrote: > > From: Rob Clark > > In normal cases the gem obj lock is acquired first before mm_lock. The > exception is iterating the various object lists. In the shrinker path, > deadlock is avoided by using msm_gem_trylock() and skipping over object

Re: [PATCH v2] drm/msm: Drop mm_lock in scan loop

2021-04-02 Thread Doug Anderson
Hi, On Fri, Apr 2, 2021 at 2:08 PM Rob Clark wrote: > > From: Rob Clark > > lock_stat + mmm_donut[1] say that this reduces contention on mm_lock > significantly (~350x lower waittime-max, and ~100x lower waittime-avg) > > [1] > https://chromium.googlesource.com/chromiumos/platform/microbenchmar

Re: [PATCH v2 4/5] dt-bindings: dt-bindings: display: simple: Add N116BCA-EA1

2021-01-15 Thread Doug Anderson
Hi, On Fri, Jan 15, 2021 at 2:44 PM Douglas Anderson wrote: > > Another simple eDP panel. > > Signed-off-by: Douglas Anderson > --- > > Changes in v2: > - ("dt-bindings: dt-bindings: display: simple: Add N116BCA-EA1") new for v2. > > .../devicetree/bindings/display/panel/panel-simple.yaml

Re: [PATCH v2 3/5] drm/panel-simple: Retry if we timeout waiting for HPD

2021-01-27 Thread Doug Anderson
Hi, On Mon, Jan 25, 2021 at 12:28 PM Stephen Boyd wrote: > > > +/* > > + * Some panels simply don't always come up and need to be power cycled to > > + * work properly. We'll allow for a handful of retries. > > + */ > > +#define MAX_PANEL_PREPARE_TRIES5 > > Is this define used an

Re: [PATCH 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 bindings

2021-02-04 Thread Doug Anderson
Hi, On Sat, Jan 30, 2021 at 10:10 AM Marek Vasut wrote: > > Add DT binding document for TI SN65DSI83 DSI to LVDS bridge. > > Signed-off-by: Marek Vasut > Cc: Douglas Anderson > Cc: Laurent Pinchart > Cc: Linus Walleij > Cc: Sam Ravnborg > Cc: Stephen Boyd > Cc: devicet...@vger.kernel.org >

Re: [PATCH 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 driver

2021-02-04 Thread Doug Anderson
Hi, On Sat, Jan 30, 2021 at 10:10 AM Marek Vasut wrote: > > Add driver for TI SN65DSI83 Single-Channel DSI to Single-Link LVDS bridge. > The driver operates the chip over I2C bus. Currently the LVDS clock are > always derived from DSI clock lane, which is the usual mode of operation, > support fo

Re: [PATCH 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 bindings

2021-02-04 Thread Doug Anderson
Hi, On Thu, Feb 4, 2021 at 10:09 AM Marek Vasut wrote: > > On 2/4/21 6:15 PM, Doug Anderson wrote: > > Hi, > > [...] > > >> +properties: > >> + compatible: > >> +const: ti,sn65dsi83 > >> + > >> + reg: > &

Re: [PATCH 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 driver

2021-02-04 Thread Doug Anderson
Hi, On Thu, Feb 4, 2021 at 10:41 AM Marek Vasut wrote: > > >> +static const struct regmap_range sn65dsi83_volatile_ranges[] = { > >> + regmap_reg_range(REG_RC_LVDS_PLL, REG_RC_LVDS_PLL), > > > > Why is REG_RC_LVDS_PLL volatile? > > See register 0xa bit 7, PLL_EN_STAT . Wow, I looked at it

Re: [PATCH 1/3] drm/msm: Fix speed-bin support not to access outside valid memory

2021-03-05 Thread Doug Anderson
Hi, On Fri, Mar 5, 2021 at 2:28 AM Srinivas Kandagatla wrote: > > > > On 27/02/2021 00:26, Douglas Anderson wrote: > > When running the latest kernel on an sc7180 with KASAN I got this > > splat: > >BUG: KASAN: slab-out-of-bounds in a6xx_gpu_init+0x618/0x644 > >Read of size 4 at addr

Re: [PATCH v2 0/5] drm/panel-simple: Patches for N116BCA-EA1

2021-03-05 Thread Doug Anderson
Hi folks, On Fri, Jan 15, 2021 at 2:44 PM Douglas Anderson wrote: > > This series is to get the N116BCA-EA1 panel working. Most of the > patches are simple, but on hardware I have in front of me the panel > sometimes doesn't come up. I'm still working with the hardware > manufacturer to get to th

Re: [PATCH v2 0/5] drm/panel-simple: Patches for N116BCA-EA1

2021-03-10 Thread Doug Anderson
Hi, On Wed, Mar 10, 2021 at 3:25 PM Linus Walleij wrote: > > On Fri, Jan 15, 2021 at 11:44 PM Douglas Anderson > wrote: > > > - ("drm/panel-simple: Don't wait longer for HPD...") new for v2. > > - ("drm/panel-simple: Retry if we timeout waiting for HPD") new for v2. > > I couldn't find these pa

Re: [PATCH v2 0/5] drm/panel-simple: Patches for N116BCA-EA1

2021-03-10 Thread Doug Anderson
Hi, On Wed, Mar 10, 2021 at 4:57 PM Linus Walleij wrote: > > On Thu, Mar 11, 2021 at 12:47 AM Doug Anderson wrote: > > > I guess what I'd say in summary is: > > > > * If you object to the retries in simple panel, I still hope the rest > > of the series can

Re: [PATCH v5 09/20] drm/bridge: ti-sn65dsi86: Break GPIO and MIPI-to-eDP bridge into sub-drivers

2021-05-03 Thread Doug Anderson
Hi, On Sat, May 1, 2021 at 4:59 AM Linus Walleij wrote: > > On Fri, Apr 23, 2021 at 6:59 PM Douglas Anderson > wrote: > > > Let's use the newly minted aux bus to break up the driver into sub > > drivers. We're not doing a full breakup here: all the code is still in > > the same file and remains

Re: [PATCH v5 14/20] drm/bridge: ti-sn65dsi86: Promote the AUX channel to its own sub-dev

2021-05-03 Thread Doug Anderson
Hi, On Fri, Apr 23, 2021 at 10:00 AM Douglas Anderson wrote: > > We'd like to be able to expose the DDC-over-AUX channel bus to our > panel. This gets into a chicken-and-egg problem because: > - The panel wants to get its DDC at probe time. > - The ti-sn65dsi86 MIPI-to-eDP bridge code, which prov

Re: [PATCH v5 01/20] drm/panel: panel-simple: Add missing pm_runtime_disable() calls

2021-05-03 Thread Doug Anderson
Hi, On Sat, May 1, 2021 at 5:07 AM Linus Walleij wrote: > > Hi Doug, > > On Fri, Apr 30, 2021 at 11:04 PM Doug Anderson wrote: > > > Pushed this one patch. Rest of the series is pending adult > > supervision. Overall summary: > > > > 1. I could probably p

Re: [PATCH v3 3/4] drm/bridge: ti-sn65dsi86: Read EDID blob over DDC

2021-05-07 Thread Doug Anderson
Hi, On Tue, Mar 23, 2021 at 12:53 PM Laurent Pinchart wrote: > > Hi Doug, > > On Tue, Mar 23, 2021 at 12:07:27PM -0700, Doug Anderson wrote: > > On Mon, Mar 22, 2021 at 8:17 PM Stephen Boyd wrote: > > > > > > Quoting Laurent Pinchart (202

Re: [v3 1/2] dt-bindings: backlight: add DisplayPort aux backlight

2021-05-11 Thread Doug Anderson
Hi, On Tue, May 11, 2021 at 11:12 AM wrote: > > On 01-05-2021 03:08, Doug Anderson wrote: > > Hi, > > > > On Fri, Apr 30, 2021 at 8:10 AM wrote: > >> > >> On 30-04-2021 02:33, Doug Anderson wrote: > >> > Hi, > >> > > >>

Re: [PATCH v6 1/5] i2c: i2c-core-of: Fix corner case of finding adapter by node

2021-05-17 Thread Doug Anderson
Hi, On Mon, May 3, 2021 at 2:59 PM Douglas Anderson wrote: > > The of_find_i2c_adapter_by_node() could end up failing to find an > adapter in certain conditions. Specifically it's possible that > of_dev_or_parent_node_match() could end up finding an I2C client in > the list and cause bus_find_dev

Re: [PATCH v6 2/5] drm/dp: Allow an early call to register DDC i2c bus

2021-05-17 Thread Doug Anderson
Hi, On Fri, May 14, 2021 at 4:16 AM Jani Nikula wrote: > > On Fri, 07 May 2021, Lyude Paul wrote: > > On Fri, 2021-05-07 at 17:00 -0500, Bjorn Andersson wrote: > >> On Fri 07 May 16:18 CDT 2021, Lyude Paul wrote: > >> > >> > Adding ville from Intel to also get their take on this. > >> > > >> > I

Re: [v3 1/2] dt-bindings: backlight: add DisplayPort aux backlight

2021-05-17 Thread Doug Anderson
Hi, On Tue, May 11, 2021 at 4:17 PM Doug Anderson wrote: > > Hi, > > On Tue, May 11, 2021 at 11:12 AM wrote: > > > > On 01-05-2021 03:08, Doug Anderson wrote: > > > Hi, > > > > > > On Fri, Apr 30, 2021 at 8:10 AM wrote: > > >&g

Re: [PATCH v7 02/10] dt-bindings: display: simple: List hpd properties in panel-simple

2021-05-18 Thread Doug Anderson
Hi, On Tue, May 18, 2021 at 5:42 AM Rob Herring wrote: > > On Mon, May 17, 2021 at 3:09 PM Douglas Anderson > wrote: > > > > These are described in panel-common.yaml but if I don't list them in > > panel-simple then I get yells when running 'dt_binding_check' in a > > future patch. List them al

Re: [PATCH v7 03/10] dt-bindings: drm/bridge: ti-sn65dsi86: Add aux-bus child

2021-05-19 Thread Doug Anderson
Hi, On Wed, May 19, 2021 at 1:02 PM Rob Herring wrote: > > On Mon, May 17, 2021 at 01:09:00PM -0700, Douglas Anderson wrote: > > We want to be able to list an eDP panel as a child of a ti-sn65dsi86 > > node to represent the fact that the panel is connected to the bridge's > > DP AUX bus. Though t

Re: [PATCH v4 1/5] drm: panel: simple: Fixup the struct panel_desc kernel doc

2020-11-23 Thread Doug Anderson
Hi, On Mon, Nov 9, 2020 at 5:01 PM Douglas Anderson wrote: > > When I run: > scripts/kernel-doc -rst drivers/gpu/drm/panel/panel-simple.c > > I see that several of the kernel-doc entries aren't showing up because > they don't specify the full path down the hierarchy. Let's fix that > and also

Re: [PATCH] drm: panel: add flags to BOE NV110WTM-N61

2020-12-01 Thread Doug Anderson
Hi, On Mon, Nov 30, 2020 at 10:26 AM Sam Ravnborg wrote: > > When applying a patch to add the BOE NV110WTM-N61 panel I forgot > to add the changes that added flags to drm_display_mode. Sorry, I didn't mean to make more work for you! > Signed-off-by: Sam Ravnborg > Fixes: a96ee0f6b58d ("drm: p

Re: [PATCH] drm: panel: add flags to BOE NV110WTM-N61

2020-12-01 Thread Doug Anderson
Hi, On Tue, Dec 1, 2020 at 12:28 PM Sam Ravnborg wrote: > > Hi Doug, > > On Tue, Dec 01, 2020 at 10:53:17AM -0800, Doug Anderson wrote: > > Hi, > > > > On Mon, Nov 30, 2020 at 10:26 AM Sam Ravnborg wrote: > > > > > > When applying a patch to add

Re: [PATCH v4 1/5] drm: panel: simple: Fixup the struct panel_desc kernel doc

2020-12-01 Thread Doug Anderson
Hi, On Sun, Nov 29, 2020 at 2:10 PM Sam Ravnborg wrote: > > Hi Douglas, > On Mon, Nov 09, 2020 at 05:00:55PM -0800, Douglas Anderson wrote: > > When I run: > > scripts/kernel-doc -rst drivers/gpu/drm/panel/panel-simple.c > > > > I see that several of the kernel-doc entries aren't showing up bec

Re: [PATCH v3] drm/dbi: Print errors for mipi_dbi_command()

2021-07-08 Thread Doug Anderson
Hi, On Fri, Jul 2, 2021 at 6:58 AM Linus Walleij wrote: > > The macro mipi_dbi_command() does not report errors unless you wrap it > in another macro to do the error reporting. > > Report a rate-limited error so we know what is going on. > > Drop the only user in DRM using mipi_dbi_command() and

Re: [PATCH] drm/panel: Fix up DT bindings for Samsung lms397kf04

2021-07-08 Thread Doug Anderson
Hi, On Thu, Jul 1, 2021 at 2:38 PM Linus Walleij wrote: > > Improve the bindings and make them more usable: > > - Pick in spi-cpha and spi-cpol from the SPI node parent, > this will specify that we are "type 3" in the device tree > rather than hardcoding it in the operating system. > - Drop t

Re: [PATCH 1/2 v3] drm/panel: Add DT bindings for Samsung LMS380KF01

2021-07-08 Thread Doug Anderson
Hi, On Wed, Jul 7, 2021 at 4:45 PM Linus Walleij wrote: > > This adds device tree bindings for the Samsung Mobile Displays > LMS380KF01 RGB DPI display panel. > > Cc: devicet...@vger.kernel.org > Cc: phone-de...@vger.kernel.org > Cc: Douglas Anderson > Cc: Noralf Trønnes > Signed-off-by: Linus

Re: [PATCH 2/2 v3] drm/panel: ws2401: Add driver for WideChips WS2401

2021-07-08 Thread Doug Anderson
Hi, On Wed, Jul 7, 2021 at 4:55 PM Linus Walleij wrote: > > This adds a driver for panels based on the WideChips WS2401 display > controller. This display controller is used in the Samsung LMS380KF01 > display found in the Samsung GT-I8160 (Codina) mobile phone and > possibly others. > > As is co

  1   2   3   4   5   6   7   8   9   10   >