[PATCH 2/4] drm/tegra: dsi: Clear enable register if powered by bootloader

2022-09-29 Thread Diogo Ivo
In cases where the DSI module is left on by the bootloader some panels may fail to initialize if the enable register is not cleared before the panel's initialization sequence. Clear it and add an optional device tree property to inform the driver if this is the case. Signed-off-by: Diog

[PATCH 0/4] Add JDI LPM102A188A display panel support

2022-09-29 Thread Diogo Ivo
ppreciated. Thank you! Diogo Ivo (4): dt-bindings: display: Add bindings for JDI LPM102A188A drm/tegra: dsi: Clear enable register if powered by bootloader drm/panel: Add driver for JDI LPM102A188A arm64: dts: smaug: Add display panel node .../display/panel/jdi,lpm102a188a.yaml

[PATCH 1/4] dt-bindings: display: Add bindings for JDI LPM102A188A

2022-09-29 Thread Diogo Ivo
The LPM102A188A is a 10.2" 2560x1800 IPS panel found in the Google Pixel C. Signed-off-by: Diogo Ivo --- .../display/panel/jdi,lpm102a188a.yaml| 100 ++ 1 file changed, 100 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/pane

[PATCH 4/4] arm64: dts: smaug: Add display panel node

2022-09-29 Thread Diogo Ivo
The Google Pixel C has a JDI LPM102A188A display panel. Add a DT node for it. Tested on Pixel C. Signed-off-by: Diogo Ivo --- arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 72 +++ 1 file changed, 72 insertions(+) diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b

[PATCH 3/4] drm/panel: Add driver for JDI LPM102A188A

2022-09-29 Thread Diogo Ivo
-tegra-dragon-3.18-oreo/drivers/gpu/drm/panel/panel-jdi-lpm102a188a.c Signed-off-by: Diogo Ivo --- drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile| 1 + drivers/gpu/drm/panel/panel-jdi-lpm102a188a.c | 513 ++ 3 files changed, 525

Re: [REGRESSION] GM20B probe fails after commit 2541626cfb79

2023-01-27 Thread Diogo Ivo
On Fri, Jan 27, 2023 at 04:00:59PM +1000, Ben Skeggs wrote: > On Fri, 20 Jan 2023 at 21:37, Diogo Ivo wrote: > > > > On Wed, Jan 18, 2023 at 11:28:49AM +1000, Ben Skeggs wrote: > > > On Mon, 16 Jan 2023 at 22:27, Diogo Ivo > > > wrote: > > > > On

Re: [REGRESSION] GM20B probe fails after commit 2541626cfb79

2023-01-27 Thread Diogo Ivo
On Fri, Jan 27, 2023 at 10:03:17AM +0100, Nicolas Chauvet wrote: > I've tried to run glmark2-wayland under weston with DRI_PRIME=1, it > seems to work at the beginning, but then I have the following error: > > [ 1510.861730] nouveau 5700.gpu: gr: DATA_ERROR 0003 > [INVALID_OPERATION] ch 3

Re: [REGRESSION] GM20B probe fails after commit 2541626cfb79

2023-01-30 Thread Diogo Ivo
On Mon, Jan 30, 2023 at 08:36:06AM +1000, Ben Skeggs wrote: > On Fri, 27 Jan 2023 at 20:42, Diogo Ivo wrote: > > > > On Fri, Jan 27, 2023 at 04:00:59PM +1000, Ben Skeggs wrote: > > > On Fri, 20 Jan 2023 at 21:37, Diogo Ivo > > > wrote: > > > > >

Re: [PATCH 0/2] drm/tegra: handle implicit scanout modifiers

2023-01-30 Thread Diogo Ivo
On Tue, Jan 24, 2023 at 03:25:09PM +0100, Thierry Reding wrote: > On Fri, Jan 20, 2023 at 10:58:56AM +0000, Diogo Ivo wrote: > > Hello! > > > > This patch series adds support for correctly displaying tiled > > framebuffers when no modifiers are reported by userspace

Re: [REGRESSION] GM20B probe fails after commit 2541626cfb79

2023-01-14 Thread Diogo Ivo
On Fri, Jan 13, 2023 at 02:19:06PM +0100, Linux kernel regression tracking (Thorsten Leemhuis) wrote: > Diogo, for that it would be really helpful to known: is the issue still > happening with latest mainline? Is it possible to revert 2541626cfb79 > easily? And if so: do things work afterwards aga

Re: [REGRESSION] GM20B probe fails after commit 2541626cfb79

2023-01-14 Thread Diogo Ivo
On Sat, Jan 14, 2023 at 04:27:38AM +0100, Karol Herbst wrote: > I tried to look into it, but my jetson nano, just constantly behaves > in very strange ways. I tried to compile and install a 6.1 kernel onto > it, but any kernel just refuses to boot and I have no idea what's up > with that device. Th

Re: [REGRESSION] GM20B probe fails after commit 2541626cfb79

2023-01-16 Thread Diogo Ivo
On Mon, Jan 16, 2023 at 07:45:05AM +1000, David Airlie wrote: > On Thu, Dec 29, 2022 at 12:58 AM Diogo Ivo > wrote: > As a quick check can you try changing > > drivers/gpu/drm/nouveau/nvkm/core/firmware.c:nvkm_firmware_mem_target > from NVKM_MEM_TARGET_HOST to NVKM_MEM_TA

[PATCH 0/2] drm/tegra: handle implicit scanout modifiers

2023-01-20 Thread Diogo Ivo
buffer object passed to create a framebuffer is allocated with non-linear tiling but no modifier is reported. Diogo Ivo (2): drm/tegra: add sector layout to SET/GET_TILING IOCTLs drm/tegra: add scanout support for implicit tiling parameters drivers/gpu/drm/tegra/drm.c | 29

[PATCH 2/2] drm/tegra: add scanout support for implicit tiling parameters

2023-01-20 Thread Diogo Ivo
so that the framebuffer is correctly scanned out. Signed-off-by: Diogo Ivo --- drivers/gpu/drm/tegra/fb.c | 59 -- 1 file changed, 57 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c index 9291209154a7

[PATCH 1/2] drm/tegra: add sector layout to SET/GET_TILING IOCTLs

2023-01-20 Thread Diogo Ivo
ned-off-by: Diogo Ivo --- drivers/gpu/drm/tegra/drm.c | 29 + include/uapi/drm/tegra_drm.h | 16 ++-- 2 files changed, 39 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c index 6748ec1e0005..27afb7fa6259 10

Re: [REGRESSION] GM20B probe fails after commit 2541626cfb79

2023-01-20 Thread Diogo Ivo
On Wed, Jan 18, 2023 at 11:28:49AM +1000, Ben Skeggs wrote: > On Mon, 16 Jan 2023 at 22:27, Diogo Ivo wrote: > > On Mon, Jan 16, 2023 at 07:45:05AM +1000, David Airlie wrote: > > > As a quick check can you try changing > > > > > &g

Re: [PATCH 1/4] dt-bindings: display: Add bindings for JDI LPM102A188A

2022-10-03 Thread Diogo Ivo
On Fri, Sep 30, 2022 at 12:49:31PM +0200, Krzysztof Kozlowski wrote: > > + ts-reset-gpios: > > +maxItems: 1 > > +description: | > > + Specifier for a GPIO connected to the touchscreen reset control > > signal. > > + The reset signal is active low. > > Isn't touchscreen a separa

Re: [PATCH 2/4] drm/tegra: dsi: Clear enable register if powered by bootloader

2022-10-03 Thread Diogo Ivo
On Fri, Sep 30, 2022 at 01:11:10PM +0200, Thierry Reding wrote: > On Thu, Sep 29, 2022 at 06:05:00PM +0100, Diogo Ivo wrote: > > + > > err = tegra_dsi_prepare(dsi); > > if (err < 0) { > > dev_err(dsi->dev, "failed to prepare: %d\n",

Re: [PATCH 1/4] dt-bindings: display: Add bindings for JDI LPM102A188A

2022-10-04 Thread Diogo Ivo
On Tue, Oct 04, 2022 at 01:05:04PM +0200, Krzysztof Kozlowski wrote: > On 03/10/2022 19:06, Diogo Ivo wrote: > > On Fri, Sep 30, 2022 at 12:49:31PM +0200, Krzysztof Kozlowski wrote: > >> Isn't touchscreen a separate (input) device? > > > > Hello, thank you for

[PATCH v2 RESEND 4/4] arm64: dts: smaug: Add display panel node

2022-11-28 Thread Diogo Ivo
The Google Pixel C has a JDI LPM102A188A display panel. Add a DT node for it. Tested on Pixel C. Signed-off-by: Diogo Ivo --- Changes in v2: - renamed backlight node to a generic name - removed underscores arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 70 +++ 1 file changed

[PATCH v2 RESEND 2/4] drm/tegra: dsi: Clear enable register if powered by bootloader

2022-11-28 Thread Diogo Ivo
In cases where the DSI module is left on by the bootloader some panels may fail to initialize if the enable register is not cleared before the panel's initialization sequence is sent, so clear it if that is the case. Signed-off-by: Diogo Ivo --- Changes in v2: - detect if the DSI module

[PATCH v2 RESEND 0/4] Add JDI LPM102A188A display panel support

2022-11-28 Thread Diogo Ivo
backlight delay values - Patch 4: add generic node names, remove underscores Thank you. Diogo Ivo (4): dt-bindings: display: Add bindings for JDI LPM102A188A drm/tegra: dsi: Clear enable register if powered by bootloader drm/panel: Add driver for JDI LPM102A188A arm64: dts: smaug: Add display

[PATCH v2 RESEND 3/4] drm/panel: Add driver for JDI LPM102A188A

2022-11-28 Thread Diogo Ivo
-tegra-dragon-3.18-oreo/drivers/gpu/drm/panel/panel-jdi-lpm102a188a.c Signed-off-by: Diogo Ivo --- Changes in v2: - tuned backlight delays drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile| 1 + drivers/gpu/drm/panel/panel-jdi-lpm102a188a.c | 509

[PATCH v2 0/4] Add JDI LPM102A188A display panel support

2022-10-25 Thread Diogo Ivo
v2: - Patch 1: remove touchscreen reset gpio property - Patch 2: clear register based on its value rather than a DT property - Patch 3: tune backlight delay values - Patch 4: add generic node names, remove underscores Thank you. Diogo Ivo (4): dt-bindings: display: Add bindings for JDI

[PATCH v2 1/4] dt-bindings: display: Add bindings for JDI LPM102A188A

2022-10-25 Thread Diogo Ivo
The LPM102A188A is a 10.2" 2560x1800 IPS panel found in the Google Pixel C. Signed-off-by: Diogo Ivo --- Changes in v2: - removed the touch screen property .../display/panel/jdi,lpm102a188a.yaml| 94 +++ 1 file changed, 94 insertions(+) create mode 1

[PATCH v2 2/4] drm/tegra: dsi: Clear enable register if powered by bootloader

2022-10-25 Thread Diogo Ivo
In cases where the DSI module is left on by the bootloader some panels may fail to initialize if the enable register is not cleared before the panel's initialization sequence is sent, so clear it if that is the case. Signed-off-by: Diogo Ivo --- Changes in v2: - detect if the DSI module

[PATCH v2 3/4] drm/panel: Add driver for JDI LPM102A188A

2022-10-25 Thread Diogo Ivo
-tegra-dragon-3.18-oreo/drivers/gpu/drm/panel/panel-jdi-lpm102a188a.c Signed-off-by: Diogo Ivo --- Changes in v2: - tuned backlight delays drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile| 1 + drivers/gpu/drm/panel/panel-jdi-lpm102a188a.c | 509

[PATCH v2 4/4] arm64: dts: smaug: Add display panel node

2022-10-25 Thread Diogo Ivo
The Google Pixel C has a JDI LPM102A188A display panel. Add a DT node for it. Tested on Pixel C. Signed-off-by: Diogo Ivo --- Changes in v2: - renamed backlight node to a generic name - removed underscores arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 70 +++ 1 file changed

Re: [PATCH v2 RESEND 0/4] Add JDI LPM102A188A display panel support

2022-12-22 Thread Diogo Ivo
On Mon, Nov 28, 2022 at 04:28:48PM +, Diogo Ivo wrote: > Hello, > > These patches add support for the JDI LPM102A188A display panel, > found in the Google Pixel C. Hello, Gentle ping on this series. Thank you, Diogo Ivo

Re: [v2,3/4] drm/panel: Add driver for JDI LPM102A188A

2022-12-27 Thread Diogo Ivo
Hello, On Fri, Dec 23, 2022 at 03:33:40PM +, Rayyan Ansari wrote: > On 25/10/2022 16:37, Diogo Ivo wrote: > > +config DRM_PANEL_JDI_LPM102A188A > > + tristate "JDI LPM102A188A DSI panel" > > + depends on OF && GPIOLIB > > +

[REGRESSION] GM20B probe fails after commit 2541626cfb79

2022-12-28 Thread Diogo Ivo
#regzbot introduced: 2541626cfb79 Thanks, Diogo Ivo

Re: [PATCH v2 0/4] Add JDI LPM102A188A display panel support

2023-01-09 Thread Diogo Ivo
On Tue, Oct 25, 2022 at 04:37:43PM +0100, Diogo Ivo wrote: > Hello, > > These patches add support for the JDI LPM102A188A display panel, > found in the Google Pixel C. > > Patch 1 adds the DT bindings for the panel. > > Patch 2 adds a register clear to the Tegra DS

[PATCH v2 0/2] Enable GPU on Smaug

2023-05-16 Thread Diogo Ivo
@tecnico.ulisboa.pt/ V1 -> V2: - Patch 1: Use generic DT node name for regulator and GPIO flag defines. Best regards, Diogo Ivo (2): arm64: dts: tegra: smaug: add GPU power rail regulator arm64: dts: tegra: smaug: add GPU node arch/arm64/boot/dts/nvidia/tegra210-smaug.dts |

[PATCH v2 2/2] arm64: dts: tegra: smaug: add GPU node

2023-05-16 Thread Diogo Ivo
Enable the GPU on the Pixel C. Signed-off-by: Diogo Ivo --- arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts index 929372f24339..db25f3ae8e0b

[PATCH v2 1/2] arm64: dts: tegra: smaug: add GPU power rail regulator

2023-05-16 Thread Diogo Ivo
Add the GPU power rail regulator node for the Pixel C. Signed-off-by: Diogo Ivo --- V1 -> V2: Use generic DT node name and GPIO flag defines (Krzysztof Kozlowski) arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 17 + 1 file changed, 17 insertions(+) diff --git a/a

Re: [PATCH v2 0/2] Enable GPU on Smaug

2023-06-07 Thread Diogo Ivo
On Tue, May 16, 2023 at 09:28:27AM +0100, Diogo Ivo wrote: > Hello, > > This patch series enables the use of the GM20B GPU in the > Google Pixel C. > > Patch 1 adds the needed regulator DT node for the GPU. > > Patch 2 enables the GPU in the DT. Hello, Gentle ping on t

[PATCH v3 0/5] Add JDI LPM102A188A display panel support

2023-08-07 Thread Diogo Ivo
Reviewed-by - Patch 2: fix error handling, remove enabled/prepared booleans, add dc/dc setting - Patches 3-5: Split previous patch 3 into three different patches, each adding a separate node - removed previous patch 2 pertaining to Tegra DSI reset as it was upstreamed Diogo Ivo (5): dt

[PATCH v3 2/5] drm/panel: Add driver for JDI LPM102A188A

2023-08-07 Thread Diogo Ivo
-tegra-dragon-3.18-oreo/drivers/gpu/drm/panel/panel-jdi-lpm102a188a.c Signed-off-by: Diogo Ivo --- Changes in v2: - tuned backlight delays Changed in v3: - removed "-dsi" from driver name, renamed "control"->"command" (Rayyan Ansari) - fix error handling - remove

[PATCH v3 1/5] dt-bindings: display: Add bindings for JDI LPM102A188A

2023-08-07 Thread Diogo Ivo
The LPM102A188A is a 10.2" 2560x1800 IPS panel found in the Google Pixel C. Signed-off-by: Diogo Ivo Reviewed-by: Krzysztof Kozlowski --- Changes in v2: - removed the touch screen property Changes in v3: - add Reviewed-by from Krzysztof Kozlowski .../display/panel/jdi,lpm102a188a

[REGRESSION] GM20B pmu timeout

2024-10-10 Thread Diogo Ivo
Hello, Somewhere between 6.11-rc4 and 6.11-rc5 the following error message is displayed when trying to initialize a nvc0_screen on the Tegra X1's GM20B: [ 34.431210] nouveau 5700.gpu: pmu:hpq: timeout waiting for queue ready [ 34.438145] nouveau 5700.gpu: gr: init failed, -110 nvc0_screen

Re: [REGRESSION] GM20B pmu timeout

2024-11-04 Thread Diogo Ivo
Hello, On Tue Oct 15, 2024 at 7:13 PM WEST, Linux regression tracking (Thorsten Leemhuis) wrote: > Hi, Thorsten here, the Linux kernel's regression tracker. > > On 10.10.24 15:32, Diogo Ivo wrote: > > > > Somewhere between 6.11-rc4 and 6.11-rc5 the following error

Re: [REGRESSION] GM20B pmu timeout

2024-11-13 Thread Diogo Ivo
Hi Dave, On Tue Nov 12, 2024 at 7:59 PM WET, Dave Airlie wrote: > On Tue, 12 Nov 2024 at 22:34, Linux regression tracking (Thorsten > Leemhuis) wrote: > > > > [CCing Danilo, who committed the culprit] > > > > On 04.11.24 13:11, Diogo Ivo wrote: > > > On

Re: [REGRESSION] GM20B pmu timeout

2024-10-25 Thread Diogo Ivo
Hi Thorsten, On Tue Oct 15, 2024 at 7:13 PM WEST, Linux regression tracking (Thorsten Leemhuis) wrote: > Hi, Thorsten here, the Linux kernel's regression tracker. > > On 10.10.24 15:32, Diogo Ivo wrote: > > > > Somewhere between 6.11-rc4 and 6.11-rc5 the

Re: [PATCH rc] gpu: host1x: Do not assume that a NULL domain means no DMA IOMMU

2025-03-15 Thread Diogo Ivo
ix as seen in commit fae6e669cdc5 ("drm/tegra: Do not assume that a NULL domain means no DMA IOMMU"). Fixes: c8cc2655cc6c ("iommu/tegra-smmu: Implement an IDENTITY domain") Reported-by: Diogo Ivo Closes: https://lore.kernel.org/all/c6a6f114-3acd-4d56-a13b-b88978e92...@tecn

Re: [PATCH rc] gpu: host1x: Do not assume that a NULL domain means no DMA IOMMU

2025-02-13 Thread Diogo Ivo
en in commit fae6e669cdc5 ("drm/tegra: Do not assume that a NULL domain means no DMA IOMMU"). Fixes: c8cc2655cc6c ("iommu/tegra-smmu: Implement an IDENTITY domain") Reported-by: Diogo Ivo Closes: https://lore.kernel.org/all/c6a6f114-3acd-4d56-a13b-b88978e92...@tecnico.ulisboa

Re: [PATCH 0/3] NVIDIA Tegra210 NVJPG support

2025-06-16 Thread Diogo Ivo
On 6/12/25 2:55 AM, Mikko Perttunen wrote: On 6/12/25 12:06 AM, Thierry Reding wrote: On Wed, Jun 11, 2025 at 01:05:40PM +0100, Diogo Ivo wrote: I have a question here, what exactly are the stream IDs? While working on the driver this came up and I didn't manage to figure it out. S

Re: [PATCH 0/3] NVIDIA Tegra210 NVJPG support

2025-06-16 Thread Diogo Ivo
On 6/11/25 4:10 PM, Thierry Reding wrote: On Wed, Jun 11, 2025 at 01:04:14PM +0100, Diogo Ivo wrote: On 6/10/25 10:05 AM, Thierry Reding wrote: On Fri, Jun 06, 2025 at 11:45:33AM +0100, Diogo Ivo wrote: Hello, This series adds support for the NVJPG hardware accelerator found in the

Re: [PATCH 0/3] NVIDIA Tegra210 NVJPG support

2025-06-16 Thread Diogo Ivo
On 6/11/25 4:06 PM, Thierry Reding wrote: On Wed, Jun 11, 2025 at 01:05:40PM +0100, Diogo Ivo wrote: On 6/10/25 10:52 AM, Mikko Perttunen wrote: On 6/10/25 6:05 PM, Thierry Reding wrote: On Fri, Jun 06, 2025 at 11:45:33AM +0100, Diogo Ivo wrote: Hello, This series adds support for the

Re: [PATCH 0/3] NVIDIA Tegra210 NVJPG support

2025-06-17 Thread Diogo Ivo
On 6/17/25 5:40 AM, Mikko Perttunen wrote: On 6/16/25 7:21 PM, Diogo Ivo wrote: On 6/11/25 4:06 PM, Thierry Reding wrote: On Wed, Jun 11, 2025 at 01:05:40PM +0100, Diogo Ivo wrote: On 6/10/25 10:52 AM, Mikko Perttunen wrote: On 6/10/25 6:05 PM, Thierry Reding wrote: On Fri, Jun 06

[PATCH 0/3] NVIDIA Tegra210 NVJPG support

2025-06-06 Thread Diogo Ivo
: Krzysztof Kozlowski To: Conor Dooley Cc: linux-ker...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: linux-te...@vger.kernel.org Cc: devicet...@vger.kernel.org Signed-off-by: Diogo Ivo [1]: https://gitlab.freedesktop.org/d.ivo/mesa/-/tree/diogo/vaapi_gl?ref_type=heads --- Diogo Ivo

[PATCH 1/3] drm/tegra: Add NVJPG driver

2025-06-06 Thread Diogo Ivo
Add support for booting and using NVJPG on Tegra210 to the Host1x and TegraDRM drivers. This driver only supports the new TegraDRM uAPI. Signed-off-by: Diogo Ivo --- drivers/gpu/drm/tegra/Makefile | 1 + drivers/gpu/drm/tegra/drm.c| 2 + drivers/gpu/drm/tegra/drm.h| 1 + drivers

[PATCH 3/3] arm64: tegra: Add NVJPG node

2025-06-06 Thread Diogo Ivo
The Tegra X1 chip contains a NVJPG accelerator capable of encoding/decoding JPEG files in hardware, so add its DT node. Signed-off-by: Diogo Ivo --- arch/arm64/boot/dts/nvidia/tegra210.dtsi | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/nvidia

[PATCH 2/3] arm64: tegra: Add NVJPG power-domain node

2025-06-06 Thread Diogo Ivo
Add the NVJPG power-domain node in order to support the NVJPG accelerator. Signed-off-by: Diogo Ivo --- arch/arm64/boot/dts/nvidia/tegra210.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi b/arch/arm64/boot/dts/nvidia/tegra210.dtsi index

Re: [PATCH 0/3] NVIDIA Tegra210 NVJPG support

2025-06-11 Thread Diogo Ivo
On 6/10/25 10:52 AM, Mikko Perttunen wrote: On 6/10/25 6:05 PM, Thierry Reding wrote: On Fri, Jun 06, 2025 at 11:45:33AM +0100, Diogo Ivo wrote: Hello, This series adds support for the NVJPG hardware accelerator found in the Tegra210 SoC. The kernel driver is essentially a copy of the

Re: [PATCH 1/3] drm/tegra: Add NVJPG driver

2025-06-11 Thread Diogo Ivo
Hi Mikko, thanks for the quick review! On 6/10/25 4:26 AM, Mikko Perttunen wrote: On 6/6/25 7:45 PM, Diogo Ivo wrote: Add support for booting and using NVJPG on Tegra210 to the Host1x and TegraDRM drivers. This driver only supports the new TegraDRM uAPI. Hello Diogo -- I'm happy t

Re: [PATCH 2/3] arm64: tegra: Add NVJPG power-domain node

2025-06-11 Thread Diogo Ivo
On 6/10/25 5:57 AM, Mikko Perttunen wrote: On 6/6/25 7:45 PM, Diogo Ivo wrote: Add the NVJPG power-domain node in order to support the NVJPG accelerator. Signed-off-by: Diogo Ivo --- arch/arm64/boot/dts/nvidia/tegra210.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch

Re: [PATCH 0/3] NVIDIA Tegra210 NVJPG support

2025-06-11 Thread Diogo Ivo
On 6/10/25 9:58 AM, Thierry Reding wrote: On Fri, Jun 06, 2025 at 11:45:33AM +0100, Diogo Ivo wrote: Hello, This series adds support for the NVJPG hardware accelerator found in the Tegra210 SoC. The kernel driver is essentially a copy of the NVDEC driver as both engines are Falcon-based

Re: [PATCH 3/3] arm64: tegra: Add NVJPG node

2025-06-11 Thread Diogo Ivo
On 6/10/25 6:01 AM, Mikko Perttunen wrote: On 6/6/25 7:45 PM, Diogo Ivo wrote: The Tegra X1 chip contains a NVJPG accelerator capable of encoding/decoding JPEG files in hardware, so add its DT node. Signed-off-by: Diogo Ivo --- arch/arm64/boot/dts/nvidia/tegra210.dtsi | 8 +++- 1

Re: [PATCH 0/3] NVIDIA Tegra210 NVJPG support

2025-06-11 Thread Diogo Ivo
On 6/10/25 10:05 AM, Thierry Reding wrote: On Fri, Jun 06, 2025 at 11:45:33AM +0100, Diogo Ivo wrote: Hello, This series adds support for the NVJPG hardware accelerator found in the Tegra210 SoC. The kernel driver is essentially a copy of the NVDEC driver as both engines are Falcon-based

[PATCH v2 0/3] NVIDIA Tegra210 NVJPG support

2025-06-11 Thread Diogo Ivo
: Krzysztof Kozlowski To: Conor Dooley Cc: linux-ker...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: linux-te...@vger.kernel.org Cc: devicet...@vger.kernel.org Signed-off-by: Diogo Ivo [1]: https://gitlab.freedesktop.org/d.ivo/mesa/-/tree/diogo/vaapi_gl?ref_type=heads --- Changes in

[PATCH v2 2/3] arm64: tegra: Add Tegra210 NVJPG power-domain node

2025-06-11 Thread Diogo Ivo
Add the NVJPG power-domain node in order to support the NVJPG accelerator in Tegra210 platforms. Reviewed-by: Mikko Perttunen Signed-off-by: Diogo Ivo --- v1->v2: - Collect R-b from Mikko - Explicitly mention Tegra210 in commit subject --- arch/arm64/boot/dts/nvidia/tegra210.dtsi

[PATCH v2 3/3] arm64: tegra: Add NVJPG node for Tegra210 platforms

2025-06-11 Thread Diogo Ivo
The Tegra X1 chip contains a NVJPG accelerator capable of encoding/decoding JPEG files in hardware. Complete its DT node and enable it. Reviewed-by: Mikko Perttunen Signed-off-by: Diogo Ivo --- v1->v2: - Collect R-b from Mikko - Explicitly mention Tegra210 in commit subject - Be more prec

Re: [PATCH 1/3] drm/tegra: Add NVJPG driver

2025-06-11 Thread Diogo Ivo
Hi Thierry, On 6/10/25 9:44 AM, Thierry Reding wrote: On Tue, Jun 10, 2025 at 12:26:07PM +0900, Mikko Perttunen wrote: On 6/6/25 7:45 PM, Diogo Ivo wrote: Add support for booting and using NVJPG on Tegra210 to the Host1x and TegraDRM drivers. This driver only supports the new TegraDRM uAPI

[PATCH v2 1/3] drm/tegra: Add NVJPG driver

2025-06-11 Thread Diogo Ivo
Add support for booting and using NVJPG on Tegra210 to the Host1x and TegraDRM drivers. This driver only supports the new TegraDRM uAPI. Signed-off-by: Diogo Ivo --- v1->v2: - Removed explicit reset handling, leaving it to power-domain code - Set clock rate to maximum upon getting clock -

Re: [PATCH v3 2/4] drm/panel: jdi-lpm102a188a: Fix bug and clean up driver

2025-07-17 Thread Diogo Ivo
Hi Brigham, thanks for the patch! The code looks a lot cleaner. Some review follows. On 7/17/25 7:57 AM, Brigham Campbell wrote: Fix bug in unprepare() which causes the function's return value to be that of the last mipi "enter sleep mode" command. Update driver to use the "multi" variant of MI

Re: [PATCH v4 2/4] drm/panel: jdi-lpm102a188a: Fix bug and clean up driver

2025-07-19 Thread Diogo Ivo
On 7/18/25 5:11 PM, Doug Anderson wrote: Hi, On Thu, Jul 17, 2025 at 9:41 AM Brigham Campbell wrote: static int jdi_panel_prepare(struct drm_panel *panel) { struct jdi_panel *jdi = to_panel_jdi(panel); + struct mipi_dsi_multi_context dsi_ctx = { .accum_err = 0 }; nit:

Re: [PATCH v4 2/4] drm/panel: jdi-lpm102a188a: Fix bug and clean up driver

2025-07-20 Thread Diogo Ivo
On 7/20/25 8:50 AM, Brigham Campbell wrote: On Sat Jul 19, 2025 at 11:10 AM MDT, Diogo Ivo wrote: nit: can just be this: struct mipi_dsi_multi_context dsi_ctx = {}; I am not an expert here but I was under the impression that this is only valid with C23 while the kernel is written in C11

Re: [PATCH 0/3] NVIDIA Tegra210 NVJPG support

2025-06-30 Thread Diogo Ivo
Hi Mikko, On 6/30/25 7:14 AM, Mikko Perttunen wrote: On 6/17/25 6:26 PM, Diogo Ivo wrote: On 6/17/25 5:40 AM, Mikko Perttunen wrote: On 6/16/25 7:21 PM, Diogo Ivo wrote: On 6/11/25 4:06 PM, Thierry Reding wrote: On Wed, Jun 11, 2025 at 01:05:40PM +0100, Diogo Ivo wrote: On 6/10

[PATCH v3 0/3] NVIDIA Tegra210 NVJPG support

2025-06-30 Thread Diogo Ivo
: Krzysztof Kozlowski To: Conor Dooley Cc: linux-ker...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: linux-te...@vger.kernel.org Cc: devicet...@vger.kernel.org Signed-off-by: Diogo Ivo [1]: https://gitlab.freedesktop.org/d.ivo/mesa/-/tree/diogo/vaapi_gl?ref_type=heads --- Changes in

[PATCH v3 2/3] arm64: tegra: Add Tegra210 NVJPG power-domain node

2025-06-30 Thread Diogo Ivo
Add the NVJPG power-domain node in order to support the NVJPG accelerator in Tegra210 platforms. Reviewed-by: Mikko Perttunen Signed-off-by: Diogo Ivo --- v1->v2: - Collect R-b from Mikko - Explicitly mention Tegra210 in commit subject --- arch/arm64/boot/dts/nvidia/tegra210.dtsi

[PATCH v3 3/3] arm64: tegra: Add NVJPG node for Tegra210 platforms

2025-06-30 Thread Diogo Ivo
The Tegra X1 chip contains a NVJPG accelerator capable of encoding/decoding JPEG files in hardware. Complete its DT node and enable it. Reviewed-by: Mikko Perttunen Signed-off-by: Diogo Ivo --- v1->v2: - Collect R-b from Mikko - Explicitly mention Tegra210 in commit subject - Be more prec

[PATCH v3 1/3] drm/tegra: Add NVJPG driver

2025-06-30 Thread Diogo Ivo
Add support for booting and using NVJPG on Tegra210 to the Host1x and TegraDRM drivers. This driver only supports the new TegraDRM uAPI. Acked-by: Mikko Perttunen Signed-off-by: Diogo Ivo --- v2->v3: - Properly handle dma_alloc_coherent error path by checking for a valid return pointer

Re: [PATCH v4 2/4] drm/panel: jdi-lpm102a188a: Fix bug and clean up driver

2025-07-18 Thread Diogo Ivo
ng and remove the panel's dependency on deprecated MIPI functions. Use the new mipi_dsi_dual macro to reduce code duplication. Signed-off-by: Brigham Campbell Reviewed-by: Diogo Ivo Tested-by: Diogo Ivo Thanks for the patch! Just the smallest of nits in the review but it'