Since a DRM function that reads link DP link status is available, let's
use that instead of the i915 clone.
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/i915/intel_dp.c | 15 +++
drivers/gpu/drm/i915/intel_dp_link_training.c | 11 ---
drivers/gp
Currently we do not print the training pattern used in any of the DP link
training stages. Including this piece of information in debug messages will
help debugging.
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/i915/intel_dp.c | 13 +++--
1 file changed, 7 insertions(+), 6
We do not currently output enough information to help debugging DP link
training issues. For e.g., training pattern and link status information.
This series aims to correct that by adding debug messages that can help
developers.
Dhinakaran Pandiyan (4):
drm/i915/dp: Add debug messages to print
A full dump of link status can be handy in debugging link training
failures. Let's add that to the debug messages when link training fails.
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/i915/intel_dp_link_training.c | 11 +++
drivers/gpu/drm/i915/intel_drv.h
avoid that with these debug
messages in drm.
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_dp_helper.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
index 091053e..d763b57 100644
DRM_DEBUG_KMS.
DRM_DEBUG_DISPLAY will specifically address such cases where the developer
wants communicate why a display related configuration choice was made.
Signed-off-by: Dhinakaran Pandiyan
Cc: Chris Wilson
---
include/drm/drmP.h | 9 +
1 file changed, 9 insertions(+)
diff --git a
to do this on every encoder->update_pipe
> > callback.
> >
> > Changes in v2:
> > -Merge the patches adding the intel_psr_enable() and
> > intel_edp_drrs_enable()
> > calls into a single patch
> >
> > Reviewed-by: Maarten Lankhorst
> > Signed
t enable_psr is handled
> and
> update the module parameter string to match the actual functionality.
>
> Cc: Dhinakaran Pandiyan
> Cc: Rodrigo Vivi
> Signed-off-by: Ross Zwisler
> ---
> drivers/gpu/drm/i915/i915_drv.h| 1 -
> drivers/gpu/drm/i915/i915_params.c |
On Thu, 2018-12-20 at 15:13 -0800, Dhinakaran Pandiyan wrote:
> On Thu, 2018-12-20 at 09:10 -0800, Rodrigo Vivi wrote:
> > On Thu, Dec 20, 2018 at 02:21:20PM +0100, Hans de Goede wrote:
> > > Call intel_psr_enable() and intel_edp_drrs_enable() on pipe
> > > updates
>
track of the encoder IDs.
Cc: José Roberto de Souza
Cc: Ville Syrjälä
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Dhinakaran Pandiyan
---
include/drm/drm_connector.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_connector.h b/include/drm
On Wed, 2019-06-26 at 16:31 +0200, Daniel Vetter wrote:
> On Wed, Jun 26, 2019 at 04:43:28PM +0300, Ville Syrjälä wrote:
> > On Tue, Jun 25, 2019 at 04:40:45PM -0700, Dhinakaran Pandiyan wrote:
> > > Currently we restrict the number of encoders that can be linked to
>
On Sat, 2019-09-07 at 00:21 -0700, Dhinakaran Pandiyan wrote:
> Gen-12 has a new compression format, add a new modifier to indicate that.
>
> Cc: Ville Syrjälä
> Cc: Matt Roper
> Cc: Nanley G Chery
> Cc: Jason Ekstrand
Cc: dri-devel@lists.freedesktop.org
> Signed-off-by
gic for connector-crtc switching case (Daniel)
Fixed logic for suspend-resume case.
Cc: Daniel Vetter
Cc: Maarten Lankhorst
Cc: Archit Taneja
Cc: Chris Wilson
Cc: Harry Wentland
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/i915/intel_dp_mst.c | 48 +++
el)
Cc: Daniel Vetter
Cc: Maarten Lankhorst
Cc: Archit Taneja
Cc: Chris Wilson
Cc: Harry Wentland
Acked-by: Harry Wentland
Suggested-by: Daniel Vetter
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_atomic.c| 65 ++
drivers/gpu/drm/drm_atomi
k.
v3: WARN_ON() if connection_mutex is not held (Archit)
v2: Included kernel doc, moved state initialization and switched to
kmemdup() for allocation (Daniel)
Cc: Daniel Vetter
Cc: Maarten Lankhorst
Cc: Archit Taneja
Cc: Chris Wilson
Cc: Harry Wentland
Reviewed-by: Maarten Lankhorst
Signed-off
ten Lankhorst
Reviewed-by: Daniel Vetter
Suggested-by: Daniel Vetter
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_atomic_helper.c | 19 +++
include/drm/drm_modeset_helper_vtables.h | 16
2 files changed, 35 insertions(+)
diff
nd
Reviewed-by: Maarten Lankhorst
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_dp_mst_topology.c | 75 +++
include/drm/drm_dp_mst_helper.h | 6 +++
2 files changed, 81 insertions(+)
diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c
b/drivers/gpu/d
Changes in this version:
Included the 5 left over patches. Patches 1 and 5 have changed, so
I have removed Maarten's R-B for patch 5.
1/5: Added NULL checks
5/5: Fixed vcpi slot accounting when atomic_release() is called multiple
times within an atomic_check()
This series
y Wentland
Reviewed-by: Maarten Lankhorst
Reviewed-by: Daniel Vetter
Suggested-by: Daniel Vetter
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_atomic_helper.c | 22 ++
include/drm/drm_modeset_helper_vtables.h | 20
2 files changed, 42 in
k.
v3: WARN_ON() if connection_mutex is not held (Archit)
v2: Included kernel doc, moved state initialization and switched to
kmemdup() for allocation (Daniel)
Cc: Daniel Vetter
Cc: Maarten Lankhorst
Cc: Archit Taneja
Cc: Chris Wilson
Cc: Harry Wentland
Reviewed-by: Maarten Lankhorst
Signed-off
rator to filter private objects (Daniel)
Cc: Daniel Vetter
Cc: Maarten Lankhorst
Cc: Archit Taneja
Cc: Chris Wilson
Cc: Harry Wentland
Acked-by: Harry Wentland
Suggested-by: Daniel Vetter
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_atomic.c| 65 +
quashed atomic_release() implementation and caller (Daniel)
Fixed logic for connector-crtc switching case (Daniel)
Fixed logic for suspend-resume case.
Cc: Daniel Vetter
Cc: Maarten Lankhorst
Cc: Archit Taneja
Cc: Chris Wilson
Cc: Harry Wentland
Signed-off-by: Dhinakaran Pandiyan
---
to not depend on current allocation
Cc: Daniel Vetter
Cc: Maarten Lankhorst
Cc: Archit Taneja
Cc: Chris Wilson
Cc: Harry Wentland
Reviewed-by: Maarten Lankhorst
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_dp_mst_topology.c | 76 +++
include
_helper_vtables.h
> b/include/drm/drm_modeset_helper_vtables.h
> >>> index b304950b402d..7b5dd909f189 100644
> >>> --- a/include/drm/drm_modeset_helper_vtables.h
> >>> +++ b/include/drm/drm_modeset_helper_vtables.h
> >>> @@ -860,6 +860,43 @@ s
k.
v3: WARN_ON() if connection_mutex is not held (Archit)
v2: Included kernel doc, moved state initialization and switched to
kmemdup() for allocation (Daniel)
Cc: Daniel Vetter
Cc: Maarten Lankhorst
Cc: Archit Taneja
Cc: Chris Wilson
Cc: Harry Wentland
Reviewed-by: Maarten Lankhorst
Signed-off
Changes in this version:
Used connector->atomic_check() to release vcpi slots instead of the
atomic_release() callback.
This series introduces void * type driver-private objects in core and adds
helper functions that operate on these private objects. Drivers need to
implement object-specific funct
rator to filter private objects (Daniel)
Cc: Daniel Vetter
Cc: Maarten Lankhorst
Cc: Archit Taneja
Cc: Chris Wilson
Cc: Harry Wentland
Acked-by: Harry Wentland
Suggested-by: Daniel Vetter
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_atomic.c| 65 +
to not depend on current allocation
Cc: Daniel Vetter
Cc: Maarten Lankhorst
Cc: Archit Taneja
Cc: Chris Wilson
Cc: Harry Wentland
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_dp_mst_topology.c | 75 +++
include/drm/drm_dp_mst_helper.h | 6
ilson
Cc: Harry Wentland
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/i915/intel_dp_mst.c | 57 +
1 file changed, 51 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c
b/drivers/gpu/drm/i915/intel_dp_mst.c
index 5af22a7..20c
rator to filter private objects (Daniel)
Cc: Daniel Vetter
Cc: Maarten Lankhorst
Cc: Archit Taneja
Cc: Chris Wilson
Cc: Harry Wentland
Acked-by: Harry Wentland
Suggested-by: Daniel Vetter
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_atomic.c| 65 +++
Taneja
Cc: Chris Wilson
Cc: Harry Wentland
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/i915/intel_dp_mst.c | 48 -
1 file changed, 42 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c
b/drivers/gpu/drm/i915/int
Taneja
Cc: Chris Wilson
Cc: Harry Wentland
Acked-by: Harry Wentland
Reviewed-by: Maarten Lankhorst
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/i915/intel_dp_mst.c | 48 -
1 file changed, 42 insertions(+), 6 deletions(-)
diff --git a/drivers/gp
to not depend on current allocation
Cc: Daniel Vetter
Cc: Maarten Lankhorst
Cc: Archit Taneja
Cc: Chris Wilson
Cc: Harry Wentland
Reviewed-by: Maarten Lankhorst
Reviewed-by: Harry Wentland
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_dp_mst_topology.c | 75
Resending for CI.
Pandiyan, Dhinakaran (4):
drm: Add driver-private objects to atomic state
drm/dp: Introduce MST topology state to track available link bandwidth
drm/dp: Add DP MST helpers to atomically find and release vcpi slots
drm/dp: Track MST link bandwidth
drivers/gpu/drm/drm_ato
iewed-by: Harry Wentland
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_dp_mst_topology.c | 75 +++
include/drm/drm_dp_mst_helper.h | 20 ++
2 files changed, 95 insertions(+)
diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c
b/
t
Suggested-by: Daniel Vetter
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_atomic.c| 65 +
drivers/gpu/drm/drm_atomic_helper.c | 5 ++
include/drm/drm_atomic.h| 95 +
3 files changed, 165 insertions(+
Having a ->atomic_release callback is useful to release shared resources
that get allocated in compute_config().
Suggested-by: Daniel Vetter
Signed-off-by: Dhinakaran Pandiyan
---
include/drm/drm_modeset_helper_vtables.h | 15 +++
1 file changed, 15 insertions(+)
diff --gi
Implement the ->atomic_release() callback to release the shared link
bandwidth that was originally acquired during compute_config()
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/i915/intel_dp_mst.c | 28
1 file changed, 28 insertions(+)
diff --gi
more descriptive.
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_dp_mst_topology.c | 16
include/drm/drm_dp_mst_helper.h | 12
2 files changed, 8 insertions(+), 20 deletions(-)
diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c
b/drivers/gp
struct drm_dp_mst_topology_mgr currently stores a pointer to struct dev.
Changing this to instead hold a pointer to drm_device is more useful as it
gives access to DRM structures. This also makes it consistent with other
DRM structures like drm_crtc, drm_connector etc.
Signed-off-by: Dhinakaran
helper callback ->atomic_release() when CRTCs are disabled.
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_atomic_helper.c | 9 -
drivers/gpu/drm/i915/intel_dp_mst.c | 13 -
2 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/driver
needs to be done during the atomic_check phase to avoid failed
modesets. Let's encsapsulate the available link bw information in a
private state structure so that bw can be allocated and released atomically
for each of the ports sharing the primary link.
Signed-off-by: Dhinakaran Pan
e port.
drm_dp_atomic_release_vcpi_slots() should be called from
->atomic_check() to release a port's vcpi slot allocation from the
state.
Drivers that do not make use of this atomic helper are expected to call
drm_dp_find_vcpi_slots() instead before calling
drm_dp_mst_allocate_vcpi().
Signed-off-by: Dhina
erent types can be managed in the same state array.
This series also includes some necessary cleanups.
Dhinakaran Pandiyan (9):
drm/dp: Store drm_device in MST topology manager
drm/dp: Kill unused MST vcpi slot availability tracking
drm/dp: Split drm_dp_mst_allocate_vcpi
drm: Add driver pr
ck
if there are enough vcpi slots before allocating them.
This brings the check to one place. Additionally drivers that will use MST
state tracking for atomic modesets can use the atomic version of
find_vcpi_slots() and reuse drm_dp_mst_allocate_vcpi()
Signed-off-by: Dhinakaran Pandiyan
---
driver
erent types can be managed in the
same state array.
Suggested-by: Daniel Vetter
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_atomic.c| 55 +
drivers/gpu/drm/drm_atomic_helper.c | 6
include/drm/drm_atomic.h
drm_atomic_set_mode_for_crtc() modifies the .enable member of CRTC state
but documentation claims otherwise, fix that.
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_atomic.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic.c b
. So, fix this by removing the total_pbn member itself.
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_dp_mst_topology.c | 5 ++---
include/drm/drm_dp_mst_helper.h | 9 +
2 files changed, 3 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c
ck
if there are enough vcpi slots before allocating them.
This brings the check to one place. Additionally drivers that will use MST
state tracking for atomic modesets can use the atomic version of
find_vcpi_slots() and reuse drm_dp_mst_allocate_vcpi()
Signed-off-by: Dhinakaran Pandiyan
Reviewed-by:
helper callback ->atomic_release() when CRTCs are disabled.
v2:
Squashed atomic_release() implementation and caller (Daniel)
Fixed logic for connector-crtc switching case (Daniel)
Fixed logic for suspend-resume case.
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/i915/intel_dp_m
fixes vcpi slot accounting logic for suspend-resume and
connector switching
Dhinakaran Pandiyan (8):
drm/dp: Kill total_pbn and total_slots in struct
drm_dp_mst_topology_mgr
drm/dp: Kill unused MST vcpi slot availability tracking
drm/dp: Split drm_dp_mst_allocate_vcpi
drm: Add
The avail_slots member in the MST topology manager is never updated to
reflect the available vcpi slots. The check is effectively against
total slots, 63. So, let's make that check obvious and remove
avail_slots. While at it, make debug messages more descriptive.
Signed-off-by: Dhina
state initialization and switched to
kmemdup() for allocation (Daniel)
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_dp_mst_topology.c | 71 +++
include/drm/drm_dp_mst_helper.h | 20 ++
2 files changed, 91 insertions(+)
diff --git a/drivers/gp
ter
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_atomic_helper.c | 19 +++
include/drm/drm_modeset_helper_vtables.h | 13 +
2 files changed, 32 insertions(+)
diff --git a/drivers/gpu/drm/drm_atomic_helper.c
b/drivers/gpu/drm/drm_atomic_helper.c
in
erent types can be managed in the
same state array.
v2: Added docs and new iterator to filter private objects (Daniel)
Suggested-by: Daniel Vetter
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_atomic.c| 68 +++
drivers/gpu/drm/drm_atomic_helper.c
verifying the port reference is valid
Moved get_mst_topology_state() into the helpers (Daniel)
Changed find_vcpi_slots() to not depend on current allocation
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_dp_mst_topology.c | 75 +++
include/drm/drm_d
The DP device identification string read from the DPCD registers is 6
characters long at max. and we store it in a char array of the same length
without space for the NULL terminator. Fix this by increasing the array
size to 7 and initialize it to an empty string.
Signed-off-by: Dhinakaran
er of unallocated slots out of
the total 64. The value will be updated when vcpi allocation or reset
happens. Since vcpi allocation and deallocation can happen simultaneously,
the struct drm_dp_mst_topology_mgr.lock mutex is used to protect
it from concurrent accesses.
Signed-off-by: Dhinakaran Pan
s fix this by calculating the total link bandwidth as
link bw (PBN) = BW per time slot(PBN) * max. time slots , where max. time
slots is 64
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_dp_mst_topology.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drive
drm_dp_find_vcpi_slots() returns an error when there is not enough
available bandwidth on a link to support a mode. This error should make
compute_config() to fail. Not returning false could end up in a modeset
which will not work.
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/i915
The number of available time slots in a MTP should be updated when a new
vcpi is added or an existing one is removed. Keeping this updated will be
useful to reject modes for which there is not enough link bandwidth early.
Dhinakaran Pandiyan (3):
drm/i915/dp: Fail DP MST config when there are
escriptive.
Cc: Daniel Vetter
Cc: Archit Taneja
Cc: Maarten Lankhorst
Cc: Chris Wilson
Cc: Harry Wentland
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_dp_mst_topology.c | 15 ---
include/drm/drm_dp_mst_helper.h | 5 -
2 files changed, 8 insertions(+
Signed-off-by: Dhinakaran Pandiyan
Reviewed-by: Dave Airlie
---
drivers/gpu/drm/drm_dp_mst_topology.c | 21 ++---
drivers/gpu/drm/i915/intel_dp_mst.c| 4 ++--
drivers/gpu/drm/nouveau/nv50_display.c | 3 ++-
drivers/gpu/drm/radeon/radeon_dp_mst.c | 4 +++-
include/drm/drm_
nds on the link rate and is not a
constant. So, fix this by removing the total_pbn member itself.
Cc: Daniel Vetter
Cc: Archit Taneja
Cc: Maarten Lankhorst
Cc: Chris Wilson
Cc: Harry Wentland
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_dp_mst_topology.c | 5 ++---
i
connector_in_state()' macro.
v2: Moved the caller hunk to this patch (Daniel)
Cc: Daniel Vetter
Cc: Archit Taneja
Cc: Maarten Lankhorst
Cc: Chris Wilson
Cc: Harry Wentland
Suggested-by: Daniel Vetter
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_at
Link bandwidth is a shared resource between multiple displays in DP MST
configurations. For atomic modesetting drivers, checking if there is
sufficient link bandwidth for a mode needs to be done during the
atomic_check phase to avoid failed modesets when multiple CRTC's and
connectors are involved.
Harry Wentland
Suggested-by: Daniel Vetter
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_atomic.c| 68 +++
drivers/gpu/drm/drm_atomic_helper.c | 5 ++
include/drm/drm_atomic.h| 93 +
3 files changed,
Taneja
Cc: Maarten Lankhorst
Cc: Chris Wilson
Cc: Harry Wentland
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/i915/intel_dp_mst.c | 38 ++---
1 file changed, 31 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c
b/d
k.
v3: WARN_ON() if connection_mutex is not held (Archit)
v2: Included kernel doc, moved state initialization and switched to
kmemdup() for allocation (Daniel)
Cc: Daniel Vetter
Cc: Archit Taneja
Cc: Maarten Lankhorst
Cc: Chris Wilson
Cc: Harry Wentland
Signed-off-by: Dhinakaran Pandiyan
---
mst_allocate_vcpi().
v2:
Added checks for verifying the port reference is valid
Moved get_mst_topology_state() into the helpers (Daniel)
Changed find_vcpi_slots() to not depend on current allocation
Cc: Daniel Vetter
Cc: Archit Taneja
Cc: Maarten Lankhorst
Cc: Chris Wilson
Cc: Harry Wentland
S
conditionally called and before
other atomic_checks() (Daniel)
v3: Use the new 'for_each_oldnew_connector_in_state()' macro.
v2: Moved the caller hunk to this patch (Daniel)
Reviewed-by: Daniel Vetter
Suggested-by: Daniel Vetter
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/
: Daniel Vetter
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_atomic.c| 69 +++
drivers/gpu/drm/drm_atomic_helper.c | 5 ++
include/drm/drm_atomic.h| 93 +
3 files changed, 167 insertions(+)
diff --gi
Corrected typo in bridge and encoder comparison. Also, added a one-line
encoder description from the previous documentation.
Cc: Daniel Vetter
Cc: Archit Taneja
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_encoder.c | 17 +
1 file changed, 9 insertions(+), 8
The positions of primary and overlay plane type enums in the kernel were
updated in
drm/doc: Polish for drm_plane.[hc]
So, making the change here as well.
Cc: Daniel Vetter
Signed-off-by: Dhinakaran Pandiyan
---
xf86drmMode.h | 6 +++---
1 file changed, 3 insertions(+), 3
vgem does not do modeset, looping through non-existent CRTC's while
registering drm_minor in
'commit 48c787899882 ("drm: Add API for capturing frame CRCs")'
caused kernel oops. So, let's add CRC debugfs files
only for those drivers that do modeset.
Signed-o
etc.
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_dp_mst_topology.c | 6 +++---
drivers/gpu/drm/i915/intel_dp_mst.c| 3 ++-
drivers/gpu/drm/nouveau/nv50_display.c | 2 +-
drivers/gpu/drm/radeon/radeon_dp_mst.c | 2 +-
include/drm/drm_dp_mst_helper.h| 7 +--
5 files
needs to be done during the atomic_check phase to avoid failed
modesets. Let's encsapsulate the available link bw information in a state
structure so that bw can be allocated and released atomically for each of
the ports sharing the primary link.
Signed-off-by: Dhinakaran Pandiyan
---
driver
more informative.
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_dp_mst_topology.c | 14 ++
include/drm/drm_dp_mst_helper.h | 12
2 files changed, 6 insertions(+), 20 deletions(-)
diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c
b/drivers/gp
Make use of the added MST helpers to find, allocate and release link bw
for atomic modesets.
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/i915/intel_display.c | 39 +++-
drivers/gpu/drm/i915/intel_dp_mst.c | 36
ck
if there are enough vcpi slots before allocating them.
This brings the check to one place. Additionally drivers that will use MST
state tracking for atomic modesets can uses the atomic version of
find_vcpi_slots() and reuse drm_dp_mst_allocate_vcpi()
Signed-off-by: Dhinakaran Pandiyan
---
driver
e port.
drm_dp_atomic_release_vcpi_slots() should be called from
->atomic_check() to release a port's vcpi slot allocation from the
state.
Drivers that do not make use of this atomic helper are expected to call
drm_dp_find_vcpi_slots() instead before calling
drm_dp_mst_allocate_vcpi().
Signed-off-by: Dhina
i915 changes to use the helpers .
Dhinakaran Pandiyan (6):
drm/dp: Store drm_device in MST topology manager
drm/dp: Kill unused MST vcpi slot availability tracking
drm/dp: Split drm_dp_mst_allocate_vcpi
drm/dp: Introduce DP MST topology manager state to track DP link bw
drm/dp: Add DP MST he
: Daniel Vetter
Cc: Ben Skeggs
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_fb_helper.c | 6 +++---
drivers/gpu/drm/nouveau/nouveau_connector.c | 4 ++--
drivers/gpu/drm/nouveau/nouveau_display.c | 6 +++---
drivers/gpu/drm/nouveau/nouveau_fbcon.c | 2 +-
include/drm
are tracked in the state structures.
v2: Included header
Cc: Daniel Vetter
Reviewed-by: Daniel Vetter
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_mode_object.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_mode_object.c
b/drivers/gpu
)
Move the function drm_atomic.h (Daniel)
Fixed comment marker for documentation
Suggested-by: Daniel Vetter
Cc: Daniel Vetter
Cc: Ben Skeggs
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_fb_helper.c | 6 +++---
drivers/gpu/drm/nouveau/nouveau_connector.c | 5
)
Move the function drm_atomic.h (Daniel)
Suggested-by: Daniel Vetter
Cc: Daniel Vetter
Cc: Ben Skeggs
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_fb_helper.c | 6 +++---
drivers/gpu/drm/nouveau/nouveau_connector.c | 5 +++--
drivers/gpu/drm/nouveau
are tracked in the state structures.
v2: Included header
Cc: Daniel Vetter
Reviewed-by: Daniel Vetter
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_mode_object.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_mode_object.c
b/drivers/gpu
are tracked in the state structures.
Cc: Daniel Vetter
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_mode_object.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_mode_object.c
b/drivers/gpu/drm/drm_mode_object.c
index 9f17085..292d339
are tracked in the state structures.
v2: Included header
Cc: Daniel Vetter
Reviewed-by: Daniel Vetter
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_mode_object.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_mode_object.c
b/drivers/gpu
)
Move the function drm_atomic.h (Daniel)
Fixed comment marker for documentation
v3:
Included drmP.h to dereference struct drm_device
Suggested-by: Daniel Vetter
Cc: Daniel Vetter
Cc: Ben Skeggs
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_fb_helper.c | 6
i915 will make use of this to fail early during framebuffer creation.
Suggested-by: Ville Syrjälä
Cc: dri-devel@lists.freedesktop.org
Cc: Ville Syrjälä
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_plane.c | 1 +
include/drm/drm_plane.h | 11 +++
2 files changed, 12
the
> modifier yet, instead export the function and let drivers
> call it themselves
>
> Cc: Eric Anholt
> Signed-off-by: Ville Syrjälä
I ended up writing a similar patch for i915. Having this in the core
seems better and patch still applies cleanly.
Reviewed-by: Dhinaka
On Fri, 2018-03-09 at 17:14 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Replace the messy framebuffer format/modifier validation code
> with a single call to drm_any_plane_has_format(). The code was
> extremely annoying to maintain as you had to have a lot of platform
> checks for diffe
rm
> checks for different formats. The new code requires zero maintenance.
>
> v2: Nuke the modifier checks as well since the core does that too now
> v3: Call drm_any_plane_has_format() from the driver code
> v4: Rebase
>
> Cc: Dhinakaran Pandiyan
Reviewed-by: Dhinakaran Pa
"atomic driver check for %p failed: %d\n",
> + state, ret);
> return ret;
> + }
>
nit: Would have slightly looked better if the 'ret' check was moved
inside the branch for funcs->atomic_check.
Reviewed-by: Dhinakara
On Wed, 2018-04-11 at 18:54 -0400, Lyude Paul wrote:
> While having the modeset_retry_work in intel_connector makes sense with
> SST, this paradigm doesn't make a whole ton of sense when it comes to
> MST since we have to deal with multiple connectors. In most cases, it's
> more useful to just u
On Fri, 2018-05-11 at 18:03 +, Souza, Jose wrote:
> On Thu, 2018-05-10 at 17:54 -0700, Dhinakaran Pandiyan wrote:
> >
> > Entry corresponding to 220 us setup time was missing. I am not
> > aware
> > of
> > any specific bug this fixes, but this could potential
1.4a.
Fixes: 6608804b3d7f ("drm/dp: Add drm_dp_psr_setup_time()")
Cc: sta...@vger.kernel.org
Cc: Ville Syrjälä
Cc: Jose Roberto de Souza
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/drm_dp_helper.c | 1 +
1 file changed, 1 insertion(+)
di
Allows drivers to pass a larger modifier array, thereby avoiding
declarations of static modifier arrays that are only slight different
for each plane.
Cc: dri-devel@lists.freedesktop.org
Cc: Ville Syrjälä
Suggested-by: Ville Syrjälä
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm
On Tue, 2018-11-06 at 16:13 +0200, Ville Syrjälä wrote:
> On Mon, Nov 05, 2018 at 06:44:34PM -0800, Dhinakaran Pandiyan wrote:
> > Allows drivers to pass a larger modifier array, thereby avoiding
> > declarations of static modifier arrays that are only slight
> > differe
1 - 100 of 183 matches
Mail list logo
