[PATCH libdrm] modetest: Add support for setting mode having floating vertical refresh rate

2019-11-06 Thread Devarsh Thakkar
ch it be can done as shown in below command, given there is an appropriate mode is available : modetest -M xlnx -s 39:1920x1080-59.94@BG24 -v NOTE: Above command was tested on xilinx DRM driver with DP monitor which was supporting mode having 59.94 Hz refresh rate. Signed-off-by: Devarsh Th

[PATCH libdrm v2] modetest: Add support for setting mode having floating vertical refresh rate

2019-11-06 Thread Devarsh Thakkar
igned-off-by: Devarsh Thakkar --- V2: Update commit message --- tests/modetest/modetest.c | 32 1 file changed, 24 insertions(+), 8 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index e66be66..9b3e410 100644 --- a/tests/mod

RE: [PATCH libdrm v2] modetest: Add support for setting mode having floating vertical refresh rate

2019-11-12 Thread Devarsh Thakkar
Hi Ville, Thanks for the review. I have sent v3 patch addressing the review comments. Could you please review and let me know if any further changes required ? Regards, Devarsh > -Original Message- > From: Ville Syrjälä > Sent: 07 November 2019 03:13 > To: Devarsh Thakka

[PATCH libdrm v3] modetest: Add support for setting mode having floating vertical refresh rate

2019-11-12 Thread Devarsh Thakkar
igned-off-by: Devarsh Thakkar --- V2: Update commit message V3: Update with below changes as per review comments : 1) Use epsilon for vrefresh comparison 2) Use implicit type-casting wherever possible --- tests/modetest/modetest.c | 20 1 file changed, 12 insertions(

[PATCH libdrm v4] modetest: Add support for setting mode having floating vertical refresh rate

2019-11-17 Thread Devarsh Thakkar
. V2: Update commit message V3: Update with below changes as per review comments : 1) Use epsilon for vrefresh comparison 2) Use implicit type-casting wherever possible V4: Keep patch version history on main commit message Signed-off-by: Devarsh Thakkar Reviewed-by: Ville Syrjälä --- tests/mod

RE: [PATCH libdrm] modetest: call drmModeCrtcSetGamma() only if add_property_optional returns true

2020-03-03 Thread Devarsh Thakkar
Hi Rohit, This makes sense to me as gamma was implemented as optional property. Reviewed-By: "Devarsh Thakkar " @emil.veli...@collabora.com, @imir...@alum.mit.edu, @Ville Syrjälä, Could you please ack and help merge this patch if it also look good to you ? Regards, Devarsh >

RE: [PATCH libdrm v4] modetest: Add support for setting mode having floating vertical refresh rate

2019-11-25 Thread Devarsh Thakkar
way to subscribe ? Regards, Devarsh > -Original Message- > From: Devarsh Thakkar > Sent: 15 November 2019 06:31 > To: dri-devel@lists.freedesktop.org; ville.syrj...@linux.intel.com > Cc: Hyun Kwon ; vcu-team ; > Ranganathan Sk ; Dhaval Rajeshbhai Shah > ; S

RE: [PATCH libdrm v4] modetest: Add support for setting mode having floating vertical refresh rate

2019-11-26 Thread Devarsh Thakkar
> -Original Message- > From: Ville Syrjälä > Sent: 25 November 2019 06:30 > To: Devarsh Thakkar > Cc: dri-devel@lists.freedesktop.org; Hyun Kwon ; vcu- > team ; Ranganathan Sk ; Dhaval > Rajeshbhai Shah ; Satish Kumar Nagireddy > ; Varunkumar Allagadapa > Su

[PATCH libdrm] modetest: Use floating vrefresh while dumping mode

2019-11-27 Thread Devarsh Thakkar
more appropriate mode using suitable refresh rate value. Signed-off-by: Devarsh Thakkar --- tests/modetest/modetest.c | 36 ++-- 1 file changed, 22 insertions(+), 14 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index b4edfcb..80cf076 1

RE: [PATCH libdrm] modetest: Use floating vrefresh while dumping mode

2019-11-27 Thread Devarsh Thakkar
Thanks for the review Ville, please see inline: > -Original Message- > From: Ville Syrjälä > Sent: 26 November 2019 07:15 > To: Devarsh Thakkar > Cc: dri-devel@lists.freedesktop.org; Hyun Kwon ; vcu- > team ; Ranganathan Sk ; Dhaval > Rajeshbhai Shah ; S

RE: [PATCH libdrm v3] modetest: Use floating vrefresh while dumping mode

2019-12-03 Thread Devarsh Thakkar
Thanks for the review Ville and Neil, response inline. > -Original Message- > From: Ville Syrjälä > Sent: 02 December 2019 09:43 > To: Neil Armstrong > Cc: Devarsh Thakkar ; Ranganathan Sk > ; vcu-team ; Dhaval Rajeshbhai Shah > ; dri-devel@lists.freedesktop.org; Va

[PATCH libdrm v2] modetest: Use floating vrefresh while dumping mode

2019-12-03 Thread Devarsh Thakkar
more appropriate mode using suitable refresh rate value. Signed-off-by: Devarsh Thakkar --- tests/modetest/modetest.c | 40 +++- 1 file changed, 27 insertions(+), 13 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index b4edfcb..c3

[PATCH libdrm v3] modetest: Use floating vrefresh while dumping mode

2019-12-03 Thread Devarsh Thakkar
it in args. Signed-off-by: Devarsh Thakkar --- tests/modetest/modetest.c | 40 +++- 1 file changed, 27 insertions(+), 13 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index b4edfcb..19ce20f 100644 --- a/tests/modetest/modetest.c +

[PATCH libdrm v4] modetest: Use floating vrefresh while dumping mode

2019-12-04 Thread Devarsh Thakkar
V3: 1) Change name of function used to derive refresh rate. V2: 1) Don't use inline function for deriving refresh rate from mode. 2) If requested mode not found, print refresh rate only if user had provided it in args. Signed-off-by: Devarsh Thakkar Reviewed-by: Neil Armstrong --- test

RE: [PATCH libdrm v4] modetest: Use floating vrefresh while dumping mode

2019-12-10 Thread Devarsh Thakkar
Hi Eric, Ville, Thanks for the review, please see inline. > -Original Message- > From: Eric Engestrom > Sent: 05 December 2019 05:17 > To: Devarsh Thakkar > Cc: dri-devel@lists.freedesktop.org > Subject: Re: [PATCH libdrm v4] modetest: Use floating vrefresh wh

Re: [RFC PATCH 2/3] drm/tidss: Add support for display sharing

2024-03-22 Thread Devarsh Thakkar
Hi Maxime, On 14/03/24 20:04, Maxime Ripard wrote: > Hi, > > On Wed, Feb 14, 2024 at 09:17:12PM +0530, Devarsh Thakkar wrote: >> On 13/02/24 19:34, Maxime Ripard wrote: >>> On Thu, Feb 08, 2024 at 06:26:17PM +0530, Devarsh Thakkar wrote: >>>> On 26/01/24

[PATCH] drm/tidss: Power up attached PM domains on probe

2023-10-09 Thread Devarsh Thakkar
igned-off-by: Devarsh Thakkar --- drivers/gpu/drm/tidss/tidss_drv.c | 76 +++ drivers/gpu/drm/tidss/tidss_drv.h | 5 ++ 2 files changed, 81 insertions(+) diff --git a/drivers/gpu/drm/tidss/tidss_drv.c b/drivers/gpu/drm/tidss/tidss_drv.c index 4d063eb9cd0b..a703a27

Re: [PATCH] drm/tidss: Power up attached PM domains on probe

2023-10-09 Thread Devarsh Thakkar
Hi Maxime, Thanks for the review. On 09/10/23 14:53, Maxime Ripard wrote: > Hi Devarsh, > > On Mon, Oct 09, 2023 at 01:20:18PM +0530, Devarsh Thakkar wrote: >> Some SoC's such as AM62P have dedicated power domains >> for OLDI which need to be powered on separe

Re: [PATCH] drm/tidss: Power up attached PM domains on probe

2023-10-12 Thread Devarsh Thakkar
Hi Maxime, On 09/10/23 16:40, Devarsh Thakkar wrote: Hi Maxime, Thanks for the review. On 09/10/23 14:53, Maxime Ripard wrote: Hi Devarsh, On Mon, Oct 09, 2023 at 01:20:18PM +0530, Devarsh Thakkar wrote: Some SoC's such as AM62P have dedicated power domains for OLDI which need

Re: [PATCH] drm/tidss: Power up attached PM domains on probe

2023-10-12 Thread Devarsh Thakkar
On 09/10/23 13:20, Devarsh Thakkar wrote: Some SoC's such as AM62P have dedicated power domains for OLDI which need to be powered on separetely along with display controller. So during driver probe, power up all attached PM domains enumerated in devicetree node for DSS. This also pre

Re: [PATCH] drm/tidss: Power up attached PM domains on probe

2023-10-16 Thread Devarsh Thakkar
Hi Maxime, On 12/10/23 18:10, Maxime Ripard wrote: > Hi, > > On Thu, Oct 12, 2023 at 05:10:06PM +0530, Devarsh Thakkar wrote: >> On 09/10/23 13:20, Devarsh Thakkar wrote: >>> Some SoC's such as AM62P have dedicated power domains >>> for OLDI which need to b

Re: [RFC PATCH 1/3] dt-bindings: display: ti,am65x-dss: Add support for display sharing mode

2024-02-08 Thread Devarsh Thakkar
Hi Rob, Thanks for the review. On 19/01/24 19:25, Rob Herring wrote: > On Thu, Jan 18, 2024 at 7:59 AM Devarsh Thakkar wrote: >> >> Hi Rob, >> >> Thanks for the quick review. >> >> On 18/01/24 01:43, Rob Herring wrote: >>> On Tue, Jan 16,

Re: [RFC PATCH 3/3] arm64: dts: ti: k3-am62x: Add overlay to use DSS in display sharing mode

2024-02-08 Thread Devarsh Thakkar
Hi Tomi, Thanks for the review. On 23/01/24 13:59, Tomi Valkeinen wrote: > Hi, > > On 16/01/2024 15:41, Devarsh Thakkar wrote: >> This overlay needs to be used with display sharing supported device >> manager firmware only. >> >> Remote core running this fir

Re: [RFC PATCH 2/3] drm/tidss: Add support for display sharing

2024-02-08 Thread Devarsh Thakkar
Hi Maxime, Thanks a lot for checking on this. On 26/01/24 17:45, Maxime Ripard wrote: > Hi, > > Thanks a lot for working on that. > > On Tue, Jan 16, 2024 at 07:11:41PM +0530, Devarsh Thakkar wrote: >> Display subsystem present in TI Keystone family of devices supports

Re: [PATCH 1/2] dt-bindings: display: ti,am65x-dss: Add support for common1 region

2024-02-14 Thread Devarsh Thakkar
Hi Tomi, Vignesh, On 14/02/24 14:53, Tomi Valkeinen wrote: > On 14/02/2024 11:10, Tomi Valkeinen wrote: >> Hi, >> >> On 15/01/2024 14:57, Devarsh Thakkar wrote: >>> TI keystone display subsystem present in AM65 and other SoCs such as AM62 >>> support two

[PATCH v2 1/2] dt-bindings: display: ti, am65x-dss: Add support for common1 region

2024-02-14 Thread Devarsh Thakkar
s://www.ti.com/lit/pdf/spruiv7 (Section 14.8.9.1 DSS Registers) AM65x TRM: https://www.ti.com/lit/pdf/spruid7 (Section 12.6.5 DSS Registers) AM62A TRM: https://www.ti.com/lit/pdf/spruj16 (Section 14.9.9.1 DSS Registers) Signed-off-by: Devarsh Thakkar Acked-by: Conor Dooley --- V2: Add Ac

[PATCH v2 0/2] Add common1 region for AM62, AM62A & AM65x

2024-02-14 Thread Devarsh Thakkar
This adds DSS common1 region for respective SoCs supporting it. Devarsh Thakkar (2): dt-bindings: display: ti,am65x-dss: Add support for common1 region arm64: dts: ti: Add common1 register space for AM62x, AM62A & AM65x SoCs .../devicetree/bindings/display/ti/ti,am65x-dss.yaml

[PATCH v2 2/2] arm64: dts: ti: Add common1 register space for AM62x, AM62A & AM65x SoCs

2024-02-14 Thread Devarsh Thakkar
This adds common1 register space for AM62x, AM62A and AM65x SoC's which are using TI's Keystone display hardware and supporting it as described in Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml Signed-off-by: Devarsh Thakkar --- V2: Add common1 region for AM62A SoC too

Re: [RFC PATCH 2/3] drm/tidss: Add support for display sharing

2024-02-14 Thread Devarsh Thakkar
Hi Maxime, Thanks for the quick reply. On 13/02/24 19:34, Maxime Ripard wrote: > Hi Devarsh, > > On Thu, Feb 08, 2024 at 06:26:17PM +0530, Devarsh Thakkar wrote: >> Hi Maxime, >> >> Thanks a lot for checking on this. >> >> On 26/01/24 17:45, Maxime Ripard

[PATCH v3 2/2] arm64: dts: ti: Add common1 register space for AM62x, AM62A & AM65x SoCs

2024-02-15 Thread Devarsh Thakkar
play SubSystem (DSS)") Fixes: 8ccc1073c7bb ("arm64: dts: ti: k3-am62-main: Add node for DSS") Fixes: fc539b90eda2 ("arm64: dts: ti: am654: Add DSS node") Signed-off-by: Devarsh Thakkar --- V2: Add common1 region for AM62A SoC too V3: Add Fixes tag --- arch/arm64/boot/dts/ti/

[PATCH v3 1/2] dt-bindings: display: ti, am65x-dss: Add support for common1 region

2024-02-15 Thread Devarsh Thakkar
s://www.ti.com/lit/pdf/spruiv7 (Section 14.8.9.1 DSS Registers) AM65x TRM: https://www.ti.com/lit/pdf/spruid7 (Section 12.6.5 DSS Registers) Fixes: 2d8730f1021f ("dt-bindings: display: ti,am65x-dss: Add dt-schema yaml binding") Signed-off-by: Devarsh Thakkar Acked-by: Conor Dooley --

[PATCH v3 0/2] Add common1 region for AM62, AM62A & AM65x

2024-02-15 Thread Devarsh Thakkar
This adds DSS common1 region for respective SoCs supporting it. Changelog: V2 : Remove do-not-merge tag and add am62a dss common1 reion V3 : Add Fixes tag to each commit Devarsh Thakkar (2): dt-bindings: display: ti,am65x-dss: Add support for common1 region arm64: dts: ti: Add common1

[PATCH v4 2/2] arm64: dts: ti: Add common1 register space for AM62x, AM62A & AM65x SoCs

2024-02-15 Thread Devarsh Thakkar
play SubSystem (DSS)") Fixes: 8ccc1073c7bb ("arm64: dts: ti: k3-am62-main: Add node for DSS") Fixes: fc539b90eda2 ("arm64: dts: ti: am654: Add DSS node") Signed-off-by: Devarsh Thakkar Reviewed-by: Aradhya Bhatia --- V2: Add common1 region for AM62A SoC too V3: Add Fixes

[PATCH v4 0/2] Add common1 region for AM62, AM62A & AM65x

2024-02-15 Thread Devarsh Thakkar
This adds DSS common1 region for respective SoCs supporting it. Changelog: V2 : Remove do-not-merge tag and add am62a dss common1 reion V3 : Add Fixes tag to each commit V4 : Add Reviewed-by tag and AM62A SoC TRM Link Devarsh Thakkar (2): dt-bindings: display: ti,am65x-dss: Add support for

[PATCH v4 1/2] dt-bindings: display: ti, am65x-dss: Add support for common1 region

2024-02-15 Thread Devarsh Thakkar
dd dt-schema yaml binding") Signed-off-by: Devarsh Thakkar Reviewed-by: Aradhya Bhatia Acked-by: Conor Dooley --- V2: Add Acked-by tag V3: Add Fixes tag V4: Add Reviewed-by and AM62A TRM link --- .../devicetree/bindings/display/ti/ti,am65x-dss.yaml | 7 +-- 1 file changed, 5 ins

[PATCH v5 4/4] arm64: dts: ti: Add common1 register space for AM62A SoC

2024-02-15 Thread Devarsh Thakkar
) Signed-off-by: Devarsh Thakkar --- V1->V4 : - No change (this was part of "arm64: dts: ti: Add common1 register space for AM62x, AM62A & AM65x SoCs ) V5 : - Split this as a separate patch from "arm64: dts: ti: Add common1 register space for AM62x, AM62A & AM65x SoCs&

[PATCH v5 0/4] Add common1 region for AM62, AM62A & AM65x

2024-02-15 Thread Devarsh Thakkar
This adds DSS common1 region for respective SoCs supporting it. Changelog: V2 : Remove do-not-merge tag and add am62a dss common1 reion V3 : Add Fixes tag to each commit V4 : Add Reviewed-by tag and AM62A SoC TRM Link V5 : Split dts patch to separate patches for each SoC Devarsh Thakkar (4

[PATCH v5 2/4] arm64: dts: ti: Add common1 register space for AM65x SoC

2024-02-15 Thread Devarsh Thakkar
This adds common1 register space for AM65x SoC which is using TI's Keystone display hardware and supporting it as described in Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml Fixes: fc539b90eda2 ("arm64: dts: ti: am654: Add DSS node") Signed-off-by: Devarsh Thak

[PATCH v5 1/4] dt-bindings: display: ti, am65x-dss: Add support for common1 region

2024-02-15 Thread Devarsh Thakkar
chema yaml binding") Signed-off-by: Devarsh Thakkar Reviewed-by: Aradhya Bhatia Acked-by: Conor Dooley --- V2: Add Acked-by tag V3: Add Fixes tag V4: Add Reviewed-by and AM62A TRM link V5: No change --- .../devicetree/bindings/display/ti/ti,am65x-dss.yaml | 7 +-- 1 file change

[PATCH v5 3/4] arm64: dts: ti: Add common1 register space for AM62x SoC

2024-02-15 Thread Devarsh Thakkar
This adds common1 register space for AM62x SoC which is using TI's Keystone display hardware and supporting it as described in Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml Fixes: 8ccc1073c7bb ("arm64: dts: ti: k3-am62-main: Add node for DSS") Signed-off-by:

[PATCH v7 8/8] gpu: ipu-v3: Use generic macro for rounding to nearest multiple

2024-05-09 Thread Devarsh Thakkar
Use generic macro round_closest_up for rounding to nearest multiple instead of using local function. Signed-off-by: Devarsh Thakkar --- V1->V6 (No change, patch introduced in V7) --- drivers/gpu/ipu-v3/ipu-image-convert.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --gi

[PATCH v7 6/8] math.h Add macros to round to closest specified power of 2

2024-05-09 Thread Devarsh Thakkar
: Devarsh Thakkar --- V1->V6 (No change, patch introduced in V7) --- include/linux/math.h | 36 1 file changed, 36 insertions(+) diff --git a/include/linux/math.h b/include/linux/math.h index dd4152711de7..82ee3265c910 100644 --- a/include/linux/math.h ++

[PATCH v7 7/8] media: imagination: Round to closest multiple for cropping region

2024-05-09 Thread Devarsh Thakkar
values (high and low) are possible to raise the probability of cropping rectangle falling inside the bound region. Signed-off-by: Devarsh Thakkar --- V1->V6 (No change, patch introduced in V7) --- drivers/media/platform/imagination/e5010-jpeg-enc.c | 8 1 file changed, 4 insertions(+)

[PATCH RESEND v7 0/8] Add V4L2 M2M Driver for E5010 JPEG Encoder

2024-05-10 Thread Devarsh Thakkar
@ti.com/ V5: https://lore.kernel.org/all/20240215134641.3381478-1-devar...@ti.com/ V6: https://lore.kernel.org/all/20240228141140.3530612-1-devar...@ti.com/ Devarsh Thakkar (8): media: dt-bindings: Add Imagination E5010 JPEG Encoder media: imagination: Add E5010 JPEG Encoder driver media: v4l2-jpeg: E

[PATCH RESEND v7 6/8] math.h Add macros to round to closest specified power of 2

2024-05-10 Thread Devarsh Thakkar
: Devarsh Thakkar --- V1->V6 (No change, patch introduced in V7) --- include/linux/math.h | 36 1 file changed, 36 insertions(+) diff --git a/include/linux/math.h b/include/linux/math.h index dd4152711de7..82ee3265c910 100644 --- a/include/linux/math.h ++

[PATCH RESEND v7 7/8] media: imagination: Round to closest multiple for cropping region

2024-05-10 Thread Devarsh Thakkar
values (high and low) are possible to raise the probability of cropping rectangle falling inside the bound region. Signed-off-by: Devarsh Thakkar --- V1->V6 (No change, patch introduced in V7) --- drivers/media/platform/imagination/e5010-jpeg-enc.c | 8 1 file changed, 4 insertions(+)

[PATCH RESEND v7 8/8] gpu: ipu-v3: Use generic macro for rounding to nearest multiple

2024-05-10 Thread Devarsh Thakkar
Use generic macro round_closest_up for rounding to nearest multiple instead of using local function. Signed-off-by: Devarsh Thakkar --- V1->V6 (No change, patch introduced in V7) --- drivers/gpu/ipu-v3/ipu-image-convert.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --gi

Re: [PATCH v7 7/8] media: imagination: Round to closest multiple for cropping region

2024-05-11 Thread Devarsh Thakkar
Hi Andy, Thanks for the quick review. On 10/05/24 20:40, Andy Shevchenko wrote: > On Fri, May 10, 2024 at 12:10:01AM +0530, Devarsh Thakkar wrote: >> If neither of the flags to round down (V4L2_SEL_FLAG_LE) or round up >> (V4L2_SEL_FLAG_GE) are specified by the user, then r

Re: [PATCH v7 6/8] math.h Add macros to round to closest specified power of 2

2024-05-11 Thread Devarsh Thakkar
Hi Andy, Thanks for the quick review. On 10/05/24 20:31, Andy Shevchenko wrote: > On Fri, May 10, 2024 at 12:09:52AM +0530, Devarsh Thakkar wrote: >> Add macros to round to nearest specified power of 2. > > This is not what they are doing. For the above we already have macros def

Re: [PATCH v7 6/8] math.h Add macros to round to closest specified power of 2

2024-05-11 Thread Devarsh Thakkar
Hi Jani, Thanks for the quick review. On 10/05/24 20:45, Jani Nikula wrote: [...] > Moreover, I think the naming of round_up() and round_down() should have > reflected the fact that they operate on powers of 2. It's unfortunate > that the difference to roundup() and rounddown() is just the under

Re: [PATCH v7 8/8] gpu: ipu-v3: Use generic macro for rounding to nearest multiple

2024-05-11 Thread Devarsh Thakkar
Hi Andy, Thanks for the quick review. On 10/05/24 20:33, Andy Shevchenko wrote: > On Fri, May 10, 2024 at 12:10:10AM +0530, Devarsh Thakkar wrote: >> Use generic macro round_closest_up for rounding to nearest multiple instead > > round_closest_up() > > We refer to

Re: [PATCH v7 6/8] math.h Add macros to round to closest specified power of 2

2024-05-13 Thread Devarsh Thakkar
Hi Andy, On 13/05/24 14:29, Andy Shevchenko wrote: > On Sat, May 11, 2024 at 11:11:14PM +0530, Devarsh Thakkar wrote: >> On 10/05/24 20:45, Jani Nikula wrote: > > [...] > >>> Moreover, I think the naming of round_up() and round_down() should have >>> ref

Re: [PATCH v7 6/8] math.h Add macros to round to closest specified power of 2

2024-05-13 Thread Devarsh Thakkar
Hi Andy, On 13/05/24 17:55, Andy Shevchenko wrote: > On Mon, May 13, 2024 at 04:55:58PM +0530, Devarsh Thakkar wrote: >> On 13/05/24 14:29, Andy Shevchenko wrote: >>> On Sat, May 11, 2024 at 11:11:14PM +0530, Devarsh Thakkar wrote: >>>> On 10/05/24 20:45, Jani Niku

Re: [PATCH v7 7/8] media: imagination: Round to closest multiple for cropping region

2024-05-14 Thread Devarsh Thakkar
Hi Nicolas, Thanks for the review. On 15/05/24 01:52, Nicolas Dufresne wrote: > Le samedi 11 mai 2024 à 22:38 +0530, Devarsh Thakkar a écrit : >> Hi Andy, >> >> Thanks for the quick review. >> On 10/05/24 20:40, Andy Shevchenko wrote: >>> On Fri, May 10, 2024

[PATCH v8 00/10] Add V4L2 M2M Driver for E5010 JPEG Encoder

2024-05-17 Thread Devarsh Thakkar
://lore.kernel.org/all/20240205114239.924697-1-devar...@ti.com/ V3: https://lore.kernel.org/all/20230816152210.4080779-1-devar...@ti.com/ V2: https://lore.kernel.org/all/20230727112546.2201995-1-devar...@ti.com/ Daniel Latypov (1): lib: add basic KUnit test for lib/math Devarsh Thakkar (9):

[PATCH v8 06/10] math.h: Add macros for rounding to closest value

2024-05-17 Thread Devarsh Thakkar
* round_closest_up(15, 4) = 16 * round_closest_up(14, 4) = 16 * round_closest_down(17, 4) = 16 * round_closest_down(15, 4) = 16 * round_closest_down(14, 4) = 12 * roundclosest(21, 5) = 20 * roundclosest(19, 5) = 20 * roundclosest(17, 5) = 15 Signed-off-by: Devarsh Thakkar --- NOTE: This patch

[PATCH v8 07/10] lib: add basic KUnit test for lib/math

2024-05-17 Thread Devarsh Thakkar
c files Signed-off-by: Daniel Latypov Reviewed-by: David Gow [devarsht: Rebase to 6.9 and change license to GPL] Signed-off-by: Devarsh Thakkar --- Changes since v6: * Rebase to linux-next, change license to GPL as suggested by checkpatch. Changes since v5: * add in test cases for roundup/roun

[PATCH v8 08/10] lib: math_kunit: Add tests for new rounding related macros

2024-05-17 Thread Devarsh Thakkar
Add tests for round_closest_up/down and roundclosest macros which round to nearest multiple of specified argument. These are tested with kunit tool as shared here [1]. [1]: https://gist.github.com/devarsht/3f9042825be3da4e133b8f4eda067876 Signed-off-by: Devarsh Thakkar --- V1->V8 (No cha

[PATCH v8 09/10] media: imagination: Round to closest multiple for cropping region

2024-05-17 Thread Devarsh Thakkar
ection.rst Signed-off-by: Devarsh Thakkar --- V8: Update commit message with specification reference V1->V7 (No change, patch introduced in V7) --- drivers/media/platform/imagination/e5010-jpeg-enc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/platfor

[PATCH v8 10/10] gpu: ipu-v3: Use generic macro for rounding closest to specified value

2024-05-17 Thread Devarsh Thakkar
Use generic macro round_closest_up() for rounding closest to specified value instead of using local macro round_closest(). There is no change from functionality point of view as round_closest_up() is functionally same as the previously used local macro round_closest(). Signed-off-by: Devarsh

Re: [PATCH v8 07/10] lib: add basic KUnit test for lib/math

2024-05-20 Thread Devarsh Thakkar
Hi Andy, Daniel, On 18/05/24 01:44, Andy Shevchenko wrote: > On Fri, May 17, 2024 at 11:06:07PM +0530, Devarsh Thakkar wrote: [..] > >> [devarsht: Rebase to 6.9 and change license to GPL] > > I'm not sure that you may change license. It needs the author's con

Re: [PATCH v8 07/10] lib: add basic KUnit test for lib/math

2024-05-20 Thread Devarsh Thakkar
On 20/05/24 17:52, Andy Shevchenko wrote: > On Mon, May 20, 2024 at 05:11:18PM +0530, Devarsh Thakkar wrote: >> On 18/05/24 01:44, Andy Shevchenko wrote: >>> On Fri, May 17, 2024 at 11:06:07PM +0530, Devarsh Thakkar wrote: > > [..] > [..] > Yes, and one should

[PATCH v9 00/10] Add V4L2 M2M Driver for E5010 JPEG Encoder

2024-05-26 Thread Devarsh Thakkar
l/20240205114239.924697-1-devar...@ti.com/ V3: https://lore.kernel.org/all/20230816152210.4080779-1-devar...@ti.com/ V2: https://lore.kernel.org/all/20230727112546.2201995-1-devar...@ti.com/ Daniel Latypov (1): lib: add basic KUnit test for lib/math Devarsh Thakkar (9): media: dt-bindings: Add Imag

[PATCH v9 06/10] math.h: Add macros for rounding to closest value

2024-05-26 Thread Devarsh Thakkar
* round_closest_up(15, 4) = 16 * round_closest_up(14, 4) = 16 * round_closest_down(17, 4) = 16 * round_closest_down(15, 4) = 16 * round_closest_down(14, 4) = 12 * roundclosest(21, 5) = 20 * roundclosest(19, 5) = 20 * roundclosest(17, 5) = 15 Signed-off-by: Devarsh Thakkar --- NOTE: This patch

[PATCH v9 07/10] lib: add basic KUnit test for lib/math

2024-05-26 Thread Devarsh Thakkar
c files Signed-off-by: Daniel Latypov Reviewed-by: David Gow [devarsht: Rebase to 6.9, remove kernel.h and change license to GPL] Signed-off-by: Devarsh Thakkar --- Changes since v8: * Remove unrequired header file linux/kernel.h Changes since v7: * Rebase to linux-next, change license to GPL

[PATCH v9 08/10] lib: math_kunit: Add tests for new macros related to rounding to nearest value

2024-05-26 Thread Devarsh Thakkar
Add tests for round_closest_up/down and roundclosest macros which round to nearest multiple of specified argument. These are tested with kunit tool as shared here [1]. [1]: https://gist.github.com/devarsht/3f9042825be3da4e133b8f4eda067876 Signed-off-by: Devarsh Thakkar --- V1->V9 (No cha

[PATCH v9 09/10] media: imagination: Round to closest multiple for cropping region

2024-05-26 Thread Devarsh Thakkar
ection.rst Signed-off-by: Devarsh Thakkar --- V9: No change V8: Update commit message with specification reference V1->V7 (No change, patch introduced in V7) --- drivers/media/platform/imagination/e5010-jpeg-enc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/

[PATCH v9 10/10] gpu: ipu-v3: Use generic macro for rounding closest to specified value

2024-05-26 Thread Devarsh Thakkar
Use generic macro round_closest_up() for rounding closest to specified value instead of using local macro round_closest(). There is no change from functionality point of view as round_closest_up() is functionally same as the previously used local macro round_closest(). Signed-off-by: Devarsh

Re: [PATCH v9 06/10] math.h: Add macros for rounding to closest value

2024-05-28 Thread Devarsh Thakkar
Hi Andy, Thanks for the review. On 28/05/24 02:02, Andy Shevchenko wrote: > On Sun, May 26, 2024 at 11:38:56PM +0530, Devarsh Thakkar wrote: ... >> +/** >> + * round_closest_up - round closest to be multiple of specified value >> (which is >> + *

Re: [PATCH v9 07/10] lib: add basic KUnit test for lib/math

2024-05-28 Thread Devarsh Thakkar
Hi Andy, Thanks for the review. On 28/05/24 02:07, Andy Shevchenko wrote: [..] >> +#include >> +#include >> +#include > > + math.h (where abs()/DIV_ROUND_*()/etc come from?) > I believe I mentioned that. > I did compile and test this, so math.h was indirectly getting included via some othe

Re: [PATCH v9 07/10] lib: add basic KUnit test for lib/math

2024-05-28 Thread Devarsh Thakkar
On 28/05/24 02:08, Andy Shevchenko wrote: > On Mon, May 27, 2024 at 11:37:20PM +0300, Andy Shevchenko wrote: >> On Sun, May 26, 2024 at 11:39:33PM +0530, Devarsh Thakkar wrote: > > ... > >>> +MODULE_LICENSE("GPL"); >> >> modpost

Re: [RFC PATCH 2/3] drm/tidss: Add support for display sharing

2024-05-29 Thread Devarsh Thakkar
Hi Javier, Maxime, Daniel, Sorry for the delay. Please find response inline. On 16/05/24 18:21, Daniel Vetter wrote: > On Wed, May 15, 2024 at 04:45:09PM +0200, Javier Martinez Canillas wrote: >> Devarsh Thakkar writes: [..] >> >> If I understand you correctly, for now t

[PATCH 1/2] dt-bindings: display: ti, am65x-dss: Add support for common1 region

2024-01-15 Thread Devarsh Thakkar
s://www.ti.com/lit/pdf/spruiv7 (Section 14.8.9.1 DSS Registers) AM65x TRM: https://www.ti.com/lit/pdf/spruid7 (Section 12.6.5 DSS Registers) Signed-off-by: Devarsh Thakkar --- .../devicetree/bindings/display/ti/ti,am65x-dss.yaml | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(

[DO NOT MERGE PATCH 2/2] arm64: dts: ti: Add common1 register space for AM62x and AM65x SoCs

2024-01-15 Thread Devarsh Thakkar
AM62x TRM: https://www.ti.com/lit/pdf/spruiv7 (Section 14.8.9.1 DSS Registers) AM65x TRM: https://www.ti.com/lit/pdf/spruid7 (Section 12.6.5 DSS Registers) Signed-off-by: Devarsh Thakkar --- arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 5 +++-- arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 5 +++-- 2 fil

[PATCH 0/2] Add common1 register space for TI Keystone displays

2024-01-15 Thread Devarsh Thakkar
mmon1 region in device-tree bindings seem to be a miss as ideally bindings should enumerate all supported register spaces as done in Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml which also uses TI Keystone display subsystem albeit with some more features. Devarsh Thakkar (2):

Re: [PATCH 1/2] dt-bindings: display: ti,am65x-dss: Add support for common1 region

2024-01-16 Thread Devarsh Thakkar
Hi Conor, Thanks for the review. On 15/01/24 21:47, Conor Dooley wrote: > On Mon, Jan 15, 2024 at 06:27:15PM +0530, Devarsh Thakkar wrote: >> TI keystone display subsystem present in AM65 and other SoCs such as AM62 > > Do all 3 SoCs supported by this binding (am625 am62a7 a

Re: [DO NOT MERGE PATCH 2/2] arm64: dts: ti: Add common1 register space for AM62x and AM65x SoCs

2024-01-16 Thread Devarsh Thakkar
Hi Conor, Thanks for the review. On 15/01/24 21:44, Conor Dooley wrote: > On Mon, Jan 15, 2024 at 06:27:16PM +0530, Devarsh Thakkar wrote: >> This adds common1 register space for AM62x and AM65x SoC's which are using >> TI's Keystone display hardware and supp

[RFC PATCH 0/3] Add display sharing support in tidss

2024-01-16 Thread Devarsh Thakkar
ay Cluster user guide with demo details) [3] : https://git.ti.com/cgit/processor-firmware/ti-linux-firmware/tree/ti-dm/am62pxx/dss_display_share.wkup-r5f0_0.release.strip.out?h=ti-linux-firmware-next Devarsh Thakkar (3): dt-bindings: display: ti,am65x-dss: Add support for display sharing

[RFC PATCH 2/3] drm/tidss: Add support for display sharing

2024-01-16 Thread Devarsh Thakkar
x and programmed using traditional CRTC helpers and rest of video ports and associated resources are removed from feature list accordingly. Signed-off-by: Devarsh Thakkar --- drivers/gpu/drm/tidss/tidss_crtc.c | 120 - drivers/gpu/drm/tidss/tidss_dispc.c

[RFC PATCH 1/3] dt-bindings: display: ti, am65x-dss: Add support for display sharing mode

2024-01-16 Thread Devarsh Thakkar
access. Signed-off-by: Devarsh Thakkar --- .../bindings/display/ti/ti,am65x-dss.yaml | 82 +++ 1 file changed, 82 insertions(+) diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml index

[RFC PATCH 3/3] arm64: dts: ti: k3-am62x: Add overlay to use DSS in display sharing mode

2024-01-16 Thread Devarsh Thakkar
shared mode overlay file so that Linux does not re-use the same while allocating memory. Also add a label for reserved memory region in base device-tree file so that it can be referred back in overlay file. Signed-off-by: Devarsh Thakkar --- arch/arm64/boot/dts/ti/Makefile | 1 + .

Re: [RFC PATCH 1/3] dt-bindings: display: ti,am65x-dss: Add support for display sharing mode

2024-01-18 Thread Devarsh Thakkar
Hi Rob, Thanks for the quick review. On 18/01/24 01:43, Rob Herring wrote: > On Tue, Jan 16, 2024 at 07:11:40PM +0530, Devarsh Thakkar wrote: >> Add support for using TI Keystone DSS hardware present in display >> sharing mode. >> >> TI Keystone DSS hardware support

[PATCH] drm/tidss: Add MIT license along with GPL-2.0

2024-09-12 Thread Devarsh Thakkar
Modify license to include dual licensing as GPL-2.0-only OR MIT license for tidss display driver. This allows other operating system ecosystems such as Zephyr and also the commercial firmwares to refer and derive code from this display driver in a more permissive manner. Signed-off-by: Devarsh

Re: [PATCH] drm/tidss: Add MIT license along with GPL-2.0

2024-09-16 Thread Devarsh Thakkar
Hi Laurent, Thanks for the quick review. On 13/09/24 13:54, Laurent Pinchart wrote: > Hi Devarsh, > > On Thu, Sep 12, 2024 at 10:41:42PM +0530, Devarsh Thakkar wrote: >> Modify license to include dual licensing as GPL-2.0-only OR MIT license for >> tidss display driv

[PATCH v10 00/11] Add V4L2 M2M Driver for E5010 JPEG Encoder

2024-05-30 Thread Devarsh Thakkar
0779-1-devar...@ti.com/ V2: https://lore.kernel.org/all/20230727112546.2201995-1-devar...@ti.com/ Daniel Latypov (1): lib: add basic KUnit test for lib/math Devarsh Thakkar (10): media: dt-bindings: Add Imagination E5010 JPEG Encoder media: imagination: Add E5010 JPEG Encoder driver media: v4l2

[PATCH v10 06/11] math.h: Add macros for rounding to closest value

2024-05-30 Thread Devarsh Thakkar
* round_closest_up(15, 4) = 16 * round_closest_up(14, 4) = 16 * round_closest_down(17, 4) = 16 * round_closest_down(15, 4) = 16 * round_closest_down(14, 4) = 12 * roundclosest(21, 5) = 20 * roundclosest(19, 5) = 20 * roundclosest(17, 5) = 15 Signed-off-by: Devarsh Thakkar --- NOTE: This patch

[PATCH v10 07/11] Documentation: core-api: Add math.h macros and functions

2024-05-30 Thread Devarsh Thakkar
Add documentation for rounding, scaling, absolute value and difference, 32-bit division related macros and functions exported by math.h header file. Signed-off-by: Devarsh Thakkar --- V1->V9 (No change) V10: Patch introduced --- Documentation/core-api/kernel-api.rst | 6 ++ 1 file chan

[PATCH v10 08/11] lib: add basic KUnit test for lib/math

2024-05-30 Thread Devarsh Thakkar
c files Signed-off-by: Daniel Latypov Reviewed-by: David Gow [devarsht: Rebase to 6.9, remove kernel.h, update Kconfig and change license to GPL] Signed-off-by: Devarsh Thakkar --- Changes since v9: * Added Kconfig dependency for KUNIT Changes since v8: * Remove unrequired header file linux/ke

[PATCH v10 09/11] lib: math_kunit: Add tests for new macros related to rounding to nearest value

2024-05-30 Thread Devarsh Thakkar
Add tests for round_closest_up/down and roundclosest macros which round to nearest multiple of specified argument. These are tested with kunit tool as shared here [1]. [1]: https://gist.github.com/devarsht/3f9042825be3da4e133b8f4eda067876 Signed-off-by: Devarsh Thakkar --- V1->V10 (No cha

[PATCH v10 10/11] media: imagination: Round to closest multiple for cropping region

2024-05-30 Thread Devarsh Thakkar
ection.rst Signed-off-by: Devarsh Thakkar --- V10: No change V9: No change V8: Update commit message with specification reference V1->V7 (No change, patch introduced in V7) --- drivers/media/platform/imagination/e5010-jpeg-enc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[PATCH v10 11/11] gpu: ipu-v3: Use generic macro for rounding closest to specified value

2024-05-30 Thread Devarsh Thakkar
Use generic macro round_closest_up() for rounding closest to specified value instead of using local macro round_closest(). There is no change from functionality point of view as round_closest_up() is functionally same as the previously used local macro round_closest(). Signed-off-by: Devarsh

Re: [PATCH v10 06/11] math.h: Add macros for rounding to closest value

2024-05-31 Thread Devarsh Thakkar
Hi Andy, Thanks for the review. On 31/05/24 00:49, Andy Shevchenko wrote: > On Thu, May 30, 2024 at 10:42:25PM +0530, Devarsh Thakkar wrote: >> Add below rounding related macros: >> >> round_closest_up(x, y) : Rounds x to closest multiple of y where y is a >> power

Re: [PATCH v10 08/11] lib: add basic KUnit test for lib/math

2024-05-31 Thread Devarsh Thakkar
On 31/05/24 00:53, Andy Shevchenko wrote: > On Thu, May 30, 2024 at 10:48:10PM +0530, Devarsh Thakkar wrote: >> From: Daniel Latypov >> >> Add basic test coverage for files that don't require any config options: >> * part of math.h (what seem to be the most

Re: [PATCH v10 07/11] Documentation: core-api: Add math.h macros and functions

2024-05-31 Thread Devarsh Thakkar
On 31/05/24 00:51, Andy Shevchenko wrote: > On Thu, May 30, 2024 at 10:47:40PM +0530, Devarsh Thakkar wrote: >> Add documentation for rounding, scaling, absolute value and difference, >> 32-bit division related macros and functions exported by math.h header >> file. >

Re: [PATCH v10 07/11] Documentation: core-api: Add math.h macros and functions

2024-05-31 Thread Devarsh Thakkar
Hi Randy, Thanks for the review. On 31/05/24 04:14, Randy Dunlap wrote: > > > On 5/30/24 10:17 AM, Devarsh Thakkar wrote: >> Add documentation for rounding, scaling, absolute value and difference, >> 32-bit division related macros and functions exported by math.h header

[PATCH v11 00/11] Add V4L2 M2M Driver for E5010 JPEG Encoder

2024-05-31 Thread Devarsh Thakkar
10.4080779-1-devar...@ti.com/ V2: https://lore.kernel.org/all/20230727112546.2201995-1-devar...@ti.com/ Daniel Latypov (1): lib: add basic KUnit test for lib/math Devarsh Thakkar (10): media: dt-bindings: Add Imagination E5010 JPEG Encoder media: imagination: Add E5010 JPEG Encoder driver media: v4l2-j

[PATCH v11 06/11] math.h: Add macros for rounding to closest value

2024-05-31 Thread Devarsh Thakkar
* round_closest_up(15, 4) = 16 * round_closest_up(14, 4) = 16 * round_closest_down(17, 4) = 16 * round_closest_down(15, 4) = 16 * round_closest_down(14, 4) = 12 * roundclosest(21, 5) = 20 * roundclosest(19, 5) = 20 * roundclosest(17, 5) = 15 Signed-off-by: Devarsh Thakkar --- NOTE: This patch

[PATCH v11 07/11] Documentation: core-api: Add math.h macros and functions

2024-05-31 Thread Devarsh Thakkar
Add documentation for rounding, scaling, absolute value and difference, 32-bit division related macros and functions exported by math.h header file. Signed-off-by: Devarsh Thakkar --- V11: Fix title for math function header V10: Patch introduced V1->V9 (No change) --- Documentation/core-

[PATCH v11 08/11] lib: add basic KUnit test for lib/math

2024-05-31 Thread Devarsh Thakkar
c files Signed-off-by: Daniel Latypov Reviewed-by: David Gow [devarsht: Rebase to 6.9, remove kernel.h, update Kconfig and change license to GPL] Signed-off-by: Devarsh Thakkar --- Changes since v10: * Include headers per IWYU principle and add module description Changes since v9: * Added Kco

[PATCH v11 09/11] lib: math_kunit: Add tests for new macros related to rounding to nearest value

2024-05-31 Thread Devarsh Thakkar
Add tests for round_closest_up/down and roundclosest macros which round to nearest multiple of specified argument. These are tested with kunit tool as shared here [1]. [1]: https://gist.github.com/devarsht/3f9042825be3da4e133b8f4eda067876 Signed-off-by: Devarsh Thakkar --- V1->V11 (No cha

  1   2   >